April 2022 - Alsa-devel - mailman.alsa-project.org

Patch "ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM" has been added to the 5.17-stable tree
by gregkh＠linuxfoundation.org 02 Apr '22

02 Apr '22

This is a note to let you know that I've just added the patch titled ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: asoc-sof-intel-fix-null-ptr-dereference-when-enomem.patch and it can be found in the queue-5.17 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From b7fb0ae09009d076964afe4c1a2bde1ee2bd88a9 Mon Sep 17 00:00:00 2001 From: Ammar Faizi <ammarfaizi2(a)gnuweeb.org> Date: Fri, 25 Feb 2022 01:58:36 +0700 Subject: ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM From: Ammar Faizi <ammarfaizi2(a)gnuweeb.org> commit b7fb0ae09009d076964afe4c1a2bde1ee2bd88a9 upstream. Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns -ENOMEM because it leads to a NULL pointer dereference bug. The dmesg says: [ T1387] sof-audio-pci-intel-tgl 0000:00:1f.3: error: memory alloc failed: -12 [ T1387] BUG: kernel NULL pointer dereference, address: 0000000000000000 [ T1387] #PF: supervisor read access in kernel mode [ T1387] #PF: error_code(0x0000) - not-present page [ T1387] PGD 0 P4D 0 [ T1387] Oops: 0000 [#1] PREEMPT SMP NOPTI [ T1387] CPU: 6 PID: 1387 Comm: alsa-sink-HDA A Tainted: G W 5.17.0-rc4-superb-owl-00055-g80d47f5de5e3 [ T1387] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.15 09/15/2021 [ T1387] RIP: 0010:dma_free_noncontiguous+0x37/0x80 [ T1387] Code: [... snip ...] [ T1387] RSP: 0000:ffffc90002b87770 EFLAGS: 00010246 [ T1387] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 [ T1387] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff888101db30d0 [ T1387] RBP: 00000000fffffff4 R08: 0000000000000000 R09: 0000000000000000 [ T1387] R10: 0000000000000000 R11: ffffc90002b874d0 R12: 0000000000000001 [ T1387] R13: 0000000000058000 R14: ffff888105260c68 R15: ffff888105260828 [ T1387] FS: 00007f42e2ffd640(0000) GS:ffff888466b80000(0000) knlGS:0000000000000000 [ T1387] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ T1387] CR2: 0000000000000000 CR3: 000000014acf0003 CR4: 0000000000770ee0 [ T1387] PKRU: 55555554 [ T1387] Call Trace: [ T1387] <TASK> [ T1387] cl_stream_prepare+0x10a/0x120 [snd_sof_intel_hda_common 146addf995b9279ae7f509621078cccbe4f875e1] [... snip ...] [ T1387] </TASK> Cc: Daniel Baluta <daniel.baluta(a)nxp.com> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Cc: Keyon Jie <yang.jie(a)linux.intel.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Rander Wang <rander.wang(a)intel.com> Cc: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: sound-open-firmware(a)alsa-project.org Cc: alsa-devel(a)alsa-project.org Cc: linux-kernel(a)vger.kernel.org Cc: stable(a)vger.kernel.org # v5.2+ Fixes: d16046ffa6de040bf580a64d5f4d0aa18258a854 ("ASoC: SOF: Intel: Add Intel specific HDA firmware loader") Link: https://lore.kernel.org/lkml/20220224145124.15985-1-ammarfaizi2@gnuweeb.org/ # v1 Link: https://lore.kernel.org/lkml/20220224180850.34592-1-ammarfaizi2@gnuweeb.org/ # v2 Link: https://lore.kernel.org/lkml/20220224182818.40301-1-ammarfaizi2@gnuweeb.org/ # v3 Reviewed-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Ammar Faizi <ammarfaizi2(a)gnuweeb.org> Link: https://lore.kernel.org/r/20220224185836.44907-1-ammarfaizi2@gnuweeb.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- sound/soc/sof/intel/hda-loader.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) --- a/sound/soc/sof/intel/hda-loader.c +++ b/sound/soc/sof/intel/hda-loader.c @@ -47,7 +47,7 @@ static struct hdac_ext_stream *cl_stream ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab); if (ret < 0) { dev_err(sdev->dev, "error: memory alloc failed: %d\n", ret); - goto error; + goto out_put; } hstream->period_bytes = 0;/* initialize period_bytes */ @@ -58,22 +58,23 @@ static struct hdac_ext_stream *cl_stream ret = hda_dsp_iccmax_stream_hw_params(sdev, dsp_stream, dmab, NULL); if (ret < 0) { dev_err(sdev->dev, "error: iccmax stream prepare failed: %d\n", ret); - goto error; + goto out_free; } } else { ret = hda_dsp_stream_hw_params(sdev, dsp_stream, dmab, NULL); if (ret < 0) { dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret); - goto error; + goto out_free; } hda_dsp_stream_spib_config(sdev, dsp_stream, HDA_DSP_SPIB_ENABLE, size); } return dsp_stream; -error: - hda_dsp_stream_put(sdev, direction, hstream->stream_tag); +out_free: snd_dma_free_pages(dmab); +out_put: + hda_dsp_stream_put(sdev, direction, hstream->stream_tag); return ERR_PTR(ret); } Patches currently in stable-queue which might be from ammarfaizi2(a)gnuweeb.org are queue-5.17/asoc-sof-intel-fix-null-ptr-dereference-when-enomem.patch

1 0

Cannot run amixer due to: helem (MIXER, 'Mic Boost Volume', 0, 1, 0) appears twice or more
by GitHub issues - opened 02 Apr '22

02 Apr '22

alsa-project/alsa-lib issue #220 was opened from 0jrp0: After a recent update to Debian, I am receiving the following error: ```shell $ amixer ALSA lib simple_none.c:1555:(simple_add1) helem (MIXER,'Mic Boost Volume',0,1,0) appears twice or more amixer: Mixer default load error: Invalid argument ``` I attempted to remove `/var/lib/alsa/asound.state`, but it didn't help. If I run `alsactl restore`, it does nothing. If I run `alsactl store`, it just dumps the duplicate Mic Boost Volume entry again. I have an HDMI device that I don't use where this is possibly coming from. I attempted to blacklist the kernel module for `snd_hda_codec_hdmi`, but it didn't help (nor could I figure out how to persist the black list across reboots even after modifying `/etc/modprobe.d/`). My current setup is using `pipewire` using the `pipewire-pulse` binary which connects up to `alsa`. Some info: ``` $ pactl list short sinks 89 alsa_output.pci-0000_00_1f.3.pro-output-0 PipeWire s32le 2ch 48000Hz SUSPENDED 90 alsa_output.pci-0000_00_1f.3.pro-output-4 PipeWire s32le 2ch 48000Hz SUSPENDED 111 bluez_output.04_52_C7_B0_B3_08.a2dp-sink PipeWire s16le 2ch 48000Hz SUSPENDED ``` ``` $ sudo dmesg |grep snd [ 24.786073] snd_hda_intel 0000:00:1f.3: enabling device (0140 -> 0142) [ 24.786637] snd_hda_intel 0000:65:00.1: enabling device (0140 -> 0142) [ 24.786746] snd_hda_intel 0000:65:00.1: Disabling MSI [ 24.786790] snd_hda_intel 0000:65:00.1: Handle vga_switcheroo audio client [ 24.814739] snd_hda_codec_generic hdaudioC0D0: autoconfig for Generic: line_outs=1 (0x14/0x0/0x0/0x0/0x0) type:line [ 24.814745] snd_hda_codec_generic hdaudioC0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 24.814748] snd_hda_codec_generic hdaudioC0D0: hp_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 24.814751] snd_hda_codec_generic hdaudioC0D0: mono: mono_out=0x0 [ 24.814752] snd_hda_codec_generic hdaudioC0D0: inputs: [ 24.814754] snd_hda_codec_generic hdaudioC0D0: Mic=0x18 [ 24.814756] snd_hda_codec_generic hdaudioC0D0: Line=0x1a [ 24.832905] snd_hda_codec_generic hdaudioC0D1: autoconfig for Generic: line_outs=1 (0x1b/0x0/0x0/0x0/0x0) type:speaker [ 24.832912] snd_hda_codec_generic hdaudioC0D1: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 24.832914] snd_hda_codec_generic hdaudioC0D1: hp_outs=1 (0x21/0x0/0x0/0x0/0x0) [ 24.832916] snd_hda_codec_generic hdaudioC0D1: mono: mono_out=0x0 [ 24.832917] snd_hda_codec_generic hdaudioC0D1: inputs: [ 24.832918] snd_hda_codec_generic hdaudioC0D1: Mic=0x19 [ 24.837834] snd_hda_intel 0000:00:1f.3: control 2:0:0:Capture Volume:0 is already present [ 24.837840] snd_hda_intel 0000:00:1f.3: control 2:0:0:Capture Switch:0 is already present [ 24.837843] snd_hda_intel 0000:00:1f.3: control 2:0:0:Mic Boost Volume:0 is already present [ 24.966257] usbcore: registered new interface driver snd-usb-audio ``` ``` $ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: PCH [HDA Intel PCH], device 0: Generic Analog [Generic Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 4: Generic Analog [Generic Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: NVidia [HDA NVidia], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: NVidia [HDA NVidia], device 7: HDMI 1 [HDMI 1] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: NVidia [HDA NVidia], device 8: HDMI 2 [HDMI 2] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: NVidia [HDA NVidia], device 9: HDMI 3 [HDMI 3] Subdevices: 1/1 Subdevice #0: subdevice #0 ``` ``` $ lspci -v ... 00:1f.3 Audio device: Intel Corporation 200 Series PCH HD Audio Subsystem: Lenovo 200 Series PCH HD Audio Flags: bus master, fast devsel, latency 32, IRQ 65, NUMA node 0, IOMMU group 21 Memory at 43ffff20000 (64-bit, non-prefetchable) [size=16K] Memory at 43ffff00000 (64-bit, non-prefetchable) [size=64K] Capabilities: <access denied> Kernel driver in use: snd_hda_intel Kernel modules: snd_hda_intel ... ``` ``` $ inxi -SAxc 0 System: Host: {redacted} Kernel: 5.15.15-{redacted}-amd64 x86_64 bits: 64 compiler: gcc v: 11.2.0 Desktop: awesome 4.3 Distro: Debian GNU/Linux 12 Audio: Device-1: Intel 200 Series PCH HD Audio vendor: Lenovo driver: snd_hda_intel v: kernel bus-ID: 00:1f.3 Device-2: NVIDIA GP107GL High Definition Audio driver: snd_hda_intel v: kernel bus-ID: 65:00.1 Device-3: Logitech Webcam C930e type: USB driver: snd-usb-audio,uvcvideo bus-ID: 1-14:9 Sound Server-1: ALSA v: k5.15.15-1rodete2-amd64 running: yes Sound Server-2: PulseAudio v: 15.0 running: no Sound Server-3: PipeWire v: 0.3.47 running: yes ``` ``` $ head -n 1 /proc/asound/card0/codec* ==> /proc/asound/card0/codec#0 <== Codec: Realtek Generic ==> /proc/asound/card0/codec#1 <== Codec: Realtek Generic ``` ``` $ /bin/cat /etc/modprobe.d/alsa-base.conf options snd-hda-intel model=generic ``` ``` $ aplay -L null Discard all samples (playback) or generate zero samples (capture) lavrate Rate Converter Plugin Using Libav/FFmpeg Library samplerate Rate Converter Plugin Using Samplerate Library speexrate Rate Converter Plugin Using Speex Resampler jack JACK Audio Connection Kit oss Open Sound System pulse PulseAudio Sound Server upmix Plugin for channel upmix (4,6,8) vdownmix Plugin for channel downmix (stereo) with a simple spacialization hw:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog Direct hardware device without any conversions hw:CARD=PCH,DEV=4 HDA Intel PCH, Generic Analog Direct hardware device without any conversions plughw:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog Hardware device with all software conversions plughw:CARD=PCH,DEV=4 HDA Intel PCH, Generic Analog Hardware device with all software conversions default:CARD=PCH HDA Intel PCH, Generic Analog Default Audio Device sysdefault:CARD=PCH HDA Intel PCH, Generic Analog Default Audio Device front:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog Front output / input surround21:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 2.1 Surround output to Front and Subwoofer speakers surround40:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 4.0 Surround output to Front and Rear speakers surround41:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 4.1 Surround output to Front, Rear and Subwoofer speakers surround50:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 5.0 Surround output to Front, Center and Rear speakers surround51:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 5.1 Surround output to Front, Center, Rear and Subwoofer speakers surround71:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog 7.1 Surround output to Front, Center, Side, Rear and Woofer speakers dmix:CARD=PCH,DEV=0 HDA Intel PCH, Generic Analog Direct sample mixing device dmix:CARD=PCH,DEV=4 HDA Intel PCH, Generic Analog Direct sample mixing device usbstream:CARD=PCH HDA Intel PCH USB Stream Output usbstream:CARD=C930e Logitech Webcam C930e USB Stream Output hw:CARD=NVidia,DEV=3 HDA NVidia, HDMI 0 Direct hardware device without any conversions hw:CARD=NVidia,DEV=7 HDA NVidia, HDMI 1 Direct hardware device without any conversions hw:CARD=NVidia,DEV=8 HDA NVidia, HDMI 2 Direct hardware device without any conversions hw:CARD=NVidia,DEV=9 HDA NVidia, HDMI 3 Direct hardware device without any conversions plughw:CARD=NVidia,DEV=3 HDA NVidia, HDMI 0 Hardware device with all software conversions plughw:CARD=NVidia,DEV=7 HDA NVidia, HDMI 1 Hardware device with all software conversions plughw:CARD=NVidia,DEV=8 HDA NVidia, HDMI 2 Hardware device with all software conversions plughw:CARD=NVidia,DEV=9 HDA NVidia, HDMI 3 Hardware device with all software conversions hdmi:CARD=NVidia,DEV=0 HDA NVidia, HDMI 0 HDMI Audio Output hdmi:CARD=NVidia,DEV=1 HDA NVidia, HDMI 1 HDMI Audio Output hdmi:CARD=NVidia,DEV=2 HDA NVidia, HDMI 2 HDMI Audio Output hdmi:CARD=NVidia,DEV=3 HDA NVidia, HDMI 3 HDMI Audio Output dmix:CARD=NVidia,DEV=3 HDA NVidia, HDMI 0 Direct sample mixing device dmix:CARD=NVidia,DEV=7 HDA NVidia, HDMI 1 Direct sample mixing device dmix:CARD=NVidia,DEV=8 HDA NVidia, HDMI 2 Direct sample mixing device dmix:CARD=NVidia,DEV=9 HDA NVidia, HDMI 3 Direct sample mixing device usbstream:CARD=NVidia HDA NVidia USB Stream Output ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/220 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/6] add internal static library to include common utilities
by GitHub pull_request - opened 01 Apr '22

01 Apr '22

alsa-project/alsa-gobject pull request #67 was opened from takaswie: Current implementation of included libraries have duplicated codes to operate over sysfs by libudev and so. It's inconvenient in a point of maintenance. This patchset adds internal static library to include such codes. ``` Takashi Sakamoto (6): utils: build internal static library including common utilities utils: add utility to compute integer value from string literal utils: add utilities to allocate string information for device utils: add utilitiy to generate list of sysnum by prefix of sysname utils: add utilities to request control ioctl utils: add utility macros to generate GError with file domain src/ctl/card.c | 5 +- src/ctl/meson.build | 2 +- src/ctl/query.c | 261 ++---------------------------- src/hwdep/meson.build | 2 +- src/hwdep/query.c | 306 +++-------------------------------- src/meson.build | 1 + src/rawmidi/meson.build | 2 +- src/rawmidi/query.c | 324 ++++---------------------------------- src/rawmidi/stream-pair.c | 5 +- src/seq/meson.build | 2 +- src/seq/query.c | 87 ++-------- src/seq/user-client.c | 5 +- src/timer/meson.build | 2 +- src/timer/query.c | 105 +++--------- src/timer/user-instance.c | 5 +- src/utils/ioctl.c | 45 ++++++ src/utils/meson.build | 23 +++ src/utils/string.c | 47 ++++++ src/utils/sysfs.c | 176 +++++++++++++++++++++ src/utils/utils.h | 176 +++++++++++++++++++++ 20 files changed, 578 insertions(+), 1003 deletions(-) create mode 100644 src/utils/ioctl.c create mode 100644 src/utils/meson.build create mode 100644 src/utils/string.c create mode 100644 src/utils/sysfs.c create mode 100644 src/utils/utils.h ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/67 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/67.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0