December 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH AUTOSEL 6.0 1/7] ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown"
by Sasha Levin 31 Dec '22

31 Dec '22

From: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> [ Upstream commit 44fda61d2bcfb74a942df93959e083a4e8eff75f ] The unregister machine drivers call is not safe to do when kexec is used. Kexec-lite gets blocked with following backtrace: [ 84.943749] Freezing user space processes ... (elapsed 0.111 seconds) done. [ 246.784446] INFO: task kexec-lite:5123 blocked for more than 122 seconds. [ 246.819035] Call Trace: [ 246.821782] <TASK> [ 246.824186] __schedule+0x5f9/0x1263 [ 246.828231] schedule+0x87/0xc5 [ 246.831779] snd_card_disconnect_sync+0xb5/0x127 ... [ 246.889249] snd_sof_device_shutdown+0xb4/0x150 [ 246.899317] pci_device_shutdown+0x37/0x61 [ 246.903990] device_shutdown+0x14c/0x1d6 [ 246.908391] kernel_kexec+0x45/0xb9 This reverts commit 83bfc7e793b555291785136c3ae86abcdc046887. Reported-by: Ricardo Ribalda <ribalda(a)chromium.org> Cc: Ricardo Ribalda <ribalda(a)chromium.org> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Link: https://lore.kernel.org/r/20221209114529.3909192-3-kai.vehmanen@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/core.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c index c99b5e6c026c..694a2d94a222 100644 --- a/sound/soc/sof/core.c +++ b/sound/soc/sof/core.c @@ -472,19 +472,10 @@ EXPORT_SYMBOL(snd_sof_device_remove); int snd_sof_device_shutdown(struct device *dev) { struct snd_sof_dev *sdev = dev_get_drvdata(dev); - struct snd_sof_pdata *pdata = sdev->pdata; if (IS_ENABLED(CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE)) cancel_work_sync(&sdev->probe_work); - /* - * make sure clients and machine driver(s) are unregistered to force - * all userspace devices to be closed prior to the DSP shutdown sequence - */ - sof_unregister_clients(sdev); - - snd_sof_machine_unregister(sdev, pdata); - if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) return snd_sof_shutdown(sdev); -- 2.35.1

1 2

[PATCH] pcm: rate: fix last_commit_ptr boundary wrapping
by Alan Young 30 Dec '22

30 Dec '22

Wrap last_commit_ptr using boundary. Was just wrapped to 0, which is correct only if the buffer size, and hence the boundary, is an integer multiple of the period size. Signed-off-by: Alan Young <consult.awy(a)gmail.com> Fixes: 467d69c5bc1 ("Fix CPU hog with combination of rate plugin") Fixes: 29041c52207 ("fix infinite draining of the rate plugin in SND_PCM_NONBLOCK mode") --- src/pcm/pcm_rate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pcm/pcm_rate.c b/src/pcm/pcm_rate.c index e5d8eddd..c8076859 100644 --- a/src/pcm/pcm_rate.c +++ b/src/pcm/pcm_rate.c @@ -1018,7 +1018,7 @@ static int snd_pcm_rate_sync_playback_area(snd_pcm_t *pcm, snd_pcm_uframes_t app slave_size -= rate->gen.slave->period_size; rate->last_commit_ptr += pcm->period_size; if (rate->last_commit_ptr >= pcm->boundary) - rate->last_commit_ptr = 0; + rate->last_commit_ptr -= pcm->boundary; } return 0; } @@ -1163,7 +1163,7 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm) if (commit_err == 1) { rate->last_commit_ptr += psize; if (rate->last_commit_ptr >= pcm->boundary) - rate->last_commit_ptr = 0; + rate->last_commit_ptr -= pcm->boundary; } else if (commit_err == 0) { if (pcm->mode & SND_PCM_NONBLOCK) { commit_err = -EAGAIN; -- 2.31.1

2 1

Tthinkpad Z13 No Sound From Builtin Laptop Speakers - Possible Problems From Codecs ALC287 And ALC3306
by ben＠0x1bi.xyz 30 Dec '22

30 Dec '22

Hello, all; I've discovered that on the Thinkpad Z13 latpop the builtin speakers don't work. When plugging in headphones through the headphone jack sound is played from the headphones, however no sound has ever been heard from the speakers. There's already been many complaints leveled against the codecs used by this laptop, namely ALC3306 and ALC287 (the Lenovo spec sheet says the codec used is ALC3306 however alsa displays ALC287). I'm wondering if there's anything I can do to resolve this issue, and more importantly how can this issue be prevented for other laptops with similar specs. Below is an output of some relevant commands $ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: Generic [HD-Audio Generic], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: Generic [HD-Audio Generic], device 7: HDMI 1 [HDMI 1] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: Generic [HD-Audio Generic], device 8: HDMI 2 [HDMI 2] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: Generic [HD-Audio Generic], device 9: HDMI 3 [HDMI 3] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: Generic [HD-Audio Generic], device 10: HDMI 4 [HDMI 4] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: Generic_1 [HD-Audio Generic], device 0: ALC287 Analog [ALC287 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 $ aplay -L null Discard all samples (playback) or generate zero samples (capture) default Default ALSA Output (currently PipeWire Media Server) pipewire PipeWire Sound Server hdmi:CARD=Generic,DEV=0 HD-Audio Generic, HDMI 0 HDMI Audio Output hdmi:CARD=Generic,DEV=1 HD-Audio Generic, HDMI 1 HDMI Audio Output hdmi:CARD=Generic,DEV=2 HD-Audio Generic, HDMI 2 HDMI Audio Output hdmi:CARD=Generic,DEV=3 HD-Audio Generic, HDMI 3 HDMI Audio Output hdmi:CARD=Generic,DEV=4 HD-Audio Generic, HDMI 4 HDMI Audio Output sysdefault:CARD=Generic_1 HD-Audio Generic, ALC287 Analog Default Audio Device front:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog Front output / input surround21:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 2.1 Surround output to Front and Subwoofer speakers surround40:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 4.0 Surround output to Front and Rear speakers surround41:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 4.1 Surround output to Front, Rear and Subwoofer speakers surround50:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 5.0 Surround output to Front, Center and Rear speakers surround51:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 5.1 Surround output to Front, Center, Rear and Subwoofer speakers surround71:CARD=Generic_1,DEV=0 HD-Audio Generic, ALC287 Analog 7.1 Surround output to Front, Center, Side, Rear and Woofer speakersnull Thanks in advance. Ben Raskin

1 0

[PATCH v1] ASoC: wm8904: fix wrong outputs volume after power reactivation
by Francesco Dolcini 29 Dec '22

29 Dec '22

From: Emanuele Ghidoli <emanuele.ghidoli(a)toradex.com> Restore volume after charge pump and PGA activation to ensure that volume settings are correctly applied when re-enabling codec from SND_SOC_BIAS_OFF state. CLASS_W, CHARGE_PUMP and POWER_MANAGEMENT_2 register configuration affect how the volume register are applied and must be configured first. Fixes: a91eb199e4dc ("ASoC: Initial WM8904 CODEC driver") Link: https://lore.kernel.org/all/c7864c35-738c-a867-a6a6-ddf9f98df7e7@gmail.com/ Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli(a)toradex.com> Signed-off-by: Francesco Dolcini <francesco.dolcini(a)toradex.com> --- sound/soc/codecs/wm8904.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index ca6a01a230af..791d8738d1c0 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -697,6 +697,7 @@ static int out_pga_event(struct snd_soc_dapm_widget *w, int dcs_mask; int dcs_l, dcs_r; int dcs_l_reg, dcs_r_reg; + int an_out_reg; int timeout; int pwr_reg; @@ -712,6 +713,7 @@ static int out_pga_event(struct snd_soc_dapm_widget *w, dcs_mask = WM8904_DCS_ENA_CHAN_0 | WM8904_DCS_ENA_CHAN_1; dcs_r_reg = WM8904_DC_SERVO_8; dcs_l_reg = WM8904_DC_SERVO_9; + an_out_reg = WM8904_ANALOGUE_OUT1_LEFT; dcs_l = 0; dcs_r = 1; break; @@ -720,6 +722,7 @@ static int out_pga_event(struct snd_soc_dapm_widget *w, dcs_mask = WM8904_DCS_ENA_CHAN_2 | WM8904_DCS_ENA_CHAN_3; dcs_r_reg = WM8904_DC_SERVO_6; dcs_l_reg = WM8904_DC_SERVO_7; + an_out_reg = WM8904_ANALOGUE_OUT2_LEFT; dcs_l = 2; dcs_r = 3; break; @@ -792,6 +795,10 @@ static int out_pga_event(struct snd_soc_dapm_widget *w, snd_soc_component_update_bits(component, reg, WM8904_HPL_ENA_OUTP | WM8904_HPR_ENA_OUTP, WM8904_HPL_ENA_OUTP | WM8904_HPR_ENA_OUTP); + + /* Update volume, requires PGA to be powered */ + val = snd_soc_component_read(component, an_out_reg); + snd_soc_component_write(component, an_out_reg, val); break; case SND_SOC_DAPM_POST_PMU: -- 2.25.1

3 2

[PATCH 0/2] Add new AMP MAX98360A for RT5682S
by tongjian 29 Dec '22

29 Dec '22

Add MAX98360A for RT5682S, MAX98360A works same as rt1019. So, it can be supported. tongjian (2): ASoC: mediatek: mt8186: support rt5682s_max98360 ASoC: dt-bindings: mt8186-mt6366: add new compatible for max98360a .../sound/mt8186-mt6366-rt1019-rt5682s.yaml | 1 + .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 22 ++++++++++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.25.1

4 7

[PATCH] ASoC: rt9120: Make dev PM runtime bind AsoC component PM
by cy_huang 29 Dec '22

29 Dec '22

From: ChiYuan Huang <cy_huang(a)richtek.com> RT9120 uses PM runtime autosuspend to decrease the frequently on/off spent time. This exists one case, when pcm is closed and dev PM is waiting for autosuspend time expired to enter runtime suspend state. At the mean time, system is going to enter suspend, dev PM runtime suspend won't be called. It makes the rt9120 suspend consumption current not as expected. This patch can fix the rt9120 dev PM issue during runtime autosuspend and system suspend by binding dev PM runtime and ASoC component PM. Fixes: 80b949f332e3 ("ASoC: rt9120: Use pm_runtime and regcache to optimize 'pwdnn' logic") Signed-off-by: ChiYuan Huang <cy_huang(a)richtek.com> --- sound/soc/codecs/rt9120.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/soc/codecs/rt9120.c b/sound/soc/codecs/rt9120.c index 644300e..fcf4fba 100644 --- a/sound/soc/codecs/rt9120.c +++ b/sound/soc/codecs/rt9120.c @@ -177,8 +177,20 @@ static int rt9120_codec_probe(struct snd_soc_component *comp) return 0; } +static int rt9120_codec_suspend(struct snd_soc_component *comp) +{ + return pm_runtime_force_suspend(comp->dev); +} + +static int rt9120_codec_resume(struct snd_soc_component *comp) +{ + return pm_runtime_force_resume(comp->dev); +} + static const struct snd_soc_component_driver rt9120_component_driver = { .probe = rt9120_codec_probe, + .suspend = rt9120_codec_suspend, + .resume = rt9120_codec_resume, .controls = rt9120_snd_controls, .num_controls = ARRAY_SIZE(rt9120_snd_controls), .dapm_widgets = rt9120_dapm_widgets, -- 2.7.4

2 1

[PATCH] ASoC: mediatek: mt8186: Add machine support for max98357a
by Allen-KH Cheng 29 Dec '22

29 Dec '22

Add support for mt8186 with mt6366 and max98357a. Signed-off-by: Allen-KH Cheng <allen-kh.cheng(a)mediatek.com> --- sound/soc/mediatek/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index 363fa4d47680..7bdb0ded831c 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig @@ -182,9 +182,10 @@ config SND_SOC_MT8186_MT6366_DA7219_MAX98357 If unsure select "N". config SND_SOC_MT8186_MT6366_RT1019_RT5682S - tristate "ASoC Audio driver for MT8186 with RT1019 RT5682S codec" + tristate "ASoC Audio driver for MT8186 with RT1019 RT5682S MAX98357A/MAX98360 codec" depends on I2C && GPIOLIB depends on SND_SOC_MT8186 && MTK_PMIC_WRAP + select SND_SOC_MAX98357A select SND_SOC_MT6358 select SND_SOC_RT1015P select SND_SOC_RT5682S -- 2.18.0

2 1

[PATCH 1/2] ASoC: dt-bindings: cirrus,cs35l41: add interrupts
by Krzysztof Kozlowski 29 Dec '22

29 Dec '22

Both DTS (SM8250 and SM8350 based Sony Xperia boards) and Linux driver mention interrupt, so allow it to fix: sm8350-sony-xperia-sagami-pdx215.dtb: cs35l41@41: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml index 82062d80d700..919d7f16f24c 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml @@ -22,6 +22,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + '#sound-dai-cells': description: The first cell indicating the audio interface. -- 2.34.1

3 4

[bugzilla-daemon@kernel.org: [Bug 216861] New: sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157]
by Borislav Petkov 29 Dec '22

29 Dec '22

Forwarding to the ALSA ML. ----- Forwarded message from bugzilla-daemon(a)kernel.org ----- Date: Thu, 29 Dec 2022 10:07:51 +0000 From: bugzilla-daemon(a)kernel.org To: bp(a)alien8.de Subject: [Bug 216861] New: sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157 Message-ID: <bug-216861-6385(a)https.bugzilla.kernel.org/> https://bugzilla.kernel.org/show_bug.cgi?id=216861 URL: https://bugzilla.altlinux.org/44690 Bug ID: 216861 Summary: sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157 Product: Platform Specific/Hardware Version: 2.5 Kernel Version: 5.10.157 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: x86-64 Assignee: platform_x86_64(a)kernel-bugs.osdl.org Reporter: zagagyka(a)basealt.ru CC: broonie(a)kernel.org, perex(a)perex.cz Regression: Yes Created attachment 303497 --> https://bugzilla.kernel.org/attachment.cgi?id=303497&action=edit pulseaudio.log Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz # lspci 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) Subsystem: Acer Incorporated [ALI] Device 148c Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] Capabilities: [50] Power Management version 3 Capabilities: [80] Vendor Specific Information: Len=14 <?> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ Kernel driver in use: sof-audio-pci I am attaching the pulseaudio and dmesg logs This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157 Bisection revealed the commit being reverted: c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit commit c34db0d6b88b1da95e7ab3353e674f4f574cccee Author: Richard Fitzgerald <rf(a)opensource.cirrus.com> Date: Fri Nov 4 13:22:13 2022 +0000 ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open() [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ] The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot() and used by later code that depends on the TDM settings. So __soc_pcm_open() should not be obliterating those mask values. The code in __soc_pcm_hw_params() uses these masks to calculate the active channels so that only the AIF_IN/AIF_OUT widgets for the active TDM slots are enabled. The zeroing of the masks in __soc_pcm_open() disables this functionality so all AIF widgets were enabled even for channels that are not assigned to a TDM slot. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> Fixes: 2e5894d73789 ("ASoC: pcm: Add support for DAI multicodec") Link: https://lore.kernel.org/r/20221104132213.121847-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> sound/soc/soc-pcm.c | 5 ----- 1 file changed, 5 deletions(-) Original bug report: https://bugzilla.altlinux.org/44690 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ----- End forwarded message ----- -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

1 0

[PATCH v2 0/3] Add support for XCVR on i.MX93 platform
by Chancel Liu 29 Dec '22

29 Dec '22

This patchset supports XCVR on i.MX93 platform. changes in v2: - remove unnecessary code which causes kernel test robot reporting error Chancel Liu (3): ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX93 platform ASoC: fsl_xcvr: Add support for i.MX93 platform ASoC: fsl_xcvr: Add constraints of period size while using eDMA .../devicetree/bindings/sound/fsl,xcvr.yaml | 1 + sound/soc/fsl/fsl_xcvr.c | 155 ++++++++++++------ sound/soc/fsl/fsl_xcvr.h | 7 + 3 files changed, 115 insertions(+), 48 deletions(-) -- 2.25.1

2 4