January 2022 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH v1 1/1] ASoC: dpcm: prevent snd_soc_dpcm use after free
by Greg KH 24 Jan '22

24 Jan '22

On Fri, Jan 21, 2022 at 11:16:44PM +0000, Will McVicker wrote: > From: KaiChieh Chuang <kaichieh.chuang(a)mediatek.com> > > [ Upstream commit a9764869779081e8bf24da07ac040e8f3efcf13a ] > > The dpcm get from fe_clients/be_clients > may be free before use > > Add a spin lock at snd_soc_card level, > to protect the dpcm instance. > The lock may be used in atomic context, so use spin lock. > > Use irq spin lock version, > since the lock may be used in interrupts. > > possible race condition between > void dpcm_be_disconnect( > ... > list_del(&dpcm->list_be); > list_del(&dpcm->list_fe); > kfree(dpcm); > ... > > and > for_each_dpcm_fe() > for_each_dpcm_be*() > > race condition example > Thread 1: > snd_soc_dapm_mixer_update_power() > -> soc_dpcm_runtime_update() > -> dpcm_be_disconnect() > -> kfree(dpcm); > Thread 2: > dpcm_fe_dai_trigger() > -> dpcm_be_dai_trigger() > -> snd_soc_dpcm_can_be_free_stop() > -> if (dpcm->fe == fe) > > Excpetion Scenario: > two FE link to same BE > FE1 -> BE > FE2 -> > > Thread 1: switch of mixer between FE2 -> BE > Thread 2: pcm_stop FE1 > > Exception: > > Unable to handle kernel paging request at virtual address dead0000000000e0 > > pc=<> [<ffffff8960e2cd10>] dpcm_be_dai_trigger+0x29c/0x47c > sound/soc/soc-pcm.c:3226 > if (dpcm->fe == fe) > lr=<> [<ffffff8960e2f694>] dpcm_fe_dai_do_trigger+0x94/0x26c > > Backtrace: > [<ffffff89602dba80>] notify_die+0x68/0xb8 > [<ffffff896028c7dc>] die+0x118/0x2a8 > [<ffffff89602a2f84>] __do_kernel_fault+0x13c/0x14c > [<ffffff89602a27f4>] do_translation_fault+0x64/0xa0 > [<ffffff8960280cf8>] do_mem_abort+0x4c/0xd0 > [<ffffff8960282ad0>] el1_da+0x24/0x40 > [<ffffff8960e2cd10>] dpcm_be_dai_trigger+0x29c/0x47c > [<ffffff8960e2f694>] dpcm_fe_dai_do_trigger+0x94/0x26c > [<ffffff8960e2edec>] dpcm_fe_dai_trigger+0x3c/0x44 > [<ffffff8960de5588>] snd_pcm_do_stop+0x50/0x5c > [<ffffff8960dded24>] snd_pcm_action+0xb4/0x13c > [<ffffff8960ddfdb4>] snd_pcm_drop+0xa0/0x128 > [<ffffff8960de69bc>] snd_pcm_common_ioctl+0x9d8/0x30f0 > [<ffffff8960de1cac>] snd_pcm_ioctl_compat+0x29c/0x2f14 > [<ffffff89604c9d60>] compat_SyS_ioctl+0x128/0x244 > [<ffffff8960283740>] el0_svc_naked+0x34/0x38 > [<ffffffffffffffff>] 0xffffffffffffffff > > Signed-off-by: KaiChieh Chuang <kaichieh.chuang(a)mediatek.com> > Signed-off-by: Mark Brown <broonie(a)kernel.org> > [willmcvicker: move spinlock to bottom of struct snd_soc_card] > Signed-off-by: Will McVicker <willmcvicker(a)google.com> > Cc: stable(a)vger.kernel.org # 4.19+ > --- > include/sound/soc.h | 2 ++ > sound/soc/soc-core.c | 1 + > sound/soc/soc-pcm.c | 40 +++++++++++++++++++++++++++++++++------- > 3 files changed, 36 insertions(+), 7 deletions(-) Now queued up, thanks. greg k-h

1 0

HP Spectre X360 fails to find soundcard
by GitHub issues - opened 23 Jan '22

23 Jan '22

alsa-project/alsa-ucm-conf issue #135 was opened from bornmw: HP Spectre x360 Convertible 13t-aw200 Vanilla kernel 5.16.2 alsa-ucm-conf-1.2.6.3 alsa-lib-1.2.6.1 alsa-utils-1.2.6 pulseaudio-15.0 [pulseverbose.log](https://github.com/alsa-project/alsa-ucm-conf/files/79198… A combination of these commands plays noise successfully: alsaucm -c sof-soundwire set _verb HiFi set _enadev Speaker speaker-test -Dhw:0,2 -c2 -r48000 $ aplay -Ll null Discard all samples (playback) or generate zero samples (capture) pulse PulseAudio Sound Server upmix Plugin for channel upmix (4,6,8) vdownmix Plugin for channel downmix (stereo) with a simple spacialization sysdefault:CARD=sofsoundwire sof-soundwire, Default Audio Device usbstream:CARD=sofsoundwire sof-soundwire USB Stream Output **** List of PLAYBACK Hardware Devices **** card 0: sofsoundwire [sof-soundwire], device 0: Headphone (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: sofsoundwire [sof-soundwire], device 2: SDW1-speakers (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: sofsoundwire [sof-soundwire], device 5: HDMI1 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: sofsoundwire [sof-soundwire], device 6: HDMI2 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: sofsoundwire [sof-soundwire], device 7: HDMI3 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: sofsoundwire [sof-soundwire], device 8: HDMI4 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/135 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH AUTOSEL 5.16 50/52] ASoC: amd: acp: acp-mach: Change default RT1019 amp dev id
by Sasha Levin 22 Jan '22

22 Jan '22

From: Ajit Kumar Pandey <AjitKumar.Pandey(a)amd.com> [ Upstream commit 7112550890d7e415188a3351ec0a140be60f6deb ] RT1019 components was initially registered with i2c1 and i2c2 but now changed to i2c0 and i2c1 in most of our AMD platforms. Change default rt1019 components to 10EC1019:00 and 10EC1019:01 which is aligned with most of AMD machines. Any exception to rt1019 device ids in near future board design can be handled using dmi based quirk for that machine. Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey(a)amd.com> Link: https://lore.kernel.org/r/20220106150525.396170-1-AjitKumar.Pandey@amd.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/amd/acp/acp-mach-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c index 7785f12aa0065..7386e5bb61b5e 100644 --- a/sound/soc/amd/acp/acp-mach-common.c +++ b/sound/soc/amd/acp/acp-mach-common.c @@ -268,8 +268,8 @@ static const struct snd_soc_ops acp_card_rt5682s_ops = { /* Declare RT1019 codec components */ SND_SOC_DAILINK_DEF(rt1019, - DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:01", "rt1019-aif"), - COMP_CODEC("i2c-10EC1019:02", "rt1019-aif"))); + DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:00", "rt1019-aif"), + COMP_CODEC("i2c-10EC1019:01", "rt1019-aif"))); static const struct snd_soc_dapm_route rt1019_map_lr[] = { { "Left Spk", NULL, "Left SPO" }, @@ -278,11 +278,11 @@ static const struct snd_soc_dapm_route rt1019_map_lr[] = { static struct snd_soc_codec_conf rt1019_conf[] = { { - .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"), + .dlc = COMP_CODEC_CONF("i2c-10EC1019:00"), .name_prefix = "Left", }, { - .dlc = COMP_CODEC_CONF("i2c-10EC1019:02"), + .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"), .name_prefix = "Right", }, }; -- 2.34.1

2 2

[PATCH v3 00/10] Support Spi in i2c-multi-instantiate driver
by Stefan Binding 21 Jan '22

21 Jan '22

Add support for SPI bus in the i2c-multi-instantiate driver as upcoming laptops will need to multi instantiate SPI devices from a single device node, which has multiple SpiSerialBus entries at the ACPI table. With the new SPI support, i2c-multi-instantiate becomes bus-multi-instantiate and is moved to the ACPI folder. The intention is to support the SPI bus by re-using the current I2C multi instantiate, instead of creating a new SPI multi instantiate, to make it possible for peripherals that can be controlled by I2C or SPI to have the same HID at the ACPI table. The new driver (Bus multi instantiate, bmi) checks for the hard-coded bus type and returns -ENODEV in case of zero devices found for that bus. In the case of automatic bus detection, the driver will give preference to I2C. The expectation is for a device node in the ACPI table to have multiple I2cSerialBus only or multiple SpiSerialBus only, not a mix of both; and for the case where there are both entries in one device node, only the I2C ones would be probed. This new bus multi instantiate will be used in CS35L41 HDA new driver. Changes since V2: - Fix review comments in bus-multi-instantiate - Modified spi code to export new helper to allocate spi device based on ACPI - Add api in spi code to count number of spi devices in ACPI - Add patch to add support for HP Laptops - Add patch to add support for various CS35L41 devices in scan.c and bus-multi-instantiate from previous chain: https://lore.kernel.org/all/20220117160830.709403-1-tanureal@opensource.cir… Lucas Tanure (5): platform/x86: i2c-multi-instantiate: Move it to drivers/acpi folder ACPI: i2c-multi-instantiate: Rename it for a generic bus driver name ACPI: bus-multi-instantiate: Reorganize I2C functions ALSA: hda/realtek: Add support for HP Laptops ACPI / scan: Create platform device for CS35L41 Stefan Binding (5): spi: Make spi_alloc_device and spi_add_device public again spi: Create helper API to lookup ACPI info for spi device spi: Support selection of the index of the ACPI Spi Resource before alloc spi: Add API to count spi acpi resources ACPI: bus-multi-instantiate: Add SPI support MAINTAINERS | 4 +- drivers/acpi/Kconfig | 11 + drivers/acpi/Makefile | 1 + drivers/acpi/bus-multi-instantiate.c | 369 +++++++++++++++++++ drivers/acpi/scan.c | 16 +- drivers/platform/x86/Kconfig | 11 - drivers/platform/x86/Makefile | 1 - drivers/platform/x86/i2c-multi-instantiate.c | 174 --------- drivers/spi/spi.c | 142 ++++++- include/linux/spi/spi.h | 32 ++ sound/pci/hda/patch_realtek.c | 43 ++- 11 files changed, 592 insertions(+), 212 deletions(-) create mode 100644 drivers/acpi/bus-multi-instantiate.c delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c -- 2.25.1

5 15

Re: Re: [PATCH v2] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio
by Jiasheng Jiang 21 Jan '22

21 Jan '22

On Thu, Jan 20, 2022 at 00:46:45AM +0800, Mark Brown wrote: >> Since the possible failure of the devm_regmap_init_mmio(), it will >> return error pointer and be assigned to the regmap. >> Then the error pointer will be dereferenced. >> For example rx->regmap will be used in rx_macro_mclk_enable(). >> Therefore, it should be better to check it. > > This doesn't apply against current code, please check and resend. I am really sorry. I have already try my best to find the latest code but fails. Please give me the url or the git repository. Sincerely thanks, Jiang

2 1

SSL 2+ playback device didn't work (device or resource busy)
by Mikhail Gavrilov 21 Jan '22

21 Jan '22

Hi. Got a brand new SSL 2+ sound card today. If the recording works (not ideally) I would like to work with each channel both separately and in stereo mode. That playback does not work at all. The device is defined as a quad channel and it would be better to see this device as two separated stereo devices. $ systemctl --user stop wireplumber.service $ aplay --device sysdefault:CARD=ILDSP ~/Music/Modern\ CD/01.\ I\ have\ found\ my\ love\ in\ you.wav Playing WAVE '/home/mikhail/Music/Modern CD/01. I have found my love in you.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo ^CAborted by signal Interrupt... aplay: pcm_write:2127: write error: Interrupted system call $ aplay --device sysdefault:CARD=S2 ~/Music/Modern\ CD/01.\ I\ have\ found\ my\ love\ in\ you.wav ALSA lib pcm_dmix.c:1032:(snd_pcm_dmix_open) unable to open slave aplay: main:831: audio open error: Device or resource busy $ aplay --device sysdefault:CARD=S2 ~/Music/Modern\ CD/01.\ I\ have\ found\ my\ love\ in\ you.wav ALSA lib pcm_dmix.c:1032:(snd_pcm_dmix_open) unable to open slave aplay: main:831: audio open error: Device or resource busy $ systemctl --user start wireplumber.service http://alsa-project.org/db/?f=99ecd60a74fe21e14262ec53475437b413ae5602 -- Best Regards, Mike Gavrilov.

1 0

[PATCH v4 0/9] Support Spi in i2c-multi-instantiate driver
by Stefan Binding 21 Jan '22

21 Jan '22

Add support for SPI bus in the i2c-multi-instantiate driver as upcoming laptops will need to multi instantiate SPI devices from a single device node, which has multiple SpiSerialBus entries at the ACPI table. With the new SPI support, i2c-multi-instantiate becomes bus-multi-instantiate and is moved to the ACPI folder. The intention is to support the SPI bus by re-using the current I2C multi instantiate, instead of creating a new SPI multi instantiate, to make it possible for peripherals that can be controlled by I2C or SPI to have the same HID at the ACPI table. The new driver (Bus multi instantiate, bmi) checks for the hard-coded bus type and returns -ENODEV in case of zero devices found for that bus. In the case of automatic bus detection, the driver will give preference to I2C. The expectation is for a device node in the ACPI table to have multiple I2cSerialBus only or multiple SpiSerialBus only, not a mix of both; and for the case where there are both entries in one device node, only the I2C ones would be probed. This new bus multi instantiate will be used in CS35L41 HDA new driver. Changes since V2: - Moved bus-multi-instantiate back into platform/x86 Lucas Tanure (4): platform/x86: i2c-multi-instantiate: Rename it for a generic bus driver name platform/x86: bus-multi-instantiate: Reorganize I2C functions ALSA: hda/realtek: Add support for HP Laptops ACPI / scan: Create platform device for CS35L41 Stefan Binding (5): spi: Make spi_alloc_device and spi_add_device public again spi: Create helper API to lookup ACPI info for spi device spi: Support selection of the index of the ACPI Spi Resource before alloc spi: Add API to count spi acpi resources platform/x86: bus-multi-instantiate: Add SPI support MAINTAINERS | 4 +- drivers/acpi/scan.c | 16 +- drivers/platform/x86/Kconfig | 14 +- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/bus-multi-instantiate.c | 369 +++++++++++++++++++ drivers/platform/x86/i2c-multi-instantiate.c | 174 --------- drivers/spi/spi.c | 142 ++++++- include/linux/spi/spi.h | 32 ++ sound/pci/hda/patch_realtek.c | 43 ++- 9 files changed, 588 insertions(+), 208 deletions(-) create mode 100644 drivers/platform/x86/bus-multi-instantiate.c delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c -- 2.25.1

4 26

[PATCH 0/3] ASOC: cs42l42: Add support for system suspend
by Richard Fitzgerald 21 Jan '22

21 Jan '22

Add system suspend and resume handlers so that the cs42l42 is cleanly put into power-off state during system suspend and the registers are restored in resume. The first two patches separate out two small changes that can stand alone and are needed to enable the system suspend implementation: 1) Don't rely on there being a jack unplug IRQ before a plug IRQ. There won't be if the unplug and plug happened while in system suspend. 2) Put a mutex around the entire IRQ handling so that the suspend can ensure the last run of the IRQ handler has completed before it powers down. Richard Fitzgerald (3): ASoC: cs42l42: Report full jack status when plug is detected ASoC: cs42l42: Change jack_detect_mutex to a lock of all IRQ handling ASoC: cs42l42: Handle system suspend sound/soc/codecs/cs42l42.c | 164 ++++++++++++++++++++++++++++++++++++++++++--- sound/soc/codecs/cs42l42.h | 7 +- 2 files changed, 161 insertions(+), 10 deletions(-) -- 2.11.0

1 4

[PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
by Rob Herring 21 Jan '22

21 Jan '22

The 'interrupts' properties takes an irq number, not a phandle, and 'interrupt-parent' isn't needed in examples. --- Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml index 5dce62a7eff2..68c75a517c92 100644 --- a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml +++ b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml @@ -245,8 +245,7 @@ examples: interrupt-controller; #interrupt-cells = <2>; - interrupts = <&host_irq1>; - interrupt-parent = <&gic>; + interrupts = <4 1 0>; gpio-controller; #gpio-cells = <2>; -- 2.32.0

3 3

[PATCH] dt-bindings: Drop unnecessary pinctrl properties
by Rob Herring 20 Jan '22

20 Jan '22

For a single pinctrl mode, it is not necessary to define pinctrl properties as the tools always allow pinctrl properties. Signed-off-by: Rob Herring <robh(a)kernel.org> --- .../display/rockchip/rockchip,rk3066-hdmi.yaml | 8 -------- Documentation/devicetree/bindings/input/gpio-keys.yaml | 6 ------ .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 9 --------- .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 10 ---------- .../devicetree/bindings/sound/samsung-i2s.yaml | 6 ------ 5 files changed, 39 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml index 008c144257cb..1a68a940d165 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml @@ -26,14 +26,6 @@ properties: clock-names: const: hclk - pinctrl-0: - maxItems: 2 - - pinctrl-names: - const: default - description: - Switch the iomux for the HPD/I2C pins to HDMI function. - power-domains: maxItems: 1 diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml index dbe7ecc19ccb..7fe1966ea28a 100644 --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml @@ -88,12 +88,6 @@ patternProperties: which can be disabled to suppress events from the button. type: boolean - pinctrl-0: - maxItems: 1 - - pinctrl-names: - maxItems: 1 - required: - linux,code diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml index 80020539c3bb..5cd512b7d5ba 100644 --- a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml @@ -51,15 +51,6 @@ properties: appropriate of the LOCHNAGARx_PIN_NUM_GPIOS define, see [3]. maxItems: 1 - pinctrl-0: - description: - A phandle to the default pinctrl state. - - pinctrl-names: - description: - A pinctrl state named "default" must be defined. - const: default - pin-settings: type: object patternProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml index e50d7ad5c229..c85f759ae5a3 100644 --- a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml @@ -30,16 +30,6 @@ description: | Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt properties: - pinctrl-0: - description: - A phandle to the node containing the subnodes containing default - configurations. - - pinctrl-names: - description: - A pinctrl state named "default" must be defined. - const: default - pin-settings: description: One subnode is required to contain the default settings. It diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml index 2e3628ef48df..84c4d6cba521 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml @@ -110,12 +110,6 @@ properties: Internal DMA register base address of the audio subsystem (used in secondary sound source). - pinctrl-0: - description: Should specify pin control groups used for this controller. - - pinctrl-names: - const: default - power-domains: maxItems: 1 -- 2.32.0

4 4