January 2022 - Alsa-devel - mailman.alsa-project.org

[RESEND PATCH v10 0/3] This patches provide ADSP IPC support for MT8195
by allen-kh.cheng 04 Jan '22

04 Jan '22

From: Allen-KH Cheng <Allen-KH.Cheng(a)mediatek.com> Mediatek ADSP IPC is used to send notification or short message between processors with dsp.· It will place the message to the share buffer and will access the ADSP mailbox registers to kick dsp. Two mailboxes used to send notification or short message between processors with dsp changes since v9: - rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops changes since v8: - remove struct adsp_mbox_ch_info - add get_mtk_adsp_mbox_priv - use mtk_adsp_mbox_priv va_mboxreg address in adsp mbox driver - add struct mtk_adsp_mbox_cfg for DSP mbox register offset - remove adsp mbox register offset hard code define - remove mtk-adsp-ipc.h reference in adsp mbox driver changes since v7: - add mtk prefix for adsp ipc functions - rename adsp_mbox_ch_info to mtk_adsp_mbox_ch_info - remove incorrect reviewers in commit message changes since v6: - dt-bindings: change example dtsi node. - rename config MTK_ADSP_IPC_MBOX to MTK_ADSP_MBOX - remove unused variable - add reviewers changes since v5: - remove some redundant code changes since v4: - use switch ... case in adsp_ipc_recv - add error handling path for chan_name pointer - refine some code to be concise changes since v3: - reorder MTK_ADSP_IPC_MBOX config - remove some redundant code - remove lock in mtk-adsp-mailbox changes since v2: - separate adsp_mailbox into two instances changes since v1: - fix dt_binding_check error Allen-KH Cheng (3): dt-bindings: mediatek: add adsp-mbox document firmware: mediatek: add adsp ipc protocol interface mailbox: mediatek: add support for adsp mailbox controller .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 ++++++ drivers/firmware/Kconfig | 1 + drivers/firmware/Makefile | 1 + drivers/firmware/mediatek/Kconfig | 9 + drivers/firmware/mediatek/Makefile | 2 + drivers/firmware/mediatek/mtk-adsp-ipc.c | 135 ++++++++++++++ drivers/mailbox/Kconfig | 7 + drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-adsp-mailbox.c | 176 ++++++++++++++++++ .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ 10 files changed, 450 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml create mode 100644 drivers/firmware/mediatek/Kconfig create mode 100644 drivers/firmware/mediatek/Makefile create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h -- 2.18.0

1 4

IOMMU Page Fault with Creative Soundblaster Zx after suspend
by Rouven Czerwinski 04 Jan '22

04 Jan '22

Hi, With current 5.15.11, my soundblaster Zx is not correctly coming back from suspend. Dmesg prints: [Mi Dez 29 16:12:14 2021] [drm] UVD and UVD ENC initialized successfully. [Mi Dez 29 16:12:14 2021] snd_hda_codec_ca0132 hdaudioC0D1: ca0132 DSP downloaded and running [Mi Dez 29 16:12:15 2021] [drm] VCE initialized successfully. [Mi Dez 29 16:12:15 2021] usb 1-5: reset full-speed USB device number 2 using xhci_hcd [Mi Dez 29 16:12:16 2021] ata1.00: Enabling discard_zeroes_data [Mi Dez 29 16:12:16 2021] OOM killer enabled. [Mi Dez 29 16:12:16 2021] Restarting tasks ... done. [Mi Dez 29 16:12:16 2021] PM: suspend exit [Mi Dez 29 16:12:16 2021] snd_hda_intel 0000:06:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000f address=0xdf880000 flags=0x0000] [Mi Dez 29 16:12:17 2021] igb 0000:08:00.0 enp8s0: igb: enp8s0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX Where the IOMMU Page Fault looks suspicious. Unbinding and rebinding the driver using sysfs fixes it, thats the current workaround I have been using. Thanks and happy holidays, Rouven Czerwinski

3 2

[PATCH] mips: bcm63xx: add support for clk_set_parent()
by Randy Dunlap 03 Jan '22

03 Jan '22

The MIPS BMC63XX subarch does not provide/support clk_set_parent(). This causes build errors in a few drivers, so add a simple implementation of that function so that callers of it will build without errors. Fixes these build errors: ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined! ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined! Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." ) Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> --- arch/mips/bcm63xx/clk.c | 6 ++++++ 1 file changed, 6 insertions(+) --- linux-next-20211224.orig/arch/mips/bcm63xx/clk.c +++ linux-next-20211224/arch/mips/bcm63xx/clk.c @@ -387,6 +387,12 @@ struct clk *clk_get_parent(struct clk *c } EXPORT_SYMBOL(clk_get_parent); +int clk_set_parent(struct clk *clk, struct clk *parent) +{ + return 0; +} +EXPORT_SYMBOL(clk_set_parent); + unsigned long clk_get_rate(struct clk *clk) { if (!clk)

4 3

[PATCH] mips: lantiq: add support for clk_set_parent()
by Randy Dunlap 03 Jan '22

03 Jan '22

Provide a simple implementation of clk_set_parent() in the lantiq subarch so that callers of it will build without errors. Fixes these build errors: ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined! ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined! Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reported-by: kernel test robot <lkp(a)intel.com> --to=linux-mips(a)vger.kernel.org --cc="John Crispin <john(a)phrozen.org>" --cc="Jonathan Cameron <jic23(a)kernel.org>" --cc="Russell King <linux(a)armlinux.org.uk>" --cc="Andy Shevchenko <andy.shevchenko(a)gmail.com>" --cc=alsa-devel(a)alsa-project.org --to="Thomas Bogendoerfer <tsbogend(a)alpha.franken.de>" --- arch/mips/lantiq/clk.c | 6 ++++++ 1 file changed, 6 insertions(+) --- linux-next-20211224.orig/arch/mips/lantiq/clk.c +++ linux-next-20211224/arch/mips/lantiq/clk.c @@ -164,6 +164,12 @@ struct clk *clk_get_parent(struct clk *c } EXPORT_SYMBOL(clk_get_parent); +int clk_set_parent(struct clk *clk, struct clk *parent) +{ + return 0; +} +EXPORT_SYMBOL(clk_set_parent); + static inline u32 get_counter_resolution(void) { u32 res;

3 2

[PATCH v2 0/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows
by Christian Lachner 03 Jan '22

03 Jan '22

This is version 2 of my patch. It implements suggestions from Takashi Iwai. Thanks for that! Furthermore, I re-analyzed all the relevant coefs and removed those that are not actually needed. === This patch addresses an issue where after rebooting from Windows into Linux there would be no audio output. It turns out that the Realtek Audio driver on Windows changes some coeffs which are not being reset/reinitialized when rebooting the machine. As a result, there is no audio output until these coeffs are being reset to their initial state. This patch takes care of that by setting known-good (initial) values to the coeffs. The coeffs were collected via alsa-info, see: broken: https://pastebin.com/4bRBSseH working: https://pastebin.com/WUTufvZB I also created a script which fixes the audio at runtime. #!/bin/sh hda-verb /dev/snd/hwC2D0 0x20 SET_COEF_INDEX 0x1a hda-verb /dev/snd/hwC2D0 0x20 SET_PROC_COEF 0x01c1 hda-verb /dev/snd/hwC2D0 0x20 SET_COEF_INDEX 0x1b hda-verb /dev/snd/hwC2D0 0x20 SET_PROC_COEF 0x0202 hda-verb /dev/snd/hwC2D0 0x20 SET_COEF_INDEX 0x43 hda-verb /dev/snd/hwC2D0 0x20 SET_PROC_COEF 0x3005 However, obviously, we can and should fix this in the kernel. We initially relied upon alc1220_fixup_clevo_p950() to fix some pins in the connection list. However, it also sets coef 0x7 which does not need to be touched. Furthermore, to prevent mixing device-specific quirks I introduced a new alc1220_fixup_gb_x570() which is heavily based on alc1220_fixup_clevo_p950() but does not set coeff 0x7 and fixes the coeffs that are actually needed instead. This new alc1220_fixup_gb_x570() is believed to also work for other boards, like the Gigabyte X570 Aorus Extreme and the newer Gigabyte Aorus X570S Master. However, as there is no way for me to test these I initially only enable this new behaviour for the mainboard I have which is the Gigabyte X570(non-S) Aorus Master. I tested this patch on the 5.15 branch as well as on master and it is working well for me. Christian Lachner (1): ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows sound/pci/hda/patch_realtek.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) -- 2.34.1

2 2

[PATCH 0/3] More amlogic sound-name-prefix DT fixes
by Alexander Stein 03 Jan '22

03 Jan '22

Following up [1] here are more fix for missing sound-name-prefix properties in the arch/arm64/boot/dts/amlogic/ subtree. [1] https://www.spinics.net/lists/devicetree/msg466125.html Alexander Stein (3): dt-bindings: display: meson-dw-hdmi: add missing sound-name-prefix property ASoC: dt-bindings: spdif-dit: add missing sound-name-prefix property ASoC: dt-bindings: aiu: spdif-dit: add missing sound-name-prefix property .../devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml | 5 +++++ Documentation/devicetree/bindings/sound/amlogic,aiu.yaml | 5 +++++ Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml | 5 +++++ 3 files changed, 15 insertions(+) -- 2.34.1

3 6

[RESEND] Amlogic DPCM audio card(s) speaker placement issue
by Christian Hewitt 03 Jan '22

03 Jan '22

Hello alsa-dev people, I’d like to describe a problem with speaker placement seen with the Amlogic (meson) AIU and AXG drivers when playing multi-channel media. The problem was traced to a failure to get the channel map via snd_pcm_get_chmap() and further analysis showed this failed because the PCM controls are exposed on a different device than the PCM stream. e.g. on LibreTech LePotato with DPCM routing configured for HDMI output, the hw PCM is on the single frontend device 0 but the PCM controls are on device 2: LePotato:~ # aplay -l **** List of PLAYBACK Hardware Devices **** card 0: LIBRETECHCC [LIBRETECH-CC], device 0: fe.dai-link-0 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 LePotato:~ # amixer controls numid=19,iface=MIXER,name='PCM Playback Volume' numid=18,iface=MIXER,name='ACODEC Left DAC Sel' numid=7,iface=MIXER,name='ACODEC Mute Ramp Switch' numid=2,iface=MIXER,name='ACODEC Playback Channel Mode' numid=3,iface=MIXER,name='ACODEC Playback Switch' numid=4,iface=MIXER,name='ACODEC Playback Volume' numid=5,iface=MIXER,name='ACODEC Ramp Rate' numid=17,iface=MIXER,name='ACODEC Right DAC Sel' numid=8,iface=MIXER,name='ACODEC Unmute Ramp Switch' numid=6,iface=MIXER,name='ACODEC Volume Ramp Switch' numid=1,iface=MIXER,name='AIU ACODEC I2S Lane Select' numid=16,iface=MIXER,name='AIU ACODEC OUT EN Switch' numid=15,iface=MIXER,name='AIU ACODEC SRC' numid=14,iface=MIXER,name='AIU HDMI CTRL SRC' numid=13,iface=MIXER,name='AIU SPDIF SRC SEL' numid=12,iface=PCM,name='ELD',device=2 numid=11,iface=PCM,name='IEC958 Playback Default',device=2 numid=10,iface=PCM,name='IEC958 Playback Mask',device=2 numid=9,iface=PCM,name='Playback Channel Map',device=2 https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/amlogic/m… or on a Wetek Play 2: WP2:~ # aplay -l **** List of PLAYBACK Hardware Devices **** card 0: WETEKPLAY2 [WETEK-PLAY2], device 0: fe.dai-link-0 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: WETEKPLAY2 [WETEK-PLAY2], device 1: fe.dai-link-1 (*) [] Subdevices: 1/1 Subdevice #0: subdevice #0 WP2:~ # amixer controls numid=7,iface=MIXER,name='PCM Playback Volume' numid=6,iface=MIXER,name='AIU HDMI CTRL SRC' numid=5,iface=MIXER,name='AIU SPDIF SRC SEL' numid=4,iface=PCM,name='ELD',device=4 numid=3,iface=PCM,name='IEC958 Playback Default',device=4 numid=2,iface=PCM,name='IEC958 Playback Mask',device=4 numid=1,iface=PCM,name='Playback Channel Map',device=4 https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/amlogic/m… It looks like the PCM controls of the backend hdmi-codec are not routed through the DPCM driver the same way as PCM streams. We discussed that issue with Jerome, the driver author, but it’s not clear which bits we are missing. i.e. if it's something ASoC DPCM should be handling or if some further plumbing in the card driver or userspace is needed? Any hints into the right direction would be highly appreciated! Christian

3 4

slow snd_rawmidi_drain() for VirMidi devcies
by Stefan Sauer 02 Jan '22

02 Jan '22

hi, happy new year every one. During the free days I've tried to link BitwigStudio to the webapp [1]cables.gl over virmidi. Unfortunately Bitwig Studio only supports rawmidi. What I discovered is that there is a strange slowness when sending data to virmidi caused by snd_rawmidi_drain(). I've posted two tiny, self-contained c apps to: [2]https://gist.github.com/ensonic/c7588b87fa6c1fa94a8f753b1e0aa394 See some examples below. 2 observations: * snd_rawmidi_type() is *not* reporting virmidi as VIRTUAL * snd_rawmidi_drain() takes about 60ms! on virtual vs. less that 0.1 ms on usb midi (I checked all my hw midi and the worst was avg=1ms on physical midi image unitor8) When comparing the implementations: [3]https://github.com/alsa-project/alsa-lib/blob/master/ src/rawmidi/rawmidi_virt.c#L173 [4]https://github.com/alsa-project/alsa-lib/blob/master/ src/rawmidi/rawmidi_hw.c#L164 I see that the hw one results in an IOCTL (SNDRV_RAWMIDI_IOCTL_DRAIN) which I can see when strac'ing app and I wonder if this is the root cause? Why is rawmidi_virt.c not used for virmidi? From poking at snd_rawmidi_open_conf() I have not yet figured where this is decided .... If the IOCTl is the right code path, any idea why it is slow? Is the virmidi driver not reporting buffer fill status or something like that? Stefan > amidi -l Dir Device Name IO hw:0,0,0 Scarlett 18i20 USB MIDI 1 IO hw:3,0,0 nanoKEY2 nanoKEY2 _ KEYBOARD IO hw:5,0,0 nanoKONTROL nanoKONTROL _ SLIDE IO hw:10,0 Virtual Raw MIDI (16 subdevices) IO hw:11,0 Virtual Raw MIDI (16 subdevices) # using direct i/o to virmidi - all good > ./rawmidi_oss /dev/midi11 0 Using device '/dev/midi11' without draining write took min= 0.0015 ms, avg= 0.0016 ms, max= 0.0110 ms > ./rawmidi_oss /dev/midi11 1 Using device '/dev/midi11' with draining write took min= 0.0015 ms, avg= 0.0017 ms, max= 0.0101 ms drain took min= 0.0001 ms, avg= 0.0001 ms, max= 0.0008 ms # using snd_rawmidi to virmidi - slow drain operations > ./rawmidi_alsa hw:11,0 0 Using device 'hw:11,0' without draining SND_RAWMIDI_TYPE_HW write took min= 0.0010 ms, avg= 0.0011 ms, max= 0.0056 ms > ./rawmidi_alsa hw:11,0 1 Using device 'hw:11,0' with draining SND_RAWMIDI_TYPE_HW write took min= 0.0016 ms, avg= 0.0040 ms, max= 0.0077 ms drain took min= 55.9951 ms, avg= 60.4330 ms, max= 64.0653 ms # using snd_rawmidi to usb hw - all good > ./rawmidi_alsa hw:3,0 0 Using device 'hw:3,0' without draining SND_RAWMIDI_TYPE_HW write took min= 0.0012 ms, avg= 0.0015 ms, max= 0.0121 ms > ./rawmidi_alsa hw:3,0 1 Using device 'hw:3,0' with draining SND_RAWMIDI_TYPE_HW write took min= 0.0024 ms, avg= 0.0032 ms, max= 0.0110 ms drain took min= 0.0293 ms, avg= 0.0636 ms, max= 0.2277 ms References 1. http://cables.gl/ 2. https://gist.github.com/ensonic/c7588b87fa6c1fa94a8f753b1e0aa394 3. https://github.com/alsa-project/alsa-lib/blob/master/src/rawmidi/rawmidi_vi… 4. https://github.com/alsa-project/alsa-lib/blob/master/src/rawmidi/rawmidi_hw…

1 0

src/topology/parser.c: drop duplicate safe_strtol_base
by GitHub pull_request - opened 01 Jan '22

01 Jan '22

alsa-project/alsa-lib pull request #208 was opened from ffontaine: `safe_strtol_base` is defined twice since https://github.com/alsa-project/alsa-lib/commit/f547b2e35f71e89397e8b29cd0b… and https://github.com/alsa-project/alsa-lib/commit/5fab157a593180525607b7d2626… resulting in the following build failure when alsa-utils is built statically: ``` checking for snd_tplg_new in -latopology... no configure: error: No linkable libatopology was found. ``` because `safe_strtol_base` is defined twice: ``` configure:7776: checking for snd_tplg_new in -latopology configure:7801: /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -latopology -lasound -lasound -lm -lpthread >&5 /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libasound.a(conf.o): in function `safe_strtol_base': conf.c:(.text+0x1600): multiple definition of `safe_strtol_base'; /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libatopology.a(parser.o):parser.c:(.text+0x130): first defined here ``` Fixes: - http://autobuild.buildroot.org/results/08d028004090b2a8292f03910cb9bf80a73a… Request URL : https://github.com/alsa-project/alsa-lib/pull/208 Patch URL : https://github.com/alsa-project/alsa-lib/pull/208.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

src/topology/parser.c: drop duplicate safe_strtol_base
by GitHub pull_request - opened 01 Jan '22

01 Jan '22

alsa-project/alsa-lib pull request #207 was opened from ffontaine: `safe_strtol_base` is defined twice since https://github.com/alsa-project/alsa-lib/commit/f547b2e35f71e89397e8b29cd0b… and https://github.com/alsa-project/alsa-lib/commit/5fab157a593180525607b7d2626… resulting in the following build failure when alsa-utils is built statically: ``` checking for snd_tplg_new in -latopology... no configure: error: No linkable libatopology was found. ``` because `safe_strtol_base` is defined twice: ``` configure:7776: checking for snd_tplg_new in -latopology configure:7801: /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -latopology -lasound -lasound -lm -lpthread >&5 /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libasound.a(conf.o): in function `safe_strtol_base': conf.c:(.text+0x1600): multiple definition of `safe_strtol_base'; /home/buildroot/autobuild/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libatopology.a(parser.o):parser.c:(.text+0x130): first defined here ``` Fixes: - http://autobuild.buildroot.org/results/08d028004090b2a8292f03910cb9bf80a73a… Signed-off-by: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Request URL : https://github.com/alsa-project/alsa-lib/pull/207 Patch URL : https://github.com/alsa-project/alsa-lib/pull/207.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0