July 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] sound: usb: line6: free allocated urbs on failure
by Salah Triki 15 Jul '21

15 Jul '21

Free allocated urbs on failure in order to prevent memory leaks. Signed-off-by: Salah Triki <salah.triki(a)gmail.com> --- sound/usb/line6/capture.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/sound/usb/line6/capture.c b/sound/usb/line6/capture.c index 970c9bdce0b2..345b75ede5d5 100644 --- a/sound/usb/line6/capture.c +++ b/sound/usb/line6/capture.c @@ -258,6 +258,7 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm) { struct usb_line6 *line6 = line6pcm->line6; int i; + int ret; line6pcm->in.urbs = kcalloc(line6->iso_buffers, sizeof(struct urb *), GFP_KERNEL); @@ -272,8 +273,10 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm) urb = line6pcm->in.urbs[i] = usb_alloc_urb(LINE6_ISO_PACKETS, GFP_KERNEL); - if (urb == NULL) - return -ENOMEM; + if (urb == NULL) { + ret = -ENOMEM; + goto enomem; + } urb->dev = line6->usbdev; urb->pipe = @@ -286,9 +289,20 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm) urb->interval = LINE6_ISO_INTERVAL; urb->error_count = 0; urb->complete = audio_in_callback; - if (usb_urb_ep_type_check(urb)) - return -EINVAL; + if (usb_urb_ep_type_check(urb)) { + ret = -EINVAL; + goto einval; + } } return 0; + +enomem: + i--; + +einval: + while (i >= 0) + usb_free_urb(line6pcm->in.urbs[i--]); + + return ret; } -- 2.25.1

2 1

How can turn on auto-mute mode in alsa ?
by GitHub issues - edited 15 Jul '21

15 Jul '21

alsa-project/alsa-lib issue #164 was edited from yufeiluo: My alsa-utils version: aplay --version aplay: version 1.1.8 by Jaroslav Kysela <perex(a)perex.cz> No auto-mute option in alsamixer gui menu. [https://www.dropbox.com/s/ie6meqto1t1rv9g/alsamixer.png?dl=0](url) debian@debian:~$ amixer -c 0 sset 'Auto-Mute Mode' Enabled amixer: Unable to find simple control 'Auto-Mute Mode',0 Issue URL : https://github.com/alsa-project/alsa-lib/issues/164 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

How can turn on auto-mute mode in alsa ?
by GitHub issues - opened 15 Jul '21

15 Jul '21

alsa-project/alsa-lib issue #164 was opened from yufeiluo: My alsa-utils version: [code] aplay --version aplay: version 1.1.8 by Jaroslav Kysela <perex(a)perex.cz> [/code] No auto-mute option in alsamixer gui menu. [https://www.dropbox.com/s/ie6meqto1t1rv9g/alsamixer.png?dl=0](url) [code] debian@debian:~$ amixer -c 0 sset 'Auto-Mute Mode' Enabled amixer: Unable to find simple control 'Auto-Mute Mode',0 [/code] Issue URL : https://github.com/alsa-project/alsa-lib/issues/164 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/7] ASoC: Intel: updates for JasperLake and SoundWire machines
by Pierre-Louis Bossart 14 Jul '21

14 Jul '21

The first 4 patches enable the use of a Maxim 98360a amplifier on JasperLake using the existing sof_cs42l42 machine driver, and a slightly different hardware layout compared to GeminiLake devices. The last 3 patches reflect recent changes in the RT711 codec driver: we want to avoid duplicating the JD modes and can following the definitions from the codec driver. Bard Liao (2): ASoC: Intel: sof_sdw: extends SOF_RT711_JDSRC to 4 bits ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode Brent Lu (4): ASoC: Intel: sof_cs42l42: support arbitrary DAI link sequence ASoC: Intel: maxim-common: support max98360a ASoC: Intel: sof_cs42l42: add support for jsl_cs4242_mx98360a ASoC: Intel: sof_rt5682: code refactor for max98360a jairaj arava (1): ASoC: Intel: sof_sdw: update quirk for jack detection in ADL RVP sound/soc/intel/boards/sof_cs42l42.c | 353 ++++++++++++------ sound/soc/intel/boards/sof_maxim_common.c | 17 +- sound/soc/intel/boards/sof_maxim_common.h | 4 +- sound/soc/intel/boards/sof_rt5682.c | 52 +-- sound/soc/intel/boards/sof_sdw.c | 23 +- sound/soc/intel/boards/sof_sdw_common.h | 27 +- .../intel/common/soc-acpi-intel-jsl-match.c | 8 + 7 files changed, 292 insertions(+), 192 deletions(-) -- 2.25.1

2 8

[PATCH v1] ASoC: rt5631: Fix regcache sync errors on resume
by Dmitry Osipenko 14 Jul '21

14 Jul '21

From: Maxim Schwalm <maxim.schwalm(a)gmail.com> The ALC5631 does not like multi-write accesses, avoid them. This fixes: rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121 errors on resume from suspend (and all registers after the registers in the error not being synced). Inspired by commit 2d30e9494f1e ("ASoC: rt5651: Fix regcache sync errors on resume") from Hans de Geode, which fixed the same errors on ALC5651. Signed-off-by: Maxim Schwalm <maxim.schwalm(a)gmail.com> --- sound/soc/codecs/rt5631.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index 3000bc128b5b..38356ea2bd6e 100644 --- a/sound/soc/codecs/rt5631.c +++ b/sound/soc/codecs/rt5631.c @@ -1695,6 +1695,8 @@ static const struct regmap_config rt5631_regmap_config = { .reg_defaults = rt5631_reg, .num_reg_defaults = ARRAY_SIZE(rt5631_reg), .cache_type = REGCACHE_RBTREE, + .use_single_read = true, + .use_single_write = true, }; static int rt5631_i2c_probe(struct i2c_client *i2c, -- 2.32.0

2 1

[PATCH] ASoC: SOF: Intel: Update ADL descriptor to use ACPI power states
by Pierre-Louis Bossart 14 Jul '21

14 Jul '21

From: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> The ADL descriptor was missing an ACPI power setting, causing the DSP to enter D3 even with a D0i1-compatible wake-on-voice/hotwording capture stream. Fixes: 4ad03f894b3c ('ASoC: SOF: Intel: Update ADL P to use its own descriptor') Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/sof/intel/pci-tgl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sof/intel/pci-tgl.c b/sound/soc/sof/intel/pci-tgl.c index a00262184efa..d04ce84fe7cc 100644 --- a/sound/soc/sof/intel/pci-tgl.c +++ b/sound/soc/sof/intel/pci-tgl.c @@ -89,6 +89,7 @@ static const struct sof_dev_desc adls_desc = { static const struct sof_dev_desc adl_desc = { .machines = snd_soc_acpi_intel_adl_machines, .alt_machines = snd_soc_acpi_intel_adl_sdw_machines, + .use_acpi_target_states = true, .resindex_lpe_base = 0, .resindex_pcicfg_base = -1, .resindex_imr_base = -1, -- 2.25.1

2 1

[PATCH] ASoC: codecs: wcd938x: make sdw dependency explicit in Kconfig
by Srinivas Kandagatla 14 Jul '21

14 Jul '21

currenlty wcd938x has only soundwire interface and depends on symbols from wcd938x soundwire module, so make this dependency explicit in Kconfig Without this one of the randconfig endup setting CONFIG_SND_SOC_WCD938X=y CONFIG_SND_SOC_WCD938X_SDW=m resulting in some undefined reference to wcd938x_sdw* symbols. Reported-by: kernel test robot <lkp(a)intel.com> Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 2d80836ef220..f47d46eb76bc 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1557,6 +1557,7 @@ config SND_SOC_WCD934X Qualcomm SoCs like SDM845. config SND_SOC_WCD938X + depends on SND_SOC_WCD938X_SDW tristate config SND_SOC_WCD938X_SDW -- 2.21.0

2 1

[PATCH] ALSA: usb-audio: Add missing proc text entry for BESPOKEN type
by Takashi Iwai 14 Jul '21

14 Jul '21

Recently we've added a new usb_mixer element type, USB_MIXER_BESPOKEN, but it wasn't added in the table in snd_usb_mixer_dump_cval(). This is no big problem since each bespoken type should have its own dump method, but it still isn't disallowed to use the standard one, so we should cover it as well. Along with it, define the table with the explicit array initializer for avoiding other pitfalls. Fixes: 785b6f29a795 ("ALSA: usb-audio: scarlett2: Fix wrong resume call") Reported-by: Pavel Machek <pavel(a)denx.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/mixer.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 30b3e128e28d..f4cdaf1ba44a 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -3295,7 +3295,15 @@ static void snd_usb_mixer_dump_cval(struct snd_info_buffer *buffer, { struct usb_mixer_elem_info *cval = mixer_elem_list_to_info(list); static const char * const val_types[] = { - "BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32", + [USB_MIXER_BOOLEAN] = "BOOLEAN", + [USB_MIXER_INV_BOOLEAN] = "INV_BOOLEAN", + [USB_MIXER_S8] = "S8", + [USB_MIXER_U8] = "U8", + [USB_MIXER_S16] = "S16", + [USB_MIXER_U16] = "U16", + [USB_MIXER_S32] = "S32", + [USB_MIXER_U32] = "U32", + [USB_MIXER_BESPOKEN] = "BESPOKEN", }; snd_iprintf(buffer, " Info: id=%i, control=%i, cmask=0x%x, " "channels=%i, type=\"%s\"\n", cval->head.id, -- 2.26.2

1 0

Missing macro 'AM_PATH_LD10K1' not found in library
by GitHub issues - opened 14 Jul '21

14 Jul '21

alsa-project/alsa-tools issue #7 was opened from ronohara: New Linux Mint 20.0 install (Ubuntu 20.04 based) on HP X360 with TigerLake hardware. This distro only has lib-alsa-1.2.2 ... so I need to compile/install the latest alsa stuff from source I have the kernel working at seeing the hardware - in the mainline 5.13 kernel it is already available. Installed the firmware and UCM2 stuff. 'speaker-test' works ... lots of details in this closed bug: https://github.com/thesofproject/linux/issues/2700#issuecomment-854033711 Installed alsa-lib from source, and alsa-utils .... but compiling alsa-tools (gitcompile) fails. This macro needs to be installed, but I am wondering what the best way is ...? make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/src' make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' sed -e 's,[@]sbindir[@],/usr/local/sbin,g' -e 's,[@]binarydir[@],/usr/local/bin,g' -e 's,[@]sysconfdir[@],/usr/local/etc,g' ./ld10k1d.in > ld10k1d make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[2]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[1]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[1]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make all-recursive make[2]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' Making all in setup make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup' Making all in effects make[4]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup/effects' make[4]: Nothing to be done for 'all'. make[4]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup/effects' make[4]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup' make[4]: Nothing to be done for 'all-am'. make[4]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup' make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/setup' Making all in doc make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/doc' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/doc' Making all in patch make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/patch' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/patch' Making all in dump make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/dump' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/dump' Making all in contrib make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/contrib' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/contrib' Making all in include make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/include' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/include' Making all in src make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/src' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1/src' make[3]: Entering directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[3]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[2]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' make[1]: Leaving directory '/root/alsa-1.2.5/alsa-tools-1.2.5/ld10k1' ./qlo10k1 configure.ac:21: warning: macro 'AM_PATH_LD10K1' not found in library libtoolize: putting auxiliary files in '.'. libtoolize: copying file './ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'. libtoolize: copying file 'm4/libtool.m4' libtoolize: copying file 'm4/ltoptions.m4' libtoolize: copying file 'm4/ltsugar.m4' libtoolize: copying file 'm4/ltversion.m4' libtoolize: copying file 'm4/lt~obsolete.m4' libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am. configure.ac:21: warning: macro 'AM_PATH_LD10K1' not found in library configure.ac:21: error: possibly undefined macro: AM_PATH_LD10K1 If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 make: *** [Makefile:9: all] Error 1 Issue URL : https://github.com/alsa-project/alsa-tools/issues/7 Repository URL: https://github.com/alsa-project/alsa-tools

1 0

sof-ehl-rt5660: Add UCM for Intel sof-ehl-rt5660
by GitHub pull_request - opened 14 Jul '21

14 Jul '21

alsa-project/alsa-ucm-conf pull request #106 was opened from libinyang: Add the UCM support for the sof-ehl-rt5660 platform. Signed-off-by: Libin Yang <libin.yang(a)intel.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/106 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/106.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0