June 2021 - Alsa-devel - mailman.alsa-project.org

ThinkPad T14 AMD microphone LED always ON
by GitHub issues - opened 16 Jun '21

16 Jun '21

alsa-project/alsa-ucm-conf issue #100 was opened from miquecg: I'm running Arch Linux with `alsa-ucm-conf` 1.2.5.1. This problem was present in previous versions and it's being discussed on a [forum thread](https://bbs.archlinux.org/viewtopic.php?pid=1977273) among other things. So the problem is that microphone LED is always ON but mute/unmute behaviour still works. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/100 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

rate-lav: Convert to libswresample
by GitHub pull_request - opened 16 Jun '21

16 Jun '21

alsa-project/alsa-plugins pull request #27 was opened from tiwai: The libavresample has been deprecated. Convert to the new API for libswresample. The phase shift and cutoff seem to be either redundant or not-working properly, so those are dropped. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Request URL : https://github.com/alsa-project/alsa-plugins/pull/27 Patch URL : https://github.com/alsa-project/alsa-plugins/pull/27.patch Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static
by Wei Yongjun 16 Jun '21

16 Jun '21

The sparse tool complains as follows: sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol 'hdmi_codec_controls' was not declared. Should it be static? This symbol is not used outside of hdmi-codec.c, so marks it static. Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls") Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- sound/soc/codecs/hdmi-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index e0460a9bd17a..b61f980cabdc 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -747,7 +747,7 @@ static const struct snd_soc_dai_ops hdmi_codec_spdif_dai_ops = { SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\ SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE) -struct snd_kcontrol_new hdmi_codec_controls[] = { +static struct snd_kcontrol_new hdmi_codec_controls[] = { { .access = SNDRV_CTL_ELEM_ACCESS_READ, .iface = SNDRV_CTL_ELEM_IFACE_PCM,

2 1

[PATCH -next] ALSA: fm801: Fix missing pci_release_regions() on error in snd_fm801_create()
by Yang Yingliang 16 Jun '21

16 Jun '21

Fix the missing pci_release_regions() before return from snd_fm801_create() in the error handling case. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/pci/fm801.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/fm801.c b/sound/pci/fm801.c index ed9dae87145b..adac9c6a67f0 100644 --- a/sound/pci/fm801.c +++ b/sound/pci/fm801.c @@ -1254,6 +1254,7 @@ static int snd_fm801_create(struct snd_card *card, IRQF_SHARED, KBUILD_MODNAME, chip)) { dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq); snd_fm801_free(chip); + pci_release_regions(pci); return -EBUSY; } chip->irq = pci->irq; @@ -1266,6 +1267,7 @@ static int snd_fm801_create(struct snd_card *card, err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops); if (err < 0) { snd_fm801_free(chip); + pci_release_regions(pci); return err; } @@ -1273,6 +1275,7 @@ static int snd_fm801_create(struct snd_card *card, err = v4l2_device_register(&pci->dev, &chip->v4l2_dev); if (err < 0) { snd_fm801_free(chip); + pci_release_regions(pci); return err; } chip->tea.v4l2_dev = &chip->v4l2_dev; @@ -1285,6 +1288,7 @@ static int snd_fm801_create(struct snd_card *card, if (snd_tea575x_init(&chip->tea, THIS_MODULE)) { dev_err(card->dev, "TEA575x radio not found\n"); snd_fm801_free(chip); + pci_release_regions(pci); return -ENODEV; } } else if ((chip->tea575x_tuner & TUNER_TYPE_MASK) == 0) { -- 2.25.1

2 2

[PATCH][next] ALSA: bebob: Fix bit flag quirk constants
by Colin King 16 Jun '21

16 Jun '21

From: Colin Ian King <colin.king(a)canonical.com> The quirking bit-flags are currently set as contiguous integer enum values and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so he quirking never getting set or tested correctly for this quirk. Fix this by setting the quirking constants as shifted bit values. Addresses-Coverity: ("Bitwise-and with zero") Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/firewire/bebob/bebob.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h index c06579d9380e..4d73ecb30d79 100644 --- a/sound/firewire/bebob/bebob.h +++ b/sound/firewire/bebob/bebob.h @@ -76,8 +76,8 @@ struct snd_bebob_spec { }; enum snd_bebob_quirk { - SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC, - SND_BEBOB_QUIRK_WRONG_DBC, + SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC = (1 << 0), + SND_BEBOB_QUIRK_WRONG_DBC = (1 << 1), }; struct snd_bebob { -- 2.31.1

3 2

[PATCH -next] ALSA: ppc: fix error return code in snd_pmac_probe()
by Yang Yingliang 16 Jun '21

16 Jun '21

If snd_pmac_tumbler_init() or snd_pmac_tumbler_post_init() fails, snd_pmac_probe() need return error code. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/ppc/powermac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c index 1d2865c43d4b..db414b61157e 100644 --- a/sound/ppc/powermac.c +++ b/sound/ppc/powermac.c @@ -79,7 +79,11 @@ static int snd_pmac_probe(struct platform_device *devptr) sprintf(card->shortname, "PowerMac %s", name_ext); sprintf(card->longname, "%s (Dev %d) Sub-frame %d", card->shortname, chip->device_id, chip->subframe); - if ( snd_pmac_tumbler_init(chip) < 0 || snd_pmac_tumbler_post_init() < 0) + err = snd_pmac_tumbler_init(chip); + if (err < 0) + goto __error; + err = snd_pmac_tumbler_post_init(); + if (err < 0) goto __error; break; case PMAC_AWACS: -- 2.25.1

2 1

Fix a52 for the recent avcodec
by GitHub pull_request - opened 16 Jun '21

16 Jun '21

alsa-project/alsa-plugins pull request #26 was opened from tiwai: Request URL : https://github.com/alsa-project/alsa-plugins/pull/26 Patch URL : https://github.com/alsa-project/alsa-plugins/pull/26.patch Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH] media: Fix Media Controller API config checks
by Shuah Khan 16 Jun '21

16 Jun '21

Smatch static checker warns that "mdev" can be null: sound/usb/media.c:287 snd_media_device_create() warn: 'mdev' can also be NULL If CONFIG_MEDIA_CONTROLLER is disabled, this file should not be included in the build. The below conditions in the sound/usb/Makefile are in place to ensure that media.c isn't included in the build. sound/usb/Makefile: snd-usb-audio-$(CONFIG_SND_USB_AUDIO_USE_MEDIA_CONTROLLER) += media.o select SND_USB_AUDIO_USE_MEDIA_CONTROLLER if MEDIA_CONTROLLER && (MEDIA_SUPPORT=y || MEDIA_SUPPORT=SND_USB_AUDIO) The following config check in include/media/media-dev-allocator.h is in place to enable the API only when CONFIG_MEDIA_CONTROLLER and CONFIG_USB are enabled. #if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) This check doesn't work as intended when CONFIG_USB=m. When CONFIG_USB=m, CONFIG_USB_MODULE is defined and CONFIG_USB is not. The above config check doesn't catch that CONFIG_USB is defined as a module and disables the API. This results in sound/usb enabling Media Controller specific ALSA driver code, while Media disables the Media Controller API. Fix the problem requires two changes: 1. Change the check to use IS_ENABLED to detect when CONFIG_USB is enabled as a module or static. Since CONFIG_MEDIA_CONTROLLER is a bool, leave the check unchanged to be consistent with drivers/media/Makefile. 2. Change the drivers/media/mc/Makefile to include mc-dev-allocator.o in mc-objs when CONFIG_USB is y or m. Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Link: https://lore.kernel.org/alsa-devel/YLeAvT+R22FQ%2FEyw@mwanda/ Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> --- drivers/media/mc/Makefile | 2 +- include/media/media-dev-allocator.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/mc/Makefile b/drivers/media/mc/Makefile index 119037f0e686..140f0a78540e 100644 --- a/drivers/media/mc/Makefile +++ b/drivers/media/mc/Makefile @@ -3,7 +3,7 @@ mc-objs := mc-device.o mc-devnode.o mc-entity.o \ mc-request.o -ifeq ($(CONFIG_USB),y) +ifeq ($(CONFIG_USB),$(filter $(CONFIG_USB),y m)) mc-objs += mc-dev-allocator.o endif diff --git a/include/media/media-dev-allocator.h b/include/media/media-dev-allocator.h index b35ea6062596..2ab54d426c64 100644 --- a/include/media/media-dev-allocator.h +++ b/include/media/media-dev-allocator.h @@ -19,7 +19,7 @@ struct usb_device; -#if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) +#if defined(CONFIG_MEDIA_CONTROLLER) && IS_ENABLED(CONFIG_USB) /** * media_device_usb_allocate() - Allocate and return struct &media device * -- 2.30.2

2 4

conf: refine check for snd_config_is_array
by GitHub pull_request - opened 16 Jun '21

16 Jun '21

alsa-project/alsa-lib pull request #158 was opened from ranj063: Apart from checking the index, also check if the node is not compound to qualify a config as an array. For ex: mixer [ "mixer1" ] is an array but mixer.0 { name "mixer 1" } is not an array even though the id is 0. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Request URL : https://github.com/alsa-project/alsa-lib/pull/158 Patch URL : https://github.com/alsa-project/alsa-lib/pull/158.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Build fails with "undefined macro AM_GNU_GETTEXT"
by GitHub issues - edited 15 Jun '21

15 Jun '21

alsa-project/alsa-utils issue #99 was edited from edward-a: **./gitcompile** fails with the following output: configure.ac:10: warning: macro 'AM_GNU_GETTEXT' not found in library configure.ac:11: warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library ./gitcompile: line 10: gettextize: command not found configure.ac:15: installing './compile' configure.ac:6: installing './install-sh' configure.ac:6: installing './missing' alsactl/Makefile.am: installing './depcomp' axfer/test/Makefile.am:9: warning: source file '../container.c' is in a subdirectory, axfer/test/Makefile.am:9: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. axfer/test/Makefile.am:9: warning: source file '../container-riff-wave.c' is in a subdirectory, axfer/test/Makefile.am:9: but option 'subdir-objects' is disabled axfer/test/Makefile.am:9: warning: source file '../container-au.c' is in a subdirectory, axfer/test/Makefile.am:9: but option 'subdir-objects' is disabled axfer/test/Makefile.am:9: warning: source file '../container-voc.c' is in a subdirectory, axfer/test/Makefile.am:9: but option 'subdir-objects' is disabled axfer/test/Makefile.am:9: warning: source file '../container-raw.c' is in a subdirectory, axfer/test/Makefile.am:9: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../container.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../container-riff-wave.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../container-au.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../container-voc.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../container-raw.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../mapper.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../mapper-single.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled axfer/test/Makefile.am:20: warning: source file '../mapper-multiple.c' is in a subdirectory, axfer/test/Makefile.am:20: but option 'subdir-objects' is disabled parallel-tests: installing './test-driver' **configure.ac:10: error: possibly undefined macro: AM_GNU_GETTEXT If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:11: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION** CFLAGS=-O2 -Wall -pipe -g ./configure checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /usr/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether to enable maintainer-specific portions of Makefiles... yes ./configure: line 2937: syntax error near unexpected token `external' ./configure: line 2937: `AM_GNU_GETTEXT(external)' ### System info: DISTRIB_ID=Ubuntu DISTRIB_RELEASE=20.04 DISTRIB_CODENAME=focal DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS" NAME="Ubuntu" VERSION="20.04.2 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.2 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal Issue URL : https://github.com/alsa-project/alsa-utils/issues/99 Repository URL: https://github.com/alsa-project/alsa-utils

1 0