February 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH][next] ASoC: codecs: lpass-rx-macro: Fix uninitialized variable ec_tx
by Colin King 23 Feb '21

23 Feb '21

From: Colin Ian King <colin.king(a)canonical.com> There is potential read of the uninitialized variable ec_tx if the call to snd_soc_component_read fails or returns an unrecognized w->name. To avoid this corner case, initialize ec_tx to -1 so that it is caught later when ec_tx is bounds checked. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 4f692926f562 ("ASoC: codecs: lpass-rx-macro: add dapm widgets and route") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/codecs/lpass-rx-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index c9c21d22c2c4..8c04b3b2c907 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -2895,7 +2895,7 @@ static int rx_macro_enable_echo(struct snd_soc_dapm_widget *w, { struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); u16 val, ec_hq_reg; - int ec_tx; + int ec_tx = -1; val = snd_soc_component_read(component, CDC_RX_INP_MUX_RX_MIX_CFG4); -- 2.30.0

2 1

Add audio LED support - control API and PCM softvol plugin
by GitHub pull_request - opened 23 Feb '21

23 Feb '21

alsa-project/alsa-lib pull request #121 was opened from perexg: As proposed for the driver, this set of patches can resolve the LED handling issue for the hardware without mixer switches or volume controls (like AMD ACP bridge). Request URL : https://github.com/alsa-project/alsa-lib/pull/121 Patch URL : https://github.com/alsa-project/alsa-lib/pull/121.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy
by Romain Perier 23 Feb '21

23 Feb '21

strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding buffer is unbounded. Its safe replacement is strscpy(), as suggested in the deprecated interface [1]. We plan to make this contribution in two steps: - Firsly all cases of strlcpy's return value are manually replaced by the corresponding calls of strscpy() with the new handling of the return value (as the return code is different in case of error). - Then all other cases are automatically replaced by using coccinelle. This series covers manual replacements. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy Romain Perier (20): cgroup: Manual replacement of the deprecated strlcpy() with return values crypto: Manual replacement of the deprecated strlcpy() with return values devlink: Manual replacement of the deprecated strlcpy() with return values dma-buf: Manual replacement of the deprecated strlcpy() with return values kobject: Manual replacement of the deprecated strlcpy() with return values ima: Manual replacement of the deprecated strlcpy() with return values SUNRPC: Manual replacement of the deprecated strlcpy() with return values kernfs: Manual replacement of the deprecated strlcpy() with return values m68k/atari: Manual replacement of the deprecated strlcpy() with return values module: Manual replacement of the deprecated strlcpy() with return values hwmon: Manual replacement of the deprecated strlcpy() with return values s390/hmcdrv: Manual replacement of the deprecated strlcpy() with return values scsi: zfcp: Manual replacement of the deprecated strlcpy() with return values target: Manual replacement of the deprecated strlcpy() with return values ALSA: usb-audio: Manual replacement of the deprecated strlcpy() with return values tracing/probe: Manual replacement of the deprecated strlcpy() with return values vt: Manual replacement of the deprecated strlcpy() with return values usb: gadget: f_midi: Manual replacement of the deprecated strlcpy() with return values usbip: usbip_host: Manual replacement of the deprecated strlcpy() with return values s390/watchdog: Manual replacement of the deprecated strlcpy() with return values arch/m68k/emu/natfeat.c | 6 +-- crypto/lrw.c | 6 +-- crypto/xts.c | 6 +-- drivers/dma-buf/dma-buf.c | 4 +- drivers/hwmon/pmbus/max20730.c | 66 +++++++++++++------------ drivers/s390/char/diag_ftp.c | 4 +- drivers/s390/char/sclp_ftp.c | 6 +-- drivers/s390/scsi/zfcp_fc.c | 8 +-- drivers/target/target_core_configfs.c | 33 ++++--------- drivers/tty/vt/keyboard.c | 5 +- drivers/usb/gadget/function/f_midi.c | 4 +- drivers/usb/gadget/function/f_printer.c | 8 +-- drivers/usb/usbip/stub_main.c | 6 +-- drivers/watchdog/diag288_wdt.c | 12 +++-- fs/kernfs/dir.c | 27 +++++----- kernel/cgroup/cgroup.c | 2 +- kernel/module.c | 4 +- kernel/trace/trace_uprobe.c | 11 ++--- lib/kobject_uevent.c | 6 +-- net/core/devlink.c | 6 +-- net/sunrpc/clnt.c | 6 ++- security/integrity/ima/ima_policy.c | 8 ++- sound/usb/card.c | 4 +- 23 files changed, 129 insertions(+), 119 deletions(-) -- 2.20.1

3 4

[PATCH v2 0/3] HID: elan: Mute LED handling fixes and improvements
by Hans de Goede 23 Feb '21

23 Feb '21

Hi All, Here is v2 of my series with mute LED handling fixes and improvements for the hid-elan driver. New in v2: - Add Marek Behún's Reviewed-by to all patches,thank you for all the reviews Marek. - Improve error handling in patch 1/3 to return -EIO when ret != 3 and >= 0 Regards, Hans Hans de Goede (3): HID: elan: Silence mute LED errors being logged when the device is unplugged HID: elan: Set default_trigger for the mute LED HID: elan: Remove elan_mute_led_get_brigtness() drivers/hid/hid-elan.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) -- 2.30.1

2 5

[PATCH] sound: core: fixed coding style errors
by Rajesh Kumbhakar 23 Feb '21

23 Feb '21

fixing ERROR: "foo * bar" should be "foo *bar" fixing WARNING: Missing a blank line after declarations Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj(a)gmail.com> --- sound/core/hwdep_compat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c index a0b76706c..d8624a14a 100644 --- a/sound/core/hwdep_compat.c +++ b/sound/core/hwdep_compat.c @@ -36,11 +36,13 @@ enum { SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32) }; -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd, +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd, unsigned long arg) { struct snd_hwdep *hw = file->private_data; + void __user *argp = compat_ptr(arg); + switch (cmd) { case SNDRV_HWDEP_IOCTL_PVERSION: case SNDRV_HWDEP_IOCTL_INFO: -- 2.25.1

2 2

yoga 9i bottom speakers do not work
by GitHub issues - edited 23 Feb '21

23 Feb '21

alsa-project/alsa-lib issue #120 was edited from zany130: this might be the same issue as the c940 and legion 7i not sure, but the soundbar works but the bottom speakers don't https://linux-hardware.org/?probe=1f0bdc3a66 I was trying to get the ALSA Information Script running and the script uploaded but it wasn't connecting so here is the file [alsa-info.txt](https://github.com/alsa-project/alsa-lib/files/6026794/alsa-… Issue URL : https://github.com/alsa-project/alsa-lib/issues/120 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

yoga 9i bottom speakers do not work
by GitHub issues - opened 23 Feb '21

23 Feb '21

alsa-project/alsa-lib issue #120 was opened from zany130: this might be the same issue as the c940 and legion 7i not sure, but the soundbar works but the bottom speakers don't https://linux-hardware.org/?probe=1f0bdc3a66 Issue URL : https://github.com/alsa-project/alsa-lib/issues/120 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] sound: soc: codecs: fix kconfig dependency on GPIOLIB
by Julian Braha 22 Feb '21

22 Feb '21

When SND_SOC_DMIC is enabled and GPIOLIB is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for SND_SOC_DMIC Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n] Selected by [y]: - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y] This is because SND_SOC_AMD_RENOIR_MACH selects SND_SOC_DMIC, without depending on or selecting GPIOLIB, despite that config option depending on GPIOLIB. Signed-off-by: Julian Braha <julianbraha(a)gmail.com> --- sound/soc/amd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index a6ce000fac3f..5480dff7a1ad 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -46,6 +46,7 @@ config SND_SOC_AMD_RENOIR config SND_SOC_AMD_RENOIR_MACH tristate "AMD Renoir support for DMIC" + select GPIOLIB select SND_SOC_DMIC depends on SND_SOC_AMD_RENOIR help -- 2.27.0

1 0

[PATCH 1/2] ASoC: rt1015: fix i2c communication error
by jack.yu＠realtek.com 22 Feb '21

22 Feb '21

From: Jack Yu <jack.yu(a)realtek.com> Remove 0x100 cache re-sync to solve i2c communication error. Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt1015.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c index 37b5795b00d1..90767490af82 100644 --- a/sound/soc/codecs/rt1015.c +++ b/sound/soc/codecs/rt1015.c @@ -209,6 +209,7 @@ static bool rt1015_volatile_register(struct device *dev, unsigned int reg) case RT1015_VENDOR_ID: case RT1015_DEVICE_ID: case RT1015_PRO_ALT: + case RT1015_MAN_I2C: case RT1015_DAC3: case RT1015_VBAT_TEST_OUT1: case RT1015_VBAT_TEST_OUT2: -- 2.29.0

2 2

Query on sysclk source
by Sameer Pujar 22 Feb '21

22 Feb '21

Hi All, I do have a query for snd_soc_dai_set_sysclk(). It takes 'clk_id' as argument which is used for sysclk source purpose in some drivers and in some it seems to be used for clock ID specifically. Please see below references. - https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/soun… as sysclk source) - https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/soun… as sysclk source) - https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/soun… actually seems refer to specific clock id) To add snd_soc_component_sysclk() takes both 'clk_id' and 'source' arguments. Currently snd_soc_dai_set_sysclk() has following implementation. ------------------------------------------------------------------ / int snd_soc_dai_set_sysclk(struct snd_soc_dai *dai, int clk_id,// // unsigned int freq, int dir)// // {// // int ret;// // // if (dai->driver->ops &&// //dai->driver->ops->set_sysclk)// // ret = dai->driver->ops->set_sysclk(dai, clk_id, freq, dir);// // else// // ret = snd_soc_component_set_sysclk(dai->component, clk_id, 0,// // freq, dir);// // // return soc_dai_ret(dai, ret);// // }/ ------------------------------------------------------------------- The 'source' for snd_soc_component_set_sysclk() is hardcoded to 0 always, which may not be the case always. Please see below. - https://elixir.bootlin.com/linux/v5.11/source/sound/soc/samsung/bells.c#L161 Hence I am wondering if 'clk_id' argument is being used inconsistently for snd_soc_dai_set_sysclk() and should we rather have a separate 'source' argument for this as well? Thanks, Sameer.

2 1