December 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: sound/isa/gus: check the return value of kstrdup()
by xkernel 12 Dec '21

12 Dec '21

kstrdup() returns NULL when some internal memory errors happen, it is better to check the return value of it. Otherwise, we may not to be able to catch some memory errors in time. Signed-off-by: xkernel <xkernel.wang(a)foxmail.com> --- sound/isa/gus/gus_mem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c index ff9480f..f8d915f 100644 --- a/sound/isa/gus/gus_mem.c +++ b/sound/isa/gus/gus_mem.c @@ -199,6 +199,8 @@ struct snd_gf1_mem_block *snd_gf1_mem_alloc(struct snd_gf1_mem * alloc, int owne memcpy(&block.share_id, share_id, sizeof(block.share_id)); block.owner = owner; block.name = kstrdup(name, GFP_KERNEL); + if (block.name == NULL) + return NULL; nblock = snd_gf1_mem_xalloc(alloc, &block); snd_gf1_mem_lock(alloc, 1); return nblock; @@ -237,13 +239,13 @@ int snd_gf1_mem_init(struct snd_gus_card * gus) block.ptr = 0; block.size = 1024; block.name = kstrdup("InterWave LFOs", GFP_KERNEL); - if (snd_gf1_mem_xalloc(alloc, &block) == NULL) + if (block.name == NULL || snd_gf1_mem_xalloc(alloc, &block) == NULL) return -ENOMEM; } block.ptr = gus->gf1.default_voice_address; block.size = 4; block.name = kstrdup("Voice default (NULL's)", GFP_KERNEL); - if (snd_gf1_mem_xalloc(alloc, &block) == NULL) + if (block.name == NULL || snd_gf1_mem_xalloc(alloc, &block) == NULL) return -ENOMEM; #ifdef CONFIG_SND_DEBUG snd_card_ro_proc_new(gus->card, "gusmem", gus, snd_gf1_mem_info_read); --

1 0

Move the call to expand variables and expressions
by GitHub pull_request - edited 12 Dec '21

12 Dec '21

alsa-project/alsa-utils pull request #127 was edited from ranj063: With the addition of the math expression evaluator in alsa-lib, we can use it to evaluate simple math expresionns for objects attribute values based on other attributes. For ex: we can set the expression for buffer size as follows: buffer_size "$[($in_channels * 48) * 4]" The buffer_size attribute value will be computed with the attribute value "in_channels" based on the expression above. So if $in_channels = 2, buffer_size will be evaluated to 384. Request URL : https://github.com/alsa-project/alsa-utils/pull/127 Patch URL : https://github.com/alsa-project/alsa-utils/pull/127.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Move the call to expand variables and expressions
by GitHub pull_request - edited 12 Dec '21

12 Dec '21

alsa-project/alsa-utils pull request #127 was edited from ranj063: With the addition of the math expression evaluator in alsa-lib, we can use it to evaluate simple math expresionns for objects attribute values based on other attributes. For ex: we can set the expression for buffer size as follows: buffer_size "$[$[$in_channels * 48] * 4]" The buffer_size attribute value will be computed with the attribute value "in_channels" based on the expression above. So if $in_channels = 2, buffer_size will be evaluated to 384. Request URL : https://github.com/alsa-project/alsa-utils/pull/127 Patch URL : https://github.com/alsa-project/alsa-utils/pull/127.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

S24LE and S32LE format equivalency
by Marios Sioutis 12 Dec '21

12 Dec '21

Hi all, Quick question, I was troubleshooting a 24bit USB device and got down the rabbit hole of sample formats. The device advertises itself as S24LE (4byte payload) but it appears as S32LE under alsa, something that bothered me a lot initially. However, If the conversion between the two formats is to just << 8 i.e. put a zero byte as LSB, then the two formats are essentially equivalent. Is this actually the case? If yes, who performs the conversion? Is it on the alsa side, or the device already adds a zero byte LSB? Thank you in advance, Marios

2 3

[PATCH v4 0/3] kselftest: alsa: Add basic mixer selftest
by Mark Brown 12 Dec '21

12 Dec '21

This series adds a basic selftest for the mixer interface, as discussed in the cover letter for the main patch there's plenty of additional coverage that could be added but this is a good starting point. v4: - More stylistic updates suggested by Shuah. - Fix build with older alsa-lib. v3: - Pull in incremental updates adding a fixed library configuration from Jaroslav and support for volatile controls from Takashi Sakamoto. - Stylistic updates suggested by Shuah. v2: - Use pkg-config to get CFLAGS and LDLIBS for alsa-lib. Jaroslav Kysela (1): kselftest: alsa: Use private alsa-lib configuration in mixer test Mark Brown (1): kselftest: alsa: Add simplistic test for ALSA mixer controls kselftest Takashi Sakamoto (1): kselftest: alsa: optimization for SNDRV_CTL_ELEM_ACCESS_VOLATILE MAINTAINERS | 8 + tools/testing/selftests/Makefile | 3 +- tools/testing/selftests/alsa/.gitignore | 1 + tools/testing/selftests/alsa/Makefile | 9 + tools/testing/selftests/alsa/mixer-test.c | 665 ++++++++++++++++++++++ 5 files changed, 685 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/alsa/.gitignore create mode 100644 tools/testing/selftests/alsa/Makefile create mode 100644 tools/testing/selftests/alsa/mixer-test.c base-commit: fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf -- 2.30.2

2 4

Add ALC287 speaker fixup for Lenovo IdeaPad Slim 9i 14ITL5
by Bart Kroon 12 Dec '21

12 Dec '21

Hello, The speaker fixup that is used for the Yoga 7 14ITL5 also applies to the IdeaPad Slim 9i 14ITL5. The attached patch applies the quirk. The attached patch is validated on my laptop. Regards, Bart

2 1

[PATCH] ALSA: sparc: no need to initialise statics to 0
by Jason Wang 12 Dec '21

12 Dec '21

Static variables do not need to be initialised to 0, because compiler will initialise all uninitialised statics to 0. Thus, remove the unneeded initializations. Signed-off-by: Jason Wang <wangborong(a)cdjrlc.com> --- sound/sparc/dbri.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c index 6b84f66e4af4..3881e1c1b08a 100644 --- a/sound/sparc/dbri.c +++ b/sound/sparc/dbri.c @@ -688,7 +688,7 @@ static void dbri_cmdsend(struct snd_dbri *dbri, s32 *cmd, int len) { u32 dvma_addr = (u32)dbri->dma_dvma; s32 tmp, addr; - static int wait_id = 0; + static int wait_id; wait_id++; wait_id &= 0xffff; /* restrict it to a 16 bit counter. */ @@ -1926,7 +1926,7 @@ static void dbri_process_interrupt_buffer(struct snd_dbri *dbri) static irqreturn_t snd_dbri_interrupt(int irq, void *dev_id) { struct snd_dbri *dbri = dev_id; - static int errcnt = 0; + static int errcnt; int x; if (dbri == NULL) @@ -2591,7 +2591,7 @@ static int dbri_probe(struct platform_device *op) struct snd_dbri *dbri; struct resource *rp; struct snd_card *card; - static int dev = 0; + static int dev; int irq; int err; -- 2.34.1

2 1

ALSA: drivers: opl3: assignment of a pointer that is not used, probable bug
by Colin King (gmail) 12 Dec '21

12 Dec '21

Hi, static analysis with scan-build has found an assignment to vp2 that is never used in function snd_opl3_note_on(), sound/drivers/opl3/opl3_midi.c as follows: if (instr_4op) { vp2 = &opl3->voices[voice + 3]; if (vp->state > 0) { opl3_reg = reg_side | (OPL3_REG_KEYON_BLOCK + voice_offset + 3); reg_val = vp->keyon_reg & ~OPL3_KEYON_BIT; opl3->command(opl3, opl3_reg, reg_val); } } sound/drivers/opl3/opl3_midi.c:399:3: warning: Value stored to 'vp2' is never read [deadcode.DeadStores] vp2 = &opl3->voices[voice + 3]; ^ ~~~~~~~~~~~~~~~~~~~~~~~~ I suspect that references to vp in this if block should be to vp2, but I'm unsure if that is for all references or not, hence I'm reporting this issue. Coln

2 1

[PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6
by Bradley Scott 12 Dec '21

12 Dec '21

HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier initialization as used on several other HP laptops using ALC285. This commit also adds a new "alc285-hp-amp-init" model that can be used to apply this same amp init fixup to other devices by passing "hda_model=alc285-hp-amp-init" to the snd-sof-intel-hda-common module or "model=alc285-hp-amp-init" to the snd-hda-intel module, depending on which is being used. Signed-off-by: Bradley Scott <Bradley.Scott(a)zebra.com> --- Documentation/sound/hd-audio/models.rst | 2 ++ sound/pci/hda/patch_realtek.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Documentation/sound/hd-audio/models.rst b/Documentation/sound/hd-audio/models.rst index 0ea967d34583..d25335993e55 100644 --- a/Documentation/sound/hd-audio/models.rst +++ b/Documentation/sound/hd-audio/models.rst @@ -326,6 +326,8 @@ usi-headset Headset support on USI machines dual-codecs Lenovo laptops with dual codecs +alc285-hp-amp-init + HP laptops which require speaker amplifier initialization (ALC285) ALC680 ====== diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3599f4c85ebf..fc41f3e8ddc3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8660,6 +8660,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN), SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), + SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO), @@ -9123,6 +9124,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name = "alc287-ideapad-bass-spk-amp"}, {.id = ALC623_FIXUP_LENOVO_THINKSTATION_P340, .name = "alc623-lenovo-thinkstation-p340"}, {.id = ALC255_FIXUP_ACER_HEADPHONE_AND_MIC, .name = "alc255-acer-headphone-and-mic"}, + {.id = ALC285_FIXUP_HP_GPIO_AMP_INIT, .name = "alc285-hp-amp-init"}, {} }; #define ALC225_STANDARD_PINS \ -- 2.25.1 ________________________________ - CONFIDENTIAL- This email and any files transmitted with it are confidential, and may also be legally privileged. If you are not the intended recipient, you may not review, use, copy, or distribute this message. If you receive this email in error, please notify the sender immediately by reply email and then delete this email.

2 1

Add profile for Behringer UMC204HD
by GitHub pull_request - opened 12 Dec '21

12 Dec '21

alsa-project/alsa-ucm-conf pull request #128 was opened from brndd: Adds a profile for the Behringer UMC204HD to split a 4-channel output into two outputs, and a 2-channel input into two inputs, as per the physical layout of the device. I have very little idea what I'm doing, so let me know if something looks incorrect (there's one thing that looks incorrect even to me which I shall point out in a comment below). The config does at least work, though. [alsa-info.txt](https://github.com/alsa-project/alsa-ucm-conf/files/7698277/… ----- ![UMC204HD_P0BK0_Front_XL](https://user-images.githubusercontent.com/5822375/145704001-5bb9b741-0d1f-4f83-8184-6335c9b53fbf.png) ![UMC204HD_P0BK0_Rear_XL](https://user-images.githubusercontent.com/5822375/145703999-918614e6-3298-4191-a7b6-7260e8eb3638.png) Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/128 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/128.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0