December 2021 - Alsa-devel - mailman.alsa-project.org

Missing profile 7.1
by GitHub issues - opened 19 Dec '21

19 Dec '21

alsa-project/alsa-utils issue #128 was opened from raven2cz: Hello, I have several years profile 7.1 which is missing now around 1.5-2months. I already write these issues * https://bbs.archlinux.org/viewtopic.php?id=272280 * https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1309 It seems that the problem can be in alsa-utils. ``` control.45 { iface PCM name 'Playback Channel Map' value.0 0 value.1 0 value.2 0 value.3 0 value.4 0 value.5 0 comment { access read type INTEGER count 6 range '0 - 36' } } ``` I already try to change kernels, not help. See inside the issues whole test env. Can you help me? Issue URL : https://github.com/alsa-project/alsa-utils/issues/128 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH 1/3] ASoC: dt-bindings: Use name-prefix schema
by Alexander Stein 18 Dec '21

18 Dec '21

name-prefix.txt does not exist anymore, just reference the schema instead. Signed-off-by: Alexander Stein <alexander.stein(a)mailbox.org> --- .../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml index 26379377a7ac..1f0327474744 100644 --- a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml +++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml @@ -9,6 +9,9 @@ title: Simple Audio Amplifier Device Tree Bindings maintainers: - Jerome Brunet <jbrunet(a)baylibre.com> +allOf: + - $ref: name-prefix.yaml# + properties: compatible: enum: @@ -22,10 +25,7 @@ properties: description: > power supply for the device - sound-name-prefix: - $ref: /schemas/types.yaml#/definitions/string - description: > - See ./name-prefix.txt + sound-name-prefix: pass required: - compatible -- 2.34.1

1 2

Re: [syzbot] KMSAN: uninit-value in snd_rawmidi_ioctl
by Jaroslav Kysela 18 Dec '21

18 Dec '21

On 18. 12. 21 12:17, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 8b936c96768e kmsan: core: remove the accidentally committe.. > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=11791d89b00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=e00a8959fdd3f3e8 > dashboard link: https://syzkaller.appspot.com/bug?extid=88412ee8811832b00dbe > compiler: clang version 14.0.0 (git@github.com:llvm/llvm-project.git 0996585c8e3b3d409494eb5f1cad714b9e1f7fb5), GNU ld (GNU Binutils for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13a7abf9b00000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=172410b9b00000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+88412ee8811832b00dbe(a)syzkaller.appspotmail.com > > ===================================================== > BUG: KMSAN: uninit-value in snd_rawmidi_ioctl+0xf1e/0x1330 sound/core/rawmidi.c:887 > snd_rawmidi_ioctl+0xf1e/0x1330 sound/core/rawmidi.c:887 Nice catch. I wonder why the problem was not detected by tests. The patch bellow should initialize the user_pversion variable: diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index 6f30231bdb88..befa9809ff00 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -447,6 +447,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file) err = -ENOMEM; goto __error; } + rawmidi_file->user_pversion = 0; init_waitqueue_entry(&wait, current); add_wait_queue(&rmidi->open_wait, &wait); while (1) { I'll send the path in the proper format ASAP. Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0

ALSA update from 1.2.5.1 to 1.2.6.1 loses audio devices on Dell XPS 9700
by GitHub issues - opened 18 Dec '21

18 Dec '21

alsa-project/alsa-lib issue #206 was opened from roland-d: Hello, On December 16, Manjaro pushed an update which included an ALSA update from 1.2.5.1 to 1.2.6.1. This has caused users of a DELL XPS 9700 to no longer show any audio devices except the built-in speaker. This has been reported in the release post as well by a user named sparcplug. https://forum.manjaro.org/t/stable-update-2021-12-16-kernels-kde-gear-21-12… I can confirm that for me the audio devices also disappeared. A rollback to 1.2.5.1 and restart of the system brought back the sound devices. I have no idea what causes this but wanted to report it and if you need me to test I am happy to do so. Issue URL : https://github.com/alsa-project/alsa-lib/issues/206 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

rawmidi driver dropping some sysex commands
by Kolten Pearson 17 Dec '21

17 Dec '21

I have been working on reverse engineering the sysex commands to control an Arturia MiniLab mkII controller, and have run into an issue where the rawmidi driver is dropping some of the commands. Here is a snippet of my code that illustrates the problem --- snd_rawmidi_t* midi_input; snd_rawmidi_t* midi_output; void midi_init() { int ret = snd_rawmidi_open(&midi_input, &midi_output, "hw:3,0,0", SND_RAWMIDI_NONBLOCK); assert (ret == 0 && "could not open midi device"); uint8_t pad_list[] = { MA_PAD_1, MPC_NO_COLOR, MA_PAD_2, MPC_RED, MA_PAD_3, MPC_GREEN, MA_PAD_4, MPC_YELLOW, MA_PAD_5, MPC_BLUE, MA_PAD_6, MPC_CYAN, MA_PAD_7, MPC_MAGENTA, MA_PAD_8, MPC_WHITE, MA_PAD_9, MPC_NO_COLOR, MA_PAD_10, MPC_RED, MA_PAD_11, MPC_GREEN, MA_PAD_12, MPC_YELLOW, MA_PAD_13, MPC_BLUE, MA_PAD_14, MPC_CYAN, MA_PAD_15, MPC_MAGENTA, MA_PAD_16, MPC_WHITE, }; for (int i = 0; i < 16; i++) { midi_set(MC_ON_OFF, pad_list[2*i], 0x08); //sets the pad to be a control instead of a note midi_set(MC_MIN_RANGE, pad_list[2*i], 0); midi_set(MC_MAX_RANGE, pad_list[2*i], 1); midi_set(MC_MODE_SET, pad_list[2*i], 1); //set it to gate, 0 is toggle midi_set(MC_PAD_COLOR, pad_list[2*i], pad_list[2*i+1]); } midi_set(MC_GLOBAL_SET, MA_PAD_BACKLIGHTS, 0x0f); //updates the pad backlights uint8_t knob_list[] = { MA_KNOB_1, MA_KNOB_2, MA_KNOB_3, MA_KNOB_4, MA_KNOB_5, MA_KNOB_6, MA_KNOB_7, MA_KNOB_8, MA_KNOB_9, MA_KNOB_10, MA_KNOB_11, MA_KNOB_12, MA_KNOB_13, MA_KNOB_14, MA_KNOB_15, MA_KNOB_16 }; for (int i = 0; i < 16; i++) { midi_set(MC_MODE_SET, knob_list[i], 0x02); //sets it to relative mode where 0-3 is right turn, 7f-7d is left turn midi_set(MC_CC_SET, knob_list[i], i); } } void midi_set(enum midi_set_command command, enum midi_set_address address, uint8_t data) { uint8_t raw_command[] = {0xf0, 0x00, 0x20, 0x6b, 0x7f, 0x42, 0x02, 0x00, command, address, data, 0xf7}; int count = snd_rawmidi_write(midi_output, raw_command, sizeof(raw_command)); assert(count == sizeof(raw_command) && "bad write"); //SDL_Delay(1); int ret = snd_rawmidi_drain(midi_output); assert(ret == 0 && "could not drain"); } --- When this code is run, the minilab will only respond to a nondeterministic number of calls to the midi_set function and ignore the rest. However if the SDL_Delay(1) line is uncommented, it will work correctly every time (This function call causes the process to sleep for at least 1 millisecond). I feel like the call to snd_rawmidi_drain should make the SDL_Delay call unnecessary, but that is not the case. Is there something I am not understanding about how the api works? Thanks for any help!

2 1

ALSA 1.2.6.3 release
by Jaroslav Kysela 17 Dec '21

17 Dec '21

Hello all, new ALSA userspace packages were released. This is third bugfix release. You may download them from the ALSA website http://www.alsa-project.org or directly: HTTP: https://www.alsa-project.org/files/pub FTP: ftp://ftp.alsa-project.org/pub Released packages: alsa-ucm-conf Full list of changes: https://www.alsa-project.org/wiki/Changes_v1.2.6.2_v1.2.6.3 The fingerprint of the public signing key is: F04D F507 37AC 1A88 4C4B 3D71 8380 596D A6E5 9C91 Have fun, Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0

[PATCH v5 00/11] Support HDMI audio on NVIDIA Tegra20
by Dmitry Osipenko 17 Dec '21

17 Dec '21

This series revives Tegra20 S/PDIF driver which was upstreamed long time ago, but never was used. It also turns Tegra DRM HDMI driver into HDMI audio CODEC provider. Finally, HDMI audio is enabled in device-trees. For now the audio is enable only for Acer A500 tablet and Toshiba AC100 netbook because they're already supported by upstream, later on ASUS TF101 tablet will join them. (!) These patches are made on top of stable dmaengine branch from Vinod Koul. The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux 5.16-rc1 (2021-11-14 13:56:52 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git tags/dmaengine_topic_slave_id_removal_5.17 for you to fetch changes up to 3c219644075795a99271d345efdfa8b256e55161: dmaengine: remove slave_id config field (2021-12-17 11:23:56 +0530) Changelog: v5: - Dropped all patches that were already applied by Thierry Reding. - Made minor changes that were suggested by Thierry Reding. - Added acks from Thierry Reding. - Rebased patches on top of stable dmaengine branch from Vinod Koul. v4: - Added patches that update multi_v7_defconfig with the enabled S/PDIF and APB DMA drivers. v3: - Renamed S/PDIF device-tree clocks as was suggested by Rob Herring. - Added r-bs and acks that were given by Rob Herring to v2. v2: - Corrected I2S yaml problem that was reported by the DT bot for v1 by removing the non-existent required clock-names property. - Removed assigned-clocks property from S/PDIF yaml since this property is now inherited from the clocks property. - Reordered the "tegra20: spdif: Set FIFO trigger level" patch, making it the first sound/soc patch in the series, like it was suggested by Mark Brown in the comment to v1. Also reworded commit message of this patch to *not* make it looks like it should be backported to stable kernels. Dmitry Osipenko (11): ASoC: dt-bindings: Add binding for Tegra20 S/PDIF ASoC: dt-bindings: tegra20-i2s: Convert to schema ASoC: dt-bindings: tegra20-i2s: Document new nvidia,fixed-parent-rate property ASoC: tegra20: spdif: Set FIFO trigger level ASoC: tegra20: spdif: Support device-tree ASoC: tegra20: spdif: Improve driver's code ASoC: tegra20: spdif: Use more resource-managed helpers ASoC: tegra20: spdif: Reset hardware ASoC: tegra20: spdif: Support system suspend ASoC: tegra20: spdif: Filter out unsupported rates ASoC: tegra20: i2s: Filter out unsupported rates .../bindings/sound/nvidia,tegra20-i2s.txt | 30 --- .../bindings/sound/nvidia,tegra20-i2s.yaml | 77 +++++++ .../bindings/sound/nvidia,tegra20-spdif.yaml | 85 ++++++++ sound/soc/tegra/tegra20_i2s.c | 49 +++++ sound/soc/tegra/tegra20_spdif.c | 198 +++++++++++++----- sound/soc/tegra/tegra20_spdif.h | 1 + sound/soc/tegra/tegra_pcm.c | 6 + sound/soc/tegra/tegra_pcm.h | 1 + 8 files changed, 359 insertions(+), 88 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-spdif.yaml -- 2.33.1

1 12

[PATCH 0/6] ASoC : soc-pcm: fix trigger race conditions with shared BE
by Pierre-Louis Bossart 17 Dec '21

17 Dec '21

We've been adding a 'deep buffer' PCM device to several SOF topologies in order to reduce power consumption. The typical use-case would be music playback over a headset: this additional PCM device provides more buffering and longer latencies, leaving the rest of the system sleep for longer periods. Notifications and 'regular' low-latency audio playback would still use the 'normal' PCM device and be mixed with the 'deep buffer' before rendering on the headphone endpoint. The tentative direction would be to expose this alternate device to PulseAudio/PipeWire/CRAS via the UCM SectionModifier definitions. That seemed a straightforward topology change until our automated validation stress tests started reporting issues on SoundWire platforms, when e.g. two START triggers might be send and conversely the STOP trigger is never sent. The SoundWire stream state management flagged inconsistent states when the two 'normal' and 'deep buffer' devices are used concurrently with rapid play/stop/pause monkey testing. Looking at the soc-pcm.c code, it seems that the BE state management needs a lot of love. a) there is no consistent protection for the BE state. In some parts of the code, the state updates are protected by a spinlock but in the trigger they are not. When we open/play/close the two PCM devices in stress tests, we end-up testing a state that is being modified. That can't be good. b) there is a conceptual deadlock: on stop we check the FE states to see if a shared BE can be stopped, but since we trigger the BE first the FE states have not been modified yet, so the TRIGGER_STOP is never sent. This patchset suggests the removal of the dedicated 'dpcm_lock' and follows the design suggested by Takashi Iwai. By default the protection relies on the 'pcm_mutex', except for the FE and BE triggers where the mutex cannot be used. In this case, the FE PCM lock is used instead. In the cases where a BE is added/removed, the pcm_mutex and FE PCM lock are both taken. In addition, the BE PCM lock is used to serialize access to a shared BE. With these patches I am able to run our entire validation suite without any issues with this new 'deep buffer' topology, and no regressions on existing solutions [1]. The tests were reproduced by Bard Liao for SoundWire devices. One might ask 'how come we didn't see this earlier'? The answer is probably that the .trigger callbacks in most implementations seems to perform DAPM operations, and sending the triggers multiple times is not an issue. In the case of SoundWire, we do use the .trigger callback to reconfigure the bus using the 'bank switch' mechanism. It could be acceptable to tolerate a trigger multiple times, but the deadlock on stop cannot be fixed at the SoundWire level alone. Opens: 1) The issues reported by Nvidia on the RFCv3 may or may not be present. We'd need test results to make sure the locking update does not introduce a regression on Tegra. 2) There are other reports of kernel oopses [2] that seem related to the lack of protection. I'd be good to confirm if this patchset solve these problems as well. [1] https://github.com/thesofproject/linux/pull/3146 [2] https://lore.kernel.org/alsa-devel/002f01d7b4f5$c030f4a0$4092dde0$@samsung.… changes since RFCv3: Used two patches from Takashi. We now use the pcm_mutex, the FE stream lock when adding and deleting a BE, and the BE stream lock to handle concurrency between streams using the same BE. Added a patch to use GFP_ATOMIC for the DPCM structure. Fixed PAUSE_RELEASE transition (GitHub comment from Kai Vehmanen) changes since RFCv2: Removal of dpcm_lock to use FE PCM locks (credits to Takashi Iwai for the suggestion). The FE PCM lock is now used before each use of for_each_dpcm_be() - with the exception of the trigger where the lock is already taken. This change is also applied in drivers which make use of this loop (compress, SH, FSL). Addition of BE PCM lock to deal with mutual exclusion between triggers for the same BE. Alignment of the BE atomicity on the FE on connections, this is required to avoid sleeping in atomic context. Additional cleanups (indentation, static functions) changes since RFC v1: Removed unused function Removed exported symbols only used in soc-pcm.c, used static instead Use a mutex instead of a spinlock Protect all for_each_dpcm_be() loops Fix bugs introduced in the refcount Pierre-Louis Bossart (4): ASoC: soc-pcm: use GFP_ATOMIC for dpcm structure ASoC: soc-pcm: align BE 'atomicity' with that of the FE ASoC: soc-pcm: test refcount before triggering ASoC: soc-pcm: fix BE handling of PAUSE_RELEASE Takashi Iwai (2): ASoC: soc-pcm: Fix and cleanup DPCM locking ASoC: soc-pcm: serialize BE triggers include/sound/soc-dpcm.h | 2 + include/sound/soc.h | 2 - sound/soc/soc-core.c | 1 - sound/soc/soc-pcm.c | 351 +++++++++++++++++++++++++++------------ 4 files changed, 246 insertions(+), 110 deletions(-) -- 2.25.1

3 11

[PATCH] ASoC: max98357a: Add mixer control to mute/unmute speaker
by Ajit Kumar Pandey 17 Dec '21

17 Dec '21

Add "Playback Switch" mixer control to mute or unmute speaker playback from ucm conf depend on use cases. Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey(a)amd.com> --- sound/soc/codecs/max98357a.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 918812763884..9b2f16ab4498 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -73,6 +73,36 @@ static int max98357a_sdmode_event(struct snd_soc_dapm_widget *w, return 0; } +static int speaker_mute_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct max98357a_priv *max98357a = snd_soc_component_get_drvdata(component); + + ucontrol->value.enumerated.item[0] = max98357a->sdmode_switch; + + return 0; +} + +static int speaker_mute_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct max98357a_priv *max98357a = snd_soc_component_get_drvdata(component); + int mode = ucontrol->value.enumerated.item[0]; + + max98357a->sdmode_switch = mode; + gpiod_set_value_cansleep(max98357a->sdmode, mode); + dev_dbg(component->dev, "set sdmode to %d", mode); + + return 0; +} + +static const struct snd_kcontrol_new max98357a_snd_controls[] = { + SOC_SINGLE_BOOL_EXT("Playback Switch", 0, + speaker_mute_get, speaker_mute_put), +}; + static const struct snd_soc_dapm_widget max98357a_dapm_widgets[] = { SND_SOC_DAPM_OUTPUT("Speaker"), SND_SOC_DAPM_OUT_DRV_E("SD_MODE", SND_SOC_NOPM, 0, 0, NULL, 0, @@ -86,6 +116,8 @@ static const struct snd_soc_dapm_route max98357a_dapm_routes[] = { }; static const struct snd_soc_component_driver max98357a_component_driver = { + .controls = max98357a_snd_controls, + .num_controls = ARRAY_SIZE(max98357a_snd_controls), .dapm_widgets = max98357a_dapm_widgets, .num_dapm_widgets = ARRAY_SIZE(max98357a_dapm_widgets), .dapm_routes = max98357a_dapm_routes, -- 2.25.1

3 7

[PATCH v5 00/10] Add support for CS35L41 in HDA systems
by Lucas Tanure 17 Dec '21

17 Dec '21

Add support for laptops that have CS35L41 connected to an HDA codec by I2S and direct I2C connection to the CPU. Laptops that use CS35L41 and are SPI will be added in the future, after the support for it is resolved at i2c-multi-instantiate driver. i2c-multi-instantiate thread: https://lkml.org/lkml/2021/12/10/557 Hardware: - Some laptops have two CS35L41 amplifiers, connected to Realtek ALC287 by an I2S bus and by and direct I2C to the CPU. - The ALC287 codec is connected to the CPU by an HDA bus. - The CS35L41 has a DSP which will require firmware to be loaded. Architecture: - Creation of a library of shared functions for CS35L41 ASoC and HDA - HDA codec driver (RealTek) and CS35L41 HDA driver are combined by using component binding, where it uses device names to find the components and bind to the master - The HDA CS35L41 driver applies pre-defined registers sequences for each action in playback for HDA Sound card Changes from V4: - Save index received from ACPI for latter use in DSP Support - Move CS35L41_DSP1_CCM_CORE_CTRL to regmap_write so doesn't affect DSP hibernation feature V4: https://lkml.org/lkml/2021/12/14/487 Changes from V3: - SPI bus driver starter added - Use separate modules approach instead of liking library - Add CSC3551 ACPI _HID for more I2C laptops - Removed regulators from HDA driver - Add note about Non-conforming _HID V3: https://lkml.org/lkml/2021/11/23/723 Changes from V2: - Not an RFC - Create a new HDA driver for CS35L41 instead of using the ASoC one - Use component binding and device names to find the CS35L41 driver - Create a shared library for ASoC and HDA CS35L41 drivers v2: https://lkml.org/lkml/2021/10/8/344 Lucas Tanure (9): ASoC: cs35l41: Convert tables to shared source code ASoC: cs35l41: Move cs35l41_otp_unpack to shared code ASoC: cs35l41: Move power initializations to reg_sequence ASoC: cs35l41: Create shared function for errata patches ASoC: cs35l41: Create shared function for setting channels ASoC: cs35l41: Create shared function for boost configuration hda: cs35l41: Add support for CS35L41 in HDA systems ACPI / scan: Create platform device for CLSA0100 and CSC3551 ACPI nodes ALSA: hda/realtek: Add support for Legion 7 16ACHg6 laptop Stefan Binding (1): ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops MAINTAINERS | 2 + drivers/acpi/scan.c | 3 + drivers/platform/x86/i2c-multi-instantiate.c | 11 + include/sound/cs35l41.h | 739 ++++++++++++++++++ sound/pci/hda/Kconfig | 27 + sound/pci/hda/Makefile | 10 + sound/pci/hda/cs35l41_hda.c | 527 +++++++++++++ sound/pci/hda/cs35l41_hda.h | 69 ++ sound/pci/hda/cs35l41_hda_i2c.c | 66 ++ sound/pci/hda/cs35l41_hda_spi.c | 63 ++ sound/pci/hda/hda_component.h | 20 + sound/pci/hda/patch_realtek.c | 144 ++++ sound/soc/codecs/Kconfig | 7 + sound/soc/codecs/Makefile | 4 +- sound/soc/codecs/cs35l41-i2c.c | 1 - .../{cs35l41-tables.c => cs35l41-lib.c} | 355 ++++++++- sound/soc/codecs/cs35l41-spi.c | 1 - sound/soc/codecs/cs35l41.c | 360 +-------- sound/soc/codecs/cs35l41.h | 734 ----------------- 19 files changed, 2051 insertions(+), 1092 deletions(-) create mode 100644 sound/pci/hda/cs35l41_hda.c create mode 100644 sound/pci/hda/cs35l41_hda.h create mode 100644 sound/pci/hda/cs35l41_hda_i2c.c create mode 100644 sound/pci/hda/cs35l41_hda_spi.c create mode 100644 sound/pci/hda/hda_component.h rename sound/soc/codecs/{cs35l41-tables.c => cs35l41-lib.c} (71%) -- 2.34.1

2 11