October 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: usb-audio: Less restriction for low-latency playback mode
by Takashi Iwai 11 Oct '21

11 Oct '21

The recent support for the improved low-latency playback mode applied the SNDRV_PCM_INFO_EXPLICIT_SYNC flag for the target streams, but this was a slight overkill. The use of the flag above disables effectively both PCM status and control mmaps, while basically what we want to track is only about the appl_ptr update. For less restriction, use a more proper flag, SNDRV_PCM_INFO_SYNC_APPLPTR instead, which disables only the control mmap. Fixes: d5f871f89e21 ("ALSA: usb-audio: Improved lowlatency playback support") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 3bb095a3c9b6..95ec8eec1bb0 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -1102,7 +1102,7 @@ static int snd_usb_pcm_open(struct snd_pcm_substream *substream) /* need an explicit sync to catch applptr update in low-latency mode */ if (direction == SNDRV_PCM_STREAM_PLAYBACK && as->chip->lowlatency) - runtime->hw.info |= SNDRV_PCM_INFO_EXPLICIT_SYNC; + runtime->hw.info |= SNDRV_PCM_INFO_SYNC_APPLPTR; runtime->private_data = subs; subs->pcm_substream = substream; /* runtime PM is also done there */ -- 2.31.1

1 0

None
by srinivas.kandagatla＠linaro.org 11 Oct '21

11 Oct '21

On 08/10/2021 16:30, Mark Brown wrote: > On Fri, Oct 08, 2021 at 07:37:12PM +0530, Srinivasa Rao Mandadapu wrote: >> On 9/28/2021 2:01 PM, Srinivas Kandagatla wrote: > >>> In that case you should probably consider using regmap_register_patch() >>> for corrections to the default registers in sm8250 case. > >> As regmap_register_patch() not working in this use case, updating defaults >> in probe for sc7280 specific differences. > > In what way is regmap_register_patch() not working? SM8250 and SC7280 has different register defaults values for few (atleast 2 that we are aware of) registers. Initially we thought regmap_register_patch() would help in this case, but later learned that it was designed for completely different usecase and this will not update the cache values with the new values from reg_sequence passed to regmap_register_patch(). What we want was to be able to reflect that default values in the regcaches, so that subsequent writes are not ignored based on incorrect cache values. There are two ways to fix this, one is to come up with a full default register list specific to SC7280 or reuse SM8250 defaults with some modifications, other option is to update default registers based on compatible string before regmap creation. I suggested Srinivasa to use the second option as 99% of the defaults match to SM8250. --srini >

1 0

[PATCH] ALSA: hda/realtek: Fix for quirk to enable speaker output on the Lenovo 13s Gen2.
by Cameron Berkenpas 11 Oct '21

11 Oct '21

The previous patch's HDA verb initialization for the Lenovo 13s sequence was slightly off. This updated verb sequence has been tested and confirmed working. Fixes: ad7cc2d41b7a ("ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion 7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops.") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208555 Cc: <stable(a)vger.kernel.org> Cc: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Cameron Berkenpas <cam(a)neo-zeon.de> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4407f7da57c4..84d3e062a335 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8344,7 +8344,7 @@ static const struct hda_fixup alc269_fixups[] = { .v.verbs = (const struct hda_verb[]) { { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x41 }, - { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x2 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 }, -- 2.30.2

2 1

None
by srivasam＠codeaurora.org 11 Oct '21

11 Oct '21

On 10/8/2021 9:00 PM, Mark Brown wrote: > On Fri, Oct 08, 2021 at 07:37:12PM +0530, Srinivasa Rao Mandadapu wrote: >> On 9/28/2021 2:01 PM, Srinivas Kandagatla wrote: >>> In that case you should probably consider using regmap_register_patch() >>> for corrections to the default registers in sm8250 case. >> As regmap_register_patch() not working in this use case, updating defaults >> in probe for sc7280 specific differences. > In what way is regmap_register_patch() not working? Even after using this API, reg cache is not updating with the latest default values. The regmap_register_patch() implementation is bypassing Cache and writing values to HW. The requirement for updating previous defaults in cache is not solving here. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

1 0

None
by srivasam＠codeaurora.org 11 Oct '21

11 Oct '21

On 10/8/2021 9:00 PM, Mark Brown wrote: > On Fri, Oct 08, 2021 at 07:37:12PM +0530, Srinivasa Rao Mandadapu wrote: >> On 9/28/2021 2:01 PM, Srinivas Kandagatla wrote: >>> In that case you should probably consider using regmap_register_patch() >>> for corrections to the default registers in sm8250 case. >> As regmap_register_patch() not working in this use case, updating defaults >> in probe for sc7280 specific differences. > In what way is regmap_register_patch() not working? Even after using this API, reg cache is not updating with the latest default values. The regmap_register_patch() implementation is bypassing Cache and writing values to HW. The requirement for updating previous defaults in cache is not solving here. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

1 0

[PATCH 1/3] ASoc: amd: create platform device for VG machine driver
by Vijendar Mukunda 11 Oct '21

11 Oct '21

Create platform device for Vangogh machine driver. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/amd/vangogh/acp5x.h | 2 +- sound/soc/amd/vangogh/pci-acp5x.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h index a808635f9740..fe5e1fa98974 100644 --- a/sound/soc/amd/vangogh/acp5x.h +++ b/sound/soc/amd/vangogh/acp5x.h @@ -23,7 +23,7 @@ #define ACP_ERR_INTR_MASK 0x20000000 #define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF -#define ACP5x_DEVS 3 +#define ACP5x_DEVS 4 #define ACP5x_REG_START 0x1240000 #define ACP5x_REG_END 0x1250200 #define ACP5x_I2STDM_REG_START 0x1242400 diff --git a/sound/soc/amd/vangogh/pci-acp5x.c b/sound/soc/amd/vangogh/pci-acp5x.c index a57b762d9f2e..137e64c47882 100644 --- a/sound/soc/amd/vangogh/pci-acp5x.c +++ b/sound/soc/amd/vangogh/pci-acp5x.c @@ -213,6 +213,9 @@ static int snd_acp5x_probe(struct pci_dev *pci, pdevinfo[2].num_res = 1; pdevinfo[2].res = &adata->res[2]; + pdevinfo[3].name = "acp5x_nu8821_cs35l41_mach"; + pdevinfo[3].id = 0; + pdevinfo[3].parent = &pci->dev; for (i = 0; i < ACP5x_DEVS; i++) { adata->pdev[i] = platform_device_register_full(&pdevinfo[i]); -- 2.25.1

3 6

[PATCH] ALSA: hda/realtek: Fix for quirk to enable speaker output on the Lenovo 13s Gen2.
by Cameron Berkenpas 10 Oct '21

10 Oct '21

The previous patch's HDA verb initialization for the Lenovo 13s sequence was slightly off. This updated verb sequence has been tested and confirmed working. --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4407f7da57c4..84d3e062a335 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8344,7 +8344,7 @@ static const struct hda_fixup alc269_fixups[] = { .v.verbs = (const struct hda_verb[]) { { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x41 }, - { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 }, + { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x2 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 }, { 0x20, AC_VERB_SET_PROC_COEF, 0x0 }, -- 2.30.2

2 1

[PATCH v4 0/4] ASoC: Intel: bytcht_es8316: few cleanups
by Andy Shevchenko 10 Oct '21

10 Oct '21

The small set of cleanups against bytcht_es8316 board file. In v4: - fixed Pierre's email (Pierre) - added Hans to the Cc list In v3: - actually added a Pierre's tag (Mark) In v2: - added tag (Pierre) - added commit message to the patch 2 (Joe) Andy Shevchenko (4): ASoC: Intel: bytcht_es8316: Get platform data via dev_get_platdata() ASoC: Intel: bytcht_es8316: Use temporary variable for struct device ASoC: Intel: bytcht_es8316: Switch to use gpiod_get_optional() ASoC: Intel: bytcht_es8316: Utilize dev_err_probe() to avoid log saturation sound/soc/intel/boards/bytcht_es8316.c | 37 +++++++++----------------- 1 file changed, 12 insertions(+), 25 deletions(-) -- 2.33.0

2 5

Tenacity throws error when running "build/bin/Debug/tenacity" to run it
by GitHub issues - edited 10 Oct '21

10 Oct '21

alsa-project/alsa-lib issue #184 was edited from User10987654321: context: https://github.com/tenacityteam/tenacity/issues/649 `cat /proc/asound/version` output: Advanced Linux Sound Architecture Driver Version k5.10.0-kali9-amd64 backtrace, which is only produced in a popup once I comment out the lines "pcm.rear #cards.pcm.rear pcm.center_lfe #cards.pcm.center_lfe pcm.side #cards.pcm.side", which produce the following backtrace in a popup labeled "../src/AudioIOBase.cpp(501): assert "false" failed in getRecordDevIndex():": ASSERT INFO: ../src/AudioIOBase.cpp(501): assert "false" failed in getRecordDevIndex(). BACKTRACE: [1] AudioIOBase::getRecordDevIndex(wxString const&) [2] AudioIO::Init() [3] AudacityApp::InitPart2() [4] AudacityApp::OnInit() [5] wxAppConsoleBase::CallOnInit() [6] wxEntry(int&, wchar_t**) [7] wxEntry(int&, char**) [8] main [9] __libc_start_main [10] _sta When going through the steps in https://github.com/tenacityteam/tenacity/blob/master/BUILDING.md, I eventually get to a point where I run the command in the issue title which brings up the tenacity logo on screen and then provides the following errors in the terminal: ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory) attempt to connect to server failed connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory) attempt to connect to server failed ALSA lib pcm_oss.c:397:(_snd_pcm_oss_open) Cannot open device /dev/dsp ALSA lib pcm_oss.c:397:(_snd_pcm_oss_open) Cannot open device /dev/dsp ALSA lib pcm_a52.c:835:(_snd_pcm_a52_open) a52 is only for playback zsh: segmentation fault ./tenacity/build/bin/Debug/tenacity How can I mitigate this to use tenacity successfully? Issue URL : https://github.com/alsa-project/alsa-lib/issues/184 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Tenacity throws error when running "build/bin/Debug/tenacity" to run it
by GitHub issues - edited 10 Oct '21

10 Oct '21

alsa-project/alsa-lib issue #184 was edited from User10987654321: context: https://github.com/tenacityteam/tenacity/issues/649 `cat /proc/asound/version` output: Advanced Linux Sound Architecture Driver Version k5.10.0-kali9-amd64 When going through the steps in https://github.com/tenacityteam/tenacity/blob/master/BUILDING.md, I eventually get to a point where I run the command in the issue title which brings up the tenacity logo on screen and then provides the following errors in the terminal: ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map ALSA lib pcm_route.c:877:(find_matching_chmap) Found no matching channel map connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory) attempt to connect to server failed connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory) attempt to connect to server failed ALSA lib pcm_oss.c:397:(_snd_pcm_oss_open) Cannot open device /dev/dsp ALSA lib pcm_oss.c:397:(_snd_pcm_oss_open) Cannot open device /dev/dsp ALSA lib pcm_a52.c:835:(_snd_pcm_a52_open) a52 is only for playback zsh: segmentation fault ./tenacity/build/bin/Debug/tenacity How can I mitigate this to use tenacity successfully? Issue URL : https://github.com/alsa-project/alsa-lib/issues/184 Repository URL: https://github.com/alsa-project/alsa-lib

1 0