January 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH 00/10] Remove support for TX49xx
by Thomas Bogendoerfer 13 Jan '21

13 Jan '21

I couldn't find any buyable product other than reference boards using TX49xx CPUs. And since nobody showed interest in keeping support for it, it's time to remove it. I've split up the removal into seperate parts for different maintainers. So if the patch fits your needs, please take it via your tree or give me an ack so I can apply them the mips-next tree. Thomas Bogendoerfer (10): MIPS: TX49xx: Drop support net: tc35815: Drop support for TX49XX boards net: 8390: Drop support for TX49XX boards spi: txx9: Remove driver dma: tx49 removal mtd: Remove drivers used by TX49xx char: hw_random: Remove tx4939 driver rtc: tx4939: Remove driver ide: tx4938ide: Remove driver ASoC: txx9: Remove driver arch/mips/Kbuild.platforms | 1 - arch/mips/Kconfig | 23 - arch/mips/Makefile | 1 - arch/mips/configs/rbtx49xx_defconfig | 98 --- arch/mips/include/asm/cpu-type.h | 4 - arch/mips/include/asm/cpu.h | 2 +- .../asm/mach-tx49xx/cpu-feature-overrides.h | 26 - arch/mips/include/asm/mach-tx49xx/ioremap.h | 30 - arch/mips/include/asm/mach-tx49xx/kmalloc.h | 7 - .../include/asm/mach-tx49xx/mangle-port.h | 27 - arch/mips/include/asm/mach-tx49xx/spaces.h | 17 - arch/mips/include/asm/mipsregs.h | 6 - arch/mips/include/asm/txx9/boards.h | 10 - arch/mips/include/asm/txx9/generic.h | 9 - arch/mips/include/asm/txx9/rbtx4927.h | 92 --- arch/mips/include/asm/txx9/rbtx4938.h | 145 ---- arch/mips/include/asm/txx9/rbtx4939.h | 142 ---- arch/mips/include/asm/txx9/tx4927.h | 273 -------- arch/mips/include/asm/txx9/tx4927pcic.h | 203 ------ arch/mips/include/asm/txx9/tx4938.h | 312 --------- arch/mips/include/asm/txx9/tx4939.h | 524 --------------- arch/mips/include/asm/vermagic.h | 2 - arch/mips/kernel/cpu-probe.c | 10 - arch/mips/kernel/idle.c | 3 - arch/mips/mm/c-r4k.c | 77 --- arch/mips/mm/page.c | 1 - arch/mips/mm/tlbex.c | 1 - arch/mips/pci/Makefile | 6 - arch/mips/pci/fixup-rbtx4927.c | 73 -- arch/mips/pci/fixup-rbtx4938.c | 53 -- arch/mips/pci/ops-tx4927.c | 524 --------------- arch/mips/pci/pci-tx4927.c | 91 --- arch/mips/pci/pci-tx4938.c | 142 ---- arch/mips/pci/pci-tx4939.c | 107 --- arch/mips/txx9/Kconfig | 89 --- arch/mips/txx9/Makefile | 8 - arch/mips/txx9/Platform | 3 - arch/mips/txx9/generic/7segled.c | 123 ---- arch/mips/txx9/generic/Makefile | 4 - arch/mips/txx9/generic/irq_tx4927.c | 49 -- arch/mips/txx9/generic/irq_tx4938.c | 37 -- arch/mips/txx9/generic/irq_tx4939.c | 216 ------ arch/mips/txx9/generic/mem_tx4927.c | 75 --- arch/mips/txx9/generic/setup.c | 158 +---- arch/mips/txx9/generic/setup_tx4927.c | 337 ---------- arch/mips/txx9/generic/setup_tx4938.c | 485 -------------- arch/mips/txx9/generic/setup_tx4939.c | 568 ---------------- arch/mips/txx9/rbtx4927/Makefile | 2 - arch/mips/txx9/rbtx4927/irq.c | 198 ------ arch/mips/txx9/rbtx4927/prom.c | 42 -- arch/mips/txx9/rbtx4927/setup.c | 380 ----------- arch/mips/txx9/rbtx4938/Makefile | 2 - arch/mips/txx9/rbtx4938/irq.c | 157 ----- arch/mips/txx9/rbtx4938/prom.c | 22 - arch/mips/txx9/rbtx4938/setup.c | 372 ----------- arch/mips/txx9/rbtx4939/Makefile | 2 - arch/mips/txx9/rbtx4939/irq.c | 95 --- arch/mips/txx9/rbtx4939/prom.c | 29 - arch/mips/txx9/rbtx4939/setup.c | 554 --------------- drivers/char/hw_random/Kconfig | 13 - drivers/char/hw_random/Makefile | 1 - drivers/char/hw_random/tx4939-rng.c | 157 ----- drivers/dma/Kconfig | 2 +- drivers/dma/txx9dmac.h | 10 - drivers/ide/Kconfig | 10 - drivers/ide/Makefile | 3 - drivers/ide/tx4938ide.c | 209 ------ drivers/ide/tx4939ide.c | 628 ------------------ drivers/mtd/maps/Kconfig | 6 - drivers/mtd/maps/Makefile | 1 - drivers/mtd/maps/rbtx4939-flash.c | 133 ---- drivers/mtd/nand/raw/Kconfig | 7 - drivers/mtd/nand/raw/Makefile | 1 - drivers/mtd/nand/raw/txx9ndfmc.c | 423 ------------ drivers/net/ethernet/8390/Kconfig | 2 +- drivers/net/ethernet/8390/ne.c | 7 +- drivers/net/ethernet/toshiba/tc35815.c | 29 - drivers/rtc/Kconfig | 7 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-tx4939.c | 303 --------- drivers/spi/Kconfig | 6 - drivers/spi/Makefile | 1 - drivers/spi/spi-txx9.c | 477 ------------- drivers/watchdog/Kconfig | 2 +- include/linux/platform_data/txx9/ndfmc.h | 28 - sound/soc/Kconfig | 1 - sound/soc/Makefile | 1 - sound/soc/txx9/Kconfig | 30 - sound/soc/txx9/Makefile | 12 - sound/soc/txx9/txx9aclc-ac97.c | 230 ------- sound/soc/txx9/txx9aclc-generic.c | 88 --- sound/soc/txx9/txx9aclc.c | 422 ------------ sound/soc/txx9/txx9aclc.h | 71 -- 93 files changed, 6 insertions(+), 10365 deletions(-) delete mode 100644 arch/mips/configs/rbtx49xx_defconfig delete mode 100644 arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h delete mode 100644 arch/mips/include/asm/mach-tx49xx/ioremap.h delete mode 100644 arch/mips/include/asm/mach-tx49xx/kmalloc.h delete mode 100644 arch/mips/include/asm/mach-tx49xx/mangle-port.h delete mode 100644 arch/mips/include/asm/mach-tx49xx/spaces.h delete mode 100644 arch/mips/include/asm/txx9/rbtx4927.h delete mode 100644 arch/mips/include/asm/txx9/rbtx4938.h delete mode 100644 arch/mips/include/asm/txx9/rbtx4939.h delete mode 100644 arch/mips/include/asm/txx9/tx4927.h delete mode 100644 arch/mips/include/asm/txx9/tx4927pcic.h delete mode 100644 arch/mips/include/asm/txx9/tx4938.h delete mode 100644 arch/mips/include/asm/txx9/tx4939.h delete mode 100644 arch/mips/pci/fixup-rbtx4927.c delete mode 100644 arch/mips/pci/fixup-rbtx4938.c delete mode 100644 arch/mips/pci/ops-tx4927.c delete mode 100644 arch/mips/pci/pci-tx4927.c delete mode 100644 arch/mips/pci/pci-tx4938.c delete mode 100644 arch/mips/pci/pci-tx4939.c delete mode 100644 arch/mips/txx9/generic/7segled.c delete mode 100644 arch/mips/txx9/generic/irq_tx4927.c delete mode 100644 arch/mips/txx9/generic/irq_tx4938.c delete mode 100644 arch/mips/txx9/generic/irq_tx4939.c delete mode 100644 arch/mips/txx9/generic/mem_tx4927.c delete mode 100644 arch/mips/txx9/generic/setup_tx4927.c delete mode 100644 arch/mips/txx9/generic/setup_tx4938.c delete mode 100644 arch/mips/txx9/generic/setup_tx4939.c delete mode 100644 arch/mips/txx9/rbtx4927/Makefile delete mode 100644 arch/mips/txx9/rbtx4927/irq.c delete mode 100644 arch/mips/txx9/rbtx4927/prom.c delete mode 100644 arch/mips/txx9/rbtx4927/setup.c delete mode 100644 arch/mips/txx9/rbtx4938/Makefile delete mode 100644 arch/mips/txx9/rbtx4938/irq.c delete mode 100644 arch/mips/txx9/rbtx4938/prom.c delete mode 100644 arch/mips/txx9/rbtx4938/setup.c delete mode 100644 arch/mips/txx9/rbtx4939/Makefile delete mode 100644 arch/mips/txx9/rbtx4939/irq.c delete mode 100644 arch/mips/txx9/rbtx4939/prom.c delete mode 100644 arch/mips/txx9/rbtx4939/setup.c delete mode 100644 drivers/char/hw_random/tx4939-rng.c delete mode 100644 drivers/ide/tx4938ide.c delete mode 100644 drivers/ide/tx4939ide.c delete mode 100644 drivers/mtd/maps/rbtx4939-flash.c delete mode 100644 drivers/mtd/nand/raw/txx9ndfmc.c delete mode 100644 drivers/rtc/rtc-tx4939.c delete mode 100644 drivers/spi/spi-txx9.c delete mode 100644 include/linux/platform_data/txx9/ndfmc.h delete mode 100644 sound/soc/txx9/Kconfig delete mode 100644 sound/soc/txx9/Makefile delete mode 100644 sound/soc/txx9/txx9aclc-ac97.c delete mode 100644 sound/soc/txx9/txx9aclc-generic.c delete mode 100644 sound/soc/txx9/txx9aclc.c delete mode 100644 sound/soc/txx9/txx9aclc.h -- 2.29.2

6 17

[PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret
by Shengjiu Wang 12 Jan '21

12 Jan '21

From: shengjiu wang <shengjiu.wang(a)nxp.com> When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) is true, then goto fail, the uninitialized variable ret will be returned. Signed-off-by: shengjiu wang <shengjiu.wang(a)nxp.com> Reported-by: kernel test robot <lkp(a)intel.com> --- sound/soc/fsl/imx-hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c index 2c2a76a71940..ede4a9ad1054 100644 --- a/sound/soc/fsl/imx-hdmi.c +++ b/sound/soc/fsl/imx-hdmi.c @@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev) if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) { dev_err(&pdev->dev, "Invalid HDMI DAI link\n"); + ret = -EINVAL; goto fail; } -- 2.17.1

5 7

[PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency
by Arnd Bergmann 12 Jan '21

12 Jan '21

From: Arnd Bergmann <arnd(a)arndb.de> The sof-pci-dev driver fails to link when built into the kernel and CONFIG_SND_INTEL_DSP_CONFIG is set to =m: arm-linux-gnueabi-ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe': sof-pci-dev.c:(.text+0x1c): undefined reference to `snd_intel_dsp_driver_probe' All other drivers using this interface already use a 'select SND_INTEL_DSP_CONFIG' statement to force the it to be present, so it seems reasonable to do the same here. The stub implementation in the header makes the problem harder to find, as it avoids the link error when SND_INTEL_DSP_CONFIG is completely disabled, without any obvious upsides. Remove these stubs to make it clearer that the driver is in fact needed here. Fixes: 82d9d54a6c0e ("ALSA: hda: add Intel DSP configuration / probe code") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- include/sound/intel-dsp-config.h | 17 ----------------- sound/soc/sof/Kconfig | 2 ++ 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/sound/intel-dsp-config.h b/include/sound/intel-dsp-config.h index d4609077c258..94667e870029 100644 --- a/include/sound/intel-dsp-config.h +++ b/include/sound/intel-dsp-config.h @@ -18,24 +18,7 @@ enum { SND_INTEL_DSP_DRIVER_LAST = SND_INTEL_DSP_DRIVER_SOF }; -#if IS_ENABLED(CONFIG_SND_INTEL_DSP_CONFIG) - int snd_intel_dsp_driver_probe(struct pci_dev *pci); int snd_intel_acpi_dsp_driver_probe(struct device *dev, const u8 acpi_hid[ACPI_ID_LEN]); -#else - -static inline int snd_intel_dsp_driver_probe(struct pci_dev *pci) -{ - return SND_INTEL_DSP_DRIVER_ANY; -} - -static inline -int snd_intel_acpi_dsp_driver_probe(struct device *dev, const u8 acpi_hid[ACPI_ID_LEN]) -{ - return SND_INTEL_DSP_DRIVER_ANY; -} - -#endif - #endif diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 031dad5fc4c7..051fd3d27047 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -12,6 +12,7 @@ if SND_SOC_SOF_TOPLEVEL config SND_SOC_SOF_PCI tristate "SOF PCI enumeration support" depends on PCI + select SND_INTEL_DSP_CONFIG select SND_SOC_SOF select SND_SOC_ACPI if ACPI help @@ -23,6 +24,7 @@ config SND_SOC_SOF_PCI config SND_SOC_SOF_ACPI tristate "SOF ACPI enumeration support" depends on ACPI || COMPILE_TEST + select SND_INTEL_DSP_CONFIG select SND_SOC_SOF select SND_SOC_ACPI if ACPI select IOSF_MBI if X86 && PCI -- 2.29.2

6 15

[PATCH v3 1/4] ALSA: hda/realtek: Power up codec when setting LED via COEF and GPIO
by Kai-Heng Feng 12 Jan '21

12 Jan '21

System takes a very long time to suspend after commit 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete optimization"): [ 90.065964] PM: suspend entry (s2idle) [ 90.067337] Filesystems sync: 0.001 seconds [ 90.185758] Freezing user space processes ... (elapsed 0.002 seconds) done. [ 90.188713] OOM killer disabled. [ 90.188714] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. [ 90.190024] printk: Suspending console(s) (use no_console_suspend to debug) [ 90.904912] intel_pch_thermal 0000:00:12.0: CPU-PCH is cool [49C], continue to suspend [ 321.262505] snd_hda_codec_realtek ehdaudio0D0: Unable to sync register 0x2b8000. -5 [ 328.426919] snd_hda_codec_realtek ehdaudio0D0: Unable to sync register 0x2b8000. -5 [ 329.490933] ACPI: EC: interrupt blocked That commit keeps the codec suspended during the system suspend. However, led_suspend() for mute and micmute led writes codec register, triggers a pending wake up. The wakeup is then handled in __device_suspend() by the following: - pm_runtime_disable() to handle the wakeup event. - device is no longer is suspended state, direct-complete isn't taken. - pm_runtime_enable() to balance disable_depth. if (dev->power.direct_complete) { if (pm_runtime_status_suspended(dev)) { pm_runtime_disable(dev); if (pm_runtime_status_suspended(dev)) { pm_dev_dbg(dev, state, "direct-complete "); goto Complete; } pm_runtime_enable(dev); } dev->power.direct_complete = false; } Since direct-complete doens't apply anymore, the codec's system suspend routine is used. This doesn't play well with SOF driver. When its runtime resume is called for system suspend, hda_codec_jack_check() schedules jackpoll_work which uses snd_hdac_is_power_on() to check whether codec is suspended. Because of the previous pm_runtime_enable(), snd_hdac_is_power_on() returns false and jackpoll continues to run, and snd_hda_power_up_pm() cannot power up an already suspended codec in multiple attempts, causes the long delay on system suspend. When direct-complete path is taken, snd_hdac_is_power_on() returns true and hda_jackpoll_work() is skipped by accident. This is still not correct, and it will be addressed by later patch. Explicitly runtime resume codec on setting LED to solve the issue. Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete optimization") --- v3: New patch. sound/pci/hda/patch_realtek.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3c1d2a3fb1a4..304a7bc89fcd 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4164,7 +4164,10 @@ static void alc_update_gpio_led(struct hda_codec *codec, unsigned int mask, { if (polarity) enabled = !enabled; + /* temporarily power up/down for setting GPIO */ + snd_hda_power_up_pm(codec); alc_update_gpio_data(codec, mask, !enabled); /* muted -> LED on */ + snd_hda_power_down_pm(codec); } /* turn on/off mute LED via GPIO per vmaster hook */ @@ -4287,8 +4290,10 @@ static void alc_update_coef_led(struct hda_codec *codec, if (polarity) on = !on; /* temporarily power up/down for setting COEF bit */ + snd_hda_power_up_pm(codec); alc_update_coef_idx(codec, led->idx, led->mask, on ? led->on : led->off); + snd_hda_power_down_pm(codec); } /* update mute-LED according to the speaker mute state via COEF bit */ -- 2.29.2

3 6

[PATCH v3 0/3] Dell hardware privacy implementation for dell laptop
by Perry Yuan 12 Jan '21

12 Jan '21

From: Perry Yuan <perry_yuan(a)dell.com> Hi All, This patch set is a new driver for dell mobile platform ,which has the hardware privacy feature. For micmute led control, the hotkey is Fn + F4, it is a hardware based mute state, and new privacy will prevent micphone void input from hardware layer, any application cannot get voice data when micmute activated. Camera mute use a new hardware design to control the camrea shutter. When video is muted, no OS application should be functionally able to capture images of the person/environment in front of the system Older history: [1]https://patchwork.kernel.org/project/platform-driver-x86/patch/2020122813… [2]https://patchwork.kernel.org/project/alsa-devel/patch/20201103125859.8759… [3]https://www.spinics.net/lists/alsa-devel/msg120537.html [4]https://github.com/thesofproject/linux/pull/2660 Perry Yuan (3): platform/x86: dell-privacy: Add support for Dell hardware privacy x86/platform/dell-privacy-wmi: add document for dell privacy driver ASoC: rt715:add micmute led state control supports .../testing/sysfs-platform-dell-privacy-wmi | 31 ++ drivers/platform/x86/Kconfig | 17 + drivers/platform/x86/Makefile | 4 +- drivers/platform/x86/dell-laptop.c | 25 +- drivers/platform/x86/dell-privacy-acpi.c | 167 +++++++++ drivers/platform/x86/dell-privacy-wmi.c | 320 ++++++++++++++++++ drivers/platform/x86/dell-privacy-wmi.h | 33 ++ drivers/platform/x86/dell-wmi.c | 37 +- sound/soc/codecs/rt715-sdca.c | 16 + sound/soc/codecs/rt715-sdca.h | 1 + sound/soc/codecs/rt715.c | 14 + sound/soc/codecs/rt715.h | 1 + 12 files changed, 650 insertions(+), 16 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-platform-dell-privacy-wmi create mode 100644 drivers/platform/x86/dell-privacy-acpi.c create mode 100644 drivers/platform/x86/dell-privacy-wmi.c create mode 100644 drivers/platform/x86/dell-privacy-wmi.h -- 2.25.1

1 0

[PATCH] ASoC: es8316: Fix possible NULL pointer deref in es8316_disable_jack_detect()
by Hans de Goede 12 Jan '21

12 Jan '21

sound/soc/soc-core.c: soc_remove_component() unconditionally calls snd_soc_component_set_jack(component, NULL, NULL); on any components being removed. This means that on machines where the machine-driver does not provide a jack through snd_soc_component_set_jack() es8316_disable_jack_detect() will still get called and at this time es8316->jack will be NULL and the es8316->jack->status check in es8316_disable_jack_detect() will lead to a NULL pointer deref. Fix this by checking for es8316->jack bein NULL at the start of es8316_disable_jack_detect() and turn the function into a no-op in that case. Cc: russianneuromancer <russianneuromancer(a)ya.ru> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/codecs/es8316.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index f9ec5cf82599..1ce84f12a4cf 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -681,6 +681,9 @@ static void es8316_disable_jack_detect(struct snd_soc_component *component) { struct es8316_priv *es8316 = snd_soc_component_get_drvdata(component); + if (!es8316->jack) + return; /* Already disabled (or never enabled) */ + disable_irq(es8316->irq); mutex_lock(&es8316->lock); -- 2.28.0

2 1

[PATCH 0/3] ASoC: Intel: bytcr_rt5640: Add support for devices with only a headphone jack (no speakers/mic)
by Hans de Goede 12 Jan '21

12 Jan '21

Hi All, This series adds support for devices with only a headphone jack (no speakers/internal mic). Specifically this adds support for the Mele PCG03 Mini PC. But the new no-speakers and no-internal-mic quirks will likely be useful on other devices too. Regards, Hans

3 5

[PATCH] ASoC: adau17x1: Remove redundant null check before clk_disable_unprepare
by Xu Wang 12 Jan '21

12 Jan '21

Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it. Signed-off-by: Xu Wang <vulab(a)iscas.ac.cn> --- sound/soc/codecs/adau17x1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c index 30e072c80ac1..546ee8178038 100644 --- a/sound/soc/codecs/adau17x1.c +++ b/sound/soc/codecs/adau17x1.c @@ -1095,8 +1095,7 @@ void adau17x1_remove(struct device *dev) { struct adau *adau = dev_get_drvdata(dev); - if (adau->mclk) - clk_disable_unprepare(adau->mclk); + clk_disable_unprepare(adau->mclk); } EXPORT_SYMBOL_GPL(adau17x1_remove); -- 2.17.1

3 2

[PATCH] ASoC: Intel: cht_bsw_nau8824: Move snd_soc_dai_set_tdm_slot call to cht_codec_fixup
by Hans de Goede 12 Jan '21

12 Jan '21

Move the snd_soc_dai_set_tdm_slot() call from cht_codec_init() to cht_codec_fixup(). There are 2 reasons for doing this: 1. This aligns the cht_bsw_nau8824 with all the other BYT/CHT machine drivers which also do this from their codec_fixup function. 2. When using the SOF driver, things like the TDM info is set from the topology file. Moving the call to the codec_fixup function, which gets skipped when using the SOF driver avoids the call interfering with the settings when using the SOF driver. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/intel/boards/cht_bsw_nau8824.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/intel/boards/cht_bsw_nau8824.c b/sound/soc/intel/boards/cht_bsw_nau8824.c index fd5e25ca05f7..da5a5cbc8759 100644 --- a/sound/soc/intel/boards/cht_bsw_nau8824.c +++ b/sound/soc/intel/boards/cht_bsw_nau8824.c @@ -100,13 +100,6 @@ static int cht_codec_init(struct snd_soc_pcm_runtime *runtime) struct snd_soc_component *component = codec_dai->component; int ret, jack_type; - /* TDM 4 slots 24 bit, set Rx & Tx bitmask to 4 active slots */ - ret = snd_soc_dai_set_tdm_slot(codec_dai, 0xf, 0x1, 4, 24); - if (ret < 0) { - dev_err(runtime->dev, "can't set codec TDM slot %d\n", ret); - return ret; - } - /* NAU88L24 supports 4 butons headset detection * KEY_PLAYPAUSE * KEY_VOICECOMMAND @@ -141,6 +134,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd, SNDRV_PCM_HW_PARAM_CHANNELS); struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT); + int ret; /* The DSP will covert the FE rate to 48k, stereo, 24bits */ rate->min = rate->max = 48000; @@ -150,6 +144,13 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd, snd_mask_none(fmt); params_set_format(params, SNDRV_PCM_FORMAT_S24_LE); + /* TDM 4 slots 24 bit, set Rx & Tx bitmask to 4 active slots */ + ret = snd_soc_dai_set_tdm_slot(asoc_rtd_to_codec(rtd, 0), 0xf, 0x1, 4, 24); + if (ret < 0) { + dev_err(rtd->dev, "can't set codec TDM slot %d\n", ret); + return ret; + } + return 0; } -- 2.28.0

3 2

[PATCH] ASoC: SOF: add mutex to protect the dsp_power_state access
by Kai Vehmanen 12 Jan '21

12 Jan '21

From: Keyon Jie <yang.jie(a)linux.intel.com> There could be more than one thread read/write the dsp_power_state simultaneously (e.g. hda_dsp_d0i3_work and sof_ipc_tx_message), add a mutex power_state_access to make sure the access to it is mutually exclusive. Signed-off-by: Keyon Jie <yang.jie(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Bard Liao <bard.liao(a)intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/soc/sof/core.c | 1 + sound/soc/sof/ops.h | 11 ++++++++--- sound/soc/sof/sof-priv.h | 2 ++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/core.c b/sound/soc/sof/core.c index adc7c37145d6..2b85ef5d6092 100644 --- a/sound/soc/sof/core.c +++ b/sound/soc/sof/core.c @@ -316,6 +316,7 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data) INIT_LIST_HEAD(&sdev->route_list); spin_lock_init(&sdev->ipc_lock); spin_lock_init(&sdev->hw_lock); + mutex_init(&sdev->power_state_access); if (IS_ENABLED(CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE)) INIT_WORK(&sdev->probe_work, sof_probe_work); diff --git a/sound/soc/sof/ops.h b/sound/soc/sof/ops.h index 95e748b36903..4c1f9daaa6e8 100644 --- a/sound/soc/sof/ops.h +++ b/sound/soc/sof/ops.h @@ -208,11 +208,16 @@ static inline int snd_sof_dsp_set_power_state(struct snd_sof_dev *sdev, const struct sof_dsp_power_state *target_state) { + int ret = 0; + + mutex_lock(&sdev->power_state_access); + if (sof_ops(sdev)->set_power_state) - return sof_ops(sdev)->set_power_state(sdev, target_state); + ret = sof_ops(sdev)->set_power_state(sdev, target_state); - /* D0 substate is not supported, do nothing here. */ - return 0; + mutex_unlock(&sdev->power_state_access); + + return ret; } /* debug */ diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 68da8f797403..28d19fa30614 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -375,6 +375,8 @@ struct snd_sof_dev { /* current DSP power state */ struct sof_dsp_power_state dsp_power_state; + /* mutex to protect the dsp_power_state access */ + struct mutex power_state_access; /* Intended power target of system suspend */ enum sof_system_suspend_state system_suspend_target; -- 2.29.2

2 1