January 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH 1/2] ALSA: oxfw: fix info leak in hwdep_read()
by Dan Carpenter 22 Jan '21

22 Jan '21

If "count" is too large and "oxfw->dev_lock_changed" is false then this will copy beyond the end of the struct to user space. Fixes: 8985f4ac1c42 ("ALSA: oxfw: Add hwdep interface") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/firewire/oxfw/oxfw-hwdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/oxfw/oxfw-hwdep.c b/sound/firewire/oxfw/oxfw-hwdep.c index 9e1b3e151bad..ca5477eeb663 100644 --- a/sound/firewire/oxfw/oxfw-hwdep.c +++ b/sound/firewire/oxfw/oxfw-hwdep.c @@ -35,12 +35,12 @@ static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, } memset(&event, 0, sizeof(event)); + count = min_t(long, count, sizeof(event.lock_status)); if (oxfw->dev_lock_changed) { event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS; event.lock_status.status = (oxfw->dev_lock_count > 0); oxfw->dev_lock_changed = false; - count = min_t(long, count, sizeof(event.lock_status)); } spin_unlock_irq(&oxfw->lock); -- 2.29.2

1 1

duplicate line at samsung speyside driver
by Kuninori Morimoto 22 Jan '21

22 Jan '21

Hi ALSA ML I noticed samsung speyside driver has duplicate line on audio_paths. I think it is typo or something... linux/sound/soc/samsung/speyside.c static struct snd_soc_dapm_route audio_paths[] = { => { "IN1RN", NULL, "MICB1" }, { "IN1RP", NULL, "MICB1" }, { "IN1RN", NULL, "MICB2" }, { "IN1RP", NULL, "MICB2" }, { "MICB1", NULL, "Headset Mic", speyside_get_micbias }, { "MICB2", NULL, "Headset Mic", speyside_get_micbias }, { "IN1LP", NULL, "MICB2" }, => { "IN1RN", NULL, "MICB1" }, { "MICB2", NULL, "Main AMIC" }, ... Thank you for your help !! Best regards --- Kuninori Morimoto

2 2

[Regression] Game "Rise of the Tomb Raider" crashes at launch
by GitHub issues - edited 21 Jan '21

21 Jan '21

alsa-project/alsa-lib issue #116 was edited from Oschowa: The the native linux version of the game "Rise of the Tomb Raider" crashes at launch when it doesn't detect a working pulseaudio server and it falls back to alsa-lib directly. This is a regression, the last working alsa-lib version is v1.2.1.2 and bisection yields 5ee5ef31b5ff3f as the first bad commit. The crash happens when using "real" alsa hardware drivers as well as when running on the pulseaudio-alsa or pipewire-alsa software plug. Happy to provide more info if i can. Issue URL : https://github.com/alsa-project/alsa-lib/issues/116 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[Regression] Game "Rise of the Tomb Raider" crashes at launch
by GitHub issues - opened 21 Jan '21

21 Jan '21

alsa-project/alsa-lib issue #116 was opened from Oschowa: The the native linux version of the game "Rise of the Tomb Raider" crashes at launch when it doesn't detect a working pulseaudio server and it falls back alsa-lib directly. This is a regression, the last working alsa-lib version is v1.2.1.2 and bisection yields 5ee5ef31b5ff3f as the first bad commit. The crash happens when using "real" alsa hardware drivers as well as when running on the pulseaudio-alsa or pipewire-alsa software plug. Happy to provide more info if i can. Issue URL : https://github.com/alsa-project/alsa-lib/issues/116 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

SOF: Improve dmic support
by GitHub pull_request - edited 21 Jan '21

21 Jan '21

alsa-project/alsa-ucm-conf pull request #75 was edited from plbossart: DMIC support seems incomplete for HDaudio (not handling all possibilities for cfg-dmics) and missing completely for SoundWire. This is an untested draft just to get UCM3 feedback from @perexg and tests from @aigilea on an HP Spectre x360 device. Edit: adding @kv2019i @RanderWang @bardliao and @libinyang for reviews. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

SOF: Improve dmic support
by GitHub pull_request - edited 21 Jan '21

21 Jan '21

alsa-project/alsa-ucm-conf pull request #75 was edited from plbossart: DMIC support seems incomplete for HDaudio (not handling all possibilities for cfg-dmics) and missing completely for SoundWire. This is an untested draft just to get UCM3 feedback from @perexg and tests from @aigilea on an HP Spectre x360 device. Edit: adding @libinyang for reviews. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

SOF: Improve dmic support
by GitHub pull_request - opened 21 Jan '21

21 Jan '21

alsa-project/alsa-ucm-conf pull request #75 was opened from plbossart: DMIC support seems incomplete for HDaudio (not handling all possibilities for cfg-dmics) and missing completely for SoundWire. This is an untested draft just to get UCM3 feedback from @perexg and tests from @aigilea on an HP Spectre x360 device. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/75.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Support for NUX MG-300 USB interface
by Mike Oliphant 21 Jan '21

21 Jan '21

I recently got a NUX MG-300 USB guitar fx interface with high hopes that it would work in Linux. It is supposed to be class-compliant, and works in iOS and macOS without a driver. Unfortunately, while it is recognized as a USB audio device by Linux, it is not working. The core issue seems to be that "stream0" reports no playback rates. dmesg also shows errors, including "__uac_clock_find_source(): selector reported illegal value". Any help identifying the issue would be much appreciated. I have some experience troubleshooting the USB audio kernel code and am happy to try doing so if I can get a nudge in the right direction. Output from "stream0", dmesg, and lsusb follows. Thanks! Mike "stream0" --- NUX NUX MG-300 AUDIO at usb-0000:00:1a.7-1.3, high speed : USB Audio Playback: Status: Stop Interface 1 Altset 1 Format: S32_LE Channels: 2 Endpoint: 0x01 (1 OUT) (ASYNC) Rates: Data packet interval: 1000 us Bits: 24 Channel map: FL FR Sync Endpoint: 0x81 (1 IN) Sync EP Interface: 1 Sync EP Altset: 1 Implicit Feedback Mode: No Capture: Status: Stop Interface 2 Altset 1 Format: S32_LE Channels: 2 Endpoint: 0x82 (2 IN) (ASYNC) Rates: Data packet interval: 1000 us Bits: 24 Channel map: FL FR --- dmesg log: --- [ 141.265806] usb 3-1.3: new high-speed USB device number 9 using ehci-pci [ 141.374351] usb 3-1.3: config 1 interface 3 altsetting 0 bulk endpoint 0x4 has invalid maxpacket 256 [ 141.374370] usb 3-1.3: config 1 interface 3 altsetting 0 bulk endpoint 0x83 has invalid maxpacket 256 [ 141.375373] usb 3-1.3: New USB device found, idVendor=1fc9, idProduct=8260, bcdDevice= 1.00 [ 141.375389] usb 3-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 141.375396] usb 3-1.3: Product: NUX MG-300 AUDIO [ 141.375401] usb 3-1.3: Manufacturer: NUX [ 141.375405] usb 3-1.3: SerialNumber: 2008101346 [ 141.468523] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.468531] usb 3-1.3: parse_audio_format_rates_v2v3(): unable to find clock source (clock -22) [ 141.468771] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.468897] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.469274] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.469279] usb 3-1.3: parse_audio_format_rates_v2v3(): unable to find clock source (clock -22) [ 141.469521] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.469646] usb 3-1.3: __uac_clock_find_source(): selector reported illegal value, id 40, ret 0 [ 141.472645] usbcore: registered new interface driver snd-usb-audio --- lsusb output: --- Bus 003 Device 009: ID 1fc9:8260 NXP Semiconductors Couldn't open device, some information will be missing Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 bDeviceProtocol 1 Interface Association bMaxPacketSize0 64 idVendor 0x1fc9 NXP Semiconductors idProduct 0x8260 bcdDevice 1.00 iManufacturer 1 iProduct 2 iSerial 3 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 0x013e bNumInterfaces 4 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xc0 Self Powered MaxPower 2mA Interface Association: bLength 8 bDescriptorType 11 bFirstInterface 0 bInterfaceCount 3 bFunctionClass 1 Audio bFunctionSubClass 0 bFunctionProtocol 32 iFunction 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 1 Control Device bInterfaceProtocol 32 iInterface 0 AudioControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdADC 2.00 bCategory 8 wTotalLength 0x0065 bmControls 0x00 AudioControl Interface Descriptor: bLength 8 bDescriptorType 36 bDescriptorSubtype 10 (CLOCK_SOURCE) bClockID 41 bmAttributes 3 Internal programmable clock bmControls 0x07 Clock Frequency Control (read/write) Clock Validity Control (read-only) bAssocTerminal 0 iClockSource 0 AudioControl Interface Descriptor: bLength 8 bDescriptorType 36 bDescriptorSubtype 11 (CLOCK_SELECTOR) bClockID 40 bNrInPins 1 baCSourceID(0) 41 bmControls 0x03 Clock Selector Control (read/write) iClockSelector 0 AudioControl Interface Descriptor: bLength 17 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 2 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bCSourceID 40 bNrChannels 2 bmChannelConfig 0x00000000 iChannelNames 0 bmControls 0x0000 iTerminal 0 AudioControl Interface Descriptor: bLength 18 bDescriptorType 36 bDescriptorSubtype 6 (FEATURE_UNIT) bUnitID 10 bSourceID 2 bmaControls(0) 0x0000000f Mute Control (read/write) Volume Control (read/write) bmaControls(1) 0x0000000f Mute Control (read/write) Volume Control (read/write) bmaControls(2) 0x0000000f Mute Control (read/write) Volume Control (read/write) iFeature 0 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 20 wTerminalType 0x0301 Speaker bAssocTerminal 0 bSourceID 10 bCSourceID 40 bmControls 0x0000 iTerminal 0 AudioControl Interface Descriptor: bLength 17 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Microphone bAssocTerminal 0 bCSourceID 40 bNrChannels 2 bmChannelConfig 0x00000000 iChannelNames 0 bmControls 0x0000 iTerminal 0 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 22 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 2 bCSourceID 40 bmControls 0x0000 iTerminal 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 32 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 2 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 32 iInterface 0 AudioStreaming Interface Descriptor: bLength 16 bDescriptorType 36 bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 2 bmControls 0x00 bFormatType 1 bmFormats 0x00000001 PCM bNrChannels 2 bmChannelConfig 0x00000000 iChannelNames 0 AudioStreaming Interface Descriptor: bLength 6 bDescriptorType 36 bDescriptorSubtype 2 (FORMAT_TYPE) bFormatType 1 (FORMAT_TYPE_I) bSubslotSize 4 bBitResolution 24 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x01 EP 1 OUT bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0258 1x 600 bytes bInterval 4 AudioStreaming Endpoint Descriptor: bLength 8 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x00 bmControls 0x00 bLockDelayUnits 0 Undefined wLockDelay 0x0000 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 17 Transfer Type Isochronous Synch Type None Usage Type Feedback wMaxPacketSize 0x0004 1x 4 bytes bInterval 4 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 32 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 32 iInterface 0 AudioStreaming Interface Descriptor: bLength 16 bDescriptorType 36 bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 22 bmControls 0x00 bFormatType 1 bmFormats 0x00000001 PCM bNrChannels 2 bmChannelConfig 0x00000000 iChannelNames 0 AudioStreaming Interface Descriptor: bLength 6 bDescriptorType 36 bDescriptorSubtype 2 (FORMAT_TYPE) bFormatType 1 (FORMAT_TYPE_I) bSubslotSize 4 bBitResolution 24 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x82 EP 2 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0258 1x 600 bytes bInterval 4 AudioStreaming Endpoint Descriptor: bLength 8 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x00 bmControls 0x00 bLockDelayUnits 0 Undefined wLockDelay 0x0000 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 1 Audio bInterfaceSubClass 3 MIDI Streaming bInterfaceProtocol 0 iInterface 4 MIDIStreaming Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdADC 1.00 wTotalLength 0x0041 MIDIStreaming Interface Descriptor: bLength 6 bDescriptorType 36 bDescriptorSubtype 2 (MIDI_IN_JACK) bJackType 1 Embedded bJackID 1 iJack 0 MIDIStreaming Interface Descriptor: bLength 6 bDescriptorType 36 bDescriptorSubtype 2 (MIDI_IN_JACK) bJackType 2 External bJackID 2 iJack 0 MIDIStreaming Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (MIDI_OUT_JACK) bJackType 1 Embedded bJackID 3 bNrInputPins 1 baSourceID( 0) 2 BaSourcePin( 0) 1 iJack 0 MIDIStreaming Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (MIDI_OUT_JACK) bJackType 2 External bJackID 4 bNrInputPins 1 baSourceID( 0) 1 BaSourcePin( 0) 1 iJack 0 Endpoint Descriptor: bLength 9 bDescriptorType 5 bEndpointAddress 0x04 EP 4 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0100 1x 256 bytes bInterval 0 bRefresh 0 bSynchAddress 0 MIDIStreaming Endpoint Descriptor: bLength 5 bDescriptorType 37 bDescriptorSubtype 1 (GENERAL) bNumEmbMIDIJack 1 baAssocJackID( 0) 1 Endpoint Descriptor: bLength 9 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0100 1x 256 bytes bInterval 0 bRefresh 0 bSynchAddress 0 MIDIStreaming Endpoint Descriptor: bLength 5 bDescriptorType 37 bDescriptorSubtype 1 (GENERAL) bNumEmbMIDIJack 1 baAssocJackID( 0) 3 ---

2 15

[PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete
by Ricardo Ribalda 21 Jan '21

21 Jan '21

If dobj->control is not initialized we end up in an OOPs during skl_tplg_complete: [ 26.553358] BUG: kernel NULL pointer dereference, address: 0000000000000078 [ 26.561151] #PF: supervisor read access in kernel mode [ 26.566897] #PF: error_code(0x0000) - not-present page [ 26.572642] PGD 0 P4D 0 [ 26.575479] Oops: 0000 [#1] PREEMPT SMP PTI [ 26.580158] CPU: 2 PID: 2082 Comm: udevd Tainted: G C 5.4.81 #4 [ 26.588232] Hardware name: HP Soraka/Soraka, BIOS Google_Soraka.10431.106.0 12/03/2019 [ 26.597082] RIP: 0010:skl_tplg_complete+0x70/0x144 [snd_soc_skl] Fixes: 2d744ecf2b98 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHL") Signed-off-by: Ricardo Ribalda <ribalda(a)chromium.org> --- sound/soc/intel/skylake/skl-topology.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index ae466cd59292..1ef30ca45410 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3619,15 +3619,16 @@ static void skl_tplg_complete(struct snd_soc_component *component) list_for_each_entry(dobj, &component->dobj_list, list) { struct snd_kcontrol *kcontrol = dobj->control.kcontrol; - struct soc_enum *se = - (struct soc_enum *)kcontrol->private_value; - char **texts = dobj->control.dtexts; + struct soc_enum *se; + char **texts; char chan_text[4]; - if (dobj->type != SND_SOC_DOBJ_ENUM || - dobj->control.kcontrol->put != - skl_tplg_multi_config_set_dmic) + if (dobj->type != SND_SOC_DOBJ_ENUM || !kcontrol || + kcontrol->put != skl_tplg_multi_config_set_dmic) continue; + + se = (struct soc_enum *)kcontrol->private_value; + texts = dobj->control.dtexts; sprintf(chan_text, "c%d", mach->mach_params.dmic_num); for (i = 0; i < se->items; i++) { -- 2.30.0.296.g2bfb1c46d8-goog

5 8

[PATCH] ASoC: rt5682: remove connection with LDO2 in DAPM graph
by shumingf＠realtek.com 21 Jan '21

21 Jan '21

From: Shuming Fan <shumingf(a)realtek.com> The application circuit shall provide MICVDD power. In default, the codec driver doesn't need to enable LDO2. In case, a board wants to use VBAT for micbias, it should add a DAPM route which IN1P connects with LDO2 in the machine driver. e.g. { "IN1P", NULL, "LDO2" }, Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt5682.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 42ad5bea86b5..185906d6d4e0 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -1854,8 +1854,6 @@ static const struct snd_soc_dapm_route rt5682_dapm_routes[] = { {"CLKDET SYS", NULL, "CLKDET"}, - {"IN1P", NULL, "LDO2"}, - {"BST1 CBJ", NULL, "IN1P"}, {"RECMIX1L", "CBJ Switch", "BST1 CBJ"}, -- 2.29.0

2 1