January 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: Intel: Skylake: Check the kcontrol against NULL
by Lukasz Majczak 20 Jan '21

20 Jan '21

There is no check for the kcontrol against NULL and in some cases it causes kernel to crash. Fixes: 2d744ecf2b984 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT") Cc: <stable(a)vger.kernel.org> # 5.4+ Signed-off-by: Lukasz Majczak <lma(a)semihalf.com> --- sound/soc/intel/skylake/skl-topology.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index ae466cd592922..c9abbe4ff0ba3 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3618,12 +3618,18 @@ static void skl_tplg_complete(struct snd_soc_component *component) int i; list_for_each_entry(dobj, &component->dobj_list, list) { - struct snd_kcontrol *kcontrol = dobj->control.kcontrol; - struct soc_enum *se = - (struct soc_enum *)kcontrol->private_value; - char **texts = dobj->control.dtexts; + struct snd_kcontrol *kcontrol; + struct soc_enum *se; + char **texts; char chan_text[4]; + kcontrol = dobj->control.kcontrol; + if(!kcontrol) + continue; + + se = (struct soc_enum *)kcontrol->private_value; + texts = dobj->control.dtexts; + if (dobj->type != SND_SOC_DOBJ_ENUM || dobj->control.kcontrol->put != skl_tplg_multi_config_set_dmic) base-commit: 69fe63aa100220c8fd1f451dd54dd0895df1441d -- 2.25.1

7 9

handling different frame sizes in snd_pcm_extplug_callback_t transfer callback
by Arsen Arsenović 20 Jan '21

20 Jan '21

Hello! I am writing an external noise cancellation plugin for ALSA, based on rnnoise, but I've hit a bit of a roadblock: rnnoise processes chunks of 480 floats at a time and does no buffering, but alsa expects the transfer callback to take all the data from the input and put it onto the output, with no way to signal that any buffering is or should be happening. I have tried to return a multiple of 480 from the transfer callback and keep a buffer with the leftover data, to be prepended to the next payload, but it looks like ALSA will, when a plugin returns too little data, just send back the same non-processed data in a new call, which breaks this idea. Any way I can work around these limitations? Another solution could be for external plugins to report the amount they consumed and produced, rather than a single number for both, but I am not aware of how to do that, if it's even possible with the filter plugin SDK. Thanks in advance! EDIT: I had previously posted this question before I confirmed my mailing list membership, but seeing as it wasn't approved for a few days I cancelled the request and reposted it. Sorry about that. -- Arsen Arsenović

1 0

sof topology compilation fails
by GitHub issues - opened 20 Jan '21

20 Jan '21

alsa-project/alsa-lib issue #114 was opened from juimonen: sof topologies fail to compile because of following commit: commit 51e1d486ce4535923692bd1d7e59d5aa3a29cd50 Author: Jaroslav Kysela <perex(a)perex.cz> Date: Thu Jan 7 17:40:42 2021 +0100 topology: parse_tuple_set() - remove dead condition code Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> I don't completely understand the change...? we are in "case SND_SOC_TPLG_TUPLE_TYPE_WORD" and then we check for SND_SOC_TPLG_TUPLE_TYPE_WORD (and not the value anymore) and error out? Issue URL : https://github.com/alsa-project/alsa-lib/issues/114 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Add jack2 as test
by GitHub pull_request - opened 20 Jan '21

20 Jan '21

alsa-project/alsa-utils pull request #74 was opened from bengan: Jack2 been around for a long time. It should be included in the test. Request URL : https://github.com/alsa-project/alsa-utils/pull/74 Patch URL : https://github.com/alsa-project/alsa-utils/pull/74.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH 1/2] ASoC: dt-bindings: rt5682: add LDO2 power control device property
by shumingf＠realtek.com 20 Jan '21

20 Jan '21

From: Shuming Fan <shumingf(a)realtek.com> The "realtek,ldo2-pow-en" device property uses to enable LDO2 power while the headset recording. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- Documentation/devicetree/bindings/sound/rt5682.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index 9c5fadb6ac82..eba2ea588564 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -46,6 +46,8 @@ Optional properties: - realtek,dmic-clk-driving-high : Set the high drving of the DMIC clock out. +- realtek,ldo2-pow-en : Enable LDO2 power control if the application circuit uses VBAT, not MICVDD. + Pins on the device (for linking into audio routes) for RT5682: * DMIC L1 -- 2.29.0

1 0

[PATCH] Add basic capture support for Pioneer DJ DJM-250MK2
by František Kučera 20 Jan '21

20 Jan '21

From: František Kučera <franta-linux(a)frantovo.cz> This patch extends support for DJM-250MK2 and allows recording. However, DVS is not possible yet (see the comment in code). Signed-off-by: František Kučera <franta-linux(a)frantovo.cz> --- sound/usb/pcm.c | 1 + sound/usb/quirks-table.h | 62 ++++++++++++++++++++++++++++++++++------ sound/usb/quirks.c | 1 + 3 files changed, 56 insertions(+), 8 deletions(-) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 5600751803cf..f5fa11deea4d 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -374,6 +374,7 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs, ifnum = 2; goto add_sync_ep_from_ifnum; case USB_ID(0x2b73, 0x000a): /* Pioneer DJ DJM-900NXS2 */ + case USB_ID(0x2b73, 0x0017): /* Pioneer DJ DJM-250MK2 */ ep = 0x82; ifnum = 0; goto add_sync_ep_from_ifnum; diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index f4fb002e3ef4..c6b2f0b8d3e2 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -3549,14 +3549,40 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), { /* * Pioneer DJ DJM-250MK2 - * PCM is 8 channels out @ 48 fixed (endpoints 0x01). - * The output from computer to the mixer is usable. - * - * The input (phono or line to computer) is not working. - * It should be at endpoint 0x82 and probably also 8 channels, - * but it seems that it works only with Pioneer proprietary software. - * Even on officially supported OS, the Audacity was unable to record - * and Mixxx to recognize the control vinyls. + * PCM is 8 channels out @ 48 fixed (endpoint 0x01) + * and 8 channels in @ 48 fixed (endpoint 0x82). + * + * Both playback and recording is working, even simultaneously. + * + * Playback channels could be mapped to: + * - CH1 + * - CH2 + * - AUX + * + * Recording channels could be mapped to: + * - Post CH1 Fader + * - Post CH2 Fader + * - Cross Fader A + * - Cross Fader B + * - MIC + * - AUX + * - REC OUT + * + * There is remaining problem with recording directly from PHONO/LINE. + * If we map a channel to: + * - CH1 Control Tone PHONO + * - CH1 Control Tone LINE + * - CH2 Control Tone PHONO + * - CH2 Control Tone LINE + * it is silent. + * There is no signal even on other operating systems with official drivers. + * The signal appears only when a supported application is started. + * This needs to be investigated yet... + * (there is quite a lot communication on the USB in both directions) + * + * In current version this mixer could be used for playback + * and for recording from vinyls (through Post CH* Fader) + * but not for DVS (Digital Vinyl Systems) like in Mixxx. */ USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017), .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { @@ -3580,6 +3606,26 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), .rate_max = 48000, .nr_rates = 1, .rate_table = (unsigned int[]) { 48000 } + } + }, + { + .ifnum = 0, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S24_3LE, + .channels = 8, // inputs + .iface = 0, + .altsetting = 1, + .altset_idx = 1, + .endpoint = 0x82, + .ep_attr = USB_ENDPOINT_XFER_ISOC| + USB_ENDPOINT_SYNC_ASYNC| + USB_ENDPOINT_USAGE_IMPLICIT_FB, + .rates = SNDRV_PCM_RATE_48000, + .rate_min = 48000, + .rate_max = 48000, + .nr_rates = 1, + .rate_table = (unsigned int[]) { 48000 } } }, { diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index abf99b814a0f..6a0be7e7f4fe 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1493,6 +1493,7 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs, set_format_emu_quirk(subs, fmt); break; case USB_ID(0x2b73, 0x000a): /* Pioneer DJ DJM-900NXS2 */ + case USB_ID(0x2b73, 0x0017): /* Pioneer DJ DJM-250MK2 */ pioneer_djm_set_format_quirk(subs); break; case USB_ID(0x534d, 0x2109): /* MacroSilicon MS2109 */ -- 2.20.1

5 9

Dual ALC1220 Bug MSI Godlike X570
by Aeonik 20 Jan '21

20 Jan '21

Hello, I believe I have run into an Alsa bug due to new/unsupported hardware. I am running Arch Linux Kernel version 5.10.8 on my new MSI Godlike X570 motherboard, and I believe Alsa is having issues with the Dual ALC1220 Codecs. I saw that this has been an issue before <https://bugzilla.kernel.org/show_bug.cgi?id=195305> in the and looks solved, but for some reason, my Alsa utilities are crashing when trying to access my sound card (Alsamixer and amixer). Here is an example with the error message. amixer -c 0 ALSA lib simple_none.c:1544:(simple_add1) helem (MIXER,'Master Playback Switch',0,1,0) appears twice or more cannot load mixer controls: Invalid argument I have tried solving the issue in a variety of ways, including explicitly setting the kernel module snd-hda_intel model name. I also experience the same bug in a fresh Arch Linux ISO, which rules out most configuration issues, I think. I reviewed your documentation, and it looks like my next step is to file a bug report. I already reached out to the Arch Linux community, and you can review my post at the following link. I have also attached the output of alsa-info.sh to this email. https://bbs.archlinux.org/viewtopic.php?pid=1949255#p1949255 Let me know if you need anything else from me, I appreciate all your work, and look forward to your response! Aeonik

1 0

[PATCH AUTOSEL 4.4 1/4] ASoC: Intel: haswell: Add missing pm_ops
by Sasha Levin 20 Jan '21

20 Jan '21

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit bb224c3e3e41d940612d4cc9573289cdbd5cb8f5 ] haswell machine board is missing pm_ops what prevents it from undergoing suspend-resume procedure successfully. Assign default snd_soc_pm_ops so this is no longer the case. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Link: https://lore.kernel.org/r/20201217105401.27865-1-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/boards/haswell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/haswell.c b/sound/soc/intel/boards/haswell.c index de955c2e8c4e3..a0e67d5f59683 100644 --- a/sound/soc/intel/boards/haswell.c +++ b/sound/soc/intel/boards/haswell.c @@ -197,6 +197,7 @@ static struct platform_driver haswell_audio = { .probe = haswell_audio_probe, .driver = { .name = "haswell-audio", + .pm = &snd_soc_pm_ops, }, }; -- 2.27.0

1 0

[PATCH AUTOSEL 4.9 1/4] ASoC: Intel: haswell: Add missing pm_ops
by Sasha Levin 20 Jan '21

20 Jan '21

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit bb224c3e3e41d940612d4cc9573289cdbd5cb8f5 ] haswell machine board is missing pm_ops what prevents it from undergoing suspend-resume procedure successfully. Assign default snd_soc_pm_ops so this is no longer the case. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Link: https://lore.kernel.org/r/20201217105401.27865-1-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/boards/haswell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/haswell.c b/sound/soc/intel/boards/haswell.c index 11d0cc2b0e390..060da95770416 100644 --- a/sound/soc/intel/boards/haswell.c +++ b/sound/soc/intel/boards/haswell.c @@ -197,6 +197,7 @@ static struct platform_driver haswell_audio = { .probe = haswell_audio_probe, .driver = { .name = "haswell-audio", + .pm = &snd_soc_pm_ops, }, }; -- 2.27.0

1 0

[PATCH AUTOSEL 4.14 1/9] ASoC: Intel: haswell: Add missing pm_ops
by Sasha Levin 20 Jan '21

20 Jan '21

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit bb224c3e3e41d940612d4cc9573289cdbd5cb8f5 ] haswell machine board is missing pm_ops what prevents it from undergoing suspend-resume procedure successfully. Assign default snd_soc_pm_ops so this is no longer the case. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Link: https://lore.kernel.org/r/20201217105401.27865-1-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/boards/haswell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/haswell.c b/sound/soc/intel/boards/haswell.c index 8158409921e02..c6007aa95fff1 100644 --- a/sound/soc/intel/boards/haswell.c +++ b/sound/soc/intel/boards/haswell.c @@ -197,6 +197,7 @@ static struct platform_driver haswell_audio = { .probe = haswell_audio_probe, .driver = { .name = "haswell-audio", + .pm = &snd_soc_pm_ops, }, }; -- 2.27.0

1 0