July 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap
by Shengjiu Wang 16 Jul '20

16 Jul '20

Add missed return for snd_soc_pcm_component_mmap, otherwise it always return -EINVAL. Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/soc-component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c index af9909c5492f..cde7b9c609bb 100644 --- a/sound/soc/soc-component.c +++ b/sound/soc/soc-component.c @@ -705,7 +705,7 @@ int snd_soc_pcm_component_mmap(struct snd_pcm_substream *substream, /* FIXME. it returns 1st mmap now */ for_each_rtd_components(rtd, i, component) if (component->driver->mmap) - soc_component_ret( + return soc_component_ret( component, component->driver->mmap(component, substream, vma)); -- 2.27.0

3 2

[PATCH] soundwire: fix the kernel-doc comment
by Vinod Koul 16 Jul '20

16 Jul '20

sdw_startup_stream() and sdw_shutdown_stream() argument has been updated but not the comments, so update these as well to fix warning with W=1 drivers/soundwire/stream.c:1859: warning: Function parameter or member 'sdw_substream' not described in 'sdw_startup_stream' drivers/soundwire/stream.c:1859: warning: Excess function parameter 'stream' description in 'sdw_startup_stream' drivers/soundwire/stream.c:1903: warning: Function parameter or member 'sdw_substream' not described in 'sdw_shutdown_stream' drivers/soundwire/stream.c:1903: warning: Excess function parameter 'stream' description in 'sdw_shutdown_stream' Signed-off-by: Vinod Koul <vkoul(a)kernel.org> --- drivers/soundwire/stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 6bc2ff29c202..37290a799023 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1851,7 +1851,7 @@ static int set_stream(struct snd_pcm_substream *substream, /** * sdw_startup_stream() - Startup SoundWire stream * - * @stream: Soundwire stream + * @sdw_substream: Soundwire stream * * Documentation/driver-api/soundwire/stream.rst explains this API in detail */ @@ -1895,7 +1895,7 @@ EXPORT_SYMBOL(sdw_startup_stream); /** * sdw_shutdown_stream() - Shutdown SoundWire stream * - * @stream: Soundwire stream + * @sdw_substream: Soundwire stream * * Documentation/driver-api/soundwire/stream.rst explains this API in detail */ -- 2.26.2

2 2

[PATCH][resend] ASoC: dt-bindings: ak4613: switch to yaml base Documentation
by Kuninori Morimoto 16 Jul '20

16 Jul '20

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> This patch switches from .txt base to .yaml base Document. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- - 2weeks passed, but nothing happen .../devicetree/bindings/sound/ak4613.txt | 27 ---------- .../devicetree/bindings/sound/ak4613.yaml | 49 +++++++++++++++++++ 2 files changed, 49 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ak4613.txt create mode 100644 Documentation/devicetree/bindings/sound/ak4613.yaml diff --git a/Documentation/devicetree/bindings/sound/ak4613.txt b/Documentation/devicetree/bindings/sound/ak4613.txt deleted file mode 100644 index 49a2e74fd9cb..000000000000 --- a/Documentation/devicetree/bindings/sound/ak4613.txt +++ /dev/null @@ -1,27 +0,0 @@ -AK4613 I2C transmitter - -This device supports I2C mode only. - -Required properties: - -- compatible : "asahi-kasei,ak4613" -- reg : The chip select number on the I2C bus - -Optional properties: -- asahi-kasei,in1-single-end : Boolean. Indicate input / output pins are single-ended. -- asahi-kasei,in2-single-end rather than differential. -- asahi-kasei,out1-single-end -- asahi-kasei,out2-single-end -- asahi-kasei,out3-single-end -- asahi-kasei,out4-single-end -- asahi-kasei,out5-single-end -- asahi-kasei,out6-single-end - -Example: - -&i2c { - ak4613: ak4613@10 { - compatible = "asahi-kasei,ak4613"; - reg = <0x10>; - }; -}; diff --git a/Documentation/devicetree/bindings/sound/ak4613.yaml b/Documentation/devicetree/bindings/sound/ak4613.yaml new file mode 100644 index 000000000000..eb915377bc5d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ak4613.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ak4613.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AK4613 I2C transmitter Device Tree Bindings + +maintainers: + - Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> + +properties: + compatible: + const: asahi-kasei,ak4613 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +patternProperties: + "^asahi-kasei,in[1-2]-single-end$": + description: Input Pin 1 - 2. + $ref: /schemas/types.yaml#/definitions/flag + + "^asahi-kasei,out[1-6]-single-end$": + description: Output Pin 1 - 6. + $ref: /schemas/types.yaml#/definitions/flag + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + ak4613: ak4613@10 { + compatible = "asahi-kasei,ak4613"; + reg = <0x10>; + }; + }; -- 2.25.1

3 3

[PATCH] ASoC: cros_ec_codec: Reset I2S RX when probing
by Yu-Hsuan Hsu 15 Jul '20

15 Jul '20

It is not guaranteed that I2S RX is disabled when the kernel booting. For example, if the kernel crashes while it is enabled, it will keep enabled until the next time EC reboots. Reset I2S RX when probing to fix this issue. Signed-off-by: Yu-Hsuan Hsu <yuhsuan(a)chromium.org> --- include/linux/platform_data/cros_ec_commands.h | 1 + sound/soc/codecs/cros_ec_codec.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h index 69210881ebac8..11ce917ca924c 100644 --- a/include/linux/platform_data/cros_ec_commands.h +++ b/include/linux/platform_data/cros_ec_commands.h @@ -4598,6 +4598,7 @@ enum ec_codec_i2s_rx_subcmd { EC_CODEC_I2S_RX_SET_SAMPLE_DEPTH = 0x2, EC_CODEC_I2S_RX_SET_DAIFMT = 0x3, EC_CODEC_I2S_RX_SET_BCLK = 0x4, + EC_CODEC_I2S_RX_RESET = 0x5, EC_CODEC_I2S_RX_SUBCMD_COUNT, }; diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c index 8d45c628e988e..5495214e73e68 100644 --- a/sound/soc/codecs/cros_ec_codec.c +++ b/sound/soc/codecs/cros_ec_codec.c @@ -1034,6 +1034,13 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev) } priv->ec_capabilities = r.capabilities; + /* Reset EC codec I2S RX. */ + p.cmd = EC_CODEC_I2S_RX_RESET; + ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX, + (uint8_t *)&p, sizeof(p), NULL, 0); + if (ret) + dev_err(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret); + platform_set_drvdata(pdev, priv); ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver, -- 2.27.0.383.g050319c2ae-goog

3 6

[PATCH 00/10] ALSA: Replace words for inclusive terminalogy guideline
by Takashi Iwai 15 Jul '20

15 Jul '20

Hi, this is a patch set to replace some words and sentences for adapting the recent inclusive terminology guidelines. Takashi === Takashi Iwai (10): ALSA: Replace the word "slave" in vmaster API ALSA: ac97: Replace the words white/blacklist ALSA: bt87x: Replace the words white/blacklist ALSA: ctxfi: Replace the word blacklist ALSA: es1968: Replace the words white/blacklist ALSA: hda: Replace the words white/blacklist ALSA: intel8x0: Replace the words white/blacklist ALSA: nm256: Replace the words blacklist ALSA: via82xx: Replace the words whitelist ALSA: usb-audio: Replace blacklist word include/sound/control.h | 45 +++---- include/sound/hda_codec.h | 2 +- sound/core/vmaster.c | 261 ++++++++++++++++++++-------------------- sound/pci/ac97/ac97_patch.c | 34 +++--- sound/pci/bt87x.c | 14 +-- sound/pci/ca0106/ca0106_mixer.c | 18 +-- sound/pci/ctxfi/ctatc.c | 2 +- sound/pci/es1968.c | 20 +-- sound/pci/hda/hda_codec.c | 94 +++++++-------- sound/pci/hda/hda_generic.c | 20 +-- sound/pci/hda/hda_generic.h | 2 +- sound/pci/hda/hda_intel.c | 26 ++-- sound/pci/hda/hda_local.h | 10 +- sound/pci/hda/patch_ca0132.c | 10 +- sound/pci/hda/patch_realtek.c | 6 +- sound/pci/hda/patch_sigmatel.c | 2 +- sound/pci/ice1712/juli.c | 16 +-- sound/pci/ice1712/quartet.c | 12 +- sound/pci/intel8x0.c | 6 +- sound/pci/nm256/nm256.c | 8 +- sound/pci/via82xx.c | 6 +- sound/ppc/awacs.c | 12 +- sound/usb/6fire/control.c | 2 +- sound/usb/quirks-table.h | 2 +- 24 files changed, 316 insertions(+), 314 deletions(-) -- 2.16.4

3 16

[PATCH] sound/soc/soc-core: Removed instances of 'blacklist'
by Paul Schulz 15 Jul '20

15 Jul '20

This patch removes 'blacklist' and replaces it with 'invalid list' in sound/soc/soc-core.c This is a functionally trivial patch and has no other effect. Signed-off-by: Paul Schulz <paul(a)mawsonlakes.org> --- sound/soc/soc-core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0f30f5aabaa8..6bc56c4cb207 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1457,11 +1457,11 @@ EXPORT_SYMBOL_GPL(snd_soc_runtime_set_dai_fmt); #ifdef CONFIG_DMI /* - * If a DMI filed contain strings in this blacklist (e.g. + * If a DMI filed contain strings in this invalid list (e.g. * "Type2 - Board Manufacturer" or "Type1 - TBD by OEM"), it will be taken * as invalid and dropped when setting the card long name from DMI info. */ -static const char * const dmi_blacklist[] = { +static const char * const dmi_invalid_list[] = { "To be filled by OEM", "TBD by OEM", "Default String", @@ -1493,14 +1493,14 @@ static void cleanup_dmi_name(char *name) /* * Check if a DMI field is valid, i.e. not containing any string - * in the black list. + * in the invalid list. */ static int is_dmi_valid(const char *field) { int i = 0; - while (dmi_blacklist[i]) { - if (strstr(field, dmi_blacklist[i])) + while (dmi_invalid_list[i]) { + if (strstr(field, dmi_invalid_list[i])) return 0; i++; } -- 2.25.1

1 0

[PATCH v3 00/10] topology: decode: Various fixes
by Piotr Maziarz 15 Jul '20

15 Jul '20

This series fixes various problems with topology decoding mechanism. Some of the problems were critical like improper memory management or infinite loops that were causing undefined behaviour or program crashes, while other resulted in losing some data during conversion. Bugs found while testing with Intel SST topologies. Changelog: v2: -Divide into more patches, critical fixes are in separate patches now -More specific descriptions -Fix a typo UML to UCM -Add error reporting in topology: decode: fix channel map memory allocation -Remove goto again in topology: Make buffer for saving dynamic size for better readability v3: -No functional changes -Changed UCM to more descriptive standard ALSA configuration files -removed Gerrit's Change-Id -Added missing signed-offs Piotr Maziarz (10): topology: decode: Fix channel map memory allocation topology: decode: Fix infinite loop in decoding enum control topology: decode: Remove decoding values for enum control topology: decode: Add enum control texts as separate element topology: decode: Fix printing texts section topology: decode: Change declaration of enum decoding function topology: decode: Fix decoding PCM formats and rates topology: decode: Print sig_bits field in PCM capabilities section topology: decode: Add DAI name printing topology: Make buffer for saving dynamic size src/topology/ctl.c | 51 ++++++++++++++++++++++------------------------- src/topology/dapm.c | 3 +-- src/topology/pcm.c | 11 +++++++--- src/topology/save.c | 34 ++++++++++++++++++++++++++----- src/topology/text.c | 2 +- src/topology/tplg_local.h | 2 +- 6 files changed, 64 insertions(+), 39 deletions(-) -- 2.7.4

3 16

[PATCH 0/9] soundwire: intel: revisit SHIM programming
by Bard Liao 15 Jul '20

15 Jul '20

This series does some cleanup, revisits SHIM programming sequences, and merges Soundwire interrupt handlers/threads. Bard Liao (2): soundwire: intel/cadence: merge Soundwire interrupt handlers/threads Soundwire: intel_init: save Slave(s) _ADR info in sdw_intel_ctx Pierre-Louis Bossart (6): soundwire: intel: reuse code for wait loops to set/clear bits soundwire: intel: revisit SHIM programming sequences. soundwire: intel: introduce a helper to arm link synchronization soundwire: intel: introduce helper for link synchronization soundwire: intel_init: add implementation of sdw_intel_enable_irq() soundwire: intel_init: use EXPORT_SYMBOL_NS Rander Wang (1): soundwire: intel: add wake interrupt support drivers/soundwire/cadence_master.c | 18 +- drivers/soundwire/cadence_master.h | 4 + drivers/soundwire/intel.c | 389 ++++++++++++++++++++++------ drivers/soundwire/intel.h | 9 + drivers/soundwire/intel_init.c | 101 +++++++- include/linux/soundwire/sdw_intel.h | 2 + 6 files changed, 425 insertions(+), 98 deletions(-) -- 2.17.1

4 22

[DMIX Plugin] Using Different bindings for same Alsa card
by Vijay Palaniswamy (RBEI/ECF3) 15 Jul '20

15 Jul '20

Hi All, I have two virtual device pointing to same Alsa card ,with different bindings When audio played on both device [dmix_4_channels and dmix_2_channels] in parallel. Audio played on dmix_2_channels is getting corrupted. Validated with alsa versio : 1.2.3 Please let me know how to make it work with below configuration. Alsa configuration used for testing: ************************************************* pcm.dmix_4_channels { type dmix ipc_key 5678293 ipc_perm 0660 ipc_gid audio bindings [0 1 2 3] slave { pcm "hardware" channels 4 periods 4 period_time 40000 } } pcm.dmix_2_channels { type dmix ipc_key 5678293 ipc_perm 0660 ipc_gid audio bindings [0 1] slave { pcm "hardware" channels 2 periods 4 period_time 40000 } } pcm.hardware { type hw card 0 channels 4 rate 48000 format S16_LE } ************************************************* Best regards Palaniswamy Vijay

1 0

[PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped
by Bard Liao 15 Jul '20

15 Jul '20

Fix PRBS/Static_1 swapped definitions and indentation in sdw.h Pierre-Louis Bossart (2): soundwire: sdw.h: fix PRBS/Static_1 swapped definitions soundwire: sdw.h: fix indentation include/linux/soundwire/sdw.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.17.1

2 3