June 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH 2/3] dt-bindings: sound: Add bindings for Samsung Aries audio complex
by Jonathan Bakker 14 Jun '20

14 Jun '20

The audio system on S5PV210 Aries boards have a wm8994 codec connected to the Samsung I2S0 DAI. Jack detection is done via GPIOs, an ADC, and an extcon device (fsa9480). There are two main variants, one with an FM radio and where the wm8994 is the master for the modem audio and the other without FM and the modem is the master. Signed-off-by: Jonathan Bakker <xc-racer2(a)live.ca> --- .../bindings/sound/samsung,aries-wm8994.yaml | 147 ++++++++++++++++++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml diff --git a/Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml b/Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml new file mode 100644 index 000000000000..902a0b66628e --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml @@ -0,0 +1,147 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/samsung,aries-wm8994.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Aries audio complex with WM8994 codec + +maintainers: + - Jonathan Bakker <xc-racer2(a)live.ca> + +properties: + compatible: + oneOf: + - const: samsung,aries-wm8994 + description: With FM radio and modem master + + - const: samsung,fascinate4g-wm8994 + description: Without FM radio and modem slave + + model: + $ref: /schemas/types.yaml#/definitions/string + description: The user-visible name of this sound complex. + + cpu: + type: object + properties: + sound-dai: + minItems: 2 + maxItems: 2 + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + phandles to the I2S controller and bluetooth codec, + in that order + + codec: + type: object + properties: + sound-dai: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: phandle to the WM8994 CODEC + + samsung,audio-routing: + $ref: /schemas/types.yaml#/definitions/non-unique-string-array + description: | + List of the connections between audio + components; each entry is a pair of strings, the first being the + connection's sink, the second being the connection's source; + valid names for sources and sinks are the WM8994's pins (as + documented in its binding), and the jacks on the board - + For samsung,aries-wm8994: HP, SPK, RCV, LINE, Main Mic, Headset Mic, + or FM In + For samsung,fascinate4g-wm8994: HP, SPK, RCV, LINE, Main Mic, + or HeadsetMic + + extcon: + description: Extcon phandle for dock detection + + main-micbias-supply: + description: Supply for the micbias on the main mic + + headset-micbias-supply: + description: Supply for the micbias on the headset mic + + earpath-sel-gpios: + description: GPIO for switching between tv-out and mic paths + + headset-detect-gpios: + description: GPIO for detection of headset insertion + + headset-key-gpios: + description: GPIO for detection of headset key press + + io-channels: + maxItems: 1 + description: IO channel to read micbias voltage for headset detection + + io-channel-names: + const: headset-detect + +required: + - compatible + - model + - cpu + - codec + - samsung,audio-routing + - extcon + - main-micbias-supply + - headset-micbias-supply + - earpath-sel-gpios + - headset-detect-gpios + - headset-key-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + sound { + compatible = "samsung,fascinate4g-wm8994"; + + model = "Fascinate4G"; + + extcon = <&fsa9480>; + + main-micbias-supply = <&main_micbias_reg>; + headset-micbias-supply = <&headset_micbias_reg>; + + earpath-sel-gpios = <&gpj2 6 GPIO_ACTIVE_HIGH>; + + io-channels = <&adc 3>; + io-channel-names = "headset-detect"; + headset-detect-gpios = <&gph0 6 GPIO_ACTIVE_HIGH>; + headset-key-gpios = <&gph3 6 GPIO_ACTIVE_HIGH>; + + samsung,audio-routing = + "HP", "HPOUT1L", + "HP", "HPOUT1R", + + "SPK", "SPKOUTLN", + "SPK", "SPKOUTLP", + + "RCV", "HPOUT2N", + "RCV", "HPOUT2P", + + "LINE", "LINEOUT2N", + "LINE", "LINEOUT2P", + + "IN1LP", "Main Mic", + "IN1LN", "Main Mic", + + "IN1RP", "Headset Mic", + "IN1RN", "Headset Mic"; + + pinctrl-names = "default"; + pinctrl-0 = <&headset_det &earpath_sel>; + + cpu { + sound-dai = <&i2s0>, <&bt_codec>; + }; + + codec { + sound-dai = <&wm8994>; + }; + }; + -- 2.20.1

1 0

[PATCH 0/3] ASoC: samsung: Add machine driver for Aries boards
by Jonathan Bakker 14 Jun '20

14 Jun '20

This is a machine driver for Aries boards which are based on Samsung's S5PV210 platform. These are the first-gen Galaxy S devices. It consists of a WM8994 codec connected to I2S0 along with two codec-to-codec links to the modem and the bluetooth. --------- | | Modem | | --------- | AIF2 | ---------- --------- | | AIF1 | | I2S ------- wm8994 | | | | ---------- --------- | AIF3 | --------- | | BT | | --------- Jack detection is relatively complex with various GPIOs, an ADC, and an extcon device all involved. One oddity is that the headphone jack is shared between the mic and the analog tv-out and is controlled by a GPIO (earpath-sel) and the proper path should be selected based on the jack detection. There is also an oddity with how the speaker is connected. It's a mono speaker and the spkmode pin is pulled up, but the connections aren't bridged so if stereo playback is attempted, only the one channel will play. Therefore, when the speaker is enabled the entire AIF should be forced into mono mode. UCM2 config files are available at https://github.com/xc-racer99/aries-hw-files/tree/ucm2/usr/share/alsa/ucm2 Jonathan Bakker (3): dt-bindings: sound: Document wm8994 endpoints dt-bindings: sound: Add bindings for Samsung Aries audio complex ASoC: samsung: Add driver for Aries boards .../bindings/sound/samsung,aries-wm8994.yaml | 147 ++++ .../devicetree/bindings/sound/wm8994.txt | 23 + sound/soc/samsung/Kconfig | 13 + sound/soc/samsung/Makefile | 2 + sound/soc/samsung/aries_wm8994.c | 695 ++++++++++++++++++ 5 files changed, 880 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,aries-wm8994.yaml create mode 100644 sound/soc/samsung/aries_wm8994.c -- 2.20.1

1 0

alsa usb problem
by GitHub issues - opened 14 Jun '20

14 Jun '20

alsa-project/alsa-lib issue #59 was opened from texstar: Plugging in a usb microphone causes pulse audio to crash with alsa-lib 1.2.3. Issue URL : https://github.com/alsa-project/alsa-lib/issues/59 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: next-0519 on thinkpad x60: sound related? window manager crash
by Alex Xu (Hello71) 14 Jun '20

14 Jun '20

Excerpts from Takashi Iwai's message of June 9, 2020 11:12 am: > On Tue, 09 Jun 2020 13:47:33 +0200, > Christoph Hellwig wrote: >> >> Alex, can you try this patch? > > Also could you check whether just papering over the memset() call > alone avoids the crash like below? For PulseAudio and dmix/dsnoop, > it's the only code path that accesses the vmapped buffer, I believe. > > If this works more or less, I'll cook a more comprehensive fix. > > > thanks, > > Takashi > > --- a/sound/core/pcm_native.c > +++ b/sound/core/pcm_native.c > @@ -754,9 +754,11 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream, > while (runtime->boundary * 2 <= LONG_MAX - runtime->buffer_size) > runtime->boundary *= 2; > > +#if 0 > /* clear the buffer for avoiding possible kernel info leaks */ > if (runtime->dma_area && !substream->ops->copy_user) > memset(runtime->dma_area, 0, runtime->dma_bytes); > +#endif > > snd_pcm_timer_resolution_change(substream); > snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP); > Sorry, this patch doesn't work for me with SME off using abfbb29297c2. David's newest submitted patch works for me, which I already replied to separately. Thanks, Alex.

2 5

[PATCH] ALSA: firewire-motu: wait for notification when changing clock configuration for protocol v3
by Takashi Sakamoto 14 Jun '20

14 Jun '20

This patch is for development period of v5.9 kernel. It costs expensive to change clock configuration for models of protocol version 3. In current implementation, speculative strategy is used to finish the operation; just waiting for 4 seconds. As long as I investigate, when accepting and changing clock status actually, the device sends notification with mask. This commit uses wise way to wait for the notification after changing sampling clock rate during 4 seconds. Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/motu/motu-protocol-v3.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/sound/firewire/motu/motu-protocol-v3.c b/sound/firewire/motu/motu-protocol-v3.c index 01a47ac7bb2d..4e6b0e449ee4 100644 --- a/sound/firewire/motu/motu-protocol-v3.c +++ b/sound/firewire/motu/motu-protocol-v3.c @@ -24,6 +24,9 @@ #define V3_NO_ADAT_OPT_OUT_IFACE_A 0x00040000 #define V3_NO_ADAT_OPT_OUT_IFACE_B 0x00400000 +#define V3_MSG_FLAG_CLK_CHANGED 0x00000002 +#define V3_CLK_WAIT_MSEC 4000 + int snd_motu_protocol_v3_get_clock_rate(struct snd_motu *motu, unsigned int *rate) { @@ -79,9 +82,16 @@ int snd_motu_protocol_v3_set_clock_rate(struct snd_motu *motu, return err; if (need_to_wait) { - /* Cost expensive. */ - if (msleep_interruptible(4000) > 0) - return -EINTR; + int result; + + motu->msg = 0; + result = wait_event_interruptible_timeout(motu->hwdep_wait, + motu->msg & V3_MSG_FLAG_CLK_CHANGED, + msecs_to_jiffies(V3_CLK_WAIT_MSEC)); + if (result < 0) + return result; + if (result == 0) + return -ETIMEDOUT; } return 0; -- 2.25.1

1 0

alsa-gobject: add Python 3 sample scripts
by GitHub pull_request - opened 14 Jun '20

14 Jun '20

alsa-project/alsa-gobject pull request #37 was opened from takaswie: PyGObject is a loader for GObject Introspection in Python 3 runtime. This patchset adds Python 3 sample scripts to use ALSACtl, ALSAHwdep, ALSARawmidi, ALSATimer, and ALSASeq loaded by PyGObject. Request URL : https://github.com/alsa-project/alsa-gobject/pull/37 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/37.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

alsa-gobject: seq: fix port creation API
by GitHub pull_request - opened 14 Jun '20

14 Jun '20

alsa-project/alsa-gobject pull request #36 was opened from takaswie: ALSASeq.UserClient.create_port() has nullable argument for the numerical ID of port to use SNDRV_SEQ_PORT_FLG_GIVEN_PORT flag properly. However, the nullable is not inconvenient for PyGObject and causes SIGSEGV. This patchset adds an alternative API, ALSASeq.UserClient.create_port_at() for the flag, then ALSASeq.UserClient.create_port() hs no argument for explicit port ID. Additionally, this patchset includes some fixes for the other parts. Request URL : https://github.com/alsa-project/alsa-gobject/pull/36 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/36.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH] ALSA: usb-audio: add quirk for Denon DCD-1500RE
by Yick W. Tse 14 Jun '20

14 Jun '20

fix error "clock source 41 is not valid, cannot use" [] New USB device found, idVendor=154e, idProduct=1002, bcdDevice= 1.00 [] New USB device strings: Mfr=1, Product=2, SerialNumber=0 [] Product: DCD-1500RE [] Manufacturer: D & M Holdings Inc. [] [] clock source 41 is not valid, cannot use [] usbcore: registered new interface driver snd-usb-audio Signed-off-by: Yick W. Tse <y_w_tse(a)yahoo.com.hk> --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index bca0179a0ef8..c495e720e2f1 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1532,6 +1532,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip) static bool is_itf_usb_dsd_dac(unsigned int id) { switch (id) { + case USB_ID(0x154e, 0x1002): /* Denon DCD-1500RE */ case USB_ID(0x154e, 0x1003): /* Denon DA-300USB */ case USB_ID(0x154e, 0x3005): /* Marantz HD-DAC1 */ case USB_ID(0x154e, 0x3006): /* Marantz SA-14S1 */ --

2 1

Cannot get Lenovo P520/Realtek ALC662 (rev 3) to produce sound
by Jan Pokorny 14 Jun '20

14 Jun '20

Hello list, this time within wider circle (and with more experience so far). I am seeking for help with shiny new Lenovo P520 machine that only lacks one thing for me to be entirely happy it. I believe this is relatively a new batch -- intentionally mentioning it since the topic of this very machine appears to be a settled case already: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… With newest BIOS, running the most recent kernel from Fedora Rawhide (but I did try 5.5.10 kernel from Fedora 30 as well), booted via UEFI (incl. secure boot), the only way to get it to produce any sound whatsoever is to manually load snd-pcsp [*1]. With that done, virtual terminal starts to beep as expected (as in printf '\a'), I am able to run "beep" program, and even "aplay -D hw:pcsp /usr/share/sound/alsa/*.wav" is producing the respective sounds, despite suffering from surrounding noise[*]. That validates that basic function of the built-in speaker works just fine (and previously, it was validated under Windows that it worked just fine). As the linked commit indicates, the proper model parameter to snd-hda-audio module is dual-codecs. I've tried that, and a handful of other models, to no avail. I considered the possibility the problem is just that I cannot work with "mute" state properly, so tried everything I could (incl. alsaunmute), again, without any change. Next dimension to the matrix was attaching external speaker to the front connector. Nothing has helped. Comparing outputs from alsa-info.sh for both states, "no model specified" and "dual-codecs" specified, there was no observable change other than this sole "model" parameter not/being (null). I am not sure whether this means this particular predefined quirk was applied properly, or the same observation is to be expected in general. Note that said quirk is, IIUIC, normally hooked onto the presence of "Subsystem: Lenovo Device 1036" (as in from lspci), and it is what this machine assuredly satisfies. I am attaching the output from the plain/default case, and looking forward to being able to move at least a bit with this. I'd be fine, for the time being, to use the sketched "PC speaker" workaround, if only it wasn't spoiled with so much noise/hum (no audio connector was used at that time). But that won't solve the urging general teleconferencing problem of these days, apparently. [*1] at a matter of fact, even it should play no role here, there was a change between this 5.7.0.rc7 kernel and the other tested, 5.5.10, in that the respective (another, IIRC) module got loaded automatically in the latter/older, whereas it needed to be loaded manually with the former/newer [*2] perhaps resembled https://bugzilla.redhat.com/show_bug.cgi?id=1660581 that I found when trying to do an extensive search around similar problems Thanks -- Jan

3 6

dlmisc.c: fix uclibc build
by GitHub pull_request - opened 13 Jun '20

13 Jun '20

alsa-project/alsa-lib pull request #58 was opened from bkuhls: RTLD_DL_LINKMAP & RTLD_DI_ORIGIN, are unsupported on uClibc: https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/dlfcn.h#n106 This patch adds detection for uClibc because uClibc also defines __GLIBC__: https://lists.gnu.org/archive/html/bug-gnulib/2010-11/msg00280.html Request URL : https://github.com/alsa-project/alsa-lib/pull/58 Patch URL : https://github.com/alsa-project/alsa-lib/pull/58.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0