June 2020 - Alsa-devel - mailman.alsa-project.org

Move ownership for repositories in Github related to gobject-introspection
by Takashi Sakamoto 18 Jun '20

18 Jun '20

Hi Jaroslav, Now I'm going to prepare for official release of alsa-gobject v0.1.0. At the same time, Rust binding is also OK to be released. Currently It's in my private repository[1] but I think it better to put under alsa-project project account in Github. Github supports transferring ownership, and this time I'd like to utilize the feature if you don't mind it. After transferring. some arrangement for the repository are perhaps required; e.g. to put it to 'gobject-introspection' team[3]. Would I ask it to you? Additionally, I'd like to move repositories for libhinawa[4][5][6] as well, which is required to make up control service in user space for devices supported by ALSA firewire stack[7]. [1] https://github.com/takaswie/alsa-gobject-rs/ [2] https://help.github.com/en/github/administering-a-repository/transferring-a… [3] https://github.com/orgs/alsa-project/teams/gobject-introspection [4] https://github.com/takaswie/libhinawa [5] https://github.com/takaswie/libhinawa-docs [6] https://github.com/takaswie/hinawa-rs [7] https://mailman.alsa-project.org/pipermail/alsa-devel/2020-June/168550.html Regards Takashi Sakamoto

2 6

[PATCH 0/3] ASoC: SOF: Intel: update PCI IDs
by Pierre-Louis Bossart 17 Jun '20

17 Jun '20

Clean-up CometLake and add missing PCI IDs. Changes for the legacy driver are sent separately. Pierre-Louis Bossart (3): ASoC: Intel: SOF: merge COMETLAKE_LP and COMETLAKE_H ASoC: SOF: Intel: add PCI ID for CometLake-S ASoC: SOF: Intel: add PCI IDs for ICL-H and TGL-H sound/hda/intel-dsp-config.c | 4 +--- sound/soc/intel/boards/Kconfig | 4 ++-- sound/soc/sof/intel/Kconfig | 29 ++++++++--------------------- sound/soc/sof/sof-pci-dev.c | 24 ++++++++++++++---------- 4 files changed, 25 insertions(+), 36 deletions(-) -- 2.20.1

2 4

[PATCH] ASoC: hdac_hda: fix memleak with regmap not freed on remove
by Pierre-Louis Bossart 17 Jun '20

17 Jun '20

kmemleak throws error reports on module load/unload tests, add snd_hdac_regmap_exit() in .remove(). While we are at it, also fix the error handling flow in .probe() to use snd_hdac_regmap_exit() if needed. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Daniel Baluta <daniel.baluta(a)gmail.com> Reviewed-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/codecs/hdac_hda.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index de003acb1951..473efe9ef998 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -441,13 +441,13 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) ret = snd_hda_codec_set_name(hcodec, hcodec->preset->name); if (ret < 0) { dev_err(&hdev->dev, "name failed %s\n", hcodec->preset->name); - goto error; + goto error_pm; } ret = snd_hdac_regmap_init(&hcodec->core); if (ret < 0) { dev_err(&hdev->dev, "regmap init failed\n"); - goto error; + goto error_pm; } patch = (hda_codec_patch_t)hcodec->preset->driver_data; @@ -455,7 +455,7 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) ret = patch(hcodec); if (ret < 0) { dev_err(&hdev->dev, "patch failed %d\n", ret); - goto error; + goto error_regmap; } } else { dev_dbg(&hdev->dev, "no patch file found\n"); @@ -467,7 +467,7 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) ret = snd_hda_codec_parse_pcms(hcodec); if (ret < 0) { dev_err(&hdev->dev, "unable to map pcms to dai %d\n", ret); - goto error; + goto error_regmap; } /* HDMI controls need to be created in machine drivers */ @@ -476,7 +476,7 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) if (ret < 0) { dev_err(&hdev->dev, "unable to create controls %d\n", ret); - goto error; + goto error_regmap; } } @@ -496,7 +496,9 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) return 0; -error: +error_regmap: + snd_hdac_regmap_exit(hdev); +error_pm: pm_runtime_put(&hdev->dev); error_no_pm: snd_hdac_ext_bus_link_put(hdev->bus, hlink); @@ -518,6 +520,8 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component) pm_runtime_disable(&hdev->dev); snd_hdac_ext_bus_link_put(hdev->bus, hlink); + + snd_hdac_regmap_exit(hdev); } static const struct snd_soc_dapm_route hdac_hda_dapm_routes[] = { -- 2.20.1

2 1

sof-soundwire: initial UCM2 version
by GitHub pull_request - opened 17 Jun '20

17 Jun '20

alsa-project/alsa-ucm-conf pull request #36 was opened from plbossart: Add support for sof-soundwire driver, with conditional inclusion of sections for RT700, RT711, RT5682, RT1308, RT715. Required test files for the ucm-validation are provided at https://github.com/alsa-project/alsa-tests/pull/10 Signed-off-by: Libin Yang <libin.yang(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/36 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/36.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] regmap: fix memory leak with map->patch
by Pierre-Louis Bossart 17 Jun '20

17 Jun '20

kmemleak throws the following error on devices using regmap_register_patch(). map->patch is allocated dynamically with krealloc() but never freed. root@Zotac:~/kmod# cat /sys/kernel/debug/kmemleak unreferenced object 0xffff8880641c4e08 (size 96): comm "systemd-udevd", pid 266, jiffies 4294736541 (age 414.914s) hex dump (first 32 bytes): 3d 01 00 00 00 36 00 00 00 00 00 00 12 01 00 00 =....6.......... a8 0a 00 00 00 00 00 00 14 01 00 00 aa 0a 00 00 ................ backtrace: [<00000000f2841faf>] krealloc+0x63/0xc0 [<00000000ed643fb3>] regmap_register_patch+0x68/0x1d0 [<000000001806a5c3>] 0xffffffffc088a5f9 [<00000000f4781e26>] i2c_device_probe+0x462/0x4b0 [<000000009dd7f5f4>] really_probe+0x17f/0x520 [<00000000be42920d>] driver_probe_device+0x114/0x170 [<00000000e5840d3f>] device_driver_attach+0x82/0x90 [<0000000027828801>] __driver_attach+0xa9/0x190 [<0000000085195e73>] bus_for_each_dev+0xe1/0x140 [<0000000070edb38c>] bus_add_driver+0x224/0x2e0 [<000000002d41b24a>] driver_register+0xd3/0x150 [<0000000055dbb3fb>] i2c_register_driver+0x6b/0xd0 [<00000000bf84b954>] do_one_initcall+0x86/0x2a0 [<000000001d939871>] do_init_module+0xf8/0x350 [<00000000267b474f>] load_module+0x41a9/0x44c0 [<000000007d8014dc>] __do_sys_finit_module+0x121/0x1b0 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Daniel Baluta <daniel.baluta(a)gmail.com> Reviewed-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/base/regmap/regmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index c472f624382d..46f4b6322e47 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1357,6 +1357,7 @@ void regmap_exit(struct regmap *map) if (map->hwlock) hwspin_lock_free(map->hwlock); kfree_const(map->name); + kfree(map->patch); kfree(map); } EXPORT_SYMBOL_GPL(regmap_exit); -- 2.20.1

2 1

[PATCH] ASoC: meson: imply acodec glue on axg sound card
by Jerome Brunet 17 Jun '20

17 Jun '20

When axg card driver support is enabled, lets enable the related internal DAC glue by default. Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> --- sound/soc/meson/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/meson/Kconfig b/sound/soc/meson/Kconfig index 8b6295283989..363dc3b1bbe4 100644 --- a/sound/soc/meson/Kconfig +++ b/sound/soc/meson/Kconfig @@ -68,6 +68,7 @@ config SND_MESON_AXG_SOUND_CARD imply SND_MESON_AXG_SPDIFOUT imply SND_MESON_AXG_SPDIFIN imply SND_MESON_AXG_PDM + imply SND_MESON_G12A_TOACODEC imply SND_MESON_G12A_TOHDMITX if DRM_MESON_DW_HDMI help Select Y or M to add support for the AXG SoC sound card -- 2.25.4

2 1

[PATCH v2 1/2] ASoC: bindings: fsl-asoc-card: Add compatible string for MQS
by Shengjiu Wang 17 Jun '20

17 Jun '20

Add compatible string "fsl,imx-audio-mqs" for MQS, and move "audio-routing" property to be optional for MQS doesn't need such property. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- changes in v2 - Move "audio-routing" to optional. .../devicetree/bindings/sound/fsl-asoc-card.txt | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt index c60a5732d29c..ca9a3a43adfd 100644 --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt @@ -34,6 +34,8 @@ The compatible list for this generic sound card currently: "fsl,imx-audio-wm8960" + "fsl,imx-audio-mqs" + Required properties: - compatible : Contains one of entries in the compatible list. @@ -44,6 +46,11 @@ Required properties: - audio-codec : The phandle of an audio codec +Optional properties: + + - audio-asrc : The phandle of ASRC. It can be absent if there's no + need to add ASRC support via DPCM. + - audio-routing : A list of the connections between audio components. Each entry is a pair of strings, the first being the connection's sink, the second being the connection's @@ -60,11 +67,6 @@ Required properties: coexisting in order to support the old bindings of wm8962 and sgtl5000. -Optional properties: - - - audio-asrc : The phandle of ASRC. It can be absent if there's no - need to add ASRC support via DPCM. - Optional unless SSI is selected as a CPU DAI: - mux-int-port : The internal port of the i.MX audio muxer (AUDMUX) -- 2.21.0

3 3

[PATCH v3 1/2] ASoC: bindings: fsl_spdif: Add new compatible string for imx6sx
by Shengjiu Wang 17 Jun '20

17 Jun '20

Add new compatible string "fsl,imx6sx-spdif" in the binding document. And add compatible string "fsl,vf610-spdif" which was missed before. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Documentation/devicetree/bindings/sound/fsl,spdif.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.txt b/Documentation/devicetree/bindings/sound/fsl,spdif.txt index 8b324f82a782..e1365b0ee1e9 100644 --- a/Documentation/devicetree/bindings/sound/fsl,spdif.txt +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.txt @@ -6,7 +6,11 @@ a fibre cable. Required properties: - - compatible : Compatible list, must contain "fsl,imx35-spdif". + - compatible : Compatible list, should contain one of the following + compatibles: + "fsl,imx35-spdif", + "fsl,vf610-spdif", + "fsl,imx6sx-spdif", - reg : Offset and length of the register set for the device. -- 2.21.0

2 2

[PATCH] ASoC: tegra: Fix reference count leaks.
by wu000273＠umn.edu 17 Jun '20

17 Jun '20

From: Qiushi Wu <wu000273(a)umn.edu> Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count if pm_runtime_put is not called in error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Qiushi Wu <wu000273(a)umn.edu> --- sound/soc/tegra/tegra30_ahub.c | 4 +++- sound/soc/tegra/tegra30_i2s.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c index 635eacbd28d4..156e3b9d613c 100644 --- a/sound/soc/tegra/tegra30_ahub.c +++ b/sound/soc/tegra/tegra30_ahub.c @@ -643,8 +643,10 @@ static int tegra30_ahub_resume(struct device *dev) int ret; ret = pm_runtime_get_sync(dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put(dev); return ret; + } ret = regcache_sync(ahub->regmap_ahub); ret |= regcache_sync(ahub->regmap_apbif); pm_runtime_put(dev); diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index d59882ec48f1..db5a8587bfa4 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -567,8 +567,10 @@ static int tegra30_i2s_resume(struct device *dev) int ret; ret = pm_runtime_get_sync(dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put(dev); return ret; + } ret = regcache_sync(i2s->regmap); pm_runtime_put(dev); -- 2.17.1

3 2

pcm: direct: correctly apply existing interval settings
by GitHub pull_request - edited 17 Jun '20

17 Jun '20

alsa-project/alsa-lib pull request #62 was edited from aditpape: Feature 'variable periodsize' allows to extend user period size up to buffer_size/2 independent of slave period. On enlargement of the settings for period_time.max and period_size.max the setting for openmax was not updated. This lead to the effect, that if the slave period itself had openmax set it was still set on the extended size. Configuration of a period matching half buffer size was thus rejected. Example for failure: period size of 384 (half buffer size) is requested which is rejected and rounded down to 352: <pre> root@oracle-virtualbox:~# arecord -DDSNOOP_32 -r48000 -fS16_LE -c2 --period-size=382 -vv --dump-hw-params > /dev/null Recording WAVE 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo HW Params of device "DSNOOP_32": -------------------- ACCESS: MMAP_INTERLEAVED MMAP_NONINTERLEAVED RW_INTERLEAVED RW_NONINTERLEAVED FORMAT: S16_LE SUBFORMAT: STD SAMPLE_BITS: 16 FRAME_BITS: 32 CHANNELS: 2 RATE: 48000 PERIOD_TIME: (666 7334) PERIOD_SIZE: [32 352] PERIOD_BYTES: [128 1408] PERIODS: [2 24] BUFFER_TIME: (1333 16000] BUFFER_SIZE: [64 768] BUFFER_BYTES: [256 3072] TICK_TIME: ALL -------------------- Direct Snoop PCM Its setup is: stream : CAPTURE access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 704 period_size : 352 period_time : 7333 tstamp_mode : NONE tstamp_type : MONOTONIC period_step : 1 avail_min : 352 period_event : 0 start_threshold : 1 stop_threshold : 704 silence_threshold: 0 silence_size : 0 boundary : 6341068275337658368 Hardware PCM card 0 'Intel 82801AA-ICH' device 0 subdevice 0 Its setup is: stream : CAPTURE access : MMAP_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 768 period_size : 32 period_time : 666 tstamp_mode : ENABLE tstamp_type : MONOTONIC period_step : 1 avail_min : 32 period_event : 0 start_threshold : 1 stop_threshold : 6917529027641081856 silence_threshold: 0 silence_size : 0 boundary : 6917529027641081856 appl_ptr : 0 hw_ptr : 224 When correctly applying the openmax setting: root@oracle-virtualbox:~# arecord -DDSNOOP_32 -r48000 -fS16_LE -c2 --period-size=382 -vv --dump-hw-params > /dev/null Recording WAVE 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo HW Params of device "DSNOOP_32": -------------------- ACCESS: MMAP_INTERLEAVED MMAP_NONINTERLEAVED RW_INTERLEAVED RW_NONINTERLEAVED FORMAT: S16_LE SUBFORMAT: STD SAMPLE_BITS: 16 FRAME_BITS: 32 CHANNELS: 2 RATE: 48000 PERIOD_TIME: (666 8000] PERIOD_SIZE: [32 384] PERIOD_BYTES: [128 1536] PERIODS: [2 24] BUFFER_TIME: (1333 16000] BUFFER_SIZE: [64 768] BUFFER_BYTES: [256 3072] TICK_TIME: ALL -------------------- Direct Snoop PCM Its setup is: stream : CAPTURE access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 768 period_size : 384 period_time : 8000 tstamp_mode : NONE tstamp_type : MONOTONIC period_step : 1 avail_min : 384 period_event : 0 start_threshold : 1 stop_threshold : 768 silence_threshold: 0 silence_size : 0 boundary : 6917529027641081856 Hardware PCM card 0 'Intel 82801AA-ICH' device 0 subdevice 0 Its setup is: stream : CAPTURE access : MMAP_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 768 period_size : 32 period_time : 666 tstamp_mode : ENABLE tstamp_type : MONOTONIC period_step : 1 avail_min : 32 period_event : 0 start_threshold : 1 stop_threshold : 6917529027641081856 silence_threshold: 0 silence_size : 0 boundary : 6917529027641081856 appl_ptr : 0 hw_ptr : 224 </pre> Signed-off-by: Andreas Pape <apape(a)de.adit-jv.com> Request URL : https://github.com/alsa-project/alsa-lib/pull/62 Patch URL : https://github.com/alsa-project/alsa-lib/pull/62.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0