April 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: topology: remove unneeded semicolon
by Jason Yan 20 Apr '20

20 Apr '20

Fix the following coccicheck warning: sound/soc/soc-topology.c:2344:2-3: Unneeded semicolon Signed-off-by: Jason Yan <yanaijie(a)huawei.com> --- sound/soc/soc-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 33e8d189ba2f..a5cd73742dc5 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -2390,7 +2390,7 @@ static int soc_tplg_link_elems_load(struct soc_tplg *tplg, tplg->pos += le32_to_cpu(hdr->size) + le32_to_cpu(hdr->payload_size); return 0; - }; + } /* check the element size and count */ link = (struct snd_soc_tplg_link_config *)tplg->pos; -- 2.21.1

2 1

[PATCH 0/2] ASoC: rsnd: multi-SSI setup fixes
by Matthias Blankertz 20 Apr '20

20 Apr '20

Fix rsnd_dai_call() operations being performed twice for the master SSI in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI setups. The only visible effect of these issues was some "status check failed" spam when the rsnd_ssi_stop was called, but overall the code is cleaner now, and some questionable writes to the SSICR register which did not lead to any observable misbehaviour but were contrary to the datasheet are fixed. Mark: The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode" from a few days ago and achieves the same effect in a simpler fashion, if you would prefer a clean patch series based on v5.6 drop me a note. Greetings, Matthias Matthias Blankertz (2): ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent ASoC: rsnd: Fix "status check failed" spam for multi-SSI sound/soc/sh/rcar/ssi.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) base-commit: 15a5760cb8b6d5c1ebbf1d2e1f0b77380ab68a82 -- 2.26.1

3 4

[PATCH 0/2] ASoC: meson: fix codec-to-codec link setup
by Jerome Brunet 20 Apr '20

20 Apr '20

This patchset fixes the problem reported by Marc in this thread [0] The problem was due to an error in the meson card drivers which had the "no_pcm" dai_link property set on codec-to-codec links [0]: https://lore.kernel.org/r/20200417122732.GC5315@sirena.org.uk Jerome Brunet (2): ASoC: meson: axg-card: fix codec-to-codec link setup ASoC: meson: gx-card: fix codec-to-codec link setup sound/soc/meson/axg-card.c | 4 +++- sound/soc/meson/gx-card.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.25.2

2 3

[PATCH] ASoC: dapm: fixup dapm kcontrol widget
by Gyeongtaek Lee 20 Apr '20

20 Apr '20

snd_soc_dapm_kcontrol widget which is created by autodisable control should contain correct on_val, mask and shift because it is set when the widget is powered and changed value is applied on registers by following code in dapm_seq_run_coalesced(). mask |= w->mask << w->shift; if (w->power) value |= w->on_val << w->shift; else value |= w->off_val << w->shift; Shift on the mask in dapm_kcontrol_data_alloc() is removed to prevent double shift. And, on_val in dapm_kcontrol_set_value() is modified to get correct value in the dapm_seq_run_coalesced(). Signed-off-by: Gyeongtaek Lee <gt82.lee(a)samsung.com> Cc: stable(a)vger.kernel.org --- sound/soc/soc-dapm.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index a4143ca190d0..e2632841b321 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -423,7 +423,7 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, memset(&template, 0, sizeof(template)); template.reg = e->reg; - template.mask = e->mask << e->shift_l; + template.mask = e->mask; template.shift = e->shift_l; template.off_val = snd_soc_enum_item_to_val(e, 0); template.on_val = template.off_val; @@ -546,8 +546,22 @@ static bool dapm_kcontrol_set_value(const struct snd_kcontrol *kcontrol, if (data->value == value) return false; - if (data->widget) - data->widget->on_val = value; + if (data->widget) { + switch (dapm_kcontrol_get_wlist(kcontrol)->widgets[0]->id) { + case snd_soc_dapm_switch: + case snd_soc_dapm_mixer: + case snd_soc_dapm_mixer_named_ctl: + data->widget->on_val = value & data->widget->mask; + break; + case snd_soc_dapm_demux: + case snd_soc_dapm_mux: + data->widget->on_val = value >> data->widget->shift; + break; + default: + data->widget->on_val = value; + break; + } + } data->value = value; base-commit: ecdcf8a833d770347115f739a37583cdc6ddbf7a -- 2.21.0

2 1

[PATCH 0/2] ASoC: qdsp6: fix default FE dais and routings.
by Srinivas Kandagatla 20 Apr '20

20 Apr '20

QDSP6 Frontend dais can be configured to work in rx or tx or both rx/tx mode, however the default routing do not honour this DT configuration making sound card fail to probe. FE dais are also not fully honouring device tree configuration. Fix both of them. Originally issue was reported by Vinod Koul Srinivas Kandagatla (2): ASoC: qdsp6: q6asm-dai: only enable dais from device tree ASoC: qdsp6: q6routing: remove default routing sound/soc/qcom/qdsp6/q6asm-dai.c | 30 +++++++++++++++++++++++------- sound/soc/qcom/qdsp6/q6routing.c | 19 ------------------- 2 files changed, 23 insertions(+), 26 deletions(-) -- 2.21.0

4 11

wm8960 codec driver question
by Alexey Shinkin 20 Apr '20

20 Apr '20

Hi, I hope this is the right place to ask . In the driver ( soc/codecs/wm8960.c ) there is a function that sets pll - the wm8960_set_pll() , line 1185 . On exit , the function turns on the pll clocking like this : /* Turn it on */ snd_soc_component_update_bits(component, WM8960_POWER2, 0x1, 0x1); msleep(250); snd_soc_component_update_bits(component, WM8960_CLOCK1, 0x1, 0x1); What is the reason for the 250 ms delay ? I did not find anything related in the chip datasheet . I found the delay very annoying in my app that generates an audible feedback to touchscreen events. Looks like it is safe to comment out the msleep() call , could there be any implications ? Best regards, Alex Shinkin

2 1

[PATCH] ALSA: usx2y: Fix potential NULL dereference
by Takashi Iwai 20 Apr '20

20 Apr '20

The error handling code in usX2Y_rate_set() may hit a potential NULL dereference when an error occurs before allocating all us->urb[]. Add a proper NULL check for fixing the corner case. Reported-by: Lin Yi <teroincn(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/usx2y/usbusx2yaudio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c index 37d290fe9d43..ecaf41265dcd 100644 --- a/sound/usb/usx2y/usbusx2yaudio.c +++ b/sound/usb/usx2y/usbusx2yaudio.c @@ -681,6 +681,8 @@ static int usX2Y_rate_set(struct usX2Ydev *usX2Y, int rate) us->submitted = 2*NOOF_SETRATE_URBS; for (i = 0; i < NOOF_SETRATE_URBS; ++i) { struct urb *urb = us->urb[i]; + if (!urb) + continue; if (urb->status) { if (!err) err = -ENODEV; -- 2.16.4

1 0

sound: usb: usx2y: is it a null pointer deference in function usX2Y_rate_set?
by 亿一 20 Apr '20

20 Apr '20

Hi, all: when reviewing function usX2Y_rate_set, here may exist a NULL pointer deference if kmalloc_array failed or usb_alloc_urb failed, in cleanup, we should judge whether us->urb[i] is NULL first. static int usX2Y_rate_set(struct usX2Ydev *usX2Y, int rate) { us = kzalloc(sizeof(*us) + sizeof(struct urb*) * NOOF_SETRATE_URBS, GFP_KERNEL); if (NULL == us) { err = -ENOMEM; goto cleanup; } usbdata = kmalloc_array(NOOF_SETRATE_URBS, sizeof(int), GFP_KERNEL); if (NULL == usbdata) { err = -ENOMEM; goto cleanup; } for (i = 0; i < NOOF_SETRATE_URBS; ++i) { if (NULL == (us->urb[i] = usb_alloc_urb(0, GFP_KERNEL))) { err = -ENOMEM; goto cleanup; } ... } ... cleanup: if (us) { us->submitted = 2*NOOF_SETRATE_URBS; for (i = 0; i < NOOF_SETRATE_URBS; ++i) { struct urb *urb = us->urb[i]; if (urb->status) { if (!err) err = -ENODEV; usb_kill_urb(urb); } usb_free_urb(urb);

2 2

PROBLEM: No sound on ASUS ROG Zenith Extreme in 5.6.5
by Johnathan Smithinovic 20 Apr '20

20 Apr '20

PROBLEM: No sound on ASUS ROG Zenith Extreme since 5.6.5 When I upgraded from 5.6.4 to 5.6.5 I noticed that my sound stopped working. My motherboard is a first generation "ASUS ROG Zenith Extreme". (I'm running Ubuntu 18.04 in case that matters.) I'm pretty sure it comes from stable kernel release commit 7f722d9aa00fde795834840cc84e13a94efb29ed (git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git) which notes "commit 3c6fd1f07ed03a04debbb9a9d782205f1ef5e2ab upstream." ("ALSA: hda: Add driver blacklist"). When I comment out 'SND_PCI_QUIRK(0x1043, 0x874f, "ASUS ROG Zenith II / Strix", 0),' in sound/pci/hda/hda_intel.c my sound works again. (In case I chose incorrect places to write this mail to I'm sorry. I tried to follow https://www.kernel.org/doc/html/latest/admin-guide/reporting-bugs.html while keeping this report minimal.) Kind regards John

2 3

MIPS ioremap cleanups v2
by Christoph Hellwig 20 Apr '20

20 Apr '20

Hi Thomas, below is a bunch of cleanups for the MIPS ioremap code. Compile tested only. Changes since v1: - don't remove cpu_has_64bit_gp_regs - add a new prep patch to stop txx9aclc-ac97 from poking into ioremap internals

3 10