April 2020 - Alsa-devel - mailman.alsa-project.org

please point wiki to github
by GitHub issues - opened 28 Apr '20

28 Apr '20

alsa-project/alsa-lib issue #43 was opened from archenemies: Googling "alsa report issue" or "alsa report bug" takes me to the following page: https://www.alsa-project.org/wiki/Bug_Tracking This page should have a link to https://github.com/alsa-project/alsa-lib/issues/ Issue URL : https://github.com/alsa-project/alsa-lib/issues/43 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: [PATCH] [inline assembly] fix pcm_dmix_i386.h assembly chunk interfaces
by Takashi Iwai 27 Apr '20

27 Apr '20

Please don't drop Cc to ML. And about the comments: On Mon, 27 Apr 2020 16:35:32 +0200, FRÉDÉRIC RECOULES wrote: > > I wrongly assumed that the option -mmmx was passed when compiling (re) > mix_areas_16_mmx. > I know how to fix it (inspired of ffmpeg): > - the configure test if mmx is supported by the compiler option and set a > macro HAVE_MMX accordingly (maybe something already exist?). Actually the mmx support isn't about whether the compiler supports it or not. With inline asm, the MMX-enabled code is always included in alsa-lib as well as the code without MMX, then which one to be executed is dynamically switched at runtime by probing the CPU capability. thanks, Takashi > - declare a macro MMX_CLOBBERS(list) that will output the list when HAVE_MMX > is true and nothing otherwise. > I will resubmit a patch soon. > > Regards, > Frédéric Recoules > > ------------------------------------------------------------------------------ > De: "tiwai" <tiwai(a)suse.de> > À: "frederic recoules" <frederic.recoules(a)univ-grenoble-alpes.fr> > Cc: "alsa-devel" <alsa-devel(a)alsa-project.org>, "frederic recoules" > <frederic.recoules(a)orange.fr> > Envoyé: Lundi 27 Avril 2020 15:47:02 > Objet: Re: [PATCH] [inline assembly] fix pcm_dmix_i386.h assembly chunk > interfaces > > On Mon, 27 Apr 2020 09:36:04 +0200, > frederic.recoules(a)univ-grenoble-alpes.fr wrote: > > > > From: Frédéric Recoules <frederic.recoules(a)orange.fr> > > > > Main changes are: > > - move 'size' and 'old_ebx' to the output list since they are clobbered > > - add the "memory" keyword since input pointers are dereferenced > > - add mmx registers in the clobber list and add an initialization for mm1 > > - add ebx in clobbers via a set of macro when GCC is newer than 5.0 > > (it will work for other compilers or non-PIC mode too) > > > > Minor changes are: > > - keep consistent the token numbering in the template > > - remove the manual save/restore ebx when it is in the clobber list > > - allows 'dst_step', 'src_step' and 'sum_step' to be given by immediates > > - allows 'size' to be given by register (e.g. ebp) > > - add "cc" keyword since the eflag register is clobbered > > > > Signed-off-by: Frédéric Recoules <frederic.recoules(a)orange.fr> > > When I apply this and build for i386 with gcc9, I got the following > error: > pcm_dmix_i386.h: In function 'mix_areas_16_mmx': > pcm_dmix_i386.h:180:2: error: unknown register name 'mm1' in 'asm' > 180 | __asm__ __volatile__ ( > | ^~~~~~~ > pcm_dmix_i386.h:180:2: error: unknown register name 'mm0' in 'asm' > In file included from pcm_dmix_i386.c:31, > from pcm_dmix.c:144: > pcm_dmix_i386.h: In function 'remix_areas_16_mmx': > pcm_dmix_i386.h:180:2: error: unknown register name 'mm1' in 'asm' > 180 | __asm__ __volatile__ ( > | ^~~~~~~ > .... > > Could you check those errors? > > thanks, > > Takashi > > > --- > > src/pcm/pcm_dmix_i386.h | 168 ++++++++++++++++++++++------------------ > > 1 file changed, 93 insertions(+), 75 deletions(-) > > > > diff --git a/src/pcm/pcm_dmix_i386.h b/src/pcm/pcm_dmix_i386.h > > index 2778cb1d..af2f4630 100644 > > --- a/src/pcm/pcm_dmix_i386.h > > +++ b/src/pcm/pcm_dmix_i386.h > > @@ -26,6 +26,13 @@ > > * > > */ > > > > +#define COMMA , > > +#if __GNUC__ < 5 && defined(__PIC__) > > +# define GCC_PIC_SWITCH(before,after) before > > +#else > > +# define GCC_PIC_SWITCH(before,after) after > > +#endif > > + > > /* > > * for plain i386 > > */ > > @@ -47,13 +54,14 @@ static void MIX_AREAS_16(unsigned int size, > > __asm__ __volatile__ ( > > "\n" > > > > - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) * > / > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) > > /* > > * initialization, load ESI, EDI, EBX registers > > */ > > - "\tmovl %1, %%edi\n" > > - "\tmovl %2, %%esi\n" > > - "\tmovl %3, %%ebx\n" > > + "\tmovl %2, %%edi\n" > > + "\tmovl %3, %%esi\n" > > + "\tmovl %4, %%ebx\n" > > "\tcmpl $0, %0\n" > > "\tjnz 2f\n" > > "\tjmp 7f\n" > > @@ -64,9 +72,9 @@ static void MIX_AREAS_16(unsigned int size, > > */ > > "\t.p2align 4,,15\n" > > "1:" > > - "\tadd %4, %%edi\n" > > - "\tadd %5, %%esi\n" > > - "\tadd %6, %%ebx\n" > > + "\tadd %5, %%edi\n" > > + "\tadd %6, %%esi\n" > > + "\tadd %7, %%ebx\n" > > > > /* > > * sample = *src; > > @@ -138,15 +146,16 @@ static void MIX_AREAS_16(unsigned int size, > > "\tjnz 4b\n" > > "\tdecl %0\n" > > "\tjnz 1b\n" > > - > > - "7:" > > - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) * > / > > > > - : /* no output regs */ > > - : "m" (size), "m" (dst), "m" (src), > > - "m" (sum), "m" (dst_step), "m" (src_step), > > - "m" (sum_step), "m" (old_ebx) > > - : "esi", "edi", "edx", "ecx", "eax" > > + "7:" > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) > > + > > + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) > > + : "m" (dst), "m" (src), "m" (sum), > > + "im" (dst_step), "im" (src_step), "im" (sum_step) > > + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) > "eax", > > + "memory", "cc" > > ); > > } > > > > @@ -171,22 +180,24 @@ static void MIX_AREAS_16_MMX(unsigned int size, > > __asm__ __volatile__ ( > > "\n" > > > > - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) * > / > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) > > /* > > - * initialization, load ESI, EDI, EBX registers > > + * initialization, load ESI, EDI, EBX registers, clear MM1 > > */ > > - "\tmovl %1, %%edi\n" > > - "\tmovl %2, %%esi\n" > > - "\tmovl %3, %%ebx\n" > > + "\tpxor %%mm1, %%mm1\n" > > + "\tmovl %2, %%edi\n" > > + "\tmovl %3, %%esi\n" > > + "\tmovl %4, %%ebx\n" > > "\tcmpl $0, %0\n" > > "\tjnz 2f\n" > > "\tjmp 5f\n" > > > > "\t.p2align 4,,15\n" > > "1:" > > - "\tadd %4, %%edi\n" > > - "\tadd %5, %%esi\n" > > - "\tadd %6, %%ebx\n" > > + "\tadd %5, %%edi\n" > > + "\tadd %6, %%esi\n" > > + "\tadd %7, %%ebx\n" > > > > "2:" > > /* > > @@ -230,13 +241,14 @@ static void MIX_AREAS_16_MMX(unsigned int size, > > "\tjnz 1b\n" > > "\temms\n" > > "5:" > > - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) * > / > > - > > - : /* no output regs */ > > - : "m" (size), "m" (dst), "m" (src), > > - "m" (sum), "m" (dst_step), "m" (src_step), > > - "m" (sum_step), "m" (old_ebx) > > - : "esi", "edi", "edx", "ecx", "eax" > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) > > + > > + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) > > + : "m" (dst), "m" (src), "m" (sum), > > + "im" (dst_step), "im" (src_step), "im" (sum_step) > > + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) > "eax", > > + "mm0", "mm1", "memory", "cc" > > ); > > } > > > > @@ -261,13 +273,14 @@ static void MIX_AREAS_32(unsigned int size, > > __asm__ __volatile__ ( > > "\n" > > > > - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) * > / > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) > > /* > > * initialization, load ESI, EDI, EBX registers > > */ > > - "\tmovl %1, %%edi\n" > > - "\tmovl %2, %%esi\n" > > - "\tmovl %3, %%ebx\n" > > + "\tmovl %2, %%edi\n" > > + "\tmovl %3, %%esi\n" > > + "\tmovl %4, %%ebx\n" > > "\tcmpl $0, %0\n" > > "\tjnz 1f\n" > > "\tjmp 6f\n" > > @@ -337,19 +350,20 @@ static void MIX_AREAS_32(unsigned int size, > > */ > > "\tdecl %0\n" > > "\tjz 6f\n" > > - "\tadd %4, %%edi\n" > > - "\tadd %5, %%esi\n" > > - "\tadd %6, %%ebx\n" > > + "\tadd %5, %%edi\n" > > + "\tadd %6, %%esi\n" > > + "\tadd %7, %%ebx\n" > > "\tjmp 1b\n" > > - > > - "6:" > > - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) * > / > > > > - : /* no output regs */ > > - : "m" (size), "m" (dst), "m" (src), > > - "m" (sum), "m" (dst_step), "m" (src_step), > > - "m" (sum_step), "m" (old_ebx) > > - : "esi", "edi", "edx", "ecx", "eax" > > + "6:" > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) > > + > > + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) > > + : "m" (dst), "m" (src), "m" (sum), > > + "im" (dst_step), "im" (src_step), "im" (sum_step) > > + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) > "eax", > > + "memory", "cc" > > ); > > } > > > > @@ -374,13 +388,14 @@ static void MIX_AREAS_24(unsigned int size, > > __asm__ __volatile__ ( > > "\n" > > > > - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) * > / > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) > > /* > > * initialization, load ESI, EDI, EBX registers > > */ > > - "\tmovl %1, %%edi\n" > > - "\tmovl %2, %%esi\n" > > - "\tmovl %3, %%ebx\n" > > + "\tmovl %2, %%edi\n" > > + "\tmovl %3, %%esi\n" > > + "\tmovl %4, %%ebx\n" > > "\tcmpl $0, %0\n" > > "\tjnz 1f\n" > > "\tjmp 6f\n" > > @@ -443,19 +458,20 @@ static void MIX_AREAS_24(unsigned int size, > > */ > > "\tdecl %0\n" > > "\tjz 6f\n" > > - "\tadd %4, %%edi\n" > > - "\tadd %5, %%esi\n" > > - "\tadd %6, %%ebx\n" > > + "\tadd %5, %%edi\n" > > + "\tadd %6, %%esi\n" > > + "\tadd %7, %%ebx\n" > > "\tjmp 1b\n" > > - > > - "6:" > > - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) * > / > > > > - : /* no output regs */ > > - : "m" (size), "m" (dst), "m" (src), > > - "m" (sum), "m" (dst_step), "m" (src_step), > > - "m" (sum_step), "m" (old_ebx) > > - : "esi", "edi", "edx", "ecx", "eax" > > + "6:" > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) > > + > > + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) > > + : "m" (dst), "m" (src), "m" (sum), > > + "im" (dst_step), "im" (src_step), "im" (sum_step) > > + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) > "eax", > > + "memory", "cc" > > ); > > } > > > > @@ -480,13 +496,14 @@ static void MIX_AREAS_24_CMOV(unsigned int size, > > __asm__ __volatile__ ( > > "\n" > > > > - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) * > / > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) > > /* > > * initialization, load ESI, EDI, EBX registers > > */ > > - "\tmovl %1, %%edi\n" > > - "\tmovl %2, %%esi\n" > > - "\tmovl %3, %%ebx\n" > > + "\tmovl %2, %%edi\n" > > + "\tmovl %3, %%esi\n" > > + "\tmovl %4, %%ebx\n" > > "\tcmpl $0, %0\n" > > "\tjz 6f\n" > > > > @@ -541,19 +558,20 @@ static void MIX_AREAS_24_CMOV(unsigned int size, > > /* > > * while (size-- > 0) > > */ > > - "\tadd %4, %%edi\n" > > - "\tadd %5, %%esi\n" > > - "\tadd %6, %%ebx\n" > > + "\tadd %5, %%edi\n" > > + "\tadd %6, %%esi\n" > > + "\tadd %7, %%ebx\n" > > "\tdecl %0\n" > > "\tjnz 1b\n" > > - > > - "6:" > > - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) * > / > > > > - : /* no output regs */ > > - : "m" (size), "m" (dst), "m" (src), > > - "m" (sum), "m" (dst_step), "m" (src_step), > > - "m" (sum_step), "m" (old_ebx) > > - : "esi", "edi", "edx", "ecx", "eax" > > + "6:" > > + /* ebx is GOT pointer (-fPIC) */ > > + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) > > + > > + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) > > + : "m" (dst), "m" (src), "m" (sum), > > + "im" (dst_step), "im" (src_step), "im" (sum_step) > > + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) > "eax", > > + "memory", "cc" > > ); > > } > > -- > > 2.17.1 > > > >

2 1

[PATCH 0/3] add channel constraint for BDW machine drivers
by Brent Lu 27 Apr '20

27 Apr '20

The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel recording while other two drivers support only 2-channel recording. HW constraints are implemented to reflect the hardware limitation on BDW platform. Brent Lu (3): ASoC: bdw-rt5677: channel constraint support ASoC: bdw-rt5650: channel constraint support ASoC: broadwell: channel constraint support sound/soc/intel/boards/bdw-rt5650.c | 34 ++++++++++++++++++++++++++++++++++ sound/soc/intel/boards/bdw-rt5677.c | 33 +++++++++++++++++++++++++++++++++ sound/soc/intel/boards/broadwell.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+) -- 2.7.4

3 10

[PATCH v6 0/3] Add support for different DMIC configurations
by Mateusz Gorski 27 Apr '20

27 Apr '20

Set of patches to enable DMIC capture on different hardware configurations. Information about supported DMIC configuration is read from NHLT and correct pipeline configuration is selected automatically. Also, adding additional option for topology binary name which is based on used machine driver. Reviewed-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Mateusz Gorski (3): ASoC: Intel: Skylake: Add alternative topology binary name ASoC: Intel: Multiple I/O PCM format support for pipe ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Changes in v2: - removed patch 1/4 swapping machine device and platform device registration order - alt_tplg_name creation now uses different field to read machine driver name - including of <sound/soc-acpi.h> moved to different patch Changes in v3: - cosmetic changes in skl-topology.c file Changes in v4: - refactored patch 2/3 to use one common helper function to deal with both set and get pipe configuration operations, as suggested by Pierre - adjusted patch 3/3 to also use this helper function for DMIC pipes - added comment in patch 3/3 explaining the change of access rights for DMIC enums Changes in v5: - fixed alignment issue in patch 2/3 - addressed "checkpatch.pl --strict" warnings in patches Changes in v6: - fixed commit message in patch 2/3 include/uapi/sound/skl-tplg-interface.h | 2 + sound/soc/intel/skylake/skl-topology.c | 178 +++++++++++++++++++++++- sound/soc/intel/skylake/skl-topology.h | 1 + 3 files changed, 176 insertions(+), 5 deletions(-) -- 2.17.1

3 5

High-bandwidth/multiple transactions per microframe in usb audio?
by Pavel Hofman 27 Apr '20

27 Apr '20

Hi, Please does the current USB audio driver support multiple transactions per microframe (high-bandwidth mode)? I could not find it in endpoint.c but it may be there or somewhere else :-) Thanks a lot, Pavel.

3 5

[PATCH] [inline assembly] fix pcm_dmix_i386.h assembly chunk interfaces
by frederic.recoules＠univ-grenoble-alpes.fr 27 Apr '20

27 Apr '20

From: Frédéric Recoules <frederic.recoules(a)orange.fr> Main changes are: - move 'size' and 'old_ebx' to the output list since they are clobbered - add the "memory" keyword since input pointers are dereferenced - add mmx registers in the clobber list and add an initialization for mm1 - add ebx in clobbers via a set of macro when GCC is newer than 5.0 (it will work for other compilers or non-PIC mode too) Minor changes are: - keep consistent the token numbering in the template - remove the manual save/restore ebx when it is in the clobber list - allows 'dst_step', 'src_step' and 'sum_step' to be given by immediates - allows 'size' to be given by register (e.g. ebp) - add "cc" keyword since the eflag register is clobbered Signed-off-by: Frédéric Recoules <frederic.recoules(a)orange.fr> --- src/pcm/pcm_dmix_i386.h | 168 ++++++++++++++++++++++------------------ 1 file changed, 93 insertions(+), 75 deletions(-) diff --git a/src/pcm/pcm_dmix_i386.h b/src/pcm/pcm_dmix_i386.h index 2778cb1d..af2f4630 100644 --- a/src/pcm/pcm_dmix_i386.h +++ b/src/pcm/pcm_dmix_i386.h @@ -26,6 +26,13 @@ * */ +#define COMMA , +#if __GNUC__ < 5 && defined(__PIC__) +# define GCC_PIC_SWITCH(before,after) before +#else +# define GCC_PIC_SWITCH(before,after) after +#endif + /* * for plain i386 */ @@ -47,13 +54,14 @@ static void MIX_AREAS_16(unsigned int size, __asm__ __volatile__ ( "\n" - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) */ + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) /* * initialization, load ESI, EDI, EBX registers */ - "\tmovl %1, %%edi\n" - "\tmovl %2, %%esi\n" - "\tmovl %3, %%ebx\n" + "\tmovl %2, %%edi\n" + "\tmovl %3, %%esi\n" + "\tmovl %4, %%ebx\n" "\tcmpl $0, %0\n" "\tjnz 2f\n" "\tjmp 7f\n" @@ -64,9 +72,9 @@ static void MIX_AREAS_16(unsigned int size, */ "\t.p2align 4,,15\n" "1:" - "\tadd %4, %%edi\n" - "\tadd %5, %%esi\n" - "\tadd %6, %%ebx\n" + "\tadd %5, %%edi\n" + "\tadd %6, %%esi\n" + "\tadd %7, %%ebx\n" /* * sample = *src; @@ -138,15 +146,16 @@ static void MIX_AREAS_16(unsigned int size, "\tjnz 4b\n" "\tdecl %0\n" "\tjnz 1b\n" - - "7:" - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) */ - : /* no output regs */ - : "m" (size), "m" (dst), "m" (src), - "m" (sum), "m" (dst_step), "m" (src_step), - "m" (sum_step), "m" (old_ebx) - : "esi", "edi", "edx", "ecx", "eax" + "7:" + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) + + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) + : "m" (dst), "m" (src), "m" (sum), + "im" (dst_step), "im" (src_step), "im" (sum_step) + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) "eax", + "memory", "cc" ); } @@ -171,22 +180,24 @@ static void MIX_AREAS_16_MMX(unsigned int size, __asm__ __volatile__ ( "\n" - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) */ + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) /* - * initialization, load ESI, EDI, EBX registers + * initialization, load ESI, EDI, EBX registers, clear MM1 */ - "\tmovl %1, %%edi\n" - "\tmovl %2, %%esi\n" - "\tmovl %3, %%ebx\n" + "\tpxor %%mm1, %%mm1\n" + "\tmovl %2, %%edi\n" + "\tmovl %3, %%esi\n" + "\tmovl %4, %%ebx\n" "\tcmpl $0, %0\n" "\tjnz 2f\n" "\tjmp 5f\n" "\t.p2align 4,,15\n" "1:" - "\tadd %4, %%edi\n" - "\tadd %5, %%esi\n" - "\tadd %6, %%ebx\n" + "\tadd %5, %%edi\n" + "\tadd %6, %%esi\n" + "\tadd %7, %%ebx\n" "2:" /* @@ -230,13 +241,14 @@ static void MIX_AREAS_16_MMX(unsigned int size, "\tjnz 1b\n" "\temms\n" "5:" - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) */ - - : /* no output regs */ - : "m" (size), "m" (dst), "m" (src), - "m" (sum), "m" (dst_step), "m" (src_step), - "m" (sum_step), "m" (old_ebx) - : "esi", "edi", "edx", "ecx", "eax" + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) + + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) + : "m" (dst), "m" (src), "m" (sum), + "im" (dst_step), "im" (src_step), "im" (sum_step) + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) "eax", + "mm0", "mm1", "memory", "cc" ); } @@ -261,13 +273,14 @@ static void MIX_AREAS_32(unsigned int size, __asm__ __volatile__ ( "\n" - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) */ + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) /* * initialization, load ESI, EDI, EBX registers */ - "\tmovl %1, %%edi\n" - "\tmovl %2, %%esi\n" - "\tmovl %3, %%ebx\n" + "\tmovl %2, %%edi\n" + "\tmovl %3, %%esi\n" + "\tmovl %4, %%ebx\n" "\tcmpl $0, %0\n" "\tjnz 1f\n" "\tjmp 6f\n" @@ -337,19 +350,20 @@ static void MIX_AREAS_32(unsigned int size, */ "\tdecl %0\n" "\tjz 6f\n" - "\tadd %4, %%edi\n" - "\tadd %5, %%esi\n" - "\tadd %6, %%ebx\n" + "\tadd %5, %%edi\n" + "\tadd %6, %%esi\n" + "\tadd %7, %%ebx\n" "\tjmp 1b\n" - - "6:" - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) */ - : /* no output regs */ - : "m" (size), "m" (dst), "m" (src), - "m" (sum), "m" (dst_step), "m" (src_step), - "m" (sum_step), "m" (old_ebx) - : "esi", "edi", "edx", "ecx", "eax" + "6:" + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) + + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) + : "m" (dst), "m" (src), "m" (sum), + "im" (dst_step), "im" (src_step), "im" (sum_step) + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) "eax", + "memory", "cc" ); } @@ -374,13 +388,14 @@ static void MIX_AREAS_24(unsigned int size, __asm__ __volatile__ ( "\n" - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) */ + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) /* * initialization, load ESI, EDI, EBX registers */ - "\tmovl %1, %%edi\n" - "\tmovl %2, %%esi\n" - "\tmovl %3, %%ebx\n" + "\tmovl %2, %%edi\n" + "\tmovl %3, %%esi\n" + "\tmovl %4, %%ebx\n" "\tcmpl $0, %0\n" "\tjnz 1f\n" "\tjmp 6f\n" @@ -443,19 +458,20 @@ static void MIX_AREAS_24(unsigned int size, */ "\tdecl %0\n" "\tjz 6f\n" - "\tadd %4, %%edi\n" - "\tadd %5, %%esi\n" - "\tadd %6, %%ebx\n" + "\tadd %5, %%edi\n" + "\tadd %6, %%esi\n" + "\tadd %7, %%ebx\n" "\tjmp 1b\n" - - "6:" - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) */ - : /* no output regs */ - : "m" (size), "m" (dst), "m" (src), - "m" (sum), "m" (dst_step), "m" (src_step), - "m" (sum_step), "m" (old_ebx) - : "esi", "edi", "edx", "ecx", "eax" + "6:" + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) + + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) + : "m" (dst), "m" (src), "m" (sum), + "im" (dst_step), "im" (src_step), "im" (sum_step) + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) "eax", + "memory", "cc" ); } @@ -480,13 +496,14 @@ static void MIX_AREAS_24_CMOV(unsigned int size, __asm__ __volatile__ ( "\n" - "\tmovl %%ebx, %7\n" /* ebx is GOT pointer (-fPIC) */ + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %%ebx, %1\n",) /* * initialization, load ESI, EDI, EBX registers */ - "\tmovl %1, %%edi\n" - "\tmovl %2, %%esi\n" - "\tmovl %3, %%ebx\n" + "\tmovl %2, %%edi\n" + "\tmovl %3, %%esi\n" + "\tmovl %4, %%ebx\n" "\tcmpl $0, %0\n" "\tjz 6f\n" @@ -541,19 +558,20 @@ static void MIX_AREAS_24_CMOV(unsigned int size, /* * while (size-- > 0) */ - "\tadd %4, %%edi\n" - "\tadd %5, %%esi\n" - "\tadd %6, %%ebx\n" + "\tadd %5, %%edi\n" + "\tadd %6, %%esi\n" + "\tadd %7, %%ebx\n" "\tdecl %0\n" "\tjnz 1b\n" - - "6:" - "\tmovl %7, %%ebx\n" /* ebx is GOT pointer (-fPIC) */ - : /* no output regs */ - : "m" (size), "m" (dst), "m" (src), - "m" (sum), "m" (dst_step), "m" (src_step), - "m" (sum_step), "m" (old_ebx) - : "esi", "edi", "edx", "ecx", "eax" + "6:" + /* ebx is GOT pointer (-fPIC) */ + GCC_PIC_SWITCH("\tmovl %1, %%ebx\n",) + + : "+&rm" (size), GCC_PIC_SWITCH("=m","=X") (old_ebx) + : "m" (dst), "m" (src), "m" (sum), + "im" (dst_step), "im" (src_step), "im" (sum_step) + : "esi", "edi", "edx", "ecx", GCC_PIC_SWITCH(,"ebx"COMMA) "eax", + "memory", "cc" ); } -- 2.17.1

2 1

pcm: Fix memory leak at snd_pcm_new when THREAD_SAVE_API is defined
by GitHub pull_request - opened 27 Apr '20

27 Apr '20

alsa-project/alsa-lib pull request #42 was opened from chunxuxiao: The pthread_mutexattr_t object should be destroyed by calling pthread_mutexattr_destroy(), otherwise it may cause a potential memory leak due to the different implement of pthread_mutexattr_init() Signed-off-by: chunxu.li <chunxuxiao(a)gmail.com> Request URL : https://github.com/alsa-project/alsa-lib/pull/42 Patch URL : https://github.com/alsa-project/alsa-lib/pull/42.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v5 0/3] Add support for different DMIC configurations
by Mateusz Gorski 27 Apr '20

27 Apr '20

Set of patches to enable DMIC capture on different hardware configurations. Information about supported DMIC configuration is read from NHLT and correct pipeline configuration is selected automatically. Also, adding additional option for topology binary name which is based on used machine driver. Changes in v2: - removed patch 1/4 swapping machine device and platform device registration order - alt_tplg_name creation now uses different field to read machine driver name - including of <sound/soc-acpi.h> moved to different patch Changes in v3: - cosmetic changes in skl-topology.c file Changes in v4: - refactored patch 2/3 to use one common helper function to deal with both set and get pipe configuration operations, as suggested by Pierre - adjusted patch 3/3 to also use this helper function for DMIC pipes - added comment in patch 3/3 explaining the change of access rights for DMIC enums Changes in v5: - fixed alignment issue in patch 2/3 - addressed "checkpatch.pl --strict" warnings in patches Reviewed-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Mateusz Gorski (3): ASoC: Intel: Skylake: Add alternative topology binary name ASoC: Intel: Multiple I/O PCM format support for pipe ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT include/uapi/sound/skl-tplg-interface.h | 2 + sound/soc/intel/skylake/skl-topology.c | 178 +++++++++++++++++++++++- sound/soc/intel/skylake/skl-topology.h | 1 + 3 files changed, 176 insertions(+), 5 deletions(-) -- 2.17.1

3 5

[PATCH] ASoC: hisilicon: Use IS_ERR() instead of IS_ERR_OR_NULL()
by Tang Bin 27 Apr '20

27 Apr '20

In the function hi6210_i2s_probe(), devm_clk_get() doesn't return NULL. Thus use IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). Signed-off-by: Zhang Shengju <zhangshengju(a)cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin(a)cmss.chinamobile.com> --- sound/soc/hisilicon/hi6210-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/hisilicon/hi6210-i2s.c b/sound/soc/hisilicon/hi6210-i2s.c index ab3b76d29..f14ce0253 100644 --- a/sound/soc/hisilicon/hi6210-i2s.c +++ b/sound/soc/hisilicon/hi6210-i2s.c @@ -570,12 +570,12 @@ static int hi6210_i2s_probe(struct platform_device *pdev) return PTR_ERR(i2s->sysctrl); i2s->clk[CLK_DACODEC] = devm_clk_get(&pdev->dev, "dacodec"); - if (IS_ERR_OR_NULL(i2s->clk[CLK_DACODEC])) + if (IS_ERR(i2s->clk[CLK_DACODEC])) return PTR_ERR(i2s->clk[CLK_DACODEC]); i2s->clocks++; i2s->clk[CLK_I2S_BASE] = devm_clk_get(&pdev->dev, "i2s-base"); - if (IS_ERR_OR_NULL(i2s->clk[CLK_I2S_BASE])) + if (IS_ERR(i2s->clk[CLK_I2S_BASE])) return PTR_ERR(i2s->clk[CLK_I2S_BASE]); i2s->clocks++; -- 2.20.1.windows.1

2 1

[PATCH] ASoC: Intel: sof_sdw: add amp number in components string for ucm
by Bard Liao 27 Apr '20

27 Apr '20

From: randerwang <rander.wang(a)linux.intel.com> The number of speaker amplifiers may vary between platforms. UCM needs to check amp number to include different configuration files. This patch keeps track of the number of speaker amplifiers and stores it in components string of the card. Tested on Comet Lake platforms. Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: randerwang <rander.wang(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/intel/boards/sof_sdw.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c index a64dc563b47e..c94e71563891 100644 --- a/sound/soc/intel/boards/sof_sdw.c +++ b/sound/soc/intel/boards/sof_sdw.c @@ -898,6 +898,7 @@ static int mc_probe(struct platform_device *pdev) struct snd_soc_card *card = &card_sof_sdw; struct snd_soc_acpi_mach *mach; struct mc_private *ctx; + int amp_num = 0, i; int ret; dev_dbg(&pdev->dev, "Entry %s\n", __func__); @@ -924,9 +925,18 @@ static int mc_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, ctx); + /* + * the default amp_num is zero for each codec and + * amp_num will only be increased for active amp + * codecs on used platform + */ + for (i = 0; i < ARRAY_SIZE(codec_info_list); i++) + amp_num += codec_info_list[i].amp_num; + card->components = devm_kasprintf(card->dev, GFP_KERNEL, - "cfg-spk:%d", - (sof_sdw_quirk & SOF_SDW_FOUR_SPK) ? 4 : 2); + "cfg-spk:%d, cfg-amp:%d", + (sof_sdw_quirk & SOF_SDW_FOUR_SPK) + ? 4 : 2, amp_num); if (!card->components) return -ENOMEM; -- 2.17.1

2 1