February 2020 - Alsa-devel - mailman.alsa-project.org

[asoc:for-5.7 21/76] wcd9335.c:undefined reference to `slim_stream_prepare'
by kbuild test robot 18 Feb '20

18 Feb '20

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7 head: 3cd23f021e2e5f3350125abcb39f12430df87d06 commit: ea00d95200d02ece71f5814d41b14f2eb16d598b [21/76] ASoC: Use imply for SND_SOC_ALL_CODECS config: x86_64-randconfig-s2-20200217 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: git checkout ea00d95200d02ece71f5814d41b14f2eb16d598b # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): ld: sound/soc/codecs/ab8500-codec.o: in function `ab8500_codec_read_reg': ab8500-codec.c:(.text+0x479): undefined reference to `abx500_get_register_interruptible' ld: sound/soc/codecs/ab8500-codec.o: in function `ab8500_codec_probe': ab8500-codec.c:(.text+0xdf1): undefined reference to `abx500_get_register_interruptible' ld: ab8500-codec.c:(.text+0xe18): undefined reference to `abx500_set_register_interruptible' ld: sound/soc/codecs/ab8500-codec.o: in function `ab8500_codec_write_reg': ab8500-codec.c:(.text+0x4b1): undefined reference to `abx500_set_register_interruptible' ld: sound/soc/codecs/mc13783.o: in function `mc13783_probe': mc13783.c:(.text+0x24c): undefined reference to `mc13xxx_reg_write' ld: mc13783.c:(.text+0x25e): undefined reference to `mc13xxx_reg_write' ld: mc13783.c:(.text+0x270): undefined reference to `mc13xxx_reg_write' ld: mc13783.c:(.text+0x282): undefined reference to `mc13xxx_reg_write' ld: mc13783.c:(.text+0x294): undefined reference to `mc13xxx_reg_write' ld: sound/soc/codecs/mc13783.o:mc13783.c:(.text+0x2a6): more undefined references to `mc13xxx_reg_write' follow ld: sound/soc/codecs/mc13783.o: in function `mc13783_probe': mc13783.c:(.text+0x2c5): undefined reference to `mc13xxx_reg_rmw' ld: mc13783.c:(.text+0x2e4): undefined reference to `mc13xxx_reg_rmw' ld: sound/soc/codecs/mc13783.o: in function `mc13783_remove': mc13783.c:(.text+0x212): undefined reference to `mc13xxx_reg_rmw' ld: sound/soc/codecs/wcd9335.o: in function `wcd9335_trigger': >> wcd9335.c:(.text+0x323): undefined reference to `slim_stream_prepare' >> ld: wcd9335.c:(.text+0x32f): undefined reference to `slim_stream_enable' >> ld: wcd9335.c:(.text+0x345): undefined reference to `slim_stream_unprepare' >> ld: wcd9335.c:(.text+0x351): undefined reference to `slim_stream_disable' ld: sound/soc/codecs/wcd9335.o: in function `wcd9335_slim_status': >> wcd9335.c:(.text+0x1970): undefined reference to `of_slim_get_device' >> ld: wcd9335.c:(.text+0x1995): undefined reference to `slim_get_logical_addr' >> ld: wcd9335.c:(.text+0x19b2): undefined reference to `__regmap_init_slimbus' ld: wcd9335.c:(.text+0x19f3): undefined reference to `__regmap_init_slimbus' ld: sound/soc/codecs/wcd9335.o: in function `wcd9335_hw_params': >> wcd9335.c:(.text+0x348f): undefined reference to `slim_stream_allocate' ld: sound/soc/codecs/wcd9335.o: in function `wcd9335_slim_driver_init': >> wcd9335.c:(.init.text+0x3c): undefined reference to `__slim_driver_register' ld: sound/soc/codecs/wcd9335.o: in function `wcd9335_slim_driver_exit': >> wcd9335.c:(.exit.text+0x8): undefined reference to `slim_driver_unregister' ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_trigger': >> wcd934x.c:(.text+0x30d): undefined reference to `slim_stream_prepare' >> ld: wcd934x.c:(.text+0x319): undefined reference to `slim_stream_enable' >> ld: wcd934x.c:(.text+0x32f): undefined reference to `slim_stream_unprepare' >> ld: wcd934x.c:(.text+0x33b): undefined reference to `slim_stream_disable' ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_hw_params': >> wcd934x.c:(.text+0x2620): undefined reference to `slim_stream_allocate' ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_codec_probe': >> wcd934x.c:(.text+0x27ee): undefined reference to `of_slim_get_device' >> ld: wcd934x.c:(.text+0x2818): undefined reference to `slim_get_logical_addr' >> ld: wcd934x.c:(.text+0x2836): undefined reference to `__regmap_init_slimbus' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

3 2

[alsa-devel] [PATCH v4 00/18] ASoC: soc-pcm cleanup step3
by Kuninori Morimoto 18 Feb '20

18 Feb '20

Hi Mark These are v4 of soc-pcm cleanup step3. Main change from v3 is that - tidyup Subject on [10/18] patch - added Takashi's Reviewed-by / Acked-by on [10/18], [18/18] Kuninori Morimoto (18): 1) ASoC: soc-pcm: move dai_get_widget() 2) ASoC: soc-pcm: use dai_get_widget() at dpcm_get_be() 3) ASoC: soc-pcm: use dai_get_widget() at dpcm_end_walk_at_be() 4) ASoC: soc-pcm: use dpcm_get_be() at dpcm_end_walk_at_be() 5) ASoC: soc-pcm: remove soc_dpcm_be_digital_mute() 6) ASoC: soc-pcm: remove snd_soc_dpcm_be_get/set_state() 7) ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code 8) ASoC: soc-pcm: use goto and remove multi return 9) ASoC: soc-pcm: merge playback/cature_active into stream_active 10) ASoC: soc.h: add for_each_pcm_streams() 11) ASoC: soc-core: use for_each_pcm_streams() macro 12) ASoC: soc-pcm: use for_each_pcm_streams() macro 13) ASoC: soc-generic-dmaengine-pcm: use for_each_pcm_streams() macro 14) ASoC: dwc: dwc-i2s: use for_each_pcm_streams() macro 15) ASoC: fsl: fsl_asrc_dma: use for_each_pcm_streams() macro 16) ASoC: qcom: lpass-platform: use for_each_pcm_streams() macro 17) ASoC: sof: sof-audio: use for_each_pcm_streams() macro 18) ALSA: usx2y: use for_each_pcm_streams() macro include/sound/pcm.h | 5 + include/sound/soc-dai.h | 3 +- include/sound/soc-dpcm.h | 9 - sound/soc/codecs/cs4271.c | 4 +- sound/soc/dwc/dwc-i2s.c | 8 +- sound/soc/fsl/fsl_asrc_dma.c | 4 +- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/soc-core.c | 48 ++-- sound/soc/soc-generic-dmaengine-pcm.c | 8 +- sound/soc/soc-pcm.c | 327 +++++++++----------------- sound/soc/sof/sof-audio.c | 19 +- sound/usb/usx2y/usbusx2yaudio.c | 9 +- 12 files changed, 162 insertions(+), 284 deletions(-) -- 2.17.1

2 19

[alsa-devel] [PATCH v4 00/11] ASoC: SOF: Data probing
by Cezary Rojewski 18 Feb '20

18 Feb '20

This set of patches achieves few goals in order to enable data probing feature for audio DSP. First, provide new and alter existing interfaces (page allocation, runtime flow adjustments) to make them compress friendly. For HDA part, work has been done to account for compress streams when servicing IRQs, setting up BDLs and assigning DMAs. Finally, the end goal which are the probe APIs and usage itself. Probes can be treated as endpoints which allow for data extraction from or injection to target module - a great ally when debugging problematic audio issues such as distortions, glitches or gaps. Compress streams are a weapon of choice here to provide a lightweight implementation. While all available IPCs have been defined, current implementation covers extraction only, with injection scheduled for a later date. Initial review and development of probes can be found under: https://github.com/thesofproject/linux/pull/1276 with the hda-compress-enable set of patches being separated and reviewed on: https://github.com/thesofproject/linux/pull/1571 Tested on CML-U with rt5682 i2s board. Changes in v4: - No changes to ALSA core and hda patches - 'probe' source added in patch "ASoC: SOF: Implement Probe IPC API" now only compiled if SND_SOC_SOF_DEBUG_PROBES is enabled. Said kconfig initial declaration has been moved to that patch too - 'extractor_stream_tag' field now decorated with _DEBUG_PROBES to account for the change above - Debugfs probe handlers now check if extractor stream is running before continuing. To achieve this, 'extractor_stream_tag' is both initialized and set to SOF_PROBE_INVALID_NODE_ID on sof_probe_compr_free(). Suggestion provided by Pierre - Reverted SND_SOC_SOF_HDA_LINK requirement-removal change for HDA probes. Code requires SND_HDA_EXT_CORE in order to function on Intel platforms - Relocated probe-compress related code from /sof/pcm.c directly to /sof/compress.c as requested by Daniel Changes in v3: - No changes to ALSA core and hda patches - Addressed sparse and all doc related warnings as reported by Pierre - Moved _DEBUG_PROBES config outside of _DEVELOPER_SUPPORT block - Renamed 'extractor' field to 'extractor_stream_tag' as requested - Relocated 'extractor_stream_tag' declaration from patch 07 to 08 Changes in v2: - No changes to ALSA core and hda patches - Removed "ASoC: Intel: sof_rt5682: Add compress probe DAI links" from the patchset list as requested by Pierre - updated copyright header for newly added files (dates) - probes over HDA no longer require SND_SOC_SOF_HDA_LINK enabled - renamed debugfs probe functions as requested by Pierre - probe IPC API has been updated to align with newest SOF FW & probe debug app (struct_size macro has been enlisted to make the size calculations transparent). This targets only "ASoC: SOF: Implement Probe IPC API" patch Cezary Rojewski (11): ALSA: hda: Allow for compress stream to hdac_ext_stream assignment ALSA: hda: Prepare for compress stream support ALSA: hda: Interrupt servicing and BDL setup for compress streams ALSA: core: Expand DMA buffer information ALSA: core: Implement compress page allocation and free routines ASoC: SOF: Intel: Account for compress streams when servicing IRQs ASoC: SOF: Implement Probe IPC API ASoC: SOF: Generic probe compress operations ASoC: SOF: Intel: Probe compress operations ASoC: SOF: Provide probe debugfs support ASoC: SOF: Intel: Add Probe compress CPU DAIs include/sound/compress_driver.h | 40 +++- include/sound/hdaudio.h | 2 + include/sound/hdaudio_ext.h | 2 + include/sound/sof/header.h | 11 ++ sound/core/compress_offload.c | 42 +++++ sound/hda/ext/hdac_ext_stream.c | 49 ++++- sound/hda/hdac_controller.c | 4 +- sound/hda/hdac_stream.c | 52 ++++-- sound/soc/sof/Kconfig | 9 + sound/soc/sof/Makefile | 1 + sound/soc/sof/compress.c | 146 +++++++++++++++ sound/soc/sof/compress.h | 31 ++++ sound/soc/sof/core.c | 6 + sound/soc/sof/debug.c | 226 +++++++++++++++++++++++ sound/soc/sof/intel/Kconfig | 10 + sound/soc/sof/intel/Makefile | 1 + sound/soc/sof/intel/apl.c | 9 + sound/soc/sof/intel/cnl.c | 9 + sound/soc/sof/intel/hda-compress.c | 132 +++++++++++++ sound/soc/sof/intel/hda-dai.c | 28 +++ sound/soc/sof/intel/hda-ipc.c | 4 +- sound/soc/sof/intel/hda-stream.c | 26 ++- sound/soc/sof/intel/hda.h | 30 +++ sound/soc/sof/ops.h | 43 +++++ sound/soc/sof/pcm.c | 7 + sound/soc/sof/probe.c | 286 +++++++++++++++++++++++++++++ sound/soc/sof/probe.h | 85 +++++++++ sound/soc/sof/sof-priv.h | 25 +++ 28 files changed, 1277 insertions(+), 39 deletions(-) create mode 100644 sound/soc/sof/compress.c create mode 100644 sound/soc/sof/compress.h create mode 100644 sound/soc/sof/intel/hda-compress.c create mode 100644 sound/soc/sof/probe.c create mode 100644 sound/soc/sof/probe.h -- 2.17.1

2 15

Questions about event implementation in ALSA Sequencer
by Takashi Sakamoto 18 Feb '20

18 Feb '20

Hi, I'm working for alsa-gobject[1] so that it supports API for ALSA Sequencer. At present I've mostly done it just with direct dispatch support[2] (thus transmission via queue is for my later work). Then I have some questions about the design of event in ALSA Sequencer. I'd like to ask for some advices (mainly Iwai-san, perhaps). 1. use case of SNDRV_SEQ_EVENT_LENGTH_VARUSR in 'struct snd_seq_event' In my understanding, the flag is used for a case that sender transmits the value of pointer itself and its length to the receiver in the shape of 'struct snd_seq_ev_ext'. I assume that two use cases. If the sender and receiver are in the same process, the event is a request for the receiver to operate data in the same VMA. If the sender and receiver are in different processes, the event is a request for pointer-based calculation between the peer. If the above understanding is correct, it's hard to represent this type of event for g-i interface because g-i is the object-based framework. Any raw pointer without explicit type is hard to be exposed to g-i applications as long as I know, and it's going to be unsupported, perhaps. 2. event data type corresponding to event type Some event types are expected to specific data type; e.g. SNDRV_SEQ_EVENT_NOTE is for 'struct snd_seq_ev_note' and SNDRV_SEQ_EVENT_CONTROLLER is for 'struct snd_seq_ev_ctrl'. However there're some types for any data type; e.g. SNDRV_SEQ_EVENT_ECHO or SNDRV_SEQ_EVENT_USR0. For the kind of types, the event structure has no information about which data type should be used and user applications voluntarily decide the data type. Therefore the sender and receiver should share a kind of protocol in advance. This means that userspace applications require API to select data type independent of event type itself. 3. quote event and specific event types. Two event types are reserved for 'struct snd_seq_ev_quote'; i.e. SNDRV_SEQ_EVENT_KERNEL_ERROR and SNDRV_SEQ_EVENT_KERNEL_QUOTE(obsoleted?). However, the quote structure is exposed to userspace itself. Furthermore, as of v5.5 kernel, there's no in-kernel code to check the quote data from/to user client. Is it better to produce API so that userspace application can transfer the quote event? [1] https://github.com/alsa-project/alsa-gobject [2] https://github.com/takaswie/alsa-gobject/tree/topic/seq Regards Takashi Sakamoto

2 2

Re: linux-next: Tree for Feb 18 (sound/soc/codecs/wm5110.c)
by Randy Dunlap 18 Feb '20

18 Feb '20

On 2/17/20 8:28 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200217: > on x86_64: WARNING: unmet direct dependencies detected for SND_SOC_WM5110 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MFD_WM5110 [=n] Selected by [y]: - SND_SOC_BELLS [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SAMSUNG [=y] && MFD_ARIZONA [=y] && I2C [=y] && SPI_MASTER [=y] && (MACH_WLF_CRAGG_6410 || COMPILE_TEST [=y]) - SND_SOC_SAMSUNG_TM2_WM5110 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SAMSUNG [=y] && MFD_ARIZONA [=y] && I2C [=y] && SPI_MASTER [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y]) Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap <rdunlap(a)infradead.org>

3 4

[GIT PULL] ASoC fixes for v5.6
by Mark Brown 18 Feb '20

18 Feb '20

The following changes since commit 13426feaf46c48fcddb591e89d35120fcc90527f: ASoC: wcd934x: Add missing COMMON_CLK dependency to SND_SOC_ALL_CODECS (2020-02-05 10:05:19 +0000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.6-rc2 for you to fetch changes up to 96781fd941b39e1f78098009344ebcd7af861c67: ASoC: sun8i-codec: Fix setting DAI data format (2020-02-17 21:58:41 +0000) ---------------------------------------------------------------- ASoC: Fixes for v5.6 A few fixes sent in since the merge window, none of them with global impact but all important for the users they affect. ---------------------------------------------------------------- Arnd Bergmann (1): ASoC: atmel: fix atmel_ssc_set_audio link failure Kai Vehmanen (3): ALSA: hda: do not override bus codec_mask in link_get() ASoC: SOF: Intel: hda: fix ordering bug in resume flow ASoC: SOF: Intel: hda: move i915 init earlier Oleksandr Suvorov (1): ASoC: fsl_sai: Fix exiting path on probing failure Ravulapati Vishnu vardhan rao (2): ASoC: amd: Buffer Size instead of MAX Buffer ASoC: amd: ACP needs to be powered off in BIOS. Samuel Holland (2): ASoC: codec2codec: avoid invalid/double-free of pcm runtime ASoC: sun8i-codec: Fix setting DAI data format Tzung-Bi Shih (3): ASoC: max98090: revert invalid fix for handling SHDN ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked ASoC: hdmi-codec: set plugged_cb to NULL when component removing include/sound/soc-dapm.h | 2 - sound/hda/ext/hdac_ext_controller.c | 9 +- sound/soc/amd/raven/acp3x-i2s.c | 8 + sound/soc/amd/raven/acp3x-pcm-dma.c | 7 +- sound/soc/amd/raven/pci-acp3x.c | 23 -- sound/soc/atmel/Kconfig | 4 +- sound/soc/atmel/Makefile | 10 +- sound/soc/codecs/hdmi-codec.c | 10 + sound/soc/codecs/max98090.c | 434 ++++++++++-------------------------- sound/soc/codecs/max98090.h | 3 +- sound/soc/fsl/fsl_sai.c | 22 +- sound/soc/soc-dapm.c | 57 ++--- sound/soc/sof/intel/hda-codec.c | 12 +- sound/soc/sof/intel/hda-dsp.c | 11 + sound/soc/sof/intel/hda.c | 19 +- sound/soc/sunxi/sun8i-codec.c | 3 +- 16 files changed, 219 insertions(+), 415 deletions(-)

2 1

[alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics
by Takashi Iwai 18 Feb '20

18 Feb '20

When the driver is configured with CONFIG_SND_SOC_SOF_HDA, the SOF driver tries to bind with i915 audio component. But there is also a system without Intel graphics. On such a system, snd_hdac_i915_init() returns -ENODEV error and it leads to the whole probe error of SOF driver. For avoiding this spurious probe error, this patch changes snd_hdac_i915_init() to return -ENOENT for non-existing i915 graphics case. Then the caller can check the error code and handle as no fatal error. In SOF side, a few changes have been added to hda_codec_i915_init() and hda_codec_i915_exit() for skipping the i915 init and exit calls on such a system. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- This is an attempt to fix the regression for HP OMEN 17, which showed the probe error as: [ 6.278811] sof-audio-pci 0000:00:1f.3: error: init i915 and HDMI codec failed [ 6.278907] sof-audio-pci 0000:00:1f.3: error: failed to probe DSP -19 Although the i915 binding error is gone by the patch, it still fails to probe: [ 6.298259] sof-audio-pci 0000:00:1f.3: error: no matching ASoC machine driver found - aborting probe [ 6.298299] sof-audio-pci 0000:00:1f.3: error: failed to get machine info -19 [ 6.298668] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -19 I'm submitting this fix as is for now since the i915 error itself gets fixed, and the rest seems to be another unsolved problem. Takashi sound/hda/hdac_i915.c | 4 +++- sound/soc/sof/intel/hda-codec.c | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 3c2db3816029..a451df3efc8a 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -116,6 +116,8 @@ static const struct drm_audio_component_audio_ops i915_init_ops = { * with i915 graphics driver. * * Returns zero for success or a negative error code. + * -ENOENT indicates that i915 graphics doesn't exist. + * -ENODEV means the binding with i915 graphics failed. */ int snd_hdac_i915_init(struct hdac_bus *bus) { @@ -123,7 +125,7 @@ int snd_hdac_i915_init(struct hdac_bus *bus) int err; if (!i915_gfx_present()) - return -ENODEV; + return -ENOENT; init_completion(&bind_complete); diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c index 9106ab8dac6f..7202355a701e 100644 --- a/sound/soc/sof/intel/hda-codec.c +++ b/sound/soc/sof/intel/hda-codec.c @@ -186,6 +186,8 @@ int hda_codec_i915_init(struct snd_sof_dev *sdev) /* i915 exposes a HDA codec for HDMI audio */ ret = snd_hdac_i915_init(bus); + if (ret == -ENOENT) + return 0; /* no i915 graphics present on the system */ if (ret < 0) return ret; @@ -200,6 +202,9 @@ int hda_codec_i915_exit(struct snd_sof_dev *sdev) struct hdac_bus *bus = sof_to_bus(sdev); int ret; + if (!bus->audio_component) /* not bound with i915 */ + return 0; + hda_codec_i915_display_power(sdev, false); ret = snd_hdac_i915_exit(bus); -- 2.16.4

2 8

[PATCH] ALSA: hda: Use scnprintf() for printing texts for sysfs/procfs
by Takashi Iwai 18 Feb '20

18 Feb '20

Some code in HD-audio driver calls snprintf() in a loop and still expects that the return value were actually written size, while snprintf() returns the expected would-be length instead. When the given buffer limit were small, this leads to a buffer overflow. Use scnprintf() for addressing those issues. It returns the actually written size unlike snprintf(). Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/hda/hdmi_chmap.c | 2 +- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/hda_eld.c | 2 +- sound/pci/hda/hda_sysfs.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/hda/hdmi_chmap.c b/sound/hda/hdmi_chmap.c index 5fd6d575e123..aad5c4bf4d34 100644 --- a/sound/hda/hdmi_chmap.c +++ b/sound/hda/hdmi_chmap.c @@ -250,7 +250,7 @@ void snd_hdac_print_channel_allocation(int spk_alloc, char *buf, int buflen) for (i = 0, j = 0; i < ARRAY_SIZE(cea_speaker_allocation_names); i++) { if (spk_alloc & (1 << i)) - j += snprintf(buf + j, buflen - j, " %s", + j += scnprintf(buf + j, buflen - j, " %s", cea_speaker_allocation_names[i]); } buf[j] = '\0'; /* necessary when j == 0 */ diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 5dc42f932739..53e7732ef752 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -4022,7 +4022,7 @@ void snd_print_pcm_bits(int pcm, char *buf, int buflen) for (i = 0, j = 0; i < ARRAY_SIZE(bits); i++) if (pcm & (AC_SUPPCM_BITS_8 << i)) - j += snprintf(buf + j, buflen - j, " %d", bits[i]); + j += scnprintf(buf + j, buflen - j, " %d", bits[i]); buf[j] = '\0'; /* necessary when j == 0 */ } diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c index bb46c89b7f63..136477ed46ae 100644 --- a/sound/pci/hda/hda_eld.c +++ b/sound/pci/hda/hda_eld.c @@ -360,7 +360,7 @@ static void hdmi_print_pcm_rates(int pcm, char *buf, int buflen) for (i = 0, j = 0; i < ARRAY_SIZE(alsa_rates); i++) if (pcm & (1 << i)) - j += snprintf(buf + j, buflen - j, " %d", + j += scnprintf(buf + j, buflen - j, " %d", alsa_rates[i]); buf[j] = '\0'; /* necessary when j == 0 */ diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c index 0607ed5d1959..eb8ec109d7ad 100644 --- a/sound/pci/hda/hda_sysfs.c +++ b/sound/pci/hda/hda_sysfs.c @@ -222,7 +222,7 @@ static ssize_t init_verbs_show(struct device *dev, int i, len = 0; mutex_lock(&codec->user_mutex); snd_array_for_each(&codec->init_verbs, i, v) { - len += snprintf(buf + len, PAGE_SIZE - len, + len += scnprintf(buf + len, PAGE_SIZE - len, "0x%02x 0x%03x 0x%04x\n", v->nid, v->verb, v->param); } @@ -272,7 +272,7 @@ static ssize_t hints_show(struct device *dev, int i, len = 0; mutex_lock(&codec->user_mutex); snd_array_for_each(&codec->hints, i, hint) { - len += snprintf(buf + len, PAGE_SIZE - len, + len += scnprintf(buf + len, PAGE_SIZE - len, "%s = %s\n", hint->key, hint->val); } mutex_unlock(&codec->user_mutex); -- 2.16.4

1 0

[alsa-devel] [PATCH v3 0/5] soundwire: intel: add DAI callbacks
by Pierre-Louis Bossart 18 Feb '20

18 Feb '20

The existing mainline code is missing most of the DAI callbacks needed for a functional implementation, and the existing ones need to be modified to provide the relevant information to ASoC/SOF drivers. As suggested by Vinod, these patches are shared first - with the risk that they are separated from the actual DAI enablement, so reviewers might wonder why they are needed in the first place. For reference, the complete set of 90+ patches required for SoundWire on Intel platforms is available here: https://github.com/thesofproject/linux/pull/1692 Changes since v2: Add missing kfree for stream name (feedback from Vinod) changes since v1: Fix string allocation (only feedback from Vinod) Pierre-Louis Bossart (2): soundwire: intel: rename res field as link_res soundwire: intel: free all resources on hw_free() Rander Wang (3): soundwire: intel: add prepare support in sdw dai driver soundwire: intel: add trigger support in sdw dai driver soundwire: intel: add sdw_stream_setup helper for .startup callback drivers/soundwire/intel.c | 198 ++++++++++++++++++++++++++++++++++---- 1 file changed, 178 insertions(+), 20 deletions(-) -- 2.20.1

3 7

[PATCH] ALSA: hda/realtek - Apply quirk for yet another MSI laptop
by Takashi Iwai 18 Feb '20

18 Feb '20

MSI GP65 laptop with SSID 1462:1293 requires the same quirk as other MSI models. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204159 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 82485e06dde1..477589e7ec1d 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2449,6 +2449,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = { SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS), SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD), SND_PCI_QUIRK(0x1462, 0xda57, "MSI Z270-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS), SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3), -- 2.16.4

1 0