February 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] soundwire: bus: provide correct return value on error
by Pierre-Louis Bossart 26 Feb '20

26 Feb '20

From: Bard Liao <yung-chuan.liao(a)linux.intel.com> It seems to be a typo. It makes more sense to return the return value of sdw_update() instead of the value we want to update. Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- drivers/soundwire/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 13887713f311..b8a7a84aca1c 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1070,7 +1070,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave) if (ret < 0) { dev_err(slave->bus->dev, "SDW_DP0_INTMASK read failed:%d\n", ret); - return val; + return ret; } return 0; -- 2.20.1

2 2

[PATCH v3 0/2] Introduce the TLV320ADCx140 codec family
by Dan Murphy 26 Feb '20

26 Feb '20

Hello Introducing the Texas Instruments TLV320ADCx140 quad channel audio ADC. This device supports 4 analog inputs, 8 digital inputs or a combination of analog and digital microphones. TLV320ADC3140 - http://www.ti.com/lit/gpn/tlv320adc3140 TLV320ADC5140 - http://www.ti.com/lit/gpn/tlv320adc5140 TLV320ADC6140 - http://www.ti.com/lit/gpn/tlv320adc6140 Dan Murphy (2): dt-bindings: sound: Add TLV320ADCx140 dt bindings ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family .../bindings/sound/tlv320adcx140.yaml | 83 ++ sound/soc/codecs/Kconfig | 9 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tlv320adcx140.c | 849 ++++++++++++++++++ sound/soc/codecs/tlv320adcx140.h | 130 +++ 5 files changed, 1073 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tlv320adcx140.yaml create mode 100644 sound/soc/codecs/tlv320adcx140.c create mode 100644 sound/soc/codecs/tlv320adcx140.h -- 2.25.0

3 9

[PATCH v2 0/3] Add new module driver for new ASRC
by Shengjiu Wang 26 Feb '20

26 Feb '20

Add new module driver for new ASRC in i.MX8MN. Shengjiu Wang (3): ASoC: fsl_asrc: Move common definition to fsl_asrc_common ASoC: dt-bindings: fsl_easrc: Add document for EASRC ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers changes in v2 - change i.MX815 to i.MX8MN - Add changes in Kconfig and Makefile .../devicetree/bindings/sound/fsl,easrc.txt | 57 + sound/soc/fsl/Kconfig | 10 + sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_asrc.h | 11 +- sound/soc/fsl/fsl_asrc_common.h | 22 + sound/soc/fsl/fsl_easrc.c | 2265 +++++++++++++++++ sound/soc/fsl/fsl_easrc.h | 668 +++++ sound/soc/fsl/fsl_easrc_dma.c | 440 ++++ 8 files changed, 3465 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.txt create mode 100644 sound/soc/fsl/fsl_asrc_common.h create mode 100644 sound/soc/fsl/fsl_easrc.c create mode 100644 sound/soc/fsl/fsl_easrc.h create mode 100644 sound/soc/fsl/fsl_easrc_dma.c -- 2.21.0

3 5

[PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai
by jack.yu＠realtek.com 26 Feb '20

26 Feb '20

From: Jack Yu <jack.yu(a)realtek.com> 1. Add "static" for rt1015_aif_dai_ops. 2. Add "static" for rt1015_dai[]. 3. Add operation callback for rt1015_dai[]. Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt1015.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c index d300b417dd50..bb310bc7febd 100644 --- a/sound/soc/codecs/rt1015.c +++ b/sound/soc/codecs/rt1015.c @@ -664,7 +664,7 @@ static int rt1015_hw_params(struct snd_pcm_substream *substream, snd_soc_component_update_bits(component, RT1015_TDM_MASTER, RT1015_I2S_DL_MASK, val_len); snd_soc_component_update_bits(component, RT1015_CLK2, - RT1015_FS_PD_MASK, pre_div); + RT1015_FS_PD_MASK, pre_div << RT1015_FS_PD_SFT); return 0; } @@ -841,12 +841,12 @@ static void rt1015_remove(struct snd_soc_component *component) #define RT1015_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \ SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S8) -struct snd_soc_dai_ops rt1015_aif_dai_ops = { +static struct snd_soc_dai_ops rt1015_aif_dai_ops = { .hw_params = rt1015_hw_params, .set_fmt = rt1015_set_dai_fmt, }; -struct snd_soc_dai_driver rt1015_dai[] = { +static struct snd_soc_dai_driver rt1015_dai[] = { { .name = "rt1015-aif", .id = 0, @@ -857,6 +857,7 @@ struct snd_soc_dai_driver rt1015_dai[] = { .rates = RT1015_STEREO_RATES, .formats = RT1015_FORMATS, }, + .ops = &rt1015_aif_dai_ops, } }; -- 2.25.1

2 1

[alsa-devel] Question about the various mixer options in UCM
by Tanu Kaskinen 26 Feb '20

26 Feb '20

What's the difference between PlaybackVolume, PlaybackMixerElem and PlaybackMasterElem? Other than the obvious difference that PlaybackVolume is used only to configure the volume control, whereas PlaybackMixerElem and PlaybackMasterElem are used also to configure the mute control. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk

2 8

Re: [PATCH 0/1] Fix silent output on Gigabyte X570 Aorus Master
by Chris 26 Feb '20

26 Feb '20

Hello, on Sunday, Feb 23, I sent a patch (Fix silent output on Gigabyte X570 Aorus Master) for a sound-problem my motherboard has and made the mistake of not registering to alsa-devel beforehand. As a result, my mails are pending for approval in mailman and wont show up in the mailinglist. I did the registration now. Can someone please approve my previous mails or should I just resend my patches? I am really sorry for the mishap - it wont happen again. Greetings, Chris On Sun, Feb 23, 2020 at 10:27 AM Christian Lachner <gladiac(a)gmail.com> wrote: > > The Gigabyte X570 Aorus Master motherboard with ALC1220 codec > requires a similar workaround for Clevo laptops to enforce the > DAC/mixer connection path. This patch sets up a quirk entry for > that. It was tested by myself on my own hardware for some time > and it works just fine. We should probably rename > ALC1220_FIXUP_CLEVO_P950 at some point as the amount of > non-Clevo hardware needing this workaround is growing. > > Christian Lachner (1): > ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master > > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > -- > 2.25.1 >

1 0

Most speakers don't work
by GitHub issues - opened 26 Feb '20

26 Feb '20

alsa-project/alsa-lib issue #28 was opened from JonathanReeve: I have a Lenovo Yoga C-930, which has a Dolby sound bar, and it seems that only one or two out of six speakers work. Is there a way I can make this work? Here's my alsa-info: http://alsa-project.org/db/?f=87931920f5a8cbfcaa9a2490b88d8c1ed6337e9f Issue URL : https://github.com/alsa-project/alsa-lib/issues/28 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] Add headset Mic no shutup for ALC283
by Kailang 26 Feb '20

26 Feb '20

Hi Takashi, ChromeBox machine had humming noise from external skeaker plugin at codec D3 state. BR, Kailang

3 2

Re: [PATCH v2 3/3] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers
by S.j. Wang 26 Feb '20

26 Feb '20

Hi > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> > > --- > > sound/soc/fsl/Kconfig | 10 + > > sound/soc/fsl/Makefile | 2 + > > sound/soc/fsl/fsl_asrc_common.h | 1 + > > sound/soc/fsl/fsl_easrc.c | 2265 +++++++++++++++++++++++++++++++ > > sound/soc/fsl/fsl_easrc.h | 668 +++++++++ > > sound/soc/fsl/fsl_easrc_dma.c | 440 ++++++ > > I see a 90% similarity between fsl_asrc_dma and fsl_easrc_dma files. > Would it be possible reuse the existing code? Could share structures from > my point of view, just like it reuses "enum asrc_pair_index", I know > differentiating "pair" and "context" is a big point here though. > > A possible quick solution for that, off the top of my head, could be: > > 1) in fsl_asrc_common.h > > struct fsl_asrc { > .... > }; > > struct fsl_asrc_pair { > .... > }; > > 2) in fsl_easrc.h > > /* Renaming shared structures */ > #define fsl_easrc fsl_asrc > #define fsl_easrc_context fsl_asrc_pair > > May be a good idea to see if others have some opinion too. > We need to modify the fsl_asrc and fsl_asrc_pair, let them To be used by both driver, also we need to put the specific Definition for each module to same struct, right? > > > +static const struct regmap_config fsl_easrc_regmap_config = { > > + .readable_reg = fsl_easrc_readable_reg, > > + .volatile_reg = fsl_easrc_volatile_reg, > > + .writeable_reg = fsl_easrc_writeable_reg, > > Can we use regmap_range and regmap_access_table? > Can the regmap_range support discontinuous registers? The reg_stride = 4. Best regards Wang shengjiu

3 3

[alsa-devel] motu microbook iic
by thomas rost 26 Feb '20

26 Feb '20

Hello, can anybody help me get the 'class compliant' motu microbook iic to run? this is my alsa-info.sh output: http://alsa-project.org/db/?f=0fd9a8df7bae3400d83b6af8b75c45aa0760d84d thanks in advance. thomas

2 1