December 2020 - Alsa-devel - mailman.alsa-project.org

Steinberg UR22 Crackling and Clicks
by meschi＠posteo.de 09 Dec '20

09 Dec '20

Hi, I am using a Steinberg UR22 audio interface. Since installing Ubuntu 20.04 on my workstation I have slight crackling in audio playback. It doesn't matter if the audio gets routed through pulse, jack or played straight to alsa. When running jack, the crackling is not showing any xruns. It's not possible to get any glitch-free playback in the system. The onboard intel audio works fine. My system: alsa info: alsa-project.org/db/?f=8b821b17a8c83fa5db866f34a5b4dfe74d640a32 Processor: Intel Xeon X5687 $ uname -a Linux WorkStation-T5500 5.4.0-56-lowlatency #62-Ubuntu SMP PREEMPT Mon Nov 23 20:19:44 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux I have tried: 5.4.0-56-generic and -lowlatency 5.8.0-31-generic and -lowlatency setting cpu governor to performance using nouveau driver over nvidia When playing a file with aplay like this: systemctl --user stop pulseaudio.socket systemctl --user stop pulseaudio.service aplay -D plughw:CARD=UR22 ./test.wav slight crackling can be heard every 5-10 seconds. It also appears, that the clicks heard are not always on both channels, sometimes the left stereo channel clicks, sometimes the right, sometimes both. Plugging the Interface into different USB-ports doesn't help. The only external devices connected via USB are my mouse and my keyboard. On Wndows the same setup on the same machine works fine. To make things even weirder, using the same audio interface on my Thinkpad x220 (Core i5-2540M) with ubuntu 20.04 and 5.4.0.56-lowlatency does not show this problem. Running dmesg seems to show nothing audio driver related after: [ 22.425520] usbcore: registered new interface driver snd-usb-audio I have found a similar issue showcasing the problem on manjaro with a differend soundcard. Therefore I suspect the problem is caused by ALSA interacting with the hardware. https://forum.manjaro.org/t/pops-clicks-on-audio-interface/40129 Here is another occurence on ubuntu on yet another audio interface. https://askubuntu.com/questions/1256787/ubuntu-2004-novation-xiosynth-exter… If I can supply more information I'm happy to help. I couldn't find a similar issue in this mailing list, so if this is already fixed I apologize in advance. Kilian

3 15

[PATCH] ASoC: rt1015: check the return value of regmap_read during i2c probe
by derek.fang＠realtek.com 09 Dec '20

09 Dec '20

From: Derek Fang <derek.fang(a)realtek.com> In some projects, the device ID register is not read correctly. This patch helps to verify the issue is caused from i2c host or client. Signed-off-by: Derek Fang <derek.fang(a)realtek.com> diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c index ac4c9f43b338..32e6bcf763d1 100644 --- a/sound/soc/codecs/rt1015.c +++ b/sound/soc/codecs/rt1015.c @@ -1207,8 +1207,13 @@ static int rt1015_i2c_probe(struct i2c_client *i2c, rt1015->hw_config = (i2c->addr == 0x29) ? RT1015_HW_29 : RT1015_HW_28; - regmap_read(rt1015->regmap, RT1015_DEVICE_ID, &val); - if ((val != RT1015_DEVICE_ID_VAL) && (val != RT1015_DEVICE_ID_VAL2)) { + ret = regmap_read(rt1015->regmap, RT1015_DEVICE_ID, &val); + if (ret) { + dev_err(&i2c->dev, + "Failed to read device register: %d\n", ret); + return ret; + } else if ((val != RT1015_DEVICE_ID_VAL) && + (val != RT1015_DEVICE_ID_VAL2)) { dev_err(&i2c->dev, "Device with ID register %x is not rt1015\n", val); return -ENODEV; -- 2.17.1

2 1

[PATCH] ASoC: max98390: Fix error codes in max98390_dsm_init()
by Dan Carpenter 09 Dec '20

09 Dec '20

These error paths return success but they should return -EINVAL. Fixes: 97ed3e509ee6 ("ASoC: max98390: Fix potential crash during param fw loading") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/soc/codecs/max98390.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index ff5cc9bbec29..bb736c44e68a 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -784,6 +784,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) if (fw->size < MAX98390_DSM_PARAM_MIN_SIZE) { dev_err(component->dev, "param fw is invalid.\n"); + ret = -EINVAL; goto err_alloc; } dsm_param = (char *)fw->data; @@ -794,6 +795,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) fw->size < param_size + MAX98390_DSM_PAYLOAD_OFFSET) { dev_err(component->dev, "param fw is invalid.\n"); + ret = -EINVAL; goto err_alloc; } regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x80); -- 2.29.2

2 1

[PATCH v2] ASoC: AMD Raven/Renoir - fix the PCI probe (PCI revision)
by Jaroslav Kysela 09 Dec '20

09 Dec '20

The Raven and Renoir ACP can be distinguished by the PCI revision. Let's do the check very early, otherwise the wrong probe code can be run. Link: https://lore.kernel.org/alsa-devel/2e4587f8-f602-cf23-4845-fd27a32b1cfc@amd… Cc: <stable(a)kernel.org> Cc: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> Cc: Mark Brown <broonie(a)kernel.org> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/soc/amd/raven/pci-acp3x.c | 4 ++++ sound/soc/amd/renoir/rn-pci-acp3x.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c index 31b797c8bfe6..77f2d9389606 100644 --- a/sound/soc/amd/raven/pci-acp3x.c +++ b/sound/soc/amd/raven/pci-acp3x.c @@ -118,6 +118,10 @@ static int snd_acp3x_probe(struct pci_dev *pci, int ret, i; u32 addr, val; + /* Raven device detection */ + if (pci->revision != 0x00) + return -ENODEV; + if (pci_enable_device(pci)) { dev_err(&pci->dev, "pci_enable_device failed\n"); return -ENODEV; diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index 60a3e2f442db..338b78c514ec 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -188,6 +188,10 @@ static int snd_rn_acp_probe(struct pci_dev *pci, int ret, index; u32 addr; + /* Renoir device check */ + if (pci->revision != 0x01) + return -ENODEV; + if (pci_enable_device(pci)) { dev_err(&pci->dev, "pci_enable_device failed\n"); return -ENODEV; -- 2.26.2

2 1

[PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for ARCHOS Cesium 140
by Chris Chiu 09 Dec '20

09 Dec '20

Tha ARCHOS Cesium 140 tablet has problem with the jack-sensing, thus the heaset functions are not working. Add quirk for this model to select the correct input map, jack-detect options and channel map to enable jack sensing and headset microphone. This device uses IN1 for its internal MIC and JD2 for jack-detect. Signed-off-by: Chris Chiu <chiu(a)endlessos.org> --- sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index f790514a147d..cd6f7caa43c8 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -421,6 +421,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ARCHOS"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ARCHOS 140 CESIUM"), + }, + .driver_data = (void *)(BYT_RT5640_IN1_MAP | + BYT_RT5640_JD_SRC_JD2_IN4N | + BYT_RT5640_OVCD_TH_2000UA | + BYT_RT5640_OVCD_SF_0P75 | + BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), -- 2.20.1

3 2

[PATCH 1/5] ASoC: codecs/jz47xx: Use regmap_{set,clear}_bits
by Paul Cercueil 09 Dec '20

09 Dec '20

Use regmap_{set,clear}_bits instead of regmap_update_bits, when applicable. Signed-off-by: Paul Cercueil <paul(a)crapouillou.net> --- sound/soc/codecs/jz4725b.c | 26 ++++++------ sound/soc/codecs/jz4740.c | 20 +++------ sound/soc/codecs/jz4770.c | 85 +++++++++++++++++--------------------- 3 files changed, 55 insertions(+), 76 deletions(-) diff --git a/sound/soc/codecs/jz4725b.c b/sound/soc/codecs/jz4725b.c index e49374c72e70..5201a8f6d7b6 100644 --- a/sound/soc/codecs/jz4725b.c +++ b/sound/soc/codecs/jz4725b.c @@ -198,15 +198,15 @@ static int jz4725b_out_stage_enable(struct snd_soc_dapm_widget *w, switch (event) { case SND_SOC_DAPM_PRE_PMU: - return regmap_update_bits(map, JZ4725B_CODEC_REG_IFR, - BIT(REG_IFR_RAMP_UP_DONE_OFFSET), 0); + return regmap_clear_bits(map, JZ4725B_CODEC_REG_IFR, + BIT(REG_IFR_RAMP_UP_DONE_OFFSET)); case SND_SOC_DAPM_POST_PMU: return regmap_read_poll_timeout(map, JZ4725B_CODEC_REG_IFR, val, val & BIT(REG_IFR_RAMP_UP_DONE_OFFSET), 100000, 500000); case SND_SOC_DAPM_PRE_PMD: - return regmap_update_bits(map, JZ4725B_CODEC_REG_IFR, - BIT(REG_IFR_RAMP_DOWN_DONE_OFFSET), 0); + return regmap_clear_bits(map, JZ4725B_CODEC_REG_IFR, + BIT(REG_IFR_RAMP_DOWN_DONE_OFFSET)); case SND_SOC_DAPM_POST_PMD: return regmap_read_poll_timeout(map, JZ4725B_CODEC_REG_IFR, val, val & BIT(REG_IFR_RAMP_DOWN_DONE_OFFSET), @@ -303,24 +303,22 @@ static int jz4725b_codec_set_bias_level(struct snd_soc_component *component, switch (level) { case SND_SOC_BIAS_ON: - regmap_update_bits(map, JZ4725B_CODEC_REG_PMR2, - BIT(REG_PMR2_SB_SLEEP_OFFSET), 0); + regmap_clear_bits(map, JZ4725B_CODEC_REG_PMR2, + BIT(REG_PMR2_SB_SLEEP_OFFSET)); break; case SND_SOC_BIAS_PREPARE: /* Enable sound hardware */ - regmap_update_bits(map, JZ4725B_CODEC_REG_PMR2, - BIT(REG_PMR2_SB_OFFSET), 0); + regmap_clear_bits(map, JZ4725B_CODEC_REG_PMR2, + BIT(REG_PMR2_SB_OFFSET)); msleep(224); break; case SND_SOC_BIAS_STANDBY: - regmap_update_bits(map, JZ4725B_CODEC_REG_PMR2, - BIT(REG_PMR2_SB_SLEEP_OFFSET), - BIT(REG_PMR2_SB_SLEEP_OFFSET)); + regmap_set_bits(map, JZ4725B_CODEC_REG_PMR2, + BIT(REG_PMR2_SB_SLEEP_OFFSET)); break; case SND_SOC_BIAS_OFF: - regmap_update_bits(map, JZ4725B_CODEC_REG_PMR2, - BIT(REG_PMR2_SB_OFFSET), - BIT(REG_PMR2_SB_OFFSET)); + regmap_set_bits(map, JZ4725B_CODEC_REG_PMR2, + BIT(REG_PMR2_SB_OFFSET)); break; } diff --git a/sound/soc/codecs/jz4740.c b/sound/soc/codecs/jz4740.c index c9900d1cd5c2..5e58bfee2b49 100644 --- a/sound/soc/codecs/jz4740.c +++ b/sound/soc/codecs/jz4740.c @@ -219,12 +219,11 @@ static struct snd_soc_dai_driver jz4740_codec_dai = { static void jz4740_codec_wakeup(struct regmap *regmap) { - regmap_update_bits(regmap, JZ4740_REG_CODEC_1, - JZ4740_CODEC_1_RESET, JZ4740_CODEC_1_RESET); + regmap_set_bits(regmap, JZ4740_REG_CODEC_1, JZ4740_CODEC_1_RESET); udelay(2); - regmap_update_bits(regmap, JZ4740_REG_CODEC_1, - JZ4740_CODEC_1_SUSPEND | JZ4740_CODEC_1_RESET, 0); + regmap_clear_bits(regmap, JZ4740_REG_CODEC_1, + JZ4740_CODEC_1_SUSPEND | JZ4740_CODEC_1_RESET); regcache_sync(regmap); } @@ -235,7 +234,6 @@ static int jz4740_codec_set_bias_level(struct snd_soc_component *component, struct jz4740_codec *jz4740_codec = snd_soc_component_get_drvdata(component); struct regmap *regmap = jz4740_codec->regmap; unsigned int mask; - unsigned int value; switch (level) { case SND_SOC_BIAS_ON: @@ -244,9 +242,8 @@ static int jz4740_codec_set_bias_level(struct snd_soc_component *component, mask = JZ4740_CODEC_1_VREF_DISABLE | JZ4740_CODEC_1_VREF_AMP_DISABLE | JZ4740_CODEC_1_HEADPHONE_POWERDOWN_M; - value = 0; - regmap_update_bits(regmap, JZ4740_REG_CODEC_1, mask, value); + regmap_clear_bits(regmap, JZ4740_REG_CODEC_1, mask); break; case SND_SOC_BIAS_STANDBY: /* The only way to clear the suspend flag is to reset the codec */ @@ -256,17 +253,12 @@ static int jz4740_codec_set_bias_level(struct snd_soc_component *component, mask = JZ4740_CODEC_1_VREF_DISABLE | JZ4740_CODEC_1_VREF_AMP_DISABLE | JZ4740_CODEC_1_HEADPHONE_POWERDOWN_M; - value = JZ4740_CODEC_1_VREF_DISABLE | - JZ4740_CODEC_1_VREF_AMP_DISABLE | - JZ4740_CODEC_1_HEADPHONE_POWERDOWN_M; - regmap_update_bits(regmap, JZ4740_REG_CODEC_1, mask, value); + regmap_set_bits(regmap, JZ4740_REG_CODEC_1, mask); break; case SND_SOC_BIAS_OFF: mask = JZ4740_CODEC_1_SUSPEND; - value = JZ4740_CODEC_1_SUSPEND; - - regmap_update_bits(regmap, JZ4740_REG_CODEC_1, mask, value); + regmap_set_bits(regmap, JZ4740_REG_CODEC_1, mask); regcache_mark_dirty(regmap); break; default: diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 298689a07168..c6b2043f31a9 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -190,18 +190,18 @@ static int jz4770_codec_set_bias_level(struct snd_soc_component *codec, switch (level) { case SND_SOC_BIAS_PREPARE: - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC, - REG_CR_VIC_SB, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_VIC, + REG_CR_VIC_SB); msleep(250); - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC, - REG_CR_VIC_SB_SLEEP, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_VIC, + REG_CR_VIC_SB_SLEEP); msleep(400); break; case SND_SOC_BIAS_STANDBY: - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC, - REG_CR_VIC_SB_SLEEP, REG_CR_VIC_SB_SLEEP); - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC, - REG_CR_VIC_SB, REG_CR_VIC_SB); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_VIC, + REG_CR_VIC_SB_SLEEP); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_VIC, + REG_CR_VIC_SB); fallthrough; default: break; @@ -292,8 +292,8 @@ static int jz4770_codec_mute_stream(struct snd_soc_dai *dai, int mute, int direc } /* clear GUP/GDO flag */ - regmap_update_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, - gain_bit, gain_bit); + regmap_set_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, + gain_bit); } return 0; @@ -369,8 +369,8 @@ static int hpout_event(struct snd_soc_dapm_widget *w, switch (event) { case SND_SOC_DAPM_PRE_PMU: /* set cap-less, unmute HP */ - regmap_update_bits(jz_codec->regmap, JZ4770_CODEC_REG_CR_HP, - REG_CR_HP_SB_HPCM | REG_CR_HP_MUTE, 0); + regmap_clear_bits(jz_codec->regmap, JZ4770_CODEC_REG_CR_HP, + REG_CR_HP_SB_HPCM | REG_CR_HP_MUTE); break; case SND_SOC_DAPM_POST_PMU: @@ -385,16 +385,15 @@ static int hpout_event(struct snd_soc_dapm_widget *w, } /* clear RUP flag */ - regmap_update_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, - REG_IFR_RUP, REG_IFR_RUP); + regmap_set_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, + REG_IFR_RUP); break; case SND_SOC_DAPM_POST_PMD: /* set cap-couple, mute HP */ - regmap_update_bits(jz_codec->regmap, JZ4770_CODEC_REG_CR_HP, - REG_CR_HP_SB_HPCM | REG_CR_HP_MUTE, - REG_CR_HP_SB_HPCM | REG_CR_HP_MUTE); + regmap_set_bits(jz_codec->regmap, JZ4770_CODEC_REG_CR_HP, + REG_CR_HP_SB_HPCM | REG_CR_HP_MUTE); err = regmap_read_poll_timeout(jz_codec->regmap, JZ4770_CODEC_REG_IFR, @@ -406,8 +405,8 @@ static int hpout_event(struct snd_soc_dapm_widget *w, } /* clear RDO flag */ - regmap_update_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, - REG_IFR_RDO, REG_IFR_RDO); + regmap_set_bits(jz_codec->regmap, JZ4770_CODEC_REG_IFR, + REG_IFR_RDO); break; } @@ -592,63 +591,53 @@ static void jz4770_codec_codec_init_regs(struct snd_soc_component *codec) regcache_cache_only(regmap, true); /* default HP output to PCM */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_HP, - REG_CR_HP_SEL_MASK, REG_CR_HP_SEL_MASK); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_HP, REG_CR_HP_SEL_MASK); /* default line output to PCM */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_LO, - REG_CR_LO_SEL_MASK, REG_CR_LO_SEL_MASK); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_LO, REG_CR_LO_SEL_MASK); /* Disable stereo mic */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_MIC, - BIT(REG_CR_MIC_STEREO_OFFSET), 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_MIC, + BIT(REG_CR_MIC_STEREO_OFFSET)); /* Set mic 1 as default source for ADC */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_ADC, - REG_CR_ADC_IN_SEL_MASK, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_ADC, + REG_CR_ADC_IN_SEL_MASK); /* ADC/DAC: serial + i2s */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_AICR_ADC, - REG_AICR_ADC_SERIAL | REG_AICR_ADC_I2S, - REG_AICR_ADC_SERIAL | REG_AICR_ADC_I2S); - regmap_update_bits(regmap, JZ4770_CODEC_REG_AICR_DAC, - REG_AICR_DAC_SERIAL | REG_AICR_DAC_I2S, - REG_AICR_DAC_SERIAL | REG_AICR_DAC_I2S); + regmap_set_bits(regmap, JZ4770_CODEC_REG_AICR_ADC, + REG_AICR_ADC_SERIAL | REG_AICR_ADC_I2S); + regmap_set_bits(regmap, JZ4770_CODEC_REG_AICR_DAC, + REG_AICR_DAC_SERIAL | REG_AICR_DAC_I2S); /* The generated IRQ is a high level */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_ICR, - REG_ICR_INT_FORM_MASK, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_ICR, REG_ICR_INT_FORM_MASK); regmap_update_bits(regmap, JZ4770_CODEC_REG_IMR, REG_IMR_ALL_MASK, REG_IMR_JACK_MASK | REG_IMR_RUP_MASK | REG_IMR_RDO_MASK | REG_IMR_GUP_MASK | REG_IMR_GDO_MASK); /* 12M oscillator */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CCR, - REG_CCR_CRYSTAL_MASK, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CCR, REG_CCR_CRYSTAL_MASK); /* 0: 16ohm/220uF, 1: 10kohm/1uF */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_HP, - REG_CR_HP_LOAD, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_HP, REG_CR_HP_LOAD); /* disable automatic gain */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_AGC1, REG_AGC1_EN, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_AGC1, REG_AGC1_EN); /* Disable DAC lrswap */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_DAC, - REG_CR_DAC_LRSWAP, REG_CR_DAC_LRSWAP); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_DAC, REG_CR_DAC_LRSWAP); /* Independent L/R DAC gain control */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_GCR_DACL, - REG_GCR_DACL_RLGOD, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_GCR_DACL, + REG_GCR_DACL_RLGOD); /* Disable ADC lrswap */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_ADC, - REG_CR_ADC_LRSWAP, REG_CR_ADC_LRSWAP); + regmap_set_bits(regmap, JZ4770_CODEC_REG_CR_ADC, REG_CR_ADC_LRSWAP); /* default to cap-less mode(0) */ - regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_HP, - REG_CR_HP_SB_HPCM, 0); + regmap_clear_bits(regmap, JZ4770_CODEC_REG_CR_HP, REG_CR_HP_SB_HPCM); /* Send collected updates. */ regcache_cache_only(regmap, false); -- 2.29.2

2 5

[PATCH] ALSA: hda: Fix regressions on clear and reconfig sysfs
by Takashi Iwai 09 Dec '20

09 Dec '20

It seems that the HD-audio clear and reconfig sysfs don't work any longer after the recent driver core change. There are multiple issues around that: the linked list corruption and the dead device handling. The former issue is fixed by another patch for the driver core itself, while the latter patch needs to be addressed in HD-audio side. This patch corresponds to the latter, it recovers those broken functions by replacing the device detach and attach actions with the standard core API functions, which are almost equivalent with unbind and bind actions. Fixes: 654888327e9f ("driver core: Avoid binding drivers to dead devices") Cc: <stable(a)vger.kernel.org> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209207 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/hda_sysfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 4bb58e8b08a8..687216e74526 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1803,7 +1803,7 @@ int snd_hda_codec_reset(struct hda_codec *codec) return -EBUSY; /* OK, let it free */ - snd_hdac_device_unregister(&codec->core); + device_release_driver(hda_codec_dev(codec)); /* allow device access again */ snd_hda_unlock_devices(bus); diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c index eb8ec109d7ad..d5ffcba794e5 100644 --- a/sound/pci/hda/hda_sysfs.c +++ b/sound/pci/hda/hda_sysfs.c @@ -139,7 +139,7 @@ static int reconfig_codec(struct hda_codec *codec) "The codec is being used, can't reconfigure.\n"); goto error; } - err = snd_hda_codec_configure(codec); + err = device_reprobe(hda_codec_dev(codec)); if (err < 0) goto error; err = snd_card_register(codec->card); -- 2.26.2

1 0

Re: Behringer WING usb audio - cyclic xruns dependent on periods/buffers
by Takashi Iwai 09 Dec '20

09 Dec '20

On Wed, 09 Dec 2020 13:16:23 +0100, Ben Bell wrote: > > [...] > > > and learning abobut it led me to conclude that the Wing needs an entry in > > > the quirks list in set_sync_ep_implicit_fb_quirk to properly enable it: > > > > > > --- sound/usb/pcm.c.orig 2020-11-22 23:36:08.000000000 +0000 > > > +++ sound/usb/pcm.c 2020-12-05 08:40:21.639600074 +0000 > > > @@ -340,6 +345,7 @@ > > > ep = 0x81; > > > ifnum = 3; > > > goto add_sync_ep_from_ifnum; > > > + case USB_ID(0x1397, 0x050b): /* Behringer Wing */ > > > case USB_ID(0x0763, 0x2080): /* M-Audio FastTrack Ultra */ > > > case USB_ID(0x0763, 0x2081): > > > > > > A week's worth of debugging and learning yielded a one line patch ;) > > > > That's a interesting piece of information :) > > > > Could you give lsusb -v output of the device? With the latest patch > > set, the driver can set up the implicit feedback mode automatically in > > certain cases. I'm not sure whether Behringer device follows that > > pattern. If not, we'd need to add the quirk manually. > > I did wonder whether it was possible to automate this, as all I did > was looked out the endpoint with the Implicit Feedback flag set. > Fingers crossed it'll work. > > Output attached. Thanks. Through a quick glance, this would work as is without patching. The implicit fb source EP is found in the next interface with the same altset as the playback sink EP. Let's cross fingers :) Takashi > > bjb > > > > Bus 009 Device 005: ID 1397:050b BEHRINGER International GmbH > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 239 Miscellaneous Device > bDeviceSubClass 2 > bDeviceProtocol 1 Interface Association > bMaxPacketSize0 64 > idVendor 0x1397 BEHRINGER International GmbH > idProduct 0x050b > bcdDevice 1.02 > iManufacturer 1 BEHRINGER > iProduct 3 WING > iSerial 2 WING-PP-09110504 > bNumConfigurations 2 > Configuration Descriptor: > bLength 9 > bDescriptorType 2 > wTotalLength 0x0323 > bNumInterfaces 5 > bConfigurationValue 1 > iConfiguration 0 > bmAttributes 0xc0 > Self Powered > MaxPower 0mA > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 0 > bInterfaceCount 3 > bFunctionClass 1 Audio > bFunctionSubClass 0 > bFunctionProtocol 32 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 1 Control Device > bInterfaceProtocol 32 > iInterface 3 WING > AudioControl Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 2.00 > bCategory 8 > wTotalLength 0x01df > bmControls 0x00 > AudioControl Interface Descriptor: > bLength 8 > bDescriptorType 36 > bDescriptorSubtype 10 (CLOCK_SOURCE) > bClockID 41 > bmAttributes 1 Internal fixed clock > bmControls 0x07 > Clock Frequency Control (read/write) > Clock Validity Control (read-only) > bAssocTerminal 0 > iClockSource 9 WING Internal Clock > AudioControl Interface Descriptor: > bLength 17 > bDescriptorType 36 > bDescriptorSubtype 2 (INPUT_TERMINAL) > bTerminalID 2 > wTerminalType 0x0101 USB Streaming > bAssocTerminal 0 > bCSourceID 41 > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 18 Out 1 > bmControls 0x0000 > iTerminal 6 WING Output > AudioControl Interface Descriptor: > bLength 202 > bDescriptorType 36 > bDescriptorSubtype 6 (FEATURE_UNIT) > bUnitID 10 > bSourceID 2 > bmaControls(0) 0x00000000 > bmaControls(1) 0x00000000 > bmaControls(2) 0x00000000 > bmaControls(3) 0x00000000 > bmaControls(4) 0x00000000 > bmaControls(5) 0x00000000 > bmaControls(6) 0x00000000 > bmaControls(7) 0x00000000 > bmaControls(8) 0x00000000 > bmaControls(9) 0x00000000 > bmaControls(10) 0x00000000 > bmaControls(11) 0x00000000 > bmaControls(12) 0x00000000 > bmaControls(13) 0x00000000 > bmaControls(14) 0x00000000 > bmaControls(15) 0x00000000 > bmaControls(16) 0x00000000 > bmaControls(17) 0x00000000 > bmaControls(18) 0x00000000 > bmaControls(19) 0x00000000 > bmaControls(20) 0x00000000 > bmaControls(21) 0x00000000 > bmaControls(22) 0x00000000 > bmaControls(23) 0x00000000 > bmaControls(24) 0x00000000 > bmaControls(25) 0x00000000 > bmaControls(26) 0x00000000 > bmaControls(27) 0x00000000 > bmaControls(28) 0x00000000 > bmaControls(29) 0x00000000 > bmaControls(30) 0x00000000 > bmaControls(31) 0x00000000 > bmaControls(32) 0x00000000 > bmaControls(33) 0x00000000 > bmaControls(34) 0x00000000 > bmaControls(35) 0x00000000 > bmaControls(36) 0x00000000 > bmaControls(37) 0x00000000 > bmaControls(38) 0x00000000 > bmaControls(39) 0x00000000 > bmaControls(40) 0x00000000 > bmaControls(41) 0x00000000 > bmaControls(42) 0x00000000 > bmaControls(43) 0x00000000 > bmaControls(44) 0x00000000 > bmaControls(45) 0x00000000 > bmaControls(46) 0x00000000 > bmaControls(47) 0x00000000 > bmaControls(48) 0x00000000 > iFeature 0 > AudioControl Interface Descriptor: > bLength 12 > bDescriptorType 36 > bDescriptorSubtype 3 (OUTPUT_TERMINAL) > bTerminalID 20 > wTerminalType 0x0301 Speaker > bAssocTerminal 0 > bSourceID 10 > bCSourceID 41 > bmControls 0x0000 > iTerminal 0 > AudioControl Interface Descriptor: > bLength 17 > bDescriptorType 36 > bDescriptorSubtype 2 (INPUT_TERMINAL) > bTerminalID 1 > wTerminalType 0x0201 Microphone > bAssocTerminal 0 > bCSourceID 41 > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 66 In 1 > bmControls 0x0000 > iTerminal 0 > AudioControl Interface Descriptor: > bLength 202 > bDescriptorType 36 > bDescriptorSubtype 6 (FEATURE_UNIT) > bUnitID 11 > bSourceID 1 > bmaControls(0) 0x00000000 > bmaControls(1) 0x00000000 > bmaControls(2) 0x00000000 > bmaControls(3) 0x00000000 > bmaControls(4) 0x00000000 > bmaControls(5) 0x00000000 > bmaControls(6) 0x00000000 > bmaControls(7) 0x00000000 > bmaControls(8) 0x00000000 > bmaControls(9) 0x00000000 > bmaControls(10) 0x00000000 > bmaControls(11) 0x00000000 > bmaControls(12) 0x00000000 > bmaControls(13) 0x00000000 > bmaControls(14) 0x00000000 > bmaControls(15) 0x00000000 > bmaControls(16) 0x00000000 > bmaControls(17) 0x00000000 > bmaControls(18) 0x00000000 > bmaControls(19) 0x00000000 > bmaControls(20) 0x00000000 > bmaControls(21) 0x00000000 > bmaControls(22) 0x00000000 > bmaControls(23) 0x00000000 > bmaControls(24) 0x00000000 > bmaControls(25) 0x00000000 > bmaControls(26) 0x00000000 > bmaControls(27) 0x00000000 > bmaControls(28) 0x00000000 > bmaControls(29) 0x00000000 > bmaControls(30) 0x00000000 > bmaControls(31) 0x00000000 > bmaControls(32) 0x00000000 > bmaControls(33) 0x00000000 > bmaControls(34) 0x00000000 > bmaControls(35) 0x00000000 > bmaControls(36) 0x00000000 > bmaControls(37) 0x00000000 > bmaControls(38) 0x00000000 > bmaControls(39) 0x00000000 > bmaControls(40) 0x00000000 > bmaControls(41) 0x00000000 > bmaControls(42) 0x00000000 > bmaControls(43) 0x00000000 > bmaControls(44) 0x00000000 > bmaControls(45) 0x00000000 > bmaControls(46) 0x00000000 > bmaControls(47) 0x00000000 > bmaControls(48) 0x00000000 > iFeature 0 > AudioControl Interface Descriptor: > bLength 12 > bDescriptorType 36 > bDescriptorSubtype 3 (OUTPUT_TERMINAL) > bTerminalID 22 > wTerminalType 0x0101 USB Streaming > bAssocTerminal 0 > bSourceID 11 > bCSourceID 41 > bmControls 0x0000 > iTerminal 7 WING Input > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 4 WING Output Terminal > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 1 > bNumEndpoints 1 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 4 WING Output Terminal > AudioStreaming Interface Descriptor: > bLength 16 > bDescriptorType 36 > bDescriptorSubtype 1 (AS_GENERAL) > bTerminalLink 2 > bmControls 0x00 > bFormatType 1 > bmFormats 0x00000001 > PCM > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 18 Out 1 > AudioStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (FORMAT_TYPE) > bFormatType 1 (FORMAT_TYPE_I) > bSubslotSize 3 > bBitResolution 24 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x01 EP 1 OUT > bmAttributes 5 > Transfer Type Isochronous > Synch Type Asynchronous > Usage Type Data > wMaxPacketSize 0x03f0 1x 1008 bytes > bInterval 1 > AudioStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (EP_GENERAL) > bmAttributes 0x00 > bmControls 0x00 > bLockDelayUnits 2 Decoded PCM samples > wLockDelay 0x0008 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 5 WING Input Terminal > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 1 > bNumEndpoints 1 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 5 WING Input Terminal > AudioStreaming Interface Descriptor: > bLength 16 > bDescriptorType 36 > bDescriptorSubtype 1 (AS_GENERAL) > bTerminalLink 22 > bmControls 0x00 > bFormatType 1 > bmFormats 0x00000001 > PCM > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 66 In 1 > AudioStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (FORMAT_TYPE) > bFormatType 1 (FORMAT_TYPE_I) > bSubslotSize 3 > bBitResolution 24 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x81 EP 1 IN > bmAttributes 37 > Transfer Type Isochronous > Synch Type Asynchronous > Usage Type Implicit feedback Data > wMaxPacketSize 0x03f0 1x 1008 bytes > bInterval 1 > AudioStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (EP_GENERAL) > bmAttributes 0x00 > bmControls 0x00 > bLockDelayUnits 2 Decoded PCM samples > wLockDelay 0x0008 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 3 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 1 Control Device > bInterfaceProtocol 0 > iInterface 0 > AudioControl Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 1.00 > wTotalLength 0x0009 > bInCollection 1 > baInterfaceNr(0) 1 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 4 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 1 Audio > bInterfaceSubClass 3 MIDI Streaming > bInterfaceProtocol 0 > iInterface 0 > MIDIStreaming Interface Descriptor: > bLength 7 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 1.00 > wTotalLength 0x00a1 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 25 > iJack 11 WING MIDI DAW 1 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 2 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 26 > iJack 13 WING MIDI DAW 2 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 3 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 27 > iJack 15 WING MIDI DAW 3 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 4 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 28 > iJack 17 WING MIDI Control > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 9 > bNrInputPins 1 > baSourceID( 0) 25 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 17 > bNrInputPins 1 > baSourceID( 0) 1 > BaSourcePin( 0) 1 > iJack 10 WING MIDI DAW 1 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 10 > bNrInputPins 1 > baSourceID( 0) 26 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 18 > bNrInputPins 1 > baSourceID( 0) 2 > BaSourcePin( 0) 1 > iJack 12 WING MIDI DAW 2 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 11 > bNrInputPins 1 > baSourceID( 0) 27 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 19 > bNrInputPins 1 > baSourceID( 0) 3 > BaSourcePin( 0) 1 > iJack 14 WING MIDI DAW 3 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 12 > bNrInputPins 1 > baSourceID( 0) 28 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 20 > bNrInputPins 1 > baSourceID( 0) 4 > BaSourcePin( 0) 1 > iJack 16 WING MIDI Control > Endpoint Descriptor: > bLength 9 > bDescriptorType 5 > bEndpointAddress 0x02 EP 2 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > bRefresh 0 > bSynchAddress 0 > MIDIStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (GENERAL) > bNumEmbMIDIJack 4 > baAssocJackID( 0) 1 > baAssocJackID( 1) 2 > baAssocJackID( 2) 3 > baAssocJackID( 3) 4 > Endpoint Descriptor: > bLength 9 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > bRefresh 0 > bSynchAddress 0 > MIDIStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (GENERAL) > bNumEmbMIDIJack 4 > baAssocJackID( 0) 9 > baAssocJackID( 1) 10 > baAssocJackID( 2) 11 > baAssocJackID( 3) 12 > Configuration Descriptor: > bLength 9 > bDescriptorType 2 > wTotalLength 0x0323 > bNumInterfaces 5 > bConfigurationValue 1 > iConfiguration 0 > bmAttributes 0xc0 > Self Powered > MaxPower 0mA > Interface Association: > bLength 8 > bDescriptorType 11 > bFirstInterface 0 > bInterfaceCount 3 > bFunctionClass 1 Audio > bFunctionSubClass 0 > bFunctionProtocol 32 > iFunction 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 1 Control Device > bInterfaceProtocol 32 > iInterface 3 WING > AudioControl Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 2.00 > bCategory 8 > wTotalLength 0x01df > bmControls 0x00 > AudioControl Interface Descriptor: > bLength 8 > bDescriptorType 36 > bDescriptorSubtype 10 (CLOCK_SOURCE) > bClockID 41 > bmAttributes 1 Internal fixed clock > bmControls 0x07 > Clock Frequency Control (read/write) > Clock Validity Control (read-only) > bAssocTerminal 0 > iClockSource 9 WING Internal Clock > AudioControl Interface Descriptor: > bLength 17 > bDescriptorType 36 > bDescriptorSubtype 2 (INPUT_TERMINAL) > bTerminalID 2 > wTerminalType 0x0101 USB Streaming > bAssocTerminal 0 > bCSourceID 41 > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 18 Out 1 > bmControls 0x0000 > iTerminal 6 WING Output > AudioControl Interface Descriptor: > bLength 202 > bDescriptorType 36 > bDescriptorSubtype 6 (FEATURE_UNIT) > bUnitID 10 > bSourceID 2 > bmaControls(0) 0x00000000 > bmaControls(1) 0x00000000 > bmaControls(2) 0x00000000 > bmaControls(3) 0x00000000 > bmaControls(4) 0x00000000 > bmaControls(5) 0x00000000 > bmaControls(6) 0x00000000 > bmaControls(7) 0x00000000 > bmaControls(8) 0x00000000 > bmaControls(9) 0x00000000 > bmaControls(10) 0x00000000 > bmaControls(11) 0x00000000 > bmaControls(12) 0x00000000 > bmaControls(13) 0x00000000 > bmaControls(14) 0x00000000 > bmaControls(15) 0x00000000 > bmaControls(16) 0x00000000 > bmaControls(17) 0x00000000 > bmaControls(18) 0x00000000 > bmaControls(19) 0x00000000 > bmaControls(20) 0x00000000 > bmaControls(21) 0x00000000 > bmaControls(22) 0x00000000 > bmaControls(23) 0x00000000 > bmaControls(24) 0x00000000 > bmaControls(25) 0x00000000 > bmaControls(26) 0x00000000 > bmaControls(27) 0x00000000 > bmaControls(28) 0x00000000 > bmaControls(29) 0x00000000 > bmaControls(30) 0x00000000 > bmaControls(31) 0x00000000 > bmaControls(32) 0x00000000 > bmaControls(33) 0x00000000 > bmaControls(34) 0x00000000 > bmaControls(35) 0x00000000 > bmaControls(36) 0x00000000 > bmaControls(37) 0x00000000 > bmaControls(38) 0x00000000 > bmaControls(39) 0x00000000 > bmaControls(40) 0x00000000 > bmaControls(41) 0x00000000 > bmaControls(42) 0x00000000 > bmaControls(43) 0x00000000 > bmaControls(44) 0x00000000 > bmaControls(45) 0x00000000 > bmaControls(46) 0x00000000 > bmaControls(47) 0x00000000 > bmaControls(48) 0x00000000 > iFeature 0 > AudioControl Interface Descriptor: > bLength 12 > bDescriptorType 36 > bDescriptorSubtype 3 (OUTPUT_TERMINAL) > bTerminalID 20 > wTerminalType 0x0301 Speaker > bAssocTerminal 0 > bSourceID 10 > bCSourceID 41 > bmControls 0x0000 > iTerminal 0 > AudioControl Interface Descriptor: > bLength 17 > bDescriptorType 36 > bDescriptorSubtype 2 (INPUT_TERMINAL) > bTerminalID 1 > wTerminalType 0x0201 Microphone > bAssocTerminal 0 > bCSourceID 41 > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 66 In 1 > bmControls 0x0000 > iTerminal 0 > AudioControl Interface Descriptor: > bLength 202 > bDescriptorType 36 > bDescriptorSubtype 6 (FEATURE_UNIT) > bUnitID 11 > bSourceID 1 > bmaControls(0) 0x00000000 > bmaControls(1) 0x00000000 > bmaControls(2) 0x00000000 > bmaControls(3) 0x00000000 > bmaControls(4) 0x00000000 > bmaControls(5) 0x00000000 > bmaControls(6) 0x00000000 > bmaControls(7) 0x00000000 > bmaControls(8) 0x00000000 > bmaControls(9) 0x00000000 > bmaControls(10) 0x00000000 > bmaControls(11) 0x00000000 > bmaControls(12) 0x00000000 > bmaControls(13) 0x00000000 > bmaControls(14) 0x00000000 > bmaControls(15) 0x00000000 > bmaControls(16) 0x00000000 > bmaControls(17) 0x00000000 > bmaControls(18) 0x00000000 > bmaControls(19) 0x00000000 > bmaControls(20) 0x00000000 > bmaControls(21) 0x00000000 > bmaControls(22) 0x00000000 > bmaControls(23) 0x00000000 > bmaControls(24) 0x00000000 > bmaControls(25) 0x00000000 > bmaControls(26) 0x00000000 > bmaControls(27) 0x00000000 > bmaControls(28) 0x00000000 > bmaControls(29) 0x00000000 > bmaControls(30) 0x00000000 > bmaControls(31) 0x00000000 > bmaControls(32) 0x00000000 > bmaControls(33) 0x00000000 > bmaControls(34) 0x00000000 > bmaControls(35) 0x00000000 > bmaControls(36) 0x00000000 > bmaControls(37) 0x00000000 > bmaControls(38) 0x00000000 > bmaControls(39) 0x00000000 > bmaControls(40) 0x00000000 > bmaControls(41) 0x00000000 > bmaControls(42) 0x00000000 > bmaControls(43) 0x00000000 > bmaControls(44) 0x00000000 > bmaControls(45) 0x00000000 > bmaControls(46) 0x00000000 > bmaControls(47) 0x00000000 > bmaControls(48) 0x00000000 > iFeature 0 > AudioControl Interface Descriptor: > bLength 12 > bDescriptorType 36 > bDescriptorSubtype 3 (OUTPUT_TERMINAL) > bTerminalID 22 > wTerminalType 0x0101 USB Streaming > bAssocTerminal 0 > bSourceID 11 > bCSourceID 41 > bmControls 0x0000 > iTerminal 7 WING Input > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 4 WING Output Terminal > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 1 > bNumEndpoints 1 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 4 WING Output Terminal > AudioStreaming Interface Descriptor: > bLength 16 > bDescriptorType 36 > bDescriptorSubtype 1 (AS_GENERAL) > bTerminalLink 2 > bmControls 0x00 > bFormatType 1 > bmFormats 0x00000001 > PCM > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 18 Out 1 > AudioStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (FORMAT_TYPE) > bFormatType 1 (FORMAT_TYPE_I) > bSubslotSize 3 > bBitResolution 24 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x01 EP 1 OUT > bmAttributes 5 > Transfer Type Isochronous > Synch Type Asynchronous > Usage Type Data > wMaxPacketSize 0x03f0 1x 1008 bytes > bInterval 1 > AudioStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (EP_GENERAL) > bmAttributes 0x00 > bmControls 0x00 > bLockDelayUnits 2 Decoded PCM samples > wLockDelay 0x0008 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 5 WING Input Terminal > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 1 > bNumEndpoints 1 > bInterfaceClass 1 Audio > bInterfaceSubClass 2 Streaming > bInterfaceProtocol 32 > iInterface 5 WING Input Terminal > AudioStreaming Interface Descriptor: > bLength 16 > bDescriptorType 36 > bDescriptorSubtype 1 (AS_GENERAL) > bTerminalLink 22 > bmControls 0x00 > bFormatType 1 > bmFormats 0x00000001 > PCM > bNrChannels 48 > bmChannelConfig 0x00000000 > iChannelNames 66 In 1 > AudioStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (FORMAT_TYPE) > bFormatType 1 (FORMAT_TYPE_I) > bSubslotSize 3 > bBitResolution 24 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x81 EP 1 IN > bmAttributes 37 > Transfer Type Isochronous > Synch Type Asynchronous > Usage Type Implicit feedback Data > wMaxPacketSize 0x03f0 1x 1008 bytes > bInterval 1 > AudioStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (EP_GENERAL) > bmAttributes 0x00 > bmControls 0x00 > bLockDelayUnits 2 Decoded PCM samples > wLockDelay 0x0008 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 3 > bAlternateSetting 0 > bNumEndpoints 0 > bInterfaceClass 1 Audio > bInterfaceSubClass 1 Control Device > bInterfaceProtocol 0 > iInterface 0 > AudioControl Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 1.00 > wTotalLength 0x0009 > bInCollection 1 > baInterfaceNr(0) 1 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 4 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 1 Audio > bInterfaceSubClass 3 MIDI Streaming > bInterfaceProtocol 0 > iInterface 0 > MIDIStreaming Interface Descriptor: > bLength 7 > bDescriptorType 36 > bDescriptorSubtype 1 (HEADER) > bcdADC 1.00 > wTotalLength 0x00a1 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 25 > iJack 11 WING MIDI DAW 1 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 2 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 26 > iJack 13 WING MIDI DAW 2 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 3 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 27 > iJack 15 WING MIDI DAW 3 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 1 Embedded > bJackID 4 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 6 > bDescriptorType 36 > bDescriptorSubtype 2 (MIDI_IN_JACK) > bJackType 2 External > bJackID 28 > iJack 17 WING MIDI Control > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 9 > bNrInputPins 1 > baSourceID( 0) 25 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 17 > bNrInputPins 1 > baSourceID( 0) 1 > BaSourcePin( 0) 1 > iJack 10 WING MIDI DAW 1 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 10 > bNrInputPins 1 > baSourceID( 0) 26 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 18 > bNrInputPins 1 > baSourceID( 0) 2 > BaSourcePin( 0) 1 > iJack 12 WING MIDI DAW 2 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 11 > bNrInputPins 1 > baSourceID( 0) 27 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 19 > bNrInputPins 1 > baSourceID( 0) 3 > BaSourcePin( 0) 1 > iJack 14 WING MIDI DAW 3 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 1 Embedded > bJackID 12 > bNrInputPins 1 > baSourceID( 0) 28 > BaSourcePin( 0) 1 > iJack 0 > MIDIStreaming Interface Descriptor: > bLength 9 > bDescriptorType 36 > bDescriptorSubtype 3 (MIDI_OUT_JACK) > bJackType 2 External > bJackID 20 > bNrInputPins 1 > baSourceID( 0) 4 > BaSourcePin( 0) 1 > iJack 16 WING MIDI Control > Endpoint Descriptor: > bLength 9 > bDescriptorType 5 > bEndpointAddress 0x02 EP 2 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > bRefresh 0 > bSynchAddress 0 > MIDIStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (GENERAL) > bNumEmbMIDIJack 4 > baAssocJackID( 0) 1 > baAssocJackID( 1) 2 > baAssocJackID( 2) 3 > baAssocJackID( 3) 4 > Endpoint Descriptor: > bLength 9 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > bRefresh 0 > bSynchAddress 0 > MIDIStreaming Endpoint Descriptor: > bLength 8 > bDescriptorType 37 > bDescriptorSubtype 1 (GENERAL) > bNumEmbMIDIJack 4 > baAssocJackID( 0) 9 > baAssocJackID( 1) 10 > baAssocJackID( 2) 11 > baAssocJackID( 3) 12 > Device Qualifier (for other device speed): > bLength 10 > bDescriptorType 6 > bcdUSB 2.00 > bDeviceClass 0 > bDeviceSubClass 0 > bDeviceProtocol 0 > bMaxPacketSize0 64 > bNumConfigurations 1 > Device Status: 0x0001 > Self Powered

1 0

Re: Behringer WING usb audio - cyclic xruns dependent on periods/buffers
by Takashi Iwai 09 Dec '20

09 Dec '20

On Sat, 05 Dec 2020 15:43:56 +0100, Ben Bell wrote: > > > > Like I said in the initial email, it feels like some sort of clock drift > > > problem, where we're managing very slowly to collect more samples than > > > we're reading -- to the tune of about 1 extra every few cycles -- and > > > nothing on the consumer side is ever managing to compensate for that. > > > I'm not even sure how that sort of drift would be possible though. Seems > > > surprising. > [...] > > > At least you can try the latest patch set destined for 5.11, which > > should improve the cases for the implicit feedback. > > Aha! This actually was the key piece of information I needed. I haven't > tried 5.11 or the latest patch set yet, but googling "implicit feedback" > and learning abobut it led me to conclude that the Wing needs an entry in > the quirks list in set_sync_ep_implicit_fb_quirk to properly enable it: > > --- sound/usb/pcm.c.orig 2020-11-22 23:36:08.000000000 +0000 > +++ sound/usb/pcm.c 2020-12-05 08:40:21.639600074 +0000 > @@ -340,6 +345,7 @@ > ep = 0x81; > ifnum = 3; > goto add_sync_ep_from_ifnum; > + case USB_ID(0x1397, 0x050b): /* Behringer Wing */ > case USB_ID(0x0763, 0x2080): /* M-Audio FastTrack Ultra */ > case USB_ID(0x0763, 0x2081): > > > A week's worth of debugging and learning yielded a one line patch ;) That's a interesting piece of information :) Could you give lsusb -v output of the device? With the latest patch set, the driver can set up the implicit feedback mode automatically in certain cases. I'm not sure whether Behringer device follows that pattern. If not, we'd need to add the quirk manually. thanks, Takashi

2 1

[PATCH] ASoC: rt1015p: delay 300ms after SDB pulling high for calibration
by Tzung-Bi Shih 09 Dec '20

09 Dec '20

RT1015p needs 300ms delay after SDB pulling high for internal calibration during the power on sequence. Delays 300ms right before data sends out to avoid data truncated. Signed-off-by: Tzung-Bi Shih <tzungbi(a)google.com> --- sound/soc/codecs/rt1015p.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/rt1015p.c b/sound/soc/codecs/rt1015p.c index 59bb60682270..515357474eba 100644 --- a/sound/soc/codecs/rt1015p.c +++ b/sound/soc/codecs/rt1015p.c @@ -4,6 +4,7 @@ // // Copyright 2020 The Linux Foundation. All rights reserved. +#include <linux/delay.h> #include <linux/device.h> #include <linux/err.h> #include <linux/gpio.h> @@ -20,6 +21,7 @@ struct rt1015p_priv { struct gpio_desc *sdb; int sdb_switch; + bool calib_done; }; static int rt1015p_daiops_trigger(struct snd_pcm_substream *substream, @@ -39,6 +41,11 @@ static int rt1015p_daiops_trigger(struct snd_pcm_substream *substream, if (rt1015p->sdb_switch) { gpiod_set_value(rt1015p->sdb, 1); dev_dbg(component->dev, "set sdb to 1"); + + if (!rt1015p->calib_done) { + mdelay(300); + rt1015p->calib_done = true; + } } break; case SNDRV_PCM_TRIGGER_STOP: -- 2.29.2.576.ga3fc446d84-goog

3 2