December 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH v4 0/2] Platform driver update to support playback recover after resume
by Srinivasa Rao Mandadapu 17 Dec '20

17 Dec '20

This patch set is to add support for playback recover after hard suspend and resume. It includes: 1. Reverting part of previous commit, which is for handling registers invalid state after hard suspend. 2. Adding pm ops in component driver and do regcache sync. Srinivasa Rao Mandadapu (2): Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state ASoC: qcom: Add support for playback recover after resume sound/soc/qcom/lpass-cpu.c | 20 ++---------------- sound/soc/qcom/lpass-platform.c | 46 +++++++++++++++++++++++++++++++---------- 2 files changed, 37 insertions(+), 29 deletions(-) -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

3 11

rsnd: clk-multiplier already disabled warning on Ebisu
by Geert Uytterhoeven 17 Dec '20

17 Dec '20

Hi Morimoto-san, While booting Ebisu-4D, I saw the below warnings (once). rcar_sound ec500000.sound: can't use clk 1 rsnd_adg_clk_control() failed to enable CLKB, but continues. ------------[ cut here ]------------ clk-multiplier already disabled WARNING: CPU: 1 PID: 52 at drivers/clk/clk.c:952 clk_core_disable+0x30/0x9c Modules linked in: CPU: 1 PID: 52 Comm: kworker/1:2 Not tainted 5.10.0-rc7-rcar3-initrd-00582-gadecf297acf4-dirty #183 Hardware name: Renesas Ebisu-4D board based on r8a77990 (DT) Workqueue: events deferred_probe_work_func pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) pc : clk_core_disable+0x30/0x9c lr : clk_core_disable+0x30/0x9c sp : ffffffc010f939f0 x29: ffffffc010f939f0 x28: 0000000000000000 x27: ffffff800949eb00 x26: ffffff80093c40f8 x25: 0000000000000001 x24: ffffffc010805fea x23: 0000000000000000 x22: ffffff80082b8810 x21: ffffff80093c4080 x20: ffffff8009368b00 x19: ffffff8009368b00 x18: 0000000000000000 x17: 000000004ef774c4 x16: 0000000000000014 x15: ffffffffffffffff x14: ffffffc010b8e8b0 x13: fffffffffff9fd47 x12: 0720072007200720 x11: fffffffffffc0000 x10: ffffffc010b8e8d8 x9 : 0720072007200720 x8 : 2079646165726c61 x7 : 0000000000000004 x6 : 00000000ffffe6ad x5 : ffffffc010f93718 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 00000000ffffffff x1 : 0000000000000000 x0 : 0000000000000000 Call trace: clk_core_disable+0x30/0x9c clk_core_disable_lock+0x24/0x3c clk_disable+0x20/0x30 rsnd_adg_clk_control+0xa0/0xd4 rsnd_adg_remove+0x58/0x6c rsnd_probe+0x134/0x3cc Something else fails (-EPROBE_DEFER?), and thus rsnd_adg_remove() is called. The latter disables all clocks, including the one that failed to enable before, leading to the warning. platform_drv_probe+0x54/0xa4 really_probe+0x234/0x340 driver_probe_device+0xa0/0xb0 __device_attach_driver+0x9c/0xa8 bus_for_each_drv+0x9c/0xc4 __device_attach+0xd4/0x140 device_initial_probe+0x14/0x20 bus_probe_device+0x30/0x94 deferred_probe_work_func+0x9c/0xb0 process_one_work+0x180/0x1f0 process_scheduled_works+0x44/0x48 worker_thread+0x1ec/0x270 kthread+0xdc/0xec ret_from_fork+0x10/0x30 ---[ end trace 8d8c2a1b7537ca36 ]--- ------------[ cut here ]------------ clk-multiplier already unprepared WARNING: CPU: 1 PID: 52 at drivers/clk/clk.c:810 clk_core_unprepare+0x30/0xd0 [...] ---[ end trace 8d8c2a1b7537ca37 ]--- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

3 5

[PATCH v2] ASoC: AMD Renoir - add DMI table to avoid the ACP mic probe (broken BIOS)
by Jaroslav Kysela 17 Dec '20

17 Dec '20

Users reported that some Lenovo AMD platforms do not have ACP microphone, but the BIOS advertises it via ACPI. This patch create a simple DMI table, where those machines with the broken BIOS can be added. The DMI description for Lenovo IdeaPad 5 and IdeaPad Flex 5 devices are added there. Also describe the dmic_acpi_check kernel module parameter in a more understandable way. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1892115 Cc: <stable(a)kernel.org> Cc: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> Cc: Mark Brown <broonie(a)kernel.org> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/soc/amd/renoir/rn-pci-acp3x.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index b943e59fc302..60a3e2f442db 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -6,6 +6,7 @@ #include <linux/pci.h> #include <linux/acpi.h> +#include <linux/dmi.h> #include <linux/module.h> #include <linux/io.h> #include <linux/delay.h> @@ -20,14 +21,13 @@ module_param(acp_power_gating, int, 0644); MODULE_PARM_DESC(acp_power_gating, "Enable acp power gating"); /** - * dmic_acpi_check = -1 - Checks ACPI method to know DMIC hardware status runtime - * = 0 - Skips the DMIC device creation and returns probe failure - * = 1 - Assumes that platform has DMIC support and skips ACPI - * method check + * dmic_acpi_check = -1 - Use ACPI/DMI method to detect the DMIC hardware presence at runtime + * = 0 - Skip the DMIC device creation and return probe failure + * = 1 - Force DMIC support */ static int dmic_acpi_check = ACP_DMIC_AUTO; module_param(dmic_acpi_check, bint, 0644); -MODULE_PARM_DESC(dmic_acpi_check, "checks Dmic hardware runtime"); +MODULE_PARM_DESC(dmic_acpi_check, "Digital microphone presence (-1=auto, 0=none, 1=force)"); struct acp_dev_data { void __iomem *acp_base; @@ -163,6 +163,17 @@ static int rn_acp_deinit(void __iomem *acp_base) return 0; } +static const struct dmi_system_id rn_acp_quirk_table[] = { + { + /* Lenovo IdeaPad Flex 5 14ARE05, IdeaPad 5 15ARE05 */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "LNVNB161216"), + } + }, + {} +}; + static int snd_rn_acp_probe(struct pci_dev *pci, const struct pci_device_id *pci_id) { @@ -172,6 +183,7 @@ static int snd_rn_acp_probe(struct pci_dev *pci, acpi_handle handle; acpi_integer dmic_status; #endif + const struct dmi_system_id *dmi_id; unsigned int irqflags; int ret, index; u32 addr; @@ -232,6 +244,12 @@ static int snd_rn_acp_probe(struct pci_dev *pci, goto de_init; } #endif + dmi_id = dmi_first_match(rn_acp_quirk_table); + if (dmi_id && !dmi_id->driver_data) { + dev_info(&pci->dev, "ACPI settings override using DMI (ACP mic is not present)"); + ret = -ENODEV; + goto de_init; + } } adata->res = devm_kzalloc(&pci->dev, -- 2.26.2

4 3

chtrt5645: Enable Internal MIC of ECS EF20EA
by GitHub pull_request - edited 17 Dec '20

17 Dec '20

alsa-project/alsa-ucm-conf pull request #68 was edited from starnight: * Add a card long name "Standard-EF20EA-1.0" match chtrt5645 enabling the internal DMIC. * ~~Create HdmiLpeAudio folder and copy & modify HDMI.conf from HDA-Intel for the devices using HdmiLpeAudio as the HDMI audio driver.~~ Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/68 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/68.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

chtrt5645: Enable Internal MIC of ECS EF20EA
by GitHub pull_request - edited 17 Dec '20

17 Dec '20

alsa-project/alsa-ucm-conf pull request #68 was edited from starnight: * Add a card long name "Standard-EF20EA-1.0" match chtrt5645 enabling the internal DMIC. * Create HdmiLpeAudio folder and copy & modify HDMI.conf from HDA-Intel for the devices using HdmiLpeAudio as the HDMI audio driver. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/68 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/68.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: SOF: Fix spelling mistake in Kconfig "ond" -> "and"
by Colin King 16 Dec '20

16 Dec '20

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 031dad5fc4c7..3e8b6c035ce3 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -122,7 +122,7 @@ config SND_SOC_SOF_DEBUG_XRUN_STOP bool "SOF stop on XRUN" help This option forces PCMs to stop on any XRUN event. This is useful to - preserve any trace data ond pipeline status prior to the XRUN. + preserve any trace data and pipeline status prior to the XRUN. Say Y if you are debugging SOF FW pipeline XRUNs. If unsure select "N". -- 2.29.2

3 2

[PATCH] ASoC: codecs: fix spelling mistake in Kconfig "comunicate" -> "communicate"
by Colin King 16 Dec '20

16 Dec '20

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index ba4eb54aafcb..9bf6bfdaf11e 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -457,7 +457,7 @@ config SND_SOC_ADAU7118_HW help Enable support for the Analog Devices ADAU7118 8 Channel PDM-to-I2S/TDM Converter. In this mode, the device works in standalone mode which - means that there is no bus to comunicate with it. Stereo mode is not + means that there is no bus to communicate with it. Stereo mode is not supported in this mode. To compile this driver as a module, choose M here: the module -- 2.29.2

2 1

[PATCH] ASoC: atmel: fix spelling mistake in Kconfig "programable" -> "programmable"
by Colin King 16 Dec '20

16 Dec '20

From: Colin Ian King <colin.king(a)canonical.com> There are a couple of spelling mistakes in the Kconfig help text. Fix them. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/atmel/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 142373ec411a..9fe9471f4514 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -143,7 +143,7 @@ config SND_MCHP_SOC_SPDIFTX - sama7g5 This S/PDIF TX driver is compliant with IEC-60958 standard and - includes programable User Data and Channel Status fields. + includes programmable User Data and Channel Status fields. config SND_MCHP_SOC_SPDIFRX tristate "Microchip ASoC driver for boards using S/PDIF RX" @@ -157,5 +157,5 @@ config SND_MCHP_SOC_SPDIFRX - sama7g5 This S/PDIF RX driver is compliant with IEC-60958 standard and - includes programable User Data and Channel Status fields. + includes programmable User Data and Channel Status fields. endif -- 2.29.2

3 2

[PATCH 0/2] ASoC: ti: Maintainer mail address change
by Peter Ujfalusi 16 Dec '20

16 Dec '20

Hi, My TI address is going to bounce after Friday (18.12.2020), switch my email address to my private one for now. Regards, Peter --- Peter Ujfalusi (2): MAINTAINERS: Update email address for TI ASoC and twl4030 codec drivers ASoC: dt-bindings: ti,j721e: Update maintainer and author information .../devicetree/bindings/sound/ti,j721e-cpb-audio.yaml | 4 +++- .../devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml | 4 +++- MAINTAINERS | 6 +++--- 3 files changed, 9 insertions(+), 5 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

3 5

[PATCH] ASoC: dapm: remove widget from dirty list on free
by Thomas Hebb 16 Dec '20

16 Dec '20

A widget's "dirty" list_head, much like its "list" list_head, eventually chains back to a list_head on the snd_soc_card itself. This means that the list can stick around even after the widget (or all widgets) have been freed. Currently, however, widgets that are in the dirty list when freed remain there, corrupting the entire list and leading to memory errors and undefined behavior when the list is next accessed or modified. I encountered this issue when a component failed to probe relatively late in snd_soc_bind_card(), causing it to bail out and call soc_cleanup_card_resources(), which eventually called snd_soc_dapm_free() with widgets that were still dirty from when they'd been added. Fixes: db432b414e20 ("ASoC: Do DAPM power checks only for widgets changed since last run") Cc: stable(a)vger.kernel.org Signed-off-by: Thomas Hebb <tommyhebb(a)gmail.com> --- sound/soc/soc-dapm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 7f87b449f950..148c095df27b 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2486,6 +2486,7 @@ void snd_soc_dapm_free_widget(struct snd_soc_dapm_widget *w) enum snd_soc_dapm_direction dir; list_del(&w->list); + list_del(&w->dirty); /* * remove source and sink paths associated to this widget. * While removing the path, remove reference to it from both -- 2.29.2

3 2