November 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda: Add Alderlake-S PCI ID and HDMI codec vid
by Kai Vehmanen 16 Nov '20

16 Nov '20

Add HD Audio PCI ID and HDMI codec vendor ID for Intel Alder Lake. Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> --- sound/pci/hda/hda_intel.c | 3 +++ sound/pci/hda/patch_hdmi.c | 1 + 2 files changed, 4 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index d539f52009a1..6852668f1bcb 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2506,6 +2506,9 @@ static const struct pci_device_id azx_ids[] = { /* DG1 */ { PCI_DEVICE(0x8086, 0x490d), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, + /* Alderlake-S */ + { PCI_DEVICE(0x8086, 0x7ad0), + .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, /* Elkhart Lake */ { PCI_DEVICE(0x8086, 0x4b55), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index ccd1df059654..b0068f8ca46d 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -4274,6 +4274,7 @@ HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862814, "DG1 HDMI", patch_i915_tgl_hdmi), +HDA_CODEC_ENTRY(0x80862815, "Alderlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862816, "Rocketlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x8086281a, "Jasperlake HDMI", patch_i915_icl_hdmi), HDA_CODEC_ENTRY(0x8086281b, "Elkhartlake HDMI", patch_i915_icl_hdmi), -- 2.28.0

2 1

[PATCH 0/2] alsa-gobject: rawmidi: fix to select substream
by GitHub pull_request - opened 16 Nov '20

16 Nov '20

alsa-project/alsa-gobject pull request #54 was opened from takaswie: This patchset fixes #53 . ALSARawmidi.StreamPair.open() has `subdevice_id` argument to select one of substreams supported by the Rawmidi device. However, this parameter is ignored and the first substream is always selected. In ALSA rawmidi core, private structure associated to file descriptor to control character device assists selection of rawmidi substream. It requires to keep the file descriptor until the selected substream is actually attached by open rawmidi character device. Current implementation of libalsarawmidi is to close the file descriptor before opening rawmidi character device. This is the cause of the issue. This commit fixes the bug by keeping the file descriptor till opening rawmidi character device. ``` Takashi Sakamoto (2): rawmidi: query: allow caller to take ownership of file descriptor for control character device rawmidi: stream_pair: fix to select substream src/rawmidi/privates.h | 2 +- src/rawmidi/query.c | 16 ++++++++++------ src/rawmidi/stream-pair.c | 4 +++- 3 files changed, 14 insertions(+), 8 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/54 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/54.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH] ALSA: usb-audio: Use ALC1220-VB-DT mapping for ASUS ROG Strix TRX40 mobo
by Kai-Heng Feng 16 Nov '20

16 Nov '20

ASUS ROG Strix also uses ALC1220-VB-DT, so adjust the mapping and add profile name to let userspace pick correct UCM profile. BugLink: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1031 Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/usb/card.c | 4 ++++ sound/usb/mixer_maps.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/usb/card.c b/sound/usb/card.c index fa764b61fe9c..4457214a3ae6 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -379,6 +379,10 @@ static const struct usb_audio_device_name usb_audio_names[] = { DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"), + /* ASUS ROG Strix */ + PROFILE_NAME(0x0b05, 0x1917, + "Realtek", "ALC1220-VB-DT", "Realtek-ALC1220-VB-Desktop"), + /* Dell WD15 Dock */ PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"), /* Dell WD19 Dock */ diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index c369c81e74c4..a7212f16660e 100644 --- a/sound/usb/mixer_maps.c +++ b/sound/usb/mixer_maps.c @@ -561,7 +561,8 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { }, { /* ASUS ROG Strix */ .id = USB_ID(0x0b05, 0x1917), - .map = asus_rog_map, + .map = trx40_mobo_map, + .connector_map = trx40_mobo_connector_map, }, { /* MSI TRX40 Creator */ .id = USB_ID(0x0db0, 0x0d64), -- 2.28.0

2 1

[sound:test/usb-hacks-wip 44/53] sound/usb/endpoint.c:1255:5: warning: no previous prototype for function 'snd_usb_sync_endpoint_start'
by kernel test robot 16 Nov '20

16 Nov '20

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/usb-hacks-wip head: 8d9dd7caccc6daebab8b2a1a7bbd09e605b83fba commit: ca31918f6843b5369d0c900c43bfe5f71441b5b2 [44/53] ALSA: usb-audio: Refactor endpoint management config: x86_64-randconfig-a001-20201115 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9a85643cd357e412cff69067bb5c4840e228c2ab) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound test/usb-hacks-wip git checkout ca31918f6843b5369d0c900c43bfe5f71441b5b2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> sound/usb/endpoint.c:1255:5: warning: no previous prototype for function 'snd_usb_sync_endpoint_start' [-Wmissing-prototypes] int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, ^ sound/usb/endpoint.c:1255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, ^ static >> sound/usb/endpoint.c:1298:6: warning: no previous prototype for function 'snd_usb_sync_endpoint_stop' [-Wmissing-prototypes] void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) ^ sound/usb/endpoint.c:1298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) ^ static 2 warnings generated. vim +/snd_usb_sync_endpoint_start +1255 sound/usb/endpoint.c 1254 > 1255 int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, 1256 struct snd_usb_endpoint *data_ep) 1257 { 1258 int err; 1259 1260 err = snd_usb_endpoint_start(ep); 1261 return err; 1262 } 1263 1264 /** 1265 * snd_usb_endpoint_stop: stop an snd_usb_endpoint 1266 * 1267 * @ep: the endpoint to stop (may be NULL) 1268 * 1269 * A call to this function will decrement the use count of the endpoint. 1270 * In case the last user has requested the endpoint stop, the URBs will 1271 * actually be deactivated. 1272 * 1273 * Must be balanced to calls of snd_usb_endpoint_start(). 1274 * 1275 * The caller needs to synchronize the pending stop operation via 1276 * snd_usb_endpoint_sync_pending_stop(). 1277 */ 1278 void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep) 1279 { 1280 if (!ep) 1281 return; 1282 1283 usb_audio_dbg(ep->chip, "Stopping %s EP 0x%x (count %d)\n", 1284 ep_type_name(ep->type), ep->ep_num, ep->use_count); 1285 1286 if (snd_BUG_ON(ep->use_count == 0)) 1287 return; 1288 1289 if (ep->sync_master) 1290 WRITE_ONCE(ep->sync_master->sync_slave, NULL); 1291 1292 if (--ep->use_count == 0) { 1293 deactivate_urbs(ep, false); 1294 set_bit(EP_FLAG_STOPPING, &ep->flags); 1295 } 1296 } 1297 > 1298 void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) 1299 { 1300 snd_usb_endpoint_stop(ep); 1301 } 1302 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH 0/5] This patch series enables DMA mode on Intel Keem Bay platform
by Michael Sit Wei Hong 16 Nov '20

16 Nov '20

v1: Initial patch version, which contains fix for S24_LE format and also enable DMA mode on Intel Keembay platform Michael Sit Wei Hong (5): ASoC: Intel: KMB: Fix S24_LE configuration dt-bindings: sound: intel, keembay-i2s: Add info for device to use DMA ASoC: soc-generic-dmaengine-pcm: Add custom prepare and submit function ASoC: dmaengine_pcm: expose functions to header file for custom functions ASoC: Intel: KMB: Enable DMA transfer mode .../bindings/sound/intel,keembay-i2s.yaml | 14 ++ include/sound/dmaengine_pcm.h | 21 ++ sound/core/pcm_dmaengine.c | 46 ++-- sound/soc/intel/Kconfig | 2 + sound/soc/intel/keembay/kmb_platform.c | 208 ++++++++++++++++-- sound/soc/intel/keembay/kmb_platform.h | 9 + sound/soc/soc-generic-dmaengine-pcm.c | 8 +- 7 files changed, 270 insertions(+), 38 deletions(-) -- 2.17.1

1 5

rawmidi: substream 0 is always selected, ignoring parameter
by GitHub issues - opened 16 Nov '20

16 Nov '20

alsa-project/alsa-gobject issue #53 was opened from takaswie: This issue is confirmed in v0.1.0 release. `ALSARawmidi.StreamPair.open()` has `subdevice_id` to select one of substreams supported by the Rawmidi device. However, this parameter is ignored and the first substream is always selected. Currently, the procedure in `ALSARawmidi.StreamPair.open()` to open Rawmidi character device is: 1. open control character device 2. ioctl call with SNDRV_CTL_IOCTL_RAWMIDI_PREFER_SUBDEVICE 3. close control character device 4. open rawmidi character device The cause to ignore is step 3. After closing control character device, private structure assigned to file descriptor of control character device is dropped in kernel land. At step 4, the selection information is already lost and the first substream is assigned to file descriptor of rawmidi character device. The solution is to keep file descriptor of control character device when opening rawmidi character device, thus the procedure should be: 1. open control character device 2. ioctl call with SNDRV_CTL_IOCTL_RAWMIDI_PREFER_SUBDEVICE 3. open rawmidi character device 4. close control character device Issue URL : https://github.com/alsa-project/alsa-gobject/issues/53 Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 00/15] alsa-gobject: rawmidi: enhancement for error reporting
by GitHub pull_request - opened 16 Nov '20

16 Nov '20

alsa-project/alsa-gobject pull request #52 was opened from takaswie: The patchset is the part of work about #47. Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error. This patchset enhances error reporting. The library-wide error domain is obsoleted. A new error domain is added just for ALSARawmidi.StreamPair. The error domain delivers information about the cause of error ``` Takashi Sakamoto (15): timer: user_instance: fix code for GFileError seq: user_client: fix code for GFileError rawmidi: skip check of return value from g_malloc() rawmidi: check whether method argument for GError is available rawmidi: add checks for method arguments rawmidi: stream_pair: just return when character device is not opened rawmidi: query: simplify count check rawmidi: add GLib enumerations for error reporting rawmidi: stream-pair: add GQuark to report error for ALSARawmidi.StreamPair rawmidi: report error for ioctl rawmidi: report open/read/write/fcntl error rawmidi: report error for card disconnection state rawmidi: stream_pair: report error about write-only file descriptor rawmidi: query: use GFileError to report error rawmidi: obsolete library-wide GQuark for error reporting src/rawmidi/alsarawmidi-enum-types.h | 14 +++ src/rawmidi/alsarawmidi.map | 5 + src/rawmidi/privates.h | 6 - src/rawmidi/query.c | 117 ++++++++---------- src/rawmidi/stream-pair.c | 172 +++++++++++++++++++++------ src/rawmidi/stream-pair.h | 4 + src/seq/user-client.c | 6 +- src/timer/user-instance.c | 2 +- tests/alsarawmidi-enums | 6 + 9 files changed, 216 insertions(+), 116 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/52 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/52.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 1/2] ASoC: rt5682: Add a new property for the DMIC clock driving
by Oder Chiou 16 Nov '20

16 Nov '20

The patch adds a new property to set the DMIC clock driving. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- include/sound/rt5682.h | 1 + sound/soc/codecs/rt5682-i2c.c | 5 +++++ sound/soc/codecs/rt5682.c | 3 +++ sound/soc/codecs/rt5682.h | 14 ++++++++++++++ 4 files changed, 23 insertions(+) diff --git a/include/sound/rt5682.h b/include/sound/rt5682.h index e1f790561ac1..3900a07e3935 100644 --- a/include/sound/rt5682.h +++ b/include/sound/rt5682.h @@ -40,6 +40,7 @@ struct rt5682_platform_data { unsigned int btndet_delay; unsigned int dmic_clk_rate; unsigned int dmic_delay; + bool dmic_clk_driving_high; const char *dai_clk_names[RT5682_DAI_NUM_CLKS]; }; diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 6b4e0eb30c89..37d13120f5ba 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -221,6 +221,11 @@ static int rt5682_i2c_probe(struct i2c_client *i2c, case RT5682_DMIC1_CLK_GPIO3: /* share with BCLK2 */ regmap_update_bits(rt5682->regmap, RT5682_GPIO_CTRL_1, RT5682_GP3_PIN_MASK, RT5682_GP3_PIN_DMIC_CLK); + if (rt5682->pdata.dmic_clk_driving_high) + regmap_update_bits(rt5682->regmap, + RT5682_PAD_DRIVING_CTRL, + RT5682_PAD_DRV_GP3_MASK, + 2 << RT5682_PAD_DRV_GP3_SFT); break; default: diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index a9acce7b6cca..f299b30f4f59 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2989,6 +2989,9 @@ int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) rt5682->pdata.dai_clk_names[RT5682_DAI_WCLK_IDX], rt5682->pdata.dai_clk_names[RT5682_DAI_BCLK_IDX]); + rt5682->pdata.dmic_clk_driving_high = device_property_read_bool(dev, + "realtek,dmic-clk-driving-high"); + return 0; } EXPORT_SYMBOL_GPL(rt5682_parse_dt); diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index 354acd735ef4..99b85cfe6248 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1271,6 +1271,20 @@ #define RT5682_CP_CLK_HP_300KHZ (0x2 << 4) #define RT5682_CP_CLK_HP_600KHZ (0x3 << 4) +/* Pad Driving Control (0x0136) */ +#define RT5682_PAD_DRV_GP1_MASK (0x3 << 14) +#define RT5682_PAD_DRV_GP1_SFT 14 +#define RT5682_PAD_DRV_GP2_MASK (0x3 << 12) +#define RT5682_PAD_DRV_GP2_SFT 12 +#define RT5682_PAD_DRV_GP3_MASK (0x3 << 10) +#define RT5682_PAD_DRV_GP3_SFT 10 +#define RT5682_PAD_DRV_GP4_MASK (0x3 << 8) +#define RT5682_PAD_DRV_GP4_SFT 8 +#define RT5682_PAD_DRV_GP5_MASK (0x3 << 6) +#define RT5682_PAD_DRV_GP5_SFT 6 +#define RT5682_PAD_DRV_GP6_MASK (0x3 << 4) +#define RT5682_PAD_DRV_GP6_SFT 4 + /* Chopper and Clock control for DAC (0x013a)*/ #define RT5682_CKXEN_DAC1_MASK (0x1 << 13) #define RT5682_CKXEN_DAC1_SFT 13 -- 2.29.0

3 4

USB Audio: Xonar U7 MKII needs `iec958_device` entry
by GitHub issues - opened 15 Nov '20

15 Nov '20

alsa-project/alsa-lib issue #100 was opened from ndl: `USB-Audio.conf` includes V1 of Asus Xonar U7 card but not [MKII version](https://www.asus.com/ch-en/Sound-Cards/Xonar-U7-MKII/), the section `USB-Audio.pcm.iec958_device` should be extended to include the string "Xonar U7 MKII" 1 without this S/PDIF output doesn't work. Issue URL : https://github.com/alsa-project/alsa-lib/issues/100 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

fireface: FF800 periodic burst of Xruns
by David Runge 15 Nov '20

15 Nov '20

Hi! I'm currently testing the snd-fireface module on kernel > 5.9 with the RME Fireface 800 (FF800). Unfortunately, when running jackd using that device it generates large bursts of Xruns (~10000) quite periodically. /usr/bin/jackd -P80 -p 512 -d alsa -d hw:Fireface800 -n 3 -p 256 -r 48000 The issues do not seem to correlate with any load events on the system (and in between the Xrun events there are no Xruns even under load). I am not entirely sure how to further debug this. Any hints and suggestions would be very much welcome! Note: While using libffado for the device works it is not at all stable since kernel > 5.9 (sporadic rediscovery events of firewire-ohci, requiring the unplugging/replugging of the device's firewire cable and of course the restart of jackd). This is why I tried the snd-fireface module again, but it seems to suffer from a different set of issues ;-) Best, David -- https://sleepmap.de

1 0