November 2020 - Alsa-devel - mailman.alsa-project.org

[sound:test/usb-hacks-wip 44/53] sound/usb/endpoint.c:1255:5: warning: no previous prototype for function 'snd_usb_sync_endpoint_start'
by kernel test robot 16 Nov '20

16 Nov '20

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/usb-hacks-wip head: 8d9dd7caccc6daebab8b2a1a7bbd09e605b83fba commit: ca31918f6843b5369d0c900c43bfe5f71441b5b2 [44/53] ALSA: usb-audio: Refactor endpoint management config: x86_64-randconfig-a001-20201115 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9a85643cd357e412cff69067bb5c4840e228c2ab) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound test/usb-hacks-wip git checkout ca31918f6843b5369d0c900c43bfe5f71441b5b2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> sound/usb/endpoint.c:1255:5: warning: no previous prototype for function 'snd_usb_sync_endpoint_start' [-Wmissing-prototypes] int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, ^ sound/usb/endpoint.c:1255:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, ^ static >> sound/usb/endpoint.c:1298:6: warning: no previous prototype for function 'snd_usb_sync_endpoint_stop' [-Wmissing-prototypes] void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) ^ sound/usb/endpoint.c:1298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) ^ static 2 warnings generated. vim +/snd_usb_sync_endpoint_start +1255 sound/usb/endpoint.c 1254 > 1255 int snd_usb_sync_endpoint_start(struct snd_usb_endpoint *ep, 1256 struct snd_usb_endpoint *data_ep) 1257 { 1258 int err; 1259 1260 err = snd_usb_endpoint_start(ep); 1261 return err; 1262 } 1263 1264 /** 1265 * snd_usb_endpoint_stop: stop an snd_usb_endpoint 1266 * 1267 * @ep: the endpoint to stop (may be NULL) 1268 * 1269 * A call to this function will decrement the use count of the endpoint. 1270 * In case the last user has requested the endpoint stop, the URBs will 1271 * actually be deactivated. 1272 * 1273 * Must be balanced to calls of snd_usb_endpoint_start(). 1274 * 1275 * The caller needs to synchronize the pending stop operation via 1276 * snd_usb_endpoint_sync_pending_stop(). 1277 */ 1278 void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep) 1279 { 1280 if (!ep) 1281 return; 1282 1283 usb_audio_dbg(ep->chip, "Stopping %s EP 0x%x (count %d)\n", 1284 ep_type_name(ep->type), ep->ep_num, ep->use_count); 1285 1286 if (snd_BUG_ON(ep->use_count == 0)) 1287 return; 1288 1289 if (ep->sync_master) 1290 WRITE_ONCE(ep->sync_master->sync_slave, NULL); 1291 1292 if (--ep->use_count == 0) { 1293 deactivate_urbs(ep, false); 1294 set_bit(EP_FLAG_STOPPING, &ep->flags); 1295 } 1296 } 1297 > 1298 void snd_usb_sync_endpoint_stop(struct snd_usb_endpoint *ep) 1299 { 1300 snd_usb_endpoint_stop(ep); 1301 } 1302 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH 0/5] This patch series enables DMA mode on Intel Keem Bay platform
by Michael Sit Wei Hong 16 Nov '20

16 Nov '20

v1: Initial patch version, which contains fix for S24_LE format and also enable DMA mode on Intel Keembay platform Michael Sit Wei Hong (5): ASoC: Intel: KMB: Fix S24_LE configuration dt-bindings: sound: intel, keembay-i2s: Add info for device to use DMA ASoC: soc-generic-dmaengine-pcm: Add custom prepare and submit function ASoC: dmaengine_pcm: expose functions to header file for custom functions ASoC: Intel: KMB: Enable DMA transfer mode .../bindings/sound/intel,keembay-i2s.yaml | 14 ++ include/sound/dmaengine_pcm.h | 21 ++ sound/core/pcm_dmaengine.c | 46 ++-- sound/soc/intel/Kconfig | 2 + sound/soc/intel/keembay/kmb_platform.c | 208 ++++++++++++++++-- sound/soc/intel/keembay/kmb_platform.h | 9 + sound/soc/soc-generic-dmaengine-pcm.c | 8 +- 7 files changed, 270 insertions(+), 38 deletions(-) -- 2.17.1

1 5

rawmidi: substream 0 is always selected, ignoring parameter
by GitHub issues - opened 16 Nov '20

16 Nov '20

alsa-project/alsa-gobject issue #53 was opened from takaswie: This issue is confirmed in v0.1.0 release. `ALSARawmidi.StreamPair.open()` has `subdevice_id` to select one of substreams supported by the Rawmidi device. However, this parameter is ignored and the first substream is always selected. Currently, the procedure in `ALSARawmidi.StreamPair.open()` to open Rawmidi character device is: 1. open control character device 2. ioctl call with SNDRV_CTL_IOCTL_RAWMIDI_PREFER_SUBDEVICE 3. close control character device 4. open rawmidi character device The cause to ignore is step 3. After closing control character device, private structure assigned to file descriptor of control character device is dropped in kernel land. At step 4, the selection information is already lost and the first substream is assigned to file descriptor of rawmidi character device. The solution is to keep file descriptor of control character device when opening rawmidi character device, thus the procedure should be: 1. open control character device 2. ioctl call with SNDRV_CTL_IOCTL_RAWMIDI_PREFER_SUBDEVICE 3. open rawmidi character device 4. close control character device Issue URL : https://github.com/alsa-project/alsa-gobject/issues/53 Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 00/15] alsa-gobject: rawmidi: enhancement for error reporting
by GitHub pull_request - opened 16 Nov '20

16 Nov '20

alsa-project/alsa-gobject pull request #52 was opened from takaswie: The patchset is the part of work about #47. Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error. This patchset enhances error reporting. The library-wide error domain is obsoleted. A new error domain is added just for ALSARawmidi.StreamPair. The error domain delivers information about the cause of error ``` Takashi Sakamoto (15): timer: user_instance: fix code for GFileError seq: user_client: fix code for GFileError rawmidi: skip check of return value from g_malloc() rawmidi: check whether method argument for GError is available rawmidi: add checks for method arguments rawmidi: stream_pair: just return when character device is not opened rawmidi: query: simplify count check rawmidi: add GLib enumerations for error reporting rawmidi: stream-pair: add GQuark to report error for ALSARawmidi.StreamPair rawmidi: report error for ioctl rawmidi: report open/read/write/fcntl error rawmidi: report error for card disconnection state rawmidi: stream_pair: report error about write-only file descriptor rawmidi: query: use GFileError to report error rawmidi: obsolete library-wide GQuark for error reporting src/rawmidi/alsarawmidi-enum-types.h | 14 +++ src/rawmidi/alsarawmidi.map | 5 + src/rawmidi/privates.h | 6 - src/rawmidi/query.c | 117 ++++++++---------- src/rawmidi/stream-pair.c | 172 +++++++++++++++++++++------ src/rawmidi/stream-pair.h | 4 + src/seq/user-client.c | 6 +- src/timer/user-instance.c | 2 +- tests/alsarawmidi-enums | 6 + 9 files changed, 216 insertions(+), 116 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/52 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/52.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 1/2] ASoC: rt5682: Add a new property for the DMIC clock driving
by Oder Chiou 16 Nov '20

16 Nov '20

The patch adds a new property to set the DMIC clock driving. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- include/sound/rt5682.h | 1 + sound/soc/codecs/rt5682-i2c.c | 5 +++++ sound/soc/codecs/rt5682.c | 3 +++ sound/soc/codecs/rt5682.h | 14 ++++++++++++++ 4 files changed, 23 insertions(+) diff --git a/include/sound/rt5682.h b/include/sound/rt5682.h index e1f790561ac1..3900a07e3935 100644 --- a/include/sound/rt5682.h +++ b/include/sound/rt5682.h @@ -40,6 +40,7 @@ struct rt5682_platform_data { unsigned int btndet_delay; unsigned int dmic_clk_rate; unsigned int dmic_delay; + bool dmic_clk_driving_high; const char *dai_clk_names[RT5682_DAI_NUM_CLKS]; }; diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 6b4e0eb30c89..37d13120f5ba 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -221,6 +221,11 @@ static int rt5682_i2c_probe(struct i2c_client *i2c, case RT5682_DMIC1_CLK_GPIO3: /* share with BCLK2 */ regmap_update_bits(rt5682->regmap, RT5682_GPIO_CTRL_1, RT5682_GP3_PIN_MASK, RT5682_GP3_PIN_DMIC_CLK); + if (rt5682->pdata.dmic_clk_driving_high) + regmap_update_bits(rt5682->regmap, + RT5682_PAD_DRIVING_CTRL, + RT5682_PAD_DRV_GP3_MASK, + 2 << RT5682_PAD_DRV_GP3_SFT); break; default: diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index a9acce7b6cca..f299b30f4f59 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2989,6 +2989,9 @@ int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) rt5682->pdata.dai_clk_names[RT5682_DAI_WCLK_IDX], rt5682->pdata.dai_clk_names[RT5682_DAI_BCLK_IDX]); + rt5682->pdata.dmic_clk_driving_high = device_property_read_bool(dev, + "realtek,dmic-clk-driving-high"); + return 0; } EXPORT_SYMBOL_GPL(rt5682_parse_dt); diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index 354acd735ef4..99b85cfe6248 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1271,6 +1271,20 @@ #define RT5682_CP_CLK_HP_300KHZ (0x2 << 4) #define RT5682_CP_CLK_HP_600KHZ (0x3 << 4) +/* Pad Driving Control (0x0136) */ +#define RT5682_PAD_DRV_GP1_MASK (0x3 << 14) +#define RT5682_PAD_DRV_GP1_SFT 14 +#define RT5682_PAD_DRV_GP2_MASK (0x3 << 12) +#define RT5682_PAD_DRV_GP2_SFT 12 +#define RT5682_PAD_DRV_GP3_MASK (0x3 << 10) +#define RT5682_PAD_DRV_GP3_SFT 10 +#define RT5682_PAD_DRV_GP4_MASK (0x3 << 8) +#define RT5682_PAD_DRV_GP4_SFT 8 +#define RT5682_PAD_DRV_GP5_MASK (0x3 << 6) +#define RT5682_PAD_DRV_GP5_SFT 6 +#define RT5682_PAD_DRV_GP6_MASK (0x3 << 4) +#define RT5682_PAD_DRV_GP6_SFT 4 + /* Chopper and Clock control for DAC (0x013a)*/ #define RT5682_CKXEN_DAC1_MASK (0x1 << 13) #define RT5682_CKXEN_DAC1_SFT 13 -- 2.29.0

3 4

USB Audio: Xonar U7 MKII needs `iec958_device` entry
by GitHub issues - opened 15 Nov '20

15 Nov '20

alsa-project/alsa-lib issue #100 was opened from ndl: `USB-Audio.conf` includes V1 of Asus Xonar U7 card but not [MKII version](https://www.asus.com/ch-en/Sound-Cards/Xonar-U7-MKII/), the section `USB-Audio.pcm.iec958_device` should be extended to include the string "Xonar U7 MKII" 1 without this S/PDIF output doesn't work. Issue URL : https://github.com/alsa-project/alsa-lib/issues/100 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

fireface: FF800 periodic burst of Xruns
by David Runge 15 Nov '20

15 Nov '20

Hi! I'm currently testing the snd-fireface module on kernel > 5.9 with the RME Fireface 800 (FF800). Unfortunately, when running jackd using that device it generates large bursts of Xruns (~10000) quite periodically. /usr/bin/jackd -P80 -p 512 -d alsa -d hw:Fireface800 -n 3 -p 256 -r 48000 The issues do not seem to correlate with any load events on the system (and in between the Xrun events there are no Xruns even under load). I am not entirely sure how to further debug this. Any hints and suggestions would be very much welcome! Note: While using libffado for the device works it is not at all stable since kernel > 5.9 (sporadic rediscovery events of firewire-ohci, requiring the unplugging/replugging of the device's firewire cable and of course the restart of jackd). This is why I tried the snd-fireface module again, but it seems to suffer from a different set of issues ;-) Best, David -- https://sleepmap.de

1 0

[PATCH 0/9] alsa-gobject: hwdep: enhancement for error reporting
by GitHub pull_request - opened 15 Nov '20

15 Nov '20

alsa-project/alsa-gobject pull request #51 was opened from takaswie: The patchset is the part of work about #47. Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error. This patchset enhances error reporting. The library-wide error domain is obsoleted. ALSAHwdep library is small and includes global functions. GFileError is used for the functions to report error since It has no specific error domain in current design. ``` Takashi Sakamoto (9): seq: query: remove duplicated semicolon ctl: query: simplify count check timer: instance_param: simplify count check hwdep: skip check of return value from g_malloc() hwdep: check whether method argument for GError is available hwdep: add checks for method arguments hwdep: query: simplify count check hwdep: query: use GFileError to report error hwdep; obsolete library-wide GQuark for error reporting src/ctl/query.c | 9 ++-- src/hwdep/privates.h | 6 --- src/hwdep/query.c | 101 ++++++++++++++++-------------------- src/seq/query.c | 2 +- src/timer/instance-params.c | 5 +- 5 files changed, 50 insertions(+), 73 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/51 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/51.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support
by Dave Ertman 15 Nov '20

15 Nov '20

Brief history of Auxiliary Bus ============================== The auxiliary bus code was originally submitted upstream as virtual bus, and was submitted through the netdev tree.  This process generated up to v4.  This discussion can be found here: https://lore.kernel.org/netdev/20191111192219.30259-1-jeffrey.t.kirsher@int… At this point, GregKH requested that we take the review and revision process to an internal mailing list and garner the buy-in of a respected kernel contributor. The auxiliary bus (then known as virtual bus) was originally submitted along with implementation code for the ice driver and irdma drive, causing the complication of also having dependencies in the rdma tree. This new submission is utilizing an auxiliary bus consumer in only the sound driver tree to create the initial implementation and a single user. Since implementation work has started on this patch set, there have been multiple inquiries about the time frame of its completion. It appears that there will be numerous consumers of this functionality. The process of internal review and implementation using the sound drivers generated 19 internal versions.  The changes, including the name change from virtual bus to auxiliary bus, from these versions can be summarized as the following: - Fixed compilation and checkpatch errors - Improved documentation to address the motivation for virtual bus. - Renamed virtual bus to auxiliary bus - increased maximum device name size - Correct order in Kconfig and Makefile - removed the mid-layer adev->release layer for device unregister - pushed adev->id management to parent driver - all error paths out of ancillary_device_register return error code - all error paths out of ancillary_device_register use put_device - added adev->name element - modname in register cannot be NULL - added KBUILD_MODNAME as prefix for match_name - push adev->id responsibility to registering driver - uevent now parses adev->dev name - match_id function now parses adev->dev name - changed drivers probe function to also take an ancillary_device_id param - split ancillary_device_register into device_initialize and device_add - adjusted what is done in device_initialize and device_add - change adev to ancildev and adrv to ancildrv - change adev to ancildev in documentation ========================== Introduces the auxiliary bus implementation along with the example usage in the Sound Open Firmware(SOF) audio driver. In some subsystems, the functionality of the core device (PCI/ACPI/other) may be too complex for a single device to be managed as a monolithic block or a part of the functionality might need to be exposed to a different subsystem. Splitting the functionality into smaller orthogonal devices makes it easier to manage data, power management and domain-specific communication with the hardware. Also, common auxiliary_device functionality across primary devices can be handled by a common auxiliary_device. A key requirement for such a split is that there is no dependency on a physical bus, device, register accesses or regmap support. These individual devices split from the core cannot live on the platform bus as they are not physical devices that are controlled by DT/ACPI. The same argument applies for not using MFD in this scenario as it relies on individual function devices being physical devices that are DT enumerated. An example for this kind of requirement is the audio subsystem where a single IP handles multiple entities such as HDMI, Soundwire, local devices such as mics/speakers etc. The split for the core's functionality can be arbitrary or be defined by the DSP firmware topology and include hooks for test/debug. This allows for the audio core device to be minimal and tightly coupled with handling the hardware-specific logic and communication. The auxiliary bus is intended to be minimal, generic and avoid domain-specific assumptions. Each auxiliary bus device represents a part of its parent functionality. The generic behavior can be extended and specialized as needed by encapsulating an auxiliary bus device within other domain-specific structures and the use of .ops callbacks. The SOF driver adopts the auxiliary bus for implementing the multi-client support. A client in the context of the SOF driver represents a part of the core device's functionality. It is not a physical device but rather an auxiliary device that needs to communicate with the DSP via IPCs. With multi-client support,the sound card can be separated into multiple orthogonal auxiliary devices for local devices (mic/speakers etc), HDMI, sensing, probes, debug etc. In this series, we demonstrate the usage of the auxiliary bus with the help of the IPC test client which is used for testing the serialization of IPCs when multiple clients talk to the DSP at the same time. v3 changes: rename to auxiliary bus move .c file to drivers/base/ split auxdev unregister flow into uninitialize and delete steps update kernel-doc on register functions for new unregister model update documentation with new name and unregister flow remove check for release in auxiliary bus, allow core to catch Change driver register so only probe and id_table mandatory Fix matching logic in auxillary_match_id to account for longer id->name utilize auxiliary_bus callbacks for probe, remove and shutdown add auxiliary_find_device function add code to ensure unique auxdrv name shorten initialize/uninitialize in function names to init/uninit simplify looping logic in match_id in drives/base/Kconfig changed from tristate to bool Modified signature SOF client register/unregister API Modified PM runtime enabling sequence in the SOF ipc test aux driver Removed driver.name from the aux driver Added Probes client aux driver and device registration in the SOF driver. This allows for enabling the probes functionality in the SOF firmware for audio data extraction from specific points in the audio pipeline. Without auxiliary bus, the implementation requires modifying existing 15+ machine drivers to add the probes DAI links to the sounds cards. Using the auxiliary bus allows for splitting the probes implementation from the SOF core making it easy to maintain. v2 changes: defined pr_fmt for kernel messages replaced WARN_ON calls in registration with pr_err calls adding kernel-doc function comments for device_initialize and device_add fix typo in documentation removed inaccurate line in documentation fixed formatting in drivers/bus/Makefile changed unwind path for sof_client_dev_alloc() improved comments for client list and mem freeing during client unreg removed debugfs entries in sof_ipc_test_client_drv during remove changed the signature of sof_debug_ipc_flood_test() fix a looping error in ancillary_match_id updated error value in sof_client_dev_register() mutex held while traversing client list when unregistering clients updated includes in sof-client.h Dave Ertman (1): Add auxiliary bus support Ranjani Sridharan (9): ASoC: SOF: Introduce descriptors for SOF client ASoC: SOF: Create client driver for IPC test ASoC: SOF: ops: Add ops for client registration ASoC: SOF: Intel: Define ops for client registration ASoC: SOF: Intel: Remove IPC flood test support in SOF core ASoC: SOF: sof-client: Add client APIs to access probes ops ASoC: SOF: compress: move and export sof_probe_compr_ops ASoC: SOF: Add new client driver for probes support ASoC: SOF: Intel: CNL: register probes client Documentation/driver-api/auxiliary_bus.rst | 228 ++++++++++ Documentation/driver-api/index.rst | 1 + drivers/base/Kconfig | 3 + drivers/base/Makefile | 1 + drivers/base/auxiliary.c | 267 ++++++++++++ include/linux/auxiliary_bus.h | 78 ++++ include/linux/mod_devicetable.h | 8 + scripts/mod/devicetable-offsets.c | 3 + scripts/mod/file2alias.c | 8 + sound/soc/sof/Kconfig | 47 ++- sound/soc/sof/Makefile | 10 +- sound/soc/sof/compress.c | 60 +-- sound/soc/sof/compress.h | 1 + sound/soc/sof/core.c | 18 +- sound/soc/sof/debug.c | 457 --------------------- sound/soc/sof/intel/Kconfig | 9 + sound/soc/sof/intel/Makefile | 3 + sound/soc/sof/intel/apl.c | 16 + sound/soc/sof/intel/bdw.c | 16 + sound/soc/sof/intel/byt.c | 20 + sound/soc/sof/intel/cnl.c | 32 ++ sound/soc/sof/intel/hda-dai.c | 27 -- sound/soc/sof/intel/hda.h | 6 - sound/soc/sof/intel/intel-client.c | 40 ++ sound/soc/sof/intel/intel-client.h | 26 ++ sound/soc/sof/ops.h | 14 + sound/soc/sof/pcm.c | 11 - sound/soc/sof/probe.c | 124 +++--- sound/soc/sof/probe.h | 41 +- sound/soc/sof/sof-client.c | 170 ++++++++ sound/soc/sof/sof-client.h | 91 ++++ sound/soc/sof/sof-ipc-test-client.c | 321 +++++++++++++++ sound/soc/sof/sof-priv.h | 23 +- sound/soc/sof/sof-probes-client.c | 414 +++++++++++++++++++ 34 files changed, 1968 insertions(+), 626 deletions(-) create mode 100644 Documentation/driver-api/auxiliary_bus.rst create mode 100644 drivers/base/auxiliary.c create mode 100644 include/linux/auxiliary_bus.h create mode 100644 sound/soc/sof/intel/intel-client.c create mode 100644 sound/soc/sof/intel/intel-client.h create mode 100644 sound/soc/sof/sof-client.c create mode 100644 sound/soc/sof/sof-client.h create mode 100644 sound/soc/sof/sof-ipc-test-client.c create mode 100644 sound/soc/sof/sof-probes-client.c -- 2.26.2

9 33

[PATCH 00/15] alsa-gobject: seq: enhancement for error reporting
by GitHub pull_request - opened 15 Nov '20

15 Nov '20

alsa-project/alsa-gobject pull request #50 was opened from takaswie: The patchset is the part of work about #47. Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error. This patchset enhances error reporting. The library-wide error domain is obsoleted. A new error domain is added just for ALSASeq.UserClient. The error domain delivers information about the cause of error. ``` Takashi Sakamoto (15): seq: skip check of return value from g_malloc() seq: check whether method argument for GError is available seq: add checks for method arguments seq: user_client: just return when character device is not opened seq: add GLib enumeration to report type of error for ALSASeq.UserClient seq: user_client: add GQuark to report error for ALSASeq.UserClient seq: user_client: report error for ioctl seq: user_client: report open/write error seq: user_client: report error for port access permission seq: user_client: report error for queue access permission seq: user_client: update function comment for error reporting seq: query: use GFileError to report error seq: query: code refactoring to unify code to open file descriptor seq: query: code refactoring for error path seq: obsolete library-wide error quark src/seq/alsaseq-enum-types.h | 14 ++ src/seq/alsaseq.map | 5 + src/seq/client-info.c | 20 +- src/seq/event-cntr.c | 341 +++++++++++++++++---------------- src/seq/privates.h | 6 - src/seq/query.c | 356 +++++++++++++++-------------------- src/seq/queue-status.c | 4 + src/seq/queue-tempo.c | 4 + src/seq/queue-timer.c | 4 + src/seq/remove-filter.c | 42 ++--- src/seq/user-client.c | 275 ++++++++++++++++++--------- src/seq/user-client.h | 4 + tests/alsaseq-enums | 7 + 13 files changed, 566 insertions(+), 516 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/50 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/50.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0