October 2020 - Alsa-devel - mailman.alsa-project.org

src/dlmisc.c:snd_dlpath_unlock() doesn't build if DL_ORIGIN_AVAILABLE is not defined
by GitHub issues - opened 22 Oct '20

22 Oct '20

alsa-project/alsa-lib issue #91 was opened from ollieparanoid: Hey all, thanks for maintaining alsa. In musl libc based Alpine Linux, the build of v1.2.4 fails with: ``` dlmisc.c:95:7: error: 'snd_plugin_dir_set' undeclared (first use in this function) 95 | if (!snd_plugin_dir_set) { | ^~~~~~~~~~~~~~~~~~ dlmisc.c:95:7: note: each undeclared identifier is reported only once for each function it appears in dlmisc.c:98:4: error: 'snd_plugin_dir' undeclared (first use in this function) 98 | snd_plugin_dir = strdup(env); | ``` This is a regression from https://github.com/alsa-project/alsa-lib/commit/8580c081c25678d11278efcb61b…, where the #ifdef...#else...#endif was removed. Issue URL : https://github.com/alsa-project/alsa-lib/issues/91 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Context expectations in ALSA
by Maxime Ripard 22 Oct '20

22 Oct '20

Hi! We currently have an issue reported by lockdep on the RaspberryPi and its HDMI audio output where, at startup, we end up scheduling in atomic context. This is caused by the HDMI driver polling some status bit that reports that the infoframes have been properly sent, and calling usleep_range between each iteration[1], and that is done in our trigger callback that seems to be run with a spinlock taken and the interrupt disabled (snd_pcm_action_lock_irq) as part of snd_pcm_start_lock_irq. This is the entire stack trace: # aplay --channels=2 -D 'iec958:CARD=vc4hdmi0,DEV=0' /root/test-tone.wav Playing WAVE '/root/test-tone.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo [ 14.732730] BUG: sleeping function called from invalid context at drivers/gpu/drm/vc4/vc4_hdmi.c:276 [ 14.742005] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 140, name: aplay [ 14.749955] CPU: 0 PID: 140 Comm: aplay Not tainted 5.9.0-rc5-v7l+ #66 [ 14.756578] Hardware name: BCM2711 [ 14.760026] Backtrace: [ 14.762524] [<c020d250>] (dump_backtrace) from [<c020d5f4>] (show_stack+0x20/0x24) [ 14.770209] r7:c167c9e4 r6:600e0093 r5:00000000 r4:c167c9e4 [ 14.775960] [<c020d5d4>] (show_stack) from [<c0703164>] (dump_stack+0xb8/0xd8) [ 14.783297] [<c07030ac>] (dump_stack) from [<c025108c>] (___might_sleep+0x138/0x17c) [ 14.791159] r10:00000084 r9:f0979b00 r8:c10ffd50 r7:00000010 r6:00000000 r5:00000114 [ 14.799105] r4:c10fe000 r3:600e0093 [ 14.802736] [<c0250f54>] (___might_sleep) from [<c0251140>] (__might_sleep+0x70/0xb0) [ 14.810680] r4:c0e8f5f4 [ 14.813256] [<c02510d0>] (__might_sleep) from [<c0840724>] (vc4_hdmi_stop_packet+0x120/0x330) [ 14.821907] r6:ef21f280 r5:00000003 r4:73e746f9 [ 14.826598] [<c0840604>] (vc4_hdmi_stop_packet) from [<c084422c>] (vc4_hdmi_write_infoframe+0x140/0x5d0) [ 14.836220] r9:f0979b00 r8:c10ffd50 r7:ef219900 r6:ef248840 r5:00000000 r4:ef21f280 [ 14.844084] [<c08440ec>] (vc4_hdmi_write_infoframe) from [<c0844718>] (vc4_hdmi_set_audio_infoframe+0x5c/0x80) [ 14.854236] r10:efac7738 r9:ef3ea240 r8:00000001 r7:ef219900 r6:ef248840 r5:ef21f040 [ 14.862180] r4:ef21f280 [ 14.864756] [<c08446bc>] (vc4_hdmi_set_audio_infoframe) from [<c0844774>] (vc4_hdmi_audio_trigger+0x38/0x238) [ 14.874815] r4:00000001 [ 14.877392] [<c084473c>] (vc4_hdmi_audio_trigger) from [<c0a155f0>] (snd_soc_pcm_dai_trigger+0x64/0xcc) [ 14.886923] r5:efac5a00 r4:00000000 [ 14.890555] [<c0a1558c>] (snd_soc_pcm_dai_trigger) from [<c0a18c70>] (soc_pcm_trigger+0x70/0xac) [ 14.899472] r9:ef3ea240 r8:c1133540 r7:00000003 r6:ef219900 r5:ef219900 r4:00000001 [ 14.907336] [<c0a18c00>] (soc_pcm_trigger) from [<c09fbd84>] (snd_pcm_do_start+0x3c/0x40) [ 14.915633] r5:c0c749dc r4:00000000 [ 14.919264] [<c09fbd48>] (snd_pcm_do_start) from [<c09fa390>] (snd_pcm_action_single+0x48/0x88) [ 14.928094] [<c09fa348>] (snd_pcm_action_single) from [<c09fc830>] (snd_pcm_action+0x6c/0x78) [ 14.936746] r7:00000003 r6:c0c749dc r5:00000000 r4:ef219900 [ 14.942493] [<c09fc7c4>] (snd_pcm_action) from [<c09fd7ec>] (snd_pcm_action_lock_irq+0x38/0x50) [ 14.951320] r7:00000030 r6:00000003 r5:c0c749dc r4:ef219900 [ 14.957069] [<c09fd7b4>] (snd_pcm_action_lock_irq) from [<c09ffd2c>] (snd_pcm_ioctl+0x930/0x14e4) [ 14.966073] r7:00000030 r6:00000000 r5:0085ee60 r4:ef219900 [ 14.971823] [<c09ff3fc>] (snd_pcm_ioctl) from [<c043accc>] (sys_ioctl+0xe4/0x9e4) [ 14.979420] r10:efac7738 r9:00000004 r8:c1133540 r7:0085ee60 r6:00005624 r5:c1133540 [ 14.987364] r4:00004142 [ 14.989940] [<c043abe8>] (sys_ioctl) from [<c0200040>] (ret_fast_syscall+0x0/0x28) [ 14.997621] Exception stack(0xc10fffa8 to 0xc10ffff0) [ 15.002749] ffa0: 00869260 b6fa8000 00000004 00004142 0085ee60 00000001 [ 15.011050] ffc0: 00869260 b6fa8000 00005624 00000036 00000000 00000000 00001589 00001589 [ 15.019350] ffe0: b6fa8504 bedb59fc b6f2ff68 b6da515c [ 15.024479] r10:00000036 r9:c10fe000 r8:c0200204 r7:00000036 r6:00005624 r5:b6fa8000 [ 15.032423] r4:00869260 We could switch to a udelay instead, but the idea of busy-waiting for up to a 100ms while having the interrupt disabled doesn't sound ideal either. It looks like the snd_soc_dai_link structure has a nonatomic flag that seems to be made to address more or less that issue, taking a mutex instead of a spinlock. However setting that flag results in another lockdep issue, since the dmaengine controller doing the DMA transfer would call snd_pcm_period_elapsed on completion, in a tasklet, this time taking a mutex in an atomic context which is just as bad as the initial issue. This is the stacktrace this time: # aplay --channels=2 -D 'iec958:CARD=vc4hdmi0,DEV=0' /root/test-tone.wav Playing WAVE '/root/test-tone.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo [ 43.078900] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:281 [ 43.087485] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/0 [ 43.095452] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.9.0-rc5-v7l+ #67 [ 43.102252] Hardware name: BCM2711 [ 43.105701] Backtrace: [ 43.108199] [<c020d250>] (dump_backtrace) from [<c020d5f4>] (show_stack+0x20/0x24) [ 43.115884] r7:c167c9e4 r6:600e0113 r5:00000000 r4:c167c9e4 [ 43.121636] [<c020d5d4>] (show_stack) from [<c0703164>] (dump_stack+0xb8/0xd8) [ 43.128972] [<c07030ac>] (dump_stack) from [<c025108c>] (___might_sleep+0x138/0x17c) [ 43.136833] r10:c1600000 r9:00000006 r8:00000000 r7:c1601d70 r6:00000000 r5:00000119 [ 43.144777] r4:c1600000 r3:600e0113 [ 43.148409] [<c0250f54>] (___might_sleep) from [<c0251140>] (__might_sleep+0x70/0xb0) [ 43.156353] r4:c0e32994 [ 43.158930] [<c02510d0>] (__might_sleep) from [<c0baf508>] (mutex_lock+0x2c/0x74) [ 43.166524] r6:efbfaa84 r5:ef26f548 r4:ef219998 [ 43.171216] [<c0baf4dc>] (mutex_lock) from [<c09fa82c>] (_snd_pcm_stream_lock_irqsave+0x2c/0x40) [ 43.180130] r5:ef26f548 r4:ef219900 [ 43.183765] [<c09fa800>] (_snd_pcm_stream_lock_irqsave) from [<c0a03848>] (snd_pcm_period_elapsed+0x20/0xa4) [ 43.193743] [<c0a03828>] (snd_pcm_period_elapsed) from [<c0a067d4>] (dmaengine_pcm_dma_complete+0x54/0x58) [ 43.203539] r7:c1601d70 r6:efbfaa84 r5:ef26f548 r4:00000000 [ 43.209290] [<c0a06780>] (dmaengine_pcm_dma_complete) from [<c07885e8>] (vchan_complete+0x238/0x240) [ 43.218567] [<c07883b0>] (vchan_complete) from [<c0228f9c>] (tasklet_action_common.constprop.0+0x84/0x12c) [ 43.228365] r10:c1600000 r9:00000006 r8:00000000 r7:dac802e0 r6:efbfaa84 r5:00000000 [ 43.236309] r4:efbfaa80 [ 43.238886] [<c0228f18>] (tasklet_action_common.constprop.0) from [<c022906c>] (tasklet_action+0x28/0x30) [ 43.248596] r9:00000040 r8:ef80b800 r7:00000101 r6:00000006 r5:00000007 r4:c1603098 [ 43.256459] [<c0229044>] (tasklet_action) from [<c0201284>] (__do_softirq+0x18c/0x47c) [ 43.264498] [<c02010f8>] (__do_softirq) from [<c0228de4>] (irq_exit+0xd0/0xf8) [ 43.271829] r10:c1051f40 r9:c1600000 r8:ef80b800 r7:00000001 r6:00000000 r5:00000000 [ 43.279774] r4:ffffe000 [ 43.282349] [<c0228d14>] (irq_exit) from [<c0287c54>] (__handle_domain_irq+0x70/0xc0) [ 43.290294] r5:00000000 r4:c148ee80 [ 43.293927] [<c0287be4>] (__handle_domain_irq) from [<c071d8b4>] (gic_handle_irq+0x4c/0x88) [ 43.302403] r9:c1600000 r8:c1601ed0 r7:f0803000 r6:f0802000 r5:f080200c r4:c16058d8 [ 43.310266] [<c071d868>] (gic_handle_irq) from [<c0200abc>] (__irq_svc+0x5c/0x7c) [ 43.317856] Exception stack(0xc1601ed0 to 0xc1601f18) [ 43.322983] 1ec0: c0208b84 00000000 19bf8000 600e0093 [ 43.331283] 1ee0: c1600000 00000000 c1604e34 c1604e7c c16d20e5 c0e30cac c1051f40 c1601f2c [ 43.339582] 1f00: ffffe000 c1601f20 c1600000 c0208b88 600e0013 ffffffff [ 43.346297] r9:c1600000 r8:c16d20e5 r7:c1601f04 r6:ffffffff r5:600e0013 r4:c0208b88 [ 43.354164] [<c0208b54>] (arch_cpu_idle) from [<c0bb23c8>] (default_idle_call+0x3c/0x184) [ 43.362469] [<c0bb238c>] (default_idle_call) from [<c025b5f8>] (do_idle+0x110/0x170) [ 43.370327] r5:00000000 r4:c1600000 [ 43.373958] [<c025b4e8>] (do_idle) from [<c025b950>] (cpu_startup_entry+0x28/0x2c) [ 43.381641] r9:00000193 r8:effff900 r7:c1604e00 r6:00000000 r5:c160ec50 r4:000000d7 [ 43.389503] [<c025b928>] (cpu_startup_entry) from [<c0baa65c>] (rest_init+0x108/0x110) [ 43.397542] [<c0baa554>] (rest_init) from [<c1000cc8>] (arch_call_rest_init+0x18/0x1c) [ 43.405575] r5:c1051f40 r4:c16e7078 [ 43.409205] [<c1000cb0>] (arch_call_rest_init) from [<c1001538>] (start_kernel+0x7f4/0x834) [ 43.417682] [<c1000d44>] (start_kernel) from [<00000000>] (0x0) So, I'm not really sure what I'm supposed to do here. The drivers involved don't appear to be doing anything extraordinary, but the issues lockdep report are definitely valid too. What are the expectations in terms of context from ALSA when running the callbacks, and how can we fix it? Thanks! Maxime 1: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri…

4 7

[PATCH v2 0/5] ASoC: Mediatek: Add support for MT8192 SoC
by Jiaxin Yu 22 Oct '20

22 Oct '20

This series of patches adds support for Mediatek AFE for MT8192 SoC. At the same time, the calibration function of MT6359 is completed with real machine driver. The patch is based on broonie tree "for-next" branch. Change since v1: - fixed some typos related to dt-bindings in [v1,3/5] and [v1,5/5] - add vendor prefix to the properties, such as "mediatek,apmixedsys" - add a dependency description to indicate the required header files Jiaxin Yu (5): ASoC: mediatek: mt6359: add the calibration functions ASoC: mediatek: mt8192: add platform driver dt-bindings: mediatek: mt8192: add audio afe document ASoC: mediatek: mt8192: add machine driver with mt6359, rt1015 and rt5682 dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document .../bindings/sound/mt8192-afe-pcm.yaml | 103 + .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 42 + sound/soc/codecs/mt6359.c | 110 + sound/soc/codecs/mt6359.h | 7 + sound/soc/mediatek/Kconfig | 23 + sound/soc/mediatek/Makefile | 1 + sound/soc/mediatek/common/mtk-afe-fe-dai.c | 13 +- sound/soc/mediatek/common/mtk-base-afe.h | 1 + sound/soc/mediatek/mt8192/Makefile | 16 + sound/soc/mediatek/mt8192/mt8192-afe-clk.c | 669 ++++ sound/soc/mediatek/mt8192/mt8192-afe-clk.h | 244 ++ sound/soc/mediatek/mt8192/mt8192-afe-common.h | 170 + .../soc/mediatek/mt8192/mt8192-afe-control.c | 163 + sound/soc/mediatek/mt8192/mt8192-afe-gpio.c | 306 ++ sound/soc/mediatek/mt8192/mt8192-afe-gpio.h | 19 + sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 2389 +++++++++++++ sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 1489 ++++++++ sound/soc/mediatek/mt8192/mt8192-dai-i2s.c | 2139 +++++++++++ sound/soc/mediatek/mt8192/mt8192-dai-pcm.c | 409 +++ sound/soc/mediatek/mt8192/mt8192-dai-tdm.c | 778 ++++ .../mediatek/mt8192/mt8192-interconnection.h | 65 + .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 1058 ++++++ sound/soc/mediatek/mt8192/mt8192-reg.h | 3131 +++++++++++++++++ 23 files changed, 13341 insertions(+), 4 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml create mode 100644 sound/soc/mediatek/mt8192/Makefile create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-clk.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-clk.h create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-common.h create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-control.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-gpio.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-gpio.h create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-pcm.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-adda.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-i2s.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-pcm.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-tdm.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-interconnection.h create mode 100644 sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c create mode 100644 sound/soc/mediatek/mt8192/mt8192-reg.h -- 2.18.0

3 11

[PATCH v11 0/3] Add documentation and machine driver for SC7180 sound card
by Cheng-Yi Chiang 22 Oct '20

22 Oct '20

Note: - The machine driver patch is made by the collaboration of Cheng-Yi Chiang <cychiang(a)chromium.org> Rohit kumar <rohitkr(a)codeaurora.org> Ajit Pandey <ajitp(a)codeaurora.org> But Ajit has left codeaurora. - This patch series needs HDMI DAI name SC7180_LPASS_DP defined in sc7180-lpass.h. It will be posted in the newer patchset of https://patchwork.kernel.org/patch/11745565/ Changes from v1 to v2: - Ducumentation: Addressed all suggestions from Doug. - Machine driver: - Fix comment style for license. - Sort includes. - Remove sc7180_snd_hw_params. - Remove sc7180_dai_init and use aux device instead for headset jack registration. - Statically define format for Primary MI2S. - Atomic is not a concern because there is mutex in card to make sure startup and shutdown happen sequentially. - Fix missing return -EINVAL in startup. - Use static sound card. - Use devm_kzalloc to avoid kfree. Changes from v2 to v3: - Ducumentation: Addressed suggestions from Srini. - Machine driver: - Reuse qcom_snd_parse_of to parse properties. - Remove playback-only and capture-only. - Misc fixes to address comments. Changes from v3 to v4: - Ducumentation: Addressed suggestions from Rob. - Remove definition of dai. - Use 'sound-dai: true' for sound-dai schema. - Add reg property to pass 'make dt_binding_check' check although reg is not used in the driver. - Machine driver: - Add Reviewed-by: Tzung-Bi Shih <tzungbi(a)google.com> Changes from v4 to v5: - Documentation: Addressed suggestions from Rob. - Add definition for "#address-cells" and "#size-cells". - Add additionalProperties: false - Add required properties. Changes from v5 to v6: - Documentation: Addressed suggestions from Rob. - Drop contains in compatible strings. - Only allow dai-link@[0-9] - Remove reg ref since it has a type definition already. Changes from v6 to v7 - Documentation: - Add headset-jack and hdmi-jack to specify the codec responsible for jack detection. - HDMI codec driver: - Use component set_jack ops instead of exporting hdmi_codec_set_jack_detect. - Machine driver: - Removed aux device following Stephan's suggestion. - Use headset-jack and hdmi-jack to specify the codec responsible for jack detection. - Add support for HDMI(actually DP) playback. Changes from v7 to v8 - Documentation: - Remove headset-jack and hdmi-jack. - Machine driver: - Let machine driver decide whether there is a jack on the DAI. Changes from v8 to v9 - hdmi-codec driver: - Fixed the naming. - Machine driver: - Fixed unused fields. - Moved snd_soc_card_set_drvdata - Keep the naming of HDMI as dai name until v5 of lpass-hdmi patches. Changes from v9 to v10 - Documentation: - Let compatible string be more specific for board configuration to allow for future changes. - Machine driver: - Fixed unused include and macro. - Add temporary macro SC7180_LPASS_DP for future change in sc7180-lpass.h. - Let sound card be dynamically allocated. - Change compatible string accordingly. Changes from v10 to v11 - Machine driver: - Use temporary macro LPASS_DP_RX for future change in sc7180-lpass.h. Ajit Pandey (1): ASoC: qcom: sc7180: Add machine driver for sound card registration Cheng-Yi Chiang (2): ASoC: hdmi-codec: Use set_jack ops to set jack ASoC: qcom: dt-bindings: Add sc7180 machine bindings .../bindings/sound/qcom,sc7180.yaml | 130 +++++++++ include/sound/hdmi-codec.h | 3 - sound/soc/codecs/hdmi-codec.c | 12 +- sound/soc/mediatek/mt8173/mt8173-rt5650.c | 5 +- .../mediatek/mt8183/mt8183-da7219-max98357.c | 5 +- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 5 +- sound/soc/qcom/Kconfig | 12 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sc7180.c | 266 ++++++++++++++++++ sound/soc/rockchip/rockchip_max98090.c | 3 +- 10 files changed, 421 insertions(+), 22 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml create mode 100644 sound/soc/qcom/sc7180.c -- 2.28.0.618.gf4bc123cb7-goog

5 21

Fix muted output and low ouput/input volume on a Dell Latitude 3410
by GitHub pull_request - opened 22 Oct '20

22 Oct '20

alsa-project/alsa-ucm-conf pull request #56 was opened from J-Bu: Using following environment on a Dell Latitude 3410 results in muted master channel and low output/input volume: - alsa-libs 1.2.4 - alsa-ucm-conf 1.2.4 - alsa-topology-conf 1.2.4 - alsa-utils 1.2.4 - kernel 5.9.1 -> with commit 3dca35e applied on top of it - sof-bin v1.6 The propused changes fixes the problem for me. I don't know why but the given values are not 1:1 mapped to levels in alsamixer, please see attached iamges for alsamixer levels before and after the change, the alsamixer levels where captured after running "alsactl init": before: ![before](https://user-images.githubusercontent.com/15876551/96853514-bf0f5f80-145a-11eb-9c7f-751834a56491.png) after: ![after](https://user-images.githubusercontent.com/15876551/96853530-c46caa00-145a-11eb-9057-5399382d195d.png) Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/56 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/56.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

How to downmix 5.1 and 7.1 channels to 2 channels
by Amanda Ava Koci Pereira 22 Oct '20

22 Oct '20

Hi guys... We need some clues about to downmix 5.1 and 7.1 channels to 2 channels for the moment we are using the following code -> It works but fails miserably if all channels have data at same time #define AR_K_P_ATTENUATION_LEVEL 1.0 int p = 0; int i; int save_channel_0_k_p; int save_channel_1_k_p; double save_channel_0_data_double_k_p; double save_channel_1_data_double_k_p; double sample_double_temp_k_p; int number_of_samples_k_p = decoded_frame->nb_samples; int ricardo_deslocador__ = 0; frame_processed_k_p = 1; int outputBufferLen = number_of_samples_k_p * 2 * 2; *size_out=outputBufferLen; short *outputBuffer = (int16_t *)buf; int16_t * ar_buffer_ = (int16_t *) decoded_frame->data[0]; for(i=0; i < number_of_samples_k_p; i++) { //channel 0 int16_t sample_k_p = ar_buffer_[ricardo_deslocador__++]; save_channel_0_k_p = p; save_channel_0_data_double_k_p = (double) sample_k_p; p++; /////////////////////////////////////////////// //channel 1 sample_k_p = ar_buffer_[ricardo_deslocador__++]; save_channel_1_k_p = p;//so usa no final... save_channel_1_data_double_k_p = (double) sample_k_p; p++; //////////////////////////////////////////////// //center sample_k_p = ar_buffer_[ricardo_deslocador__++]; sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_0_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = -32768.0; } sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_1_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = -32768.0; } ////////////////////////////////////////////////////// ///////subwoffer sample_k_p = ar_buffer_[ricardo_deslocador__++]; sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_0_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = -32768.0; } sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_1_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = -32768.0; } //////////////////////////////////////////////////// /////surround left 4 sample_k_p = ar_buffer_[ricardo_deslocador__++]; sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_0_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_0_data_double_k_p) { save_channel_0_data_double_k_p = -32768.0; } /////////////////////////////////////////////// //////////surround right 5 sample_k_p = ar_buffer_[ricardo_deslocador__++]; sample_double_temp_k_p = (double) sample_k_p; sample_double_temp_k_p *= AR_K_P_ATTENUATION_LEVEL; save_channel_1_data_double_k_p += sample_double_temp_k_p; if(32767.0 < save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = 32767.0; } if(-32768.0 > save_channel_1_data_double_k_p) { save_channel_1_data_double_k_p = -32768.0; } ///////////////////////////////////////////// //finalizing outputBuffer[save_channel_0_k_p] = (signed short) save_channel_0_data_double_k_p; outputBuffer[save_channel_1_k_p] = (signed short) save_channel_1_data_double_k_p; } /* if possible point us to the files in ALSA that make the downmix and it will be enough Thanks a lot */ Ricardo

2 2

[PATCH] ALSA: hda - Fix the return value if cb func is already registered
by Hui Wang 22 Oct '20

22 Oct '20

If the cb function is already registered, should return the pointer of the structure hda_jack_callback which contains this cb func, but instead it returns the NULL. Now fix it by replacing func_is_already_in_callback_list() with find_callback_from_list(). Fixes: f4794c6064a8 ("ALSA:hda - Don't register a cb func if it is registered already") Reported-and-suggested-by: Dan Carpenter <dan.carpenter(a)oracle.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/hda_jack.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/sound/pci/hda/hda_jack.c b/sound/pci/hda/hda_jack.c index ded4813f8b54..588059428d8f 100644 --- a/sound/pci/hda/hda_jack.c +++ b/sound/pci/hda/hda_jack.c @@ -275,16 +275,21 @@ int snd_hda_jack_detect_state_mst(struct hda_codec *codec, } EXPORT_SYMBOL_GPL(snd_hda_jack_detect_state_mst); -static bool func_is_already_in_callback_list(struct hda_jack_tbl *jack, - hda_jack_callback_fn func) +static struct hda_jack_callback * +find_callback_from_list(struct hda_jack_tbl *jack, + hda_jack_callback_fn func) { struct hda_jack_callback *cb; + if (!func) + return NULL; + for (cb = jack->callback; cb; cb = cb->next) { if (cb->func == func) - return true; + return cb; } - return false; + + return NULL; } /** @@ -309,7 +314,10 @@ snd_hda_jack_detect_enable_callback_mst(struct hda_codec *codec, hda_nid_t nid, jack = snd_hda_jack_tbl_new(codec, nid, dev_id); if (!jack) return ERR_PTR(-ENOMEM); - if (func && !func_is_already_in_callback_list(jack, func)) { + + callback = find_callback_from_list(jack, func); + + if (func && !callback) { callback = kzalloc(sizeof(*callback), GFP_KERNEL); if (!callback) return ERR_PTR(-ENOMEM); -- 2.25.1

2 1

PCM link state
by Matt Flax 22 Oct '20

22 Oct '20

Is there a way to check whether PCMs are linked ? Linking is done with snd_pcm_link : https://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gac6c3309… But this is no function to tell if a pcm is linked. Matt

1 0

[bug report] ALSA: hda - Don't register a cb func if it is registered already
by Dan Carpenter 22 Oct '20

22 Oct '20

Hello Hui Wang, The patch f4794c6064a8: "ALSA: hda - Don't register a cb func if it is registered already" from Sep 30, 2020, leads to the following static checker warning: sound/pci/hda/patch_sigmatel.c:3075 stac92hd71bxx_fixup_hp_m4() warn: 'jack' can also be NULL sound/pci/hda/patch_sigmatel.c 3069 /* Enable VREF power saving on GPIO1 detect */ 3070 snd_hda_codec_write_cache(codec, codec->core.afg, 0, 3071 AC_VERB_SET_GPIO_UNSOLICITED_RSP_MASK, 0x02); 3072 jack = snd_hda_jack_detect_enable_callback(codec, codec->core.afg, 3073 stac_vref_event); Originally snd_hda_jack_detect_enable_callback() would not return NULL here. 3074 if (!IS_ERR(jack)) 3075 jack->private_data = 0x02; 3076 3077 spec->gpio_mask |= 0x02; But now we have this: sound/pci/hda/hda_jack.c 301 struct hda_jack_callback * 302 snd_hda_jack_detect_enable_callback_mst(struct hda_codec *codec, hda_nid_t nid, 303 int dev_id, hda_jack_callback_fn func) 304 { 305 struct hda_jack_tbl *jack; 306 struct hda_jack_callback *callback = NULL; 307 int err; 308 309 jack = snd_hda_jack_tbl_new(codec, nid, dev_id); 310 if (!jack) 311 return ERR_PTR(-ENOMEM); 312 if (func && !func_is_already_in_callback_list(jack, func)) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ We only allocate callback if there isn't one already. 313 callback = kzalloc(sizeof(*callback), GFP_KERNEL); 314 if (!callback) 315 return ERR_PTR(-ENOMEM); 316 callback->func = func; 317 callback->nid = jack->nid; 318 callback->dev_id = jack->dev_id; 319 callback->next = jack->callback; 320 jack->callback = callback; 321 } 322 323 if (jack->jack_detect) 324 return callback; /* already registered */ ^^^^^^^^^^^^^^^ So presumably this should be jack->callback 325 jack->jack_detect = 1; 326 if (codec->jackpoll_interval > 0) 327 return callback; /* No unsol if we're polling instead */ ^^^^^^^^^^^^^^^^ 328 err = snd_hda_codec_write_cache(codec, nid, 0, 329 AC_VERB_SET_UNSOLICITED_ENABLE, 330 AC_USRSP_EN | jack->tag); 331 if (err < 0) 332 return ERR_PTR(err); 333 return callback; ^^^^^^^^^^^^^^^^ And these as well. 334 } regards, dan carpenter

3 6

[PATCH v3 0/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation
by Kuninori Morimoto 22 Oct '20

22 Oct '20

Hi Rob, Mark Cc: Sameer These are v3 of switch to yaml base Documentation for audio-graph-card and renesas,rsnd which uses audio-graph-card. v2 -> v3 - fixuped Rob's pointed points v1 -> v2 - upgrade dt-schema, and fixup errors for [2/2] patch Kuninori Morimoto (3): ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation dt-bindings: ASoC: renesas,rsnd: Add r8a77961 support .../bindings/sound/audio-graph-card.txt | 337 ------------ .../bindings/sound/audio-graph-card.yaml | 165 ++++++ .../bindings/sound/renesas,rsnd.txt | 520 ------------------ .../bindings/sound/renesas,rsnd.yaml | 457 +++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 +- 5 files changed, 623 insertions(+), 858 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/audio-graph-card.txt create mode 100644 Documentation/devicetree/bindings/sound/audio-graph-card.yaml create mode 100644 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml -- 2.25.1

1 1