January 2020 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: soc-generic-dmaengine-pcm: Fix error handling
by Shengjiu Wang 21 Jan '20

21 Jan '20

Remove the return value checking, that is to align with the code before adding snd_dmaengine_pcm_refine_runtime_hwparams function. Otherwise it causes a regression on the HiKey board: [ 17.721424] hi6210_i2s f7118000.i2s: ASoC: can't open component f7118000.i2s: -6 Fixes: e957204e732b ("ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Reported-by: John Stultz <john.stultz(a)linaro.org> --- sound/soc/soc-generic-dmaengine-pcm.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index a428ff393ea2..2b5f3b1b062b 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -117,7 +117,6 @@ dmaengine_pcm_set_runtime_hwparams(struct snd_soc_component *component, struct dma_chan *chan = pcm->chan[substream->stream]; struct snd_dmaengine_dai_dma_data *dma_data; struct snd_pcm_hardware hw; - int ret; if (pcm->config && pcm->config->pcm_hardware) return snd_soc_set_runtime_hwparams(substream, @@ -138,12 +137,15 @@ dmaengine_pcm_set_runtime_hwparams(struct snd_soc_component *component, if (pcm->flags & SND_DMAENGINE_PCM_FLAG_NO_RESIDUE) hw.info |= SNDRV_PCM_INFO_BATCH; - ret = snd_dmaengine_pcm_refine_runtime_hwparams(substream, - dma_data, - &hw, - chan); - if (ret) - return ret; + /** + * FIXME: Remove the return value check to align with the code + * before adding snd_dmaengine_pcm_refine_runtime_hwparams + * function. + */ + snd_dmaengine_pcm_refine_runtime_hwparams(substream, + dma_data, + &hw, + chan); return snd_soc_set_runtime_hwparams(substream, &hw); } -- 2.21.0

2 1

[alsa-devel] [PATCH v2 00/17] ASoC: remove DAI suspend/resume
by Kuninori Morimoto 21 Jan '20

21 Jan '20

Hi Mark This is v2 of "remove DAI suspend/resume" patch set. The difference is it has [17/17] patch, instead of previous [17/16] :) Kuninori Morimoto (17): 1) ASoC: atmel: atmel_ssc_dai: move .suspend/.resume to component 2) ASoC: bcm: cygnus-ssp: move .suspend/.resume to component 3) ASoC: cirrus: ep93xx-i2s: move .suspend/.resume to component 4) ASoC: jz4740: jz4740-i2s: move .suspend/.resume to component 5) ASoC: mediatek: move .suspend/.resume to component 6) ASoC: samsung: s3c24xx-i2s: move .suspend/.resume to component 7) ASoC: samsung: spdif: move .suspend/.resume to component 8) ASoC: sti: sti_uniperif: move .suspend/.resume to component 9) ASoC: ti: omap-mcpdm: move .suspend/.resume to component 10) ASoC: uniphier: move .suspend/.resume to component 11) ASoC: dwc: dwc-i2s: move .suspend/.resume to component 12) ASoC: samsung: i2s: move .suspend/.resume to component 13) ASoC: ux500: ux500_msp_dai: remove unused DAI .suspend/.resume 14) ASoC: pxa: pxa-ssp: move .suspend/.resume to component 15) ASoC: pxa: pxa2xx-i2s: move .suspend/.resume to component 16) ASoC: soc-core: remove DAI suspend/resume 17) ASoC: soc-core: remove bus_control include/sound/soc-dai.h | 3 -- sound/soc/atmel/atmel_ssc_dai.c | 18 ++++----- sound/soc/au1x/ac97c.c | 1 - sound/soc/au1x/psc-ac97.c | 1 - sound/soc/bcm/cygnus-ssp.c | 39 +++++++++++++++--- sound/soc/cirrus/ep93xx-ac97.c | 1 - sound/soc/cirrus/ep93xx-i2s.c | 16 ++++---- sound/soc/dwc/dwc-i2s.c | 32 ++++++++------- sound/soc/fsl/fsl_ssi.c | 1 - sound/soc/fsl/imx-ssi.c | 1 - sound/soc/fsl/mpc5200_psc_ac97.c | 2 - sound/soc/jz4740/jz4740-i2s.c | 18 ++++----- sound/soc/mediatek/common/mtk-afe-fe-dai.c | 12 +++--- sound/soc/mediatek/common/mtk-afe-fe-dai.h | 4 +- sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 14 +------ sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 10 ++--- sound/soc/pxa/pxa-ssp.c | 16 ++++---- sound/soc/pxa/pxa2xx-ac97.c | 3 -- sound/soc/pxa/pxa2xx-i2s.c | 12 +++--- sound/soc/samsung/i2s.c | 13 +++--- sound/soc/samsung/s3c24xx-i2s.c | 8 ++-- sound/soc/samsung/spdif.c | 18 ++++++--- sound/soc/sh/hac.c | 1 - sound/soc/soc-core.c | 65 ++---------------------------- sound/soc/soc-dai.c | 12 ------ sound/soc/sti/sti_uniperif.c | 12 +++--- sound/soc/tegra/tegra20_ac97.c | 1 - sound/soc/ti/omap-mcpdm.c | 16 ++++---- sound/soc/txx9/txx9aclc-ac97.c | 1 - sound/soc/uniphier/aio-cpu.c | 31 ++++++++++++-- sound/soc/uniphier/aio-ld11.c | 18 --------- sound/soc/uniphier/aio-pxs2.c | 14 ------- sound/soc/uniphier/aio.h | 2 - sound/soc/ux500/ux500_msp_dai.c | 2 - 34 files changed, 170 insertions(+), 248 deletions(-) -- 2.7.4

3 35

[alsa-devel] [PATCH 0/3] ASoC: max98090: fix lock issues
by Tzung-Bi Shih 21 Jan '20

21 Jan '20

The 1st patch reverts an already merged patch which makes less sense. (https://mailman.alsa-project.org/pipermail/alsa-devel/2020-January/161172.h…) The 3rd patch uses the function introduced from the 2nd patch to fix a deadlock issue. I wasn't aware of the deadlock issue because my test environment doesn't change the MUX. Could be manually tested by something like: `amixer -c1 cset name='LTENL Mux' 0`. Tzung-Bi Shih (3): ASoC: max98090: revert "ASoC: max98090: fix lockdep warning" ASoC: dapm: add snd_soc_dapm_put_enum_double_locked ASoC: max98090: fix deadlock in max98090_dapm_put_enum_double() include/sound/soc-dapm.h | 2 ++ sound/soc/codecs/max98090.c | 12 ++++----- sound/soc/codecs/max98090.h | 1 - sound/soc/soc-dapm.c | 54 ++++++++++++++++++++++++++++--------- 4 files changed, 48 insertions(+), 21 deletions(-) -- 2.25.0.341.g760bfbb309-goog

2 6

[alsa-devel] Applied "ASoC: dt-bindings: rt5645: add suppliers" to the asoc tree
by Mark Brown 21 Jan '20

21 Jan '20

The patch ASoC: dt-bindings: rt5645: add suppliers has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 26aa19174f0d1837cb268b744f6dcb013265ab03 Mon Sep 17 00:00:00 2001 From: Matthias Brugger <matthias.bgg(a)gmail.com> Date: Tue, 14 Jan 2020 16:01:50 +0100 Subject: [PATCH] ASoC: dt-bindings: rt5645: add suppliers The rt5645 and rt5650 have two suppliers, document them. Signed-off-by: Matthias Brugger <matthias.bgg(a)gmail.com> Link: https://lore.kernel.org/r/20200114150151.8537-1-matthias.bgg@kernel.org Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Documentation/devicetree/bindings/sound/rt5645.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5645.txt b/Documentation/devicetree/bindings/sound/rt5645.txt index a03f9a872a71..41a62fd2ae1f 100644 --- a/Documentation/devicetree/bindings/sound/rt5645.txt +++ b/Documentation/devicetree/bindings/sound/rt5645.txt @@ -10,6 +10,10 @@ Required properties: - interrupts : The CODEC's interrupt output. +- avdd-supply: Power supply for AVDD, providing 1.8V. + +- cpvdd-supply: Power supply for CPVDD, providing 3.5V. + Optional properties: - hp-detect-gpios: -- 2.20.1

1 0

Re: [alsa-devel] KASAN: use-after-free Read in ccid_hc_tx_delete
by syzbot 21 Jan '20

21 Jan '20

syzbot has bisected this bug to: commit f04684b4d85d6371126f476d3268ebf6a0bd57cf Author: Dan Carpenter <dan.carpenter(a)oracle.com> Date: Thu Jun 21 08:07:21 2018 +0000 ALSA: lx6464es: Missing error code in snd_lx6464es_create() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10dd11cae00000 start commit: eb6cf9f8 Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream final crash: https://syzkaller.appspot.com/x/report.txt?x=12dd11cae00000 console output: https://syzkaller.appspot.com/x/log.txt?x=14dd11cae00000 kernel config: https://syzkaller.appspot.com/x/.config?x=c8970c89a0efbb23 dashboard link: https://syzkaller.appspot.com/bug?extid=3967c1caf256f4d5aefe syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11022ccd400000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=124581db400000 Reported-by: syzbot+3967c1caf256f4d5aefe(a)syzkaller.appspotmail.com Fixes: f04684b4d85d ("ALSA: lx6464es: Missing error code in snd_lx6464es_create()") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

2 2

[alsa-devel] [PATCH v2 0/9] x86: Easy way of detecting MS Surface 3
by Andy Shevchenko 21 Jan '20

21 Jan '20

While working on RTC regression, I noticed that we are using the same DMI check over and over in the drivers for MS Surface 3 platform. This series dedicated for making it easier in the same way how it's done for Apple machines. Changelog v2: - removed RTC patches for now - added couple more clean ups to arch/x86/kernel/quirks.c - redone DMI quirk to use driver_data instead of callback - simplified check in soc-acpi-intel-cht-match.c to be oneliner - added a new patch to cover rt5645 codec driver Cc: Cezary Rojewski <cezary.rojewski(a)intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Cc: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> Cc: Jie Yang <yang.jie(a)linux.intel.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: alsa-devel(a)alsa-project.org Andy Shevchenko (9): x86/platform: Rename x86/apple.h -> x86/machine.h x86/quirks: Add missed include to satisfy static checker x86/quirks: Introduce hpet_dev_print_force_hpet_address() helper x86/quirks: Join string literals back x86/quirks: Convert DMI matching to use a table x86/quirks: Add a DMI quirk for Microsoft Surface 3 platform/x86: surface3_wmi: Switch DMI table match to a test of variable ASoC: rt5645: Switch DMI table match to a test of variable ASoC: Intel: Switch DMI table match to a test of variable arch/x86/kernel/quirks.c | 91 +++++++++++++------ drivers/platform/x86/surface3-wmi.c | 16 +--- include/linux/platform_data/x86/apple.h | 14 +-- include/linux/platform_data/x86/machine.h | 20 ++++ sound/soc/codecs/rt5645.c | 14 ++- .../intel/common/soc-acpi-intel-cht-match.c | 33 +------ 6 files changed, 93 insertions(+), 95 deletions(-) create mode 100644 include/linux/platform_data/x86/machine.h -- 2.24.1

2 6

[alsa-devel] Format string warnings on 32 bit platforms
by Rolf Eike Beer 21 Jan '20

21 Jan '20

The first ones can be fixed by either casting to "unsigned long long" and using that specifier or using the proper format specifiers from inttypes.h Greetings, Eike container.c: In function 'container_context_pre_process': container.c:359:33: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] 359 | fprintf(stderr, " frames: %lu\n", | ~~^ | | | long unsigned int | %llu 360 | *frame_count); | ~~~~~~~~~~~~ | | | uint64_t {aka long long unsigned int} container.c:362:37: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] 362 | fprintf(stderr, " max frames: %lu\n", | ~~^ | | | long unsigned int | %llu 363 | *frame_count); | ~~~~~~~~~~~~ | | | uint64_t {aka long long unsigned int} container.c: In function 'container_context_post_process': container.c:430:39: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] 430 | fprintf(stderr, " Handled bytes: %lu\n", | ~~^ | | | long unsigned int | %llu 431 | cntr->handled_byte_count); | ~~~~~~~~~~~~~~~~~~~~~~~~ | | | uint64_t {aka long long unsigned int} subcmd-transfer.c: In function 'context_process_frames': subcmd-transfer.c:392:20: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] 392 | "%s: Expected %lu frames, Actual %lu frames\n", | ~~^ | | | long unsigned int | %llu 393 | snd_pcm_stream_name(direction), expected_frame_count, | ~~~~~~~~~~~~~~~~~~~~ | | | uint64_t {aka long long unsigned int} subcmd-transfer.c:392:39: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] 392 | "%s: Expected %lu frames, Actual %lu frames\n", | ~~^ | | | long unsigned int | %llu 393 | snd_pcm_stream_name(direction), expected_frame_count, 394 | *actual_frame_count); | ~~~~~~~~~~~~~~~~~~~ | | | uint64_t {aka long long unsigned int} alsa.c: In function 'set_snd_pcm_params': ../include/gettext.h:13:25: warning: format '%zd' expects argument of type 'signed size_t', but argument 3 has type 'snd_pcm_uframes_t' {aka 'long unsigned int'} [-Wformat=] 13 | # define gettext(msgid) (msgid) | ^~~~~~~ ../include/gettext.h:18:18: note: in expansion of macro 'gettext' 18 | #define _(msgid) gettext (msgid) | ^~~~~~~ alsa.c:256:21: note: in expansion of macro '_' 256 | fprintf(bat->err, _("period size: %zd %s: %s(%d)\n"), | ^ ../include/gettext.h:13:25: warning: format '%zd' expects argument of type 'signed size_t', but argument 3 has type 'snd_pcm_uframes_t' {aka 'long unsigned int'} [-Wformat=] 13 | # define gettext(msgid) (msgid) | ^~~~~~~ ../include/gettext.h:18:18: note: in expansion of macro 'gettext' 18 | #define _(msgid) gettext (msgid) | ^~~~~~~ alsa.c:265:21: note: in expansion of macro '_' 265 | fprintf(bat->err, _("buffer size: %zd %s: %s(%d)\n"), | ^ ../include/gettext.h:13:25: warning: format '%zd' expects argument of type 'signed size_t', but argument 3 has type 'snd_pcm_uframes_t' {aka 'long unsigned int'} [-Wformat=] 13 | # define gettext(msgid) (msgid) | ^~~~~~~ ../include/gettext.h:18:18: note: in expansion of macro 'gettext' 18 | #define _(msgid) gettext (msgid) | ^~~~~~~ alsa.c:273:21: note: in expansion of macro '_' 273 | fprintf(bat->err, _("equal to buffer size (%zd)\n"), | ^ -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source Besuchen Sie uns auf der Embedded World 2020 in Nürnberg! -> Halle 4, Stand 368

1 0

[alsa-devel] [PATCH 1/2] ALSA: pcm: Set per-card upper limit of PCM buffer allocations
by Takashi Iwai 21 Jan '20

21 Jan '20

Currently, the available buffer allocation size for a PCM stream depends on the preallocated size; when a buffer has been preallocated, the max buffer size is set to that size, so that application won't re-allocate too much memory. OTOH, when no preallocation is done, each substream may allocate arbitrary size of buffers as long as snd_pcm_hardware.buffer_bytes_max allows -- which can be quite high, HD-audio sets 1GB there. It means that the system may consume a high amount of pages for PCM buffers, and they are pinned and never swapped out. This can lead to OOM easily. For avoiding such a situation, this patch adds the upper limit per card. Each snd_pcm_lib_malloc_pages() and _free_pages() calls are tracked and it will return an error if the total amount of buffers goes over the defined upper limit. The default value is set to 32MB, which should be really large enough for usual operations. If larger buffers are needed for any specific usage, it can be adjusted (also dynamically) via snd_pcm.max_alloc_per_card option. Setting zero there means no chceck is performed, and again, unlimited amount of buffers are allowed. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/sound/core.h | 3 +++ sound/core/init.c | 1 + sound/core/pcm_memory.c | 69 ++++++++++++++++++++++++++++++++++++------------- 3 files changed, 55 insertions(+), 18 deletions(-) diff --git a/include/sound/core.h b/include/sound/core.h index 0e14b7a3e67b..ac8b692b69b4 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -120,6 +120,9 @@ struct snd_card { int sync_irq; /* assigned irq, used for PCM sync */ wait_queue_head_t remove_sleep; + size_t total_pcm_alloc_bytes; /* total amount of allocated buffers */ + struct mutex memory_mutex; /* protection for the above */ + #ifdef CONFIG_PM unsigned int power_state; /* power state */ wait_queue_head_t power_sleep; diff --git a/sound/core/init.c b/sound/core/init.c index faa9f03c01ca..b02a99766351 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -211,6 +211,7 @@ int snd_card_new(struct device *parent, int idx, const char *xid, INIT_LIST_HEAD(&card->ctl_files); spin_lock_init(&card->files_lock); INIT_LIST_HEAD(&card->files_list); + mutex_init(&card->memory_mutex); #ifdef CONFIG_PM init_waitqueue_head(&card->power_sleep); #endif diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c index d4702cc1d376..a18ebf2341ca 100644 --- a/sound/core/pcm_memory.c +++ b/sound/core/pcm_memory.c @@ -27,6 +27,38 @@ MODULE_PARM_DESC(maximum_substreams, "Maximum substreams with preallocated DMA m static const size_t snd_minimum_buffer = 16384; +static unsigned long max_alloc_per_card = 32UL * 1024UL * 1024UL * 1024UL; +module_param(max_alloc_per_card, ulong, 0644); +MODULE_PARM_DESC(max_alloc_per_card, "Max total allocation bytes per card."); + +static int do_alloc_pages(struct snd_card *card, int type, struct device *dev, + size_t size, struct snd_dma_buffer *dmab) +{ + int err; + + if (max_alloc_per_card && + card->total_pcm_alloc_bytes + size > max_alloc_per_card) + return -ENOMEM; + err = snd_dma_alloc_pages(type, dev, size, dmab); + if (!err) { + mutex_lock(&card->memory_mutex); + card->total_pcm_alloc_bytes += dmab->bytes; + mutex_unlock(&card->memory_mutex); + } + return err; +} + +static void do_free_pages(struct snd_card *card, struct snd_dma_buffer *dmab) +{ + if (!dmab->area) + return; + mutex_lock(&card->memory_mutex); + WARN_ON(card->total_pcm_alloc_bytes < dmab->bytes); + card->total_pcm_alloc_bytes -= dmab->bytes; + mutex_unlock(&card->memory_mutex); + snd_dma_free_pages(dmab); + dmab->area = NULL; +} /* * try to allocate as the large pages as possible. @@ -37,16 +69,15 @@ static const size_t snd_minimum_buffer = 16384; static int preallocate_pcm_pages(struct snd_pcm_substream *substream, size_t size) { struct snd_dma_buffer *dmab = &substream->dma_buffer; + struct snd_card *card = substream->pcm->card; size_t orig_size = size; int err; do { - if ((err = snd_dma_alloc_pages(dmab->dev.type, dmab->dev.dev, - size, dmab)) < 0) { - if (err != -ENOMEM) - return err; /* fatal error */ - } else - return 0; + err = do_alloc_pages(card, dmab->dev.type, dmab->dev.dev, + size, dmab); + if (err != -ENOMEM) + return err; size >>= 1; } while (size >= snd_minimum_buffer); dmab->bytes = 0; /* tell error */ @@ -62,10 +93,7 @@ static int preallocate_pcm_pages(struct snd_pcm_substream *substream, size_t siz */ static void snd_pcm_lib_preallocate_dma_free(struct snd_pcm_substream *substream) { - if (substream->dma_buffer.area == NULL) - return; - snd_dma_free_pages(&substream->dma_buffer); - substream->dma_buffer.area = NULL; + do_free_pages(substream->pcm->card, &substream->dma_buffer); } /** @@ -130,6 +158,7 @@ static void snd_pcm_lib_preallocate_proc_write(struct snd_info_entry *entry, struct snd_info_buffer *buffer) { struct snd_pcm_substream *substream = entry->private_data; + struct snd_card *card = substream->pcm->card; char line[64], str[64]; size_t size; struct snd_dma_buffer new_dmab; @@ -150,9 +179,10 @@ static void snd_pcm_lib_preallocate_proc_write(struct snd_info_entry *entry, memset(&new_dmab, 0, sizeof(new_dmab)); new_dmab.dev = substream->dma_buffer.dev; if (size > 0) { - if (snd_dma_alloc_pages(substream->dma_buffer.dev.type, - substream->dma_buffer.dev.dev, - size, &new_dmab) < 0) { + if (do_alloc_pages(card, + substream->dma_buffer.dev.type, + substream->dma_buffer.dev.dev, + size, &new_dmab) < 0) { buffer->error = -ENOMEM; return; } @@ -161,7 +191,7 @@ static void snd_pcm_lib_preallocate_proc_write(struct snd_info_entry *entry, substream->buffer_bytes_max = UINT_MAX; } if (substream->dma_buffer.area) - snd_dma_free_pages(&substream->dma_buffer); + do_free_pages(card, &substream->dma_buffer); substream->dma_buffer = new_dmab; } else { buffer->error = -EINVAL; @@ -346,6 +376,7 @@ struct page *snd_pcm_sgbuf_ops_page(struct snd_pcm_substream *substream, unsigne */ int snd_pcm_lib_malloc_pages(struct snd_pcm_substream *substream, size_t size) { + struct snd_card *card = substream->pcm->card; struct snd_pcm_runtime *runtime; struct snd_dma_buffer *dmab = NULL; @@ -374,9 +405,10 @@ int snd_pcm_lib_malloc_pages(struct snd_pcm_substream *substream, size_t size) if (! dmab) return -ENOMEM; dmab->dev = substream->dma_buffer.dev; - if (snd_dma_alloc_pages(substream->dma_buffer.dev.type, - substream->dma_buffer.dev.dev, - size, dmab) < 0) { + if (do_alloc_pages(card, + substream->dma_buffer.dev.type, + substream->dma_buffer.dev.dev, + size, dmab) < 0) { kfree(dmab); return -ENOMEM; } @@ -397,6 +429,7 @@ EXPORT_SYMBOL(snd_pcm_lib_malloc_pages); */ int snd_pcm_lib_free_pages(struct snd_pcm_substream *substream) { + struct snd_card *card = substream->pcm->card; struct snd_pcm_runtime *runtime; if (PCM_RUNTIME_CHECK(substream)) @@ -406,7 +439,7 @@ int snd_pcm_lib_free_pages(struct snd_pcm_substream *substream) return 0; if (runtime->dma_buffer_p != &substream->dma_buffer) { /* it's a newly allocated buffer. release it now. */ - snd_dma_free_pages(runtime->dma_buffer_p); + do_free_pages(card, runtime->dma_buffer_p); kfree(runtime->dma_buffer_p); } snd_pcm_set_runtime_buffer(substream, NULL); -- 2.16.4

2 3

Re: [alsa-devel] BOSS GT-1 USB audio and implicit feedback&In-Reply-To=<a3588f5f-b9b2-b622-7f9e-b9d472d88907@jensverwiebe.de>
by Mike Oliphant 21 Jan '20

21 Jan '20

Jens - actually, I think we have pretty much the same issue. I get no playback when forcing an implicit feedback endpoint, or when letting the Roland quirk handle it automatically. If I disable implicit feedback, it works but I get pops/clicks. Coincidentally, I just came across this post of yours on the Line6 forums about manually tweaking the sample rate: https://line6.com/support/topic/4426-line-6-with-linux/?tab=comments#commen… I gave it a try today, and by forcing a sample rate of 44105 instead of 44100 I now have largely clean playback! I get the odd dropout, but it is much less frequent (on the order of once every few minutes instead of several times a second). This is obviously an non-ideal workaround for the problem. Playback should be synchronized to the capture stream, but this doesn't seem to be getting configured correctly for our devices. Why, I'm not sure - I'm gradually gaining a better understanding of the USB audio kernel code, but I'm not there yet. Mike

1 0

[alsa-devel] BOSS GT-1 USB audio and implicit feedback
by Mike Oliphant 20 Jan '20

20 Jan '20

I've been digging around in the USB audio section of the kernel for the past month or so trying unsuccessfully to get audio on my BOSS GT-1 pedalboard to work in Linux. The device is recognized by the current kernel, but aplay just hangs when trying to output to it. My searches led me to this now-resolved issue with implicit feedback quirk handling on BOSS Katana amplifiers: https://bugzilla.kernel.org/show_bug.cgi?id=195223 I have patched pcm.c with a similar fix for the GT-1 in set_sync_ep_implicit_fb_quirk(): case USB_ID(0x0582, 0x01d6): /* BOSS GT-1 */ return 0; This results in successful playback, but with frequent pops/clicks in the audio - even with high buffer sizes under very low load - likely attributable to the lack of implicit feedback. The GT-1 has come up on the mailing list before - some good information is here, but no resolution: https://mailman.alsa-project.org/pipermail/alsa-devel/2018-January/130957.h… My understanding from what I think I know about implicit feedback and the output of lsusb, is that the device is designed to operate with simultaneous capture/playback, with feedback being provided in the capture stream to be used to sync both capture and playback. It seems like this is what the feedback quirk might be trying to do, since this is what I see from dmesg when trying to play audio with aplay on the stock kernel: [ 218.530738] usb 1-1.1: setting usb interface 1:1 [ 218.530753] Creating new playback data endpoint #d [ 218.530772] Creating new capture data endpoint #8e [ 218.531687] usb 1-1.1: Setting params for ep #d (type 0, 12 urbs), ret=0 [ 218.531706] usb 1-1.1: match_endpoint_audioformats: (fmt @ed1fbd45) score 2 [ 218.531840] usb 1-1.1: Setting params for ep #8e (type 0, 12 urbs), ret=0 [ 218.531855] usb 1-1.1: Starting data EP @f114d201 [ 218.532514] usb 1-1.1: Starting sync EP @984e9cce I have also tried to manually set the feedback endpoint in set_sync_ep_implicit_fb_quirk(): case USB_ID(0x0582, 0x01d6): /* BOSS GT-1 */ ep = 0x8e; ifnum = 2; goto add_sync_ep_from_ifnum; but this results in the same behavior. Any suggestions on what else to try would be much appreciated. It seems like the device is *very* close to working properly. Output from lsusb for the interface follows. Thanks! Mike --- Output from lsusb: Bus 001 Device 003: ID 0582:01d6 Roland Corp. Couldn't open device, some information will be missing Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 255 Vendor Specific Class bDeviceSubClass 0 bDeviceProtocol 255 bMaxPacketSize0 64 idVendor 0x0582 Roland Corp. idProduct 0x01d6 bcdDevice 0.00 iManufacturer 1 iProduct 2 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 0x00bc bNumInterfaces 4 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xc0 Self Powered MaxPower 0mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 0 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 06 24 f1 01 00 00 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 07 24 01 01 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 04 18 01 44 ac 00 ** UNRECOGNIZED: 06 24 f1 04 16 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x0d EP 13 OUT bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0038 1x 56 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 ** UNRECOGNIZED: 07 24 01 07 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 04 18 01 44 ac 00 ** UNRECOGNIZED: 06 24 f1 04 16 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x8e EP 14 IN bmAttributes 37 Transfer Type Isochronous Synch Type Asynchronous Usage Type Implicit feedback Data wMaxPacketSize 0x0038 1x 56 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 06 24 f1 02 01 01 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 1 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 4 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x85 EP 5 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 4

2 1