June 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Sending DC offsets to an ALSA device: dangerous?
by Ser, Simon 06 Jun '19

06 Jun '19

Hi, I've been writing some audio HDMI/DisplayPort tests in the IGT test suite. As part of the tests I send 200ms DC offsets at 90% of the maximum amplitude. Do you know whether doing so is dangerous for some TV speakers? Would sending the same DC offsets at 25% of the max amplitude be better? Thanks, Simon Ser

1 0

Re: [alsa-devel] [PATCH] ASoC: fsl_esai: fix the channel swap issue after xrun
by S.j. Wang 06 Jun '19

06 Jun '19

Hi > > > > > Sounds like a bug to me...should fix it first by marking the > > > > > data registers as volatile. > > > > > > > > > The ETDR is a writable register, it is not volatile. Even we > > > > change it to Volatile, I don't think we can't avoid this issue. > > > > for the regcache_sync Just to write this register, it is correct behavior. > > > > > > Is that so? Quoting the comments of regcache_sync(): > > > "* regcache_sync - Sync the register cache with the hardware. > > > * > > > * @map: map to configure. > > > * > > > * Any registers that should not be synced should be marked as > > > * volatile." > > > > > > If regcache_sync() does sync volatile registers too as you said, I > > > don't mind having this FIFO reset WAR for now, though I think this > > > mismatch between the comments and the actual behavior then should > get people's attention. > > > > > > Thank you > > > > ETDR is not volatile, if we mark it is volatile, is it correct? > > Well, you have a point -- it might not be ideally true, but it sounds like a > correct fix to me according to this comments. > > We can wait for Mark's comments or just send a patch to the mail list for > review. > > Thanks you I test this patch, we don't need to reset the FIFO, and regcache_sync didn't Write the ETDR even the EDTR is not volatile. This fault maybe caused by Legacy, in the beginning we add this patch in internal branch, there maybe Something cause this issue, but now can't reproduced. So I will remove the reset of FIFO. Best regards Wang Shengjiu

2 1

[alsa-devel] [PATCH v4] ASoC: max98090: remove 24-bit format support if RJ is 0
by Yu-Hsuan Hsu 06 Jun '19

06 Jun '19

The supported formats are S16_LE and S24_LE now. However, by datasheet of max98090, S24_LE is only supported when it is in the right justified mode. We should remove 24-bit format if it is not in that mode to avoid triggering error. Signed-off-by: Yu-Hsuan Hsu <yuhsuan(a)chromium.org> --- Remove Change-Id. sound/soc/codecs/max98090.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 7619ea31ab50..ada8c25e643d 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -1909,6 +1909,21 @@ static int max98090_configure_dmic(struct max98090_priv *max98090, return 0; } +static int max98090_dai_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct snd_soc_component *component = dai->component; + struct max98090_priv *max98090 = snd_soc_component_get_drvdata(component); + unsigned int fmt = max98090->dai_fmt; + + /* Remove 24-bit format support if it is not in right justified mode. */ + if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) != SND_SOC_DAIFMT_RIGHT_J) { + substream->runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; + snd_pcm_hw_constraint_msbits(substream->runtime, 0, 16, 16); + } + return 0; +} + static int max98090_dai_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) @@ -2316,6 +2331,7 @@ EXPORT_SYMBOL_GPL(max98090_mic_detect); #define MAX98090_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) static const struct snd_soc_dai_ops max98090_dai_ops = { + .startup = max98090_dai_startup, .set_sysclk = max98090_dai_set_sysclk, .set_fmt = max98090_dai_set_fmt, .set_tdm_slot = max98090_set_tdm_slot, -- 2.22.0.rc1.311.g5d7573a151-goog

4 3

[alsa-devel] [PATCH v5 0/3] Fix jack detection for Chromebook Pixel
by Fletcher Woodruff 06 Jun '19

06 Jun '19

Headphone/mic jack detection doesn't work on the Chromebook Pixel 2015. This patch changes the irq implementation to support polarity flipping and fixes the configuration code so that correct GPIO pins are read from ACPI. With this series, plugging and unplugging the headphone jack switches between headphones and speakers automatically, and headset microphones are also detected. v5: - Fix void* parameter to devm_request_threaded_irq - Correct authorship for patch 2/3 v4: - Fix incorrect void* cast in rt5677_irq() v3: - Update commit message for patch 1/3 to clarify why we implement our own irq_chip. v2: - Split IRQ change into two patches: adding and fixing potential race - Change config reading code to try both DT and ACPI style names Ben Zhang (2): ASoC: rt5677: allow multiple interrupt sources ASoC: rt5677: handle concurrent interrupts Fletcher Woodruff (1): ASoC: rt5677: fall back to DT prop names on error sound/soc/codecs/rt5677.c | 346 ++++++++++++++++++++++++++------------ sound/soc/codecs/rt5677.h | 14 +- 2 files changed, 256 insertions(+), 104 deletions(-) -- 2.21.0.1020.gf2820cf01a-goog

3 13

[alsa-devel] [PATCH 1/6] device property: Add new array helper
by Charles Keepax 05 Jun '19

05 Jun '19

It is fairly common to want to read an integer array property that is composed of an unknown number of fixed size integer groups. For example, say each group consists of three values which correspond to the settings for one input on the device and the driver supports several chips with different numbers of inputs. Add a new helper function to provide this functionality, it differs for the existing helpers in that it allows reading a smaller number of values than the full array size and checks that the number of values read is a multiple of the group size. Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- drivers/base/property.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/property.h | 2 ++ 2 files changed, 50 insertions(+) diff --git a/drivers/base/property.c b/drivers/base/property.c index 348b37e64944c..656d21e01a648 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -133,6 +133,54 @@ int device_property_read_u32_array(struct device *dev, const char *propname, EXPORT_SYMBOL_GPL(device_property_read_u32_array); /** + * device_property_read_u32_2darray - return a 2d u32 array property of a device + * @dev: Device to get the property of + * @propname: Name of the property + * @val: The values are stored here or %NULL to return the number of values + * @nval: Size of the @val array + * @multiple: Number of entries in each block of data + * + * Function reads an array of u32 properties split up into fixed size + * sub-groups, with @propname from the device firmware description and + * stores them to @val if found. + * + * Return: Number of values read + * %0 if the property was not found, + * %-EINVAL if given arguments are not valid, + * %-ENODATA if the property does not have a value, + * %-EPROTO if the property is not an array of numbers, + * %-EOVERFLOW if the size of the property is not as expected. + * %-ENXIO if no suitable firmware interface is present. + */ +int device_property_read_u32_2darray(struct device *dev, const char *propname, + u32 *val, size_t nval, int multiple) +{ + int n, ret; + + n = device_property_read_u32_array(dev, propname, NULL, 0); + if (n == -EINVAL) { + return 0; /* missing, ignore */ + } else if (n < 0) { + dev_warn(dev, "%s malformed (%d)\n", propname, n); + return n; + } else if ((n % multiple) != 0) { + dev_warn(dev, "%s not a multiple of %d entries\n", + propname, multiple); + return -EOVERFLOW; + } + + if (n > nval) + n = nval; + + ret = device_property_read_u32_array(dev, propname, val, n); + if (ret < 0) + return ret; + else + return n; +} +EXPORT_SYMBOL_GPL(device_property_read_u32_2darray); + +/** * device_property_read_u64_array - return a u64 array property of a device * @dev: Device to get the property of * @propname: Name of the property diff --git a/include/linux/property.h b/include/linux/property.h index a29369c89e6ef..854867f0d139f 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -43,6 +43,8 @@ int device_property_read_u16_array(struct device *dev, const char *propname, u16 *val, size_t nval); int device_property_read_u32_array(struct device *dev, const char *propname, u32 *val, size_t nval); +int device_property_read_u32_2darray(struct device *dev, const char *propname, + u32 *val, size_t nval, int multiple); int device_property_read_u64_array(struct device *dev, const char *propname, u64 *val, size_t nval); int device_property_read_string_array(struct device *dev, const char *propname, -- 2.11.0

2 8

[alsa-devel] [PATCH] ASoC: sun4i-i2s: Change SR and WSS computation
by Maxime Ripard 05 Jun '19

05 Jun '19

The current computation for the SR (sample resolution) and the WSS (word slot size) register parameters is based on a switch returning the matching parameters for a given params width. Later SoCs (A83t, H3, A64) changed that calculation, which was loosely the same with an offset. Therefore, an offset was added to adjust those parameters. However, the calculation is a bit less trivial than initially thought. Indeed, while we assumed that SR and WSS were always the same, on older SoCs, SR will max at 24 (since those SoCs do not support 32 bits formats), but the word size can be 32. Newer SoCs can also support a much larger range (8 bits to 32 bits, by increments of 4) of size than the older SoCs could. Finally, the A64 and A83t were never adjusted to have that offset in the first place, and were therefore broken from that point of view. In order to fix all those issues, let's introduce two functions, get_wss and get_sr, with their respective implementations for all the SoCs supported so far. Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") Fixes: 66ecce332538 ("ASoC: sun4i-i2s: Add compatibility with A64 codec I2S") Signed-off-by: Maxime Ripard <maxime.ripard(a)bootlin.com> --- sound/soc/sunxi/sun4i-i2s.c | 69 ++++++++++++++++++++++++++++--------- 1 file changed, 53 insertions(+), 16 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index c53bfed8d4c2..f20f273cf5ac 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -127,7 +127,6 @@ * @sun4i_i2s_regmap: regmap config to use. * @mclk_offset: Value by which mclkdiv needs to be adjusted. * @bclk_offset: Value by which bclkdiv needs to be adjusted. - * @fmt_offset: Value by which wss and sr needs to be adjusted. * @field_clkdiv_mclk_en: regmap field to enable mclk output. * @field_fmt_wss: regmap field to set word select size. * @field_fmt_sr: regmap field to set sample resolution. @@ -150,7 +149,6 @@ struct sun4i_i2s_quirks { const struct regmap_config *sun4i_i2s_regmap; unsigned int mclk_offset; unsigned int bclk_offset; - unsigned int fmt_offset; /* Register fields for i2s */ struct reg_field field_clkdiv_mclk_en; @@ -163,6 +161,9 @@ struct sun4i_i2s_quirks { struct reg_field field_rxchanmap; struct reg_field field_txchansel; struct reg_field field_rxchansel; + + s8 (*get_sr)(const struct sun4i_i2s *, int); + s8 (*get_wss)(const struct sun4i_i2s *, int); }; struct sun4i_i2s { @@ -345,6 +346,39 @@ static int sun4i_i2s_set_clk_rate(struct snd_soc_dai *dai, return 0; } +static s8 sun4i_i2s_get_sr(const struct sun4i_i2s *i2s, int width) +{ + if (width < 16 || width > 24) + return -EINVAL; + + if (width % 4) + return -EINVAL; + + return (width - 16) / 4; +} + +static s8 sun4i_i2s_get_wss(const struct sun4i_i2s *i2s, int width) +{ + if (width < 16 || width > 32) + return -EINVAL; + + if (width % 4) + return -EINVAL; + + return (width - 16) / 4; +} + +static s8 sun8i_i2s_get_sr_wss(const struct sun4i_i2s *i2s, int width) +{ + if (width % 4) + return -EINVAL; + + if (width < 8 || width > 32) + return -EINVAL; + + return (width - 8) / 4 + 1; +} + static int sun4i_i2s_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) @@ -396,22 +430,16 @@ static int sun4i_i2s_hw_params(struct snd_pcm_substream *substream, } i2s->playback_dma_data.addr_width = width; - switch (params_width(params)) { - case 16: - sr = 0; - wss = 0; - break; + sr = i2s->variant->get_sr(i2s, params_width(params)); + if (sr < 0) + return -EINVAL; - default: - dev_err(dai->dev, "Unsupported sample width: %d\n", - params_width(params)); + wss = i2s->variant->get_wss(i2s, params_width(params)); + if (wss < 0) return -EINVAL; - } - regmap_field_write(i2s->field_fmt_wss, - wss + i2s->variant->fmt_offset); - regmap_field_write(i2s->field_fmt_sr, - sr + i2s->variant->fmt_offset); + regmap_field_write(i2s->field_fmt_wss, wss); + regmap_field_write(i2s->field_fmt_sr, sr); return sun4i_i2s_set_clk_rate(dai, params_rate(params), params_width(params)); @@ -887,6 +915,8 @@ static const struct sun4i_i2s_quirks sun4i_a10_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN4I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN4I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN4I_I2S_RX_CHAN_SEL_REG, 0, 2), + .get_sr = sun4i_i2s_get_sr, + .get_wss = sun4i_i2s_get_wss, }; static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = { @@ -904,6 +934,8 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN4I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN4I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN4I_I2S_RX_CHAN_SEL_REG, 0, 2), + .get_sr = sun4i_i2s_get_sr, + .get_wss = sun4i_i2s_get_wss, }; static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = { @@ -921,6 +953,8 @@ static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN4I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN4I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN4I_I2S_RX_CHAN_SEL_REG, 0, 2), + .get_sr = sun8i_i2s_get_sr_wss, + .get_wss = sun8i_i2s_get_sr_wss, }; static const struct sun4i_i2s_quirks sun8i_h3_i2s_quirks = { @@ -929,7 +963,6 @@ static const struct sun4i_i2s_quirks sun8i_h3_i2s_quirks = { .sun4i_i2s_regmap = &sun8i_i2s_regmap_config, .mclk_offset = 1, .bclk_offset = 2, - .fmt_offset = 3, .has_fmt_set_lrck_period = true, .has_chcfg = true, .has_chsel_tx_chen = true, @@ -944,6 +977,8 @@ static const struct sun4i_i2s_quirks sun8i_h3_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN8I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN8I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN8I_I2S_RX_CHAN_SEL_REG, 0, 2), + .get_sr = sun8i_i2s_get_sr_wss, + .get_wss = sun8i_i2s_get_sr_wss, }; static const struct sun4i_i2s_quirks sun50i_a64_codec_i2s_quirks = { @@ -961,6 +996,8 @@ static const struct sun4i_i2s_quirks sun50i_a64_codec_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN4I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN4I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN4I_I2S_RX_CHAN_SEL_REG, 0, 2), + .get_sr = sun8i_i2s_get_sr_wss, + .get_wss = sun8i_i2s_get_sr_wss, }; static int sun4i_i2s_init_regmap_fields(struct device *dev, -- 2.21.0

2 2

[alsa-devel] [PATCH] wcd9335: fix a incorrect use of kstrndup()
by Gen Zhang 05 Jun '19

05 Jun '19

In wcd9335_codec_enable_dec(), 'widget_name' is allocated by kstrndup(). However, according to doc: "Note: Use kmemdup_nul() instead if the size is known exactly." So we should use kmemdup_nul() here instead of kstrndup(). Signed-off-by: Gen Zhang <blackgod016574(a)gmail.com> --- diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index a04a7ce..85737fe 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -2734,7 +2734,7 @@ static int wcd9335_codec_enable_dec(struct snd_soc_dapm_widget *w, char *dec; u8 hpf_coff_freq; - widget_name = kstrndup(w->name, 15, GFP_KERNEL); + widget_name = kmemdup_nul(w->name, 15, GFP_KERNEL); if (!widget_name) return -ENOMEM; ---

3 2

[alsa-devel] [asoc:for-5.3 110/113] sound/soc/codecs/rt1011.c:1148:31: sparse: sparse: incorrect type in assignment (different base types)
by kbuild test robot 04 Jun '19

04 Jun '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3 head: 9b8e8b893ff52264df2b54a6820ae3c4bb820624 commit: d6e65bb7ff0d360c4c5462c3d0b237f2a07e5312 [110/113] ASoC: rt1011: Add RT1011 amplifier driver reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty git checkout d6e65bb7ff0d360c4c5462c3d0b237f2a07e5312 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> sound/soc/codecs/rt1011.c:1148:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short reg @@ got restricted __lunsigned short reg @@ >> sound/soc/codecs/rt1011.c:1148:31: sparse: expected unsigned short reg >> sound/soc/codecs/rt1011.c:1148:31: sparse: got restricted __le16 [usertype] >> sound/soc/codecs/rt1011.c:1149:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short val @@ got restricted __lunsigned short val @@ >> sound/soc/codecs/rt1011.c:1149:31: sparse: expected unsigned short val sound/soc/codecs/rt1011.c:1149:31: sparse: got restricted __le16 [usertype] >> sound/soc/codecs/rt1011.c:1190:41: sparse: sparse: cast to restricted __le16 sound/soc/codecs/rt1011.c:1191:41: sparse: sparse: cast to restricted __le16 vim +1148 sound/soc/codecs/rt1011.c 1117 1118 static int rt1011_bq_drc_coeff_get(struct snd_kcontrol *kcontrol, 1119 struct snd_ctl_elem_value *ucontrol) 1120 { 1121 struct snd_soc_component *component = 1122 snd_soc_kcontrol_component(kcontrol); 1123 struct rt1011_priv *rt1011 = 1124 snd_soc_component_get_drvdata(component); 1125 struct rt1011_bq_drc_params *bq_drc_info; 1126 struct rt1011_bq_drc_params *params = 1127 (struct rt1011_bq_drc_params *)ucontrol->value.integer.value; 1128 unsigned int i, mode_idx = 0; 1129 1130 if (strstr(ucontrol->id.name, "AdvanceMode Initial Set")) 1131 mode_idx = RT1011_ADVMODE_INITIAL_SET; 1132 else if (strstr(ucontrol->id.name, "AdvanceMode SEP BQ Coeff")) 1133 mode_idx = RT1011_ADVMODE_SEP_BQ_COEFF; 1134 else if (strstr(ucontrol->id.name, "AdvanceMode EQ BQ Coeff")) 1135 mode_idx = RT1011_ADVMODE_EQ_BQ_COEFF; 1136 else if (strstr(ucontrol->id.name, "AdvanceMode BQ UI Coeff")) 1137 mode_idx = RT1011_ADVMODE_BQ_UI_COEFF; 1138 else if (strstr(ucontrol->id.name, "AdvanceMode SmartBoost Coeff")) 1139 mode_idx = RT1011_ADVMODE_SMARTBOOST_COEFF; 1140 else 1141 return -EINVAL; 1142 1143 pr_info("%s, id.name=%s, mode_idx=%d\n", __func__, 1144 ucontrol->id.name, mode_idx); 1145 bq_drc_info = rt1011->bq_drc_params[mode_idx]; 1146 1147 for (i = 0; i < RT1011_BQ_DRC_NUM; i++) { > 1148 params[i].reg = cpu_to_le16(bq_drc_info[i].reg); > 1149 params[i].val = cpu_to_le16(bq_drc_info[i].val); 1150 } 1151 1152 return 0; 1153 } 1154 1155 static int rt1011_bq_drc_coeff_put(struct snd_kcontrol *kcontrol, 1156 struct snd_ctl_elem_value *ucontrol) 1157 { 1158 struct snd_soc_component *component = 1159 snd_soc_kcontrol_component(kcontrol); 1160 struct rt1011_priv *rt1011 = 1161 snd_soc_component_get_drvdata(component); 1162 struct rt1011_bq_drc_params *bq_drc_info; 1163 struct rt1011_bq_drc_params *params = 1164 (struct rt1011_bq_drc_params *)ucontrol->value.integer.value; 1165 unsigned int i, mode_idx = 0; 1166 1167 if (!component->card->instantiated) 1168 return 0; 1169 1170 if (strstr(ucontrol->id.name, "AdvanceMode Initial Set")) 1171 mode_idx = RT1011_ADVMODE_INITIAL_SET; 1172 else if (strstr(ucontrol->id.name, "AdvanceMode SEP BQ Coeff")) 1173 mode_idx = RT1011_ADVMODE_SEP_BQ_COEFF; 1174 else if (strstr(ucontrol->id.name, "AdvanceMode EQ BQ Coeff")) 1175 mode_idx = RT1011_ADVMODE_EQ_BQ_COEFF; 1176 else if (strstr(ucontrol->id.name, "AdvanceMode BQ UI Coeff")) 1177 mode_idx = RT1011_ADVMODE_BQ_UI_COEFF; 1178 else if (strstr(ucontrol->id.name, "AdvanceMode SmartBoost Coeff")) 1179 mode_idx = RT1011_ADVMODE_SMARTBOOST_COEFF; 1180 else 1181 return -EINVAL; 1182 1183 bq_drc_info = rt1011->bq_drc_params[mode_idx]; 1184 memset(bq_drc_info, 0, 1185 sizeof(struct rt1011_bq_drc_params) * RT1011_BQ_DRC_NUM); 1186 1187 pr_info("%s, id.name=%s, mode_idx=%d\n", __func__, 1188 ucontrol->id.name, mode_idx); 1189 for (i = 0; i < RT1011_BQ_DRC_NUM; i++) { > 1190 bq_drc_info[i].reg = le16_to_cpu(params[i].reg); 1191 bq_drc_info[i].val = le16_to_cpu(params[i].val); 1192 } 1193 1194 for (i = 0; i < RT1011_BQ_DRC_NUM; i++) { 1195 if (bq_drc_info[i].reg == 0) 1196 break; 1197 else if (rt1011_validate_bq_drc_coeff(bq_drc_info[i].reg)) { 1198 snd_soc_component_write(component, bq_drc_info[i].reg, 1199 bq_drc_info[i].val); 1200 } 1201 } 1202 1203 return 0; 1204 } 1205 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:for-5.3 110/113] sound/soc/codecs/rt1011.c:1291:3: warning: this decimal constant is unsigned only in ISO C90
by kbuild test robot 04 Jun '19

04 Jun '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3 head: 9b8e8b893ff52264df2b54a6820ae3c4bb820624 commit: d6e65bb7ff0d360c4c5462c3d0b237f2a07e5312 [110/113] ASoC: rt1011: Add RT1011 amplifier driver config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout d6e65bb7ff0d360c4c5462c3d0b237f2a07e5312 # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): sound/soc/codecs/rt1011.c: In function 'rt1011_r0_load_mode_put': >> sound/soc/codecs/rt1011.c:1291:3: warning: this decimal constant is unsigned only in ISO C90 format = 2147483648; /* 2^24 * 128 */ ^~~~~~ sound/soc/codecs/rt1011.c: In function 'rt1011_calibrate': sound/soc/codecs/rt1011.c:2123:4: warning: this decimal constant is unsigned only in ISO C90 format = 2147483648; /* 2^24 * 128 */ ^~~~~~ vim +1291 sound/soc/codecs/rt1011.c 1272 1273 static int rt1011_r0_load_mode_put(struct snd_kcontrol *kcontrol, 1274 struct snd_ctl_elem_value *ucontrol) 1275 { 1276 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 1277 struct rt1011_priv *rt1011 = snd_soc_component_get_drvdata(component); 1278 struct device *dev; 1279 unsigned int r0_integer, r0_factor, format; 1280 1281 if (ucontrol->value.integer.value[0] == rt1011->r0_reg) 1282 return 0; 1283 1284 if (!component->card->instantiated) 1285 return 0; 1286 1287 dev = regmap_get_device(rt1011->regmap); 1288 if (snd_soc_component_get_bias_level(component) == SND_SOC_BIAS_OFF) { 1289 rt1011->r0_reg = ucontrol->value.integer.value[0]; 1290 > 1291 format = 2147483648; /* 2^24 * 128 */ 1292 r0_integer = format / rt1011->r0_reg / 128; 1293 r0_factor = ((format / rt1011->r0_reg * 100) / 128) 1294 - (r0_integer * 100); 1295 dev_info(dev, "New r0 resistance about %d.%02d ohm, reg=0x%X\n", 1296 r0_integer, r0_factor, rt1011->r0_reg); 1297 1298 if (rt1011->r0_reg) 1299 rt1011_r0_load(rt1011); 1300 } 1301 1302 return 0; 1303 } 1304 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH v2 13/22] docs: soundwire: locking: fix tags for a code-block
by Mauro Carvalho Chehab 04 Jun '19

04 Jun '19

There's an ascii artwork at Example 1 whose code-block is not properly idented, causing those warnings. Documentation/driver-api/soundwire/locking.rst:50: WARNING: Inconsistent literal block quoting. Documentation/driver-api/soundwire/locking.rst:51: WARNING: Line block ends without a blank line. Documentation/driver-api/soundwire/locking.rst:55: WARNING: Inline substitution_reference start-string without end-string. Documentation/driver-api/soundwire/locking.rst:56: WARNING: Line block ends without a blank line. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> --- Documentation/driver-api/soundwire/locking.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/driver-api/soundwire/locking.rst b/Documentation/driver-api/soundwire/locking.rst index 253f73555255..3a7ffb3d87f3 100644 --- a/Documentation/driver-api/soundwire/locking.rst +++ b/Documentation/driver-api/soundwire/locking.rst @@ -44,7 +44,9 @@ Message transfer. b. Transfer message (Read/Write) to Slave1 or broadcast message on Bus in case of bank switch. - c. Release Message lock :: + c. Release Message lock + + :: +----------+ +---------+ | | | | -- 2.21.0

3 2