May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 0/2] ASoC: CX2072X codec support (revised)
by Takashi Iwai 02 May '19

02 May '19

Hi, this is a revised patchset for ASoC CX2072X codec support on Intel platforms. v1->v2: Uncomment SOF entries in ACPI binding Move snd_soc_dai_set_bclk_ratio() call into init callback v2->v3: CX2072X codec driver: * Move register tables to appropriate place * Remove some confusing codes * Set snd_ctl_boolean_* helpers directly * Fix EQ put callback * Rename to "DAC1 Switch" from "DAC1 Mute Switch" * Drop superfluous regmap calls at shutdown * Avoid regmap_register_patch() * Add missing register definitions * Fix register access on big-endian machine * Remove regcache messes CX2072X machine driver: * Add Pierre's ack * Drop superfluous ssp0 routes Simon Ho (1): ASoC: Add support for Conexant CX2071X CODEC Takashi Iwai (1): ASoC: Intel: Add machine driver for CX2072X on BYT/CHT platforms sound/soc/codecs/Kconfig | 7 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/cx2072x.c | 2158 +++++++++++++++++++++ sound/soc/codecs/cx2072x.h | 319 +++ sound/soc/intel/boards/Kconfig | 11 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/bytcht_cx2072x.c | 284 +++ sound/soc/intel/common/soc-acpi-intel-byt-match.c | 8 + sound/soc/intel/common/soc-acpi-intel-cht-match.c | 8 + 9 files changed, 2799 insertions(+) create mode 100644 sound/soc/codecs/cx2072x.c create mode 100644 sound/soc/codecs/cx2072x.h create mode 100644 sound/soc/intel/boards/bytcht_cx2072x.c -- 2.16.4

1 3

[alsa-devel] [GIT PULL]: Second soundwire updates
by Vinod Koul 02 May '19

02 May '19

Hi Greg, As discussed here is the second soundwire PULL request for v5.2-rc1. The following changes since commit 4abbd783d126cabfc20d1b8d50b1d5026b5cba09: soundwire: intel: fix implicit header use of module.h/export.h (2019-04-14 15:52:50 +0530) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git tags/soundwire-5.2-rc1_2 for you to fetch changes up to f3ed52bc798d7a5bc229d62374bf24173498092b: soundwire: remove multiple blank lines (2019-05-02 22:12:26 +0530) ---------------------------------------------------------------- 2nd soundwire updates for v5.2-rc1 This includes - the code cleanup series from Pierre - subsequent cleanups from me ---------------------------------------------------------------- Pierre-Louis Bossart (27): soundwire: Kconfig: fix help format soundwire: bus: fix alignment issues soundwire: bus: fix typos in comments soundwire: bus: fix boolean comparisons soundwire: bus: remove spurious newline soundwire: bus_type: fix alignment issues soundwire: mipi_disco: fix alignment issues soundwire: mipi_disco: fix boolean comparisons soundwire: stream: fix alignment issues soundwire: slave: fix alignment issues soundwire: intel_init: fix alignment issues soundwire: intel: fix alignment issues soundwire: intel: protect macro parameters soundwire: intel: fix boolean comparison soundwire: cadence_master: fix alignment issues soundwire: cadence_master: balance parentheses soundwire: cadence_master: fix boolean comparisons soundwire: cadence_master: remove spurious newline soundwire: fix SPDX license for header files soundwire: cadence: fix SPDX license for header files soundwire: intel: fix SPDX license for header files soundwire: fix alignment issues in header files soundwire: cadence: fix alignment issues in header files soundwire: bus: remove useless parentheses soundwire: add missing newlines in dynamic debug logs soundwire: cadence: add missing newlines in dynamic debug logs soundwire: intel: add missing newlines in dynamic debug logs Vinod Koul (14): soundwire: fix kconfig help format soundwire: fix SPDX license for header files soundwire: intel: fix SPDX license for header file soundwire: remove empty line before/after braces soundwire: cadence: remove empty line after braces soundwire: intel: remove empty line after braces soundwire: add argument to function definition soundwire: more alignment fixes soundwire: intel: more alignment fixes soundwire: avoid multiple assignments soundwire: fix more typos soundwire: wrap macro argument in parenthesis soundwire: add a blank line between functions soundwire: remove multiple blank lines drivers/soundwire/Kconfig | 4 +- drivers/soundwire/bus.c | 150 ++++++++--------- drivers/soundwire/bus.h | 16 +- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 100 +++++------ drivers/soundwire/cadence_master.h | 22 +-- drivers/soundwire/intel.c | 135 ++++++++------- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 13 +- drivers/soundwire/mipi_disco.c | 122 +++++++------- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 283 ++++++++++++++++---------------- include/linux/soundwire/sdw.h | 16 +- include/linux/soundwire/sdw_intel.h | 6 +- include/linux/soundwire/sdw_registers.h | 5 +- include/linux/soundwire/sdw_type.h | 6 +- 16 files changed, 449 insertions(+), 447 deletions(-) Thanks -- ~Vinod

2 1

[alsa-devel] [PATCH 00/14] soundwire: more code cleanups
by Vinod Koul 02 May '19

02 May '19

After applying cleanup from Pierre, I realized few more things can be cleaned up as well, so fixing these instance in the subsystem. Looks like bool is no longer encouraged, but I have skipped those and few alignment as they caused code to look worse. Greg, if you are okay I would like to add this as well (i know it is late, but they are cosmetic changes and no logic ones, let me know and I can send a updated PR) Vinod Koul (14): soundwire: fix kconfig help format soundwire: fix SPDX license for header files soundwire: intel: fix SPDX license for header file soundwire: remove empty line before/after braces soundwire: cadence: remove empty line after braces soundwire: intel: remove empty line after braces soundwire: add argument to function definition soundwire: more alignment fixes soundwire: intel: more alignment fixes soundwire: avoid multiple assignments soundwire: fix more typos soundwire: wrap macro argument in parenthesis soundwire: add a blank line between functions soundwire: remove multiple blank lines drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 17 +++++------- drivers/soundwire/cadence_master.c | 1 - drivers/soundwire/intel.c | 36 ++++++++++++------------- drivers/soundwire/intel_init.c | 1 - drivers/soundwire/mipi_disco.c | 6 ----- drivers/soundwire/stream.c | 28 +++++++++---------- include/linux/soundwire/sdw.h | 16 +++++------ include/linux/soundwire/sdw_intel.h | 6 ++--- include/linux/soundwire/sdw_registers.h | 5 ++-- include/linux/soundwire/sdw_type.h | 6 ++--- 11 files changed, 54 insertions(+), 70 deletions(-) -- 2.20.1

3 23

[alsa-devel] [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
by "mac.chiang＠intel.com--cc=pierre-louis.bossart"＠linux.intel.com 02 May '19

02 May '19

From: Mac Chiang <mac.chiang(a)intel.com> On kbl_rt5663_max98927, commit 38a5882e4292 ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE") This key pair mapping to play/pause when playing Youtube The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support. For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec The same fix is required on Chrome kbl_da7219_max98357a. Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> Reviewed-by: Benson Leung <bleung(a)chromium.org> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c index 38f6ab7..07491a0 100644 --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c @@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); -- 2.7.4

2 1

[alsa-devel] [PATCH 1/5] pcm: direct: Add generic hw_ptr_alignment function for dmix, dshare and dsnoop
by vanitha.channaiah＠in.bosch.com 02 May '19

02 May '19

From: Vanitha Channaiah <vanitha.channaiah(a)in.bosch.com> This patch is same as the fix in below commit commit 6b058fda9dce ("pcm: dmix: Add option to allow alignment of slave pointers") Signed-off-by: Vanitha Channaiah <vanitha.channaiah(a)in.bosch.com> --- src/pcm/pcm_direct.c | 19 +++++++++++++++++++ src/pcm/pcm_direct.h | 8 ++++++++ src/pcm/pcm_dmix.c | 25 ++----------------------- 3 files changed, 29 insertions(+), 23 deletions(-) diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c index 666a8ce..411a035 100644 --- a/src/pcm/pcm_direct.c +++ b/src/pcm/pcm_direct.c @@ -2040,3 +2040,22 @@ int snd_pcm_direct_parse_open_conf(snd_config_t *root, snd_config_t *conf, return 0; } + +void snd_pcm_direct_reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix) +{ + dmix->slave_appl_ptr = dmix->slave_hw_ptr = *dmix->spcm->hw.ptr; + + if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDUP || + (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO && + pcm->buffer_size <= pcm->period_size * 2)) + dmix->slave_appl_ptr = + ((dmix->slave_appl_ptr + dmix->slave_period_size - 1) / + dmix->slave_period_size) * dmix->slave_period_size; + else if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDDOWN || + (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO && + (dmix->slave_period_size * SEC_TO_MS) / + pcm->rate < LOW_LATENCY_PERIOD_TIME)) + dmix->slave_appl_ptr = dmix->slave_hw_ptr = + ((dmix->slave_hw_ptr / dmix->slave_period_size) * + dmix->slave_period_size); +} diff --git a/src/pcm/pcm_direct.h b/src/pcm/pcm_direct.h index da5e280..a71aab1 100644 --- a/src/pcm/pcm_direct.h +++ b/src/pcm/pcm_direct.h @@ -24,6 +24,11 @@ #define DIRECT_IPC_SEMS 1 #define DIRECT_IPC_SEM_CLIENT 0 +/* Seconds representing in Milli seconds */ +#define SEC_TO_MS 1000 +/* slave_period time for low latency requirements in ms */ +#define LOW_LATENCY_PERIOD_TIME 10 + typedef void (mix_areas_t)(unsigned int size, volatile void *dst, void *src, @@ -257,6 +262,8 @@ struct snd_pcm_direct { snd1_pcm_direct_get_chmap #define snd_pcm_direct_set_chmap \ snd1_pcm_direct_set_chmap +#define snd_pcm_direct_reset_slave_ptr \ + snd1_pcm_direct_reset_slave_ptr int snd_pcm_direct_semaphore_create_or_connect(snd_pcm_direct_t *dmix); @@ -341,6 +348,7 @@ int snd_pcm_direct_slave_recover(snd_pcm_direct_t *direct); int snd_pcm_direct_client_chk_xrun(snd_pcm_direct_t *direct, snd_pcm_t *pcm); int snd_timer_async(snd_timer_t *timer, int sig, pid_t pid); struct timespec snd_pcm_hw_fast_tstamp(snd_pcm_t *pcm); +void snd_pcm_direct_reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix); struct snd_pcm_direct_open_conf { key_t ipc_key; diff --git a/src/pcm/pcm_dmix.c b/src/pcm/pcm_dmix.c index c5592cd..dcde40d 100644 --- a/src/pcm/pcm_dmix.c +++ b/src/pcm/pcm_dmix.c @@ -55,9 +55,6 @@ const char *_snd_module_pcm_dmix = ""; #define STATE_RUN_PENDING 1024 #endif -#define SEC_TO_MS 1000 /* Seconds representing in Milli seconds */ -#define LOW_LATENCY_PERIOD_TIME 10 /* slave_period time for low latency requirements in ms */ - /* * */ @@ -560,30 +557,12 @@ static int snd_pcm_dmix_hwsync(snd_pcm_t *pcm) } } -static void reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix) -{ - dmix->slave_appl_ptr = dmix->slave_hw_ptr = *dmix->spcm->hw.ptr; - - if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDUP || - (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO && - pcm->buffer_size <= pcm->period_size * 2)) - dmix->slave_appl_ptr = - ((dmix->slave_appl_ptr + dmix->slave_period_size - 1) - / dmix->slave_period_size) * dmix->slave_period_size; - else if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDDOWN || - (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO && - (dmix->slave_period_size * SEC_TO_MS) / pcm->rate < LOW_LATENCY_PERIOD_TIME)) - dmix->slave_appl_ptr = dmix->slave_hw_ptr = - ((dmix->slave_hw_ptr / dmix->slave_period_size) * - dmix->slave_period_size); -} - static int snd_pcm_dmix_reset(snd_pcm_t *pcm) { snd_pcm_direct_t *dmix = pcm->private_data; dmix->hw_ptr %= pcm->period_size; dmix->appl_ptr = dmix->last_appl_ptr = dmix->hw_ptr; - reset_slave_ptr(pcm, dmix); + snd_pcm_direct_reset_slave_ptr(pcm, dmix); return 0; } @@ -592,7 +571,7 @@ static int snd_pcm_dmix_start_timer(snd_pcm_t *pcm, snd_pcm_direct_t *dmix) int err; snd_pcm_hwsync(dmix->spcm); - reset_slave_ptr(pcm, dmix); + snd_pcm_direct_reset_slave_ptr(pcm, dmix); err = snd_timer_start(dmix->timer); if (err < 0) return err; -- 2.7.4

2 9

[alsa-devel] [PATCH v4 00/22] soundwire: code cleanup
by Pierre-Louis Bossart 02 May '19

02 May '19

SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Changes since v3: patch 1,3,4 were merged for 5.2-rc1 No code change, only split patch2 in 21 patches to make Vinod happy. Each patch only fixes a specific issue. patch 5 is now patch22 and wasn't changed. Not sure why Vinod reported the patch didn't apply. Added Takashi's Reviewed-by tag in all patches since the code is exactly the same as in v3. Changes since v2: fixed inversion of devm_kcalloc parameters, detected while rebasing additional patches. Changes since v1: added missing newlines in new patch (suggested by Joe Perches) Pierre-Louis Bossart (22): soundwire: Kconfig: fix help format soundwire: fix SPDX license for header files soundwire: fix alignment issues in header files soundwire: bus: fix alignment issues soundwire: bus: fix typos in comments soundwire: bus: remove useless parentheses soundwire: bus: fix boolean comparisons soundwire: bus: remove spurious newline soundwire: bus_type: fix alignment issues soundwire: mipi_disco: fix alignment issues soundwire: mipi_disco: fix boolean comparisons soundwire: stream: fix alignment issues soundwire: slave: fix alignment issues soundwire: intel_init: fix alignment issues soundwire: intel: fix alignment issues soundwire: intel: protect macro parameters soundwire: intel: fix boolean comparison soundwire: cadence_master: fix alignment issues soundwire: cadence_master: balance parentheses soundwire: cadence_master: fix boolean comparisons soundwire: cadence_master: remove spurious newline soundwire: add missing newlines in dynamic debug logs drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c | 135 ++++++++------- drivers/soundwire/bus.h | 16 +- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 99 +++++------ drivers/soundwire/cadence_master.h | 22 +-- drivers/soundwire/intel.c | 99 ++++++----- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +- drivers/soundwire/mipi_disco.c | 116 +++++++------ drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 265 +++++++++++++++-------------- 12 files changed, 401 insertions(+), 383 deletions(-) -- 2.17.1

3 37

[alsa-devel] [PATCH][next] ASoC: SOF: remove redundant null checks of dai
by Colin King 02 May '19

02 May '19

From: Colin Ian King <colin.king(a)canonical.com> Currently there are two null checks of pointer dai in function sof_connect_dai_widget and yet there is no null check of dai at the end of the function when checking !dai->name. The latter would be a null pointer deference if dai is null (as picked up by static analysis), however the function is only ever called when dai is successfully allocated, so the null checks are redundant. Clean up the code by removing the null checks. Addresses-Coverity: ("Dereference after null check") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/sof/topology.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c index 2b9de1b97447..1f71857298a9 100644 --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -1127,15 +1127,13 @@ static int sof_connect_dai_widget(struct snd_soc_component *scomp, switch (w->id) { case snd_soc_dapm_dai_out: rtd->cpu_dai->capture_widget = w; - if (dai) - dai->name = rtd->dai_link->name; + dai->name = rtd->dai_link->name; dev_dbg(sdev->dev, "tplg: connected widget %s -> DAI link %s\n", w->name, rtd->dai_link->name); break; case snd_soc_dapm_dai_in: rtd->cpu_dai->playback_widget = w; - if (dai) - dai->name = rtd->dai_link->name; + dai->name = rtd->dai_link->name; dev_dbg(sdev->dev, "tplg: connected widget %s -> DAI link %s\n", w->name, rtd->dai_link->name); break; -- 2.20.1

1 0

[alsa-devel] [PATCH] ASoC: da7219: Update the support rate list
by Yu-Hsuan Hsu 02 May '19

02 May '19

If we want to set rate to 64000 on da7219, it fails and returns "snd_pcm_hw_params: Invalid argument". We should remove 64000 from support rate list because it is not available. Signed-off-by: Yu-Hsuan Hsu <yuhsuan(a)chromium.org> --- sound/soc/codecs/da7219.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 5f5fa3416af3..7497457cf3d4 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1658,20 +1658,26 @@ static const struct snd_soc_dai_ops da7219_dai_ops = { #define DA7219_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\ SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) +#define DA7219_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\ + SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\ + SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |\ + SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |\ + SNDRV_PCM_RATE_96000) + static struct snd_soc_dai_driver da7219_dai = { .name = "da7219-hifi", .playback = { .stream_name = "Playback", .channels_min = 1, .channels_max = DA7219_DAI_CH_NUM_MAX, - .rates = SNDRV_PCM_RATE_8000_96000, + .rates = DA7219_RATES, .formats = DA7219_FORMATS, }, .capture = { .stream_name = "Capture", .channels_min = 1, .channels_max = DA7219_DAI_CH_NUM_MAX, - .rates = SNDRV_PCM_RATE_8000_96000, + .rates = DA7219_RATES, .formats = DA7219_FORMATS, }, .ops = &da7219_dai_ops, -- 2.21.0.593.g511ec345e18-goog

2 1

[alsa-devel] [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
by mac.chiang＠intel.com 02 May '19

02 May '19

From: Mac Chiang <mac.chiang(a)intel.com> On kbl_rt5663_max98927, commit 38a5882e4292 ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE") This key pair mapping to play/pause when playing Youtube The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support. For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec The same fix is required on Chrome kbl_da7219_max98357a. Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> Reviewed-by: Benson Leung <bleung(a)chromium.org> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c index 38f6ab7..07491a0 100644 --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c @@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP); snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); -- 2.7.4

1 0

[alsa-devel] [PATCH v2 0/2] ASoC: CX2072X codec support (revised)
by Takashi Iwai 02 May '19

02 May '19

Hi, this is a revised patchset for ASoC CX2072X codec support on Intel platforms. v1->v2: Uncomment SOF entries in ACPI binding Move snd_soc_dai_set_bclk_ratio() call into init callback === It's been long time ago the first version of CX2072X codec patch was submitted, and I hoped that it'd be resubmitted, but never happened, as the original author seems to have left, unfortunately. Since I have such a laptop (ASUS E200HA), I took some time to cook and brush up the patches. The patches are for 5.2, should be applicable to ASoC tree for-next branch. Will post the corresponding UCM profile patch once when this gets accepted. thanks, Takashi === Simon Ho (1): ASoC: Add support for Conexant CX2072X CODEC Takashi Iwai (1): ASoC: Intel: Add machine driver for CX2072X on BYT/CHT platforms sound/soc/codecs/Kconfig | 7 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/cx2072x.c | 2197 +++++++++++++++++++++ sound/soc/codecs/cx2072x.h | 317 +++ sound/soc/intel/boards/Kconfig | 11 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/bytcht_cx2072x.c | 286 +++ sound/soc/intel/common/soc-acpi-intel-byt-match.c | 8 + sound/soc/intel/common/soc-acpi-intel-cht-match.c | 8 + 9 files changed, 2838 insertions(+) create mode 100644 sound/soc/codecs/cx2072x.c create mode 100644 sound/soc/codecs/cx2072x.h create mode 100644 sound/soc/intel/boards/bytcht_cx2072x.c -- 2.16.4

3 5