May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH V5] ASoC: fsl_esai: Fix missing break in switch statement
by S.j. Wang 08 May '19

08 May '19

case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break. Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Acked-by: Nicolin Chen <nicoleotsuka(a)gmail.com> Cc: <stable(a)vger.kernel.org> --- Changes in v5 - remove new line after Fixes Changes in v4 - Add acked-by Changes in v3 - Update subject line and cc stable Changes in v2 - Fix "Fixes" tag sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 3623aa9a6f2e..15202a637197 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI; - /* fall through */ + break; case ESAI_HCKR_EXTAL: ecr |= ESAI_ECR_ERI; break; -- 1.9.1

3 2

[alsa-devel] [PATCH v4 0/3] Fix jack detection for Chromebook Pixel
by Fletcher Woodruff 08 May '19

08 May '19

Headphone/mic jack detection doesn't work on the Chromebook Pixel 2015. This patch changes the irq implementation to support polarity flipping and fixes the configuration code so that correct GPIO pins are read from ACPI. With this series, plugging and unplugging the headphone jack switches between headphones and speakers automatically, and headset microphones are also detected. v4: - Fix incorrect void* cast in rt5677_irq() v3: - Update commit message for patch 1/3 to clarify why we implement our own irq_chip. v2: - Split IRQ change into two patches: adding and fixing potential race - Change config reading code to try both DT and ACPI style names Ben Zhang (1): ASoC: rt5677: allow multiple interrupt sources Fletcher Woodruff (2): ASoC: rt5677: handle concurrent interrupts ASoC: rt5677: fall back to DT prop names on error sound/soc/codecs/rt5677.c | 346 ++++++++++++++++++++++++++------------ sound/soc/codecs/rt5677.h | 14 +- 2 files changed, 256 insertions(+), 104 deletions(-) -- 2.21.0.1020.gf2820cf01a-goog

3 6

[alsa-devel] cs4265 : alsactl store and "C data buffer" fails
by Matt Flax 08 May '19

08 May '19

Hi, When alsactl store is run with a cs4265 chip, the following error occurs (from https://github.com/Audio-Injector/Ultra/issues/25) : $ sudo alsactl store alsactl: get_control:256: Cannot read control '2,0,0,C Data Buffer,0': Input/output error Upon commenting out the C data buffer control it works : https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs4265.c#L163 Can you suggest a suitable method for fixing this bug ? thanks Matt

2 2

[alsa-devel] [PATCH] Headset fixup for System76 Gazelle (gaze14)
by Jeremy Soller 08 May '19

08 May '19

On the System76 Gazelle (gaze14), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is identical to the patch already applied for the System76 Darter Pro (darp5). Signed-off-by: Jeremy Soller <jeremy(a)system76.com> --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f5b510f119ed..4ea3affad617 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6931,6 +6931,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS), SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE), SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),

2 2

[alsa-devel] Question: Selecting one codec from multiple codecs using rk3288_hdmi_analog driver
by Cheng-yi Chiang 08 May '19

08 May '19

Hi all, I am wondering whether it is possible to selectively play to one codec out of multiple codecs. There is a multiple codec usage in driver rk3288_hdmi_analog: https://github.com/torvalds/linux/blob/master/sound/soc/rockchip/rk3288_hdm… https://patchwork.kernel.org/patch/9554267/ I am not sure whether the driver supports playing to analog output or HDMI selectively one at a time ? I don't have a Firefly-RK3288 board to test that driver, but I have RK3288 veyron board. I followed the similar way like that driver does to support max98090 and HDMI on RK3288 veyron board. However, when I play to the device, it goes to both max98090 and HDMI codec. >From rk3288_hdmi_analog implementation, I failed to find out how to turn off HDMI codec when HDMI path is unwanted. The DAPM pin switch "HDMI" does not help since that even if DAPM path I2S Playback -> TX -> HDMI is turned off, the startup ops of HDMI codec is still called from soc_pcm_open path. Could someone please explain whether this is supported in the framework ? There seems to be two ways to achieve this One is to use TDM and select different channel for two codecs. The second is to add mixer controls and turn codec on/off to disable codec completely. But those requires changes on codec driver and the capability of TDM or mixer control on each codec. Maybe there should be a way to bypass startup ops of one of multiple codecs if it is unwanted ? Any help or suggestion is appreciated. Thanks!

1 0

[alsa-devel] [PATCH v1 0/2] ASoC: Intel: Add Cometlake PCI IDs
by Evan Green 07 May '19

07 May '19

This small series adds PCI IDs for Cometlake platforms, for a dazzling audio experience. Evan Green (2): ASoC: SOF: Add Comet Lake PCI ID ASoC: Intel: Skylake: Add Cometlake PCI IDs sound/soc/intel/Kconfig | 9 +++++++++ sound/soc/intel/skylake/skl-messages.c | 8 ++++++++ sound/soc/intel/skylake/skl.c | 5 +++++ sound/soc/sof/intel/Kconfig | 16 ++++++++++++++++ sound/soc/sof/sof-pci-dev.c | 4 ++++ 5 files changed, 42 insertions(+) -- 2.20.1

3 9

[alsa-devel] [PATCH] ALSA: hda/intel: add CometLake PCI IDs
by Pierre-Louis Bossart 07 May '19

07 May '19

Add PCI IDs for LP and H skews. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/pci/hda/hda_intel.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 789308f54785..0741eae23f10 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2378,6 +2378,12 @@ static const struct pci_device_id azx_ids[] = { /* Cannonlake */ { PCI_DEVICE(0x8086, 0x9dc8), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, + /* CometLake-LP */ + { PCI_DEVICE(0x8086, 0x02C8), + .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, + /* CometLake-H */ + { PCI_DEVICE(0x8086, 0x06C8), + .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, /* Icelake */ { PCI_DEVICE(0x8086, 0x34c8), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, -- 2.17.1

2 1

[alsa-devel] [asoc:for-5.2 248/316] sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup'
by kbuild test robot 07 May '19

07 May '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 head: f153bf49ddf6169544b24ef5ea26fa3eb4996b95 commit: 7e978fa37df7f771a5d02934ff828a0ee36bcf11 [248/316] ASoC: SOF: Add Build support for SOF core and Intel drivers config: i386-randconfig-l1-05071509 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: git checkout 7e978fa37df7f771a5d02934ff828a0ee36bcf11 # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): ld: sound/soc/sof/core.o: in function `sof_machine_check': >> sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup' vim +279 sound/soc/sof/core.c c16211d6 Liam Girdwood 2019-04-12 255 c16211d6 Liam Girdwood 2019-04-12 256 /* c16211d6 Liam Girdwood 2019-04-12 257 * SOF Driver enumeration. c16211d6 Liam Girdwood 2019-04-12 258 */ c16211d6 Liam Girdwood 2019-04-12 259 static int sof_machine_check(struct snd_sof_dev *sdev) c16211d6 Liam Girdwood 2019-04-12 260 { c16211d6 Liam Girdwood 2019-04-12 261 struct snd_sof_pdata *plat_data = sdev->pdata; c16211d6 Liam Girdwood 2019-04-12 262 struct snd_soc_acpi_mach *machine; c16211d6 Liam Girdwood 2019-04-12 263 int ret; c16211d6 Liam Girdwood 2019-04-12 264 c16211d6 Liam Girdwood 2019-04-12 265 if (plat_data->machine) c16211d6 Liam Girdwood 2019-04-12 266 return 0; c16211d6 Liam Girdwood 2019-04-12 267 c16211d6 Liam Girdwood 2019-04-12 268 if (!IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC)) { c16211d6 Liam Girdwood 2019-04-12 269 dev_err(sdev->dev, "error: no matching ASoC machine driver found - aborting probe\n"); c16211d6 Liam Girdwood 2019-04-12 270 return -ENODEV; c16211d6 Liam Girdwood 2019-04-12 271 } c16211d6 Liam Girdwood 2019-04-12 272 c16211d6 Liam Girdwood 2019-04-12 273 /* fallback to nocodec mode */ c16211d6 Liam Girdwood 2019-04-12 274 dev_warn(sdev->dev, "No ASoC machine driver found - using nocodec\n"); c16211d6 Liam Girdwood 2019-04-12 275 machine = devm_kzalloc(sdev->dev, sizeof(*machine), GFP_KERNEL); c16211d6 Liam Girdwood 2019-04-12 276 if (!machine) c16211d6 Liam Girdwood 2019-04-12 277 return -ENOMEM; c16211d6 Liam Girdwood 2019-04-12 278 c16211d6 Liam Girdwood 2019-04-12 @279 ret = sof_nocodec_setup(sdev->dev, plat_data, machine, c16211d6 Liam Girdwood 2019-04-12 280 plat_data->desc, plat_data->desc->ops); c16211d6 Liam Girdwood 2019-04-12 281 if (ret < 0) c16211d6 Liam Girdwood 2019-04-12 282 return ret; c16211d6 Liam Girdwood 2019-04-12 283 c16211d6 Liam Girdwood 2019-04-12 284 plat_data->machine = machine; c16211d6 Liam Girdwood 2019-04-12 285 c16211d6 Liam Girdwood 2019-04-12 286 return 0; c16211d6 Liam Girdwood 2019-04-12 287 } c16211d6 Liam Girdwood 2019-04-12 288 :::::: The code at line 279 was first introduced by commit :::::: c16211d6226dbde8819b84da07508083a1138a06 ASoC: SOF: Add Sound Open Firmware driver core :::::: TO: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

[alsa-devel] Right internal speaker and internal microphone doesn't seem to work
by Drago Praznik 07 May '19

07 May '19

My Mint 19 (kernel: 4.15.0-48-generic) on Lenovo V110 never succeeded to use an internal microphone and the right internal speaker also doesn't seem to work. Previously I tried to install Windows 10 and all the hardware works normally whilst using Win10. Here's some additional info of my setup: http://alsa-project.org/db/?f=9e9d2f773b9682f2dbd2a22cd1f4fd0613eb0a2d Originally I submitted a post on forum: https://forums.linuxmint.com/viewtopic.php?f=49&t=292732 ... since it didn't help, I ended up here. Cheers, Drago

3 4

[alsa-devel] [asoc:for-5.2 248/316] ld: sound/soc/sof/sof-acpi-dev.o:undefined reference to `sof_xtensa_arch_ops'
by kbuild test robot 07 May '19

07 May '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 head: f153bf49ddf6169544b24ef5ea26fa3eb4996b95 commit: 7e978fa37df7f771a5d02934ff828a0ee36bcf11 [248/316] ASoC: SOF: Add Build support for SOF core and Intel drivers config: i386-randconfig-l0-05071509 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: git checkout 7e978fa37df7f771a5d02934ff828a0ee36bcf11 # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): >> ld: sound/soc/sof/sof-acpi-dev.o:(.rodata+0x120): undefined reference to `sof_xtensa_arch_ops' ld: sound/soc/sof/sof-acpi-dev.o:(.rodata+0x180): undefined reference to `sof_xtensa_arch_ops' ld: sound/soc/sof/sof-acpi-dev.o:(.rodata+0x1e0): undefined reference to `sof_xtensa_arch_ops' --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1