May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: hda: increment codec device refcount when it is added to the card
by Ranjani Sridharan 31 May '19

31 May '19

Calling snd_device_new() makes the codec devices managed by the card. So, when the card is removed, the refcount for the codec device is decremented and results in the codec device's kobject being cleaned up if the refcount is 0. But, this leads to a NULL pointer exception while attempting to remove the symlinks when the codec driver is released later on. Therefore, increment the codec device's refcount before adding it to the card to prevent this. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- sound/pci/hda/hda_codec.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index b20eb7fc83eb..0d5d95b07e19 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -985,6 +985,14 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card, codec->core.subsystem_id, codec->core.revision_id); snd_component_add(card, component); + /* + * snd_device_new() makes the codec device managed by the card. + * When the card is removed, the device reference count is + * decremented. Therefore, increment it here to prevent removing + * the codec device's kobject when the card is removed. + */ + get_device(hda_codec_dev(codec)); + err = snd_device_new(card, SNDRV_DEV_CODEC, codec, &dev_ops); if (err < 0) goto error; -- 2.17.1

3 11

[alsa-devel] [PATCH] ASoC: hdac_hda: Fix unbalanced bus link refcount at probe error
by Takashi Iwai 31 May '19

31 May '19

The error paths in hdac_hda_codec_probe() don't take care of the bus link refcount properly, which leave the refcount still high. This patch addresses them. Fixes: 6bae5ea94989 ("ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- A bug I found while digging for another problem :) sound/soc/codecs/hdac_hda.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index 7d4940256914..b55deaeb1ebf 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -475,8 +475,10 @@ static int hdac_hda_dev_probe(struct hdac_device *hdev) snd_hdac_ext_bus_link_get(hdev->bus, hlink); hda_pvt = hdac_to_hda_priv(hdev); - if (!hda_pvt) - return -ENOMEM; + if (!hda_pvt) { + ret = -ENOMEM; + goto error; + } /* ASoC specific initialization */ ret = devm_snd_soc_register_component(&hdev->dev, @@ -484,12 +486,13 @@ static int hdac_hda_dev_probe(struct hdac_device *hdev) ARRAY_SIZE(hdac_hda_dais)); if (ret < 0) { dev_err(&hdev->dev, "failed to register HDA codec %d\n", ret); - return ret; + goto error; } dev_set_drvdata(&hdev->dev, hda_pvt); - snd_hdac_ext_bus_link_put(hdev->bus, hlink); + error: + snd_hdac_ext_bus_link_put(hdev->bus, hlink); return ret; } -- 2.16.4

2 2

[alsa-devel] [PATCH v8 0/6] drm/bridge: sii902x: HDMI-audio support and some fixes
by Jyri Sarha 31 May '19

31 May '19

I think these should be ready for applying to drm-misc. Changes since v7: - Debased on top of the lasts drm-misc-next and tested - "dt-bindings: display: sii902x: Add HDMI audio bindings" - Dropped off "or higher to avoid conflict with video ports" and added "Reviewed-by: Rob Herring <robh(a)kernel.org>" Ther previous round: https://patchwork.kernel.org/cover/10919173/ Jyri Sarha (5): drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz dt-bindings: display: sii902x: Remove trailing white space dt-bindings: display: sii902x: Add HDMI audio bindings drm/bridge: sii902x: Implement HDMI audio support Tomi Valkeinen (1): drm/bridge: sii902x: add input_bus_flags .../bindings/display/bridge/sii902x.txt | 42 +- drivers/gpu/drm/bridge/sii902x.c | 488 +++++++++++++++++- 2 files changed, 522 insertions(+), 8 deletions(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 7

[alsa-devel] [BISECT] No audio after "ASoC: core: use component driver name as component name"
by Krzysztof Kozlowski 31 May '19

31 May '19

Hi, Bisect points to commit b19671d6caf1ac393681864d5d85dda9fa99a448 Author: Tzung-Bi Shih <tzungbi(a)google.com> Date: Wed May 29 14:22:14 2019 +0800 ASoC: core: use component driver name as component name as a reason of failure of missing Audio card on Odroid XU3 board (ARMv7, Exynos5422, max98090 codec). Full kernel log: https://krzk.eu/#/builders/1/builds/3349/steps/14/logs/serial0 The problem might be in component name. The driver->name and fmt_single_name(dev, &component->id) are: snd_dmaengine_pcm != 3830000.i2s snd_dmaengine_pcm != 3830000.i2s-sec samsung-i2s != 3830000.i2s This commit should not go in without fixing the users of old behavior... I could adjust the platform names for primary and secondary links... but now it looks like two components will have the same name. Best regards, Krzysztof

3 2

[alsa-devel] aplay - pcm_read: Input/output error
by GitHub issues - edited 31 May '19

31 May '19

alsa-project/alsa-lib issue #7 was edited from mrajwa: Hello, I came across an issue with custom built aplay (system one works OK on Ubuntu 18.04): I have fetched both alsa-lib and alsa-utils repositories, built them now try to run: `path_to_aplay/aplay -C -D hw:0,8 -r 16000 -f S16_LE -c 2 tmp.wav -vvv` Immediately after the start it prints hw params and the error message saying: `arecord: pcm_read:2103: read errorL Input/output error` As I said system aplay works fine. Moreover I compared hw params for both system and this custom built aplay and they are exactly the same! I also tried to built alsa-utils from debian package here I did: `apt source alsa-lib && sudo apt build-dep alsa-utils && fakeroot debian/rules clean && fakeroot debian/rules build && fakeroot debian/rules binary` All finished fine, now I repeated above steps for alsa-utils and here is a problem at `fakeroot debian/rules binary` step. At some point it stops with an error message saying: `dpkg-shlibdeps: error: no dependency information found for /usr/lib/libasound.co.s2 (used by debian/alsa-utils/usr/bin/alsaucm)` Does anybody have any idea what is going on here? Issue URL : https://github.com/alsa-project/alsa-lib/issues/7 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] aplay - pcm_read: Input/output error
by GitHub issues - edited 31 May '19

31 May '19

alsa-project/alsa-lib issue #7 was edited from mrajwa: Hello, I came across an issue with custom built aplay (system one works OK on Ubuntu 18.04): I have fetched both alsa-lib and alsa-utils repositories, built them now try to run: `path_to_aplay/aplay -C -D hw:0,8 -r 16000 -f S16_LE -c 2 tmp.wav -vvv` Immediately after the start it prints hw params and the error message saying: `arecord: pcm_read:2103: read errorL Input/output error` As I said system aplay works fine. Moreover I compared hw params for both system and this custom built aplay and they are exactly the same! I also tried to built alsa-utils from debian package here I did: apt source alsa-lib && sudo apt build-dep alsa-utils && fakeroot debian/rules clean && fakeroot debian/rules build && fakeroot debian/rules binary All finished fine, now I repeated above steps for alsa-utils and here is aproblem at fakeroot debian/rules binary step. At some point it stops with error message saying: `dpkg-shlibdeps: error: no dependency information found for /usr/lib/libasound.co.s2 (used by debian/alsa-utils/usr/bin/alsaucm)` Does anybody have any idea what is going on here? Issue URL : https://github.com/alsa-project/alsa-lib/issues/7 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] aplay - pcm_read: Input/output error
by GitHub issues - opened 31 May '19

31 May '19

alsa-project/alsa-lib issue #7 was opened from mrajwa: Hello, I came across an issue with custom built aplay (system one works OK on Ubuntu 18.04): I have fetched both alsa-lib and alsa-utils repositories, built them now try to run: `path_to_aplay/aplay -C -D hw:0,8 -r 16000 -f S16_LE -c 2 tmp.wav -vvv` Immediately after the start it prints hw_params and the and error message saying: `arecord: pcm_read:2103: read errorL Input/output error` As I said system aplay works fine. Moreover I compared hw_params for both system and this custom built aplay and they are exactly the same! I also tried to built alsa-utils from debian package here I did: apt source alsa-lib && sudo apt build-dep alsa-utils && fakeroot debian/rules clean && fakeroot debian/rules build && fakeroot debian/rules binary All finished fine, now I repeated above steps for alsa-utils and here is aproblem at fakeroot debian/rules binary step. At some point it stops with error message saying: `dpkg-shlibdeps: error: no dependency information found for /usr/lib/libasound.co.s2 (used by debian/alsa-utils/usr/bin/alsaucm)` Does anybody have any idea what is going on here? Issue URL : https://github.com/alsa-project/alsa-lib/issues/7 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] [PATCH] Revert "ASoC: core: use component driver name as component name"
by Krzysztof Kozlowski 31 May '19

31 May '19

Using component driver as a name is not unique and it breaks audio in certain configurations, e.g. Hardkernel Odroid XU3 board where following components are registered: - 3830000.i2s with driver snd_dmaengine_pcm - 3830000.i2s-sec with driver snd_dmaengine_pcm - 3830000.i2s with driver 3830000.i2s-sec This reverts commit b19671d6caf1ac393681864d5d85dda9fa99a448. Signed-off-by: Krzysztof Kozlowski <krzk(a)kernel.org> --- sound/soc/soc-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 2d3520fca613..7abb017a83f3 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3113,10 +3113,7 @@ static int snd_soc_component_initialize(struct snd_soc_component *component, { struct snd_soc_dapm_context *dapm; - if (driver->name) - component->name = kstrdup(driver->name, GFP_KERNEL); - else - component->name = fmt_single_name(dev, &component->id); + component->name = fmt_single_name(dev, &component->id); if (!component->name) { dev_err(dev, "ASoC: Failed to allocate name\n"); return -ENOMEM; -- 2.7.4

1 0

[alsa-devel] [PATCH 0/3] ALSA: trivial conversions to struct_size()
by Takashi Iwai 31 May '19

31 May '19

Hi, there are a few more places that can be better written with struct_size() macro. Let's replace them. Takashi === Takashi Iwai (3): ALSA: control: Use struct_size() ALSA: hda: Use struct_size() ALSA: hda/ca0132: Use struct_size() sound/core/control.c | 6 +----- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/patch_ca0132.c | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) -- 2.16.4

1 3

[alsa-devel] ALC256 headset mode update
by Kailang 31 May '19

31 May '19

Hi Takashi, Since ALC256 was used for many machines. So, update ALC256 headset mode for separate with ALC255. Many Thanks. BR, Kailang

2 1