May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Fwd: Problem with aplay params
by Martin R 31 May '19

31 May '19

Hello, I have built aplay using github repository https://github.com/alsa-project/alsa-utils/ as well as https://github.com/thesofproject/alsa-lib. Now when I try to run it by "./path_to_aplay/aplay -C -D hw:0,8 -r 16000 -f S16_LE -c 2 tmp.wav -vvv I get immediate error message saying: arecord: pcm_read:2150 read error: Input/output error. Why is it failing? The system aplay/arecord works OK - only the one I built fails with above error. PS: system aplay version is 1.1.8 while the one built by me is 1.19 Regards, Marcin

1 0

[alsa-devel] Question about dapm setup
by Kuninori Morimoto 31 May '19

31 May '19

Hi ALSA ML snd_soc_instantiate_card() setups dapm, but its timing seems very randomly for me. In my understanding, dapm setup timing is not so serious. So, I think we can do it in one place, but are there some reasons ? For example, "xxxx should be called after yyyy" static int snd_soc_instantiate_card(struct snd_soc_card *card) { ... => snd_soc_dapm_debugfs_init(&card->dapm, card->debugfs_card_root); ... if (card->dapm_widgets) snd_soc_dapm_new_controls(&card->dapm, card->dapm_widgets, card->num_dapm_widgets); if (card->of_dapm_widgets) snd_soc_dapm_new_controls(&card->dapm, card->of_dapm_widgets, card->num_of_dapm_widgets); ... snd_soc_dapm_link_dai_widgets(card); snd_soc_dapm_connect_dai_link_widgets(card); if (card->controls) snd_soc_add_card_controls(card, card->controls, card->num_controls); if (card->dapm_routes) snd_soc_dapm_add_routes(&card->dapm, card->dapm_routes, card->num_dapm_routes); if (card->of_dapm_routes) snd_soc_dapm_add_routes(&card->dapm, card->of_dapm_routes, card->num_of_dapm_routes); ... snd_soc_dapm_new_widgets(card); ... dapm_mark_endpoints_dirty(card); snd_soc_dapm_sync(&card->dapm); ... } Thank you for your help !! Best regards --- Kuninori Morimoto

2 4

[alsa-devel] [PATCH V2] ASoC: Intel: Baytrail: add quirk for Aegex 10 (RU2) tablet
by Kovács Tamás 30 May '19

30 May '19

This tablet has an incorrect acpi identifier just like Thinkpad10 tablet, which is why it is trying to load the RT5640 driver instead of the RT5762 driver. The RT5640 driver, on the other hand, checks the hardware ID, so no driver are loaded during boot. This fix resolves to load the RT5672 driver on this tablet during boot. It also provides the correct IO configuration, like the jack detect mode 3, for 1.8V pullup. I would like to thank Pierre-Louis Bossart for helping with this patch. --- sound/soc/codecs/rt5670.c | 14 +------------- .../intel/common/soc-acpi-intel-byt-match.c | 19 +------------------ 2 files changed, 2 insertions(+), 31 deletions(-) diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c index 37cce0439568..9a037108b1ae 100644 --- a/sound/soc/codecs/rt5670.c +++ b/sound/soc/codecs/rt5670.c @@ -2882,18 +2882,6 @@ static const struct dmi_system_id dmi_platform_intel_quirks[] = { RT5670_DEV_GPIO | RT5670_JD_MODE3), }, - { - .callback = rt5670_quirk_cb, - .ident = "Aegex 10 tablet (RU2)", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "AEGEX"), - DMI_MATCH(DMI_PRODUCT_VERSION, "RU2"), - }, - .driver_data = (unsigned long *)(RT5670_DMIC_EN | - RT5670_DMIC2_INR | - RT5670_DEV_GPIO | - RT5670_JD_MODE3), - }, {} }; diff --git a/sound/soc/intel/common/soc-acpi-intel-byt-match.c b/sound/soc/intel/common/soc-acpi-intel-byt-match.c index cfed58c23e0b..fe812a909db4 100644 --- a/sound/soc/intel/common/soc-acpi-intel-byt-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-byt-match.c @@ -22,7 +22,6 @@ static unsigned long byt_machine_id; #define BYT_THINKPAD_10 1 #define BYT_POV_P1006W 2 -#define BYT_AEGEX_10 3 static int byt_thinkpad10_quirk_cb(const struct dmi_system_id *id) { @@ -36,12 +35,6 @@ static int byt_pov_p1006w_quirk_cb(const struct dmi_system_id *id) return 1; } -static int byt_aegex10_quirk_cb(const struct dmi_system_id *id) -{ - byt_machine_id = BYT_AEGEX_10; - return 1; -} - static const struct dmi_system_id byt_table[] = { { .callback = byt_thinkpad10_quirk_cb, @@ -82,18 +75,9 @@ static const struct dmi_system_id byt_table[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"), }, }, - { - /* Aegex 10 tablet (RU2) */ - .callback = byt_aegex10_quirk_cb, - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "AEGEX"), - DMI_MATCH(DMI_PRODUCT_VERSION, "RU2"), - }, - }, { } }; -/* The Thinkapd 10 and Aegex 10 tablets have the same ID problem */ static struct snd_soc_acpi_mach byt_thinkpad_10 = { .id = "10EC5640", .drv_name = "cht-bsw-rt5672", @@ -120,7 +104,6 @@ static struct snd_soc_acpi_mach *byt_quirk(void *arg) switch (byt_machine_id) { case BYT_THINKPAD_10: - case BYT_AEGEX_10: return &byt_thinkpad_10; case BYT_POV_P1006W: return &byt_pov_p1006w;

2 1

[alsa-devel] [PATCH] ASoC: rt5677: Add missing voice activation register definitions
by Curtis Malainey 30 May '19

30 May '19

Most of the voice activation definitions were missing, they will be needed for when hotwording is added. Also the source bits are only 2 wide not 3 and needed to be corrected. Signed-off-by: Curtis Malainey <cujomalainey(a)chromium.org> --- sound/soc/codecs/rt5677.h | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5677.h b/sound/soc/codecs/rt5677.h index 11a2ffceec3b..076e5161d8da 100644 --- a/sound/soc/codecs/rt5677.h +++ b/sound/soc/codecs/rt5677.h @@ -1456,9 +1456,37 @@ #define RT5677_I2S4_CLK_SEL_MASK (0xf) #define RT5677_I2S4_CLK_SEL_SFT 0 +/* VAD Function Control 1 (0x9c) */ +#define RT5677_VAD_MIN_DUR_MASK (0x3 << 13) +#define RT5677_VAD_MIN_DUR_SFT 13 +#define RT5677_VAD_ADPCM_BYPASS (1 << 10) +#define RT5677_VAD_ADPCM_BYPASS_BIT 10 +#define RT5677_VAD_FG2ENC (1 << 9) +#define RT5677_VAD_FG2ENC_BIT 9 +#define RT5677_VAD_BUF_OW (1 << 8) +#define RT5677_VAD_BUF_OW_BIT 8 +#define RT5677_VAD_CLR_FLAG (1 << 7) +#define RT5677_VAD_CLR_FLAG_BIT 7 +#define RT5677_VAD_BUF_POP (1 << 6) +#define RT5677_VAD_BUF_POP_BIT 6 +#define RT5677_VAD_BUF_PUSH (1 << 5) +#define RT5677_VAD_BUF_PUSH_BIT 5 +#define RT5677_VAD_DET_ENABLE (1 << 4) +#define RT5677_VAD_DET_ENABLE_BIT 4 +#define RT5677_VAD_FUNC_ENABLE (1 << 3) +#define RT5677_VAD_FUNC_ENABLE_BIT 3 +#define RT5677_VAD_FUNC_RESET (1 << 2) +#define RT5677_VAD_FUNC_RESET_BIT 2 + /* VAD Function Control 4 (0x9f) */ -#define RT5677_VAD_SRC_MASK (0x7 << 8) +#define RT5677_VAD_OUT_SRC_RATE_MASK (0x1 << 11) +#define RT5677_VAD_OUT_SRC_RATE_SFT 11 +#define RT5677_VAD_OUT_SRC_MASK (0x1 << 10) +#define RT5677_VAD_OUT_SRC_SFT 10 +#define RT5677_VAD_SRC_MASK (0x3 << 8) #define RT5677_VAD_SRC_SFT 8 +#define RT5677_VAD_LV_DIFF_MASK (0xff << 0) +#define RT5677_VAD_LV_DIFF_SFT 0 /* DSP InBound Control (0xa3) */ #define RT5677_IB01_SRC_MASK (0x7 << 12) -- 2.22.0.rc1.257.g3120a18244-goog

2 1

[alsa-devel] [PATCH 0/5] ASoC: Intel: fix cross-compilation/COMPILE_TEST issues
by Pierre-Louis Bossart 30 May '19

30 May '19

The Intel code has dependencies that aren't defined on all platforms and prevent COMPILE_TEST from working. The first patch was submitted as an RFC and includes Takashi Reviewed-by tag. The second patch was submitted by Randy Dunlap, I only corrected minor issues to make it more generic. The rest are just simple fixes to remove useless asm/ headers, make sure all machine drivers use COMPILE_TEST and add dependencies on CONFIG_PCI to let the SOF code support COMPILE_TEST. Tested for the following ARCH: x86_64, i386, ia64, arm, arm64, sh, mips, openrisc, sparc, m68k, s390 Pierre-Louis Bossart (4): ASoC: Intel: use common helpers to detect CPUs ASoC: Intel: boards: remove dependency on asm/platform_sst_audio.h ASoC: Intel: boards: Add COMPILE_TEST for new machine drivers ASoC: SOF: add COMPILE_TEST for PCI options Randy Dunlap (1): ASoc: fix sound/soc/intel/skylake/slk-ssp-clk.c build error on IA64 sound/soc/intel/Kconfig | 9 ++ sound/soc/intel/atom/sst/sst_acpi.c | 65 +--------- sound/soc/intel/boards/Kconfig | 7 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 11 +- sound/soc/intel/boards/bytcht_cx2072x.c | 1 - sound/soc/intel/boards/bytcht_da7213.c | 1 - sound/soc/intel/boards/bytcht_es8316.c | 13 +- sound/soc/intel/boards/bytcr_rt5640.c | 16 +-- sound/soc/intel/boards/bytcr_rt5651.c | 17 +-- sound/soc/intel/boards/cht_bsw_rt5645.c | 16 +-- sound/soc/intel/boards/sof_rt5682.c | 11 +- sound/soc/intel/common/soc-intel-quirks.h | 115 ++++++++++++++++++ sound/soc/sof/Kconfig | 2 +- sound/soc/sof/intel/hda.c | 13 +- sound/soc/sof/sof-acpi-dev.c | 57 +-------- sound/soc/sof/sof-pci-dev.c | 4 + 16 files changed, 164 insertions(+), 194 deletions(-) create mode 100644 sound/soc/intel/common/soc-intel-quirks.h -- 2.20.1

2 10

[alsa-devel] [PATCH v3 0/9] ASoC: SOF: stability fixes
by Pierre-Louis Bossart 30 May '19

30 May '19

No new functionality here but fixes to the IPC, memory allocation, workqueues, control, runtime_pm and HDaudio support. These issues were identified during the integration/productization of new platforms. I added a 'Fixes' tag to make sure backports/stable can pick up these patches, in case it's too late for them to land in 5.2 The next batch for SOF will be a set of new capabilities for trace, IPC test, Hdaudio support, they will be submitted after additional tests and once these fixes are reviewed/merged. Thanks! Changes since v2: Removed 3 patches (Hdaudio memory allocation changes, will be resubmitted when unclear system freeze is sorted out + patch already merged by Mark) Corrected merge issue with IPC patch from Guennadi Changes since v1: Feedback from Takashi: use spin_lock_irq instead of spin_lock_irq_save Added Takashi's Reviewed-by tag Guennadi Liakhovetski (1): ASoC: SOF: ipc: fix a race, leading to IPC timeouts Keyon Jie (1): ASoC: SOF: control: correct the copy size for bytes kcontrol put Libin Yang (1): ASoC: SOF: pcm: clear hw_params_upon_resume flag correctly Pierre-Louis Bossart (2): ASoC: SOF: core: fix error handling with the probe workqueue ASoC: SOF: pcm: remove warning - initialize workqueue on open Ranjani Sridharan (2): ASoC: SOF: core: remove DSP after unregistering machine driver ASoC: SOF: core: remove snd_soc_unregister_component in case of error Zhu Yingjiang (2): ASoC: SOF: Intel: hda: fix the hda init chip ASoC: SOF: Intel: hda: use the defined ppcap functions sound/soc/sof/control.c | 9 +-- sound/soc/sof/core.c | 29 +++++++-- sound/soc/sof/intel/bdw.c | 9 ++- sound/soc/sof/intel/byt.c | 10 +-- sound/soc/sof/intel/cnl.c | 4 ++ sound/soc/sof/intel/hda-ctrl.c | 102 +++++++++++++++++++++++++++--- sound/soc/sof/intel/hda-ipc.c | 17 ++++- sound/soc/sof/intel/hda.c | 109 +++++++-------------------------- sound/soc/sof/ipc.c | 13 ---- sound/soc/sof/pcm.c | 8 +-- 10 files changed, 176 insertions(+), 134 deletions(-) base-commit: 188d45fe779eeb8e3521b59fcb12cc48a6f2c203 -- 2.20.1

2 18

[alsa-devel] [PATCH] ASoC: SOF: uapi headers - add missing include for stdint.h
by Jaroslav Kysela 30 May '19

30 May '19

The modified header files depend on types defined in <stdint.h>. Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> Cc: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Cc: Takashi Iwai <tiwai(a)suse.de> Cc: Mark Brown <broonie(a)kernel.org> --- include/uapi/sound/sof/eq.h | 4 ++++ include/uapi/sound/sof/fw.h | 4 ++++ include/uapi/sound/sof/header.h | 4 ++++ include/uapi/sound/sof/manifest.h | 4 ++++ include/uapi/sound/sof/trace.h | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/include/uapi/sound/sof/eq.h b/include/uapi/sound/sof/eq.h index 666c2b6a3229..106d56e357e0 100644 --- a/include/uapi/sound/sof/eq.h +++ b/include/uapi/sound/sof/eq.h @@ -9,6 +9,10 @@ #ifndef __INCLUDE_UAPI_SOUND_SOF_USER_EQ_H__ #define __INCLUDE_UAPI_SOUND_SOF_USER_EQ_H__ +#ifndef __KERNEL__ +#include <stdint.h> +#endif + /* FIR EQ type */ #define SOF_EQ_FIR_IDX_SWITCH 0 diff --git a/include/uapi/sound/sof/fw.h b/include/uapi/sound/sof/fw.h index 1afca973eb09..4f2de19a3b86 100644 --- a/include/uapi/sound/sof/fw.h +++ b/include/uapi/sound/sof/fw.h @@ -13,6 +13,10 @@ #ifndef __INCLUDE_UAPI_SOF_FW_H__ #define __INCLUDE_UAPI_SOF_FW_H__ +#ifndef __KERNEL__ +#include <stdint.h> +#endif + #define SND_SOF_FW_SIG_SIZE 4 #define SND_SOF_FW_ABI 1 #define SND_SOF_FW_SIG "Reef" diff --git a/include/uapi/sound/sof/header.h b/include/uapi/sound/sof/header.h index 7868990b0d6f..6a62ae8f0eb9 100644 --- a/include/uapi/sound/sof/header.h +++ b/include/uapi/sound/sof/header.h @@ -9,6 +9,10 @@ #ifndef __INCLUDE_UAPI_SOUND_SOF_USER_HEADER_H__ #define __INCLUDE_UAPI_SOUND_SOF_USER_HEADER_H__ +#ifndef __KERNEL__ +#include <stdint.h> +#endif + /* * Header for all non IPC ABI data. * diff --git a/include/uapi/sound/sof/manifest.h b/include/uapi/sound/sof/manifest.h index 2009ee30fad0..d57aa2bc4764 100644 --- a/include/uapi/sound/sof/manifest.h +++ b/include/uapi/sound/sof/manifest.h @@ -9,6 +9,10 @@ #ifndef __INCLUDE_UAPI_SOUND_SOF_USER_MANIFEST_H__ #define __INCLUDE_UAPI_SOUND_SOF_USER_MANIFEST_H__ +#ifndef __KERNEL__ +#include <stdint.h> +#endif + /* start offset for base FW module */ #define SOF_MAN_ELF_TEXT_OFFSET 0x2000 diff --git a/include/uapi/sound/sof/trace.h b/include/uapi/sound/sof/trace.h index ffa7288a0f16..1652bc08d576 100644 --- a/include/uapi/sound/sof/trace.h +++ b/include/uapi/sound/sof/trace.h @@ -9,6 +9,10 @@ #ifndef __INCLUDE_UAPI_SOUND_SOF_USER_TRACE_H__ #define __INCLUDE_UAPI_SOUND_SOF_USER_TRACE_H__ +#ifndef __KERNEL__ +#include <stdint.h> +#endif + /* * Host system time. * -- 2.20.1

3 3

Re: [alsa-devel] Merging the new firmware files for CA0132 into alsa-firmware
by Jaroslav Kysela 30 May '19

30 May '19

Dne 28. 05. 19 v 16:54 Takashi Iwai napsal(a): > Hi, > > it seems that Connor's previous attempt to put a couple of ca0132 > firmware files into linux-firmware tree didn't go through, > unfortunately. And now I'm thinking of taking them into alsa-firmware > package as a stop-gap. We already distribute other ca0132 firmware > files, so the addition shouldn't be a big problem. > > Jaroslav, what do you think? No problem. The same situation is for the SoC SOF firmware files (drivers are in kernel, firmware files are missing). Perhaps, we can release those files quickly in alsa-firmware and then migrate them slowly to linux-firmware. Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

5 14

[alsa-devel] [PATCH] ALSA: hda: fix: lock reg_lock before calling snd_hdac_bus_update_rirb
by Bard liao 30 May '19

30 May '19

From: Bard Liao <yung-chuan.liao(a)linux.intel.com> The patch is to fix commit 5e13cf6cd64c (ALSA: hda: add polling mode in snd_hdac_bus_get_response) spin_lock_irq should be called before snd_hdac_bus_update_rirb. Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- Takashi, Sorry, I make a mistake on the "ALSA: hda: add polling mode in snd_hdac_bus_get_response" patch. This patch is a fix for that. Thanks, Bard --- sound/hda/hdac_controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index a16ac31bda83..d6a91429c058 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -239,9 +239,9 @@ int snd_hdac_bus_get_response(struct hdac_bus *bus, unsigned int addr, timeout = jiffies + msecs_to_jiffies(1000); for (loopcounter = 0;; loopcounter++) { + spin_lock_irq(&bus->reg_lock); if (bus->polling_mode) snd_hdac_bus_update_rirb(bus); - spin_lock_irq(&bus->reg_lock); if (!bus->rirb.cmds[addr]) { if (res) *res = bus->rirb.res[addr]; /* the last value */ -- 2.17.1

2 1

[alsa-devel] [PATCH 4.9 107/128] ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put
by Greg Kroah-Hartman 30 May '19

30 May '19

[ Upstream commit c705247136a523488eac806bd357c3e5d79a7acd ] The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/fsl/fsl_utils.c:74:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 38, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99(a)zte.com.cn> Cc: Timur Tabi <timur(a)kernel.org> Cc: Nicolin Chen <nicoleotsuka(a)gmail.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: Fabio Estevam <festevam(a)gmail.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: alsa-devel(a)alsa-project.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/fsl/fsl_utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c index b9e42b503a377..4f8bdb7650e84 100644 --- a/sound/soc/fsl/fsl_utils.c +++ b/sound/soc/fsl/fsl_utils.c @@ -75,6 +75,7 @@ int fsl_asoc_get_dma_channel(struct device_node *ssi_np, iprop = of_get_property(dma_np, "cell-index", NULL); if (!iprop) { of_node_put(dma_np); + of_node_put(dma_channel_np); return -EINVAL; } *dma_id = be32_to_cpup(iprop); -- 2.20.1

1 0