December 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Don't use 16 bit signed integers for sample rate conversion.
by GitHub issues - edited 17 Dec '19

17 Dec '19

alsa-project/alsa-plugins issue #5 was edited from crocket: Sample rate conversion should be done with the highest resolution possible. Maybe, double, unsigned int, or unsigned int64? Once sample rate conversion is done, using S32_LE is meaningless. Does dmix also use 16bits internally? Issue URL : https://github.com/alsa-project/alsa-plugins/issues/5 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[alsa-devel] [PATCH for-5.6 00/14] media: ALSA PCM API updates
by Takashi Iwai 17 Dec '19

17 Dec '19

Hi, this is a patch set to adapt the latest ALSA PCM API to media drivers. Basically these are merely cleanups, as shown in diffstat, and there should be no functional changes. As the corresponding ALSA PCM API change is found in 5.5-rc1, please apply these on 5.5-rc1 or later. Or if you prefer, I can merge them through sound tree, too. Let me know. thanks, Takashi === Takashi Iwai (14): media: solo6x10: Use managed buffer allocation media: tw686x: Use managed buffer allocation media: usbtv: Use managed buffer allocation media: cobalt: Clean up ALSA PCM API usages media: cx18: Clean up ALSA PCM API usages media: ivtv: Clean up ALSA PCM API usages media: cs231xx: Clean up ALSA PCM API usages media: em28xx: Clean up ALSA PCM API usages media: go7007: Clean up ALSA PCM API usages media: tm6000: Clean up ALSA PCM API usages media: cobalt: Drop superfluous ioctl PCM ops media: cx18: Drop superfluous ioctl PCM ops media: ivtv: Drop superfluous ioctl PCM ops media: Drop superfluous ioctl PCM ops drivers/media/pci/cobalt/cobalt-alsa-pcm.c | 69 ++---------------------- drivers/media/pci/cx18/cx18-alsa-pcm.c | 75 +------------------------- drivers/media/pci/cx23885/cx23885-alsa.c | 1 - drivers/media/pci/cx25821/cx25821-alsa.c | 1 - drivers/media/pci/cx88/cx88-alsa.c | 1 - drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 76 +------------------------- drivers/media/pci/saa7134/saa7134-alsa.c | 1 - drivers/media/pci/solo6x10/solo6x10-g723.c | 24 ++------- drivers/media/pci/tw686x/tw686x-audio.c | 16 +----- drivers/media/usb/cx231xx/cx231xx-audio.c | 79 +-------------------------- drivers/media/usb/em28xx/em28xx-audio.c | 87 +----------------------------- drivers/media/usb/go7007/snd-go7007.c | 25 ++------- drivers/media/usb/tm6000/tm6000-alsa.c | 82 +--------------------------- drivers/media/usb/usbtv/usbtv-audio.c | 29 +--------- 14 files changed, 19 insertions(+), 547 deletions(-) -- 2.16.4

2 16

[alsa-devel] [PATCH v4 00/15] soundwire: intel: implement new ASoC interfaces
by Pierre-Louis Bossart 16 Dec '19

16 Dec '19

This patchset applies on top of soundwire/next, now that the interface definitions are merged. The changes are essentially a removal of the platform devices and the implementation of the new interfaces required to scan the ACPI tables, probe the links and start them. The missing prepare, trigger and setup ASoC callbacks are also implemented. The hw_params and free callbacks use the new interfaces as well. While there are quite a few lines of code changed, this is mostly about interface changes. The next series will contain more functional changes and deal with race conditions on probe, enumeration and suspend/resume issues. Changes since v3: One line change to re-add EXPORT_SYMBOL Add missing driver_registration Changes since v2: moved uevent handling to slave_type (Vinod) Changes since v1: fix typo (Vinod) removed uevent open for Master (Vinod) clarified commit messages (Cezary) no functionality change Bard Liao (1): soundwire: register master device driver Pierre-Louis Bossart (11): soundwire: renames to prepare support for master drivers/devices soundwire: rename dev_to_sdw_dev macro soundwire: rename drv_to_sdw_slave_driver macro soundwire: bus_type: rename sdw_drv_ to sdw_slave_drv soundwire: intel: rename res field as link_res soundwire: add support for sdw_slave_type soundwire: slave: move uevent handling to slave soundwire: add initial definitions for sdw_master_device soundwire: intel: remove platform devices and provide new interface soundwire: intel: free all resources on hw_free() soundwire: intel_init: add implementation of sdw_intel_enable_irq() Rander Wang (3): soundwire: intel: add prepare support in sdw dai driver soundwire: intel: add trigger support in sdw dai driver soundwire: intel: add sdw_stream_setup helper for .startup callback drivers/base/regmap/regmap-sdw.c | 4 +- drivers/soundwire/Makefile | 2 +- drivers/soundwire/bus.c | 2 +- drivers/soundwire/bus.h | 2 + drivers/soundwire/bus_type.c | 63 +++--- drivers/soundwire/intel.c | 282 +++++++++++++++++++++----- drivers/soundwire/intel.h | 8 +- drivers/soundwire/intel_init.c | 309 ++++++++++++++++++++++------- drivers/soundwire/master.c | 63 ++++++ drivers/soundwire/slave.c | 10 +- include/linux/soundwire/sdw.h | 39 +++- include/linux/soundwire/sdw_type.h | 34 +++- 12 files changed, 657 insertions(+), 161 deletions(-) create mode 100644 drivers/soundwire/master.c -- 2.20.1

2 33

[alsa-devel] alsa-info: lots of mostly syntactic changes
by GitHub pull_request - edited 16 Dec '19

16 Dec '19

alsa-project/alsa-utils pull request #29 was edited from E5ten: - remove all bashisms and change shebang to #!/bin/sh - replace use of which with command -v for portability - remove awk dependency - general cosmetic consistency: - indentation - always put then or do on the same line as if, for, or while - quote much more, especially when the variable refers to a file - replace many uses of >> $FILE with command grouping and single redirects of the command groups - simplify text processing pipelines, mostly by turning them into a single sed command Request URL : https://github.com/alsa-project/alsa-utils/pull/29 Patch URL : https://github.com/alsa-project/alsa-utils/pull/29.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] Free-running MMAP Mode
by Fletcher Woodruff 16 Dec '19

16 Dec '19

Hi alsa-devel, I'm working on implementing memory-mapped audio for a project that uses the alsa user-space API. My understanding is that typically, mmap mode requires explicit calls to mmap_begin/mmap_commit before and after every read/write in order to notify the driver of newly read/written frames. Is there any way for a user to request a sort of "free-running" MMAP, where alsa just assumes that the data it needs has been written to the circular buffer and doesn't expect those begin/commit calls? Thanks, Fletcher

1 0

[alsa-devel] [PATCH v2 0/2] Add the broadmobi BM818
by Angus Ainslie (Purism) 16 Dec '19

16 Dec '19

he broadmobi uses slightly different parameters from the option modems so add the paramters and document them. Changes since v1: Cut back the CC list. Use data from compatible match instead of explicit compatible match. Angus Ainslie (Purism) (2): sound: codecs: gtm601: add Broadmobi bm818 sound profile dt-bindings: sound: gtm601: add the broadmobi interface .../devicetree/bindings/sound/gtm601.txt | 10 +++- sound/soc/codecs/gtm601.c | 46 +++++++++++++++---- 2 files changed, 46 insertions(+), 10 deletions(-) -- 2.17.1

3 4

Re: [alsa-devel] [PATCH v3 03/15] soc: tegra: Add Tegra PMC clock registrations into PMC driver
by Dmitry Osipenko 16 Dec '19

16 Dec '19

10.12.2019 19:53, Sowjanya Komatineni пишет: > > On 12/9/19 3:03 PM, Sowjanya Komatineni wrote: >> >> On 12/9/19 12:46 PM, Sowjanya Komatineni wrote: >>> >>> On 12/9/19 12:12 PM, Dmitry Osipenko wrote: >>>> 08.12.2019 00:36, Sowjanya Komatineni пишет: >>>>> On 12/7/19 11:59 AM, Sowjanya Komatineni wrote: >>>>>> On 12/7/19 8:00 AM, Dmitry Osipenko wrote: >>>>>>> 07.12.2019 18:53, Dmitry Osipenko пишет: >>>>>>>> 07.12.2019 18:47, Dmitry Osipenko пишет: >>>>>>>>> 07.12.2019 17:28, Dmitry Osipenko пишет: >>>>>>>>>> 06.12.2019 05:48, Sowjanya Komatineni пишет: >>>>>>>>>>> Tegra210 and prior Tegra PMC has clk_out_1, clk_out_2, clk_out_3 >>>>>>>>>>> with >>>>>>>>>>> mux and gate for each of these clocks. >>>>>>>>>>> >>>>>>>>>>> Currently these PMC clocks are registered by Tegra clock driver >>>>>>>>>>> using >>>>>>>>>>> clk_register_mux and clk_register_gate by passing PMC base >>>>>>>>>>> address >>>>>>>>>>> and register offsets and PMC programming for these clocks >>>>>>>>>>> happens >>>>>>>>>>> through direct PMC access by the clock driver. >>>>>>>>>>> >>>>>>>>>>> With this, when PMC is in secure mode any direct PMC access >>>>>>>>>>> from the >>>>>>>>>>> non-secure world does not go through and these clocks will >>>>>>>>>>> not be >>>>>>>>>>> functional. >>>>>>>>>>> >>>>>>>>>>> This patch adds these clocks registration with PMC as a clock >>>>>>>>>>> provider >>>>>>>>>>> for these clocks. clk_ops callback implementations for these >>>>>>>>>>> clocks >>>>>>>>>>> uses tegra_pmc_readl and tegra_pmc_writel which supports PMC >>>>>>>>>>> programming >>>>>>>>>>> in secure mode and non-secure mode. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Sowjanya Komatineni <skomatineni(a)nvidia.com> >>>>>>>>>>> --- >>>>>>>>> [snip] >>>>>>>>> >>>>>>>>>>> + >>>>>>>>>>> +static const struct clk_ops pmc_clk_gate_ops = { >>>>>>>>>>> + .is_enabled = pmc_clk_is_enabled, >>>>>>>>>>> + .enable = pmc_clk_enable, >>>>>>>>>>> + .disable = pmc_clk_disable, >>>>>>>>>>> +}; >>>>>>>>>> What's the benefit of separating GATE from the MUX? >>>>>>>>>> >>>>>>>>>> I think it could be a single clock. >>>>>>>>> According to TRM: >>>>>>>>> >>>>>>>>> 1. GATE and MUX are separate entities. >>>>>>>>> >>>>>>>>> 2. GATE is the parent of MUX (see PMC's CLK_OUT paths diagram >>>>>>>>> in TRM). >>>>>>>>> >>>>>>>>> 3. PMC doesn't gate EXTPERIPH clock but could "force-enable" it, >>>>>>>>> correct? >>>>> Was following existing clk-tegra-pmc as I am not sure of reason for >>>>> having these clocks registered as separate mux and gate clocks. >>>>> >>>>> Yes, PMC clocks can be registered as single clock and can use clk_ops >>>>> for set/get parent and enable/disable. >>>>> >>>>> enable/disable of PMC clocks is for force-enable to force the clock to >>>>> run regardless of ACCEPT_REQ or INVERT_REQ. >>>>> >>>>>>>> 4. clk_m_div2/4 are internal PMC OSC dividers and thus these clocks >>>>>>>> should belong to PMC. >>>>>>> Also, it should be "osc" and not "clk_m". >>>>>> I followed the same parents as it were in existing clk-tegra-pmc >>>>>> driver. >>>>>> >>>>>> Yeah they are wrong and they should be from osc and not clk_m. >>>>>> >>>>>> Will fix in next version. >>>>>> >> Reg clk_m_div2/3, they are dividers at OSC pad and not really internal >> to PMC block. >> >> current clock driver creates clk_m_div clocks which should actually be >> osc_div2/osc_div4 clocks with osc as parent. >> >> There are no clk_m_div2 and clk_m_div4 from clk_m >> >> Will fix this in next version. >> >>>> Could you please describe the full EXTPERIPH clock topology and how the >>>> pinmux configuration is related to it all? >>>> >>>> What is internal to the Tegra chip and what are the external outputs? >>>> >>>> Is it possible to bypass PMC on T30+ for the EXTPERIPH clocks? >>> >>> PMC CLK1/2/3 possible sources are OSC_DIV1, OSC_DIV2, OSC_DIV4, >>> EXTPERIPH from CAR. >>> >>> OSC_DIV1/2/4 are with internal dividers at the OSC Pads >>> >>> EXTPERIPH is from CAR and it has reset and enable controls along with >>> clock source selections to choose one of the PLLA_OUT0, CLK_S, >>> PLLP_OUT0, CLK_M, PLLE_OUT0 >>> >>> So, PMC CLK1/2/4 possible parents are OSC_DIV1, OSC_DIV2, OSC_DIV4, >>> EXTERN. >>> >>> >>> CLK1/2/3 also has Pinmux to route EXTPERIPH output on to these pins. >>> >>> >>> When EXTERN output clock is selected for these PMC clocks thru >>> CLKx_SRC_SEL, output clock is from driver by EXTPERIPH from CAR via >>> Pinmux logic or driven as per CLKx_SRC_SEL bypassing pinmux based on >>> CLKx_ACCEPT_REQ bit. >>> >>> >>> PMC Clock control register has bit CLKx_ACCEPT_REQ >>> When CLKx_ACCEPT_REQ = 0, output clock driver is from by EXTPERIPH >>> through the pinmux >>> When CLKx_ACCEPT_REQ = 1, output clock is based on CLKx_SRC_SEL bits >>> (OSC_DIV1/2/4 and EXTPERIPH clock bypassing the pinmux) >>> >>> FORCE_EN bit in PMC CLock control register forces the clock to run >>> regardless of this. > > PMC clock gate is based on the state of CLKx_ACCEPT_REQ and FORCE_EN > like explained above. > > CLKx_ACCEPT_REQ is 0 default and FORCE_EN acts as gate to enable/disable > EXTPERIPH clock output to PMC CLK_OUT_1/2/3. [and to enable OSC as well] > So I believe we need to register as MUX and Gate rather than as a single > clock. Please confirm. 1. The force-enabling is applied to both OSC and EXTERN sources of PMC_CLK_OUT_x by PMC at once. 2. Both of PMC's force-enabling and OSC/EXTERN selection is internal to PMC. Should be better to define it as a single "pmc_clk_out_x". I don't see any good reasons for differentiating PMC's Gate from the MUX, it's a single hardware unit from a point of view of the rest of the system. Peter, do you have any objections?

2 7

[alsa-devel] [PATCH] ALSA: hda - Downgrade error message for single-cmd fallback
by Takashi Iwai 16 Dec '19

16 Dec '19

We made the error message for the CORB/RIRB communication clearer by upgrading to dev_WARN() so that user can notice better. But this struck us like a boomerang: now it caught syzbot and reported back as a fatal issue although it's not really any too serious bug that worth for stopping the whole system. OK, OK, let's be softy, downgrade it to the standard dev_err() again. Fixes: dd65f7e19c69 ("ALSA: hda - Show the fatal CORB/RIRB error more clearly") Reported-by: syzbot+b3028ac3933f5c466389(a)syzkaller.appspotmail.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c index 2f3b7a35f2d9..ba56b59b3e17 100644 --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -883,7 +883,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, return -EAGAIN; /* give a chance to retry */ } - dev_WARN(chip->card->dev, + dev_err(chip->card->dev, "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n", bus->last_cmd[addr]); chip->single_cmd = 1; -- 2.16.4

1 0

[alsa-devel] [PATCH v2 1/2] ASoC: mediatek: Use managed buffer allocation
by Takashi Iwai 16 Dec '19

16 Dec '19

Clean up the drivers with the new managed buffer allocation API. The superfluous snd_pcm_lib_malloc_pages() and snd_pcm_lib_free_pages() calls are dropped, as well as the superfluous snd_pcm_lib_preallocate_free_for_all() call. As of the result, hw_free and pcm_destruct ops became empty and got removed. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/soc/mediatek/common/mtk-afe-fe-dai.c | 6 +----- sound/soc/mediatek/common/mtk-afe-platform-driver.c | 12 ++---------- sound/soc/mediatek/common/mtk-afe-platform-driver.h | 2 -- sound/soc/mediatek/mt6797/mt6797-afe-pcm.c | 1 - sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 1 - 5 files changed, 3 insertions(+), 19 deletions(-) diff --git a/sound/soc/mediatek/common/mtk-afe-fe-dai.c b/sound/soc/mediatek/common/mtk-afe-fe-dai.c index e761cb66be5d..8f314e15ce73 100644 --- a/sound/soc/mediatek/common/mtk-afe-fe-dai.c +++ b/sound/soc/mediatek/common/mtk-afe-fe-dai.c @@ -129,10 +129,6 @@ int mtk_afe_fe_hw_params(struct snd_pcm_substream *substream, unsigned int rate = params_rate(params); snd_pcm_format_t format = params_format(params); - ret = snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params)); - if (ret < 0) - return ret; - if (afe->request_dram_resource) afe->request_dram_resource(afe->dev); @@ -193,7 +189,7 @@ int mtk_afe_fe_hw_free(struct snd_pcm_substream *substream, if (afe->release_dram_resource) afe->release_dram_resource(afe->dev); - return snd_pcm_lib_free_pages(substream); + return 0; } EXPORT_SYMBOL_GPL(mtk_afe_fe_hw_free); diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.c b/sound/soc/mediatek/common/mtk-afe-platform-driver.c index b6624d8d084b..719d43bb0b8f 100644 --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.c +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.c @@ -120,25 +120,17 @@ int mtk_afe_pcm_new(struct snd_soc_component *component, struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component); size = afe->mtk_afe_hardware->buffer_bytes_max; - snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, - afe->dev, size, size); + snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV, + afe->dev, size, size); return 0; } EXPORT_SYMBOL_GPL(mtk_afe_pcm_new); -void mtk_afe_pcm_free(struct snd_soc_component *component, - struct snd_pcm *pcm) -{ - snd_pcm_lib_preallocate_free_for_all(pcm); -} -EXPORT_SYMBOL_GPL(mtk_afe_pcm_free); - const struct snd_soc_component_driver mtk_afe_pcm_platform = { .name = AFE_PCM_NAME, .ioctl = snd_soc_pcm_lib_ioctl, .pointer = mtk_afe_pcm_pointer, .pcm_construct = mtk_afe_pcm_new, - .pcm_destruct = mtk_afe_pcm_free, }; EXPORT_SYMBOL_GPL(mtk_afe_pcm_platform); diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.h b/sound/soc/mediatek/common/mtk-afe-platform-driver.h index e550d11568c3..fcc923b88f12 100644 --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.h +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.h @@ -21,8 +21,6 @@ snd_pcm_uframes_t mtk_afe_pcm_pointer(struct snd_soc_component *component, struct snd_pcm_substream *substream); int mtk_afe_pcm_new(struct snd_soc_component *component, struct snd_soc_pcm_runtime *rtd); -void mtk_afe_pcm_free(struct snd_soc_component *component, - struct snd_pcm *pcm); int mtk_afe_combine_sub_dai(struct mtk_base_afe *afe); int mtk_afe_add_sub_dai_control(struct snd_soc_component *component); diff --git a/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c b/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c index 033c07fb599c..0743c699d8c1 100644 --- a/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c +++ b/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c @@ -715,7 +715,6 @@ static const struct snd_soc_component_driver mt6797_afe_component = { .ioctl = snd_soc_pcm_lib_ioctl, .pointer = mtk_afe_pcm_pointer, .pcm_construct = mtk_afe_pcm_new, - .pcm_destruct = mtk_afe_pcm_free, }; static int mt6797_dai_memif_register(struct mtk_base_afe *afe) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c index 76af09d8f1af..6b5f407de3d0 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -1053,7 +1053,6 @@ static const struct snd_soc_component_driver mt8183_afe_component = { .ioctl = snd_soc_pcm_lib_ioctl, .pointer = mtk_afe_pcm_pointer, .pcm_construct = mtk_afe_pcm_new, - .pcm_destruct = mtk_afe_pcm_free, }; static int mt8183_dai_memif_register(struct mtk_base_afe *afe) -- 2.16.4

2 3

[alsa-devel] [PATCH] ASoC: wm8962: fix lambda value
by Shengjiu Wang 16 Dec '19

16 Dec '19

According to user manual, it is required that FLL_LAMBDA > 0 in all cases (Integer and Franctional modes). Fixes: 9a76f1ff6e29 ("ASoC: Add initial WM8962 CODEC driver") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/wm8962.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 3e5c69fbc33a..d9d59f45833f 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -2788,7 +2788,7 @@ static int fll_factors(struct _fll_div *fll_div, unsigned int Fref, if (target % Fref == 0) { fll_div->theta = 0; - fll_div->lambda = 0; + fll_div->lambda = 1; } else { gcd_fll = gcd(target, fratio * Fref); @@ -2858,7 +2858,7 @@ static int wm8962_set_fll(struct snd_soc_component *component, int fll_id, int s return -EINVAL; } - if (fll_div.theta || fll_div.lambda) + if (fll_div.theta) fll1 |= WM8962_FLL_FRAC; /* Stop the FLL while we reconfigure */ -- 2.21.0

5 6