December 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] ctl: elem_id/elem_value: add APIs to check whether two instances have the same meaning
by GitHub pull_request - opened 22 Dec '19

22 Dec '19

alsa-project/alsa-gobject pull request #2 was opened from takaswie: For some cases, it's convenient for users to check whether two instances of elem_id/elem_value have the same meaning. In glib, APIs for comparison of content of objects are named as equal. This commit adds equal APIs for this purpose. Request URL : https://github.com/alsa-project/alsa-gobject/pull/2 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/2.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[alsa-devel] ctl: elem_info_int: fix wrong assignment to private value
by GitHub pull_request - opened 22 Dec '19

22 Dec '19

alsa-project/alsa-gobject pull request #1 was opened from takaswie: ALSACtl::ElemInfoInt has properties for 'min', 'max' and 'step' but their assignments are not proper. This commit fixes the bug. Fixes: aac870451a89 ("ctl: elem_info_int: add properties for type-dependent parameters and constructor") Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Request URL : https://github.com/alsa-project/alsa-gobject/pull/1 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/1.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[alsa-devel] [sound:for-next 162/166] ./usr/include/sound/hdsp.h:35:2: error: unknown type name '__u32'
by kbuild test robot 22 Dec '19

22 Dec '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: bfea224d9250e56ed5475bf72190783a7e1d8e43 commit: d63e63d4210713ddc7eb1b2d2afc4a8d42ccf91e [162/166] ALSA: hdsp: Make uapi/hdsp.h compilable again config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: git checkout d63e63d4210713ddc7eb1b2d2afc4a8d42ccf91e # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): In file included from <command-line>:32:0: >> ./usr/include/sound/hdsp.h:35:2: error: unknown type name '__u32' __u32 input_peaks[26]; ^~~~~ ./usr/include/sound/hdsp.h:36:2: error: unknown type name '__u32' __u32 playback_peaks[26]; ^~~~~ ./usr/include/sound/hdsp.h:37:2: error: unknown type name '__u32' __u32 output_peaks[28]; ^~~~~ >> ./usr/include/sound/hdsp.h:38:2: error: unknown type name '__u64' __u64 input_rms[26]; ^~~~~ ./usr/include/sound/hdsp.h:39:2: error: unknown type name '__u64' __u64 playback_rms[26]; ^~~~~ ./usr/include/sound/hdsp.h:41:2: error: unknown type name '__u64' __u64 output_rms[26]; ^~~~~ --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

1 0

[alsa-devel] [sound:for-next 161/166] usr/include/sound/emu10k1.h:322: found __[us]{8, 16, 32, 64} type without #include <linux/types.h>
by kbuild test robot 21 Dec '19

21 Dec '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: bfea224d9250e56ed5475bf72190783a7e1d8e43 commit: 2e4688676392767e16c1adeca4cc2c083e2db13f [161/166] ALSA: emu10k1: Make uapi/emu10k1.h compilable again config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: git checkout 2e4688676392767e16c1adeca4cc2c083e2db13f # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> usr/include/sound/emu10k1.h:322: found __[us]{8,16,32,64} type without #include <linux/types.h> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

1 0

[alsa-devel] [PATCH] ALSA: hda/hdmi - fix atpx_present when CLASS is not VGA
by Alex Deucher 21 Dec '19

21 Dec '19

You can't use PCI_BASE_CLASS with pci_get_class(). This happens to work by luck on devices with PCI_CLASS_DISPLAY_VGA, but misses PCI_CLASS_DISPLAY_OTHER. Add a check for those as well. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- sound/pci/hda/hda_intel.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index b856b89378ac..f69c8de64bd6 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1410,7 +1410,17 @@ static bool atpx_present(void) acpi_handle dhandle, atpx_handle; acpi_status status; - while ((pdev = pci_get_class(PCI_BASE_CLASS_DISPLAY << 16, pdev)) != NULL) { + while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, pdev)) != NULL) { + dhandle = ACPI_HANDLE(&pdev->dev); + if (dhandle) { + status = acpi_get_handle(dhandle, "ATPX", &atpx_handle); + if (!ACPI_FAILURE(status)) { + pci_dev_put(pdev); + return true; + } + } + } + while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_OTHER << 8, pdev)) != NULL) { dhandle = ACPI_HANDLE(&pdev->dev); if (dhandle) { status = acpi_get_handle(dhandle, "ATPX", &atpx_handle); -- 2.24.1

2 1

[alsa-devel] [PATCH v10 0/2] ASoC: codecs: Add WSA881x Smart Speaker amplifier support
by Srinivas Kandagatla 20 Dec '19

20 Dec '19

This patchset adds support to WSA8810/WSA8815 Class-D Smart Speaker Amplifier which is SoundWire interfaced. This patchset along with DB845c machine driver and WCD934x codec driver has been tested on SDM845 SoC based DragonBoard DB845c with two WSA8810 and Lenovo YOGA C630 Laptop based on SDM850 with WSA8815 speaker amplifiers. Most of the code in this driver is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. TODO: Add thermal sensor support in WSA881x. Thanks, srini Changes since v9: - Program pa_gain settings in put function, rather than delaying it. Srinivas Kandagatla (2): dt-bindings: ASoC: Add WSA881x bindings ASoC: codecs: add wsa881x amplifier support .../bindings/sound/qcom,wsa881x.yaml | 68 + sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wsa881x.c | 1182 +++++++++++++++++ 4 files changed, 1262 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml create mode 100644 sound/soc/codecs/wsa881x.c -- 2.21.0

2 5

[alsa-devel] [PATCH alsa-lib] uapi: Move typedefs from uapi to sound/*
by Takashi Iwai 20 Dec '19

20 Dec '19

For keeping uapi/*.h cleaner. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/sound/emu10k1.h | 9 +++++++++ include/sound/hdsp.h | 10 ++++++++++ include/sound/hdspm.h | 8 ++++++++ include/sound/sb16_csp.h | 4 ++++ include/sound/uapi/emu10k1.h | 10 ---------- include/sound/uapi/hdsp.h | 9 --------- include/sound/uapi/hdspm.h | 8 -------- 7 files changed, 31 insertions(+), 27 deletions(-) diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h index f06ecee51c2b..0832f95bd995 100644 --- a/include/sound/emu10k1.h +++ b/include/sound/emu10k1.h @@ -1,2 +1,11 @@ #include <alsa/sound/type_compat.h> #include <alsa/sound/uapi/emu10k1.h> +#ifndef __emu10k1_type_defined +#define __emu10k1_type_defined +typedef struct snd_emu10k1_fx8010_info emu10k1_fx8010_info_t; +typedef struct snd_emu10k1_fx8010_control_gpr emu10k1_fx8010_control_gpr_t; +typedef struct snd_emu10k1_fx8010_code emu10k1_fx8010_code_t; +typedef struct snd_emu10k1_fx8010_tram emu10k1_fx8010_tram_t; +typedef struct snd_emu10k1_fx8010_pcm_rec emu10k1_fx8010_pcm_t; +typedef struct emu10k1_ctl_elem_id emu10k1_ctl_elem_id_t; +#endif diff --git a/include/sound/hdsp.h b/include/sound/hdsp.h index 78fb745b607a..e8f931569548 100644 --- a/include/sound/hdsp.h +++ b/include/sound/hdsp.h @@ -1,2 +1,12 @@ #include <alsa/sound/type_compat.h> #include <alsa/sound/uapi/hdsp.h> +#ifndef __hdsp_type_defined +#define __hdsp_type_defined +typedef enum HDSP_IO_Type HDSP_IO_Type; +typedef struct hdsp_peak_rms hdsp_peak_rms_t; +typedef struct hdsp_config_info hdsp_config_info_t; +typedef struct hdsp_firmware hdsp_firmware_t; +typedef struct hdsp_version hdsp_version_t; +typedef struct hdsp_mixer hdsp_mixer_t; +typedef struct hdsp_9632_aeb hdsp_9632_aeb_t; +#endif diff --git a/include/sound/hdspm.h b/include/sound/hdspm.h index af6d19eda87f..d9095d9f10bb 100644 --- a/include/sound/hdspm.h +++ b/include/sound/hdspm.h @@ -1,2 +1,10 @@ #include <alsa/sound/type_compat.h> #include <alsa/sound/uapi/hdspm.h> +#ifndef __hdspm_type_defined +#define __hdspm_type_defined +typedef struct hdspm_peak_rms hdspm_peak_rms_t; +typedef struct hdspm_config_info hdspm_config_info_t; +typedef struct hdspm_version hdspm_version_t; +typedef struct hdspm_channelfader snd_hdspm_channelfader_t; +typedef struct hdspm_mixer hdspm_mixer_t; +#endif diff --git a/include/sound/sb16_csp.h b/include/sound/sb16_csp.h index 24121fcbd888..fd02bc565e21 100644 --- a/include/sound/sb16_csp.h +++ b/include/sound/sb16_csp.h @@ -1 +1,5 @@ #include <alsa/sound/uapi/sb16_csp.h> +#ifndef __sb16_csp_type_defined +#define __sb16_csp_type_defined +typedef struct snd_sb_csp_microcode snd_sb_csp_microcode_t; +#endif diff --git a/include/sound/uapi/emu10k1.h b/include/sound/uapi/emu10k1.h index c1150e4d0231..6bcd76f64c1c 100644 --- a/include/sound/uapi/emu10k1.h +++ b/include/sound/uapi/emu10k1.h @@ -382,14 +382,4 @@ struct snd_emu10k1_fx8010_pcm_rec { #define SNDRV_EMU10K1_IOCTL_SINGLE_STEP _IOW ('H', 0x83, int) #define SNDRV_EMU10K1_IOCTL_DBG_READ _IOR ('H', 0x84, int) -#ifndef __KERNEL__ -/* typedefs for compatibility to user-space */ -typedef struct snd_emu10k1_fx8010_info emu10k1_fx8010_info_t; -typedef struct snd_emu10k1_fx8010_control_gpr emu10k1_fx8010_control_gpr_t; -typedef struct snd_emu10k1_fx8010_code emu10k1_fx8010_code_t; -typedef struct snd_emu10k1_fx8010_tram emu10k1_fx8010_tram_t; -typedef struct snd_emu10k1_fx8010_pcm_rec emu10k1_fx8010_pcm_t; -typedef struct emu10k1_ctl_elem_id emu10k1_ctl_elem_id_t; -#endif - #endif /* _UAPI__SOUND_EMU10K1_H */ diff --git a/include/sound/uapi/hdsp.h b/include/sound/uapi/hdsp.h index 88c92a3fb477..7ac2d3f2a9b3 100644 --- a/include/sound/uapi/hdsp.h +++ b/include/sound/uapi/hdsp.h @@ -97,13 +97,4 @@ struct hdsp_9632_aeb { #define SNDRV_HDSP_IOCTL_GET_9632_AEB _IOR('H', 0x45, struct hdsp_9632_aeb) -/* typedefs for compatibility to user-space */ -typedef enum HDSP_IO_Type HDSP_IO_Type; -typedef struct hdsp_peak_rms hdsp_peak_rms_t; -typedef struct hdsp_config_info hdsp_config_info_t; -typedef struct hdsp_firmware hdsp_firmware_t; -typedef struct hdsp_version hdsp_version_t; -typedef struct hdsp_mixer hdsp_mixer_t; -typedef struct hdsp_9632_aeb hdsp_9632_aeb_t; - #endif /* __SOUND_HDSP_H */ diff --git a/include/sound/uapi/hdspm.h b/include/sound/uapi/hdspm.h index 2d91f90eb5e1..3fbfd9dc5f51 100644 --- a/include/sound/uapi/hdspm.h +++ b/include/sound/uapi/hdspm.h @@ -219,12 +219,4 @@ struct hdspm_mixer_ioctl { /* use indirect access due to the limit of ioctl bit size */ #define SNDRV_HDSPM_IOCTL_GET_MIXER _IOR('H', 0x44, struct hdspm_mixer_ioctl) -/* typedefs for compatibility to user-space */ -typedef struct hdspm_peak_rms hdspm_peak_rms_t; -typedef struct hdspm_config_info hdspm_config_info_t; -typedef struct hdspm_version hdspm_version_t; -typedef struct hdspm_channelfader snd_hdspm_channelfader_t; -typedef struct hdspm_mixer hdspm_mixer_t; - - #endif -- 2.16.4

1 0

[alsa-devel] [PATCH] ALSA: uapi: Drop unneeded typedefs
by Takashi Iwai 20 Dec '19

20 Dec '19

We kept some typedefs in uapi/sound/*.h so that the programs in alsa-tools can be built. Now that alsa-lib takes these and applies the workarounds in its own, we don't need these typedefs any longer in the kernel uapi side. Let's drop them. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/uapi/sound/emu10k1.h | 10 ---------- include/uapi/sound/hdsp.h | 9 --------- include/uapi/sound/hdspm.h | 8 -------- 3 files changed, 27 deletions(-) diff --git a/include/uapi/sound/emu10k1.h b/include/uapi/sound/emu10k1.h index c1150e4d0231..6bcd76f64c1c 100644 --- a/include/uapi/sound/emu10k1.h +++ b/include/uapi/sound/emu10k1.h @@ -382,14 +382,4 @@ struct snd_emu10k1_fx8010_pcm_rec { #define SNDRV_EMU10K1_IOCTL_SINGLE_STEP _IOW ('H', 0x83, int) #define SNDRV_EMU10K1_IOCTL_DBG_READ _IOR ('H', 0x84, int) -#ifndef __KERNEL__ -/* typedefs for compatibility to user-space */ -typedef struct snd_emu10k1_fx8010_info emu10k1_fx8010_info_t; -typedef struct snd_emu10k1_fx8010_control_gpr emu10k1_fx8010_control_gpr_t; -typedef struct snd_emu10k1_fx8010_code emu10k1_fx8010_code_t; -typedef struct snd_emu10k1_fx8010_tram emu10k1_fx8010_tram_t; -typedef struct snd_emu10k1_fx8010_pcm_rec emu10k1_fx8010_pcm_t; -typedef struct emu10k1_ctl_elem_id emu10k1_ctl_elem_id_t; -#endif - #endif /* _UAPI__SOUND_EMU10K1_H */ diff --git a/include/uapi/sound/hdsp.h b/include/uapi/sound/hdsp.h index 88c92a3fb477..7ac2d3f2a9b3 100644 --- a/include/uapi/sound/hdsp.h +++ b/include/uapi/sound/hdsp.h @@ -97,13 +97,4 @@ struct hdsp_9632_aeb { #define SNDRV_HDSP_IOCTL_GET_9632_AEB _IOR('H', 0x45, struct hdsp_9632_aeb) -/* typedefs for compatibility to user-space */ -typedef enum HDSP_IO_Type HDSP_IO_Type; -typedef struct hdsp_peak_rms hdsp_peak_rms_t; -typedef struct hdsp_config_info hdsp_config_info_t; -typedef struct hdsp_firmware hdsp_firmware_t; -typedef struct hdsp_version hdsp_version_t; -typedef struct hdsp_mixer hdsp_mixer_t; -typedef struct hdsp_9632_aeb hdsp_9632_aeb_t; - #endif /* __SOUND_HDSP_H */ diff --git a/include/uapi/sound/hdspm.h b/include/uapi/sound/hdspm.h index 2d91f90eb5e1..3fbfd9dc5f51 100644 --- a/include/uapi/sound/hdspm.h +++ b/include/uapi/sound/hdspm.h @@ -219,12 +219,4 @@ struct hdspm_mixer_ioctl { /* use indirect access due to the limit of ioctl bit size */ #define SNDRV_HDSPM_IOCTL_GET_MIXER _IOR('H', 0x44, struct hdspm_mixer_ioctl) -/* typedefs for compatibility to user-space */ -typedef struct hdspm_peak_rms hdspm_peak_rms_t; -typedef struct hdspm_config_info hdspm_config_info_t; -typedef struct hdspm_version hdspm_version_t; -typedef struct hdspm_channelfader snd_hdspm_channelfader_t; -typedef struct hdspm_mixer hdspm_mixer_t; - - #endif -- 2.16.4

1 0

[alsa-devel] [PATCH] ASoC: sgtl5000: Fix VDDA and VDDIO comparison
by Marek Vasut 20 Dec '19

20 Dec '19

Comparing the voltage of VDDA and VDDIO to determine whether or not to enable VDDC manual override is insufficient. This is a problem in case the VDDA is supplied from different regulator than VDDIO, while both report the same voltage to the regulator framework. In that case where VDDA and VDDIO is supplied by different regulators, the VDDC manual override must not be applied. Fixes: b6319b061ba2 ("ASoC: sgtl5000: Fix charge pump source assignment") Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Fabio Estevam <festevam(a)gmail.com> Cc: Igor Opaniuk <igor.opaniuk(a)toradex.com> Cc: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Oleksandr Suvorov <oleksandr.suvorov(a)toradex.com> --- sound/soc/codecs/sgtl5000.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 93da6b58c97df..b4568f417d78e 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -28,6 +28,8 @@ #include "sgtl5000.h" +#include "../../../drivers/regulator/internal.h" + #define SGTL5000_DAP_REG_OFFSET 0x0100 #define SGTL5000_MAX_REG_OFFSET 0x013A @@ -1344,7 +1346,8 @@ static int sgtl5000_set_power_regs(struct snd_soc_component *component) * if vddio == vdda the source of charge pump should be * assigned manually to VDDIO */ - if (vddio == vdda) { + if (sgtl5000->supplies[VDDA].consumer->rdev == + sgtl5000->supplies[VDDIO].consumer->rdev) { lreg_ctrl |= SGTL5000_VDDC_ASSN_OVRD; lreg_ctrl |= SGTL5000_VDDC_MAN_ASSN_VDDIO << SGTL5000_VDDC_MAN_ASSN_SHIFT; -- 2.24.1

2 5

[alsa-devel] [PATCH] hdspmixer: Use __u32 and __u64 for RMS array types
by Takashi Iwai 20 Dec '19

20 Dec '19

Some variable types are referring to the field in ioctl struct, which are actually __u32 or __u64 instead of uint32_t or uint64_t. This inconsistency may result in the compile error. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- hdspmixer/src/HDSPMixerWindow.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hdspmixer/src/HDSPMixerWindow.cxx b/hdspmixer/src/HDSPMixerWindow.cxx index 342efb2b857f..9efc25d0d5c0 100644 --- a/hdspmixer/src/HDSPMixerWindow.cxx +++ b/hdspmixer/src/HDSPMixerWindow.cxx @@ -35,8 +35,8 @@ static void readregisters_cb(void *arg) hdsp_peak_rms_t hdsp_peak_rms; struct hdspm_peak_rms hdspm_peak_rms; bool isMADI = false; - uint32_t *input_peaks, *playback_peaks, *output_peaks; - uint64_t *input_rms, *playback_rms, *output_rms; + __u32 *input_peaks, *playback_peaks, *output_peaks; + __u64 *input_rms, *playback_rms, *output_rms; HDSPMixerWindow *w = (HDSPMixerWindow *)arg; -- 2.16.4

1 0