November 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] ASoC: Intel: sof_rt5682: add TigerLake support
by Pierre-Louis Bossart 09 Dec '19

09 Dec '19

This patchset extends the existing machine driver to support TigerLake, the main change being for HDMI streams (4 instead of 3). Sathyanarayana Nujella (3): ASoC: intel: sof_rt5682: Add quirk for number of HDMI DAI's ASoC: intel: sof_rt5682: Add support for tgl-max98357a-rt5682 ASoC: Intel: common: Add mach table for tgl-max98357a-rt5682 sound/soc/intel/boards/sof_rt5682.c | 34 +++++++++++++++++-- .../intel/common/soc-acpi-intel-tgl-match.c | 13 +++++++ 2 files changed, 44 insertions(+), 3 deletions(-) -- 2.20.1

2 6

[alsa-devel] [PATCH 0/3] ASoC: Intel: SOF: use common HDMI driver
by Pierre-Louis Bossart 09 Dec '19

09 Dec '19

By default make sure all SOF-based solutions use the common HDMI driver. The hdac_hdmi solution is only supported for devices based on the SST driver. This change was merged two weeks ago in the SOF tree and no regressions were observed. Kai Vehmanen (3): ASoC: SOF: Intel: make common HDMI driver default ASoC: Intel: boards: make common HDMI driver the default for SOF ASoC: hdac_hdmi: Drop support for Icelake sound/soc/codecs/hdac_hdmi.c | 63 +++++----------------------------- sound/soc/intel/boards/Kconfig | 5 +++ sound/soc/sof/intel/Kconfig | 1 + 3 files changed, 15 insertions(+), 54 deletions(-) -- 2.20.1

2 6

[alsa-devel] [PATCH v2 0/2] ASoC: mediatek: common: refine mtk_afe_fe_hw_params
by Eason Yen 09 Dec '19

09 Dec '19

This patch is to add more helpers to control mtk_memif dma_address/format/pbuf_size And refine hw_params and hw_prepare by these helpers. v2 changes: split patch v1 to two seprated patches for different purpose. v1 changes: 1. patchwork list: https://mailman.alsa-project.org/pipermail/alsa-devel/2019-November/158394.… Eason Yen (2): ASoC: mediatek: common: add some helpers to control mtk_memif ASoC: mediatek: common: refine hw_params and hw_prepare sound/soc/mediatek/common/mtk-afe-fe-dai.c | 359 +++++++++++++++++++++++------ sound/soc/mediatek/common/mtk-afe-fe-dai.h | 16 ++ sound/soc/mediatek/common/mtk-base-afe.h | 28 ++- 3 files changed, 336 insertions(+), 67 deletions(-) -- 1.9.1

2 4

[alsa-devel] [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls
by Nikita Yushchenko 09 Dec '19

09 Dec '19

HP output driver has two parameters that can be configured to reduce pop noise: power-on delay and ramp-up step time. Two new kcontrols have been added to set these parameters. Signed-off-by: Nikita Yushchenko <nikita.yoush(a)cogentembedded.com> --- sound/soc/codecs/tlv320aic31xx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index 67323188afd2..740e75032f36 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -263,6 +263,19 @@ static SOC_ENUM_SINGLE_DECL(cm_m_enum, AIC31XX_MICPGAMI, 6, mic_select_text); static SOC_ENUM_SINGLE_DECL(mic1lm_m_enum, AIC31XX_MICPGAMI, 4, mic_select_text); +static const char * const hp_poweron_time_text[] = { + "0us", "15.3us", "153us", "1.53ms", "15.3ms", "76.2ms", + "153ms", "304ms", "610ms", "1.22s", "3.04s", "6.1s" }; + +static SOC_ENUM_SINGLE_DECL(hp_poweron_time_enum, AIC31XX_HPPOP, 3, + hp_poweron_time_text); + +static const char * const hp_rampup_step_text[] = { + "0ms", "0.98ms", "1.95ms", "3.9ms" }; + +static SOC_ENUM_SINGLE_DECL(hp_rampup_step_enum, AIC31XX_HPPOP, 1, + hp_rampup_step_text); + static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -6350, 50, 0); static const DECLARE_TLV_DB_SCALE(adc_fgain_tlv, 0, 10, 0); static const DECLARE_TLV_DB_SCALE(adc_cgain_tlv, -2000, 50, 0); @@ -286,6 +299,9 @@ static const struct snd_kcontrol_new common31xx_snd_controls[] = { SOC_DOUBLE_R_TLV("HP Analog Playback Volume", AIC31XX_LANALOGHPL, AIC31XX_RANALOGHPR, 0, 0x7F, 1, hp_vol_tlv), + + SOC_ENUM("HP Output Driver Power-On time", hp_poweron_time_enum), + SOC_ENUM("HP Output Driver Ramp-up step", hp_rampup_step_enum), }; static const struct snd_kcontrol_new aic31xx_snd_controls[] = { -- 2.20.1

2 5

[alsa-devel] [PATCH] ASoC: fsl_sai: add IRQF_SHARED
by Michael Walle 09 Dec '19

09 Dec '19

The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use IRQF_SHARED to be able to use these SAIs simultaneously. Signed-off-by: Michael Walle <michael(a)walle.cc> --- sound/soc/fsl/fsl_sai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index b517e4bc1b87..8c3ea7300972 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -958,7 +958,8 @@ static int fsl_sai_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(&pdev->dev, irq, fsl_sai_isr, 0, np->name, sai); + ret = devm_request_irq(&pdev->dev, irq, fsl_sai_isr, IRQF_SHARED, + np->name, sai); if (ret) { dev_err(&pdev->dev, "failed to claim irq %u\n", irq); return ret; -- 2.20.1

5 6

[alsa-devel] [PATCH] ASoC: tlv320aic31xx: Add Volume Soft Stepping control
by Nikita Yushchenko 09 Dec '19

09 Dec '19

Chip supports soft stepping of volume changes and it is enabled by default. This patch adds a control for it, so it could be either made slower (two sample periods per step instead of one), or disabled. Signed-off-by: Nikita Yushchenko <nikita.yoush(a)cogentembedded.com> --- sound/soc/codecs/tlv320aic31xx.c | 8 ++++++++ sound/soc/codecs/tlv320aic31xx.h | 3 --- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index d6c462f21370..31daa60695bd 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -275,6 +275,12 @@ static const char * const hp_rampup_step_text[] = { static SOC_ENUM_SINGLE_DECL(hp_rampup_step_enum, AIC31XX_HPPOP, 1, hp_rampup_step_text); +static const char * const vol_soft_step_mode_text[] = { + "fast", "slow", "disabled" }; + +static SOC_ENUM_SINGLE_DECL(vol_soft_step_mode_enum, AIC31XX_DACSETUP, 0, + vol_soft_step_mode_text); + static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -6350, 50, 0); static const DECLARE_TLV_DB_SCALE(adc_fgain_tlv, 0, 10, 0); static const DECLARE_TLV_DB_SCALE(adc_cgain_tlv, -2000, 50, 0); @@ -306,6 +312,8 @@ static const struct snd_kcontrol_new common31xx_snd_controls[] = { */ SOC_ENUM("HP Output Driver Power-On time", hp_poweron_time_enum), SOC_ENUM("HP Output Driver Ramp-up step", hp_rampup_step_enum), + + SOC_ENUM("Volume Soft Stepping", vol_soft_step_mode_enum), }; static const struct snd_kcontrol_new aic31xx_snd_controls[] = { diff --git a/sound/soc/codecs/tlv320aic31xx.h b/sound/soc/codecs/tlv320aic31xx.h index 83a8c7604cc3..0523884cee74 100644 --- a/sound/soc/codecs/tlv320aic31xx.h +++ b/sound/soc/codecs/tlv320aic31xx.h @@ -218,9 +218,6 @@ struct aic31xx_pdata { #define AIC31XX_GPIO1_ADC_MOD_CLK 0x10 #define AIC31XX_GPIO1_SDOUT 0x11 -/* AIC31XX_DACSETUP */ -#define AIC31XX_SOFTSTEP_MASK GENMASK(1, 0) - /* AIC31XX_DACMUTE */ #define AIC31XX_DACMUTE_MASK GENMASK(3, 2) -- 2.20.1

2 1

[alsa-devel] Headset button mapping in the kernel
by Curtis Malainey 06 Dec '19

06 Dec '19

Hello ALSA Devs, I am looking to get some feedback/ideas on a possible change to headset button mapping. Locally we are carrying patches that implement the mappings in the machine driver (which we understand you do not want upstream.) We are looking to see if we can add a new API (something like a sysfs path potentially) to have userspace pass in the mapping, if it chooses to, so the mapping can still be done in the kernel. That way we can carry just the config locally and remove some of the kernel patches we are carrying locally. Thanks. Curtis

5 9

[alsa-devel] [PATCH 0/2] ASoC: fixup topology dai_link remove issue
by Kuninori Morimoto 05 Dec '19

05 Dec '19

Hi Mark Cc Pierre-Louis, Takashi-san Currently, I'm focusing to ASoC cleanup / balance-up. But, it found more unbalance issue, and Intel noticed about it. These patches fix dai_link remove issue on topology. I want to get Acked-by or Reviewed-by from Takashi-san for 2) patch if possible. These are already tested by Intel CI, and all issues were solved. (https://github.com/thesofproject/linux/pull/1504) Extra Tested-by / Reviewed-by are very welcome from Intel Kuninori Morimoto (2): 1) ASoC: soc-component: tidyup snd_soc_pcm_component_new/free() parameter 2) ASoC: soc-pcm: remove soc_pcm_private_free() include/sound/soc-component.h | 4 ++-- sound/soc/soc-component.c | 8 +++----- sound/soc/soc-core.c | 19 +++++++++++-------- sound/soc/soc-pcm.c | 12 +----------- 4 files changed, 17 insertions(+), 26 deletions(-) -- 2.7.4

5 11

Re: [alsa-devel] snd-bebob : from kernel 4.13 to 5.3.19 and .20
by Takashi Sakamoto 05 Dec '19

05 Dec '19

Hi, On Wed, Oct 30, 2019 at 10:40:18AM +0100, Jean-Paul Argudo wrote: > > I'll install Eoan kernel and test my devices. > > (but I don't have Saffire and Saffire LE...) I'd like you to wait > > for my test report. > > What I can say is that with kernel 4.13 under Ubunto Disco everything > was fine :-( I install Eoan (linux-image-5.3.0-19-generic:5.3.0-19.20) and test ALSA bebob driver with my test devices: - Yamaha GO46 (DM1000 ASIC) - M-Audio FireWire Solo (DM1000 ASIC) - Behringer FCA610 (DM1500 ASIC) - Focusrite SaffirePro 26 I/O (DM1000E) However I don't find similar discontinuities. This means that you encounter model-specific issue as regression I didn't realized. For my information, would you please get output from nodes on procfs? * /proc/asound/cardX/firewire/clock * /proc/asound/cardX/firewire/firmware * /proc/asound/cardX/firewire/formation Additionally, please install 'gir1.2-hinawa-2.0' package, then clone below remote repository: * https://github.com/takaswie/hinawa-utils This repository includes two scripts to get information from the device: * hinawa-bebob-parser * hinawa-bebob-connection-cui When your device is detected as sound card '2' and your device is also detected as '/dev/fw1', execute below: $ ./hinawa-bebob-connection-cui 2 graph-connections $ ./hinawa-bebob-parser 1 2 > At startup it lights green ok, but no sound is playable, then the > lights turn orange (like it is when it's not working), I hear a > "relay sound" (a electric clic of a relay), then, the Saffire LE > disapears from the sound menu in Ubuntu sound menu. Once your device is detected and ALSA bebob driver bound to it, pulseaudio detects it and start PCM substream to get capabilities of the device. In your case, the PCM substream is corrupted by the discontinuity. Then pulseaudio give up to use the device. As a result, sound menu drops entry of the device. I guess that the color of LED corresponds to the packet streaming. On Wed, Oct 30, 2019 at 11:12:01AM +0100, Jean-Paul Argudo wrote: > But something new and maybe interesting for you : > > Oct 30 09:25:25 deiphobe pulseaudio[2589]: E: [alsa-sink-BeBoB] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. > Oct 30 09:25:25 deiphobe pulseaudio[2589]: E: [alsa-sink-BeBoB] alsa- sink.c: Most likely this is a bug in the ALSA driver 'snd_bebob'. Please report this issue to the ALSA developers. > Oct 30 09:25:25 deiphobe pulseaudio[2589]: E: [alsa-sink-BeBoB] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. Practically these logs can be ignored. (I work to suppress the above lines in development period for Linux kernel v5.5.) > **And in kern.log** : at the beggining in the boot sequence (?), > between FS-cache lines and usb ones: > > Oct 27 21:54:36 deiphobe kernel: [ 8.742105] FS-Cache: N-key=[8] '020001bdc0a800fe' > > Oct 27 21:54:40 deiphobe kernel: [ 12.768168] usb 3-4.1: reset high- speed USB device number 5 using xhci_hcd > Oct 27 21:54:45 deiphobe kernel: [ 18.294126] snd-bebob fw1.0: transaction failed: no ack > Oct 27 21:54:45 deiphobe kernel: [ 18.294167] snd-bebob fw1.0: fail to get section type for isoc out plug 0: -5 > Oct 27 21:54:45 deiphobe kernel: [ 18.294172] snd-bebob fw1.0: fail to run AMDTP slave stream:-5 > Oct 27 21:54:45 deiphobe kernel: [ 18.306399] firewire_ohci 0000:05:01.0: DMA context still active (0x00000411) > Oct 27 21:54:45 deiphobe kernel: [ 18.318425] firewire_ohci 0000:05:01.0: DMA context still active (0x00000411) > Oct 27 21:54:47 deiphobe kernel: [ 20.311440] irq_handler: 20 callbacks suppressed > Oct 27 21:54:47 deiphobe kernel: [ 20.311441] firewire_ohci 0000:05:01.0: isochronous cycle inconsistent > Oct 27 21:54:48 deiphobe kernel: [ 21.322730] firewire_core 0000:05:01.0: phy config: new root=ffc1, gap_count=5 > > Oct 27 21:54:50 deiphobe kernel: [ 22.970251] rfkill: input handler disabled > Oct 27 20:55:10 deiphobe kernel: [ 42.697284] usb 3-4.1: reset high- speed USB device number 5 using xhci_hcd IEEE 1394 bus 'bus-reset' state. Just before/after the bus-reset, any functionality easily fails. It's better to plug-in the device enough after bootup. Regards Takashi Sakamoto

3 4

[alsa-devel] [ANNOUNCE] fcplay: compressed audio test utility
by Vinod Koul 05 Dec '19

05 Dec '19

Hello, I have forked the cplay test app into fcplay which is a different repo [1] licensed as LGPLv2.1. The reason for fork was me getting sick of seeing the tool miss sync word for mp3 and no support for other formats which I wanted to test. But I was lazy to start exploring all media formats and write a parser for them so I have used libavcodec to the job for me which is GPL. The fcplay links to libavcodec to get compressed audio parameters and then uses tinycompress to send data to sound card. It supports mp3 (no more complaints about sync words) and Flac. I will add more formats, wma etc are in the list along with gapless audio playback and support for new changes coming to gapless audio playback as discussed in audio meeting at Lyon. As usual patches are welcome. Jaroslav, can we add to alsa-project github as well? Thanks -- ~Vinod

2 6