November 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2 00/12] treewide: break dependencies on x86's RM header
by Sean Christopherson 27 Nov '19

27 Nov '19

x86's asm/realmode.h, which defines low level structures, variables and helpers used to bring up APs during SMP boot, ends up getting included in practically every nook and cranny of the kernel because the address used by ACPI for resuming from S3 also happens to be stored in the real mode header, and ACPI bleeds the dependency into its widely included headers. As a result, modifying realmode.h for even the most trivial change to the boot code triggers a full kernel rebuild, which is frustrating to say the least as it some of the most difficult code to get exactly right *and* is also some of the most functionally isolated code in the kernel. To break the kernel's widespread dependency on realmode.h, add a wrapper in the aforementioned ACPI S3 code to access the real mode header instead of derefencing the header directly in asm/acpi.h and thereby exposing it to the world via linux/acpi.h. v2: - Rebased on tip/x86/cleanups, commit b74374fef924 ("x86/setup: Enhance the comments"). - Use acpi_get_wakeup_address() as new function name. [Boris and Pavel] - Capture acpi_get_wakeup_address() in a local address. [Pavel] - Collect acks. I didn't add Rafael's acks on patches 11 and 12 due to the above changes. - Explicitly call out the removal of <asm/realmode.h> from <asm/acpi.h> in patch 12. [Ingo] - Remove superfluous Fixes: tags. [Ard] Patch Synopsis: - Patches 01-09 fix a variety of build errors that arise when patch 12 drops realmode.h from asm/acpi.h. Most of the errors are quite absurb as they have no relation whatsoever to x86's RM boot code, but occur because realmode.h happens to include asm/io.h. - Patch 10 removes a spurious include of realmode.h from an ACPI header. - Patches 11 and 12 implement the wrapper and move it out of acpi.h. Sean Christopherson (12): x86/efi: Explicitly include realmode.h to handle RM trampoline quirk x86/boot: Explicitly include realmode.h to handle RM reservations x86/ftrace: Explicitly include vmalloc.h for set_vm_flush_reset_perms() x86/kprobes: Explicitly include vmalloc.h for set_vm_flush_reset_perms() perf/x86/intel: Explicitly include asm/io.h to use virt_to_phys() efi/capsule-loader: Explicitly include linux/io.h for page_to_phys() virt: vbox: Explicitly include linux/io.h to pick up various defs vmw_balloon: Explicitly include linux/io.h for virt_to_phys() ASoC: Intel: Skylake: Explicitly include linux/io.h for virt_to_phys() x86/ACPI/sleep: Remove an unnecessary include of asm/realmode.h ACPI/sleep: Convert acpi_wakeup_address into a function x86/ACPI/sleep: Move acpi_get_wakeup_address() into sleep.c, remove <asm/realmode.h> from <asm/acpi.h> arch/ia64/include/asm/acpi.h | 5 ++++- arch/ia64/kernel/acpi.c | 2 -- arch/x86/events/intel/ds.c | 1 + arch/x86/include/asm/acpi.h | 3 +-- arch/x86/kernel/acpi/sleep.c | 11 +++++++++++ arch/x86/kernel/acpi/sleep.h | 2 +- arch/x86/kernel/ftrace.c | 1 + arch/x86/kernel/kprobes/core.c | 1 + arch/x86/kernel/setup.c | 1 + arch/x86/platform/efi/quirks.c | 1 + drivers/acpi/sleep.c | 3 +++ drivers/firmware/efi/capsule-loader.c | 1 + drivers/misc/vmw_balloon.c | 1 + drivers/virt/vboxguest/vboxguest_core.c | 1 + drivers/virt/vboxguest/vboxguest_utils.c | 1 + sound/soc/intel/skylake/skl-sst-cldma.c | 1 + 16 files changed, 30 insertions(+), 6 deletions(-) -- 2.24.0

3 16

[alsa-devel] kernel oops related to the new HDA audio handling for DP MST
by Michał Matysiak 27 Nov '19

27 Nov '19

Hi Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one. kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email. Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help? More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891 dmesg output: Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild(a)buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] Nov 26 18:06:16 kernel: Modules linked in: intel_rapl_msr intel_rapl_common iwldvm x86_pkg_temp_thermal intel_powerclamp snd_hda_codec_hdmi coretemp mac80211 snd_hda_codec_conexant snd_hda_codec_generic kvm_intel snd_hda_intel libarc4 snd_intel_nhlt kvm mei_wdt iTCO_wdt snd_hda_codec mei_hdcp iwlwifi irqbypass iTCO_vendor_support snd_hda_core intel_cstate snd_hwdep snd_seq intel_uncore snd_seq_device thinkpad_acpi joydev i2c_i801 wmi_bmof intel_rapl_perf snd_pcm pcspkr ledtrig_audio cfg80211 snd_timer mei_me snd mei soundcore lpc_ich rfkill binfmt_misc ip_tables dm_crypt i915 nouveau crct10dif_pclmul crc32_pclmul mxm_wmi crc32c_intel ttm i2c_algo_bit drm_kms_helper ghash_clmulni_intel sdhci_pci cqhci drm sdhci serio_raw e1000e firewire_ohci mmc_core firewire_core crc_itu_t wmi video fuse Nov 26 18:06:16 kernel: CPU: 0 PID: 461 Comm: kworker/0:2 Tainted: G W 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 #1 Nov 26 18:06:16 kernel: Hardware name: LENOVO 42844DG/42844DG, BIOS 8BET66WW (1.46 ) 06/14/2018 Nov 26 18:06:16 kernel: Workqueue: events azx_probe_work [snd_hda_intel] Nov 26 18:06:16 kernel: RIP: 0010:snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] Nov 26 18:06:16 kernel: Code: 41 89 c4 85 c0 78 3a 45 31 e4 48 8b 44 24 08 65 48 33 04 25 28 00 00 00 75 22 48 83 c4 10 44 89 e0 5b 5d 41 5c 41 5d 41 5e c3 <0f> 0b 41 bc f0 ff ff ff eb d6 41 bc f4 ff ff ff eb ce e8 6b 7c 5f Nov 26 18:06:16 kernel: RSP: 0018:ffffa5e4002a3c28 EFLAGS: 00010286 Nov 26 18:06:16 kernel: RAX: ffff984ae816a7e8 RBX: ffff984aebf91000 RCX: ffff984aeb50c338 Nov 26 18:06:16 kernel: RDX: 0000000000000001 RSI: 0000000000000282 RDI: 0000000000000282 Nov 26 18:06:16 kernel: RBP: ffff984ae53e4df0 R08: 0000000000000282 R09: ffff984aebe4e738 Nov 26 18:06:16 kernel: R10: ffff984ae778a180 R11: ffffa5e4002a3c0f R12: ffffffffc0c270c0 Nov 26 18:06:16 kernel: R13: ffff984aeb50c0b0 R14: 0000000000000000 R15: 0000000000000001 Nov 26 18:06:16 kernel: FS: 0000000000000000(0000) GS:ffff984aee000000(0000) knlGS:0000000000000000 Nov 26 18:06:16 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Nov 26 18:06:16 kernel: CR2: 00007f3a343e8000 CR3: 000000035360a006 CR4: 00000000000606f0 Nov 26 18:06:16 kernel: Call Trace: Nov 26 18:06:16 kernel: generic_acomp_init+0x71/0x90 [snd_hda_codec_hdmi] Nov 26 18:06:16 kernel: patch_nvhdmi+0x58/0x60 [snd_hda_codec_hdmi] Nov 26 18:06:16 kernel: hda_codec_driver_probe+0x92/0x150 [snd_hda_codec] Nov 26 18:06:16 kernel: really_probe+0x298/0x3c0 Nov 26 18:06:16 kernel: driver_probe_device+0xb6/0x100 Nov 26 18:06:16 kernel: ? driver_allows_async_probing+0x50/0x50 Nov 26 18:06:16 kernel: bus_for_each_drv+0x7e/0xc0 Nov 26 18:06:16 kernel: __device_attach+0xdf/0x160 Nov 26 18:06:16 kernel: bus_probe_device+0x8e/0xa0 Nov 26 18:06:16 kernel: device_add+0x3a2/0x670 Nov 26 18:06:16 kernel: snd_hdac_device_register+0x12/0x60 [snd_hda_core] Nov 26 18:06:16 kernel: snd_hda_codec_configure+0x45/0x150 [snd_hda_codec] Nov 26 18:06:16 kernel: azx_codec_configure+0x2f/0x60 [snd_hda_codec] Nov 26 18:06:16 kernel: azx_probe_continue+0x48c/0x700 [snd_hda_intel] Nov 26 18:06:16 kernel: process_one_work+0x1b0/0x350 Nov 26 18:06:16 kernel: worker_thread+0x50/0x3b0 Nov 26 18:06:16 kernel: kthread+0xfb/0x130 Nov 26 18:06:16 kernel: ? process_one_work+0x350/0x350 Nov 26 18:06:16 kernel: ? kthread_park+0x90/0x90 Nov 26 18:06:16 kernel: ret_from_fork+0x35/0x40 Nov 26 18:06:16 kernel: ---[ end trace 3c8d65bedba62849 ]--- Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input15 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input16 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input17 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input18 -- Regards, Michał Matysiak

3 13

[alsa-devel] [PATCH v2] ALSA: hda: hdmi - fix regression in connect list handling
by Kai Vehmanen 27 Nov '19

27 Nov '19

Fix regression in how intel_haswell_fixup_connect_list() results are used in hda_read_pin_conn(). Use of snd_hda_get_raw_connections() in hda_read_pin_conn() bypasses the cache and thus also bypasses the overridden pin connection list. On platforms that require the connection list fixup, mux list will be empty and HDMI playback will fail to -EBUSY at open. Fix the regression in hda_read_pinn_conn(). Simplify code as suggested by Takashi Iwai to remove old intel_haswell_fixup_connect_list() and copy the cvt_nid list directly and not use snd_hda_override_conn_list() at all. Fixes: 9c32fea83692 ("ALSA: hda - Add DP-MST support for non-acomp codecs") BugLink: https://github.com/thesofproject/linux/issues/1537 Cc: Nikhil Mahale <nmahale(a)nvidia.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 42 +++++++++++--------------------------- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 55d20e40a195..cad99e1f9222 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1302,6 +1302,7 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx); hda_nid_t pin_nid = per_pin->pin_nid; int dev_id = per_pin->dev_id; + int conns; if (!(get_wcaps(codec, pin_nid) & AC_WCAP_CONN_LIST)) { codec_warn(codec, @@ -1312,10 +1313,18 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) snd_hda_set_dev_select(codec, pin_nid, dev_id); + if (spec->intel_hsw_fixup) { + conns = spec->num_cvts; + memcpy(per_pin->mux_nids, spec->cvt_nids, + sizeof(hda_nid_t) * conns); + } else { + conns = snd_hda_get_raw_connections(codec, pin_nid, + per_pin->mux_nids, + HDA_MAX_CONNECTIONS); + } + /* all the device entries on the same pin have the same conn list */ - per_pin->num_mux_nids = - snd_hda_get_raw_connections(codec, pin_nid, per_pin->mux_nids, - HDA_MAX_CONNECTIONS); + per_pin->num_mux_nids = conns; return 0; } @@ -1713,9 +1722,6 @@ static void hdmi_repoll_eld(struct work_struct *work) mutex_unlock(&spec->pcm_lock); } -static void intel_haswell_fixup_connect_list(struct hda_codec *codec, - hda_nid_t nid); - static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) { struct hdmi_spec *spec = codec->spec; @@ -1790,8 +1796,6 @@ static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) per_pin->dev_id = i; per_pin->non_pcm = false; snd_hda_set_dev_select(codec, pin_nid, i); - if (spec->intel_hsw_fixup) - intel_haswell_fixup_connect_list(codec, pin_nid); err = hdmi_read_pin_conn(codec, pin_idx); if (err < 0) return err; @@ -2599,28 +2603,6 @@ static void generic_acomp_init(struct hda_codec *codec, } } -/* - * Intel codec parsers and helpers - */ - -static void intel_haswell_fixup_connect_list(struct hda_codec *codec, - hda_nid_t nid) -{ - struct hdmi_spec *spec = codec->spec; - hda_nid_t conns[4]; - int nconns; - - nconns = snd_hda_get_raw_connections(codec, nid, conns, - ARRAY_SIZE(conns)); - if (nconns == spec->num_cvts && - !memcmp(conns, spec->cvt_nids, spec->num_cvts * sizeof(hda_nid_t))) - return; - - /* override pins connection list */ - codec_dbg(codec, "hdmi: haswell: override pin connection 0x%x\n", nid); - snd_hda_override_conn_list(codec, nid, spec->num_cvts, spec->cvt_nids); -} - #define INTEL_GET_VENDOR_VERB 0xf81 #define INTEL_SET_VENDOR_VERB 0x781 #define INTEL_EN_DP12 0x02 /* enable DP 1.2 features */ -- 2.17.1

1 0

[alsa-devel] [PATCH] ALSA: hda: hdmi - fix regression in connect list handling
by Kai Vehmanen 27 Nov '19

27 Nov '19

Fix regression in how intel_haswell_fixup_connect_list() results are used in hda_read_pin_conn(). Use of snd_hda_get_raw_connections() in hda_read_pin_conn() bypasses the cache and thus also bypasses the overridden pin connection list. On platforms that require the connection list fixup, mux list will be empty and HDMI playback will fail to -EBUSY at open. Move intel_haswell_fixup_connect_list() call to hda_read_pin_conn() as it's not used elsewhere. Fixes: 9c32fea83692 ("ALSA: hda - Add DP-MST support for non-acomp codecs") BugLink: https://github.com/thesofproject/linux/issues/1537 Cc: Nikhil Mahale <nmahale(a)nvidia.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 55d20e40a195..c111bdd566c9 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1293,6 +1293,9 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, return err; } +static void intel_haswell_fixup_connect_list(struct hda_codec *codec, + hda_nid_t nid); + /* * HDA/HDMI auto parsing */ @@ -1302,6 +1305,7 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx); hda_nid_t pin_nid = per_pin->pin_nid; int dev_id = per_pin->dev_id; + int conns; if (!(get_wcaps(codec, pin_nid) & AC_WCAP_CONN_LIST)) { codec_warn(codec, @@ -1312,10 +1316,19 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) snd_hda_set_dev_select(codec, pin_nid, dev_id); + if (spec->intel_hsw_fixup) { + intel_haswell_fixup_connect_list(codec, pin_nid); + conns = snd_hda_get_connections(codec, pin_nid, + per_pin->mux_nids, + HDA_MAX_CONNECTIONS); + } else { + conns = snd_hda_get_raw_connections(codec, pin_nid, + per_pin->mux_nids, + HDA_MAX_CONNECTIONS); + } + /* all the device entries on the same pin have the same conn list */ - per_pin->num_mux_nids = - snd_hda_get_raw_connections(codec, pin_nid, per_pin->mux_nids, - HDA_MAX_CONNECTIONS); + per_pin->num_mux_nids = conns; return 0; } @@ -1713,9 +1726,6 @@ static void hdmi_repoll_eld(struct work_struct *work) mutex_unlock(&spec->pcm_lock); } -static void intel_haswell_fixup_connect_list(struct hda_codec *codec, - hda_nid_t nid); - static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) { struct hdmi_spec *spec = codec->spec; @@ -1790,8 +1800,6 @@ static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) per_pin->dev_id = i; per_pin->non_pcm = false; snd_hda_set_dev_select(codec, pin_nid, i); - if (spec->intel_hsw_fixup) - intel_haswell_fixup_connect_list(codec, pin_nid); err = hdmi_read_pin_conn(codec, pin_idx); if (err < 0) return err; -- 2.17.1

2 3

[alsa-devel] [PATCH] ALSA: aloop: Avoid pointer dereference before null-check
by Andrew Gabbasov 27 Nov '19

27 Nov '19

Static analysis tools (cppcheck and PVS Studio) report an error in loopback_snd_timer_period_elapsed() regarding dpcm_play pointer dereference earlier than its null-check. And although this is a result of a formal check, and the pointer correctness is also protected by having a corresponding bit set in the "running" mask, re-ordering of the lines can imake the code even formally correct and eliminate those static analysis error reports. Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies") Reported-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> Signed-off-by: Andrew Gabbasov <andrew_gabbasov(a)mentor.com> --- sound/drivers/aloop.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index 0ebfbe70db00..6bb46423f5ae 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -727,10 +727,6 @@ static void loopback_snd_timer_period_elapsed(struct loopback_cable *cable, dpcm_play = cable->streams[SNDRV_PCM_STREAM_PLAYBACK]; dpcm_capt = cable->streams[SNDRV_PCM_STREAM_CAPTURE]; - substream_play = (running & (1 << SNDRV_PCM_STREAM_PLAYBACK)) ? - dpcm_play->substream : NULL; - substream_capt = (running & (1 << SNDRV_PCM_STREAM_CAPTURE)) ? - dpcm_capt->substream : NULL; if (event == SNDRV_TIMER_EVENT_MSTOP) { if (!dpcm_play || @@ -741,6 +737,10 @@ static void loopback_snd_timer_period_elapsed(struct loopback_cable *cable, } } + substream_play = (running & (1 << SNDRV_PCM_STREAM_PLAYBACK)) ? + dpcm_play->substream : NULL; + substream_capt = (running & (1 << SNDRV_PCM_STREAM_CAPTURE)) ? + dpcm_capt->substream : NULL; valid_runtime = (running & (1 << SNDRV_PCM_STREAM_PLAYBACK)) ? dpcm_play->substream->runtime : dpcm_capt->substream->runtime; -- 2.21.0

2 1

[alsa-devel] Multiple LADSPA plugin paths when some of them error
by jimmy＠spalge.com 27 Nov '19

27 Nov '19

Having multiple lookup paths for ladspa plugins is supported by separating them with ":" in a "path" directive on the pcm definition in asoundrc or the LADSPA_PATH environment variable. But if there is an error encountered while looking for the plugin in one of the earlier paths than later ones won't be checked. My use case is that I have a mixed architecture system (moving from 32 to 64 bit) and I need applications of both architectures to do sound stuff. Since the dlopen will always fail for one of them it doesn't quite work as-is (I've patched it locally sufficient for my needs). I think snd_pcm_ladspa_look_for_plugin in src/pcm/pcm_ladspa.c should be changed to not return on errors in the loop but just log a message and proceed.

1 0

[alsa-devel] Converting a non BE to BE inside soc_check_tplg_fes
by Daniel Baluta 26 Nov '19

26 Nov '19

Hi all, I am trying how a non-BE link is converted to a BE link inside soc_check_tplg_fes. soc_check_tplg_fes => for all components that have ignore_machine setup to card name => dai_link->platforms->name = component->name; => dai_link->no_pcm = 1; But the thing is that the link is a true non-DPCM link, than fields like dpcm_playback/dpcm_capture are not set and playback/record substreams are no created. The question is: is this supposed to be working with non-DPCM links?

3 4

[alsa-devel] [PATCH 0/4] add runtime pm support for AMD display audio
by Alex Deucher 26 Nov '19

26 Nov '19

These patches were originally part of a larger set of patches to enabled runtime pm support on the GPU side[1]. However, the patches are useful on their own there are really no dependencies, other than the fact that you need both for runtime pm to kick in on the GPU side. The GPU side will be landing for 5.6; I'd like to land the audio side as well. Thanks, Alex [1]: https://patchwork.freedesktop.org/series/67885/ Alex Deucher (4): ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio ALSA: hda/hdmi - enable runtime pm for newer AMD display audio ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by default sound/pci/hda/hda_intel.c | 80 +++++++++++++++++++++++++++++++++++--- sound/pci/hda/patch_hdmi.c | 1 + 2 files changed, 76 insertions(+), 5 deletions(-) -- 2.23.0

2 10

[alsa-devel] Sof upstream
by GitHub pull_request - opened 26 Nov '19

26 Nov '19

alsa-project/alsa-ucm-conf pull request #7 was opened from juimonen: Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/7 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/7.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header
by Sean Christopherson 26 Nov '19

26 Nov '19

x86's asm/realmode.h, which defines low level structures, variables and helpers used to bring up APs during SMP boot, ends up getting included in practically every nook and cranny of the kernel because the address used by ACPI for resuming from S3 also happens to be stored in the real mode header, and ACPI bleeds the dependency into its widely included headers. As a result, modifying realmode.h for even the most trivial change to the boot code triggers a full kernel rebuild, which is frustrating to say the least as it some of the most difficult code to get exactly right *and* is also some of the most functionally isolated code in the kernel. To break the kernel's widespread dependency on realmode.h, add a wrapper in the aforementioned ACPI S3 code to access the real mode header instead of derefencing the header directly in asm/acpi.h and thereby exposing it to the world via linux/acpi.h. Build tested on x86 with allyesconfig and allmodconfig, so hopefully there aren't more build issues lurking, but at this point it wouldn't surprise me in the least if this somehow manages to break the build. Based on tip/master, commit ceceaf1f12ba ("Merge branch 'WIP.x86/cleanups'"). Patch Synopsis: - Patches 01-09 fix a variety of build errors that arise when patch 12 drops realmode.h from asm/acpi.h. Most of the errors are quite absurb as they have no relation whatsoever to x86's RM boot code, but occur because realmode.h happens to include asm/io.h. - Patch 10 removes a spurious include of realmode.h from an ACPI header. - Patches 11 and 12 implement the wrapper and move it out of acpi.h. Sean Christopherson (12): x86/efi: Explicitly include realmode.h to handle RM trampoline quirk x86/boot: Explicitly include realmode.h to handle RM reservations x86/ftrace: Explicitly include vmalloc.h for set_vm_flush_reset_perms() x86/kprobes: Explicitly include vmalloc.h for set_vm_flush_reset_perms() perf/x86/intel: Explicitly include asm/io.h to use virt_to_phys() efi/capsule-loader: Explicitly include linux/io.h for page_to_phys() virt: vbox: Explicitly include linux/io.h to pick up various defs vmw_balloon: Explicitly include linux/io.h for virt_to_phys() ASoC: Intel: Skylake: Explicitly include linux/io.h for virt_to_phys() x86/ACPI/sleep: Remove an unnecessary include of asm/realmode.h ACPI/sleep: Convert acpi_wakeup_address into a function x86/ACPI/sleep: Move acpi_wakeup_address() definition into sleep.c arch/ia64/include/asm/acpi.h | 5 ++++- arch/ia64/kernel/acpi.c | 2 -- arch/x86/events/intel/ds.c | 1 + arch/x86/include/asm/acpi.h | 3 +-- arch/x86/kernel/acpi/sleep.c | 11 +++++++++++ arch/x86/kernel/acpi/sleep.h | 2 +- arch/x86/kernel/ftrace.c | 1 + arch/x86/kernel/kprobes/core.c | 1 + arch/x86/kernel/setup.c | 1 + arch/x86/platform/efi/quirks.c | 1 + drivers/acpi/sleep.c | 4 ++-- drivers/firmware/efi/capsule-loader.c | 1 + drivers/misc/vmw_balloon.c | 1 + drivers/virt/vboxguest/vboxguest_core.c | 1 + drivers/virt/vboxguest/vboxguest_utils.c | 1 + sound/soc/intel/skylake/skl-sst-cldma.c | 1 + 16 files changed, 29 insertions(+), 8 deletions(-) -- 2.24.0

8 28