October 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v4 0/2] Add CML M/C for RT5682 and RT1011
by sathya.prakash.m.r＠intel.com 24 Oct '19

24 Oct '19

From: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> The series adds CML m/c driver with RT5682 on SSP0 and RT1011 on SSP1. The RT1011 is smart AMP which supports 2 Whoofers and 2 tweeter support. RT5682 is headset codec supporting playback and record. The m/c supports HDMI playback and DMIC record. Naveen Manohar (2): ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 ASoC: Intel: Add acpi match for rt1011 based m/c driver sound/soc/intel/boards/Kconfig | 18 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/cml_rt1011_rt5682.c | 473 ++++++++++++++++++++++ sound/soc/intel/common/soc-acpi-intel-cnl-match.c | 7 + 4 files changed, 500 insertions(+) create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c -- V3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Changes from V3: repost with more recipients and edits to commit messages Changes from V2: re ordered match table to ensure non i2c device matches are at the end Changes from V1: Addressed comments on ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 1.9.1

3 5

[alsa-devel] KASAN: use-after-free Read in build_audio_procunit
by syzbot 24 Oct '19

24 Oct '19

Hello, syzbot found the following crash on: HEAD commit: 22be26f7 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=17cdccc4e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=387eccb7ac68ec5 dashboard link: https://syzkaller.appspot.com/bug?extid=fd965c77e4711eb13b82 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13fe752f600000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17989fd8e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+fd965c77e4711eb13b82(a)syzkaller.appspotmail.com usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 1-1: Product: syz usb 1-1: Manufacturer: syz usb 1-1: SerialNumber: syz ================================================================== BUG: KASAN: use-after-free in uac_extension_unit_iExtension include/uapi/linux/usb/audio.h:483 [inline] BUG: KASAN: use-after-free in build_audio_procunit+0xeab/0x13f0 sound/usb/mixer.c:2434 Read of size 1 at addr ffff8881d4c0140d by task kworker/0:1/12 CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.4.0-rc3+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 print_address_description.constprop.0+0x36/0x50 mm/kasan/report.c:374 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:506 kasan_report+0xe/0x20 mm/kasan/common.c:634 uac_extension_unit_iExtension include/uapi/linux/usb/audio.h:483 [inline] build_audio_procunit+0xeab/0x13f0 sound/usb/mixer.c:2434 parse_audio_extension_unit sound/usb/mixer.c:2483 [inline] parse_audio_unit+0x1812/0x36f0 sound/usb/mixer.c:2761 snd_usb_mixer_controls+0x715/0xb90 sound/usb/mixer.c:3095 snd_usb_create_mixer+0x2b5/0x1890 sound/usb/mixer.c:3445 usb_audio_probe+0xc76/0x2010 sound/usb/card.c:653 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x104/0x210 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490 device_add+0xae6/0x16f0 drivers/base/core.c:2201 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x104/0x210 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490 device_add+0xae6/0x16f0 drivers/base/core.c:2201 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Allocated by task 12: save_stack+0x1b/0x80 mm/kasan/common.c:69 set_track mm/kasan/common.c:77 [inline] __kasan_kmalloc mm/kasan/common.c:510 [inline] __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:483 kmalloc include/linux/slab.h:561 [inline] usb_alloc_urb+0x65/0xb0 drivers/usb/core/urb.c:73 usb_internal_control_msg drivers/usb/core/message.c:94 [inline] usb_control_msg+0x1c9/0x4a0 drivers/usb/core/message.c:152 usb_get_descriptor+0xc1/0x1b0 drivers/usb/core/message.c:647 usb_get_configuration+0x28e/0x3050 drivers/usb/core/config.c:836 usb_enumerate_device drivers/usb/core/hub.c:2369 [inline] usb_new_device+0xd3/0x160 drivers/usb/core/hub.c:2505 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Freed by task 12: save_stack+0x1b/0x80 mm/kasan/common.c:69 set_track mm/kasan/common.c:77 [inline] kasan_set_free_info mm/kasan/common.c:332 [inline] __kasan_slab_free+0x130/0x180 mm/kasan/common.c:471 slab_free_hook mm/slub.c:1424 [inline] slab_free_freelist_hook mm/slub.c:1475 [inline] slab_free mm/slub.c:3018 [inline] kfree+0xe4/0x320 mm/slub.c:3967 urb_destroy drivers/usb/core/urb.c:26 [inline] kref_put include/linux/kref.h:65 [inline] usb_free_urb.part.0+0x7a/0xc0 drivers/usb/core/urb.c:95 usb_free_urb+0x1b/0x30 drivers/usb/core/urb.c:94 usb_start_wait_urb+0x1e5/0x2b0 drivers/usb/core/message.c:79 usb_internal_control_msg drivers/usb/core/message.c:101 [inline] usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:152 usb_get_descriptor+0xc1/0x1b0 drivers/usb/core/message.c:647 usb_get_configuration+0x28e/0x3050 drivers/usb/core/config.c:836 usb_enumerate_device drivers/usb/core/hub.c:2369 [inline] usb_new_device+0xd3/0x160 drivers/usb/core/hub.c:2505 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 The buggy address belongs to the object at ffff8881d4c01400 which belongs to the cache kmalloc-192 of size 192 The buggy address is located 13 bytes inside of 192-byte region [ffff8881d4c01400, ffff8881d4c014c0) The buggy address belongs to the page: page:ffffea0007530040 refcount:1 mapcount:0 mapping:ffff8881da002a00 index:0x0 flags: 0x200000000000200(slab) raw: 0200000000000200 ffffea000754fec0 0000000200000002 ffff8881da002a00 raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8881d4c01300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ffff8881d4c01380: 00 00 00 07 fc fc fc fc fc fc fc fc fc fc fc fc > ffff8881d4c01400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff8881d4c01480: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ffff8881d4c01500: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

2 1

[alsa-devel] KASAN: use-after-free Read in parse_term_proc_unit
by syzbot 24 Oct '19

24 Oct '19

Hello, syzbot found the following crash on: HEAD commit: 22be26f7 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=13a38628e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=387eccb7ac68ec5 dashboard link: https://syzkaller.appspot.com/bug?extid=97e24236f1e2918ad968 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12184764e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1432ae28e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+97e24236f1e2918ad968(a)syzkaller.appspotmail.com usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 1-1: Product: syz usb 1-1: Manufacturer: syz usb 1-1: SerialNumber: syz ================================================================== BUG: KASAN: use-after-free in uac_processing_unit_iProcessing include/uapi/linux/usb/audio.h:429 [inline] BUG: KASAN: use-after-free in parse_term_proc_unit+0x57a/0x5e0 sound/usb/mixer.c:896 Read of size 1 at addr ffff8881d5346d0e by task kworker/1:2/83 CPU: 1 PID: 83 Comm: kworker/1:2 Not tainted 5.4.0-rc3+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 print_address_description.constprop.0+0x36/0x50 mm/kasan/report.c:374 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:506 kasan_report+0xe/0x20 mm/kasan/common.c:634 uac_processing_unit_iProcessing include/uapi/linux/usb/audio.h:429 [inline] parse_term_proc_unit+0x57a/0x5e0 sound/usb/mixer.c:896 __check_input_term+0xc32/0x13f0 sound/usb/mixer.c:984 parse_audio_feature_unit sound/usb/mixer.c:1875 [inline] parse_audio_unit+0x101d/0x36f0 sound/usb/mixer.c:2753 snd_usb_mixer_controls+0x715/0xb90 sound/usb/mixer.c:3095 snd_usb_create_mixer+0x2b5/0x1890 sound/usb/mixer.c:3445 usb_audio_probe+0xc76/0x2010 sound/usb/card.c:653 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x104/0x210 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490 device_add+0xae6/0x16f0 drivers/base/core.c:2201 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 really_probe+0x281/0x6d0 drivers/base/dd.c:548 driver_probe_device+0x104/0x210 drivers/base/dd.c:721 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430 __device_attach+0x217/0x360 drivers/base/dd.c:894 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490 device_add+0xae6/0x16f0 drivers/base/core.c:2201 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Allocated by task 83: save_stack+0x1b/0x80 mm/kasan/common.c:69 set_track mm/kasan/common.c:77 [inline] __kasan_kmalloc mm/kasan/common.c:510 [inline] __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:483 kmalloc include/linux/slab.h:561 [inline] usb_alloc_urb+0x65/0xb0 drivers/usb/core/urb.c:73 usb_internal_control_msg drivers/usb/core/message.c:94 [inline] usb_control_msg+0x1c9/0x4a0 drivers/usb/core/message.c:152 usb_get_descriptor+0xc1/0x1b0 drivers/usb/core/message.c:647 usb_get_configuration+0x28e/0x3050 drivers/usb/core/config.c:836 usb_enumerate_device drivers/usb/core/hub.c:2369 [inline] usb_new_device+0xd3/0x160 drivers/usb/core/hub.c:2505 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Freed by task 83: save_stack+0x1b/0x80 mm/kasan/common.c:69 set_track mm/kasan/common.c:77 [inline] kasan_set_free_info mm/kasan/common.c:332 [inline] __kasan_slab_free+0x130/0x180 mm/kasan/common.c:471 slab_free_hook mm/slub.c:1424 [inline] slab_free_freelist_hook mm/slub.c:1475 [inline] slab_free mm/slub.c:3018 [inline] kfree+0xe4/0x320 mm/slub.c:3967 urb_destroy drivers/usb/core/urb.c:26 [inline] kref_put include/linux/kref.h:65 [inline] usb_free_urb.part.0+0x7a/0xc0 drivers/usb/core/urb.c:95 usb_free_urb+0x1b/0x30 drivers/usb/core/urb.c:94 usb_start_wait_urb+0x1e5/0x2b0 drivers/usb/core/message.c:79 usb_internal_control_msg drivers/usb/core/message.c:101 [inline] usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:152 usb_get_descriptor+0xc1/0x1b0 drivers/usb/core/message.c:647 usb_get_configuration+0x28e/0x3050 drivers/usb/core/config.c:836 usb_enumerate_device drivers/usb/core/hub.c:2369 [inline] usb_new_device+0xd3/0x160 drivers/usb/core/hub.c:2505 hub_port_connect drivers/usb/core/hub.c:5183 [inline] hub_port_connect_change drivers/usb/core/hub.c:5323 [inline] port_event drivers/usb/core/hub.c:5469 [inline] hub_event+0x1dd0/0x37e0 drivers/usb/core/hub.c:5551 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 worker_thread+0x96/0xe20 kernel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 The buggy address belongs to the object at ffff8881d5346d00 which belongs to the cache kmalloc-192 of size 192 The buggy address is located 14 bytes inside of 192-byte region [ffff8881d5346d00, ffff8881d5346dc0) The buggy address belongs to the page: page:ffffea000754d180 refcount:1 mapcount:0 mapping:ffff8881da002a00 index:0x0 flags: 0x200000000000200(slab) raw: 0200000000000200 ffffea0007548ac0 0000000900000009 ffff8881da002a00 raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8881d5346c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ffff8881d5346c80: 00 00 00 00 05 fc fc fc fc fc fc fc fc fc fc fc > ffff8881d5346d00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff8881d5346d80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ffff8881d5346e00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

2 1

[alsa-devel] [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
by Aaron Ma 24 Oct '19

24 Oct '19

These 2 ThinkCentres installed a new realtek codec ID 0x623, it has 2 front mics with the same location on pin 0x18 and 0x19. Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic location to right, then pulseaudio can handle them. One "Front Mic" and one "Mic" will be shown, and audio output works fine. Signed-off-by: Aaron Ma <aaron.ma(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b000b36ac3c6..c34d8b435f58 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7186,6 +7186,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI), SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -9187,6 +9189,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = { HDA_CODEC_ENTRY(0x10ec0298, "ALC298", patch_alc269), HDA_CODEC_ENTRY(0x10ec0299, "ALC299", patch_alc269), HDA_CODEC_ENTRY(0x10ec0300, "ALC300", patch_alc269), + HDA_CODEC_ENTRY(0x10ec0623, "ALC623", patch_alc269), HDA_CODEC_REV_ENTRY(0x10ec0861, 0x100340, "ALC660", patch_alc861), HDA_CODEC_ENTRY(0x10ec0660, "ALC660-VD", patch_alc861vd), HDA_CODEC_ENTRY(0x10ec0861, "ALC861", patch_alc861), -- 2.17.1

4 10

[alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue
by Jerome Brunet 24 Oct '19

24 Oct '19

This patchset fixes the locking issue reported by Russell. As explained a mutex was used as flag and held while returning to userspace. Patch 2 is entirely optional and switches from bit atomic operation to mutex again. I tend to prefer bit atomic operation in this particular case but either way should be fine. Jerome Brunet (2): Revert "ASoC: hdmi-codec: re-introduce mutex locking" ASoC: hdmi-codec: re-introduce mutex locking again sound/soc/codecs/hdmi-codec.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) -- 2.21.0

4 10

[alsa-devel] [PATCH] ASoC: rt5650: Add Kahlee platform specfic changes
by Curtis Malainey 24 Oct '19

24 Oct '19

From: Akshu Agrawal <akshu.agrawal(a)amd.com> Add platform specific data for Kahlee project. Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> Signed-off-by: Shirish S <shirish.s(a)amd.com> Signed-off-by: Curtis Malainey <cujomalainey(a)chromium.org> --- sound/soc/codecs/rt5645.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 1c06b3b9218c5..a15e4ecd2a241 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3636,6 +3636,12 @@ static const struct rt5645_platform_data lattepanda_board_platform_data = { .inv_jd1_1 = true }; +static const struct rt5645_platform_data kahlee_platform_data = { + .dmic1_data_pin = RT5645_DMIC_DATA_GPIO5, + .dmic2_data_pin = RT5645_DMIC_DATA_IN2P, + .jd_mode = 3, +}; + static const struct dmi_system_id dmi_platform_data[] = { { .ident = "Chrome Buddy", @@ -3742,6 +3748,13 @@ static const struct dmi_system_id dmi_platform_data[] = { }, .driver_data = (void *)&lattepanda_board_platform_data, }, + { + .ident = "Chrome Kahlee", + .matches = { + DMI_MATCH(DMI_PRODUCT_NAME, "Kahlee"), + }, + .driver_data = (void *)&kahlee_platform_data, + }, { } }; -- 2.24.0.rc0.303.g954a862665-goog

2 1

[alsa-devel] [PATCH v3 0/5] soundwire: intel/cadence: better initialization
by Pierre-Louis Bossart 24 Oct '19

24 Oct '19

Changes since v2: addressed feedback from Vinod Koul on patch 2&4 Add kernel taint when using debugfs hw_reset (similar to regmap) Remove useless goto label Changes since v1: addressed feedback from Vinod Koul clarified init changes impact Intel and Cadence sides remove unnecessary intermediate variable disable interrupts when exit_reset fails, updated error handling returned -EINVAL on debugfs invalid parameter Pierre-Louis Bossart (5): soundwire: intel/cadence: fix startup sequence soundwire: cadence_master: add hw_reset capability in debugfs soundwire: intel: add helper for initialization soundwire: intel/cadence: add flag for interrupt enable soundwire: cadence_master: make clock stop exit configurable on init drivers/soundwire/cadence_master.c | 134 +++++++++++++++++++++-------- drivers/soundwire/cadence_master.h | 5 +- drivers/soundwire/intel.c | 39 ++++++--- 3 files changed, 129 insertions(+), 49 deletions(-) -- 2.20.1

2 6

[alsa-devel] [PATCH 0/2] ASoC: SOF: make hw_info platform specific
by Pierre-Louis Bossart 24 Oct '19

24 Oct '19

The SOF core blindly sets the hw_info, when it should really be platform-specific. This move enable us to temporarily fix PulseAudio issues resulting from inaccuracies in the hw_ptr position provided by the firmware on Baytrail-Broadwell. This is the first time we experiment with the GitHub low-level API to automagically keep track of 'approvers' by inserting a Reviewed-by tag when merging a pull-request, thanks to Ranjani for her initial work and bearing with my habit of breaking things :-) Pierre-Louis Bossart (2): ASoC: SOF: define INFO_ flags in dsp_ops ASoC: SOF: Intel: only support INFO_BATCH for legacy platforms sound/soc/sof/imx/imx8.c | 7 +++++++ sound/soc/sof/intel/apl.c | 7 +++++++ sound/soc/sof/intel/bdw.c | 9 ++++++++- sound/soc/sof/intel/byt.c | 21 +++++++++++++++++++++ sound/soc/sof/intel/cnl.c | 7 +++++++ sound/soc/sof/pcm.c | 8 +++----- sound/soc/sof/sof-priv.h | 3 +++ 7 files changed, 56 insertions(+), 6 deletions(-) -- 2.20.1

2 3

[alsa-devel] [PATCH] soundwire: slave: fix scanf format
by Pierre-Louis Bossart 24 Oct '19

24 Oct '19

fix cppcheck warning: [drivers/soundwire/slave.c:145]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- drivers/soundwire/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c index 48a63ca130d2..6473fa602f82 100644 --- a/drivers/soundwire/slave.c +++ b/drivers/soundwire/slave.c @@ -128,7 +128,8 @@ int sdw_of_find_slaves(struct sdw_bus *bus) struct device_node *node; for_each_child_of_node(bus->dev->of_node, node) { - int link_id, sdw_version, ret, len; + int link_id, ret, len; + unsigned int sdw_version; const char *compat = NULL; struct sdw_slave_id id; const __be32 *addr; -- 2.20.1

2 1

[alsa-devel] AC97 audio-routing [was: Recording on WM9712]
by Matej Kupljen 24 Oct '19

24 Oct '19

Hi all, I am not sure how to specify audio-routing for AC97 codec. If I use the similar setting as the UDOO board (which was the only board that uses AC97 codec I could find) I get warnings during booting: [ 3.261369] fsl-asoc-card sound: ac97-hifi <-> 202c000.ssi mapping ok [ 3.267917] fsl-asoc-card sound: ASoC: no sink widget found for Playback [ 3.274642] fsl-asoc-card sound: ASoC: Failed to add route AC97 Playback -> direct -> Playback [ 3.283309] fsl-asoc-card sound: ASoC: no source widget found for Capture [ 3.290141] fsl-asoc-card sound: ASoC: Failed to add route Capture -> direct -> AC97 Capture This was tested on kernel Linux version 4.14.134. However, the card is detected: [ 4.041646] ALSA device list: [ 4.044628] #0: ac97-audio and I can use it for playback normally, but the capture is "slow" as described in my previous e-mail. Then I tried to build and boot the latest kernel from GIT (Linux version 5.4.0-rc4) using the same DTS, I get additional warnings from the kernel: [ 2.639878] fsl-asoc-card sound: ac97-hifi <-> 202c000.ssi mapping ok [ 2.651321] fsl-asoc-card sound: ASoC: source widget AC97 Playback overwritten [ 2.658595] fsl-asoc-card sound: ASoC: no sink widget found for Playback [ 2.665317] fsl-asoc-card sound: ASoC: Failed to add route AC97 Playback -> direct -> Playback [ 2.673974] fsl-asoc-card sound: ASoC: sink widget AC97 Capture overwritten [ 2.680986] fsl-asoc-card sound: ASoC: no source widget found for Capture [ 2.687822] fsl-asoc-card sound: ASoC: Failed to add route Capture -> direct -> AC97 Capture [ 2.718636] fsl-asoc-card sound: snd_soc_register_card failed (-19) and the card is not detected: [ 3.285543] ALSA device list: [ 3.288518] No soundcards found. As you can see, there are additional warnings about widget overwrite, because this check was added to the latest kernel, as seen from the kernel source code. This is the setting from my DTS file: sound { compatible = "fsl,imx-audio-ac97"; model = "fsl,imx6q-ac97"; audio-cpu = <&ssi2>; audio-routing = "RX", "Mic Jack", "Headphone Jack", "TX"; mux-int-port = <2>; mux-ext-port = <5>; }; As you can see, I do not even specify any routing about AC97 Playback/Capture and I still get those warnings. For the test, I commented out the code in sound/soc/soc-core.c in function snd_soc_instantiate_card, to ignore the return values from the call to snd_soc_dapm_add_routes and then I can use the card for playback, but the recording has the issues again. What seems to be wrong with this AC97 audio routing? Any suggestions? I am willing to test this on the latest kernel, or from some other GIT repo if needed. Thanks and BR, Matej

1 0