September 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/5] Set SNDRV_PCM_INFO_SYNC_APPLPTR to indirect PCM usages
by Takashi Iwai 04 Sep '18

04 Sep '18

Hi, this is a patch set to pass the missing SNDRV_PCM_INFO_SYNC_APPLPTR flag to the drivers using the indirect PCM helpers. Also, one cleanup of the indirect PCM helper usage in mips/hal2 driver is included. Takashi === Takashi Iwai (5): ALSA: rme32: Use SNDRV_PCM_INFO_SYNC_APPLPTR info flag ALSA: mips: Use SNDRV_PCM_INFO_SYNC_APPLPTR info flag ALSA: emu10k1: Use SNDRV_PCM_INFO_SYNC_APPLPTR info flag ALSA: cs46xx: Use SNDRV_PCM_INFO_SYNC_APPLPTR info flag ALSA: mips: Cleanup indirect PCM helper usages sound/mips/hal2.c | 13 +++++-------- sound/pci/cs46xx/cs46xx_lib.c | 6 ++++-- sound/pci/emu10k1/emupcm.c | 3 ++- sound/pci/rme32.c | 22 ++++++++-------------- 4 files changed, 19 insertions(+), 25 deletions(-) -- 2.18.0

2 6

[alsa-devel] Possibility of routing at the kernel level
by Mark Farrugia 04 Sep '18

04 Sep '18

Hi all, I am currently using the ALSA loopback driver to create a "virtual" sound card to abstract underlying real sound cards. I capture from the loopback in user-space, and then subsequently playback to a real sound card. The issue with this is that there is a significant latency introduced (~100ms) due to the number of transitions of the stream from user to kernel space. I am seeking a way to avoid this. My question is this: is there any way of routing PCM substreams at the kernel level, so that we can avoid the need to pipe audio back up to user-space with the loopback capturer? If there is no current solution that would achieve this, I would proposition to design and implement a system that uses a top-level ALSA driver, which then routes dynamically to one or many subscribed lower-level "audio path" drivers. The system would also have the option to loopback upon itself. Does anyone see any reason that I couldn't (or shouldn't) attempt such a solution? All feedback is welcome. Regards, Mark

2 3

[alsa-devel] [PATCH 00/13] ASoC: add full BUSIF support
by Kuninori Morimoto 04 Sep '18

04 Sep '18

Hi Mark Cc: Jiada, Timo, Dragos Dragos, Jiada, Timo added full BUSIF support, expand TDM mode, TDM split mode and its related features to Renesas sound driver on v4.14 base kernel. Thank you Dragos, Jiada, Timo. Unfortunately, I can't confirm expand TDM mode, TDM split mode on my environment. But I could confirm/test full BUSIF support. These patches are for it. Dragos Tarcatu (3): ASoC: rsnd: add support for 16/24 bit slot widths ASoC: rsnd: add support for the DSP_A/DSP_B formats ASoC: rsnd: add support for 8 bit S8 format Jiada Wang (9): ASoC: rsnd: add warning message to rsnd_kctrl_accept_runtime() ASoC: rsnd: remove is_play parameter from hw_rule function ASoC: rsnd: ssi: Fix issue in dma data address assignment ASoC: rsnd: ssi: Check runtime channel number rather than hw_params ASoc: rsnd: dma: Calculate dma address with consider of BUSIF ASoc: rsnd: dma: Calculate PDMACHCRE with consider of BUSIF ASoC: rsnd: ssiu: Support BUSIF other than BUSIF0 ASoC: rsnd: ssiu: Support to init different BUSIF instance ASoC: rsnd: fixup not to call clk_get/set under non-atomic Kuninori Morimoto (1): ASoC: rsnd: merge .nolock_start and .prepare sound/soc/sh/rcar/core.c | 135 +++++++++++++++++++++++++---------------------- sound/soc/sh/rcar/dma.c | 100 ++++++++++++++++++++++------------- sound/soc/sh/rcar/gen.c | 27 ++++++++-- sound/soc/sh/rcar/rsnd.h | 64 ++++++++++++++++------ sound/soc/sh/rcar/ssi.c | 105 ++++++++++++++++++++++-------------- sound/soc/sh/rcar/ssiu.c | 92 +++++++++++++++++++++++++++----- 6 files changed, 349 insertions(+), 174 deletions(-) -- 2.7.4

2 28

[alsa-devel] [PATCH] ALSA: HDA: Fix several mismatch for register mask and value
by Keyon Jie 03 Sep '18

03 Sep '18

E.g. for snd_hdac_ext_link_clear_stream_id(), we should set (1 << stream) as mask, and 0 as value, here correct it and several similar mismatches. And, here also remove unreadable register_mask usage for those mask value updating. Signed-off-by: Keyon Jie <yang.jie(a)linux.intel.com> --- sound/hda/ext/hdac_ext_stream.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c index 1bd27576db98..a835558ddbc9 100644 --- a/sound/hda/ext/hdac_ext_stream.c +++ b/sound/hda/ext/hdac_ext_stream.c @@ -146,7 +146,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_decouple); */ void snd_hdac_ext_link_stream_start(struct hdac_ext_stream *stream) { - snd_hdac_updatel(stream->pplc_addr, AZX_REG_PPLCCTL, 0, AZX_PPLCCTL_RUN); + snd_hdac_updatel(stream->pplc_addr, AZX_REG_PPLCCTL, + AZX_PPLCCTL_RUN, AZX_PPLCCTL_RUN); } EXPORT_SYMBOL_GPL(snd_hdac_ext_link_stream_start); @@ -171,7 +172,8 @@ void snd_hdac_ext_link_stream_reset(struct hdac_ext_stream *stream) snd_hdac_ext_link_stream_clear(stream); - snd_hdac_updatel(stream->pplc_addr, AZX_REG_PPLCCTL, 0, AZX_PPLCCTL_STRST); + snd_hdac_updatel(stream->pplc_addr, AZX_REG_PPLCCTL, + AZX_PPLCCTL_STRST, AZX_PPLCCTL_STRST); udelay(3); timeout = 50; do { @@ -242,7 +244,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_link_set_stream_id); void snd_hdac_ext_link_clear_stream_id(struct hdac_ext_link *link, int stream) { - snd_hdac_updatew(link->ml_addr, AZX_REG_ML_LOSIDV, 0, (1 << stream)); + snd_hdac_updatew(link->ml_addr, AZX_REG_ML_LOSIDV, (1 << stream), 0); } EXPORT_SYMBOL_GPL(snd_hdac_ext_link_clear_stream_id); @@ -415,7 +417,6 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_bus *bus, bool enable, int index) { u32 mask = 0; - u32 register_mask = 0; if (!bus->spbcap) { dev_err(bus->dev, "Address of SPB capability is NULL\n"); @@ -424,12 +425,8 @@ void snd_hdac_ext_stream_spbcap_enable(struct hdac_bus *bus, mask |= (1 << index); - register_mask = readl(bus->spbcap + AZX_REG_SPB_SPBFCCTL); - - mask |= register_mask; - if (enable) - snd_hdac_updatel(bus->spbcap, AZX_REG_SPB_SPBFCCTL, 0, mask); + snd_hdac_updatel(bus->spbcap, AZX_REG_SPB_SPBFCCTL, mask, mask); else snd_hdac_updatel(bus->spbcap, AZX_REG_SPB_SPBFCCTL, mask, 0); } @@ -503,7 +500,6 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_bus *bus, bool enable, int index) { u32 mask = 0; - u32 register_mask = 0; if (!bus->drsmcap) { dev_err(bus->dev, "Address of DRSM capability is NULL\n"); @@ -512,12 +508,8 @@ void snd_hdac_ext_stream_drsm_enable(struct hdac_bus *bus, mask |= (1 << index); - register_mask = readl(bus->drsmcap + AZX_REG_SPB_SPBFCCTL); - - mask |= register_mask; - if (enable) - snd_hdac_updatel(bus->drsmcap, AZX_REG_DRSM_CTL, 0, mask); + snd_hdac_updatel(bus->drsmcap, AZX_REG_DRSM_CTL, mask, mask); else snd_hdac_updatel(bus->drsmcap, AZX_REG_DRSM_CTL, mask, 0); } -- 2.14.1

2 1

[alsa-devel] [PATCH v2] sound: Convert to using %pOFn instead of device_node.name
by Rob Herring 03 Sep '18

03 Sep '18

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Johannes Berg <johannes(a)sipsolutions.net> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: linuxppc-dev(a)lists.ozlabs.org Cc: alsa-devel(a)alsa-project.org Signed-off-by: Rob Herring <robh(a)kernel.org> --- v2: - Fix error in strncmp sound/aoa/soundbus/i2sbus/core.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c index 000b58522106..bd7c5029fc59 100644 --- a/sound/aoa/soundbus/i2sbus/core.c +++ b/sound/aoa/soundbus/i2sbus/core.c @@ -157,18 +157,19 @@ static int i2sbus_add_dev(struct macio_dev *macio, struct device_node *child = NULL, *sound = NULL; struct resource *r; int i, layout = 0, rlen, ok = force; - static const char *rnames[] = { "i2sbus: %s (control)", - "i2sbus: %s (tx)", - "i2sbus: %s (rx)" }; + char node_name[6]; + static const char *rnames[] = { "i2sbus: %pOFn (control)", + "i2sbus: %pOFn (tx)", + "i2sbus: %pOFn (rx)" }; static irq_handler_t ints[] = { i2sbus_bus_intr, i2sbus_tx_intr, i2sbus_rx_intr }; - if (strlen(np->name) != 5) + if (snprintf(node_name, sizeof(node_name), "%pOFn", np) != 5) return 0; - if (strncmp(np->name, "i2s-", 4)) + if (strncmp(node_name, "i2s-", 4)) return 0; dev = kzalloc(sizeof(struct i2sbus_dev), GFP_KERNEL); @@ -228,13 +229,13 @@ static int i2sbus_add_dev(struct macio_dev *macio, dev->sound.pcmid = -1; dev->macio = macio; dev->control = control; - dev->bus_number = np->name[4] - 'a'; + dev->bus_number = node_name[4] - 'a'; INIT_LIST_HEAD(&dev->sound.codec_list); for (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++) { dev->interrupts[i] = -1; snprintf(dev->rnames[i], sizeof(dev->rnames[i]), - rnames[i], np->name); + rnames[i], np); } for (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++) { int irq = irq_of_parse_and_map(np, i); -- 2.17.1

2 1

[alsa-devel] KMSAN: uninit-value in snd_midi_event_encode_byte
by syzbot 03 Sep '18

03 Sep '18

Hello, syzbot found the following crash on: HEAD commit: 2dca2cbde67a kmsan: fix build warnings with CONFIG_KMSAN=n git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=1660ef6a400000 kernel config: https://syzkaller.appspot.com/x/.config?x=820d6393634b55e3 dashboard link: https://syzkaller.appspot.com/bug?extid=194dffdb8b22fc5d207a compiler: clang version 8.0.0 (trunk 339414) Unfortunately, I don't have any reproducer for this crash yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+194dffdb8b22fc5d207a(a)syzkaller.appspotmail.com ================================================================== BUG: KMSAN: uninit-value in snd_midi_event_encode_byte+0x569/0xff0 sound/core/seq/seq_midi_event.c:195 CPU: 0 PID: 1623 Comm: kworker/0:1H Not tainted 4.19.0-rc1+ #36 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: events_highpri snd_vmidi_output_work Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x14b/0x190 lib/dump_stack.c:113 kmsan_report+0x183/0x2b0 mm/kmsan/kmsan.c:956 __msan_warning+0x70/0xc0 mm/kmsan/kmsan_instr.c:645 snd_midi_event_encode_byte+0x569/0xff0 sound/core/seq/seq_midi_event.c:195 snd_vmidi_output_work+0x34e/0x5b0 sound/core/seq/seq_virmidi.c:161 process_one_work+0x1605/0x1f40 kernel/workqueue.c:2153 worker_thread+0x11a2/0x2590 kernel/workqueue.c:2296 kthread+0x465/0x4a0 kernel/kthread.c:247 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:416 Uninit was stored to memory at: kmsan_save_stack_with_flags mm/kmsan/kmsan.c:256 [inline] kmsan_save_stack mm/kmsan/kmsan.c:271 [inline] kmsan_internal_chain_origin+0x128/0x210 mm/kmsan/kmsan.c:573 __msan_chain_origin+0x69/0xc0 mm/kmsan/kmsan_instr.c:482 __snd_rawmidi_transmit_peek sound/core/rawmidi.c:1103 [inline] snd_rawmidi_transmit+0xa75/0xbf0 sound/core/rawmidi.c:1228 snd_vmidi_output_work+0x2ac/0x5b0 sound/core/seq/seq_virmidi.c:159 process_one_work+0x1605/0x1f40 kernel/workqueue.c:2153 worker_thread+0x11a2/0x2590 kernel/workqueue.c:2296 kthread+0x465/0x4a0 kernel/kthread.c:247 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:416 Uninit was created at: kmsan_save_stack_with_flags mm/kmsan/kmsan.c:256 [inline] kmsan_internal_poison_shadow+0xb8/0x1b0 mm/kmsan/kmsan.c:181 kmsan_kmalloc+0x98/0x100 mm/kmsan/kmsan_hooks.c:91 __kmalloc_node+0x7bf/0x11c0 mm/slub.c:3828 kmalloc_node include/linux/slab.h:555 [inline] kvmalloc_node+0x19d/0x3e0 mm/util.c:423 kvmalloc include/linux/mm.h:577 [inline] snd_rawmidi_runtime_create sound/core/rawmidi.c:132 [inline] open_substream+0x3c8/0xaa0 sound/core/rawmidi.c:276 rawmidi_open_priv+0x347/0x1000 sound/core/rawmidi.c:327 snd_rawmidi_open+0x7d4/0x1120 sound/core/rawmidi.c:424 soundcore_open+0x9be/0xa60 sound/sound_core.c:597 chrdev_open+0xc26/0xdb0 fs/char_dev.c:417 do_dentry_open+0xc9d/0x1660 fs/open.c:771 vfs_open+0xaf/0xe0 fs/open.c:880 do_last fs/namei.c:3418 [inline] path_openat+0x17a6/0x67c0 fs/namei.c:3534 do_filp_open+0x259/0x610 fs/namei.c:3564 do_sys_open+0x630/0x940 fs/open.c:1063 __do_sys_open fs/open.c:1081 [inline] __se_sys_open fs/open.c:1076 [inline] __x64_sys_open+0xf2/0x130 fs/open.c:1076 do_syscall_64+0x15b/0x220 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x63/0xe7 ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot.

3 16

[alsa-devel] Microphone detected, but no output for all ASUS G751xx with ALC668 chipset
by Håvard 03 Sep '18

03 Sep '18

Have tried enabling all GPIO settings as well as tried every possible pin combination I could think of. This problem has persisted for almost 4-years with no fix or patch to speak of. Would be great if someone finally had a look at it! -Håvard

1 0

[alsa-devel] [PATCH] ASoC: core: Don't schedule DAPM work if already in target state
by Jon Hunter 03 Sep '18

03 Sep '18

When dapm_power_widgets() is called, the dapm_pre_sequence_async() and dapm_post_sequence_async() functions are scheduled for all DAPM contexts (apart from the card DAPM context) regardless of whether the DAPM context is already in the desired state. The overhead of this is not insignificant and the more DAPM contexts there are the more overhead there is. For example, on the Tegra124 Jetson TK1, when profiling the time taken to execute the dapm_power_widgets() the following times were observed. Times for function dapm_power_widgets() are (us): Min 23, Ave 190, Max 434, Count 39 Here 'Count' is the number of times that dapm_power_widgets() has been called. Please note that the above time were measured using ktime_get() to log the time on entry and exit from dapm_power_widgets(). So it should be noted that these times may not be purely the time take to execute this function if it is preempted. However, after applying this patch and measuring the time taken to execute dapm_power_widgets() again a significant improvement is seen as shown below. Times for function dapm_power_widgets() are (us): Min 4, Ave 16, Max 82, Count 39 Therefore, optimise the dapm_power_widgets() function by only scheduling the dapm_pre/post_sequence_async() work if the DAPM context is not in the desired state. Signed-off-by: Jon Hunter <jonathanh(a)nvidia.com> --- sound/soc/soc-dapm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 461d951917c0..2e9231aeabb9 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -1953,7 +1953,7 @@ static int dapm_power_widgets(struct snd_soc_card *card, int event) dapm_pre_sequence_async(&card->dapm, 0); /* Run other bias changes in parallel */ list_for_each_entry(d, &card->dapm_list, list) { - if (d != &card->dapm) + if (d != &card->dapm && d->bias_level != d->target_bias_level) async_schedule_domain(dapm_pre_sequence_async, d, &async_domain); } @@ -1977,7 +1977,7 @@ static int dapm_power_widgets(struct snd_soc_card *card, int event) /* Run all the bias changes in parallel */ list_for_each_entry(d, &card->dapm_list, list) { - if (d != &card->dapm) + if (d != &card->dapm && d->bias_level != d->target_bias_level) async_schedule_domain(dapm_post_sequence_async, d, &async_domain); } -- 2.7.4

3 3

[alsa-devel] [PATCH] ASoC: q6routing: initialize data correctly
by Srinivas Kandagatla 03 Sep '18

03 Sep '18

Some of the router data fields are left as default zeros which are valid dai ids, so initialize these to invalid value of -1. Without intializing these correctly get_session_from_id() can return incorrect session resulting in not closing the opened copp and messing up with the copp ref count. Fixes: e3a33673e845 ("ASoC: qdsp6: q6routing: Add q6routing driver") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- sound/soc/qcom/qdsp6/q6routing.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index dc94c5c53788..c6b51571be94 100644 --- a/sound/soc/qcom/qdsp6/q6routing.c +++ b/sound/soc/qcom/qdsp6/q6routing.c @@ -960,8 +960,10 @@ static int msm_routing_probe(struct snd_soc_component *c) { int i; - for (i = 0; i < MAX_SESSIONS; i++) + for (i = 0; i < MAX_SESSIONS; i++) { routing_data->sessions[i].port_id = -1; + routing_data->sessions[i].fedai_id = -1; + } return 0; } -- 2.18.0

2 1

[alsa-devel] [PATCH] sound: soc: fix soc-core.c kernel-doc warning
by Randy Dunlap 03 Sep '18

03 Sep '18

From: Randy Dunlap <rdunlap(a)infradead.org> Fix kernel-doc warning: ../sound/soc/soc-core.c:2918: warning: Excess function parameter 'legacy_dai_naming' description in 'snd_soc_register_dais' Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> --- sound/soc/soc-core.c | 2 -- 1 file changed, 2 deletions(-) --- lnx-419-rc2.orig/sound/soc/soc-core.c +++ lnx-419-rc2/sound/soc/soc-core.c @@ -2910,8 +2910,6 @@ static struct snd_soc_dai *soc_add_dai(s * @component: The component the DAIs are registered for * @dai_drv: DAI driver to use for the DAIs * @count: Number of DAIs - * @legacy_dai_naming: Use the legacy naming scheme and let the DAI inherit the - * parent's name. */ static int snd_soc_register_dais(struct snd_soc_component *component, struct snd_soc_dai_driver *dai_drv, size_t count)

2 2