August 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] ALSA queries
by Chakravarthi Pradeep 03 Aug '18

03 Aug '18

I'm working on ALSA driver for PCIe card. My ALSA driver and it's initializing struct snd_pcm_hardware with below parameter. /************************ code start ************************************************/ static struct snd_pcm_hardware audio_pcm_hardware = { .info = (SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_RESUME ), .formats = (SNDRV_PCM_FORMAT_S16_LE | SNDRV_PCM_FORMAT_S24_LE), .rates = (SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_192000), .rate_min = 44100, .rate_max = 192000, .channels_min = 2, .channels_max = 8, .buffer_bytes_max = 76800, /*75 kbytes */ .period_bytes_min = 512,//4410, /* (channel (2) * sample_rate (44100) * bit width (24)) / (60 * 8) */ .period_bytes_max = 16*1024, .periods_min = 10, .periods_max = 255, }; /************************ code end ************************************************/ 1) I did not understand what is significance of periods_min , period_bytes_min , period_bytes_max and periods_max. Can you please tell me what is importance of these parameter and what value should be mentioned according into ALSA. 2) snd_pcm_ops trigger callback is getting called in the driver when application sends "start" command. But ALSA driver is stopping by itself after one frame is copied to ALSA framework, without waiting for "stop" command. For instance: In trigger callback , I'm getting these logs after one frame is copied. Trigger:Start (When Play button is selected/clicked in application, Start command is sent to ALSA driver) Dma transfer is completed. Trigger:Stop. (When Stop button is selected/clicked in application, Stop command is sent to ALSA driver. But stop button is not clicked in this case) Thanks in advance. -- Thanks and Regards Chakravarthi Pradeep.K Ph: 91 9980434900

2 2

[alsa-devel] bug report. Envy24 based card (terratec ews88d) won't slave to external clock via s/pdif.
by Tobias Eklund 03 Aug '18

03 Aug '18

Hi, when trying to clock my terratec ews88d from an apogee rosetta AD it just won't. The s/pdif input works but the card won't lock to the s/pdif clock but rather stay at whatever setting it was at before i change to s/pdif in envy24control or mudita24. Since I have another converter slaved via ADAT out I can tell what sample rate is being output via ADAT sync. Works perfectly for setting the sample rate in envy24control but not when i choose external clock and change the rate on the Apogee AD. Also, audio recorded through the s/pdif input is obviously at the wrong rate when changing the rate on the Apogee AD. I found this old discussion which seems to describe the same problem: http://alsa-devel.alsa-project.narkive.com/30mvygRD/m-audio-delta-1010lt-s-… Also, there is a problem with the alsa-info.sh script, it didn't give me url to share. Just the message Your ALSA information is located at Please inform the person helping you. If the alsa-info.sh output is required i'll post it in an e-mail. kind regards, -- Tobias Eklund Fatburs Brunnsgata 31 118 28 Stockholm 0046 707570196

2 1

[alsa-devel] [PATCH] ALSA: usb-audio: Fix wrong sizeof argument
by Gustavo A. R. Silva 02 Aug '18

02 Aug '18

The correct argument to be passed to kzalloc is sizeof(*pd) Addresses-Coverity-ID: 1472224 ("Wrong sizeof argument") Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 8fe3b0e..67cf849 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1037,7 +1037,7 @@ snd_usb_get_audioformat_uac3(struct snd_usb_audio *chip, fp->rate_max = UAC3_BADD_SAMPLING_RATE; fp->rates = SNDRV_PCM_RATE_CONTINUOUS; - pd = kzalloc(sizeof(pd), GFP_KERNEL); + pd = kzalloc(sizeof(*pd), GFP_KERNEL); if (!pd) { kfree(fp->rate_table); kfree(fp); -- 2.7.4

2 2

[alsa-devel] [PATCH 0/3] ASoC: core: remove support for card rebind using component framework
by Srinivas Kandagatla 02 Aug '18

02 Aug '18

DRM based audio components get registered inside the component framework bind callback. However component framework has a big mutex lock taken for every call to component_add, component_del and bind, unbind callbacks. This can lead to deadlock situation if we are trying to add new/remove component within a bind/unbind callbacks. Which is what was happening with bcm2837 rpi 3. Revert this change till we sort out the mutex issue. Thanks, srini Srinivas Kandagatla (3): ASoC: apq8096: remove auto rebinding ASoC: smd845: remove auto rebinding ASoC: core: remove support for card rebind using component framework include/sound/soc.h | 7 ------ sound/soc/qcom/apq8096.c | 2 -- sound/soc/qcom/sdm845.c | 2 -- sound/soc/soc-core.c | 62 ------------------------------------------------ 4 files changed, 73 deletions(-) -- 2.16.2

2 6

[alsa-devel] [PATCH v3 0/4] arm64: dts: rockchip: add basic dts file for PX30 SoCs
by cl＠rock-chips.com 02 Aug '18

02 Aug '18

From: Liang Chen <cl(a)rock-chips.com> Changes in v3: 1. backlight: remove properties <brightness-levels>,<num-interpolated-steps>, <default-brightness-level>, as the driver will compute a default table. Changes in V2: 1. change the subject to format "dt-bindings: module: ..." for the documents. 2. use new property <num-interpolated-steps> for backlight. 3. remove pinctrl of rk809, because the driver is not ready. Liang Chen (4): dt-bindings: usb: dwc2: add description for px30 dt-bindings: rockchip: grf: add grf and pmugrf description for px30 arm64: dts: rockchip: add core dtsi file for PX30 SoCs arm64: dts: rockchip: add PX30 eavluation board devicetree Documentation/devicetree/bindings/arm/rockchip.txt | 4 + .../devicetree/bindings/soc/rockchip/grf.txt | 2 + Documentation/devicetree/bindings/usb/dwc2.txt | 1 + arch/arm64/boot/dts/rockchip/Makefile | 1 + arch/arm64/boot/dts/rockchip/px30-evb.dts | 470 +++++ arch/arm64/boot/dts/rockchip/px30.dtsi | 2043 ++++++++++++++++++++ 6 files changed, 2521 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/px30-evb.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30.dtsi -- 1.9.1

2 8

[alsa-devel] [PATCH] ALSA: hda: Correct Asrock B85M-ITX power_save blacklist entry
by Hans de Goede 02 Aug '18

02 Aug '18

I added the subsys product-id for the HDMI HDA device rather then for the PCH one, this commit fixes this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104 Cc: stable(a)vger.kernel.org Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/pci/hda/hda_intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 1ae1850b3bfd..647ae1a71e10 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2207,7 +2207,7 @@ static int azx_probe(struct pci_dev *pci, */ static struct snd_pci_quirk power_save_blacklist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ - SND_PCI_QUIRK(0x1849, 0x0c0c, "Asrock B85M-ITX", 0), + SND_PCI_QUIRK(0x1849, 0xc892, "Asrock B85M-ITX", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1849, 0x7662, "Asrock H81M-HDS", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ -- 2.18.0

2 1

Re: [alsa-devel] A bug about cache inconsistency report
by Hans Hu(SH-RD) 02 Aug '18

02 Aug '18

1. noise relate test: 8086:1C20 noise ; 8086:A170 ok; 8086:8D20 ok; Seems this issue related to the HDA Card version 2. change *_SG relate test: Both above platform report Oops Thanks Hans -----邮件原件----- 发件人: Takashi Iwai [mailto:tiwai@suse.de] 发送时间: 01 August 2018 12:45 收件人: Hans Hu(SH-RD) <HansHu(a)zhaoxin.com> 抄送: 'alsa-devel(a)alsa-project.org' <alsa-devel(a)alsa-project.org> 主题: Re: [alsa-devel] A bug about cache inconsistency report On Wed, 01 Aug 2018 04:05:18 +0200, Hans Hu(SH-RD) wrote: > > I did more test base on different Intel platform, and result is the same. Which platform did you test exactly? > Maybe I made some mistake? Can you do the test in yours platform? The negative test result implies that the analysis isn't right. Actually I haven't seen that problem on my test machines. BTW, please avoid top-posting. thanks, Takashi > > Thank you! > Hans > > -----邮件原件----- > 发件人: Takashi Iwai [mailto:tiwai@suse.de] > 发送时间: 31 July 2018 21:55 > 收件人: Hans Hu(SH-RD) <HansHu(a)zhaoxin.com> > 抄送: 'alsa-devel(a)alsa-project.org' <alsa-devel(a)alsa-project.org> > 主题: Re: 答复: [alsa-devel] A bug about cache inconsistency report > > On Tue, 31 Jul 2018 15:51:06 +0200, > Hans Hu(SH-RD) wrote: > > > > I did the test and Oops report when install driver( both snoop and > > non-snoop mode) > > I don't understand. Did my one-liner change the behavior or not? > > > thanks, > > Takashi > > > > > -----邮件原件----- > > 发件人: Takashi Iwai [mailto:tiwai@suse.de] > > 发送时间: 31 July 2018 19:59 > > 收件人: Hans Hu(SH-RD) <HansHu(a)zhaoxin.com> > > 抄送: 'alsa-devel(a)alsa-project.org' <alsa-devel(a)alsa-project.org> > > 主题: Re: [alsa-devel] A bug about cache inconsistency report > > > > On Tue, 31 Jul 2018 12:52:04 +0200, > > Hans Hu(SH-RD) wrote: > > > > > > Hi All, > > > > > > Try send an email. > > > > > > Appearance: > > > when use non-snoop + ioctl path combination, an issue occurs: > > > usage: aplay -D plughw:0,0 44100_S16_LE_2c.wav Ubuntu, it > > > performance intermittently noise; > > > > > > Root case: > > > Function set_pages_array_wc marked the PTE of the original address; Function set_memory_wc marked the PTE both original and after vmaped address. > > > [cid:image002.png@01D428FF.92621520] > > > However, cache or not in transmission process is based on the PTE of the later, and the set_pages_array_wc did't mark it, so a cache inconsistency issue occurs. > > > > > > Related bug: > > > SHA1 ID: 9ddf1aeb2134e72275c97a2c6ff2e3eb04f2f27a > > > > OK, so did you confirm that dropping the SG buffer support "fixes" the noise problem on your system? The easiest test would be like: > > > > --- a/sound/pci/hda/hda_controller.c > > +++ b/sound/pci/hda/hda_controller.c > > @@ -770,7 +770,7 @@ int snd_hda_attach_pcm_stream(struct hda_bus > > *_bus, struct hda_codec *codec, size = CONFIG_SND_HDA_PREALLOC_SIZE > > * 1024; if (size > MAX_PREALLOC_SIZE) size = MAX_PREALLOC_SIZE; > > -snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV_SG, > > +snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, > > chip->card->dev, > > size, MAX_PREALLOC_SIZE); > > return 0; > > > > > > thanks, > > > > Takashi > > > > > > 保密声明： > > 本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。 > > CONFIDENTIAL NOTE: > > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. > > > 保密声明： > 本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。 > CONFIDENTIAL NOTE: > This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. 保密声明：本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。 CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.

2 3

[alsa-devel] [PATCH] ASoC: qcom: Fix unmet dependency warning for SND_SOC_SDM845
by Rohit kumar 02 Aug '18

02 Aug '18

Add DEPENDS_ON QCOM_APR for SND_SOC_SDM845 to fix the warning: unmet direct dependencies detected for SND_SOC_QDSP6. Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> --- sound/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 3507308..5f03312 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -93,6 +93,7 @@ config SND_SOC_MSM8996 config SND_SOC_SDM845 tristate "SoC Machine driver for SDM845 boards" + depends on QCOM_APR select SND_SOC_QDSP6 help To add support for audio on Qualcomm Technologies Inc. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

2 1

[alsa-devel] [PATCH] ASoC: fsi: convert to SPDX identifiers
by Kuninori Morimoto 02 Aug '18

02 Aug '18

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- include/sound/sh_fsi.h | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/include/sound/sh_fsi.h b/include/sound/sh_fsi.h index 7a9710b..89eafe2 100644 --- a/include/sound/sh_fsi.h +++ b/include/sound/sh_fsi.h @@ -1,16 +1,13 @@ -#ifndef __SOUND_FSI_H -#define __SOUND_FSI_H - -/* +/* SPDX-License-Identifier: GPL-2.0 + * * Fifo-attached Serial Interface (FSI) support for SH7724 * * Copyright (C) 2009 Renesas Solutions Corp. * Kuninori Morimoto <morimoto.kuninori(a)renesas.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. */ +#ifndef __SOUND_FSI_H +#define __SOUND_FSI_H + #include <linux/clk.h> #include <sound/soc.h> -- 2.7.4

2 1

[alsa-devel] [PATCH] ALSA: sb: Fix a typo
by Takashi Iwai 02 Aug '18

02 Aug '18

There was a typo of COPY_USER in the dead code (that is disabled as default). Fixes: 4b83eff81c81 ("ALSA: sb: Convert to the new PCM ops") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/isa/sb/emu8000_pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c index bc5af71d3bdb..f46f6ec3ea0c 100644 --- a/sound/isa/sb/emu8000_pcm.c +++ b/sound/isa/sb/emu8000_pcm.c @@ -470,7 +470,7 @@ static int emu8k_pcm_copy(struct snd_pcm_substream *subs, /* convert to word unit */ pos = (pos << 1) + rec->loop_start[voice]; count <<= 1; - LOOP_WRITE(rec, pos, src, count, COPY_UESR); + LOOP_WRITE(rec, pos, src, count, COPY_USER); return 0; } -- 2.18.0

1 0