August 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda/realtek - Add mute LED quirk for HP Spectre x360
by Alexandru Gagniuc 05 Aug '18

05 Aug '18

This device has the same issues as the HP x360 wrt the MUTE LED and the front speakers not working. This patch fixes the MUTE LED issue, but doesn't touch the HDA verbs. The fix for the x360 does not work on the Spectre. Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f6af3e1c2b93..d14b05f68d6d 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6530,6 +6530,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x827e, "HP x360", ALC295_FIXUP_HP_X360), SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), -- 2.17.1

2 1

[alsa-devel] ALSA driver rmmod
by Chakravarthi Pradeep 05 Aug '18

05 Aug '18

Dear ALSA Team, I have taken reference alsa driver from https://alsa-project.org/main/index.php/Minivosc and driver code path from https://github.com/stadaki/alsa-minivosc-src . If I, do a rmmod of aforesaid driver using below command "rmmod snd-minivosc" Output of the above command is "rmmod: ERROR: Module snd_minivosc is in use" Below is output from lsmod | grep snd-minivosc "snd_minivosc 16384 1 snd_pcm 98304 6 snd_hda_intel,snd_hda_codec,snd_usb_audio,snd_minivosc,snd_hda_core,snd_hda_codec_hdmi snd 81920 26 snd_hda_intel,snd_hwdep,snd_seq,snd_hda_codec,snd_usb_audio,snd_minivosc,snd_timer,snd_rawmidi,snd_hda_codec_hdmi,snd_hda_codec_generic,snd_usbmidi_lib,snd_seq_device,snd_hda_codec_realtek,snd_pcm" Is there is any way to remove alsa driver from kernel without restarting PC? Kindly let me know how to remove alsa driver safely from linux kernel and then reinsert it. Thanks and Regards Chakravarthi Pradeep.K Ph: 91 9980434900

1 0

Re: [alsa-devel] CS8409 Macbook Pro 2016 2017
by Takashi Iwai 04 Aug '18

04 Aug '18

On Sat, 04 Aug 2018 17:44:59 +0200, David Ulricht wrote: > > I used the following script running as root to verify the 8 GPIOs while > playing long youtube video, > I have running pulseaudio meanwhile and not restarting it, i think its okay > like that people on the ubuntu forums say that after using > hda-verb and setting a gpio active immediately sound appears, so i guess > there is no need to restart pulseaudio. > I have done the same test with headphones in. > No sound in both scenarios, no input no output detected (i'm watching > pavucontrol for input detection). This codec is fairly unique and doesn't provide the standard jack detection on each pin. Maybe it's via either GPIO or any other method. You can try to read GPIO pins (set as input) to see whether any of them corresponds to the jack detection, for example. Takashi > > #!/usr/bin/env python3 > import os,time > for x in range(0,256): > mhex=("0x%0.2X" % x) > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK "+mhex) > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION "+mhex) > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA "+mhex) > time.sleep(3) > > Meanwhile script is running I'm watching /proc/asound/card0/codec#0 and > IO[0-7] changes its configuration, > in comparison Joel Krahemann in his scripts is changing the hex right after > /dev/snd/hwC0D0 (0x01) e.g. i dont think he is modifiying the GPIOs > correctly. > > I found the following post: > https://forum.manjaro.org/t/sound-not-working-on-a-2017-imac-27-5k-retina/4… > According to https://bugzilla.kernel.org/show_bug.cgi?id=195671 iMac27 has > a similar soundcard. > How can i setup with command line or any other utility: > """select “off” in the top menu that propose to setup the Digital > Surround""" > this is some setting in xfce4-mixer package which is not available for > ubuntu since 2 LTS versions behind. I tried current Manjaro and couldn't > find this setting in audio mixer of xfce4 either. > > On Sat, Aug 4, 2018 at 9:48 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > On Sat, 04 Aug 2018 04:07:43 +0200, > > David Ulricht wrote: > > > > > > Hello, > > > > > > Macbook pro models containing CS8409 for sure are: > > > MBP131 MBP141.I own MBP 14,1 e.g. 2017 model. > > > > > > I'm attaching working sound configuration from Windows 10 registry (note > > > that the cs420x might need to be ignored or might be important i don't > > > really know). I believe what is really used is in the PinConfigOverride > > > section. > > > > Comparing between BIOS default (init_pin_cfg in alsa-info.sh output) > > and your override (user_pin_cfg), there aren't so many changes. > > All changes are pretty minor, and I guess it won't influence on the > > driver behavior. > > > > > Interesting thing to note is that sound in MacOS is much louder than > > > Bootcamp Windows, would be nice to hear how loud is on linux. > > > > This is possibly with some vendor-specific GPIO or COEF verbs. > > Or it's some direct I2C control. The INI file mentions it. > > And that's above HD-audio driver's responsibility. > > > > > I did convert PinConfigOverride HEX strings to [pincfg] format in the > > > attached hda-jack-retask.fw thanks to Takashi's guidance. > > > > > > I'm attaching also alsamixer ASCII. Only PCM, no Master ? > > > > It's because the codec chip has no output amplifier at all. > > So there can be neither output volume nor mute control on this chip. > > > > > What I have tried is execute: > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x@@ > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x@@ > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x@@ > > > putting @@ from 0x00 to 0x50 > > > > There are eight GPIOs, so you'd need to test each bit, i.e. 0x01, > > 0x02, 0x04, 0x08, ... 0x80. > > > > And how is the current situation? You can't play *and* record > > anything from any inputs / outputs? > > > > > > Takashi > > > [2 <text/html; UTF-8 (quoted-printable)>] >

1 0

[alsa-devel] CS8409 Macbook Pro 2016 2017
by David Ulricht 04 Aug '18

04 Aug '18

Hello, Macbook pro models containing CS8409 for sure are: MBP131 MBP141.I own MBP 14,1 e.g. 2017 model. I'm attaching working sound configuration from Windows 10 registry (note that the cs420x might need to be ignored or might be important i don't really know). I believe what is really used is in the PinConfigOverride section. Interesting thing to note is that sound in MacOS is much louder than Bootcamp Windows, would be nice to hear how loud is on linux. I did convert PinConfigOverride HEX strings to [pincfg] format in the attached hda-jack-retask.fw thanks to Takashi's guidance. I'm attaching also alsamixer ASCII. Only PCM, no Master ? What I have tried is execute: hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x@@ hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x@@ hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x@@ putting @@ from 0x00 to 0x50 Please advise.

2 2

[alsa-devel] [PATCH] ALSA: seq_oss: Mark expected switch fall-through
by Gustavo A. R. Silva 04 Aug '18

04 Aug '18

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 2 was used: -Wimplicit-fallthrough=2 Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/core/seq/oss/seq_oss_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/oss/seq_oss_timer.c b/sound/core/seq/oss/seq_oss_timer.c index 4f24ea9..ba127c2 100644 --- a/sound/core/seq/oss/seq_oss_timer.c +++ b/sound/core/seq/oss/seq_oss_timer.c @@ -92,7 +92,7 @@ snd_seq_oss_process_timer_event(struct seq_oss_timer *rec, union evrec *ev) case TMR_WAIT_REL: parm += rec->cur_tick; rec->realtime = 0; - /* continue to next */ + /* fall through and continue to next */ case TMR_WAIT_ABS: if (parm == 0) { rec->realtime = 1; -- 2.7.4

2 1

[alsa-devel] [PATCH] ALSA: seq: Mark expected switch fall-through
by Gustavo A. R. Silva 04 Aug '18

04 Aug '18

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I replaced the code comment with a proper "fall through" annotation, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/core/seq/seq_midi_emul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/seq_midi_emul.c b/sound/core/seq/seq_midi_emul.c index f9f2133..c1975dd 100644 --- a/sound/core/seq/seq_midi_emul.c +++ b/sound/core/seq/seq_midi_emul.c @@ -318,7 +318,7 @@ do_control(struct snd_midi_op *ops, void *drv, struct snd_midi_channel_set *chse break; case MIDI_CTL_MSB_DATA_ENTRY: chan->control[MIDI_CTL_LSB_DATA_ENTRY] = 0; - /* go through here */ + /* fall through */ case MIDI_CTL_LSB_DATA_ENTRY: if (chan->param_type == SNDRV_MIDI_PARAM_TYPE_REGISTERED) rpn(ops, drv, chan, chset); -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: smd845: fix memory leak
by Gustavo A. R. Silva 03 Aug '18

03 Aug '18

In case memory resources for *card* were allocated, release them before return. Addresses-Coverity-ID: 1472244 ("Resource leak") Fixes: 6b1687bf76ef ("ASoC: qcom: add sdm845 sound card support") Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- NOTE: Notice that there are many places in which the return values of functions snd_soc_dai_set_sysclk() and snd_soc_dai_set_fmt() are not being checked. I wonder if this is intentional. Otherwise, I can send a patch for that. Please, confirm. Thanks! sound/soc/qcom/sdm845.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c index be0cb11..c1adb77 100644 --- a/sound/soc/qcom/sdm845.c +++ b/sound/soc/qcom/sdm845.c @@ -222,8 +222,10 @@ static int sdm845_snd_platform_probe(struct platform_device *pdev) /* Allocate the private data */ data = kzalloc(sizeof(*data), GFP_KERNEL); - if (!data) - return -ENOMEM; + if (!data) { + ret = -ENOMEM; + goto data_alloc_fail; + } card->dev = dev; dev_set_drvdata(dev, card); @@ -248,6 +250,7 @@ static int sdm845_snd_platform_probe(struct platform_device *pdev) kfree(card->dai_link); parse_dt_fail: kfree(data); +data_alloc_fail: kfree(card); return ret; } -- 2.7.4

2 1

[alsa-devel] [PATCH 0/7] ASoC: Mark expected switch fall-throughs
by Gustavo A. R. Silva 03 Aug '18

03 Aug '18

Hi all, In preparation to enabling -Wimplicit-fallthrough, this patchset aims to add some annotations in order to mark switch cases where we are expecting to fall through. Thanks Gustavo A. R. Silva (7): ASoC: davinci-i2s: mark expected switch fall-through ASoC: fsl_esai: Mark expected switch fall-through ASoC: Intel: skl-pcm: Mark expected switch fall-through ASoC: omap-dmic: Mark expected switch fall-throughs ASoC: omap-mcpdm: MArk expected switch fall-throughs ASoC: samsung: i2s: Mark expected switch fall-through ASoC: core: mark expected switch fall-through sound/soc/davinci/davinci-i2s.c | 1 + sound/soc/fsl/fsl_esai.c | 1 + sound/soc/intel/skylake/skl-pcm.c | 1 + sound/soc/omap/omap-dmic.c | 2 ++ sound/soc/omap/omap-mcpdm.c | 4 ++++ sound/soc/samsung/i2s.c | 1 + sound/soc/soc-core.c | 1 + 7 files changed, 11 insertions(+) -- 2.7.4

2 13

[alsa-devel] [PATCH 0/6] ALSA: Remove empty init and exit
by Takashi Iwai 03 Aug '18

03 Aug '18

Hi, here is a patchset of trivial cleanups I noticed while working on the recent sequencer bug. There are a bunch of driver codes that have empty module init and exit entries, and we can remove them gracefully. Takashi === Takashi Iwai (6): ALSA: compress: Remove empty init and exit ALSA: drivers: Remove empty init and exit ALSA: isa: Remove empty init and exit ALSA: i2c: Remove empty init and exit ALSA: pci: Remove empty init and exit ALSA: synth: Remove empty init and exit sound/core/compress_offload.c | 12 ------------ sound/drivers/mpu401/mpu401_uart.c | 16 ---------------- sound/drivers/opl3/opl3_lib.c | 16 ---------------- sound/drivers/opl4/opl4_lib.c | 12 ------------ sound/drivers/vx/vx_core.c | 15 --------------- sound/i2c/cs8427.c | 12 ------------ sound/i2c/i2c.c | 13 ------------- sound/i2c/other/ak4xxx-adda.c | 12 ------------ sound/i2c/tea6330t.c | 16 ---------------- sound/isa/es1688/es1688_lib.c | 16 ---------------- sound/isa/gus/gus_main.c | 16 ---------------- sound/isa/sb/sb16_csp.c | 16 ---------------- sound/isa/sb/sb16_main.c | 16 ---------------- sound/isa/sb/sb8_main.c | 16 ---------------- sound/isa/sb/sb_common.c | 16 ---------------- sound/isa/wss/wss_lib.c | 16 ---------------- sound/pci/ac97/ac97_codec.c | 16 ---------------- sound/pci/ice1712/ak4xxx.c | 12 ------------ sound/synth/emux/emux.c | 17 ----------------- sound/synth/util_mem.c | 16 ---------------- 20 files changed, 297 deletions(-) -- 2.18.0

1 6

[alsa-devel] [PATCH] [ALSA] sound/isa/gus: fix spelling mistake "acumulator" -> "accumulator"
by Colin King 03 Aug '18

03 Aug '18

From: Colin Ian King <colin.king(a)canonical.com> Trivial spelling mistake fix in debug message Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/isa/gus/gus_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/gus/gus_io.c b/sound/isa/gus/gus_io.c index ca79878d8d8c..2fd32ef22c30 100644 --- a/sound/isa/gus/gus_io.c +++ b/sound/isa/gus/gus_io.c @@ -461,7 +461,7 @@ void snd_gf1_print_voice_registers(struct snd_gus_card * gus) printk(KERN_INFO " -%i- GFA1 effect address = 0x%x\n", voice, snd_gf1_i_read_addr(gus, 0x11, ctrl & 4)); printk(KERN_INFO " -%i- GFA1 effect volume = 0x%x\n", voice, snd_gf1_i_read16(gus, 0x16)); printk(KERN_INFO " -%i- GFA1 effect volume final = 0x%x\n", voice, snd_gf1_i_read16(gus, 0x1d)); - printk(KERN_INFO " -%i- GFA1 effect acumulator = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x14)); + printk(KERN_INFO " -%i- GFA1 effect accumulator = 0x%x\n", voice, snd_gf1_i_read8(gus, 0x14)); } if (mode & 0x20) { printk(KERN_INFO " -%i- GFA1 left offset = 0x%x (%i)\n", voice, snd_gf1_i_read16(gus, 0x13), snd_gf1_i_read16(gus, 0x13) >> 4); -- 2.17.1

2 1