July 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] Added support for Encore mDSD USB DAC
by Jeff Crukley 26 Jul '18

26 Jul '18

From: JCruk <jcrukley(a)gmail.com> This patch adds native DSD playback support for the Encore mDSD USB DAC by specifying the vendor and product ID's Signed-off-by: Jeff Crukley <jcrukley(a)gmail.com> --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 02b6cc0..6fbafce 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1373,6 +1373,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, return SNDRV_PCM_FMTBIT_DSD_U32_BE; break; + case USB_ID(0x16d0, 0x09dd): /* Encore mDSD */ case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */ case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */ case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */ -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: AMD: Fix build warning
by Akshu Agrawal 26 Jul '18

26 Jul '18

Fixes sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe': sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] dev_err(&pdev->dev, "Failed to register regulator: %d\n", ret); Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index cd3cf6e..48c1d94 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -365,7 +365,7 @@ static int cz_probe(struct platform_device *pdev) &acp_da7219_cfg); if (IS_ERR(rdev)) { dev_err(&pdev->dev, "Failed to register regulator: %d\n", - ret); + (int)PTR_ERR(rdev); return -EINVAL; } -- 1.9.1

1 0

[alsa-devel] [PATCH 00/14] ALSA: Proper endian notations
by Takashi Iwai 25 Jul '18

25 Jul '18

Hi, this is a patchset for correcting the integer types to the endian-wise ones, as caught by sparse. Just cosmetic fixes for catching future bugs, no functional change by itself. Takashi === Takashi Iwai (14): ALSA: ymfpci: Proper endian notations ALSA: trident: Proper endian notations ALSA: hda: Proper endian notations for BDL pointers ALSA: riptide: Properly endian notations ALSA: mixart: Proper endian notations ALSA: lola: Proper endian notations ALSA: intel8x0: Proper endian notations ALSA: intel8x0m: Proper endian notations ALSA: maestro3: Proper endian notations ALSA: echoaudio: Proper endian notations ALSA: bt87x: Proper endian notations ALSA: atiixp: Proper endian notations ALSA: atiixp_modem: Proper endian notations ALSA: sb: Proper endian notations sound/hda/hdac_stream.c | 4 +- sound/isa/sb/sb16_csp.c | 30 +++++------ sound/pci/atiixp.c | 4 +- sound/pci/atiixp_modem.c | 4 +- sound/pci/bt87x.c | 4 +- sound/pci/echoaudio/echoaudio.h | 2 +- sound/pci/echoaudio/echoaudio_3g.c | 14 +++--- sound/pci/echoaudio/echoaudio_dsp.c | 6 +-- sound/pci/echoaudio/echoaudio_dsp.h | 50 +++++++++--------- sound/pci/echoaudio/echoaudio_gml.c | 8 +-- sound/pci/intel8x0.c | 6 +-- sound/pci/intel8x0m.c | 6 +-- sound/pci/lola/lola.c | 4 +- sound/pci/lola/lola.h | 4 +- sound/pci/lola/lola_pcm.c | 8 +-- sound/pci/maestro3.c | 6 +-- sound/pci/mixart/mixart_core.c | 4 +- sound/pci/mixart/mixart_hwdep.c | 42 ++++++++-------- sound/pci/mixart/mixart_hwdep.h | 8 +-- sound/pci/riptide/riptide.c | 8 +-- sound/pci/trident/trident.h | 2 +- sound/pci/trident/trident_main.c | 2 +- sound/pci/ymfpci/ymfpci.h | 78 ++++++++++++++--------------- sound/pci/ymfpci/ymfpci_main.c | 6 +-- 24 files changed, 157 insertions(+), 153 deletions(-) -- 2.18.0

1 14

[alsa-devel] [PATCH 00/10] ALSA: yet more PCM format type conversion fixes
by Takashi Iwai 25 Jul '18

25 Jul '18

Hi, this is a series of similar fixes as the previous patchset for ASoC, covering other ALSA drivers to deal with PCM format type properly. Takashi === Takashi Iwai (10): ALSA: hda: Fix implicit PCM format type conversion ALSA: riptide: Fix PCM format type conversion ALSA: pcm: Fix sparse warning wrt PCM format type ALSA: ad1816a: Fix sparse warning wrt PCM format type ALSA: au88x0: Fix sparse warning wrt PCM format type ALSA: asihpi: Fix PCM format notations ALSA: wss: Fix sparse warning wrt PCM format type ALSA: sb: Fix PCM format bit calculation ALSA: sb: Fix sparse warning wrt PCM format type ALSA: xen: Use standard pcm_format_to_bits() for ALSA format bits include/sound/hdaudio.h | 3 ++- include/sound/sb16_csp.h | 2 +- sound/core/oss/pcm_oss.c | 2 +- sound/hda/hdac_device.c | 2 +- sound/isa/ad1816a/ad1816a_lib.c | 3 ++- sound/isa/sb/sb16_csp.c | 6 +++--- sound/isa/sb/sb16_main.c | 9 ++++++--- sound/isa/wss/wss_lib.c | 2 +- sound/pci/asihpi/asihpi.c | 24 +++++++++++++----------- sound/pci/au88x0/au88x0.h | 2 +- sound/pci/au88x0/au88x0_core.c | 2 +- sound/pci/riptide/riptide.c | 2 +- sound/xen/xen_snd_front_alsa.c | 4 ++-- 13 files changed, 35 insertions(+), 28 deletions(-) -- 2.18.0

1 10

[alsa-devel] [PATCH 00/12] Fixes for sparse warnings and other misc bugs
by Takashi Iwai 25 Jul '18

25 Jul '18

Hi, this is a series of patches to correct bugs spotted by sparse and manual lookups, applied in a wide range of drivers. Takashi === Takashi Iwai (12): ALSA: usb-audio: Fix multiple definitions in AU0828_DEVICE() macro ALSA: msnd: Add missing __iomem annotations ALSA: msnd: Fix the default sample sizes ALSA: hda/ca0132 - Use NULL instead of 0 ALSA: msnd: Use NULL instead of 0 ALSA: hda - Fix a sparse warning about snd_ctl_elem_iface_t ALSA: opl3: Declare common variables properly ALSA: usb-audio: Declare the common variable in header file ALSA: pcm: Add __force to cast in snd_pcm_lib_read/write() ALSA: pcm: Use standard lower_32_bits() and upper_32_bits() ALSA: korg1212: Add __force annotation to cast in user-copy callbacks ALSA: emu10k1: Fix missing __force annotation for user/kernel pointer cast include/sound/pcm.h | 4 ++-- sound/core/oss/pcm_plugin.c | 8 ++++---- sound/drivers/opl3/opl3_drums.c | 2 -- sound/drivers/opl3/opl3_lib.c | 3 +-- sound/drivers/opl3/opl3_midi.c | 4 ---- sound/drivers/opl3/opl3_oss.c | 2 -- sound/drivers/opl3/opl3_synth.c | 1 + sound/drivers/opl3/opl3_voice.h | 4 ++++ sound/isa/msnd/msnd.c | 18 +++++++++--------- sound/isa/msnd/msnd.h | 2 +- sound/isa/msnd/msnd_midi.c | 2 +- sound/isa/msnd/msnd_pinnacle.c | 8 ++++---- sound/pci/emu10k1/emufx.c | 24 ++++++++++++------------ sound/pci/hda/hda_codec.c | 4 ++-- sound/pci/hda/patch_ca0132.c | 3 +-- sound/pci/korg1212/korg1212.c | 4 ++-- sound/usb/mixer.h | 2 ++ sound/usb/mixer_quirks.c | 2 -- sound/usb/quirks-table.h | 3 ++- 19 files changed, 48 insertions(+), 52 deletions(-) -- 2.18.0

1 12

[alsa-devel] [PATCH 1/3] ALSA: vx222: Fix invalid endian conversions
by Takashi Iwai 25 Jul '18

25 Jul '18

The endian conversions used in vx2_dma_read() and vx2_dma_write() are superfluous and even wrong on big-endian machines, as inl() and outl() already do conversions. Kill them. Spotted by sparse, a warning like: sound/pci/vx222/vx222_ops.c:278:30: warning: incorrect type in argument 1 (different base types) Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/vx222/vx222_ops.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/pci/vx222/vx222_ops.c b/sound/pci/vx222/vx222_ops.c index d4298af6d3ee..c0d0bf44f365 100644 --- a/sound/pci/vx222/vx222_ops.c +++ b/sound/pci/vx222/vx222_ops.c @@ -275,7 +275,7 @@ static void vx2_dma_write(struct vx_core *chip, struct snd_pcm_runtime *runtime, length >>= 2; /* in 32bit words */ /* Transfer using pseudo-dma. */ for (; length > 0; length--) { - outl(cpu_to_le32(*addr), port); + outl(*addr, port); addr++; } addr = (u32 *)runtime->dma_area; @@ -285,7 +285,7 @@ static void vx2_dma_write(struct vx_core *chip, struct snd_pcm_runtime *runtime, count >>= 2; /* in 32bit words */ /* Transfer using pseudo-dma. */ for (; count > 0; count--) { - outl(cpu_to_le32(*addr), port); + outl(*addr, port); addr++; } @@ -313,7 +313,7 @@ static void vx2_dma_read(struct vx_core *chip, struct snd_pcm_runtime *runtime, length >>= 2; /* in 32bit words */ /* Transfer using pseudo-dma. */ for (; length > 0; length--) - *addr++ = le32_to_cpu(inl(port)); + *addr++ = inl(port); addr = (u32 *)runtime->dma_area; pipe->hw_ptr = 0; } @@ -321,7 +321,7 @@ static void vx2_dma_read(struct vx_core *chip, struct snd_pcm_runtime *runtime, count >>= 2; /* in 32bit words */ /* Transfer using pseudo-dma. */ for (; count > 0; count--) - *addr++ = le32_to_cpu(inl(port)); + *addr++ = inl(port); vx2_release_pseudo_dma(chip); } -- 2.18.0

1 2

[alsa-devel] [PATCH] ALSA: seq: Fix poll() error return
by Takashi Iwai 25 Jul '18

25 Jul '18

The sanity checks in ALSA sequencer and OSS sequencer emulation codes return falsely -ENXIO from poll callback. They should be EPOLLERR instead. This was caught thanks to the recent change to the return value. Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/oss/seq_oss.c | 2 +- sound/core/seq/seq_clientmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/seq/oss/seq_oss.c b/sound/core/seq/oss/seq_oss.c index 5f64d0d88320..e1f44fc86885 100644 --- a/sound/core/seq/oss/seq_oss.c +++ b/sound/core/seq/oss/seq_oss.c @@ -203,7 +203,7 @@ odev_poll(struct file *file, poll_table * wait) struct seq_oss_devinfo *dp; dp = file->private_data; if (snd_BUG_ON(!dp)) - return -ENXIO; + return EPOLLERR; return snd_seq_oss_poll(dp, file, wait); } diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 56ca78423040..6fd4b074b206 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -1101,7 +1101,7 @@ static __poll_t snd_seq_poll(struct file *file, poll_table * wait) /* check client structures are in place */ if (snd_BUG_ON(!client)) - return -ENXIO; + return EPOLLERR; if ((snd_seq_file_flags(file) & SNDRV_SEQ_LFLG_INPUT) && client->data.user.fifo) { -- 2.18.0

1 0

[alsa-devel] Need some help building alsa-utils
by Jamey Kirby 25 Jul '18

25 Jul '18

I have been working with alsa for a while. We use it to archive content from our radio station. I am using arecord. Build problem: 1) I cloned alsa-utils from github 2) Spent two hours on Google trying to figure out how to build the darn thing. 3) I am running Ubuntu Server 18.0 with build-essentials installed. 4) I get errors that I do not know how to fix when I try to setup ./configure. 5) I just need to make a build. What do I need to do? Feature: I am adding a feature. In the loop for capture(), when a new file is opened, I want to close the old file (when doing continuous recording). I added a new CLI parameter -K. When this is set, the capture() loop will close the old file before opening the new file. This is an issue for me for two reasons: 1) When will i run out of file handles? I capture one hour files continuously. After 10 hours, I see that all the capture files are still open? 2) I need to be notified when the file is closed so that I can do post-processing of rht capture. I've tried inotifywait in a script, and in another script I tried lsof. lsof works great, but the files are open,. See, the main issue is that I need to know when each file completes so that I can post process. Here is my post process script outline: #!/bin/bash for f in $HOME/vboxshare/jkirby/newarc/*.raw do filename=$(basename $f) open=$(lsof -t $f | wc -w) if [ $open -lt 1 ] then echo "$filename is closed" echo "Do post processing here" else echo "$filename is open by $open processe(s)" fi done If I could close the file before or after the previous file is closed, I can do my work. Otherwise, I have no way to know if the file is open and being processed or not. So, I've made the changes, I just need to build the darn thing. Thanks for any advice or help. -- Jamey Kirby Disrupting the establishment since 1964 This is a personal email account and as such, emails are not subject to archiving. Nothing else really matters.

1 2

[alsa-devel] [asoc:topic/amd 1/1] sound/soc/amd/acp-da7219-max98357a.c:325:3: warning: 'ret' may be used uninitialized in this function
by kbuild test robot 25 Jul '18

25 Jul '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/amd head: 7b5317aa809f833d017196ad4a34e3b3b7dae101 commit: 7b5317aa809f833d017196ad4a34e3b3b7dae101 [1/1] ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002 config: x86_64-randconfig-x002-201829 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: git checkout 7b5317aa809f833d017196ad4a34e3b3b7dae101 # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe': >> sound/soc/amd/acp-da7219-max98357a.c:325:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] dev_err(&pdev->dev, "Failed to register regulator: %d\n", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ret); ~~~~ vim +/ret +325 sound/soc/amd/acp-da7219-max98357a.c 313 314 static int cz_probe(struct platform_device *pdev) 315 { 316 int ret; 317 struct snd_soc_card *card; 318 struct acp_platform_info *machine; 319 struct regulator_dev *rdev; 320 321 acp_da7219_cfg.dev = &pdev->dev; 322 rdev = devm_regulator_register(&pdev->dev, &acp_da7219_desc, 323 &acp_da7219_cfg); 324 if (IS_ERR(rdev)) { > 325 dev_err(&pdev->dev, "Failed to register regulator: %d\n", 326 ret); 327 return -EINVAL; 328 } 329 330 machine = devm_kzalloc(&pdev->dev, sizeof(struct acp_platform_info), 331 GFP_KERNEL); 332 if (!machine) 333 return -ENOMEM; 334 card = &cz_card; 335 cz_card.dev = &pdev->dev; 336 platform_set_drvdata(pdev, card); 337 snd_soc_card_set_drvdata(card, machine); 338 ret = devm_snd_soc_register_card(&pdev->dev, &cz_card); 339 if (ret) { 340 dev_err(&pdev->dev, 341 "devm_snd_soc_register_card(%s) failed: %d\n", 342 cz_card.name, ret); 343 return ret; 344 } 345 bt_uart_enable = !device_property_read_bool(&pdev->dev, 346 "bt-pad-enable"); 347 return 0; 348 } 349 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH v2] ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002
by Akshu Agrawal 25 Jul '18

25 Jul '18

DA7219 for our platform need to be configured for 1.8V. Hence, we add a volatge regulator with supplies of 1.8V in the machine driver. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource(a)diasemi.com> Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/Kconfig | 1 + sound/soc/amd/acp-da7219-max98357a.c | 43 ++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 6cbf9cf..58c1dcb 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -8,6 +8,7 @@ config SND_SOC_AMD_CZ_DA7219MX98357_MACH select SND_SOC_DA7219 select SND_SOC_MAX98357A select SND_SOC_ADAU7002 + select REGULATOR depends on SND_SOC_AMD_ACP && I2C help This option enables machine driver for DA7219 and MAX9835. diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index f42606e..cd3cf6e 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -32,6 +32,8 @@ #include <linux/clk.h> #include <linux/gpio.h> #include <linux/module.h> +#include <linux/regulator/machine.h> +#include <linux/regulator/driver.h> #include <linux/i2c.h> #include <linux/input.h> #include <linux/acpi.h> @@ -320,11 +322,52 @@ static void cz_dmic_shutdown(struct snd_pcm_substream *substream) .num_controls = ARRAY_SIZE(cz_mc_controls), }; +static struct regulator_consumer_supply acp_da7219_supplies[] = { + REGULATOR_SUPPLY("VDD", "i2c-DLGS7219:00"), + REGULATOR_SUPPLY("VDDMIC", "i2c-DLGS7219:00"), + REGULATOR_SUPPLY("VDDIO", "i2c-DLGS7219:00"), + REGULATOR_SUPPLY("IOVDD", "ADAU7002:00"), +}; + +static struct regulator_init_data acp_da7219_data = { + .constraints = { + .always_on = 1, + }, + .num_consumer_supplies = ARRAY_SIZE(acp_da7219_supplies), + .consumer_supplies = acp_da7219_supplies, +}; + +static struct regulator_config acp_da7219_cfg = { + .init_data = &acp_da7219_data, +}; + +static struct regulator_ops acp_da7219_ops = { +}; + +static struct regulator_desc acp_da7219_desc = { + .name = "reg-fixed-1.8V", + .type = REGULATOR_VOLTAGE, + .owner = THIS_MODULE, + .ops = &acp_da7219_ops, + .fixed_uV = 1800000, /* 1.8V */ + .n_voltages = 1, +}; + static int cz_probe(struct platform_device *pdev) { int ret; struct snd_soc_card *card; struct acp_platform_info *machine; + struct regulator_dev *rdev; + + acp_da7219_cfg.dev = &pdev->dev; + rdev = devm_regulator_register(&pdev->dev, &acp_da7219_desc, + &acp_da7219_cfg); + if (IS_ERR(rdev)) { + dev_err(&pdev->dev, "Failed to register regulator: %d\n", + ret); + return -EINVAL; + } machine = devm_kzalloc(&pdev->dev, sizeof(struct acp_platform_info), GFP_KERNEL); -- 1.9.1

2 1