July 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] sound: stm32: replace "%p" with "%pK"
by Benjamin Gaignard 09 Jul '18

09 Jul '18

The format specifier "%p" can leak kernel addresses. Use "%pK" instead. Signed-off-by: Benjamin Gaignard <benjamin.gaignard(a)st.com> --- sound/soc/stm/stm32_adfsdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_adfsdm.c b/sound/soc/stm/stm32_adfsdm.c index db73fef3e500..0e9373064032 100644 --- a/sound/soc/stm/stm32_adfsdm.c +++ b/sound/soc/stm/stm32_adfsdm.c @@ -149,7 +149,7 @@ static int stm32_afsdm_pcm_cb(const void *data, size_t size, void *private) unsigned int old_pos = priv->pos; unsigned int cur_size = size; - dev_dbg(rtd->dev, "%s: buff_add :%p, pos = %d, size = %zu\n", + dev_dbg(rtd->dev, "%s: buff_add :%pK, pos = %d, size = %zu\n", __func__, &pcm_buff[priv->pos], priv->pos, size); if ((priv->pos + size) > buff_size) { -- 2.15.0

3 3

[alsa-devel] How to add new sound card with ASoC generic driver
by Riccardo Casagrande 09 Jul '18

09 Jul '18

Hello, I'm new to ALSA and linux in general, I need help from who knows well ALSA due to the tight schedule of the project. I'm working on a Yocto project on NXP i.MX6Quad. The hardware architetture is this: the i.MAX6Quad has 6 output connected to 3 ST FDA2100 and 2 input from ADC. In the first step what I need is simply to enable 6 output and send I2S audio to FDAs. In the second step is required a clock for ADC and enable input ports. I spent days/weeks reading docs, examples etc without success. I understood that working on device tree file and setting a simple audio card with generic codec properly is the answer, but my knowledge is almost nothing. I followed these docs/thread https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bin… https://community.nxp.com/thread/475428 but compiling I have syntax errors on device tree file. There is someone who can help me step by step? Thanks in advance Riccardo

1 0

[alsa-devel] Binding volume and mute switch
by Ladislav Michl 09 Jul '18

09 Jul '18

Hello, to provide almost self descriptive controls to alsamixer I'd like to achive something like this: http://ladislav.michl.sweb.cz/alsamixer1.png Master volume is muted using switch coupled with master volume control, microphone is muted using switch coupled with microphone volume control, etc... For mic and line input is works as expected, but for sidetone and master volume I had to use "proper" names for mixer controls, see bellow: /* Input mixer */ static const struct snd_kcontrol_new max9867_input_mixer_controls[] = { SOC_DAPM_DOUBLE("Mic Switch", MAX9867_INPUTCONFIG, 6, 4, 1, 0), SOC_DAPM_DOUBLE("Line Switch", MAX9867_INPUTCONFIG, 7, 5, 1, 0), }; /* Output mixer */ static const struct snd_kcontrol_new max9867_output_mixer_controls[] = { SOC_DAPM_DOUBLE_R("Line Bypass Switch", MAX9867_LEFTLINELVL, MAX9867_RIGHTLINELVL, 6, 1, 1), }; /* Sidetone mixer */ static const struct snd_kcontrol_new max9867_sidetone_mixer_controls[] = { SOC_DAPM_DOUBLE("Sidetone Switch", MAX9867_SIDETONE, 6, 7, 1, 0), }; /* Line out switch */ static const struct snd_kcontrol_new max9867_line_out_control = SOC_DAPM_DOUBLE_R("Switch", MAX9867_LEFTVOL, MAX9867_RIGHTVOL, 6, 1, 1); static const struct snd_soc_dapm_widget max9867_dapm_widgets[] = { SND_SOC_DAPM_INPUT("MICL"), SND_SOC_DAPM_INPUT("MICR"), SND_SOC_DAPM_INPUT("LINL"), SND_SOC_DAPM_INPUT("LINR"), SND_SOC_DAPM_MIXER("Left Input Mixer", MAX9867_PWRMAN, 6, 1, max9867_input_mixer_controls, ARRAY_SIZE(max9867_input_mixer_controls)), SND_SOC_DAPM_MIXER("Right Input Mixer", MAX9867_PWRMAN, 5, 1, max9867_input_mixer_controls, ARRAY_SIZE(max9867_input_mixer_controls)), SND_SOC_DAPM_ADC("ADCL", "HiFi Capture", MAX9867_PWRMAN, 1, 0), SND_SOC_DAPM_ADC("ADCR", "HiFi Capture", MAX9867_PWRMAN, 0, 0), SND_SOC_DAPM_MIXER("Digital", SND_SOC_NOPM, 0, 0, max9867_sidetone_mixer_controls, ARRAY_SIZE(max9867_sidetone_mixer_controls)), SND_SOC_DAPM_MIXER("Output Mixer", SND_SOC_NOPM, 0, 0, max9867_output_mixer_controls, ARRAY_SIZE(max9867_output_mixer_controls)), SND_SOC_DAPM_DAC("DACL", "HiFi Playback", MAX9867_PWRMAN, 3, 0), SND_SOC_DAPM_DAC("DACR", "HiFi Playback", MAX9867_PWRMAN, 2, 0), SND_SOC_DAPM_SWITCH("Master Playback", SND_SOC_NOPM, 0, 0, &max9867_line_out_control), SND_SOC_DAPM_OUTPUT("LOUT"), SND_SOC_DAPM_OUTPUT("ROUT"), }; static const struct snd_soc_dapm_route max9867_audio_map[] = { {"Left Input Mixer", "Mic Switch", "MICL"}, {"Right Input Mixer", "Mic Switch", "MICR"}, {"Left Input Mixer", "Line Switch", "LINL"}, {"Right Input Mixer", "Line Switch", "LINR"}, {"ADCL", NULL, "Left Input Mixer"}, {"ADCR", NULL, "Right Input Mixer"}, {"Digital", "Sidetone Switch", "ADCL"}, {"Digital", "Sidetone Switch", "ADCR"}, {"DACL", NULL, "Digital"}, {"DACR", NULL, "Digital"}, {"Output Mixer", "Line Bypass Switch", "LINL"}, {"Output Mixer", "Line Bypass Switch", "LINR"}, {"Output Mixer", NULL, "DACL"}, {"Output Mixer", NULL, "DACR"}, {"Master Playback", "Switch", "Output Mixer"}, {"LOUT", NULL, "Master Playback"}, {"ROUT", NULL, "Master Playback"}, }; With other control names than "Digital" for sidetone digital mixer, sidetone switch is shown separately from sidetone volume. The same for master volume switch, which is bind with master volume only once its name is "Master Playback". Is it intended to work this way or there is some other, more elegant way how to bind mute switch with volume control. (above solution seem too fragile to me) Thank you, ladis

1 0

[alsa-devel] Hiding some of the controls defined in codec driver from machine driver context
by Giedrius Trainavičius 09 Jul '18

09 Jul '18

Hello, Is it possible to 'hide' some of the controls of the codec in the machine driver? The codec I'm using exposes many advanced controls which are useful for board developers, but not for the end user, so I'd like to define my own 'simplified' controls, and take care of board specific logic internally in the machine driver. I found this old discussion on the topic: https://www.spinics.net/lists/alsa-devel/msg36386.html - I'm targeting kernel 4.14, maybe there's already some means to achieve this? Thank you! Giedrius.

2 1

Re: [alsa-devel] [PATCH] vgaswitchroo: set audio client id according to bound gpu client id
by Lukas Wunner 09 Jul '18

09 Jul '18

On Mon, Jul 09, 2018 at 08:52:33AM +0000, Qu, Jim wrote: > Now, I found the audio device will auto suspend even if the gpu is active, > and if I plug in a HDMI device it also do not resume back. > > 1. Did you encounter similar issue before? > 2. audio will auto suspend as default at beginning of boot, is it expect > behaviour? Yes, that's expected. Once you start streaming audio to attached displays, user space opens the codec device and this causes the HDA controller to runtime resume. If the discrete GPU is suspended at that moment, it will be powered on and kept powered on as long as user space is streaming audio. Do you need to runtime resume the HDA controller even if user space isn't streaming audio? Why, and in which situation exactly? You're saying above that the HDA controller isn't runtime resumed on hotplug of a display. Is that necessary to retrieve ELD or something? I'm not sure if there's code in the HDA driver to acquire a runtime PM ref on HPD, but maybe it's necessary. Or maybe the code is there but somehow no HPD interrupt is received by the HDA driver? Thanks, Lukas

1 0

[alsa-devel] Getting a notification of snd_kcontrol value change, defined in codec, in machine driver
by Giedrius Trainavičius 08 Jul '18

08 Jul '18

Hey, What would be the best way in machine driver to learn about changes of alsa mixer control values? The controls are defined in the codec driver. The intended use case would be to use the current volume setting for the codec on the board to forward to a dedicated microcontroller for visual feedback. I am aware that this could be bridged over via a user space program, but I will have to forward the current PCM stream format to the MCU anyway from hw_params, so ideally I would like all of this functionality contained in the machine driver. Thank you, Giedrius.

3 3

[alsa-devel] [PATCH] slimbus: stream: Fix htmldocs warnings
by Srinivas Kandagatla 07 Jul '18

07 Jul '18

This patch fixes below warning during building htmldoc: slimbus.h:352: warning: Function parameter or member 'name' not described in 'slim_stream_runtime' This patch also removes documentation for state variable in struct slim_stream_runtime which was redundant and removed. Reported-by: kbuild test robot <lkp(a)intel.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- drivers/slimbus/slimbus.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 411880f3fc0a..32ac4046154f 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -325,9 +325,8 @@ enum slim_transport_protocol { /** * struct slim_stream_runtime - SLIMbus stream runtime instance * - * @dev: Name of the stream + * @name: Name of the stream * @dev: SLIM Device instance associated with this stream - * @state: state of stream * @direction: direction of stream * @prot: Transport protocol used in this stream * @rate: Data rate of samples * -- 2.16.2

1 0

[alsa-devel] Bad header guard in alsa-lib
by Guillaume Blanc 06 Jul '18

06 Jul '18

Hello, While building alsa-lib, I got a redefinition error caused by a bad header guard in pcm_plugin.h. I assume this is a mistake and not a weird include trick, attached is a patch to fix this. Best regards, Guillaume Blanc

2 1

[alsa-devel] [PATCH] ASoC: nau8810: use 64-bit arithmetic instead of 32-bit
by Gustavo A. R. Silva 06 Jul '18

06 Jul '18

Add suffix ULL to constant 256 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: 256 * fs * 4 * nau8810_mclk_scaler[i] / 10 Addresses-Coverity-ID: 1357595 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/soc/codecs/nau8810.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c index bfd74b8..e7fd0b2 100644 --- a/sound/soc/codecs/nau8810.c +++ b/sound/soc/codecs/nau8810.c @@ -505,7 +505,7 @@ static int nau88l0_calc_pll(unsigned int pll_in, f2_max = 0; scal_sel = ARRAY_SIZE(nau8810_mclk_scaler); for (i = 0; i < ARRAY_SIZE(nau8810_mclk_scaler); i++) { - f2 = 256 * fs * 4 * nau8810_mclk_scaler[i] / 10; + f2 = 256ULL * fs * 4 * nau8810_mclk_scaler[i] / 10; if (f2 > NAU_PLL_FREQ_MIN && f2 < NAU_PLL_FREQ_MAX && f2_max < f2) { f2_max = f2; -- 2.7.4

2 1

[alsa-devel] [PATCH] ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION
by Hui Wang 06 Jul '18

06 Jul '18

We have two new lenovo desktop models which need to apply the fixup of ALC294_FIXUP_LENOVO_MIC_LOCATION, and they have the same pin cfg as the machine with subsystem id:0x17aa3136, now use the pincfg table to apply the fixup for them. Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 63154b9..666713e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6556,7 +6556,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x312a, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), - SND_PCI_QUIRK(0x17aa, 0x3136, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI), SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), @@ -6822,6 +6821,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x1a, 0x02a11040}, {0x1b, 0x01014020}, {0x21, 0x0221101f}), + SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC294_FIXUP_LENOVO_MIC_LOCATION, + {0x14, 0x90170110}, + {0x19, 0x02a11020}, + {0x1a, 0x02a11030}, + {0x21, 0x0221101f}), SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, {0x12, 0x90a60140}, {0x14, 0x90170110}, -- 2.7.4

2 1