June 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Slow SPI reads in ALSA causing mic recording error
by noman pouigt 15 Jun '18

15 Jun '18

Hello Folks, I have a DSP hardware connected over SPI to SoC with extra interrupt line. I am getting buffer overrun problem in DSP while doing MIC recording. SoC SPI consecutive reads are two slow and it is not able to empty DSP buffers in time which causes DSP to issue overruns interrupts to SoC and causes bad mic data recording. ARECORD properly records mic data but when I try to use AudioFlinger(android) then I see buffer overrun issue in DSP. Period size is same in both arecord and AudioFlinger case. system: arm64, latest mainline kernel, latest alsa-lib I have below platform ops static const struct snd_pcm_ops platform_ops = { .open = platform_open, .ioctl = snd_pcm_lib_ioctl, .pointer = platform_pcm_pointer, .mmap = snd_pcm_lib_default_mmap, .page = snd_pcm_lib_get_vmalloc_page, }; What baffles me is that consecutive SPI read(while loop in a workqueue) doesn't have any relation with userspace as it is interrupt driven (DSP interrupt) but still with audio flinger overrun happens. In the workqueue, between SPI reads, driver calls elapsed function to notify the userspace to read 1 period data whenever data crosses period boundary. I don't think that causes any issues. Aforementioned workqueue stops only when userspace closes it so I don't know how userspace application can slow down SPI reads? I have also used high priority workqueues but that didn't help either. Wondering if I can get some pointers to debug this? also if there any alsa-utility which can simulate closely audio flinger? Thanks,

2 3

[alsa-devel] [PATCH 0/2] ALSA: usb-audio: Insertion Control for BADD Adaptors.
by Jorge Sanjuan 14 Jun '18

14 Jun '18

This patchset adds support for the Insertion Control for BADD devices (subset of UAC3). This control is only pressent in the HEADSET ADAPTER BADD profile. The USB interrupt pipe shall be present for this profile so the status pipe creation should also happen for BADD devices. Also, the bi-directional type codes have been defined so they can be used as inferred values for the Input and Output terminals for this adapter profile. -- Based on tag: next-20180612 Jorge Sanjuan (2): ALSA: usb-audio: Add bi-directional terminal types. ALSA: usb-audio: UAC3. Add insertion control for BADD. include/uapi/linux/usb/audio.h | 8 ++++++++ sound/usb/mixer.c | 45 ++++++++++++++++++++++++++++++------------ 2 files changed, 40 insertions(+), 13 deletions(-) -- 2.11.0

3 11

[alsa-devel] [PATCH] ALSA: lx6464es: add error handling for pci_ioremap_bar
by Zhouyang Jia 14 Jun '18

14 Jun '18

When pci_ioremap_bar fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling pci_ioremap_bar. Signed-off-by: Zhouyang Jia <jiazhouyang09(a)gmail.com> --- sound/pci/lx6464es/lx6464es.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c index 9655b08..6157b6d 100644 --- a/sound/pci/lx6464es/lx6464es.c +++ b/sound/pci/lx6464es/lx6464es.c @@ -1016,6 +1016,10 @@ static int snd_lx6464es_create(struct snd_card *card, /* dsp port */ chip->port_dsp_bar = pci_ioremap_bar(pci, 2); + if (!chip->port_dsp_bar) { + dev_err(card->dev, "cannot remap PCI memory region\n"); + goto request_irq_failed; + } err = request_threaded_irq(pci->irq, lx_interrupt, lx_threaded_irq, IRQF_SHARED, KBUILD_MODNAME, chip); -- 2.7.4

2 3

[alsa-devel] [PATCH] ALSA: sonicvibes: add error handling for snd_ctl_add
by Zhouyang Jia 14 Jun '18

14 Jun '18

When snd_ctl_add fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling snd_ctl_add. Signed-off-by: Zhouyang Jia <jiazhouyang09(a)gmail.com> --- sound/pci/sonicvibes.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/pci/sonicvibes.c b/sound/pci/sonicvibes.c index a8abb15..57cb77a 100644 --- a/sound/pci/sonicvibes.c +++ b/sound/pci/sonicvibes.c @@ -1188,6 +1188,7 @@ SONICVIBES_SINGLE("Joystick Speed", 0, SV_IREG_GAME_PORT, 1, 15, 0); static int snd_sonicvibes_create_gameport(struct sonicvibes *sonic) { struct gameport *gp; + int err; sonic->gameport = gp = gameport_allocate_port(); if (!gp) { @@ -1203,7 +1204,10 @@ static int snd_sonicvibes_create_gameport(struct sonicvibes *sonic) gameport_register_port(gp); - snd_ctl_add(sonic->card, snd_ctl_new1(&snd_sonicvibes_game_control, sonic)); + err = snd_ctl_add(sonic->card, + snd_ctl_new1(&snd_sonicvibes_game_control, sonic)); + if (err < 0) + return err; return 0; } -- 2.7.4

2 6

[alsa-devel] [PATCH] ASoC: codecs: PCM1789: include gpio/consumer.h
by Arnd Bergmann 14 Jun '18

14 Jun '18

When CONFIG_GPIOLIB is disabled, this codec fails to build because gpio/consumer.h is not included implicitly. sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init': sound/soc/codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ^~~~~~~~~~~~~~~~~~~~~~~ Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/codecs/pcm1789.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c index 507ac9412d6c..21f15219b3ad 100644 --- a/sound/soc/codecs/pcm1789.c +++ b/sound/soc/codecs/pcm1789.c @@ -3,7 +3,7 @@ // Copyright (C) 2018 Bootlin // Mylène Josserand <mylene.josserand(a)bootlin.com> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/workqueue.h> -- 2.9.0

2 1

[alsa-devel] [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex
by Robert Jarzmik 14 Jun '18

14 Jun '18

This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik <robert.jarzmik(a)free.fr> --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt diff --git a/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt b/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt new file mode 100644 index 000000000000..b3f2882d9c7d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/marvell,pxa2xx-ac97.txt @@ -0,0 +1,25 @@ +Marvell PXA2xx audio complex + +This descriptions matches the AC97 controller found in pxa2xx and pxa3xx series. + +Required properties: + - compatible: "marvell,pxa2xx-ac97" + - reg: device MMIO address space + - interrupts: single interrupt generated by AC97 IP + - clocks: input clock of the AC97 IP, refer to clock-bindings.txt + +Optional properties: + - pinctrl-names, pinctrl-0: refer to pinctrl-bindings.txt + - reset-gpio: gpio used for AC97 reset, refer to gpio.txt + +Example: + ac97: sound@40500000 { + compatible = "marvell,pxa2xx-ac97"; + reg = < 0x40500000 0x1000 >; + interrupts = <14>; + reset-gpio = <&gpio 113 GPIO_ACTIVE_HIGH>; + #sound-dai-cells = <1>; + pinctrl-names = "default"; + pinctrl-0 = < &pmux_ac97_default >; + status = "okay"; + }; -- 2.11.0

3 4

[alsa-devel] [PATCH v2 0/6] soundwire: Add multi link support
by Shreyas NC 14 Jun '18

14 Jun '18

Currently, in the SoundWire subsystem, the concept of stream is limited to a Master and one or more Slaves(Codecs). This series aims to add support for multiple Master(s) sharing the same reference clock and synchronized in the hardware. This patch series adds: - Helpers to lock bus instances part of the stream - Boiler plate conversion of code to support a list of Master runtime - Support multi link bank switch to support synchronization between multiple masters - Add Intel platform ops for pre/post bank switch Changes in v2: - Add the example in Documentation as pointed out by Vinod - As Pierre suggested, added more description to the sdw_acquire_bus_lock() and sdw_release_bus_lock() API and sdw_stream_runtime data structure. Sanyog Kale (2): Documentation: soundwire: Add documentation for Multi link soundwire: Add support to lock across bus instances Shreyas NC (3): soundwire: Initialize completion for defer messages soundwire: Add support for multilink bank switch soundwire: intel: Add pre/post bank switch ops Vinod Koul (1): soundwire: Handle multiple master instances in a stream Documentation/driver-api/soundwire/stream.rst | 29 +- drivers/soundwire/bus.c | 1 + drivers/soundwire/bus.h | 4 + drivers/soundwire/intel.c | 54 ++++ drivers/soundwire/stream.c | 441 ++++++++++++++++++-------- include/linux/soundwire/sdw.h | 8 +- 6 files changed, 407 insertions(+), 130 deletions(-) -- 2.7.4

3 11

[alsa-devel] [PATCH] conf/ucm: VEYRON-I2S: Add internal speakers and mic, other fixes
by Urja Rannikko 13 Jun '18

13 Jun '18

Hi, Attached is a patch that effectively fixes pulseaudio (and adds the internal speakers for other UCM users, if any) on the ASUS C201 chromebook.

2 2

[alsa-devel] [PATCH 0/1] ALSA: usb-audio: Remove explicitly listed Mytek devices
by Jussi Laako 13 Jun '18

13 Jun '18

I missed the part that removes Mytek devices from explicit list, from the earlier patch set when merging changes from my kernel tree. This patch removes the devices already covered by the earlier patch which also covers the Mytek Liberty DAC not listed here.

2 2

[alsa-devel] [PATCH] More generic way to detect DSD capabilities
by Jussi Laako 13 Jun '18

13 Jun '18

There is a more generic way to detect DSD capability of popular UAC2 implementations. Advantage is that each new device with DSD capability doesn't have to be explicitly listed through VID:PID. XMOS/Thesycon implementation uses this method. As a safety precaution I have still left VID detection in place. Many of the implementations use XMOS' VID, but not all. I have moved over the devices that have been tested with these patches. Likely more of at least XMOS VID ones could be removed from the explicit list, but I opted for careful approach.

2 4