June 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: AMD: Configure channel 1 or channel 0 for capture
by Akshu Agrawal 01 Jun '18

01 Jun '18

ST/CZ SoC have 2 channels for capture in the I2SSP path. The DMA though these channels is done using the same dma descriptors. We configure the channel and enable it on the basis of channel selected by machine driver. Machine driver knows which codec sits on which channel and thus sends the information to dma driver. Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- This patch is dependent on ASoC: AMD: Change codec to channel link as per hardware redesign https://patchwork.kernel.org/patch/10388099/ sound/soc/amd/acp-da7219-max98357a.c | 43 +++++++++++++++++--- sound/soc/amd/acp-pcm-dma.c | 79 +++++++++++++++++++++++++++++++++++- sound/soc/amd/acp.h | 4 ++ 3 files changed, 119 insertions(+), 7 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index 566bd26..f42606e 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -149,6 +149,7 @@ static int cz_da7219_startup(struct snd_pcm_substream *substream) &constraints_rates); machine->i2s_instance = I2S_SP_INSTANCE; + machine->capture_channel = CAP_CHANNEL1; return da7219_clk_enable(substream); } @@ -172,7 +173,7 @@ static void cz_max_shutdown(struct snd_pcm_substream *substream) da7219_clk_disable(); } -static int cz_dmic_startup(struct snd_pcm_substream *substream) +static int cz_dmic0_startup(struct snd_pcm_substream *substream) { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_card *card = rtd->card; @@ -182,6 +183,17 @@ static int cz_dmic_startup(struct snd_pcm_substream *substream) return da7219_clk_enable(substream); } +static int cz_dmic1_startup(struct snd_pcm_substream *substream) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_card *card = rtd->card; + struct acp_platform_info *machine = snd_soc_card_get_drvdata(card); + + machine->i2s_instance = I2S_SP_INSTANCE; + machine->capture_channel = CAP_CHANNEL0; + return da7219_clk_enable(substream); +} + static void cz_dmic_shutdown(struct snd_pcm_substream *substream) { da7219_clk_disable(); @@ -197,8 +209,13 @@ static void cz_dmic_shutdown(struct snd_pcm_substream *substream) .shutdown = cz_max_shutdown, }; -static const struct snd_soc_ops cz_dmic_cap_ops = { - .startup = cz_dmic_startup, +static const struct snd_soc_ops cz_dmic0_cap_ops = { + .startup = cz_dmic0_startup, + .shutdown = cz_dmic_shutdown, +}; + +static const struct snd_soc_ops cz_dmic1_cap_ops = { + .startup = cz_dmic1_startup, .shutdown = cz_dmic_shutdown, }; @@ -241,8 +258,9 @@ static void cz_dmic_shutdown(struct snd_pcm_substream *substream) .ops = &cz_max_play_ops, }, { - .name = "dmic", - .stream_name = "DMIC Capture", + /* C panel DMIC */ + .name = "dmic0", + .stream_name = "DMIC0 Capture", .platform_name = "acp_audio_dma.0.auto", .cpu_dai_name = "designware-i2s.3.auto", .codec_dai_name = "adau7002-hifi", @@ -250,7 +268,20 @@ static void cz_dmic_shutdown(struct snd_pcm_substream *substream) .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM, .dpcm_capture = 1, - .ops = &cz_dmic_cap_ops, + .ops = &cz_dmic0_cap_ops, + }, + { + /* A/B panel DMIC */ + .name = "dmic1", + .stream_name = "DMIC1 Capture", + .platform_name = "acp_audio_dma.0.auto", + .cpu_dai_name = "designware-i2s.2.auto", + .codec_dai_name = "adau7002-hifi", + .codec_name = "ADAU7002:00", + .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF + | SND_SOC_DAIFMT_CBM_CFM, + .dpcm_capture = 1, + .ops = &cz_dmic1_cap_ops, }, }; diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 7720384..ad85354 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -336,6 +336,68 @@ static void config_acp_dma(void __iomem *acp_mmio, rtd->dma_dscr_idx_2, asic_type); } +static void acp_dma_cap_channel(void __iomem *acp_mmio, u16 cap_channel, + bool enable) +{ + u32 val; + + if (enable) { + switch (cap_channel) { + case CAP_CHANNEL1: + val = acp_reg_read(acp_mmio, + mmACP_I2S_16BIT_RESOLUTION_EN); + if (val & ACP_I2S_MIC_16BIT_RESOLUTION_EN) { + acp_reg_write(0x0, acp_mmio, + mmACP_I2SMICSP_RER1); + /* Set 16bit resolution on capture */ + acp_reg_write(0x2, acp_mmio, + mmACP_I2SMICSP_RCR1); + } + val = acp_reg_read(acp_mmio, mmACP_I2SMICSP_IMR1); + val &= ~ACP_I2SMICSP_IMR1__I2SMICSP_RXDAM_MASK; + val &= ~ACP_I2SMICSP_IMR1__I2SMICSP_RXFOM_MASK; + acp_reg_write(val, acp_mmio, mmACP_I2SMICSP_IMR1); + acp_reg_write(0x1, acp_mmio, mmACP_I2SMICSP_RER1); + break; + case CAP_CHANNEL0: + default: + val = acp_reg_read(acp_mmio, + mmACP_I2S_16BIT_RESOLUTION_EN); + if (val & ACP_I2S_MIC_16BIT_RESOLUTION_EN) { + acp_reg_write(0x0, acp_mmio, + mmACP_I2SMICSP_RER0); + /* Set 16bit resolution on capture */ + acp_reg_write(0x2, acp_mmio, + mmACP_I2SMICSP_RCR0); + } + val = acp_reg_read(acp_mmio, mmACP_I2SMICSP_IMR0); + val &= ~ACP_I2SMICSP_IMR0__I2SMICSP_RXDAM_MASK; + val &= ~ACP_I2SMICSP_IMR0__I2SMICSP_RXFOM_MASK; + acp_reg_write(val, acp_mmio, mmACP_I2SMICSP_IMR0); + acp_reg_write(0x1, acp_mmio, mmACP_I2SMICSP_RER0); + break; + } + } else { + switch (cap_channel) { + case CAP_CHANNEL1: + val = acp_reg_read(acp_mmio, mmACP_I2SMICSP_IMR1); + val |= ACP_I2SMICSP_IMR1__I2SMICSP_RXDAM_MASK; + val |= ACP_I2SMICSP_IMR1__I2SMICSP_RXFOM_MASK; + acp_reg_write(val, acp_mmio, mmACP_I2SMICSP_IMR1); + acp_reg_write(0x0, acp_mmio, mmACP_I2SMICSP_RER1); + break; + case CAP_CHANNEL0: + default: + val = acp_reg_read(acp_mmio, mmACP_I2SMICSP_IMR0); + val |= ACP_I2SMICSP_IMR0__I2SMICSP_RXDAM_MASK; + val |= ACP_I2SMICSP_IMR0__I2SMICSP_RXFOM_MASK; + acp_reg_write(val, acp_mmio, mmACP_I2SMICSP_IMR0); + acp_reg_write(0x0, acp_mmio, mmACP_I2SMICSP_RER0); + break; + } + } +} + /* Start a given DMA channel transfer */ static void acp_dma_start(void __iomem *acp_mmio, u16 ch_num) { @@ -773,7 +835,10 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream, if (WARN_ON(!rtd)) return -EINVAL; - rtd->i2s_instance = pinfo->i2s_instance; + if (pinfo) { + rtd->i2s_instance = pinfo->i2s_instance; + rtd->capture_channel = pinfo->capture_channel; + } if (adata->asic_type == CHIP_STONEY) { val = acp_reg_read(adata->acp_mmio, mmACP_I2S_16BIT_RESOLUTION_EN); @@ -989,6 +1054,18 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd) acp_dma_start(rtd->acp_mmio, rtd->ch1); acp_dma_start(rtd->acp_mmio, rtd->ch2); } else { + if (rtd->capture_channel == CAP_CHANNEL0) { + acp_dma_cap_channel(rtd->acp_mmio, + CAP_CHANNEL1, false); + acp_dma_cap_channel(rtd->acp_mmio, + CAP_CHANNEL0, true); + } + if (rtd->capture_channel == CAP_CHANNEL1) { + acp_dma_cap_channel(rtd->acp_mmio, + CAP_CHANNEL0, false); + acp_dma_cap_channel(rtd->acp_mmio, + CAP_CHANNEL1, true); + } acp_dma_start(rtd->acp_mmio, rtd->ch2); acp_dma_start(rtd->acp_mmio, rtd->ch1); } diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h index 9cd3e96..3190fdc 100644 --- a/sound/soc/amd/acp.h +++ b/sound/soc/amd/acp.h @@ -55,6 +55,8 @@ #define I2S_SP_INSTANCE 0x01 #define I2S_BT_INSTANCE 0x02 +#define CAP_CHANNEL0 0x00 +#define CAP_CHANNEL1 0x01 #define ACP_TILE_ON_MASK 0x03 #define ACP_TILE_OFF_MASK 0x02 @@ -125,6 +127,7 @@ struct audio_substream_data { unsigned int order; u16 num_of_pages; u16 i2s_instance; + u16 capture_channel; u16 direction; u16 ch1; u16 ch2; @@ -155,6 +158,7 @@ struct audio_drv_data { */ struct acp_platform_info { u16 i2s_instance; + u16 capture_channel; }; union acp_dma_count { -- 1.9.1

1 0

[alsa-devel] [PATCH v2 0/2] slimbus: Add QCOM SLIMBus NGD driver
by Srinivas Kandagatla 01 Jun '18

01 Jun '18

This patchset adds support to basic version of Qualcomm NGD SLIMBus controller driver found SoCs from B family. This controller is light-weight SLIMBus controller driver responsible for communicating with slave HW directly over the bus using messaging interface, and communicating with master component residing on ADSP for bandwidth and data-channel management. Tested this patchset on DB820c with WCD9335 codec. I have pushed my working branch to [1] incase someone want to try. This patch has dependency on https://lkml.org/lkml/2018/5/17/251 Changes sinc v1 (https://lwn.net/Articles/754679): - Fixed DT binding making NGD slave of the slim controller. - Fixed few typos spotted by Vinod. - Removed unnessary dmaengine_slave_config suggested by Vinod - Removed few unnessary initializations. - fixed commit log to remove reference to B family suggested by Trilok Thanks, srini [1] https://git.linaro.org/people/srinivas.kandagatla/linux.git/log/?h=slimbus-… Srinivas Kandagatla (2): slimbus: ngd: dt-bindings: Add slim ngd dt bindings slimbus: ngd: Add qcom SLIMBus NGD driver .../bindings/slimbus/slim-ngd-qcom-ctrl.txt | 84 ++ drivers/slimbus/Kconfig | 11 + drivers/slimbus/Makefile | 3 + drivers/slimbus/qcom-ngd-ctrl.c | 1342 ++++++++++++++++++++ drivers/slimbus/slimbus.h | 8 + 5 files changed, 1448 insertions(+) create mode 100644 Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt create mode 100644 drivers/slimbus/qcom-ngd-ctrl.c -- 2.16.2

4 5

[alsa-devel] [PATCH v2 16/21] ASoC: max98088: use match_string() helper
by Yisheng Xie 01 Jun '18

01 Jun '18

match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: alsa-devel(a)alsa-project.org Signed-off-by: Yisheng Xie <xieyisheng1(a)huawei.com> --- v2: - split ret=xxx and move assignment to the line before 'if' - fix error return value - both per Andy sound/soc/codecs/max98088.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 865f64c..fb515aa 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -1382,15 +1382,12 @@ static int max98088_set_bias_level(struct snd_soc_component *component, static int max98088_get_channel(struct snd_soc_component *component, const char *name) { - int i; + int ret; - for (i = 0; i < ARRAY_SIZE(eq_mode_name); i++) - if (strcmp(name, eq_mode_name[i]) == 0) - return i; - - /* Shouldn't happen */ - dev_err(component->dev, "Bad EQ channel name '%s'\n", name); - return -EINVAL; + ret = match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name); + if (ret < 0) + dev_err(component->dev, "Bad EQ channel name '%s'\n", name); + return ret; } static void max98088_setup_eq1(struct snd_soc_component *component) -- 1.7.12.4

2 5