May 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [bug report] ALSA: usb: add UAC3 BADD profiles support
by Dan Carpenter 16 May '18

16 May '18

[ Your patch didn't really introduce the bug, it just made it visible to static checkers. - dan ] Hello Ruslan Bilovol, The patch 17156f23e93c: "ALSA: usb: add UAC3 BADD profiles support" from May 4, 2018, leads to the following static checker warning: sound/usb/stream.c:984 snd_usb_get_audioformat_uac3() warn: possible memory leak of 'chmap' sound/usb/stream.c 864 865 chmap = kzalloc(sizeof(*chmap), GFP_KERNEL); 866 if (!chmap) 867 return ERR_PTR(-ENOMEM); 868 869 if (num_channels == 1) { 870 chmap->map[0] = SNDRV_CHMAP_MONO; 871 } else { 872 chmap->map[0] = SNDRV_CHMAP_FL; 873 chmap->map[1] = SNDRV_CHMAP_FR; 874 } 875 876 chmap->channels = num_channels; 877 clock = UAC3_BADD_CS_ID9; 878 goto found_clock; 879 } 880 881 as = snd_usb_find_csint_desc(alts->extra, alts->extralen, 882 NULL, UAC_AS_GENERAL); 883 if (!as) { 884 dev_err(&dev->dev, 885 "%u:%d : UAC_AS_GENERAL descriptor not found\n", 886 iface_no, altno); 887 return NULL; 888 } 889 890 if (as->bLength < sizeof(*as)) { 891 dev_err(&dev->dev, 892 "%u:%d : invalid UAC_AS_GENERAL desc\n", 893 iface_no, altno); 894 return NULL; 895 } 896 897 cluster_id = le16_to_cpu(as->wClusterDescrID); 898 if (!cluster_id) { 899 dev_err(&dev->dev, 900 "%u:%d : no cluster descriptor\n", 901 iface_no, altno); 902 return NULL; 903 } 904 905 /* 906 * Get number of channels and channel map through 907 * High Capability Cluster Descriptor 908 * 909 * First step: get High Capability header and 910 * read size of Cluster Descriptor 911 */ 912 err = snd_usb_ctl_msg(chip->dev, 913 usb_rcvctrlpipe(chip->dev, 0), 914 UAC3_CS_REQ_HIGH_CAPABILITY_DESCRIPTOR, 915 USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN, 916 cluster_id, 917 snd_usb_ctrl_intf(chip), 918 &hc_header, sizeof(hc_header)); 919 if (err < 0) 920 return ERR_PTR(err); 921 else if (err != sizeof(hc_header)) { 922 dev_err(&dev->dev, 923 "%u:%d : can't get High Capability descriptor\n", 924 iface_no, altno); 925 return ERR_PTR(-EIO); 926 } 927 928 /* 929 * Second step: allocate needed amount of memory 930 * and request Cluster Descriptor 931 */ 932 wLength = le16_to_cpu(hc_header.wLength); 933 cluster = kzalloc(wLength, GFP_KERNEL); 934 if (!cluster) 935 return ERR_PTR(-ENOMEM); 936 err = snd_usb_ctl_msg(chip->dev, 937 usb_rcvctrlpipe(chip->dev, 0), 938 UAC3_CS_REQ_HIGH_CAPABILITY_DESCRIPTOR, 939 USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN, 940 cluster_id, 941 snd_usb_ctrl_intf(chip), 942 cluster, wLength); 943 if (err < 0) { 944 kfree(cluster); 945 return ERR_PTR(err); 946 } else if (err != wLength) { 947 dev_err(&dev->dev, 948 "%u:%d : can't get Cluster Descriptor\n", 949 iface_no, altno); 950 kfree(cluster); 951 return ERR_PTR(-EIO); 952 } 953 954 num_channels = cluster->bNrChannels; 955 chmap = convert_chmap_v3(cluster); 956 kfree(cluster); 957 958 /* 959 * lookup the terminal associated to this interface 960 * to extract the clock 961 */ 962 input_term = snd_usb_find_input_terminal_descriptor(chip->ctrl_intf, 963 as->bTerminalLink); 964 if (input_term) { 965 clock = input_term->bCSourceID; 966 goto found_clock; 967 } 968 969 output_term = snd_usb_find_output_terminal_descriptor(chip->ctrl_intf, 970 as->bTerminalLink); 971 if (output_term) { 972 clock = output_term->bCSourceID; 973 goto found_clock; 974 } 975 976 dev_err(&dev->dev, "%u:%d : bogus bTerminalLink %d\n", 977 iface_no, altno, as->bTerminalLink); 978 return NULL; 979 980 found_clock: 981 fp = audio_format_alloc_init(chip, alts, UAC_VERSION_3, iface_no, 982 altset_idx, altno, num_channels, clock); 983 if (!fp) 984 return ERR_PTR(-ENOMEM); We should free "chmap" before returning. 985 986 fp->chmap = chmap; 987 988 if (badd_profile >= UAC3_FUNCTION_SUBCLASS_GENERIC_IO) { 989 fp->attributes = 0; /* No attributes */ 990 991 fp->fmt_type = UAC_FORMAT_TYPE_I; 992 fp->formats = badd_formats; 993 994 fp->nr_rates = 0; /* SNDRV_PCM_RATE_CONTINUOUS */ 995 fp->rate_min = UAC3_BADD_SAMPLING_RATE; 996 fp->rate_max = UAC3_BADD_SAMPLING_RATE; 997 fp->rates = SNDRV_PCM_RATE_CONTINUOUS; 998 999 } else { 1000 fp->attributes = parse_uac_endpoint_attributes(chip, alts, 1001 UAC_VERSION_3, 1002 iface_no); 1003 /* ok, let's parse further... */ 1004 if (snd_usb_parse_audio_format_v3(chip, fp, as, stream) < 0) { 1005 kfree(fp->rate_table); 1006 kfree(fp); 1007 return NULL; And here as well? I don't know. 1008 } 1009 } 1010 1011 return fp; 1012 } regards, dan carpenter

2 1

Re: [alsa-devel] [PATCH v2 09/11] docs: Fix some broken references
by Charles Keepax 16 May '18

16 May '18

On Wed, May 09, 2018 at 10:18:52AM -0300, Mauro Carvalho Chehab wrote: > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix-rst > > Manually checked if the produced result is valid, removing a few > false-positives. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> > --- > drivers/input/touchscreen/wm97xx-core.c | 2 +- Acked-by: Charles Keepax <ckeepax(a)opensource.wolfsonmicro.com> Thanks, Charles

1 0

Re: [alsa-devel] [PATCH v2 09/11] docs: Fix some broken references
by Stephen Boyd 15 May '18

15 May '18

Quoting Mauro Carvalho Chehab (2018-05-09 06:18:52) > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix-rst > > Manually checked if the produced result is valid, removing a few > false-positives. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> > --- > drivers/clk/clk.c | 4 ++-- > drivers/clk/ingenic/cgu.h | 2 +- Acked-by: Stephen Boyd <sboyd(a)kernel.org>

1 0

[alsa-devel] [PATCH 0/4] ALSA: hda/ca0132: constify local symbols
by Takashi Sakamoto 15 May '18

15 May '18

Hi, This module has some local symbols which are read-only. This commit adds 'const' qualifier to the symbols and applies some code optimization. Takashi Sakamoto (4): ALSA: hda/ca0132: constify templates for control element set ALSA: hda/ca0132: constify read-only members of string array ALSA: hda/ca0132: merge strings just for printk ALSA: hda/ca0132: constify parameter table for effects sound/pci/hda/patch_ca0132.c | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-) -- 2.14.1

2 5

[alsa-devel] [alsa-lib][PATCH 0/6] control: optimization for position offset macro of TLV data
by Takashi Sakamoto 15 May '18

15 May '18

Hi, In development period for Linux v4.18, a series of SNDRV_CTL_TLVO_XXX macro was introduced to kernel stuffs for position offset of TLV data. This patchset backports the macros to this library as well as adds code optimization with them. Takashi Sakamoto (6): control: add a series of macro for offset of several types of TLV control: use position offset macro of TLV data hcontrol: use position offset macro of TLV data pcm: hw: use position offset macro of TLV data pcm: softvol: use position offset macro of TLV data test: use position offset macro of TLV data include/sound/tlv.h | 16 ++++++++++ src/control/control.c | 12 ++++---- src/control/control_hw.c | 6 ++-- src/control/control_local.h | 1 + src/control/hcontrol.c | 4 +-- src/control/tlv.c | 72 ++++++++++++++++++++++++--------------------- src/pcm/pcm_hw.c | 10 ++++--- src/pcm/pcm_softvol.c | 11 ++++--- test/user-ctl-element-set.c | 2 +- 9 files changed, 83 insertions(+), 51 deletions(-) -- 2.14.1

2 7

[alsa-devel] [PATCH V3] ASoC: amd: modified dma pointer callback implementation
by Vijendar Mukunda 15 May '18

15 May '18

Modified dma pointer callback implementation. hw ptr calculated based on System Memory to ACP SRAM dma channel transfer count in case of playback. In case of capture, hw ptr calculated based on dma transfer count for ACP SRAM to System Memory Dma channel. Added IOC Bit for Sysmem to ACP Dma channel for both controller instances. Invoked snd_pcm_period_elapsed() call when IOC is reported for System memory to ACP SRAM DMA channel. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- v1->v2: removed hard coded values in acp dma pointer callback declared dma varaibles in rtd structure. v2->v3: modified code to invoke snd_pcm_period_elapsed() call when IOC reported for System Memory to ACP SRAM dma channel. This patch is dependent on [V4,10/10] ASoC: amd: dma driver changes for bt i2s instance https://patchwork.kernel.org/patch/10385381/ sound/soc/amd/acp-pcm-dma.c | 85 +++++++++++++++++++++++---------------------- sound/soc/amd/acp.h | 15 +++----- 2 files changed, 48 insertions(+), 52 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 906eb77..dfb37b5 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -207,11 +207,13 @@ static void set_acp_sysmem_dma_descriptors(void __iomem *acp_mmio, switch (asic_type) { case CHIP_STONEY: dmadscr[i].xfer_val |= + BIT(22) | (ACP_DMA_ATTR_DAGB_GARLIC_TO_SHAREDMEM << 16) | (size / 2); break; default: dmadscr[i].xfer_val |= + BIT(22) | (ACP_DMA_ATTR_DAGB_ONION_TO_SHAREDMEM << 16) | (size / 2); } @@ -356,9 +358,11 @@ static void acp_dma_start(void __iomem *acp_mmio, dma_ctrl |= ACP_DMA_CNTL_0__DMAChRun_MASK; switch (ch_num) { + case SYSRAM_TO_ACP_CH_NUM: case ACP_TO_I2S_DMA_CH_NUM: case ACP_TO_SYSRAM_CH_NUM: case I2S_TO_ACP_DMA_CH_NUM: + case SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM: case ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM: case ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM: case I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM: @@ -642,10 +646,14 @@ static irqreturn_t dma_irq_handler(int irq, void *arg) config_acp_dma_channel(acp_mmio, SYSRAM_TO_ACP_CH_NUM, dscr_idx, 1, 0); acp_dma_start(acp_mmio, SYSRAM_TO_ACP_CH_NUM, false); + acp_reg_write((intr_flag & BIT(ACP_TO_I2S_DMA_CH_NUM)) << 16, + acp_mmio, mmACP_EXTERNAL_INTR_STAT); + } + if ((intr_flag & BIT(SYSRAM_TO_ACP_CH_NUM)) != 0) { + valid_irq = true; snd_pcm_period_elapsed(irq_data->play_i2ssp_stream); - - acp_reg_write((intr_flag & BIT(ACP_TO_I2S_DMA_CH_NUM)) << 16, + acp_reg_write((intr_flag & BIT(SYSRAM_TO_ACP_CH_NUM)) << 16, acp_mmio, mmACP_EXTERNAL_INTR_STAT); } @@ -661,12 +669,19 @@ static irqreturn_t dma_irq_handler(int irq, void *arg) dscr_idx, 1, 0); acp_dma_start(acp_mmio, SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM, false); - snd_pcm_period_elapsed(irq_data->play_i2sbt_stream); acp_reg_write((intr_flag & BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) << 16, acp_mmio, mmACP_EXTERNAL_INTR_STAT); } + if ((intr_flag & BIT(SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM)) != 0) { + valid_irq = true; + snd_pcm_period_elapsed(irq_data->play_i2sbt_stream); + acp_reg_write((intr_flag & + BIT(SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM)) << 16, + acp_mmio, mmACP_EXTERNAL_INTR_STAT); + } + if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) { valid_irq = true; if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_15) == @@ -854,10 +869,9 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream, rtd->destination = TO_BLUETOOTH; rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH8; rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH9; - rtd->byte_cnt_high_reg_offset = - mmACP_I2S_BT_TRANSMIT_BYTE_CNT_HIGH; - rtd->byte_cnt_low_reg_offset = - mmACP_I2S_BT_TRANSMIT_BYTE_CNT_LOW; + rtd->dma_curr_dscr = mmACP_DMA_CUR_DSCR_8; + rtd->cur_trans_cnt = mmACP_DMA_CUR_TRANS_CNT_8; + rtd->end_dma_dscr = PLAYBACK_END_DMA_DESCR_CH8; adata->play_i2sbt_stream = substream; break; case I2S_SP_INSTANCE: @@ -875,10 +889,9 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream, rtd->destination = TO_ACP_I2S_1; rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12; rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13; - rtd->byte_cnt_high_reg_offset = - mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH; - rtd->byte_cnt_low_reg_offset = - mmACP_I2S_TRANSMIT_BYTE_CNT_LOW; + rtd->dma_curr_dscr = mmACP_DMA_CUR_DSCR_12; + rtd->cur_trans_cnt = mmACP_DMA_CUR_TRANS_CNT_12; + rtd->end_dma_dscr = PLAYBACK_END_DMA_DESCR_CH12; adata->play_i2ssp_stream = substream; } } else { @@ -891,10 +904,10 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream, rtd->destination = FROM_BLUETOOTH; rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH10; rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH11; - rtd->byte_cnt_high_reg_offset = - mmACP_I2S_BT_RECEIVE_BYTE_CNT_HIGH; - rtd->byte_cnt_low_reg_offset = - mmACP_I2S_BT_RECEIVE_BYTE_CNT_LOW; + rtd->dma_cntl = mmACP_DMA_CNTL_10; + rtd->dma_curr_dscr = mmACP_DMA_CUR_DSCR_10; + rtd->cur_trans_cnt = mmACP_DMA_CUR_TRANS_CNT_10; + rtd->end_dma_dscr = CAPTURE_END_DMA_DESCR_CH10; adata->capture_i2sbt_stream = substream; break; case I2S_SP_INSTANCE: @@ -914,10 +927,10 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream, rtd->destination = FROM_ACP_I2S_1; rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14; rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15; - rtd->byte_cnt_high_reg_offset = - mmACP_I2S_RECEIVED_BYTE_CNT_HIGH; - rtd->byte_cnt_low_reg_offset = - mmACP_I2S_RECEIVED_BYTE_CNT_LOW; + rtd->dma_cntl = mmACP_DMA_CNTL_14; + rtd->dma_curr_dscr = mmACP_DMA_CUR_DSCR_14; + rtd->cur_trans_cnt = mmACP_DMA_CUR_TRANS_CNT_14; + rtd->end_dma_dscr = CAPTURE_END_DMA_DESCR_CH14; adata->capture_i2ssp_stream = substream; } } @@ -955,22 +968,13 @@ static int acp_dma_hw_free(struct snd_pcm_substream *substream) return snd_pcm_lib_free_pages(substream); } -static u64 acp_get_byte_count(struct audio_substream_data *rtd) -{ - union acp_dma_count byte_count; - - byte_count.bcount.high = acp_reg_read(rtd->acp_mmio, - rtd->byte_cnt_high_reg_offset); - byte_count.bcount.low = acp_reg_read(rtd->acp_mmio, - rtd->byte_cnt_low_reg_offset); - return byte_count.bytescount; -} - static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream) { u32 buffersize; u32 pos = 0; - u64 bytescount = 0; + u32 dma_count = 0; + u16 dscr; + u32 period_bytes; struct snd_pcm_runtime *runtime = substream->runtime; struct audio_substream_data *rtd = runtime->private_data; @@ -979,11 +983,15 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream) return -EINVAL; buffersize = frames_to_bytes(runtime, runtime->buffer_size); - bytescount = acp_get_byte_count(rtd); - - if (bytescount > rtd->bytescount) - bytescount -= rtd->bytescount; - pos = do_div(bytescount, buffersize); + period_bytes = frames_to_bytes(runtime, runtime->period_size); + if ((substream->stream == SNDRV_PCM_STREAM_CAPTURE) && + acp_reg_read(rtd->acp_mmio, rtd->dma_cntl) == 0) + return 0; + dscr = acp_reg_read(rtd->acp_mmio, rtd->dma_curr_dscr); + dma_count = acp_reg_read(rtd->acp_mmio, rtd->cur_trans_cnt); + if (dscr == rtd->end_dma_dscr) + dma_count += period_bytes; + pos = dma_count % buffersize; return bytes_to_frames(runtime, pos); } @@ -1016,7 +1024,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd) { int ret; u32 loops = 4000; - u64 bytescount = 0; struct snd_pcm_runtime *runtime = substream->runtime; struct snd_soc_pcm_runtime *prtd = substream->private_data; @@ -1030,9 +1037,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd) case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: case SNDRV_PCM_TRIGGER_RESUME: - bytescount = acp_get_byte_count(rtd); - if (rtd->bytescount == 0) - rtd->bytescount = bytescount; if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { acp_dma_start(rtd->acp_mmio, rtd->ch1, false); while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) & @@ -1066,7 +1070,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd) acp_dma_stop(rtd->acp_mmio, rtd->ch2); ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1); } - rtd->bytescount = 0; break; default: ret = -EINVAL; diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h index 9cd3e96..4740804 100644 --- a/sound/soc/amd/acp.h +++ b/sound/soc/amd/acp.h @@ -131,12 +131,13 @@ struct audio_substream_data { u16 destination; u16 dma_dscr_idx_1; u16 dma_dscr_idx_2; + u16 end_dma_dscr; u32 pte_offset; u32 sram_bank; - u32 byte_cnt_high_reg_offset; - u32 byte_cnt_low_reg_offset; + u32 dma_cntl; + u32 dma_curr_dscr; + u32 cur_trans_cnt; uint64_t size; - u64 bytescount; void __iomem *acp_mmio; }; @@ -157,14 +158,6 @@ struct acp_platform_info { u16 i2s_instance; }; -union acp_dma_count { - struct { - u32 low; - u32 high; - } bcount; - u64 bytescount; -}; - enum { ACP_TILE_P1 = 0, ACP_TILE_P2, -- 2.7.4

1 0

[alsa-devel] [PATCH 0/4] ALSA: hda: Bug fixes
by Sriram Periyasamy 15 May '18

15 May '18

The series contains few bug fixes and debug updates Pardha Saradhi K (4): ALSA: hda: Make sure DMA is stopped by reading back the RUN bit ALSA: hda: Make sure DMA is started by reading back the RUN bit ALSA: hda: Log HDA Hardware related errors ALSA: hda: check if stream is stopped in snd_hdac_stream_clear sound/hda/hdac_stream.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) -- 2.7.4

2 8

[alsa-devel] [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup
by Peter Ujfalusi 15 May '18

15 May '18

Hi, Changes since v1: - Changed the MODULE_LICENSE from "GPL" to "GPL v2" to match the SPDX line. Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined, whcih I have missed: After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information The first patch also going to fix runtime issue with module loading: snd_soc_sdma: Unknown symbol devm_kmalloc (err 0) snd_soc_sdma: Unknown symbol omap_dma_filter_fn (err 0) snd_soc_sdma: Unknown symbol snd_dmaengine_pcm_prepare_slave_config (err 0) snd_soc_sdma: Unknown symbol devm_snd_dmaengine_pcm_register (err 0) As these symbols are EXPORT_SYMBOL_GPL()... Introduced by commit dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm") The second patch is kust a small adjustement for the include files. Regards, Peter --- Peter Ujfalusi (2): firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer() ASoC: omap: sdma-pcm: Fix modpost warning drivers/firmware/ti_sci.c | 2 +- sound/soc/omap/sdma-pcm.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

1 0

[alsa-devel] [PATCH 0/4] ALSA: usb: UAC3 new features.
by Jorge Sanjuan 15 May '18

15 May '18

Now that the UAC3 patch [1] has made it to linux-next I have some extra features to make a UAC3 device fully work in Linux. Including Jack insertion control that I have put on top of this other patch [2] for UAC2. Also adding support for the UAC3 Mixer Unit which is most likely to appear in most headset type devices. UAC3 devices also require to have a Basic Audio Device (BADD) in a separate config for which both Ruslan Bilovol and myself have submited different approaches[3][4] but I don't know what the final merge will be. Once there is official support for BADD, we'll need to test it with an actual UAC3 device to confirm it all wokrs. All this features are tested with an actual UAC3 device that is still in development. For this patch series, only the legacy config (#1. UAC1/UAC2) and the UAC3 config have been tested. The BADD config is only tested using and updated verison of [4]. [1]: https://patchwork.kernel.org/patch/10298179/ [2]: https://patchwork.kernel.org/patch/10305847/ [3]: https://patchwork.kernel.org/patch/10340851/ [4]: https://www.spinics.net/lists/alsa-devel/msg71617.html Based on linux-next tag: next-20180420 Jorge Sanjuan (3): ALSA: usb-audio: UAC3. Add support for mixer unit. ALSA: usb-audio: Use Class Specific EP for UAC3 devices. ALSA: usb-audio: UAC3 Add support for connector insertion. Michael Drake (1): ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3. include/linux/usb/audio-v2.h | 7 ++ include/linux/usb/audio-v3.h | 14 ++++ include/uapi/linux/usb/audio.h | 13 ++- sound/usb/mixer.c | 175 ++++++++++++++++++++++++++++++++++++----- sound/usb/stream.c | 19 ++++- 5 files changed, 204 insertions(+), 24 deletions(-) -- 2.11.0

5 39

[alsa-devel] [sound:for-next 62/68] sound/pci/hda/patch_ca0132.c:5062:50-51: WARNING: Use ARRAY_SIZE
by kbuild test robot 14 May '18

14 May '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 4844f51282b60f8a96b05d422f452a785df308b9 commit: 47cdf76e44e87d25b91c0f0d0539944c932941ba [62/68] ALSA: hda/ca0132: Add new control changes for SBZ + R3Di coccinelle warnings: (new ones prefixed by >>) >> sound/pci/hda/patch_ca0132.c:5062:50-51: WARNING: Use ARRAY_SIZE sound/pci/hda/patch_ca0132.c:5092:50-51: WARNING: Use ARRAY_SIZE Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 2