May 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 43/45] sound/soc/zte: remove duplicate includes
by Pravin Shedge 17 May '18

17 May '18

These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge <pravin.shedge4linux(a)gmail.com> --- sound/soc/zte/zx-i2s.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/zte/zx-i2s.c b/sound/soc/zte/zx-i2s.c index 9a05659..93428e1 100644 --- a/sound/soc/zte/zx-i2s.c +++ b/sound/soc/zte/zx-i2s.c @@ -20,9 +20,6 @@ #include <sound/core.h> #include <sound/dmaengine_pcm.h> #include <sound/initval.h> -#include <sound/pcm.h> -#include <sound/pcm_params.h> -#include <sound/soc.h> #define ZX_I2S_PROCESS_CTRL 0x04 #define ZX_I2S_TIMING_CTRL 0x08 -- 2.7.4

2 2

[alsa-devel] Is add uevent of controlC still a reliable synchronization point?
by Tzung-Bi Shih 17 May '18

17 May '18

Hi, We found an assumption in 78-sound-cards.rules and commit 289ca025ee1d78223e3368801fc2b984e5efbfc7 are conflict. The control device will not be the last one to register. The assumption in 78-sound-card.rules: > The control device node creation can be used as synchronization point. All other devices that belong to a card are created in the kernel before it. The commit: > commit 289ca025ee1d78223e3368801fc2b984e5efbfc7 > Author: Takashi Iwai <tiwai(a)suse.de> > Date: Wed Jan 29 15:53:35 2014 +0100 > > ALSA: Use priority list for managing device list > > Basically, the device type specifies the priority of the device to be > registered / freed, too. However, the priority value isn't well > utilized but only it's checked as a group. This results in > inconsistent register and free order (where each of them should be in > reversed direction). > > This patch simplifies the device list management code by simply > inserting a list entry at creation time in an incremental order for > the priority value. Since we can just follow the link for register, > disconnect and free calls, we don't have to specify the group; so the > whole enum definitions are also simplified as well. > > The visible change to outside is that the priorities of some object > types are revisited. For example, now the SNDRV_DEV_LOWLEVEL object > is registered before others (control, PCM, etc) and, in return, > released after others. Similarly, SNDRV_DEV_CODEC is in a lower > priority than SNDRV_DEV_BUS for ensuring the dependency. > > Also, the unused SNDRV_DEV_TOPLEVEL, SNDRV_DEV_LOWLEVEL_PRE and > SNDRV_DEV_LOWLEVEL_NORMAL are removed as a cleanup. > > Signed-off-by: Takashi Iwai <tiwai(a)suse.de> The device types: > enum snd_device_type { > SNDRV_DEV_LOWLEVEL, > SNDRV_DEV_CONTROL, > SNDRV_DEV_INFO, > SNDRV_DEV_BUS, > SNDRV_DEV_CODEC, > SNDRV_DEV_SEQUENCER, > SNDRV_DEV_HWDEP, > SNDRV_DEV_JACK, > }; The commit sorts device types ascendantly and registers them from the list head. As a result, SNDRV_DEV_CONTROL devices will be registered before most other devices. We are writing to ask: Is add uevent of controlC still a reliable signal for indicating everything is ready for a sound card? Or is there now a better way to do so?

2 8

[alsa-devel] [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems
by Akshu Agrawal 17 May '18

17 May '18

Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers don't have to explicitly do handling of mclk. Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- v2: Fixed kbuild error v3: Add corresponding clk_put for clk_get include/sound/da7219.h | 2 ++ sound/soc/codecs/da7219.c | 10 +++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/sound/da7219.h b/include/sound/da7219.h index 1bfcb16..df7ddf4 100644 --- a/include/sound/da7219.h +++ b/include/sound/da7219.h @@ -38,6 +38,8 @@ struct da7219_pdata { const char *dai_clks_name; + const char *mclk_name; + /* Mic */ enum da7219_micbias_voltage micbias_lvl; enum da7219_mic_amp_in_sel mic_amp_in_sel; diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 980a6a8..ecd46fc 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1624,6 +1624,8 @@ static struct da7219_pdata *da7219_fw_to_pdata(struct snd_soc_component *compone dev_warn(dev, "Using default clk name: %s\n", pdata->dai_clks_name); + device_property_read_string(dev, "dlg,mclk-name", &pdata->mclk_name); + if (device_property_read_u32(dev, "dlg,micbias-lvl", &of_val32) >= 0) pdata->micbias_lvl = da7219_fw_micbias_lvl(dev, of_val32); else @@ -1905,7 +1907,10 @@ static int da7219_probe(struct snd_soc_component *component) da7219_handle_pdata(component); /* Check if MCLK provided */ - da7219->mclk = devm_clk_get(component->dev, "mclk"); + if (da7219->pdata->mclk_name) + da7219->mclk = clk_get(NULL, da7219->pdata->mclk_name); + if (!da7219->mclk) + da7219->mclk = devm_clk_get(component->dev, "mclk"); if (IS_ERR(da7219->mclk)) { if (PTR_ERR(da7219->mclk) != -ENOENT) { ret = PTR_ERR(da7219->mclk); @@ -1971,6 +1976,9 @@ static void da7219_remove(struct snd_soc_component *component) clkdev_drop(da7219->dai_clks_lookup); #endif + if (da7219->pdata->mclk_name) + clk_put(da7219->mclk); + /* Supplies */ regulator_bulk_disable(DA7219_NUM_SUPPLIES, da7219->supplies); } -- 1.9.1

5 6

[alsa-devel] [PATCH v4 0/3] ASoC: Add Multi CPU DAI support
by Shreyas NC 17 May '18

17 May '18

As discussed in [1], ASoC core supports multi codec DAIs on a DAI link. However it does not do so for CPU DAIs. So, add support for multi CPU DAIs on a DAI Link by adding multi CPU DAI in Card instantiation, suspend and resume functions, PCM ops, stream handling functions and DAPM. [1]: https://www.spinics.net/lists/alsa-devel/msg71369.html changes in v4: - Addressed review comments from Charles regarding error handling in PCM operations and other nits - Rebased on the latest for-next branch Shreyas NC (3): ASoC: Add initial support for multiple CPU DAIs ASoC: Add multiple CPU DAI support for PCM ops ASoC: Add multiple CPU DAI support in DAPM include/sound/soc.h | 6 + sound/soc/soc-core.c | 283 ++++++++++++++++++++---------- sound/soc/soc-dapm.c | 71 +++++--- sound/soc/soc-pcm.c | 487 ++++++++++++++++++++++++++++++++++----------------- 4 files changed, 573 insertions(+), 274 deletions(-) -- 2.7.4

2 5

[alsa-devel] [PATCH 0/7] slimbus: fixes and some helpers
by Srinivas Kandagatla 17 May '18

17 May '18

Hi Greg, Here is set of patches for slimbus, there are 5 fixes and two helper functions. Most of these issues were found while testing QCOM NGD SLIMBus controller with WCD9335 codec. thanks, Srini Srinivas Kandagatla (7): slimbus: core: add of_slim_device_get() helper slimbus: core: rearrange slim_eaddr structure slimbus: core: add need_tid flag to slim_msg_txn slimbus: messaging: pass correct wbuf slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy slimbus: messaging: add slim_prepare_txn() helper function slimbus: messaging: initialize completion correctly drivers/slimbus/core.c | 39 +++++++++++++++++++ drivers/slimbus/messaging.c | 92 ++++++++++++++++++++++++++++++--------------- drivers/slimbus/qcom-ctrl.c | 7 +++- drivers/slimbus/slimbus.h | 3 ++ include/linux/slimbus.h | 14 ++++--- 5 files changed, 118 insertions(+), 37 deletions(-) -- 2.16.2

2 8

[alsa-devel] LAC2018 schedule and registration online!
by Linux Audio Conference 16 May '18

16 May '18

Dear all, we're happy to announce (and you might have noticed already), that the schedule for Linux Audio Conference 2018 is live! https://lac.linuxaudio.org/2018/pages/schedule Please note, that it will still be subject to slight changes! We have prepared a registration form for attendees: https://www.ak.tu-berlin.de/index.php?id=195758 Please sign up at your earliest convenience to let us know, if you're part of the conference. Also, we'd like to draw special attention to this year's keynote, which will be held by Gianfranco Ceccolini of MOD Devices: https://lac.linuxaudio.org/2018/pages/event/102/ Looking forward to seeing you in Berlin, -- Linux Audio Conference team

1 0

[alsa-devel] [PATCH] ALSA: usb-audio: Apply rate limit to warning messages in URB complete callback
by Takashi Iwai 16 May '18

16 May '18

retire_capture_urb() may print warning messages when the given URB doesn't align, and this may flood the system log easily. Put the rate limit to the message for avoiding it. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1093485 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index dc2dfec9effd..20bed1c7a312 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -1303,7 +1303,7 @@ static void retire_capture_urb(struct snd_usb_substream *subs, if (bytes % (runtime->sample_bits >> 3) != 0) { int oldbytes = bytes; bytes = frames * stride; - dev_warn(&subs->dev->dev, + dev_warn_ratelimited(&subs->dev->dev, "Corrected urb data len. %d->%d\n", oldbytes, bytes); } -- 2.16.3

1 0

[alsa-devel] Sound is not working for my headphones although it works for Windows 10
by Faisal Ahmed Moshiur 16 May '18

16 May '18

http://www.alsa-project.org/db/?f=8864f5f90259b36ff18270e6242508f64cba4292 This contains my PC info.

2 1

[alsa-devel] Aplay Fails When Reading From stdin
by Jay Foster 16 May '18

16 May '18

I recently updated may alsa from 1.1.4.1 to 1.1.6. I now noticed that aplay does not work properly (the same as 1.1.4.1) when reading the sound file data from stdin. This might have something to do with the recent change with reading the sound file header. With the previous version of aplay, aplay would report: Playing WAVE 'stdin' : Signed 16 bit Little Endian, Rate 22050 Hz, Mono With 1.1.6, aplay reports: Playing raw data 'stdin' : Unsigned 8 bit, Rate 8000 Hz, Mono This results in static/noise output. If I explicitly add the '-f S16_LE -r 22050' options to aplay, then it does play correctly. Is this a known bug and is there a fix? Jay

2 6

Re: [alsa-devel] [PATCH v2 09/11] docs: Fix some broken references
by Mathieu Poirier 16 May '18

16 May '18

On 9 May 2018 at 07:18, Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> wrote: > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix-rst > > Manually checked if the produced result is valid, removing a few > false-positives. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> > --- > > diff --git a/Documentation/trace/coresight.txt b/Documentation/trace/coresight.txt > index 1d74ad0202b6..efbc832146e7 100644 > --- a/Documentation/trace/coresight.txt > +++ b/Documentation/trace/coresight.txt > @@ -426,5 +426,5 @@ root@genericarmv8:~# > Details on how to use the generic STM API can be found here [2]. > > [1]. Documentation/ABI/testing/sysfs-bus-coresight-devices-stm > -[2]. Documentation/trace/stm.txt > +[2]. Documentation/trace/stm.rst > [3]. https://github.com/Linaro/perf-opencsd Acked-by: Mathieu Poirier <mathieu.poirier(a)linaro.org>

1 0