March 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] Fix audio regression on rk3288
by Ezequiel Garcia 21 Mar '18

21 Mar '18

From: Ezequiel Garcia <ezequiel(a)collabora.co.uk> Currently on rk3288 boards the ASoC machine driver fails to load, breaking audio support. Apparently, the regression was introduced by commit 24069b589b02 ("ASoC: hdmi-codec: remove multi detection support") which changed the codec name. If there is a lesson here, it would be about binding drivers using strings and how fragile this is. Or maybe it's about regression testing. Or maybe there isn't a lesson. Anyway, the first patch fixes the regression; the second patch makes the machine driver selects all the codecs it; finally the third patch is just a binding documentation fix. Tested on a Radxa Rock2 Square board. Ezequiel Garcia (3): ASoC: rockchip: Fix dai_name for HDMI codec ASoC: rockchip: rk3288-hdmi-analog: Select needed codecs dt-bindings: sound: rockchip Fix compatible string in example .../devicetree/bindings/sound/rockchip,rk3288-hdmi-analog.txt | 2 +- sound/soc/rockchip/Kconfig | 3 +++ sound/soc/rockchip/rk3288_hdmi_analog.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) -- 2.16.2

2 7

[alsa-devel] [asoc:topic/amd 2/7] sound/soc//amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type
by kbuild test robot 21 Mar '18

21 Mar '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/amd head: c88d311533563e6dadc244930a36125d592f5ec5 commit: 9a60cde2dd63e10b421e87e1397641304dd1ef13 [2/7] ASoC: amd: acp-da7219-max98357: replace codec to component config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 9a60cde2dd63e10b421e87e1397641304dd1ef13 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): sound/soc//amd/acp-da7219-max98357a.c: In function 'cz_da7219_init': >> sound/soc//amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types] da7219_aad_jack_det(component, &cz_jack); ^~~~~~~~~ In file included from sound/soc//amd/acp-da7219-max98357a.c:38:0: sound/soc//amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_codec *' but argument is of type 'struct snd_soc_component *' void da7219_aad_jack_det(struct snd_soc_codec *codec, struct snd_soc_jack *jack); ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors sparse warnings: (new ones prefixed by >>) >> sound/soc/amd/acp-da7219-max98357a.c:79:29: sparse: incorrect type in argument 1 (different base types) @@ expected struct snd_soc_codec *codec @@ got strustruct snd_soc_codec *codec @@ sound/soc/amd/acp-da7219-max98357a.c:79:29: expected struct snd_soc_codec *codec sound/soc/amd/acp-da7219-max98357a.c:79:29: got struct snd_soc_component *component sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init': sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types] da7219_aad_jack_det(component, &cz_jack); ^~~~~~~~~ In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0: sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_codec *' but argument is of type 'struct snd_soc_component *' void da7219_aad_jack_det(struct snd_soc_codec *codec, struct snd_soc_jack *jack); ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/da7219_aad_jack_det +79 sound/soc//amd/acp-da7219-max98357a.c 45 46 static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) 47 { 48 int ret; 49 struct snd_soc_card *card = rtd->card; 50 struct snd_soc_dai *codec_dai = rtd->codec_dai; 51 struct snd_soc_component *component = codec_dai->component; 52 53 dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name); 54 55 ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, 56 CZ_PLAT_CLK, SND_SOC_CLOCK_IN); 57 if (ret < 0) { 58 dev_err(rtd->dev, "can't set codec sysclk: %d\n", ret); 59 return ret; 60 } 61 62 ret = snd_soc_dai_set_pll(codec_dai, 0, DA7219_SYSCLK_PLL, 63 CZ_PLAT_CLK, MCLK_RATE); 64 if (ret < 0) { 65 dev_err(rtd->dev, "can't set codec pll: %d\n", ret); 66 return ret; 67 } 68 69 ret = snd_soc_card_jack_new(card, "Headset Jack", 70 SND_JACK_HEADPHONE | SND_JACK_MICROPHONE | 71 SND_JACK_BTN_0 | SND_JACK_BTN_1 | 72 SND_JACK_BTN_2 | SND_JACK_BTN_3, 73 &cz_jack, NULL, 0); 74 if (ret) { 75 dev_err(card->dev, "HP jack creation failed %d\n", ret); 76 return ret; 77 } 78 > 79 da7219_aad_jack_det(component, &cz_jack); 80 81 return 0; 82 } 83 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 2

[alsa-devel] [PATCH] ASoC: rsnd: set pm_ops in hibernate-compatible way
by Nikita Yushchenko 21 Mar '18

21 Mar '18

Use SET_SYSTEM_SLEEP_PM_OPS() macro instead of direct assignment to .suspend and .resume fields. This makes driver working after restore from hibernation. Signed-off-by: Nikita Yushchenko <nikita.yoush(a)cogentembedded.com> --- sound/soc/sh/rcar/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 64d5ecb86528..dabf9a35c25c 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -1560,8 +1560,7 @@ static int rsnd_resume(struct device *dev) } static const struct dev_pm_ops rsnd_pm_ops = { - .suspend = rsnd_suspend, - .resume = rsnd_resume, + SET_SYSTEM_SLEEP_PM_OPS(rsnd_suspend, rsnd_resume) }; static struct platform_driver rsnd_driver = { -- 2.11.0

2 1

[alsa-devel] [PATCH] linux-next: ASoC: mediatek: mt2701: Fix a typo in printk
by Masanari Iida 21 Mar '18

21 Mar '18

This patch fixes a spelling typo in printk Signed-off-by: Masanari Iida <standby24x7(a)gmail.com> --- sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c index f7e0702d92f8..f2eb4c7f94e8 100644 --- a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c +++ b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c @@ -343,7 +343,7 @@ static int mt2701_btmrg_hw_params(struct snd_pcm_substream *substream, stream_fs = params_rate(params); if ((stream_fs != 8000) && (stream_fs != 16000)) { - dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n", + dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n", __func__, stream_fs); return -EINVAL; } -- 2.16.2.520.gd0db9edba005

2 2

[alsa-devel] [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)
by Geert Uytterhoeven 20 Mar '18

20 Mar '18

Hi all, If NO_DMA=y, get_dma_ops() returns a reference to the non-existing symbol bad_dma_ops, thus causing a link failure if it is ever used. The intention of this is twofold: 1. To catch users of the DMA API on systems that do no support the DMA mapping API, 2. To avoid building drivers that cannot work on such systems anyway. However, the disadvantage is that we have to keep on adding dependencies on HAS_DMA all over the place. Thanks to the COMPILE_TEST symbol, lots of drivers now depend on one or more platform dependencies (that imply HAS_DMA) || COMPILE_TEST, thus already covering intention #2. Having to add an explicit dependency on HAS_DMA here is cumbersome, and hinders compile-testing. Hence I think the time is ripe to reconsider the link failure. Patch series "[PATCH v2 0/5] Allow compile-testing NO_DMA (core)" (https://lkml.org/lkml/2018/3/16/435) already: - Changed get_dma_ops() to return NULL instead, - Added a few more dummies to enable compile-testing. This patch series: - Removes dependencies on HAS_DMA for symbols that already have platform dependencies implying HAS_DMA. To avoid allmodconfig/allyesconfig regressions on NO_DMA=y platforms, this (drivers) series should be applied after the previous (core) series (but not many people may notice/care ;-) Changes compared to v1: - Add Reviewed-by, Acked-by, - Drop dependency of SND_SOC_LPASS_IPQ806X on HAS_DMA, - Drop dependency of VIDEOBUF{,2}_DMA_{CONTIG,SG} on HAS_DMA, - Drop new dependencies of VIDEO_IPU3_CIO2, DVB_C8SECTPFE, and MTD_NAND_MARVELL on HAS_DMA, - Split in per-subsystem patches, - Split-off the core part in a separate series. This series is against v4.16-rc5. It can also be found at https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h… It has been compile-tested with allmodconfig and allyesconfig for m68k/sun3, and has received attention from the kbuild test robot. Thanks! Geert Uytterhoeven (21): ASoC: Remove depends on HAS_DMA in case of platform dependency ata: Remove depends on HAS_DMA in case of platform dependency crypto: Remove depends on HAS_DMA in case of platform dependency fbdev: Remove depends on HAS_DMA in case of platform dependency firewire: Remove depends on HAS_DMA in case of platform dependency fpga: Remove depends on HAS_DMA in case of platform dependency i2c: Remove depends on HAS_DMA in case of platform dependency iio: adc: Remove depends on HAS_DMA in case of platform dependency iommu: Remove depends on HAS_DMA in case of platform dependency lightnvm: Remove depends on HAS_DMA in case of platform dependency mailbox: Remove depends on HAS_DMA in case of platform dependency media: Remove depends on HAS_DMA in case of platform dependency mmc: Remove depends on HAS_DMA in case of platform dependency mtd: Remove depends on HAS_DMA in case of platform dependency net: Remove depends on HAS_DMA in case of platform dependency remoteproc: Remove depends on HAS_DMA in case of platform dependency scsi: hisi_sas: Remove depends on HAS_DMA in case of platform dependency serial: Remove depends on HAS_DMA in case of platform dependency spi: Remove depends on HAS_DMA in case of platform dependency staging: vc04_services: Remove depends on HAS_DMA in case of platform dependency usb: Remove depends on HAS_DMA in case of platform dependency drivers/ata/Kconfig | 2 -- drivers/crypto/Kconfig | 14 +++------ drivers/firewire/Kconfig | 1 - drivers/fpga/Kconfig | 1 - drivers/i2c/busses/Kconfig | 3 -- drivers/iio/adc/Kconfig | 2 -- drivers/iommu/Kconfig | 5 ++-- drivers/lightnvm/Kconfig | 2 +- drivers/mailbox/Kconfig | 2 -- drivers/media/common/videobuf2/Kconfig | 2 -- drivers/media/pci/dt3155/Kconfig | 1 - drivers/media/pci/intel/ipu3/Kconfig | 1 - drivers/media/pci/solo6x10/Kconfig | 1 - drivers/media/pci/sta2x11/Kconfig | 1 - drivers/media/pci/tw5864/Kconfig | 1 - drivers/media/pci/tw686x/Kconfig | 1 - drivers/media/platform/Kconfig | 40 ++++++++----------------- drivers/media/platform/am437x/Kconfig | 2 +- drivers/media/platform/atmel/Kconfig | 4 +-- drivers/media/platform/blackfin/Kconfig | 1 - drivers/media/platform/davinci/Kconfig | 6 ---- drivers/media/platform/marvell-ccic/Kconfig | 3 +- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/soc_camera/Kconfig | 3 +- drivers/media/platform/sti/c8sectpfe/Kconfig | 2 +- drivers/media/v4l2-core/Kconfig | 2 -- drivers/mmc/host/Kconfig | 10 ++----- drivers/mtd/nand/Kconfig | 8 ++--- drivers/mtd/spi-nor/Kconfig | 2 +- drivers/net/ethernet/amd/Kconfig | 2 +- drivers/net/ethernet/apm/xgene-v2/Kconfig | 1 - drivers/net/ethernet/apm/xgene/Kconfig | 1 - drivers/net/ethernet/arc/Kconfig | 6 ++-- drivers/net/ethernet/broadcom/Kconfig | 2 -- drivers/net/ethernet/calxeda/Kconfig | 2 +- drivers/net/ethernet/hisilicon/Kconfig | 2 +- drivers/net/ethernet/marvell/Kconfig | 8 ++--- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +- drivers/net/ethernet/renesas/Kconfig | 2 -- drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 - drivers/net/wireless/quantenna/qtnfmac/Kconfig | 2 +- drivers/remoteproc/Kconfig | 1 - drivers/scsi/hisi_sas/Kconfig | 2 +- drivers/spi/Kconfig | 12 ++------ drivers/staging/media/davinci_vpfe/Kconfig | 1 - drivers/staging/media/omap4iss/Kconfig | 1 - drivers/staging/vc04_services/Kconfig | 1 - drivers/tty/serial/Kconfig | 4 --- drivers/usb/gadget/udc/Kconfig | 4 +-- drivers/usb/mtu3/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 3 +- sound/soc/bcm/Kconfig | 3 +- sound/soc/kirkwood/Kconfig | 1 - sound/soc/pxa/Kconfig | 1 - sound/soc/qcom/Kconfig | 7 ++--- 55 files changed, 56 insertions(+), 143 deletions(-) -- 2.7.4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

15 47

[alsa-devel] [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated
by Krzysztof Kozlowski 20 Mar '18

20 Mar '18

Compatible for XU4 audio is not being used. Instead the board uses the same compatible as XU3. The devices are now just compatible so they should use the same value. Mark "hardkernel,odroid-xu4-audio" as being deprecated so in this future could be removed to limit useless properties. Additionally add older compatibles appearing in the bindings. Signed-off-by: Krzysztof Kozlowski <krzk(a)kernel.org> --- Changes since v1: 1. Correct typo XU4->XU3 for one deprecated compatible. --- Documentation/devicetree/bindings/sound/samsung,odroid.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.txt b/Documentation/devicetree/bindings/sound/samsung,odroid.txt index f35a2694eb04..e9da2200e173 100644 --- a/Documentation/devicetree/bindings/sound/samsung,odroid.txt +++ b/Documentation/devicetree/bindings/sound/samsung,odroid.txt @@ -3,7 +3,9 @@ Samsung Exynos Odroid XU3/XU4 audio complex with MAX98090 codec Required properties: - compatible - "hardkernel,odroid-xu3-audio" - for Odroid XU3 board, - "hardkernel,odroid-xu4-audio" - for Odroid XU4 board + "hardkernel,odroid-xu4-audio" - for Odroid XU4 board (deprecated), + "samsung,odroid-xu3-audio" - for Odroid XU3 board (deprecated), + "samsung,odroid-xu4-audio" - for Odroid XU4 board (deprecated) - model - the user-visible name of this sound complex - clocks - should contain entries matching clock names in the clock-names property -- 2.14.1

3 7

[alsa-devel] [alsa-lib][RESEND][PATCH] pcm: add set and get methods for no-rewind flag
by Sriram Periyasamy 20 Mar '18

20 Mar '18

From: Ramesh Babu <ramesh.babu(a)intel.com> Add functions to set/get no-rewind flag Signed-off-by: Ramesh Babu <ramesh.babu(a)intel.com> Signed-off-by: Sriram Periyasamy <sriramx.periyasamy(a)intel.com> --- Please find the reference for previous discussion at [1]. [1] https://patchwork.kernel.org/patch/10191481/ include/pcm.h | 2 ++ include/sound/asound.h | 1 + src/pcm/pcm.c | 40 ++++++++++++++++++++++++++++++++++++++++ src/pcm/pcm_local.h | 1 + 4 files changed, 44 insertions(+) diff --git a/include/pcm.h b/include/pcm.h index e2a53435caab..c6af884607ae 100644 --- a/include/pcm.h +++ b/include/pcm.h @@ -805,6 +805,8 @@ int snd_pcm_hw_params_set_export_buffer(snd_pcm_t *pcm, snd_pcm_hw_params_t *par int snd_pcm_hw_params_get_export_buffer(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int *val); int snd_pcm_hw_params_set_period_wakeup(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int val); int snd_pcm_hw_params_get_period_wakeup(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int *val); +int snd_pcm_hw_params_set_no_rewind(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int val); +int snd_pcm_hw_params_get_no_rewind(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int *val); int snd_pcm_hw_params_get_period_time(const snd_pcm_hw_params_t *params, unsigned int *val, int *dir); int snd_pcm_hw_params_get_period_time_min(const snd_pcm_hw_params_t *params, unsigned int *val, int *dir); diff --git a/include/sound/asound.h b/include/sound/asound.h index 6041cab27a23..35fd50ec5395 100644 --- a/include/sound/asound.h +++ b/include/sound/asound.h @@ -375,6 +375,7 @@ typedef int snd_pcm_hw_param_t; #define SNDRV_PCM_HW_PARAMS_NORESAMPLE (1<<0) /* avoid rate resampling */ #define SNDRV_PCM_HW_PARAMS_EXPORT_BUFFER (1<<1) /* export buffer */ #define SNDRV_PCM_HW_PARAMS_NO_PERIOD_WAKEUP (1<<2) /* disable period wakeups */ +#define SNDRV_PCM_HW_PARAMS_NO_REWINDS (1<<3) /* disable rewinds */ struct snd_interval { unsigned int min, max; diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index ed47cb516c73..3346609fdf6d 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -4826,6 +4826,46 @@ int snd_pcm_hw_params_get_period_wakeup(snd_pcm_t *pcm, snd_pcm_hw_params_t *par } /** + * \brief Configure no-rewind flag through configuration space + * \param pcm PCM handle + * \param params Configuration space + * \param val 0 = disable (default), 1 = enable (default) no-rewind flag + * \return Zero on success, otherwise a negative error code. + * + * This function can be called to inform driver about application uses rewind or not + * + * Based on no-rewind flag, underlying driver could take decision on buffering scheme. + */ + +/* TODO: Invert the logic with function name set_rewind */ +int snd_pcm_hw_params_set_no_rewind(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int val) +{ + assert(pcm && params); + + if (val) { + params->flags |= SND_PCM_HW_PARAMS_NO_REWINDS; + } else + params->flags &= ~SND_PCM_HW_PARAMS_NO_REWINDS; + params->rmask = ~0; + + return snd_pcm_hw_refine(pcm, params); +} + +/** + * \brief Extract no-rewind flag from a configuration space + * \param pcm PCM handle + * \param params Configuration space + * \param val 0 = disabled, 1 = enabled no-rewind flag + * \return Zero on success, otherwise a negative error code. + */ +int snd_pcm_hw_params_get_no_rewind(snd_pcm_t *pcm, snd_pcm_hw_params_t *params, unsigned int *val) +{ + assert(pcm && params && val); + *val = params->flags & SND_PCM_HW_PARAMS_NO_REWINDS ? 0 : 1; + return 0; +} + +/** * \brief Extract period time from a configuration space * \param params Configuration space * \param val Returned approximate period duration in us diff --git a/src/pcm/pcm_local.h b/src/pcm/pcm_local.h index d52229d8ddea..2b3cae5b93f5 100644 --- a/src/pcm/pcm_local.h +++ b/src/pcm/pcm_local.h @@ -103,6 +103,7 @@ #define SND_PCM_HW_PARAMS_NORESAMPLE SNDRV_PCM_HW_PARAMS_NORESAMPLE #define SND_PCM_HW_PARAMS_EXPORT_BUFFER SNDRV_PCM_HW_PARAMS_EXPORT_BUFFER #define SND_PCM_HW_PARAMS_NO_PERIOD_WAKEUP SNDRV_PCM_HW_PARAMS_NO_PERIOD_WAKEUP +#define SND_PCM_HW_PARAMS_NO_REWINDS SNDRV_PCM_HW_PARAMS_NO_REWINDS #define SND_PCM_INFO_MONOTONIC 0x80000000 -- 2.7.4

1 0

[alsa-devel] [alsa-utils][RESEND][PATCH] Add support for no-rewind flag in aplay utility
by Sriram Periyasamy 20 Mar '18

20 Mar '18

From: Ramesh Babu <ramesh.babu(a)intel.com> The "no-rewind" flag is introduced in alsa. Application can use this flag to assure kernel driver that rewind won't be exercised. Driver could use this flag to alter it's buffering scheme to optimize power and performance. Signed-off-by: Ramesh Babu <ramesh.babu(a)intel.com> Signed-off-by: Sriram Periyasamy <sriramx.periyasamy(a)intel.com> --- Please find the reference for previous discussion at [1]. [1] https://patchwork.kernel.org/patch/10191483/ aplay/aplay.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index bbd7fffa04fc..6eb9d3b04d92 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -108,6 +108,7 @@ static snd_pcm_stream_t stream = SND_PCM_STREAM_PLAYBACK; static int mmap_flag = 0; static int interleaved = 1; static int nonblock = 0; +static int no_rewind = 0; static volatile sig_atomic_t in_aborting = 0; static u_char *audiobuf = NULL; static snd_pcm_uframes_t chunk_size = 0; @@ -229,6 +230,7 @@ _("Usage: %s [OPTION]... [FILE]...\n" "-I, --separate-channels one file for each channel\n" "-i, --interactive allow interactive operation from stdin\n" "-m, --chmap=ch1,ch2,.. Give the channel map to override or follow\n" +"-w, --no-rewind enables no rewind mode\n" " --disable-resample disable automatic rate resample\n" " --disable-channels disable automatic channel conversions\n" " --disable-format disable automatic format conversions\n" @@ -470,7 +472,7 @@ int main(int argc, char *argv[]) { int duration_or_sample = 0; int option_index; - static const char short_options[] = "hnlLD:qt:c:f:r:d:s:MNF:A:R:T:B:vV:IPCi" + static const char short_options[] = "hnlLD:qt:c:f:r:d:s:w:MNF:A:R:T:B:vV:IPCi" #ifdef CONFIG_SUPPORT_CHMAP "m:" #endif @@ -514,6 +516,7 @@ int main(int argc, char *argv[]) {"process-id-file", 1, 0, OPT_PROCESS_ID_FILE}, {"use-strftime", 0, 0, OPT_USE_STRFTIME}, {"interactive", 0, 0, 'i'}, + {"no-rewind", 0, 0, 'w'}, {"dump-hw-params", 0, 0, OPT_DUMP_HWPARAMS}, {"fatal-errors", 0, 0, OPT_FATAL_ERRORS}, #ifdef CONFIG_SUPPORT_CHMAP @@ -753,6 +756,9 @@ int main(int argc, char *argv[]) case 'i': interactive = 1; break; + case 'w': + no_rewind = 1; + break; case OPT_DISABLE_RESAMPLE: open_mode |= SND_PCM_NO_AUTO_RESAMPLE; break; @@ -1396,6 +1402,12 @@ static void set_params(void) &buffer_frames); } assert(err >= 0); + + if (no_rewind) { + err = snd_pcm_hw_params_set_no_rewind(handle, params, 1); + assert(err >= 0); + } + monotonic = snd_pcm_hw_params_is_monotonic(params); can_pause = snd_pcm_hw_params_can_pause(params); err = snd_pcm_hw_params(handle, params); -- 2.7.4

1 0

[alsa-devel] [PATCH v2 1/2] ASoC: AMD: Use single dai for da7219 playback and capture
by Akshu Agrawal 20 Mar '18

20 Mar '18

BT I2S is a bi-directional dai, we will use the same cpu dai for playback and capture. V2: reworded the commit message. TEST=aplay -D hw:0,0 -vv <file> arecord -D hw:0,0 -f dat -d 5 -vv <file> Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index bbe0f10..d07c2a1 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -124,8 +124,8 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) static struct snd_soc_dai_link cz_dai_7219_98357[] = { { - .name = "amd-da7219-play", - .stream_name = "Playback", + .name = "amd-da7219-play-cap", + .stream_name = "Playback and Capture", .platform_name = "acp_audio_dma.0.auto", .cpu_dai_name = "designware-i2s.3.auto", .codec_dai_name = "da7219-hifi", @@ -134,16 +134,6 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) | SND_SOC_DAIFMT_CBM_CFM, .init = cz_da7219_init, .dpcm_playback = 1, - }, - { - .name = "amd-da7219-cap", - .stream_name = "Capture", - .platform_name = "acp_audio_dma.0.auto", - .cpu_dai_name = "designware-i2s.4.auto", - .codec_dai_name = "da7219-hifi", - .codec_name = "i2c-DLGS7219:00", - .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF - | SND_SOC_DAIFMT_CBM_CFM, .dpcm_capture = 1, .ops = &cz_da7219_cap_ops, }, -- 1.9.1

2 2

[alsa-devel] [PATCH v2 1/3] ASoC: AMD: Use single dai for da7219 playback and capture
by Akshu Agrawal 20 Mar '18

20 Mar '18

BT I2S is a bi-directional dai, we will use the same cpu dai for playback and capture. V2: reworded the commit message. TEST=aplay -D hw:0,0 -vv <file> arecord -D hw:0,0 -f dat -d 5 -vv <file> Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- sound/soc/amd/acp-da7219-max98357a.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index bbe0f10..d07c2a1 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -124,8 +124,8 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) static struct snd_soc_dai_link cz_dai_7219_98357[] = { { - .name = "amd-da7219-play", - .stream_name = "Playback", + .name = "amd-da7219-play-cap", + .stream_name = "Playback and Capture", .platform_name = "acp_audio_dma.0.auto", .cpu_dai_name = "designware-i2s.3.auto", .codec_dai_name = "da7219-hifi", @@ -134,16 +134,6 @@ static int cz_fe_startup(struct snd_pcm_substream *substream) | SND_SOC_DAIFMT_CBM_CFM, .init = cz_da7219_init, .dpcm_playback = 1, - }, - { - .name = "amd-da7219-cap", - .stream_name = "Capture", - .platform_name = "acp_audio_dma.0.auto", - .cpu_dai_name = "designware-i2s.4.auto", - .codec_dai_name = "da7219-hifi", - .codec_name = "i2c-DLGS7219:00", - .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF - | SND_SOC_DAIFMT_CBM_CFM, .dpcm_capture = 1, .ops = &cz_da7219_cap_ops, }, -- 1.9.1

2 3