February 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: rt5665: remove rt5668 support
by Bard Liao 12 Feb '18

12 Feb '18

Remove rt5668 support from rt5665 codec driver since rt5668 will not go into mass production. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- Documentation/devicetree/bindings/sound/rt5665.txt | 4 ++-- sound/soc/codecs/rt5665.c | 5 ----- sound/soc/codecs/rt5665.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/rt5665.txt b/Documentation/devicetree/bindings/sound/rt5665.txt index 419c892..8df1705 100644 --- a/Documentation/devicetree/bindings/sound/rt5665.txt +++ b/Documentation/devicetree/bindings/sound/rt5665.txt @@ -1,10 +1,10 @@ -RT5665/RT5666/RT5668 audio CODEC +RT5665/RT5666 audio CODEC This device supports I2C only. Required properties: -- compatible : One of "realtek,rt5665", "realtek,rt5666" or "realtek,rt5668". +- compatible : One of "realtek,rt5665", "realtek,rt5666". - reg : The I2C address of the device. diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c index f05d362..e1b558b 100644 --- a/sound/soc/codecs/rt5665.c +++ b/sound/soc/codecs/rt5665.c @@ -4828,9 +4828,6 @@ static int rt5665_i2c_probe(struct i2c_client *i2c, case 0x0: rt5665->id = CODEC_5666; break; - case 0x6: - rt5665->id = CODEC_5668; - break; case 0x3: default: rt5665->id = CODEC_5665; @@ -4963,7 +4960,6 @@ static void rt5665_i2c_shutdown(struct i2c_client *client) static const struct of_device_id rt5665_of_match[] = { {.compatible = "realtek,rt5665"}, {.compatible = "realtek,rt5666"}, - {.compatible = "realtek,rt5668"}, {}, }; MODULE_DEVICE_TABLE(of, rt5665_of_match); @@ -4973,7 +4969,6 @@ MODULE_DEVICE_TABLE(of, rt5665_of_match); static const struct acpi_device_id rt5665_acpi_match[] = { {"10EC5665", 0,}, {"10EC5666", 0,}, - {"10EC5668", 0,}, {}, }; MODULE_DEVICE_TABLE(acpi, rt5665_acpi_match); diff --git a/sound/soc/codecs/rt5665.h b/sound/soc/codecs/rt5665.h index 5ddebd6..5abff0f 100644 --- a/sound/soc/codecs/rt5665.h +++ b/sound/soc/codecs/rt5665.h @@ -1978,7 +1978,6 @@ enum { enum { CODEC_5665, CODEC_5666, - CODEC_5668, }; /* filter mask */ -- 2.7.4

2 1

[alsa-devel] Applied "ASoC: soc-core: remove error due to probe deferral" to the asoc tree
by Mark Brown 12 Feb '18

12 Feb '18

The patch ASoC: soc-core: remove error due to probe deferral has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 6b49087912e311bc884d36874592595508630b88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Hundeb=C3=B8ll?= <mnhu(a)prevas.dk> Date: Thu, 1 Feb 2018 11:09:41 +0100 Subject: [PATCH] ASoC: soc-core: remove error due to probe deferral MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Deferred probes shouldn't cause error messages in the boot log, so change the dev_err() to the more harmless dev_info(). Signed-off-by: Martin Hundebøll <mnhu(a)prevas.dk> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/soc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 96c44f6576c9..60a542f35dbd 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1100,8 +1100,8 @@ static int soc_bind_dai_link(struct snd_soc_card *card, cpu_dai_component.dai_name = dai_link->cpu_dai_name; rtd->cpu_dai = snd_soc_find_dai(&cpu_dai_component); if (!rtd->cpu_dai) { - dev_err(card->dev, "ASoC: CPU DAI %s not registered\n", - dai_link->cpu_dai_name); + dev_info(card->dev, "ASoC: CPU DAI %s not registered\n", + dai_link->cpu_dai_name); goto _err_defer; } snd_soc_rtdcom_add(rtd, rtd->cpu_dai->component); -- 2.16.1

1 0

[alsa-devel] [PATCH 0/2] ASoC: stm32: spdifrx: change dai name
by Olivier Moysan 12 Feb '18

12 Feb '18

This patchset changes spdifrx dai name and fixes a typo issue. Olivier Moysan (2): ASoC: stm32: spdifrx: fix typo in function name. ASoC: stm32: spdifrx: Use default dai name sound/soc/stm/stm32_spdifrx.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 1.9.1

2 4

[alsa-devel] [PATCH] ALSA: usb: add more device quirks for USB DSD devices
by Daniel Mack 12 Feb '18

12 Feb '18

Add some more devices that need quirks to handle DSD modes correctly. Signed-off-by: Daniel Mack <daniel(a)zonque.org> Reported-and-tested-by: Thomas Gresens <tgresens(a)gmail.com> --- sound/usb/quirks.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index a66ef5777887..ea8f3de92fa4 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1363,8 +1363,11 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, return SNDRV_PCM_FMTBIT_DSD_U32_BE; break; - /* Amanero Combo384 USB interface with native DSD support */ - case USB_ID(0x16d0, 0x071a): + /* Amanero Combo384 USB based DACs with native DSD support */ + case USB_ID(0x16d0, 0x071a): /* Amanero - Combo384 */ + case USB_ID(0x2ab6, 0x0004): /* T+A DAC8DSD-V2.0, MP1000E-V2.0, MP2000R-V2.0, MP2500R-V2.0, MP3100HV-V2.0 */ + case USB_ID(0x2ab6, 0x0005): /* T+A USB HD Audio 1 */ + case USB_ID(0x2ab6, 0x0006): /* T+A USB HD Audio 2 */ if (fp->altsetting == 2) { switch (le16_to_cpu(chip->dev->descriptor.bcdDevice)) { case 0x199: -- 2.14.3

2 1

Re: [alsa-devel] [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204
by Takashi Iwai 12 Feb '18

12 Feb '18

On Sat, 03 Feb 2018 15:42:40 +0100, Lassi Ylikojola wrote: > > Add quirk to ensure a sync endpoint is properly configured. > This patch is a fix for same symptoms on Behringer UFX1204 as patch > from Albertto Aquirre on Dec 8 2016 for Axe-Fx II. > > Signed-off-by: Lassi Ylikojola <lassi.ylikojola(a)gmail.com> The patch doesn't seem applied cleanly to the latest tree. Could you check it and repost with the proper patch for the latest Linus tree? thanks, Takashi

2 2

Re: [alsa-devel] [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97
by Takashi Iwai 12 Feb '18

12 Feb '18

On Fri, 09 Feb 2018 00:20:21 +0100, Ulf Magnusson wrote: > > On Fri, Feb 09, 2018 at 12:15:36AM +0100, Ulf Magnusson wrote: > > The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol > > AC97. > > > > Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the > > select was put in by mistake and can be safely removed, with no other > > changes required. Remove it. > > > > Signed-off-by: Ulf Magnusson <ulfalizer(a)gmail.com> > > --- > > sound/ac97/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/sound/ac97/Kconfig b/sound/ac97/Kconfig > > index f8a64e15e5bf..baa5f8ef89d2 100644 > > --- a/sound/ac97/Kconfig > > +++ b/sound/ac97/Kconfig > > @@ -5,7 +5,6 @@ > > > > config AC97_BUS_NEW > > tristate > > - select AC97 > > help > > This is the new AC97 bus type, successor of AC97_BUS. The ported > > drivers which benefit from the AC97 automatic probing should "select" > > -- > > 2.14.1 > > > > I didn't have a particular tree in mind for this patchset by the way. > Feel free to take the patch in wherever it makes sense. Applied now, thanks. Takashi

1 0

[alsa-devel] arecord read error, input/output error in embedded linux project
by Christopher. Sierra Melendez 12 Feb '18

12 Feb '18

Hello, Did this issue solved? I have same problem… Enviado desde Correo<https://go.microsoft.com/fwlink/?LinkId=550986> para Windows 10

1 0

[alsa-devel] [PATCH RESEND] sound: omap-twl4030: do not complain on -EPROBE_DEFER when initializing
by Ladislav Michl 11 Feb '18

11 Feb '18

Don't complain on -EPROBE_DEFER when when initializing, the driver probe will be retried later. Signed-off-by: Ladislav Michl <ladis(a)linux-mips.org> --- Note: Just a resend of patch from 9 Nov 2016 as there were no reply by then. sound/soc/omap/omap-twl4030.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/omap/omap-twl4030.c b/sound/soc/omap/omap-twl4030.c index cccc316743fa..7c1f71884768 100644 --- a/sound/soc/omap/omap-twl4030.c +++ b/sound/soc/omap/omap-twl4030.c @@ -322,8 +322,10 @@ static int omap_twl4030_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) { - dev_err(&pdev->dev, "devm_snd_soc_register_card() failed: %d\n", - ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "devm_snd_soc_register_card() failed: %d\n", + ret); return ret; } -- 2.15.1

2 1

[alsa-devel] Fixing the CA0132 driver for Sound Blaster Z
by Connor McAdams 10 Feb '18

10 Feb '18

Hi, first time here and first time working on any sort of Kernel driver, so I hope I'm doing things right by asking my question through this list. I have managed to get audio working for the Creative Sound Blaster Z by reverse engineering the driver and firmware from Windows. I created a program to capture the HDA verbs as they happen in Windows through QEMU using vfio pci passthrough. Now, here's where I'm kind of stumped. I created a program to send the commands that route the audio to it's output on the card. If I run these commands after the driver has already loaded in Linux, it works fine and I get audio. However, if I run these commands inside of the driver, there is no audio. There is an 8051 cpu onboard, and I can dump the contents of its memory through HDA-verbs. I compared dumps of the 8051 while audio is working with the script to dumps when the audio is broken from putting the commands inside of the driver. Just about everything is the same, except for a region I have figured out has to do with the streams. Each audio stream seems to have an ID, and for some reason, if the commands are run inside of the driver, it seems like the stream ID's get messed with. My current theory is that the streams are assigned in order of streams started. So, after my command to start audio, it expects the next stream to be the output audio stream. It also seems like compared to Windows, a lot more stream commands are used. Maybe extra streams are being initiated that are unused, and are interfering with the card. So, my question is, how would I go about starting a stream, maybe like a dummy stream, so it is assigned properly? Are there any examples of this? If someone could point me to where streams are even initiated it would be helpful. My next question is the legality of distributing the firmware. I was able to pull the Sound Blaster Z's firmware from the Windows driver file. Since that is a publicly available file, is it legal to redistribute? I have no experience with this kind of thing. Maybe someone here has someone within Creative I could ask or something. Anyways, like I said, this is my first time doing anything like this. Please correct me if I've done anything wrong, and let me know if anyone needs to see my current driver. Thanks, Connor M.

1 0

[alsa-devel] [PATCH] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication
by Donglin Peng 09 Feb '18

09 Feb '18

There is some duplicate code in soc-core.c,and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/soc-core.c | 51 +++++++++------------------------------------------ 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 96c44f6576c9..cb52d1e8e0b9 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -349,33 +349,22 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) "ASoC: Failed to create codec register debugfs file\n"); } -static int codec_list_seq_show(struct seq_file *m, void *v) +static int codec_list_show(struct seq_file *s, void *v) { struct snd_soc_codec *codec; mutex_lock(&client_mutex); list_for_each_entry(codec, &codec_list, list) - seq_printf(m, "%s\n", codec->component.name); + seq_printf(s, "%s\n", codec->component.name); mutex_unlock(&client_mutex); return 0; } +DEFINE_SHOW_ATTRIBUTE(codec_list); -static int codec_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, codec_list_seq_show, NULL); -} - -static const struct file_operations codec_list_fops = { - .open = codec_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - -static int dai_list_seq_show(struct seq_file *m, void *v) +static int dai_list_show(struct seq_file *s, void *v) { struct snd_soc_component *component; struct snd_soc_dai *dai; @@ -384,50 +373,28 @@ static int dai_list_seq_show(struct seq_file *m, void *v) list_for_each_entry(component, &component_list, list) list_for_each_entry(dai, &component->dai_list, list) - seq_printf(m, "%s\n", dai->name); + seq_printf(s, "%s\n", dai->name); mutex_unlock(&client_mutex); return 0; } +DEFINE_SHOW_ATTRIBUTE(dai_list); -static int dai_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, dai_list_seq_show, NULL); -} - -static const struct file_operations dai_list_fops = { - .open = dai_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - -static int platform_list_seq_show(struct seq_file *m, void *v) +static int platform_list_show(struct seq_file *s, void *v) { struct snd_soc_platform *platform; mutex_lock(&client_mutex); list_for_each_entry(platform, &platform_list, list) - seq_printf(m, "%s\n", platform->component.name); + seq_printf(s, "%s\n", platform->component.name); mutex_unlock(&client_mutex); return 0; } - -static int platform_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, platform_list_seq_show, NULL); -} - -static const struct file_operations platform_list_fops = { - .open = platform_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(platform_list); static void soc_init_card_debugfs(struct snd_soc_card *card) { -- 2.16.1

2 6