February 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] usleep_range without a range
by Joe Perches 12 Feb '18

12 Feb '18

scheduling can generally be better when these values are not identical. Perhaps these ranges should be expanded. $ git grep -P -n "usleep_range\s*$\s*([\w\.\>\-]+)\s*,\s*\1\s*$" drivers/clk/ux500/clk-sysctrl.c:45: usleep_range(clk->enable_delay_us, clk->enable_delay_us); drivers/cpufreq/pmac64-cpufreq.c:140: usleep_range(1000, 1000); drivers/cpufreq/pmac64-cpufreq.c:239: usleep_range(10000, 10000); /* should be faster , to fix */ drivers/cpufreq/pmac64-cpufreq.c:284: usleep_range(500, 500); drivers/media/i2c/smiapp/smiapp-core.c:1228: usleep_range(1000, 1000); drivers/media/i2c/smiapp/smiapp-core.c:1235: usleep_range(1000, 1000); drivers/media/i2c/smiapp/smiapp-core.c:1240: usleep_range(sleep, sleep); drivers/media/i2c/smiapp/smiapp-core.c:1387: usleep_range(5000, 5000); drivers/media/i2c/smiapp/smiapp-quirk.c:205: usleep_range(2000, 2000); drivers/media/i2c/smiapp/smiapp-regs.c:279: usleep_range(2000, 2000); drivers/power/supply/ab8500_fg.c:643: usleep_range(100, 100); drivers/staging/rtl8192u/r819xU_phy.c:180: usleep_range(1000, 1000); drivers/staging/rtl8192u/r819xU_phy.c:736: usleep_range(1000, 1000); drivers/staging/rtl8192u/r819xU_phy.c:740: usleep_range(1000, 1000); sound/soc/codecs/ab8500-codec.c:1065: usleep_range(AB8500_ANC_SM_DELAY, AB8500_ANC_SM_DELAY); sound/soc/codecs/ab8500-codec.c:1068: usleep_range(AB8500_ANC_SM_DELAY, AB8500_ANC_SM_DELAY);

1 0

[alsa-devel] [asoc:topic/wm9713 1/1] sound/soc/codecs/wm9713.c:1219:18: error: implicit declaration of function 'snd_soc_new_ac97_component'
by kbuild test robot 12 Feb '18

12 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm9713 head: 807cef2d327a5148d456d9c4966bfb9b2785ffc8 commit: 807cef2d327a5148d456d9c4966bfb9b2785ffc8 [1/1] ASoC: wm9713: replace codec to component config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 807cef2d327a5148d456d9c4966bfb9b2785ffc8 # save the attached .config to linux build tree make.cross ARCH=openrisc All error/warnings (new ones prefixed by >>): sound/soc/codecs/wm9713.c: In function 'wm9713_soc_probe': >> sound/soc/codecs/wm9713.c:1219:18: error: implicit declaration of function 'snd_soc_new_ac97_component' [-Werror=implicit-function-declaration] wm9713->ac97 = snd_soc_new_ac97_component(component, WM9713_VENDOR_ID, ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> sound/soc/codecs/wm9713.c:1219:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion] wm9713->ac97 = snd_soc_new_ac97_component(component, WM9713_VENDOR_ID, ^ >> sound/soc/codecs/wm9713.c:1225:4: error: implicit declaration of function 'snd_soc_free_ac97_component' [-Werror=implicit-function-declaration] snd_soc_free_ac97_component(wm9713->ac97); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/snd_soc_new_ac97_component +1219 sound/soc/codecs/wm9713.c 1208 1209 static int wm9713_soc_probe(struct snd_soc_component *component) 1210 { 1211 struct wm9713_priv *wm9713 = snd_soc_component_get_drvdata(component); 1212 struct regmap *regmap = NULL; 1213 1214 if (wm9713->mfd_pdata) { 1215 wm9713->ac97 = wm9713->mfd_pdata->ac97; 1216 regmap = wm9713->mfd_pdata->regmap; 1217 } else { 1218 #ifdef CONFIG_SND_SOC_AC97_BUS > 1219 wm9713->ac97 = snd_soc_new_ac97_component(component, WM9713_VENDOR_ID, 1220 WM9713_VENDOR_ID_MASK); 1221 if (IS_ERR(wm9713->ac97)) 1222 return PTR_ERR(wm9713->ac97); 1223 regmap = regmap_init_ac97(wm9713->ac97, &wm9713_regmap_config); 1224 if (IS_ERR(regmap)) { > 1225 snd_soc_free_ac97_component(wm9713->ac97); 1226 return PTR_ERR(regmap); 1227 } 1228 #endif 1229 } 1230 1231 snd_soc_component_init_regmap(component, regmap); 1232 1233 /* unmute the adc - move to kcontrol */ 1234 snd_soc_component_update_bits(component, AC97_CD, 0x7fff, 0x0000); 1235 1236 return 0; 1237 } 1238 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/uniphier 6/7] sound/soc/uniphier/aio-compress.c:314:34: sparse: cast to restricted __be16
by kbuild test robot 12 Feb '18

12 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/uniphier head: db4cb3d04eba91db48da0032c44b83ed7185973c commit: e98131222ff931a670739cede00d1fb9d6f83763 [6/7] ASoC: uniphier: add support for UniPhier AIO compress audio reproduce: # apt-get install sparse git checkout e98131222ff931a670739cede00d1fb9d6f83763 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> sound/soc/uniphier/aio-compress.c:314:34: sparse: cast to restricted __be16 >> sound/soc/uniphier/aio-compress.c:314:34: sparse: cast to restricted __be16 >> sound/soc/uniphier/aio-compress.c:314:34: sparse: cast to restricted __be16 >> sound/soc/uniphier/aio-compress.c:314:34: sparse: cast to restricted __be16 vim +314 sound/soc/uniphier/aio-compress.c 290 291 static int aio_compr_send_to_hw(struct uniphier_aio_sub *sub, 292 char __user *buf, size_t dstsize) 293 { 294 u32 __user *srcbuf = (u32 __user *)buf; 295 u32 *dstbuf = (u32 *)(sub->compr_area + sub->wr_offs); 296 int src = 0, dst = 0, ret; 297 u32 frm, frm_a, frm_b; 298 299 while (dstsize > 0) { 300 ret = get_user(frm, srcbuf + src); 301 if (ret) 302 return ret; 303 src++; 304 305 frm_a = frm & 0xffff; 306 frm_b = (frm >> 16) & 0xffff; 307 308 if (frm == IEC61937_HEADER_SIGN) { 309 frm_a |= 0x01000000; 310 311 /* Next data is Pc and Pd */ 312 sub->iec_header = true; 313 } else { > 314 u16 pc = be16_to_cpu((__be16)frm_a); 315 316 if (sub->iec_header && sub->iec_pc != pc) { 317 /* Force overwrite IEC frame type */ 318 sub->iec_pc = pc; 319 ret = aio_oport_set_stream_type(sub, pc); 320 if (ret) 321 return ret; 322 } 323 sub->iec_header = false; 324 } 325 dstbuf[dst++] = frm_a; 326 dstbuf[dst++] = frm_b; 327 328 dstsize -= sizeof(u32) * 2; 329 } 330 331 return 0; 332 } 333 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/ad1980 1/1] sound/soc/codecs/ad1980.c:243:9: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?
by kbuild test robot 12 Feb '18

12 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/ad1980 head: db53c016644c0d33579c60cc10b5152bbf9706ff commit: db53c016644c0d33579c60cc10b5152bbf9706ff [1/1] ASoC: ad1980: replace codec to component config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout db53c016644c0d33579c60cc10b5152bbf9706ff # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): sound/soc/codecs/ad1980.c: In function 'ad1980_soc_probe': >> sound/soc/codecs/ad1980.c:243:9: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration] ac97 = snd_soc_new_ac97_component(component, 0, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~ snd_soc_new_ac97_codec >> sound/soc/codecs/ad1980.c:243:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ac97 = snd_soc_new_ac97_component(component, 0, 0); ^ >> sound/soc/codecs/ad1980.c:285:2: error: implicit declaration of function 'snd_soc_free_ac97_component'; did you mean 'snd_soc_free_ac97_codec'? [-Werror=implicit-function-declaration] snd_soc_free_ac97_component(ac97); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ snd_soc_free_ac97_codec cc1: some warnings being treated as errors vim +243 sound/soc/codecs/ad1980.c 234 235 static int ad1980_soc_probe(struct snd_soc_component *component) 236 { 237 struct snd_ac97 *ac97; 238 struct regmap *regmap; 239 int ret; 240 u16 vendor_id2; 241 u16 ext_status; 242 > 243 ac97 = snd_soc_new_ac97_component(component, 0, 0); 244 if (IS_ERR(ac97)) { 245 ret = PTR_ERR(ac97); 246 dev_err(component->dev, "Failed to register AC97 component: %d\n", ret); 247 return ret; 248 } 249 250 regmap = regmap_init_ac97(ac97, &ad1980_regmap_config); 251 if (IS_ERR(regmap)) { 252 ret = PTR_ERR(regmap); 253 goto err_free_ac97; 254 } 255 256 snd_soc_component_init_regmap(component, regmap); 257 snd_soc_component_set_drvdata(component, ac97); 258 259 ret = ad1980_reset(component, 0); 260 if (ret < 0) 261 goto reset_err; 262 263 vendor_id2 = snd_soc_component_read32(component, AC97_VENDOR_ID2); 264 if (vendor_id2 == 0x5374) { 265 dev_warn(component->dev, 266 "Found AD1981 - only 2/2 IN/OUT Channels supported\n"); 267 } 268 269 /* unmute captures and playbacks volume */ 270 snd_soc_component_write(component, AC97_MASTER, 0x0000); 271 snd_soc_component_write(component, AC97_PCM, 0x0000); 272 snd_soc_component_write(component, AC97_REC_GAIN, 0x0000); 273 snd_soc_component_write(component, AC97_CENTER_LFE_MASTER, 0x0000); 274 snd_soc_component_write(component, AC97_SURROUND_MASTER, 0x0000); 275 276 /*power on LFE/CENTER/Surround DACs*/ 277 ext_status = snd_soc_component_read32(component, AC97_EXTENDED_STATUS); 278 snd_soc_component_write(component, AC97_EXTENDED_STATUS, ext_status&~0x3800); 279 280 return 0; 281 282 reset_err: 283 snd_soc_component_exit_regmap(component); 284 err_free_ac97: > 285 snd_soc_free_ac97_component(ac97); 286 return ret; 287 } 288 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/wm9081 1/1] sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function
by kbuild test robot 12 Feb '18

12 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm9081 head: 48c3387642967d62fc47aff4ad0e3816bf8292e3 commit: 48c3387642967d62fc47aff4ad0e3816bf8292e3 [1/1] ASoC: wm9081: replace codec to component config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 48c3387642967d62fc47aff4ad0e3816bf8292e3 # save the attached .config to linux build tree make.cross ARCH=arm Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): sound/soc/codecs/wm9081.c: In function 'wm9081_digital_mute': >> sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function [-Wmaybe-uninitialized] reg |= WM9081_DAC_MUTE; vim +/reg +1161 sound/soc/codecs/wm9081.c 86ed3669 Mark Brown 2009-05-22 1152 86ed3669 Mark Brown 2009-05-22 1153 static int wm9081_digital_mute(struct snd_soc_dai *codec_dai, int mute) 86ed3669 Mark Brown 2009-05-22 1154 { 48c33876 Kuninori Morimoto 2018-01-29 1155 struct snd_soc_component *component = codec_dai->component; 86ed3669 Mark Brown 2009-05-22 1156 unsigned int reg; 86ed3669 Mark Brown 2009-05-22 1157 48c33876 Kuninori Morimoto 2018-01-29 1158 snd_soc_component_read32(component, WM9081_DAC_DIGITAL_2); 86ed3669 Mark Brown 2009-05-22 1159 86ed3669 Mark Brown 2009-05-22 1160 if (mute) 86ed3669 Mark Brown 2009-05-22 @1161 reg |= WM9081_DAC_MUTE; 86ed3669 Mark Brown 2009-05-22 1162 else 86ed3669 Mark Brown 2009-05-22 1163 reg &= ~WM9081_DAC_MUTE; 86ed3669 Mark Brown 2009-05-22 1164 48c33876 Kuninori Morimoto 2018-01-29 1165 snd_soc_component_write(component, WM9081_DAC_DIGITAL_2, reg); 86ed3669 Mark Brown 2009-05-22 1166 86ed3669 Mark Brown 2009-05-22 1167 return 0; 86ed3669 Mark Brown 2009-05-22 1168 } 86ed3669 Mark Brown 2009-05-22 1169 :::::: The code at line 1161 was first introduced by commit :::::: 86ed3669f068b514ab85ffd548456a342b3fb8d3 ASoC: WM9081 mono DAC with integrated 2.6W class AB/D amplifier driver :::::: TO: Mark Brown <broonie(a)opensource.wolfsonmicro.com> :::::: CC: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/stac9766 1/1] sound/soc/codecs/stac9766.c:281:9: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?
by kbuild test robot 12 Feb '18

12 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/stac9766 head: 033bb535d0db54c7ae14f0dec14177cc424414a5 commit: 033bb535d0db54c7ae14f0dec14177cc424414a5 [1/1] ASoC: stac9766: replace codec to component config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 033bb535d0db54c7ae14f0dec14177cc424414a5 # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): sound/soc/codecs/stac9766.c: In function 'stac9766_component_probe': >> sound/soc/codecs/stac9766.c:281:9: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration] ac97 = snd_soc_new_ac97_component(component, STAC9766_VENDOR_ID, ^~~~~~~~~~~~~~~~~~~~~~~~~~ snd_soc_new_ac97_codec >> sound/soc/codecs/stac9766.c:281:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ac97 = snd_soc_new_ac97_component(component, STAC9766_VENDOR_ID, ^ >> sound/soc/codecs/stac9766.c:297:2: error: implicit declaration of function 'snd_soc_free_ac97_component'; did you mean 'snd_soc_free_ac97_codec'? [-Werror=implicit-function-declaration] snd_soc_free_ac97_component(ac97); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ snd_soc_free_ac97_codec cc1: some warnings being treated as errors vim +281 sound/soc/codecs/stac9766.c 274 275 static int stac9766_component_probe(struct snd_soc_component *component) 276 { 277 struct snd_ac97 *ac97; 278 struct regmap *regmap; 279 int ret; 280 > 281 ac97 = snd_soc_new_ac97_component(component, STAC9766_VENDOR_ID, 282 STAC9766_VENDOR_ID_MASK); 283 if (IS_ERR(ac97)) 284 return PTR_ERR(ac97); 285 286 regmap = regmap_init_ac97(ac97, &stac9766_regmap_config); 287 if (IS_ERR(regmap)) { 288 ret = PTR_ERR(regmap); 289 goto err_free_ac97; 290 } 291 292 snd_soc_component_init_regmap(component, regmap); 293 snd_soc_component_set_drvdata(component, ac97); 294 295 return 0; 296 err_free_ac97: > 297 snd_soc_free_ac97_component(ac97); 298 return ret; 299 } 300 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] ALSA: tons of false positives because of snd_ctl_find_id()
by Dan Carpenter 12 Feb '18

12 Feb '18

Hello Takashi Iwai, The patch 72cbfd45fac6: "ALSA: ice1724 - Add ESI Maya44 support" from May 6, 2009, leads to the following static checker warning: sound/pci/ice1712/maya44.c:204 maya_vol_put() error: buffer overflow 'chip->wm' 2 <= u32max. sound/pci/ice1712/maya44.c 199 static int maya_vol_put(struct snd_kcontrol *kcontrol, 200 struct snd_ctl_elem_value *ucontrol) 201 { 202 struct snd_maya44 *chip = snd_kcontrol_chip(kcontrol); 203 struct snd_wm8776 *wm = 204 &chip->wm[snd_ctl_get_ioff(kcontrol, &ucontrol->id)]; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This is a false positive obviously, but this code is crazy hard for static analysis to parse. snd_ctl_find_id() in sound/core/control.c 682 /** 683 * snd_ctl_find_id - find the control instance with the given id 684 * @card: the card instance 685 * @id: the id to search 686 * 687 * Finds the control instance with the given id from the card. 688 * 689 * The caller must down card->controls_rwsem before calling this function 690 * (if the race condition can happen). 691 * 692 * Return: The pointer of the instance if found, or %NULL if not. 693 * 694 */ 695 struct snd_kcontrol *snd_ctl_find_id(struct snd_card *card, 696 struct snd_ctl_elem_id *id) 697 { 698 struct snd_kcontrol *kctl; 699 700 if (snd_BUG_ON(!card || !id)) 701 return NULL; 702 if (id->numid != 0) 703 return snd_ctl_find_numid(card, id->numid); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ On this path, we don't check id->index. Which is fine because we don't use it. It would really make my life simpler if we could set the unchecked fields to zero. How Smatch works is that we merge all the success paths together so it would either be zero or checked which is easy to deal with. In the current code it's either checked or unchecked which is just unchecked when you merge the success paths together. I can probably figure out other ways to deal with this if that's not a good idea. 704 list_for_each_entry(kctl, &card->controls, list) { 705 if (kctl->id.iface != id->iface) 706 continue; 707 if (kctl->id.device != id->device) 708 continue; 709 if (kctl->id.subdevice != id->subdevice) 710 continue; 711 if (strncmp(kctl->id.name, id->name, sizeof(kctl->id.name))) 712 continue; 713 if (kctl->id.index > id->index) 714 continue; 715 if (kctl->id.index + kctl->count <= id->index) 716 continue; 717 return kctl; 718 } 719 return NULL; 720 } 721 EXPORT_SYMBOL(snd_ctl_find_id); regards, dan carpenter

3 3

[alsa-devel] [PATCH 0/8] add UniPhier audio system support
by Katsuhiro Suzuki 12 Feb '18

12 Feb '18

This series adds support for Socionext audio system for UniPhier LD11/LD20 SoCs. This driver supports I2S output for Line-In, Line-Out and S/PDIF output. UniPhier AIO DAI driver provides sound devices such as I2S, S/PDIF. Since the AIO has mixed register map for those I/Os, it is hard to split register areas for each sound devices. UniPhier EVEA is a codec core for Line-In, Line-Out. Since this core is only in internal of UniPhier series SoC, this driver works independently but only UniPhier SoC can use it. Katsuhiro Suzuki (8): ASoC: spdif: Add S32_LE support for S/PDIF dummy codec drivers ASoC: uniphier: add DT bindings documentation for UniPhier EVEA ASoC: uniphier: add DT bindings documentation for UniPhier AIO ASoC: uniphier: add support for UniPhier EVEA codec ASoC: uniphier: add support for UniPhier AIO driver ASoC: uniphier: add support for UniPhier LD11/LD20 AIO driver MAINTAINERS: add entries for UniPhier ASoC sound drivers arm64: dts: uniphier: add sound node for UniPhier .../devicetree/bindings/sound/uniphier,aio.txt | 36 ++ .../devicetree/bindings/sound/uniphier,evea.txt | 26 + MAINTAINERS | 6 + .../boot/dts/socionext/uniphier-ld11-global.dts | 72 +++ arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 31 + .../boot/dts/socionext/uniphier-ld20-global.dts | 72 +++ arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 35 ++ sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/codecs/spdif_receiver.c | 5 +- sound/soc/codecs/spdif_transmitter.c | 5 +- sound/soc/uniphier/Kconfig | 34 + sound/soc/uniphier/Makefile | 8 + sound/soc/uniphier/aio-core.c | 368 +++++++++++ sound/soc/uniphier/aio-dma.c | 266 ++++++++ sound/soc/uniphier/aio-ld11.c | 343 ++++++++++ sound/soc/uniphier/aio-regctrl.c | 699 +++++++++++++++++++++ sound/soc/uniphier/aio-regctrl.h | 495 +++++++++++++++ sound/soc/uniphier/aio.h | 261 ++++++++ sound/soc/uniphier/evea.c | 567 +++++++++++++++++ 20 files changed, 3327 insertions(+), 4 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/uniphier,aio.txt create mode 100644 Documentation/devicetree/bindings/sound/uniphier,evea.txt create mode 100644 sound/soc/uniphier/Kconfig create mode 100644 sound/soc/uniphier/Makefile create mode 100644 sound/soc/uniphier/aio-core.c create mode 100644 sound/soc/uniphier/aio-dma.c create mode 100644 sound/soc/uniphier/aio-ld11.c create mode 100644 sound/soc/uniphier/aio-regctrl.c create mode 100644 sound/soc/uniphier/aio-regctrl.h create mode 100644 sound/soc/uniphier/aio.h create mode 100644 sound/soc/uniphier/evea.c -- 2.15.0

4 19

[alsa-devel] [PATCH 1/2] ASoC: rt5659: Remove the routing path of the power widget "LDO2"
by Oder Chiou 12 Feb '18

12 Feb '18

This patch removes the routing path of the power widget "LDO2", and it should be depended on the hardware design. The power widget "LDO2" should add the routing path with the MICBIAS in the machine driver that is reasonable. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5659.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 07e7757..4ec1917 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -2818,11 +2818,6 @@ static const struct snd_soc_dapm_route rt5659_dapm_routes[] = { { "I2S2", NULL, "I2S2 ASRC" }, { "I2S3", NULL, "I2S3 ASRC" }, - { "IN1P", NULL, "LDO2" }, - { "IN2P", NULL, "LDO2" }, - { "IN3P", NULL, "LDO2" }, - { "IN4P", NULL, "LDO2" }, - { "DMIC1", NULL, "DMIC L1" }, { "DMIC1", NULL, "DMIC R1" }, { "DMIC2", NULL, "DMIC L2" }, -- 2.7.4

2 3

[alsa-devel] [PATCH 1/4] ASoC: fsl-asoc-card: Use 'snd_pcm_format_t' type when appropriate
by Fabio Estevam 12 Feb '18

12 Feb '18

From: Fabio Estevam <fabio.estevam(a)nxp.com> A better suited type for 'sample_format' and 'asrc_format' is 'snd_pcm_format_t'. Change the type so that the following build warnings with W=1 are gone: sound/soc/fsl/fsl-asoc-card.c:153:29: warning: incorrect type in assignment (different base types) sound/soc/fsl/fsl-asoc-card.c:153:29: expected unsigned int [unsigned] [usertype] sample_format sound/soc/fsl/fsl-asoc-card.c:153:29: got restricted snd_pcm_format_t sound/soc/fsl/fsl-asoc-card.c:258:44: warning: restricted snd_pcm_format_t degrades to integer sound/soc/fsl/fsl-asoc-card.c:525:29: warning: incorrect type in assignment (different base types) sound/soc/fsl/fsl-asoc-card.c:525:29: expected unsigned int [unsigned] [usertype] sample_format sound/soc/fsl/fsl-asoc-card.c:525:29: got restricted snd_pcm_format_t [usertype] <noident> sound/soc/fsl/fsl-asoc-card.c:680:43: warning: incorrect type in assignment (different base types) sound/soc/fsl/fsl-asoc-card.c:680:43: expected unsigned int [unsigned] [usertype] asrc_format sound/soc/fsl/fsl-asoc-card.c:680:43: got restricted snd_pcm_format_t [usertype] <noident> sound/soc/fsl/fsl-asoc-card.c:682:43: warning: incorrect type in assignment (different base types) sound/soc/fsl/fsl-asoc-card.c:682:43: expected unsigned int [unsigned] [usertype] asrc_format sound/soc/fsl/fsl-asoc-card.c:682:43: got restricted snd_pcm_format_t [usertype] <noident> Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- sound/soc/fsl/fsl-asoc-card.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 989be51..4a6750a 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -91,9 +91,9 @@ struct fsl_asoc_card_priv { struct cpu_priv cpu_priv; struct snd_soc_card card; u32 sample_rate; - u32 sample_format; + snd_pcm_format_t sample_format; u32 asrc_rate; - u32 asrc_format; + snd_pcm_format_t asrc_format; u32 dai_fmt; char name[32]; }; @@ -199,7 +199,7 @@ static int be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, mask = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT); snd_mask_none(mask); - snd_mask_set(mask, priv->asrc_format); + snd_mask_set(mask, (__force int)priv->asrc_format); return 0; } -- 2.7.4

2 7