February 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3] ASoC: dmic: Add optional wakeup delay
by Matthias Kaehlcke 19 Feb '18

19 Feb '18

On some systems a delay is needed after switching on the clocks, to allow the output to stabilize and avoid a popping noise at the beginning of the recording. Add the optional device tree property 'wakeup-delay-ms' and apply the specified delay after enabling the mic. A blocking delay can't be applied in dmic_daiops_trigger() since the function is called in atomic context. Instead use a DAPM event handler to set the enable GPIO and apply the delay in the handler. Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- Changes in v3: - rebased on latest dmic topic branch Changes in v2: - use DAPM event handler instead of _prepare() and get rid of _trigger() - skip error check for optional 'wakeup-delay-ms' property - updated commit message .../devicetree/bindings/sound/dmic.txt | 2 + sound/soc/codecs/dmic.c | 63 ++++++++++--------- 2 files changed, 37 insertions(+), 28 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/dmic.txt b/Documentation/devicetree/bindings/sound/dmic.txt index f7bf65611453..e957b4136716 100644 --- a/Documentation/devicetree/bindings/sound/dmic.txt +++ b/Documentation/devicetree/bindings/sound/dmic.txt @@ -8,6 +8,7 @@ Required properties: Optional properties: - dmicen-gpios: GPIO specifier for dmic to control start and stop - num-channels: Number of microphones on this DAI + - wakeup-delay-ms: Delay (in ms) after enabling the DMIC Example node: @@ -15,4 +16,5 @@ Example node: compatible = "dmic-codec"; dmicen-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; num-channels = <1>; + wakeup-delay-ms <50>; }; diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index 32a8f71d51f1..bac5bbb2dd59 100644 --- a/sound/soc/codecs/dmic.c +++ b/sound/soc/codecs/dmic.c @@ -19,6 +19,7 @@ * */ +#include <linux/delay.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> #include <linux/platform_device.h> @@ -29,34 +30,33 @@ #include <sound/soc.h> #include <sound/soc-dapm.h> -static int dmic_daiops_trigger(struct snd_pcm_substream *substream, - int cmd, struct snd_soc_dai *dai) -{ - struct gpio_desc *dmic_en = snd_soc_dai_get_drvdata(dai); +struct dmic { + struct gpio_desc *gpio_en; + int wakeup_delay; +}; - if (!dmic_en) - return 0; +static int dmic_aif_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) { + struct snd_soc_codec *codec = snd_soc_dapm_to_codec(w->dapm); + struct dmic *dmic = snd_soc_codec_get_drvdata(codec); - switch (cmd) { - case SNDRV_PCM_TRIGGER_START: - case SNDRV_PCM_TRIGGER_RESUME: - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: - gpiod_set_value(dmic_en, 1); + switch (event) { + case SND_SOC_DAPM_POST_PMU: + if (dmic->gpio_en) + gpiod_set_value(dmic->gpio_en, 1); + + if (dmic->wakeup_delay) + msleep(dmic->wakeup_delay); break; - case SNDRV_PCM_TRIGGER_STOP: - case SNDRV_PCM_TRIGGER_SUSPEND: - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - gpiod_set_value(dmic_en, 0); + case SND_SOC_DAPM_POST_PMD: + if (dmic->gpio_en) + gpiod_set_value(dmic->gpio_en, 0); break; } return 0; } -static const struct snd_soc_dai_ops dmic_dai_ops = { - .trigger = dmic_daiops_trigger, -}; - static struct snd_soc_dai_driver dmic_dai = { .name = "dmic-hifi", .capture = { @@ -68,26 +68,33 @@ static struct snd_soc_dai_driver dmic_dai = { | SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE, }, - .ops = &dmic_dai_ops, }; static int dmic_component_probe(struct snd_soc_component *component) { - struct gpio_desc *dmic_en; + struct dmic *dmic; + + dmic = devm_kzalloc(component->dev, sizeof(*dmic), GFP_KERNEL); + if (!dmic) + return -ENOMEM; + + dmic->gpio_en = devm_gpiod_get_optional(component->dev, + "dmicen", GPIOD_OUT_LOW); + if (IS_ERR(dmic->gpio_en)) + return PTR_ERR(dmic->gpio_en); - dmic_en = devm_gpiod_get_optional(component->dev, - "dmicen", GPIOD_OUT_LOW); - if (IS_ERR(dmic_en)) - return PTR_ERR(dmic_en); + device_property_read_u32(component->dev, "wakeup-delay-ms", + &dmic->wakeup_delay); - snd_soc_component_set_drvdata(component, dmic_en); + snd_soc_component_set_drvdata(component, dmic); return 0; } static const struct snd_soc_dapm_widget dmic_dapm_widgets[] = { - SND_SOC_DAPM_AIF_OUT("DMIC AIF", "Capture", 0, - SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT_E("DMIC AIF", "Capture", 0, + SND_SOC_NOPM, 0, 0, dmic_aif_event, + SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD), SND_SOC_DAPM_INPUT("DMic"), }; -- 2.16.1.291.g4437f3f132-goog

3 2

[alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix compiler warning -Wmaybe-uninitialized
by Kirill Marinushkin 19 Feb '18

19 Feb '18

Configuration: SND_SOC_INTEL_SKYLAKE=y PM_SLEEP=y Warning message: sound/soc/intel/skylake/skl.c: In function 'skl_resume': sound/soc/intel/skylake/skl.c:326:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] int ret; ^~~ Fixes: 4557c305d4fc ("ASoC: Intel: Skylake: Add support for active suspend") Signed-off-by: Kirill Marinushkin <k.marinushkin(a)gmail.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Vinod Koul <vinod.koul(a)intel.com> Cc: Guneshwor Singh <guneshwor.o.singh(a)intel.com> Cc: Naveen Manohar <naveen.m(a)intel.com> Cc: Harsha Priya N <harshapriya.n(a)intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Cc: alsa-devel(a)alsa-project.org Cc: linux-kernel(a)vger.kernel.org --- sound/soc/intel/skylake/skl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 31d8634e8aa1..273a9ab75489 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -323,7 +323,7 @@ static int skl_resume(struct device *dev) struct skl *skl = ebus_to_skl(ebus); struct hdac_bus *bus = ebus_to_hbus(ebus); struct hdac_ext_link *hlink = NULL; - int ret; + int ret = 0; /* Turned OFF in HDMI codec driver after codec reconfiguration */ if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI)) { -- 2.13.6

2 1

[alsa-devel] [PATCH 0/1] Use of shared resource in designware
by Akshu Agrawal 19 Feb '18

19 Feb '18

This patch will allow the driver to map same registers to multiple instances of driver. It is useful when playback and capture have same regsiters and are required to be present on separate cpu dais. This patch is dependant on "Add devm_ioremap_shared_resource()" patch. https://patchwork.kernel.org/patch/10177127/ Akshu Agrawal (1): ASoC: dwc: Use devm_ioremap_shared_resource include/sound/designware_i2s.h | 1 + sound/soc/dwc/dwc-i2s.c | 18 +++++++++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) -- 1.9.1

4 5

[alsa-devel] [PATCH] Makefile.am: Add missing code for enhanced configure option of alsa plugins
by Lars Wendler 18 Feb '18

18 Feb '18

Commit 1201e158fb00bf15c353d088c94c1cb3eff9653c added the pieces for configure but did not do the same for Makefile. As result all plugins were still built regardless of corresponding --disable-* option being called with configure. --- Makefile.am | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 69cfe0d..76cefef 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -SUBDIRS = oss mix usb_stream arcam-av doc +SUBDIRS = doc if HAVE_JACK SUBDIRS += jack endif @@ -20,6 +20,18 @@ endif if HAVE_SPEEXDSP SUBDIRS += speex endif +if HAVE_OSS +SUBDIRS += oss +endif +if HAVE_MIX +SUBDIRS += mix +endif +if HAVE_USBSTREAM +SUBDIRS += usb_stream +endif +if HAVE_ARCAMAV +SUBDIRS += arcam-av +endif EXTRA_DIST = gitcompile version COPYING.GPL m4/attributes.m4 AUTOMAKE_OPTIONS = foreign -- 2.16.2

1 0

[alsa-devel] [asoc:for-next 19/53] sound/soc//amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type
by kbuild test robot 16 Feb '18

16 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next head: 5372fcd763f83d0e4d38ac008a2076f36664cbae commit: b2eeca7e9dc8f413d446f397a0220e21d6eb01d1 [19/53] Merge remote-tracking branches 'asoc/topic/ak5386', 'asoc/topic/ak5558', 'asoc/topic/alc5623', 'asoc/topic/alc5632' and 'asoc/topic/amd' into asoc-next config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout b2eeca7e9dc8f413d446f397a0220e21d6eb01d1 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): sound/soc//amd/acp-da7219-max98357a.c: In function 'cz_da7219_init': >> sound/soc//amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type [-Werror=incompatible-pointer-types] da7219_aad_jack_det(codec, &cz_jack); ^~~~~ In file included from sound/soc//amd/acp-da7219-max98357a.c:38:0: sound/soc//amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *' void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jack *jack); ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors sparse warnings: (new ones prefixed by >>) >> sound/soc/amd/acp-da7219-max98357a.c:79:29: sparse: incorrect type in argument 1 (different base types) @@ expected struct snd_soc_component @@ got ct snd_soc_component @@ sound/soc/amd/acp-da7219-max98357a.c:79:29: expected struct snd_soc_component sound/soc/amd/acp-da7219-max98357a.c:79:29: got struct snd_soc_codec sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init': sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of 'da7219_aad_jack_det' from incompatible pointer type da7219_aad_jack_det(codec, &cz_jack); ^~~~~ In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0: sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct snd_soc_component but argument is of type 'struct snd_soc_codec void da7219_aad_jack_det(struct snd_soc_component struct snd_soc_jack ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/da7219_aad_jack_det +79 sound/soc//amd/acp-da7219-max98357a.c 608a300f Akshu Agrawal 2018-02-16 45 608a300f Akshu Agrawal 2018-02-16 46 static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd) 608a300f Akshu Agrawal 2018-02-16 47 { 608a300f Akshu Agrawal 2018-02-16 48 int ret; 608a300f Akshu Agrawal 2018-02-16 49 struct snd_soc_card *card = rtd->card; 608a300f Akshu Agrawal 2018-02-16 50 struct snd_soc_codec *codec = rtd->codec; 608a300f Akshu Agrawal 2018-02-16 51 struct snd_soc_dai *codec_dai = rtd->codec_dai; 608a300f Akshu Agrawal 2018-02-16 52 608a300f Akshu Agrawal 2018-02-16 53 dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name); 608a300f Akshu Agrawal 2018-02-16 54 608a300f Akshu Agrawal 2018-02-16 55 ret = snd_soc_dai_set_sysclk(codec_dai, DA7219_CLKSRC_MCLK, 608a300f Akshu Agrawal 2018-02-16 56 CZ_PLAT_CLK, SND_SOC_CLOCK_IN); 608a300f Akshu Agrawal 2018-02-16 57 if (ret < 0) { 608a300f Akshu Agrawal 2018-02-16 58 dev_err(rtd->dev, "can't set codec sysclk: %d\n", ret); 608a300f Akshu Agrawal 2018-02-16 59 return ret; 608a300f Akshu Agrawal 2018-02-16 60 } 608a300f Akshu Agrawal 2018-02-16 61 608a300f Akshu Agrawal 2018-02-16 62 ret = snd_soc_dai_set_pll(codec_dai, 0, DA7219_SYSCLK_PLL, 608a300f Akshu Agrawal 2018-02-16 63 CZ_PLAT_CLK, MCLK_RATE); 608a300f Akshu Agrawal 2018-02-16 64 if (ret < 0) { 608a300f Akshu Agrawal 2018-02-16 65 dev_err(rtd->dev, "can't set codec pll: %d\n", ret); 608a300f Akshu Agrawal 2018-02-16 66 return ret; 608a300f Akshu Agrawal 2018-02-16 67 } 608a300f Akshu Agrawal 2018-02-16 68 608a300f Akshu Agrawal 2018-02-16 69 ret = snd_soc_card_jack_new(card, "Headset Jack", 608a300f Akshu Agrawal 2018-02-16 70 SND_JACK_HEADPHONE | SND_JACK_MICROPHONE | 608a300f Akshu Agrawal 2018-02-16 71 SND_JACK_BTN_0 | SND_JACK_BTN_1 | 608a300f Akshu Agrawal 2018-02-16 72 SND_JACK_BTN_2 | SND_JACK_BTN_3, 608a300f Akshu Agrawal 2018-02-16 73 &cz_jack, NULL, 0); 608a300f Akshu Agrawal 2018-02-16 74 if (ret) { 608a300f Akshu Agrawal 2018-02-16 75 dev_err(card->dev, "HP jack creation failed %d\n", ret); 608a300f Akshu Agrawal 2018-02-16 76 return ret; 608a300f Akshu Agrawal 2018-02-16 77 } 608a300f Akshu Agrawal 2018-02-16 78 608a300f Akshu Agrawal 2018-02-16 @79 da7219_aad_jack_det(codec, &cz_jack); 608a300f Akshu Agrawal 2018-02-16 80 608a300f Akshu Agrawal 2018-02-16 81 return 0; 608a300f Akshu Agrawal 2018-02-16 82 } 608a300f Akshu Agrawal 2018-02-16 83 :::::: The code at line 79 was first introduced by commit :::::: 608a300fc1f0e088446cbef8e13ded686c5172b6 ASoC: AMD: Add machine driver for ST DA7219 MAX98357 :::::: TO: Akshu Agrawal <akshu.agrawal(a)amd.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: wm_adsp: Fix some signedness errors in register access
by Richard Fitzgerald 16 Feb '18

16 Feb '18

base and sysclk_reg should be unsigned int, as that is what regmap takes as a register address. sysclk_mask is used to mask unsigned register values so should be unsigned. sysclk_shift is a shift value so is not allowed to be negative. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/soc/codecs/wm_adsp.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.h b/sound/soc/codecs/wm_adsp.h index 41cc11c19b83..d4042c95315e 100644 --- a/sound/soc/codecs/wm_adsp.h +++ b/sound/soc/codecs/wm_adsp.h @@ -64,10 +64,10 @@ struct wm_adsp { struct regmap *regmap; struct snd_soc_codec *codec; - int base; - int sysclk_reg; - int sysclk_mask; - int sysclk_shift; + unsigned int base; + unsigned int sysclk_reg; + unsigned int sysclk_mask; + unsigned int sysclk_shift; struct list_head alg_regions; -- 2.11.0

2 1

[alsa-devel] [PATCH v2] ASoC: dmic: Add optional wakeup delay
by Matthias Kaehlcke 16 Feb '18

16 Feb '18

On some systems a delay is needed after switching on the clocks, to allow the output to stabilize and avoid a popping noise at the beginning of the recording. Add the optional device tree property 'wakeup-delay-ms' and apply the specified delay after enabling the mic. A blocking delay can't be applied in dmic_daiops_trigger() since the function is called in atomic context. Instead use a DAPM event handler to set the enable GPIO and apply the delay in the handler. Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- Changes in v2: - use DAPM event handler instead of _prepare() and get rid of _trigger() - skip error check for optional 'wakeup-delay-ms' property - updated commit message .../devicetree/bindings/sound/dmic.txt | 2 + sound/soc/codecs/dmic.c | 63 ++++++++++--------- 2 files changed, 37 insertions(+), 28 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/dmic.txt b/Documentation/devicetree/bindings/sound/dmic.txt index f7bf65611453..e957b4136716 100644 --- a/Documentation/devicetree/bindings/sound/dmic.txt +++ b/Documentation/devicetree/bindings/sound/dmic.txt @@ -8,6 +8,7 @@ Required properties: Optional properties: - dmicen-gpios: GPIO specifier for dmic to control start and stop - num-channels: Number of microphones on this DAI + - wakeup-delay-ms: Delay (in ms) after enabling the DMIC Example node: @@ -15,4 +16,5 @@ Example node: compatible = "dmic-codec"; dmicen-gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; num-channels = <1>; + wakeup-delay-ms <50>; }; diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index cf83c423394d..b5f60ac22ace 100644 --- a/sound/soc/codecs/dmic.c +++ b/sound/soc/codecs/dmic.c @@ -19,6 +19,7 @@ * */ +#include <linux/delay.h> #include <linux/gpio.h> #include <linux/gpio/consumer.h> #include <linux/platform_device.h> @@ -29,34 +30,33 @@ #include <sound/soc.h> #include <sound/soc-dapm.h> -static int dmic_daiops_trigger(struct snd_pcm_substream *substream, - int cmd, struct snd_soc_dai *dai) -{ - struct gpio_desc *dmic_en = snd_soc_dai_get_drvdata(dai); +struct dmic { + struct gpio_desc *gpio_en; + int wakeup_delay; +}; - if (!dmic_en) - return 0; +static int dmic_aif_event(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) { + struct snd_soc_codec *codec = snd_soc_dapm_to_codec(w->dapm); + struct dmic *dmic = snd_soc_codec_get_drvdata(codec); - switch (cmd) { - case SNDRV_PCM_TRIGGER_START: - case SNDRV_PCM_TRIGGER_RESUME: - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: - gpiod_set_value(dmic_en, 1); + switch (event) { + case SND_SOC_DAPM_POST_PMU: + if (dmic->gpio_en) + gpiod_set_value(dmic->gpio_en, 1); + + if (dmic->wakeup_delay) + msleep(dmic->wakeup_delay); break; - case SNDRV_PCM_TRIGGER_STOP: - case SNDRV_PCM_TRIGGER_SUSPEND: - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - gpiod_set_value(dmic_en, 0); + case SND_SOC_DAPM_POST_PMD: + if (dmic->gpio_en) + gpiod_set_value(dmic->gpio_en, 0); break; } return 0; } -static const struct snd_soc_dai_ops dmic_dai_ops = { - .trigger = dmic_daiops_trigger, -}; - static struct snd_soc_dai_driver dmic_dai = { .name = "dmic-hifi", .capture = { @@ -68,26 +68,33 @@ static struct snd_soc_dai_driver dmic_dai = { | SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE, }, - .ops = &dmic_dai_ops, }; static int dmic_codec_probe(struct snd_soc_codec *codec) { - struct gpio_desc *dmic_en; + struct dmic *dmic; + + dmic = devm_kzalloc(codec->dev, sizeof(*dmic), GFP_KERNEL); + if (!dmic) + return -ENOMEM; + + dmic->gpio_en = devm_gpiod_get_optional(codec->dev, + "dmicen", GPIOD_OUT_LOW); + if (IS_ERR(dmic->gpio_en)) + return PTR_ERR(dmic->gpio_en); - dmic_en = devm_gpiod_get_optional(codec->dev, - "dmicen", GPIOD_OUT_LOW); - if (IS_ERR(dmic_en)) - return PTR_ERR(dmic_en); + device_property_read_u32(codec->dev, "wakeup-delay-ms", + &dmic->wakeup_delay); - snd_soc_codec_set_drvdata(codec, dmic_en); + snd_soc_codec_set_drvdata(codec, dmic); return 0; } static const struct snd_soc_dapm_widget dmic_dapm_widgets[] = { - SND_SOC_DAPM_AIF_OUT("DMIC AIF", "Capture", 0, - SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT_E("DMIC AIF", "Capture", 0, + SND_SOC_NOPM, 0, 0, dmic_aif_event, + SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD), SND_SOC_DAPM_INPUT("DMic"), }; -- 2.16.1.291.g4437f3f132-goog

3 4

[alsa-devel] [asoc:topic/ak4458 1/2] sound/soc/codecs/ak4458.c:577:28: sparse: symbol 'ak4458_regmap' was not declared. Should it be static?
by kbuild test robot 16 Feb '18

16 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/ak4458 head: 17e2304f0ad31d3f9bba4285b7024bf3c3626600 commit: 08660086eff9e9e69246a65ee48aba5c3901bf5e [1/2] ASoC: ak4458: Add support for AK4458 DAC driver reproduce: # apt-get install sparse git checkout 08660086eff9e9e69246a65ee48aba5c3901bf5e make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> sound/soc/codecs/ak4458.c:577:28: sparse: symbol 'ak4458_regmap' was not declared. Should it be >> sound/soc/codecs/ak4458.c:587:25: sparse: symbol 'ak4458_pm' was not declared. Should it be Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 2

[alsa-devel] [PATCH] MAINTAINERS: Add myself as sgtl5000 maintainer
by Fabio Estevam 16 Feb '18

16 Feb '18

From: Fabio Estevam <fabio.estevam(a)nxp.com> I would like helping maintaining and reviewing/testing sgtl5000 related patches. Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76e..c488c8a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9922,6 +9922,13 @@ F: Documentation/ABI/stable/sysfs-bus-nvmem F: include/linux/nvmem-consumer.h F: include/linux/nvmem-provider.h +NXP SGTL5000 DRIVER +M: Fabio Estevam <fabio.estevam(a)nxp.com> +L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/sound/sgtl5000.txt +F: sound/soc/codecs/sgtl5000* + NXP TDA998X DRM DRIVER M: Russell King <linux(a)armlinux.org.uk> S: Supported -- 2.7.4

2 1

[alsa-devel] [PATCH v3] ASoC: sgtl5000: Fix suspend/resume
by Fabio Estevam 16 Feb '18

16 Feb '18

From: Fabio Estevam <fabio.estevam(a)nxp.com> Commit 8419caa72702 ("ASoC: sgtl5000: Do not disable regulators in SND_SOC_BIAS_OFF") causes the sgtl5000 to fail after a suspend/resume sequence: # aplay /media/a2002011001-e02.wav Playing WAVE '/media/a2002011001-e02.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo aplay: pcm_write:2051: write error: Input/output error The problem is caused by the fact that the aforementioned commit dropped the cache handling, so re-introduce the register map resync to fix the problem. Cc: <stable(a)vger.kernel.org> Suggested-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- Changes since v2: - Rebased against Linus' tree sound/soc/codecs/sgtl5000.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index e1ab553..7ff5cb7 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -871,15 +871,26 @@ static int sgtl5000_pcm_hw_params(struct snd_pcm_substream *substream, static int sgtl5000_set_bias_level(struct snd_soc_codec *codec, enum snd_soc_bias_level level) { + struct sgtl5000_priv *sgtl = snd_soc_codec_get_drvdata(codec); + int ret; + switch (level) { case SND_SOC_BIAS_ON: case SND_SOC_BIAS_PREPARE: case SND_SOC_BIAS_STANDBY: + regcache_cache_only(sgtl->regmap, false); + ret = regcache_sync(sgtl->regmap); + if (ret) { + regcache_cache_only(sgtl->regmap, true); + return ret; + } + snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_REFTOP_POWERUP, SGTL5000_REFTOP_POWERUP); break; case SND_SOC_BIAS_OFF: + regcache_cache_only(sgtl->regmap, true); snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_REFTOP_POWERUP, 0); break; -- 2.7.4

2 1