February 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] audio CODEC(CS42888) test
by Muni Sekhar 21 Feb '18

21 Feb '18

[ Please keep me in CC as I'm not subscribed to the list] Hi All, I’m having a sound hardware which contains an analogue audio CODEC(CS42888) and configuring the CODEC is performed over SPI bus. I noticed that linux kernel already had a driver(snd-soc-cs42xx8.ko) for this, I planned to use this driver. Basically I’d like to perform loopback test and compare the sent and received files to verify data fidelity. Also the test to be repeated for various data rates and data formats. I’d like to know how to test this loopback scenario and compare the sent\received files? I appreciate any help. -- Thanks, Sekhar

1 0

[alsa-devel] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
by Augustine.Chen 20 Feb '18

20 Feb '18

The chip data of HDMI LPE audio is set to drm_i915_private which is not consistent with the expectation by x86 APIC driver. In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would cause kernel panic while doing CPU hotplug. Since the dependency of IRQ chip data was removed from HDMI LPE audio by Commit 9bd9590997b92fbd79fd028f704f6c584b4439d7 ("drm/i915: Stop pretending to mask/unmask LPE audio interrupts"), remove the code of setting IRQ chip data to resolve this issue. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103731 Cc: Pierre-Louis Bossart <pierre-louis.bossart(a)intel.com> Cc: Jerome Anand <jerome.anand(a)intel.com> Cc: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Augustine.Chen <augustine.chen(a)intel.com> --- drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c index 3bf6528..56176f9 100644 --- a/drivers/gpu/drm/i915/intel_lpe_audio.c +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c @@ -176,7 +176,7 @@ static int lpe_audio_irq_init(struct drm_i915_private *dev_priv) handle_simple_irq, "hdmi_lpe_audio_irq_handler"); - return irq_set_chip_data(irq, dev_priv); + return 0; } static bool lpe_audio_detect(struct drm_i915_private *dev_priv) -- 1.9.1

6 15

[alsa-devel] [PATCH, alsa-lib 1/2] topology: Fix parsing config with multiple hw_configs
by Kirill Marinushkin 20 Feb '18

20 Feb '18

Currently, if the config file includes several hw_configs sections, parse_hw_config_refs() returns after parsing only the first section. For example, the following config, based on alsa-lib/src/conf/topology/broadwell/broadwell.conf, is parsed incorrectly: ~~~~ SectionHWConfig."CodecHWConfig" { id "1" format "I2S" # physical audio format. bclk "master" # Platform is master of bit clock fsync "master" # platform is master of fsync } SectionHWConfig."CodecHWConfig2" { id "2" format "AC97" } SectionLink."Codec" { # used for binding to the physical link id "0" hw_configs [ "CodecHWConfig" "CodecHWConfig2" ] default_hw_conf_id "2" } ~~~~ Signed-off-by: Kirill Marinushkin <k.marinushkin(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: patch(a)alsa-project.org --- src/topology/pcm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/topology/pcm.c b/src/topology/pcm.c index 58cee31d..d3836677 100644 --- a/src/topology/pcm.c +++ b/src/topology/pcm.c @@ -882,6 +882,7 @@ static int parse_hw_config_refs(snd_tplg_t *tplg, snd_config_t *cfg, /* refer to a list of HW configs */ snd_config_for_each(i, next, cfg) { const char *val; + int err; n = snd_config_iterator_entry(i); if (snd_config_get_string(n, &val) < 0) @@ -893,7 +894,9 @@ static int parse_hw_config_refs(snd_tplg_t *tplg, snd_config_t *cfg, } link->num_hw_configs++; - return tplg_ref_add(elem, SND_TPLG_TYPE_HW_CONFIG, val); + err = tplg_ref_add(elem, SND_TPLG_TYPE_HW_CONFIG, val); + if (err < 0) + return err; } return 0; -- 2.13.6

2 6

[alsa-devel] [PATCH 1/2] ASoC: topology: Rename clock_gated to clock_cont in snd_soc_tplg_hw_config
by Kirill Marinushkin 20 Feb '18

20 Feb '18

In kernel `soc-dai.h`, DAI clock gating is defined as following: ~~~~ \#define SND_SOC_DAIFMT_CONT (1 << 4) /* continuous clock */ \#define SND_SOC_DAIFMT_GATED (0 << 4) /* clock is gated */ ~~~~ Therefore, the corresponding field of struct snd_soc_tplg_hw_config should be inverted compared to the current logic: clock_count = 1 => SND_SOC_DAIFMT_CONT clock_count = 0 => SND_SOC_DAIFMT_GATED Signed-off-by: Kirill Marinushkin <k.marinushkin(a)gmail.com> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: alsa-devel(a)alsa-project.org Cc: linux-kernel(a)vger.kernel.org --- include/uapi/sound/asoc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index 69c37ecbff7e..10188850dede 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -312,7 +312,9 @@ struct snd_soc_tplg_hw_config { __le32 size; /* in bytes of this structure */ __le32 id; /* unique ID - - used to match */ __le32 fmt; /* SND_SOC_DAI_FORMAT_ format value */ - __u8 clock_gated; /* 1 if clock can be gated to save power */ + __u8 clock_cont; /* 1 if clock is continuous, and can not be + * gated to save power + */ __u8 invert_bclk; /* 1 for inverted BCLK, 0 for normal */ __u8 invert_fsync; /* 1 for inverted frame clock, 0 for normal */ __u8 bclk_master; /* 1 for master of BCLK, 0 for slave */ -- 2.13.6

3 10

[alsa-devel] [PATCH] ALSA: hda-beep: add SPDX identifiers
by Matt Ranostay 20 Feb '18

20 Feb '18

Add SPDX GPLv2.0+ identifiers and update authors email Signed-off-by: Matt Ranostay <matt.ranostay(a)konsulko.com> --- sound/pci/hda/hda_beep.c | 17 ++--------------- sound/pci/hda/hda_beep.h | 17 ++--------------- 2 files changed, 4 insertions(+), 30 deletions(-) diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c index c397e7da0eac..066b5b59c4d7 100644 --- a/sound/pci/hda/hda_beep.c +++ b/sound/pci/hda/hda_beep.c @@ -1,22 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Digital Beep Input Interface for HD-audio codec * - * Author: Matt Ranostay <mranostay(a)gmail.com> + * Author: Matt Ranostay <matt.ranostay(a)konsulko.com> * Copyright (c) 2008 Embedded Alley Solutions Inc - * - * This driver is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This driver is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include <linux/input.h> diff --git a/sound/pci/hda/hda_beep.h b/sound/pci/hda/hda_beep.h index 1052ad380e97..d1a6a9c1329a 100644 --- a/sound/pci/hda/hda_beep.h +++ b/sound/pci/hda/hda_beep.h @@ -1,22 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Digital Beep Input Interface for HD-audio codec * - * Author: Matt Ranostay <mranostay(a)gmail.com> + * Author: Matt Ranostay <matt.ranostay(a)konsulko.com> * Copyright (c) 2008 Embedded Alley Solutions Inc - * - * This driver is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This driver is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef __SOUND_HDA_BEEP_H -- 2.14.1

2 1

[alsa-devel] [PATCH] ASoC: codecs: ak5558: Fix style for SPDX identifier
by Daniel Baluta 20 Feb '18

20 Feb '18

Use // for .c and /* for .h files according to: Documentation/process/license-rules.rst file. Signed-off-by: Daniel Baluta <daniel.baluta(a)nxp.com> --- sound/soc/codecs/ak5558.c | 11 +++++------ sound/soc/codecs/ak5558.h | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/ak5558.c b/sound/soc/codecs/ak5558.c index f224831..f4ed5cc 100644 --- a/sound/soc/codecs/ak5558.c +++ b/sound/soc/codecs/ak5558.c @@ -1,10 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 -/* - * Audio driver for AK5558 ADC - * - * Copyright (C) 2015 Asahi Kasei Microdevices Corporation - * Copyright 2018 NXP - */ +// +// Audio driver for AK5558 ADC +// +// Copyright (C) 2015 Asahi Kasei Microdevices Corporation +// Copyright 2018 NXP #include <linux/delay.h> #include <linux/gpio/consumer.h> diff --git a/sound/soc/codecs/ak5558.h b/sound/soc/codecs/ak5558.h index 7c9e373..6105908 100644 --- a/sound/soc/codecs/ak5558.h +++ b/sound/soc/codecs/ak5558.h @@ -1,5 +1,5 @@ -// SPDX-License-Identifier: GPL-2.0 -/* +/* SPDX-License-Identifier: GPL-2.0 + * * Audio driver header for AK5558 * * Copyright (C) 2016 Asahi Kasei Microdevices Corporation -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: hdmi-codec: Fix module unloading caused kernel crash
by Peter Ujfalusi 20 Feb '18

20 Feb '18

The hcp->chmap_info must not be freed up in the hdmi_codec_remove() function as it leads to kernel crash due ALSA core's pcm_chmap_ctl_private_free() is trying to free it up again when the card destroyed via snd_card_free. Since the driver was converted to devm_snd_soc_register_component() the whole platform_device.remove can be removed. Commit cd6111b26280a ("ASoC: hdmi-codec: add channel mapping control") should not have added the kfree(hcp->chmap_info); to the hdmi_codec_remove function. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> --- sound/soc/codecs/hdmi-codec.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 42df579cb507..6fa11888672d 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -798,23 +798,11 @@ static int hdmi_codec_probe(struct platform_device *pdev) return 0; } -static int hdmi_codec_remove(struct platform_device *pdev) -{ - struct device *dev = &pdev->dev; - struct hdmi_codec_priv *hcp; - - hcp = dev_get_drvdata(dev); - kfree(hcp->chmap_info); - - return 0; -} - static struct platform_driver hdmi_codec_driver = { .driver = { .name = HDMI_CODEC_DRV_NAME, }, .probe = hdmi_codec_probe, - .remove = hdmi_codec_remove, }; module_platform_driver(hdmi_codec_driver); -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

3 3

[alsa-devel] [PATCH v2] ASoC: hdmi-codec: Fix module unloading caused kernel crash
by Peter Ujfalusi 20 Feb '18

20 Feb '18

The hcp->chmap_info must not be freed up in the hdmi_codec_remove() function as it leads to kernel crash due ALSA core's pcm_chmap_ctl_private_free() is trying to free it up again when the card destroyed via snd_card_free. Commit cd6111b26280a ("ASoC: hdmi-codec: add channel mapping control") should not have added the kfree(hcp->chmap_info); to the hdmi_codec_remove function. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> Reviewed-by: Jyri Sarha <jsarha(a)ti.com> Tested-by: Jyri Sarha <jsarha(a)ti.com> --- Hi, Changes since v1: - Rebased on mainline (4.16-rc2) Mainline does not have devm_ version of snd_soc_register_codec(), the hdmi_codec_remove callback can not be removed. Regards, Peter sound/soc/codecs/hdmi-codec.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 5672e516bec3..c1830ccd3bb8 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -798,12 +798,7 @@ static int hdmi_codec_probe(struct platform_device *pdev) static int hdmi_codec_remove(struct platform_device *pdev) { - struct device *dev = &pdev->dev; - struct hdmi_codec_priv *hcp; - - hcp = dev_get_drvdata(dev); - kfree(hcp->chmap_info); - snd_soc_unregister_codec(dev); + snd_soc_unregister_codec(&pdev->dev); return 0; } -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2 1

[alsa-devel] [asoc:topic/topology 1/1] sound/soc/soc-topology.c:1985:33: error: 'SND_SOC_TPLG_DAI_CLK_GATE_GATED' undeclared; did you mean 'SND_SOC_TPLG_DAPM_AIF_OUT'?
by kbuild test robot 20 Feb '18

20 Feb '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/topology head: bdb86c40e8c5d2abe2ec7be964d621c1b7c27081 commit: bdb86c40e8c5d2abe2ec7be964d621c1b7c27081 [1/1] ASoC: topology: Add missing clock gating parameter when parsing hw_configs config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout bdb86c40e8c5d2abe2ec7be964d621c1b7c27081 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): sound/soc/soc-topology.c: In function 'set_link_hw_format': >> sound/soc/soc-topology.c:1985:33: error: 'SND_SOC_TPLG_DAI_CLK_GATE_GATED' undeclared (first use in this function); did you mean 'SND_SOC_TPLG_DAPM_AIF_OUT'? if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SND_SOC_TPLG_DAPM_AIF_OUT sound/soc/soc-topology.c:1985:33: note: each undeclared identifier is reported only once for each function it appears in >> sound/soc/soc-topology.c:1988:5: error: 'SND_SOC_TPLG_DAI_CLK_GATE_CONT' undeclared (first use in this function); did you mean 'SND_SOC_TPLG_DAI_CLK_GATE_GATED'? SND_SOC_TPLG_DAI_CLK_GATE_CONT) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ SND_SOC_TPLG_DAI_CLK_GATE_GATED vim +1985 sound/soc/soc-topology.c 1959 1960 /** 1961 * set_link_hw_format - Set the HW audio format of the physical DAI link. 1962 * @link: &snd_soc_dai_link which should be updated 1963 * @cfg: physical link configs. 1964 * 1965 * Topology context contains a list of supported HW formats (configs) and 1966 * a default format ID for the physical link. This function will use this 1967 * default ID to choose the HW format to set the link's DAI format for init. 1968 */ 1969 static void set_link_hw_format(struct snd_soc_dai_link *link, 1970 struct snd_soc_tplg_link_config *cfg) 1971 { 1972 struct snd_soc_tplg_hw_config *hw_config; 1973 unsigned char bclk_master, fsync_master; 1974 unsigned char invert_bclk, invert_fsync; 1975 int i; 1976 1977 for (i = 0; i < cfg->num_hw_configs; i++) { 1978 hw_config = &cfg->hw_config[i]; 1979 if (hw_config->id != cfg->default_hw_config_id) 1980 continue; 1981 1982 link->dai_fmt = hw_config->fmt & SND_SOC_DAIFMT_FORMAT_MASK; 1983 1984 /* clock gating */ > 1985 if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED) 1986 link->dai_fmt |= SND_SOC_DAIFMT_GATED; 1987 else if (hw_config->clock_gated == > 1988 SND_SOC_TPLG_DAI_CLK_GATE_CONT) 1989 link->dai_fmt |= SND_SOC_DAIFMT_CONT; 1990 1991 /* clock signal polarity */ 1992 invert_bclk = hw_config->invert_bclk; 1993 invert_fsync = hw_config->invert_fsync; 1994 if (!invert_bclk && !invert_fsync) 1995 link->dai_fmt |= SND_SOC_DAIFMT_NB_NF; 1996 else if (!invert_bclk && invert_fsync) 1997 link->dai_fmt |= SND_SOC_DAIFMT_NB_IF; 1998 else if (invert_bclk && !invert_fsync) 1999 link->dai_fmt |= SND_SOC_DAIFMT_IB_NF; 2000 else 2001 link->dai_fmt |= SND_SOC_DAIFMT_IB_IF; 2002 2003 /* clock masters */ 2004 bclk_master = hw_config->bclk_master; 2005 fsync_master = hw_config->fsync_master; 2006 if (!bclk_master && !fsync_master) 2007 link->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM; 2008 else if (bclk_master && !fsync_master) 2009 link->dai_fmt |= SND_SOC_DAIFMT_CBS_CFM; 2010 else if (!bclk_master && fsync_master) 2011 link->dai_fmt |= SND_SOC_DAIFMT_CBM_CFS; 2012 else 2013 link->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS; 2014 } 2015 } 2016 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 0/2] Fix coding style issues in AK4458 DAC
by Cosmin-Gabriel Samoila 20 Feb '18

20 Feb '18

Modify SPDX license comment style and sort headers alphabetically. Cosmin-Gabriel Samoila (2): ASoC: ak4458: Modify SPDX license format ASoC: ak4458: Sort headers alphabetically sound/soc/codecs/ak4458.c | 23 +++++++++++------------ sound/soc/codecs/ak4458.h | 2 +- 2 files changed, 12 insertions(+), 13 deletions(-) -- 2.7.4

2 4