December 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: fsl: Add a dependency on ARM for Eukrea
by Mark Brown 13 Dec '18

13 Dec '18

The MXC architecture became buildable on arm64 which doesn't have a mach-types.h so add an explicit 32 bit dependency. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/fsl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 6ec19fb4a934..ff2d4a8783f9 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -221,7 +221,7 @@ config SND_SOC_PHYCORE_AC97 config SND_SOC_EUKREA_TLV320 tristate "Eukrea TLV320" - depends on ARCH_MXC && I2C + depends on ARCH_ARM && ARCH_MXC && I2C select SND_SOC_TLV320AIC23_I2C select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_SSI -- 2.19.0.rc2

1 0

[alsa-devel] [bunk@debian.org] Bug#916052: alsa-oss FTBFS with glibc 2.28
by Elimar Riesebieter 13 Dec '18

13 Dec '18

Control: forwarded -1 alsa-devel(a)alsa-project.org Hi, could you please investigate? It seems as alsa-oss doesn't built with glibc 2.28. Thanks in advance Elimar -- Learned men are the cisterns of knowledge, not the fountainheads ;-)

2 2

[alsa-devel] [PATCH v11 0/3] Huawei laptops
by Ayman Bagabas 13 Dec '18

13 Dec '18

This patch set is based on the new audio LED triggers in topic/leds-trigger branch from git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Changes in v11: * Minor code changes Changes in v10: * Use ec_get_handle instead of acpi_get_handle since we are using the ec device * Switch to WMI0_EXPENSIVE_GUID and wmi_query_block to fetch keycode when WMI0 is used Changes in v9: * Explicitly use NULL in acpi_get_handle * Drop __initconst from huawei_wmi_keymap Changes in v8: * Switch to wmi_driver * Use devm to allocate and manage devices * Skip registering LED subsystem if a ACPI controller method was not found Changes in v7: * Use audio LED triggers patch set * Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1. In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome. Changes in v6: * Review tags Changes in v5: * Consistency in file names * How module would be enabled (Kconfig) * Match license in SPDX and MODULE_LICENSE Changes in v4: * Code formatting Changes in v3: * Support for Huawei MBX * Style and formatting issues Ayman Bagabas (3): ALSA: hda: fix front speakers on Huawei MBXP. x86: add support for Huawei WMI hotkeys. ALSA: hda: add support for Huawei WMI micmute LED drivers/platform/x86/Kconfig | 17 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 208 ++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 22 ++++ 4 files changed, 248 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c -- 2.19.2

2 4

[alsa-devel] [PATCH v2] ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M
by Fabio Estevam 13 Dec '18

13 Dec '18

eukrea-tlv320.c machine driver runs on non-DT platforms and include <asm/mach-types.h> header file in order to be able to use some machine_is_eukrea_xxx() macros. Building it for ARM64 causes the following build error: sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory Avoid this error by not allowing to build the SND_SOC_EUKREA_TLV320 driver when ARM64 is selected. This is needed in preparation for the i.MX8M support. Reported-by: kbuild test robot <lkp(a)intel.com> Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- Changes since v1: - Drop the mention to the i.MX8M commit that is currently only in Shawn's tree. sound/soc/fsl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 6ec19fb..2e75b5b 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -221,7 +221,7 @@ config SND_SOC_PHYCORE_AC97 config SND_SOC_EUKREA_TLV320 tristate "Eukrea TLV320" - depends on ARCH_MXC && I2C + depends on ARCH_MXC && !ARM64 && I2C select SND_SOC_TLV320AIC23_I2C select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_SSI -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: simple-card: Dereference pointer for memcpy sizeof in asoc_simple_card_probe
by Nathan Chancellor 13 Dec '18

13 Dec '18

Clang warns: sound/soc/generic/simple-card.c:462:6: warning: argument to 'sizeof' in 'memcpy' call is the same pointer type 'struct asoc_simple_dai *' as the source; expected 'struct asoc_simple_dai' or an explicit length [-Wsizeof-pointer-memaccess] sizeof(priv->dai_props->cpu_dai)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/generic/simple-card.c:464:6: warning: argument to 'sizeof' in 'memcpy' call is the same pointer type 'struct asoc_simple_dai *' as the source; expected 'struct asoc_simple_dai' or an explicit length [-Wsizeof-pointer-memaccess] sizeof(priv->dai_props->codec_dai)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. Commit 4fb7f4df49d3 ("ASoC: simple-card: use cpu/codec pointer on simple_dai_props") updated {cpu,codec}_dai to be pointers in struct simple_dai_props but didn't update these locations to dereference the pointers to get the proper size of their contents. Signed-off-by: Nathan Chancellor <natechancellor(a)gmail.com> --- sound/soc/generic/simple-card.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 766123485d7c..d4738d3eb2f1 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -459,9 +459,9 @@ static int asoc_simple_card_probe(struct platform_device *pdev) dai_link->dai_fmt = cinfo->daifmt; dai_link->init = asoc_simple_card_dai_init; memcpy(&priv->dai_props->cpu_dai, &cinfo->cpu_dai, - sizeof(priv->dai_props->cpu_dai)); + sizeof(*priv->dai_props->cpu_dai)); memcpy(&priv->dai_props->codec_dai, &cinfo->codec_dai, - sizeof(priv->dai_props->codec_dai)); + sizeof(*priv->dai_props->codec_dai)); } snd_soc_card_set_drvdata(card, priv); -- 2.20.0

2 2

[alsa-devel] [PATCH] ALSA: pcm: Fix potential Spectre v1 vulnerability
by Gustavo A. R. Silva 12 Dec '18

12 Dec '18

stream is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: sound/core/pcm.c:140 snd_pcm_control_ioctl() warn: potential spectre issue 'pcm->streams' [r] (local cap) Fix this by sanitizing stream before using it to index pcm->streams Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1]. [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2 Cc: stable(a)vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/core/pcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/core/pcm.c b/sound/core/pcm.c index fdb9b92fc8d6..23141003a90d 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -32,6 +32,8 @@ #include <sound/control.h> #include <sound/info.h> +#include <linux/nospec.h> + #include "pcm_local.h" MODULE_AUTHOR("Jaroslav Kysela <perex(a)perex.cz>, Abramo Bagnara <abramo(a)alsa-project.org>"); @@ -129,6 +131,7 @@ static int snd_pcm_control_ioctl(struct snd_card *card, return -EFAULT; if (stream < 0 || stream > 1) return -EINVAL; + stream = array_index_nospec(stream, 2); if (get_user(subdevice, &info->subdevice)) return -EFAULT; mutex_lock(&register_mutex); -- 2.17.1

3 2

[alsa-devel] [PATCH] alsa-oss: fix FTBFS with glibc v2.28
by GitHub pull_request - opened 12 Dec '18

12 Dec '18

alsa-project/alsa-oss pull request #1 was opened from takaswie: In glibc upstream, libio/libio.h had been deprecated for applications and became internal header in its v2.28 release. We can see below message in its release note[1]. * The nonstandard header files <libio.h> and <_G_config.h> are no longer installed. Software that was using either header should be updated to use standard <stdio.h> interfaces instead. This brings FTBFS with glibc v2.28 due to missing <libio.h>. This commit fixes it. [1] https://www.sourceware.org/ml/libc-alpha/2018-08/msg00003.html Reported-by: Adrian Bunk <bunk(a)debian.org> Reference: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916052 Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ``` --- alsa/stdioemu.c | 1 - 1 file changed, 1 deletion(-) ``` Request URL : https://github.com/alsa-project/alsa-oss/pull/1 Patch URL : https://github.com/alsa-project/alsa-oss/pull/1.patch Repository URL: https://github.com/alsa-project/alsa-oss

1 0

[alsa-devel] [PATCH] ALSA: emux_hwdep: Fix potential Spectre v1 vulnerabilities
by Gustavo A. R. Silva 12 Dec '18

12 Dec '18

info.mode and info.port are indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. These issues were detected with the help of Smatch: sound/synth/emux/emux_hwdep.c:72 snd_emux_hwdep_misc_mode() warn: potential spectre issue 'emu->portptrs[i]->ctrls' [w] (local cap) sound/synth/emux/emux_hwdep.c:75 snd_emux_hwdep_misc_mode() warn: potential spectre issue 'emu->portptrs' [w] (local cap) sound/synth/emux/emux_hwdep.c:75 snd_emux_hwdep_misc_mode() warn: potential spectre issue 'emu->portptrs[info.port]->ctrls' [w] (local cap) Fix this by sanitizing both info.mode and info.port before using them to index emu->portptrs[i]->ctrls, emu->portptrs[info.port]->ctrls and emu->portptrs. Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1]. [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2 Cc: stable(a)vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/synth/emux/emux_hwdep.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/synth/emux/emux_hwdep.c b/sound/synth/emux/emux_hwdep.c index e557946718a9..a0d5cd99572f 100644 --- a/sound/synth/emux/emux_hwdep.c +++ b/sound/synth/emux/emux_hwdep.c @@ -24,6 +24,7 @@ #include <linux/uaccess.h> #include "emux_voice.h" +#include <linux/nospec.h> #define TMP_CLIENT_ID 0x1001 @@ -66,13 +67,16 @@ snd_emux_hwdep_misc_mode(struct snd_emux *emu, void __user *arg) return -EFAULT; if (info.mode < 0 || info.mode >= EMUX_MD_END) return -EINVAL; + info.mode = array_index_nospec(info.mode, EMUX_MD_END); if (info.port < 0) { for (i = 0; i < emu->num_ports; i++) emu->portptrs[i]->ctrls[info.mode] = info.value; } else { - if (info.port < emu->num_ports) + if (info.port < emu->num_ports) { + info.port = array_index_nospec(info.port, emu->num_ports); emu->portptrs[info.port]->ctrls[info.mode] = info.value; + } } return 0; } -- 2.17.1

3 2

[alsa-devel] [PATCH v10 0/3] Huawei laptops
by Ayman Bagabas 12 Dec '18

12 Dec '18

This patch set is based on the new audio LED triggers in topic/leds-trigger branch from git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Changes in v10: * Use ec_get_handle instead of acpi_get_handle since we are using the ec device * Switch to WMI0_EXPENSIVE_GUID and wmi_query_block to fetch keycode when WMI0 is used Changes in v9: * Explicitly use NULL in acpi_get_handle * Drop __initconst from huawei_wmi_keymap Changes in v8: * Switch to wmi_driver * Use devm to allocate and manage devices * Skip registering LED subsystem if a ACPI controller method was not found Changes in v7: * Use audio LED triggers patch set * Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1. In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome. Changes in v6: * Review tags Changes in v5: * Consistency in file names * How module would be enabled (Kconfig) * Match license in SPDX and MODULE_LICENSE Changes in v4: * Code formatting Changes in v3: * Support for Huawei MBX * Style and formatting issues Ayman Bagabas (3): ALSA: hda: fix front speakers on Huawei MBXP. x86: add support for Huawei WMI hotkeys. ALSA: hda: add support for Huawei WMI micmute LED drivers/platform/x86/Kconfig | 17 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 220 ++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 22 +++ 4 files changed, 260 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c -- 2.19.2

4 10

[alsa-devel] [PATCH 0/6] ASoC: merge audio-graph-scu into audio-graph - final step
by Kuninori Morimoto 12 Dec '18

12 Dec '18

Hi Mark audio-graph card can handle normal sound card, and audio-graph-scu card can handle DPCM sound card. But, we can't use these feature in same time now. This is final step patches. Kuninori Morimoto (6): ASoC: audio-graph-card: merge audio-graph-scu-card on Doc ASoC: audio-graph-card: merge audio-graph-scu-card ASoC: audio-graph-card: tidyup mclk-fs method ASoC: audio-graph-card: tidyup convert_rate/channel method ASoC: audio-graph-scu-card: remove audio-graph-scu-card on Doc ASoC: audio-graph-scu-card: remove audio-graph-scu-card .../devicetree/bindings/sound/audio-graph-card.txt | 222 +++++++++ .../bindings/sound/audio-graph-scu-card.txt | 123 ----- sound/soc/generic/Kconfig | 10 +- sound/soc/generic/Makefile | 2 - sound/soc/generic/audio-graph-card.c | 397 +++++++++++++--- sound/soc/generic/audio-graph-scu-card.c | 501 --------------------- 6 files changed, 563 insertions(+), 692 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/audio-graph-scu-card.txt delete mode 100644 sound/soc/generic/audio-graph-scu-card.c -- 2.7.4

1 7